Skip to content
  • darin@apple.com's avatar
    WebCore: · 445c34f5
    darin@apple.com authored
    2009-07-30  Darin Adler  <darin@apple.com>
    
            Reviewed by David Levin.
    
            Use checked casts for render tree
            https://bugs.webkit.org/show_bug.cgi?id=23522
    
            Next step: Add casts for all the RenderTable classes and use them everywhere.
    
            Also added a few uses in places that were still using static_cast.
            Also made some virtual member functions private.
            Also changed RenderTable::m_tableLayout to use OwnPtr.
    
            * accessibility/AccessibilityTable.cpp:
            (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
            (WebCore::AccessibilityTable::addChildren):
            (WebCore::AccessibilityTable::cellForColumnAndRow):
            * accessibility/AccessibilityTableCell.cpp:
            (WebCore::AccessibilityTableCell::parentTable):
            (WebCore::AccessibilityTableCell::rowIndexRange):
            (WebCore::AccessibilityTableCell::columnIndexRange):
            (WebCore::AccessibilityTableCell::titleUIElement):
            * accessibility/AccessibilityTableColumn.cpp:
            (WebCore::AccessibilityTableColumn::headerObject):
            * accessibility/AccessibilityTableRow.cpp:
            (WebCore::AccessibilityTableRow::parentTable):
            * editing/DeleteSelectionCommand.cpp:
            (WebCore::DeleteSelectionCommand::removeNode):
            * editing/TextIterator.cpp:
            (WebCore::shouldEmitTabBeforeNode):
            (WebCore::shouldEmitNewlinesBeforeAndAfterNode):
            * html/HTMLTableCellElement.cpp:
            (WebCore::HTMLTableCellElement::parseMappedAttribute):
            * html/HTMLTableColElement.cpp:
            (WebCore::HTMLTableColElement::parseMappedAttribute):
            * page/Frame.cpp:
            (WebCore::Frame::searchForLabelsAboveCell):
            * page/mac/FrameMac.mm:
            (WebCore::Frame::searchForNSLabelsAboveCell):
            * rendering/AutoTableLayout.cpp:
            (WebCore::AutoTableLayout::recalcColumn):
            (WebCore::AutoTableLayout::fullRecalc):
            (WebCore::shouldScaleColumns):
            * rendering/FixedTableLayout.cpp:
            (WebCore::FixedTableLayout::calcWidthArray):
            * rendering/RenderBlock.cpp:
            (WebCore::RenderBlock::calcPrefWidths):
            * rendering/RenderBox.cpp:
            (WebCore::RenderBox::calcPercentageHeight):
            * rendering/RenderObject.cpp:
            (WebCore::RenderObject::addChild):
            (WebCore::RenderObject::containingBlock):
            * rendering/RenderTableCell.cpp:
            (WebCore::RenderTableCell::collapsedBottomBorder):
            * rendering/RenderTableCol.cpp:
            (WebCore::RenderTableCol::table):
            * rendering/RenderTableRow.cpp:
            (WebCore::RenderTableRow::addChild):
            (WebCore::RenderTableRow::layout):
            (WebCore::RenderTableRow::paint):
            * rendering/RenderTableSection.cpp:
            (WebCore::RenderTableSection::addChild):
            (WebCore::RenderTableSection::layoutRows):
            (WebCore::RenderTableSection::lowestPosition):
            (WebCore::RenderTableSection::rightmostPosition):
            (WebCore::RenderTableSection::leftmostPosition):
            (WebCore::RenderTableSection::paintObject):
            (WebCore::RenderTableSection::recalcCells):
            * rendering/RenderTreeAsText.cpp:
            (WebCore::operator<<):
            (WebCore::writeTextRun):
            Use checked casts.
    
            * rendering/RenderTable.cpp:
            (WebCore::RenderTable::styleDidChange): Updated to use OwnPtr.
            (WebCore::RenderTable::addChild): Use checked cast.
            (WebCore::RenderTable::layout): Ditto.
            (WebCore::RenderTable::setCellWidths): Ditto.
            (WebCore::RenderTable::paintObject): Ditto.
            (WebCore::RenderTable::splitColumn): Ditto.
            (WebCore::RenderTable::appendColumn): Ditto.
            (WebCore::RenderTable::colElement): Ditto.
            (WebCore::RenderTable::recalcSections): Ditto.
            (WebCore::RenderTable::outerBorderBottom): Ditto.
            (WebCore::RenderTable::outerBorderLeft): Ditto.
            (WebCore::RenderTable::outerBorderRight): Ditto.
            (WebCore::RenderTable::sectionAbove): Ditto.
            (WebCore::RenderTable::sectionBelow): Ditto.
    
            * rendering/RenderTable.h: Added checked cast. Made virtual
            functions private. Changed m_tableLayout to be a OwnPtr.
    
            * rendering/RenderTableCell.h: Added checked cast.
            * rendering/RenderTableCol.h: Ditto. Made virtual functions private.
            * rendering/RenderTableRow.h: Ditto.
            * rendering/RenderTableSection.h: Ditto.
    
    WebKit/mac:
    
    2009-07-30  Darin Adler  <darin@apple.com>
    
            Reviewed by David Levin.
    
            Use checked casts for render tree
            https://bugs.webkit.org/show_bug.cgi?id=23522
    
            * Misc/WebNSAttributedStringExtras.mm:
            (fileWrapperForElement):
            * Misc/WebNSPasteboardExtras.mm:
            (imageFromElement):
            (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
            * WebView/WebFrame.mm:
            (-[WebFrame _computePageRectsWithPrintWidthScaleFactor:printHeight:]):
            (-[WebFrame _accessibilityTree]):
            * WebView/WebRenderNode.mm:
            (copyRenderNode):
            Use checked casts.
    
    WebKit/win:
    
    2009-07-30  Darin Adler  <darin@apple.com>
    
            Reviewed by David Levin.
    
            Use checked casts for render tree
            https://bugs.webkit.org/show_bug.cgi?id=23522
    
            * DOMHTMLClasses.cpp:
            (DOMHTMLInputElement::isUserEdited):
            (DOMHTMLTextAreaElement::isUserEdited):
            Use checked casts.
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46647 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    445c34f5