Skip to content
  • jamesr@google.com's avatar
    [chromium] Convert WebAnimationCurve subtypes into pure virtual · f732c304
    jamesr@google.com authored
    https://bugs.webkit.org/show_bug.cgi?id=94068
    
    Reviewed by Adrienne Walker.
    
    Source/Platform:
    
    This makes the Web*AnimationCurve interfaces pure virtual to provide better insulation from the implementation
    details of the classes.
    
    * chromium/public/WebAnimation.h:
    (WebKit::WebAnimation::WebAnimation):
    (WebAnimation):
    * chromium/public/WebAnimationCurve.h:
    * chromium/public/WebFloatAnimationCurve.h:
    (WebFloatAnimationCurve):
    (WebKit::WebFloatAnimationCurve::~WebFloatAnimationCurve):
    * chromium/public/WebTransformAnimationCurve.h:
    (WebTransformAnimationCurve):
    (WebKit::WebTransformAnimationCurve::~WebTransformAnimationCurve):
    
    Source/WebCore:
    
    Updates users of the Web*AnimationCurve interface for its new pointery goodness.
    
    * platform/graphics/chromium/AnimationTranslationUtil.cpp:
    (WebCore::appendKeyframeWithStandardTimingFunction):
    (WebCore::appendKeyframeWithCustomBezierTimingFunction):
    (WebCore::WebTransformAnimationCurve):
    (WebCore::createWebAnimation):
    
    Source/WebKit/chromium:
    
    Updates the implementations, some callers and tests of Web*AnimationCurve to its new interface.
    
    * WebKit.gyp:
    * src/WebAnimation.cpp:
    (WebKit::WebAnimation::initialize):
    * src/WebFloatAnimationCurveImpl.cpp: Renamed from Source/WebKit/chromium/src/WebFloatAnimationCurve.cpp.
    (WebKit):
    (WebKit::WebFloatAnimationCurve::create):
    (WebKit::WebFloatAnimationCurveImpl::WebFloatAnimationCurveImpl):
    (WebKit::WebFloatAnimationCurveImpl::~WebFloatAnimationCurveImpl):
    (WebKit::WebFloatAnimationCurveImpl::type):
    (WebKit::WebFloatAnimationCurveImpl::add):
    (WebKit::WebFloatAnimationCurveImpl::getValue):
    (WebKit::WebFloatAnimationCurveImpl::cloneToCCAnimationCurve):
    * src/WebTransformAnimationCurve.cpp: Removed.
    * tests/WebAnimationTest.cpp:
    (WebKit::TEST):
    * tests/WebFloatAnimationCurveTest.cpp:
    (WebKit::TEST):
    * tests/WebTransformAnimationCurveTest.cpp:
    (WebKit::TEST):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126513 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    f732c304