Skip to content
  • commit-queue@webkit.org's avatar
    [Blackberry] Static code analysis warning fixes · 3eefa319
    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=105129
    
    Patch by Anthony Scian <ascian@rim.com> on 2012-12-17
    Reviewed by Rob Buis.
    
    Source/WebCore:
    
    - alloca can return NULL, recoded to just use a temp var
    
    * plugins/blackberry/PluginViewBlackBerry.cpp:
    (WebCore::PluginView::updateBuffer):
    
    Source/WebKit/blackberry:
    
    - disable copy/op= in BackingStore
    - cache and check intermediate values in parentLayer
    - disable copy/op= in InRegionScroller
    - disable copy/op= in WebPageGroupLoadDeferrer
    - disable copy/op= in WebSettings
    - disable copy/op= in WebViewportArguments
    - disable copy/op= in BackingStoreClient
    - disable copy/op= in TileBuffer
    - if stopNode is not NULL, loop could iterate past NULL; added NULL check to loop
      to make the code more robust
    
    * Api/BackingStore.h:
    * Api/InRegionScroller.cpp:
    (BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):
    (BlackBerry::WebKit::parentLayer):
    * Api/InRegionScroller.h:
    * Api/WebPageGroupLoadDeferrer.h:
    * Api/WebSettings.h:
    * Api/WebViewportArguments.h:
    * WebKitSupport/BackingStoreClient.h:
    (BackingStoreClient):
    * WebKitSupport/BackingStoreTile.h:
    (TileBuffer):
    * WebKitSupport/DOMSupport.cpp:
    (BlackBerry::WebKit::DOMSupport::visibleTextQuads):
    
    Tools:
    
    Added null checks for fopen calls, no recovery attempted; access fault prevention only.
    
    * DumpRenderTree/blackberry/DumpRenderTree.cpp:
    (BlackBerry::WebKit::createFile):
    (BlackBerry::WebKit::DumpRenderTree::runTest):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137908 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    3eefa319