-
commit-queue@webkit.org authored
Reviewed by Steve Block. [chromium] Port test shell geolocation fixes to DRT https://bugs.webkit.org/show_bug.cgi?id=45313 Remove exceptions for tests that now pass (in DRT and downstream test_shell) * platform/chromium/drt_expectations.txt: * platform/chromium/test_expectations.txt: 2010-09-13 Jonathan Dixon <joth@chromium.org> Reviewed by Steve Block. [chromium] Port test shell geolocation fixes to DRT https://bugs.webkit.org/show_bug.cgi?id=45313 Also re-apply rolled out patch http://trac.webkit.org/changeset/66886 :- Add missing virtual destructor to the abstract base class. * platform/chromium/GeolocationServiceChromium.cpp: (WebCore::GeolocationServiceBridge::~GeolocationServiceBridge): * platform/chromium/GeolocationServiceChromium.h: 2010-09-13 Jonathan Dixon <joth@chromium.org> Reviewed by Steve Block. [chromium] Port test shell geolocation fixes to DRT https://bugs.webkit.org/show_bug.cgi?id=45313 Ports over fixes from test shell: - http://codereview.chromium.org/3294007 - http://codereview.chromium.org/333800 Resets state between service instances, which fixes delayed-permission-allowed-for-multiple-requests.html Also re-apply rolled out patch http://trac.webkit.org/changeset/66886 :- Access to out-of-scope WebGeolocationServiceBridgeImpl https://bugs.webkit.org/show_bug.cgi?id=45112 Keep the WebGeolocationService pointer for lifetime of the bridge, to ensure it can be detached reliably Includes follow-up review comment to rename onWebGeolocationServiceDestroyed to didDestroyGeolocationService * public/WebGeolocationService.h: (WebKit::WebGeolocationService::~WebGeolocationService): * public/WebGeolocationServiceBridge.h: (WebKit::WebGeolocationServiceBridge::onWebGeolocationServiceDestroyed): * public/WebGeolocationServiceMock.h: * src/WebGeolocationServiceBridgeImpl.cpp: (WebKit::WebGeolocationServiceBridgeImpl::WebGeolocationServiceBridgeImpl): (WebKit::WebGeolocationServiceBridgeImpl::~WebGeolocationServiceBridgeImpl): (WebKit::WebGeolocationServiceBridgeImpl::startUpdating): (WebKit::WebGeolocationServiceBridgeImpl::stopUpdating): (WebKit::WebGeolocationServiceBridgeImpl::suspend): (WebKit::WebGeolocationServiceBridgeImpl::resume): (WebKit::WebGeolocationServiceBridgeImpl::attachBridgeIfNeeded): (WebKit::WebGeolocationServiceBridgeImpl::setIsAllowed): (WebKit::WebGeolocationServiceBridgeImpl::setLastPosition): (WebKit::WebGeolocationServiceBridgeImpl::setLastError): (WebKit::WebGeolocationServiceBridgeImpl::didDestroyGeolocationService): (WebKit::WebGeolocationServiceBridgeImpl::isAttached): * src/WebGeolocationServiceMock.cpp: (WebKit::WebGeolocationServiceMock::setMockGeolocationPermission): (WebKit::WebGeolocationServiceMockImpl::WebGeolocationServiceMockImpl): (WebKit::WebGeolocationServiceMockImpl::~WebGeolocationServiceMockImpl): (WebKit::WebGeolocationServiceMockImpl::setMockGeolocationPermission): (WebKit::WebGeolocationServiceMockImpl::requestPermissionForFrame): (WebKit::WebGeolocationServiceMockImpl::notifyPendingPermissions): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@67387 268f45cc-cd09-0410-ab3c-d52691b4dbfc
3ec81dfb