Skip to content
  • jochen@chromium.org's avatar
    Source/WebCore: Rename FrameLoaderClient::allowImages to... · 3eb74cd7
    jochen@chromium.org authored
    Source/WebCore: Rename FrameLoaderClient::allowImages to FrameLoaderClient::allowImage and include the image URL as parameter
    https://bugs.webkit.org/show_bug.cgi?id=68071
    
    This will allow embedders to block images based on where the image is loaded from, instead of just blocking all images in a given frame.
    
    Reviewed by Adam Barth.
    
    * html/ImageDocument.cpp:
    (WebCore::ImageDocumentParser::appendBytes):
    * loader/FrameLoaderClient.h:
    (WebCore::FrameLoaderClient::allowImage):
    * loader/cache/CachedResourceLoader.cpp:
    (WebCore::CachedResourceLoader::requestImage):
    
    Source/WebKit/chromium: Rename FrameLoaderClient::allowImages to FrameLoaderClient::allowImage and include the image URL as parameter
    https://bugs.webkit.org/show_bug.cgi?id=68071
    
    Reviewed by Adam Barth.
    
    * public/WebPermissionClient.h:
    (WebKit::WebPermissionClient::allowImage):
    * src/FrameLoaderClientImpl.cpp:
    (WebKit::FrameLoaderClientImpl::allowImage):
    * src/FrameLoaderClientImpl.h:
    
    Tools: Rename FrameLoaderClient::allowImages to FrameLoaderClient::allowImage and include the image URL as parameter
    https://bugs.webkit.org/show_bug.cgi?id=68071
    
    Reviewed by Adam Barth.
    
    * DumpRenderTree/chromium/WebPermissions.cpp:
    (WebPermissions::allowImage):
    * DumpRenderTree/chromium/WebPermissions.h:
    
    LayoutTests: Add tests for FrameLoaderClient::allowImage.
    https://bugs.webkit.org/show_bug.cgi?id=68071
    
    Reviewed by Adam Barth.
    
    * http/tests/permissionclient/resources/bostin.gif:
    * http/tests/permissionclient/resources/redir.php:
    * platform/chromium/permissionclient/image-permissions-expected.txt:
    * platform/chromium/permissionclient/image-permissions.html:
    * platform/http/tests/permissionclient/image-permissions-expected.txt:
    * platform/http/tests/permissionclient/image-permissions.html:
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95369 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    3eb74cd7