Skip to content
  • joepeck@webkit.org's avatar
    2010-04-27 Joseph Pecoraro <joepeck@webkit.org> · 23e346c7
    joepeck@webkit.org authored
            Reviewed by Dan Bernstein.
    
            <input type="search"> with uneven padding causes text clipping
            https://bugs.webkit.org/show_bug.cgi?id=38160
    
            * fast/css/input-search-padding.html: Added.
            * platform/mac/fast/css/input-search-padding-expected.checksum: Added.
            * platform/mac/fast/css/input-search-padding-expected.png: Added.
            * platform/mac/fast/css/input-search-padding-expected.txt: Added.
    
    2010-04-27  Joseph Pecoraro  <joepeck@webkit.org>
    
            Reviewed by Dan Bernstein.
    
            <input type="search"> with uneven padding causes text clipping
            https://bugs.webkit.org/show_bug.cgi?id=38160
    
            Test: fast/css/input-search-padding.html
    
            An <input type="search"> contains an inner block, which is explicitly
            centered in RenderTextControlSingleLine based on the height of the element.
            However, the clipping rect was not using the set location, and instead
            calculated off of the top border and padding alone. This also vertically
            centers the Caps Lock indicator.
    
            * rendering/RenderTextControl.cpp: moved controlClipRect implementation to RenderTextControlSingleLine
            * rendering/RenderTextControl.h: allow a subclass implementation of controlClipRect, removed redundant hasControlClip implementation, and moved controlClipRect
            * rendering/RenderTextControlSingleLine.cpp:
            (WebCore::RenderTextControlSingleLine::paint): vertically center the Caps Lock indicator
            (WebCore::RenderTextControlSingleLine::controlClipRect): use the set location of the anonymous inner block instead
            * rendering/RenderTextControlSingleLine.h: allow for an implementation of controlClipRect for <input type="search">
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58313 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    23e346c7