Skip to content
  • timothy@apple.com's avatar
    Add support for dock-to-right of the Web Inspector in the Mac port. · 3e6451ee
    timothy@apple.com authored
    Unfortunately this requires Safari changes, so it is disabled in the nightly builds.
    
    https://webkit.org/b/113341
    rdar://problem/10368152
    
    Reviewed by Joseph Pecoraro.
    
    .:
    
    * Source/autotools/symbols.filter:
    
    Source/WebCore:
    
    * WebCore.exp.in:
    * inspector/InspectorFrontendClient.h:
    (InspectorFrontendClient):
    * inspector/InspectorFrontendClientLocal.cpp:
    (WebCore):
    (WebCore::InspectorFrontendClientLocal::frontendLoaded):
    (WebCore::InspectorFrontendClientLocal::requestSetDockSide):
    (WebCore::InspectorFrontendClientLocal::canAttachWindow):
    (WebCore::InspectorFrontendClientLocal::changeAttachedWindowWidth):
    (WebCore::InspectorFrontendClientLocal::setAttachedWindow):
    (WebCore::InspectorFrontendClientLocal::constrainedAttachedWindowWidth):
    * inspector/InspectorFrontendClientLocal.h:
    (InspectorFrontendClientLocal):
    * inspector/InspectorFrontendHost.cpp:
    (WebCore::InspectorFrontendHost::setAttachedWindowWidth):
    (WebCore):
    * inspector/InspectorFrontendHost.h:
    (InspectorFrontendHost):
    * inspector/InspectorFrontendHost.idl:
    * inspector/front-end/InspectorFrontendHostStub.js:
    (.WebInspector.InspectorFrontendHostStub.prototype.setAttachedWindowWidth):
    * inspector/front-end/externs.js:
    (InspectorFrontendHostAPI.prototype.setAttachedWindowWidth):
    * testing/Internals.cpp:
    
    Source/WebKit/chromium:
    
    * src/InspectorFrontendClientImpl.cpp:
    (WebKit::InspectorFrontendClientImpl::changeAttachedWindowWidth):
    * src/InspectorFrontendClientImpl.h:
    (InspectorFrontendClientImpl):
    
    Source/WebKit/efl:
    
    * WebCoreSupport/InspectorClientEfl.cpp:
    (WebCore::InspectorFrontendClientEfl::attachWindow):
    (WebCore::InspectorFrontendClientEfl::setAttachedWindowWidth):
    * WebCoreSupport/InspectorClientEfl.h:
    (InspectorFrontendClientEfl):
    
    Source/WebKit/gtk:
    
    * WebCoreSupport/InspectorClientGtk.cpp:
    (WebKit::InspectorFrontendClient::attachWindow):
    (WebKit::InspectorFrontendClient::setAttachedWindowWidth):
    * WebCoreSupport/InspectorClientGtk.h:
    (InspectorFrontendClient):
    
    Source/WebKit/mac:
    
    * Resources/Dock.pdf: Updated.
    * WebCoreSupport/WebInspectorClient.h:
    (WebInspectorFrontendClient):
    * WebCoreSupport/WebInspectorClient.mm:
    (WebInspectorFrontendClient::frontendLoaded):
    (WebInspectorFrontendClient::attachWindow):
    (WebInspectorFrontendClient::setAttachedWindowWidth):
    (-[WebInspectorWindowController attachWindow:]):
    (-[WebInspectorWindowController attach]):
    (-[WebInspectorWindowController detach]):
    * WebInspector/WebInspectorFrontend.mm:
    (-[WebInspectorFrontend attach]):
    
    Source/WebKit/qt:
    
    * WebCoreSupport/InspectorClientQt.cpp:
    (WebCore::InspectorFrontendClientQt::frontendLoaded):
    (WebCore::InspectorFrontendClientQt::attachWindow):
    (WebCore::InspectorFrontendClientQt::setAttachedWindowWidth):
    * WebCoreSupport/InspectorClientQt.h:
    (InspectorFrontendClientQt):
    
    Source/WebKit/win:
    
    * WebCoreSupport/WebInspectorClient.cpp:
    (WebInspectorFrontendClient::frontendLoaded):
    (WebInspectorFrontendClient::attachWindow):
    (WebInspectorFrontendClient::setAttachedWindowWidth):
    * WebCoreSupport/WebInspectorClient.h:
    (WebInspectorFrontendClient):
    
    Source/WebKit2:
    
    * Resources/Dock.pdf: Removed.
    * Resources/DockBottom.pdf: Added.
    * Resources/DockRight.pdf: Added.
    * Shared/WebPreferencesStore.h:
    * UIProcess/WebInspectorProxy.cpp:
    (WebKit::WebInspectorProxy::WebInspectorProxy):
    (WebKit::WebInspectorProxy::attachBottom):
    (WebKit::WebInspectorProxy::attachRight):
    (WebKit::WebInspectorProxy::attach):
    (WebKit::WebInspectorProxy::detach):
    (WebKit::WebInspectorProxy::setAttachedWindowWidth):
    (WebKit::WebInspectorProxy::createInspectorPage):
    (WebKit::WebInspectorProxy::canAttach):
    * UIProcess/WebInspectorProxy.h:
    (WebInspectorProxy):
    * UIProcess/WebInspectorProxy.messages.in:
    * UIProcess/mac/WebInspectorProxyMac.mm:
    (-[WKWebInspectorProxyObjCAdapter attachRight:]):
    (-[WKWebInspectorProxyObjCAdapter attachBottom:]):
    (-[WKWebInspectorWindow _cursorForResizeDirection:]):
    (-[WKWebInspectorWindow _customTitleFrame]):
    (WebKit::createDockButton):
    (WebKit::WebInspectorProxy::createInspectorWindow):
    (WebKit::WebInspectorProxy::platformCreateInspectorPage):
    (WebKit::WebInspectorProxy::platformAttachAvailabilityChanged):
    (WebKit::WebInspectorProxy::inspectedViewFrameDidChange):
    (WebKit::WebInspectorProxy::platformInspectedWindowWidth):
    (WebKit::WebInspectorProxy::platformAttach):
    (WebKit::WebInspectorProxy::platformDetach):
    (WebKit::WebInspectorProxy::platformSetAttachedWindowHeight):
    (WebKit::WebInspectorProxy::platformSetAttachedWindowWidth):
    * WebKit2.xcodeproj/project.pbxproj:
    * WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
    (WebKit::WebInspectorFrontendClient::attachWindow):
    (WebKit::WebInspectorFrontendClient::setAttachedWindowWidth):
    * WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:
    (WebInspectorFrontendClient):
    * WebProcess/WebPage/WebInspector.cpp:
    (WebKit::WebInspector::attachBottom):
    (WebKit::WebInspector::attachRight):
    (WebKit::WebInspector::setAttachedWindowWidth):
    (WebKit::WebInspector::attachedBottom):
    (WebKit::WebInspector::attachedRight):
    (WebKit::WebInspector::detached):
    * WebProcess/WebPage/WebInspector.h:
    (WebInspector):
    * WebProcess/WebPage/WebInspector.messages.in:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147004 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    3e6451ee