Skip to content
  • abarth@webkit.org's avatar
    ENABLE(UNDO_MANAGER) is disabled everywhere and is not under active development · 3df3cc9a
    abarth@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=100711
    
    Reviewed by Eric Seidel.
    
    .: 
    
    * Source/cmake/WebKitFeatures.cmake:
    * Source/cmakeconfig.h.cmake:
    
    Source/JavaScriptCore: 
    
    * Configurations/FeatureDefines.xcconfig:
    
    Source/WebCore: 
    
    No one is actively working on ENABLE(UNDO_MANAGER). There are some
    tricky lifetime issues in the UndoManager API that are complicating
    ongoing work to improve the interaction between WebCore and the garbage
    collector. Rather than leave this code in a broken state, we should
    remove it for the time being. We can always restore it from the svn
    history when there is an active owner for this code.
    
    * CMakeLists.txt:
    * Configurations/FeatureDefines.xcconfig:
    * DerivedSources.cpp:
    * DerivedSources.make:
    * DerivedSources.pri:
    * GNUmakefile.features.am:
    * GNUmakefile.list.am:
    * Target.pri:
    * UseJSC.cmake:
    * UseV8.cmake:
    * WebCore.gypi:
    * WebCore.vcproj/WebCore.vcproj:
    * WebCore.xcodeproj/project.pbxproj:
    * bindings/js/DOMTransaction.cpp: Removed.
    * bindings/js/DOMTransaction.h: Removed.
    * bindings/js/JSBindingsAllInOne.cpp:
    * bindings/js/JSUndoManagerCustom.cpp: Removed.
    * bindings/v8/DOMTransaction.cpp: Removed.
    * bindings/v8/DOMTransaction.h: Removed.
    * bindings/v8/V8HiddenPropertyName.h:
    (WebCore):
    * bindings/v8/custom/V8DOMTransactionCustom.cpp: Removed.
    * bindings/v8/custom/V8UndoManagerCustom.cpp: Removed.
    * css/PropertySetCSSStyleDeclaration.cpp:
    (WebCore::PropertySetCSSStyleDeclaration::setCssText):
    (WebCore::PropertySetCSSStyleDeclaration::setProperty):
    (WebCore::PropertySetCSSStyleDeclaration::removeProperty):
    (WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):
    * dom/CharacterData.cpp:
    (WebCore::CharacterData::setDataAndUpdate):
    * dom/ContainerNode.cpp:
    (WebCore::willRemoveChild):
    (WebCore::willRemoveChildren):
    (WebCore::updateTreeAfterInsertion):
    * dom/Document.cpp:
    (WebCore::Document::Document):
    * dom/Document.h:
    (WebCore):
    (Document):
    * dom/Document.idl:
    * dom/Element.cpp:
    (WebCore::Element::willModifyAttribute):
    * editing/CompositeEditCommand.h:
    * editing/DOMTransaction.idl: Removed.
    * editing/DOMTransactionStep.cpp: Removed.
    * editing/DOMTransactionStep.h: Removed.
    * editing/Editor.cpp:
    (WebCore::Editor::appliedEditing):
    (WebCore::Editor::unappliedEditing):
    (WebCore::Editor::reappliedEditing):
    (WebCore::Editor::canUndo):
    (WebCore::Editor::undo):
    (WebCore::Editor::canRedo):
    (WebCore::Editor::redo):
    * editing/UndoManager.cpp: Removed.
    * editing/UndoManager.h: Removed.
    * editing/UndoManager.idl: Removed.
    * editing/UndoStep.h:
    (UndoStep):
    
    Source/WebKit/mac: 
    
    * Configurations/FeatureDefines.xcconfig:
    
    Source/WebKit2: 
    
    * Configurations/FeatureDefines.xcconfig:
    
    Tools: 
    
    * Scripts/webkitperl/FeatureList.pm:
    * qmake/mkspecs/features/features.pri:
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133326 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    3df3cc9a