Skip to content
  • abarth@webkit.org's avatar
    2011-01-21 Yury Semikhatsky <yurys@chromium.org> · 3a2486e3
    abarth@webkit.org authored
            Reviewed by Adam Barth.
    
            Regression: new window.onerror() implementation leaks cross-origin Javascript errors
            https://bugs.webkit.org/show_bug.cgi?id=52903
    
            In case of an exception in a script from different domain only generic message
            will be passed to window.onerror hander.
    
            Tests: http/tests/security/cross-origin-script-window-onerror-redirected.html
                   http/tests/security/cross-origin-script-window-onerror.html
    
            * bindings/js/CachedScriptSourceProvider.h: use URL from the resource response to make sure we do all
            cross origin checks agains real script URL, not the original URL which may have resulted in a sequence
            of redirects to different domains.
            (WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider):
            * bindings/v8/ScriptSourceCode.h: same for v8.
            (WebCore::ScriptSourceCode::url):
            * dom/ScriptExecutionContext.cpp:
            (WebCore::ScriptExecutionContext::dispatchErrorEvent): in case the error occurred in a script we cannot
            access provide concise "Script error." message without any information about the error source. This is
            what Firefox does in this case.
    2011-01-21  Yury Semikhatsky  <yurys@chromium.org>
    
            Reviewed by Adam Barth.
    
            Regression: new window.onerror() implementation leaks cross-origin Javascript errors
            https://bugs.webkit.org/show_bug.cgi?id=52903
    
            A couple of tests to check that window.onerror won't reveal any content of the resource
            from a different domain if the latter is referenced via <script src=...>
    
            * http/tests/security/cross-origin-script-window-onerror-expected.txt: Added.
            * http/tests/security/cross-origin-script-window-onerror-redirected-expected.txt: Added.
            * http/tests/security/cross-origin-script-window-onerror-redirected.html: Added.
            * http/tests/security/cross-origin-script-window-onerror.html: Added.
            * http/tests/security/resources/cross-origin-script.txt: Added.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76429 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    3a2486e3