Skip to content
  • jknotten@chromium.org's avatar
    2011-01-17 John Knottenbelt <jknotten@chromium.org> · 390c2e34
    jknotten@chromium.org authored
            Reviewed by Jeremy Orlow.
    
            GeolocationController should call stopUpdating on destruction
            https://bugs.webkit.org/show_bug.cgi?id=52216
    
            fast/dom/window-close-crash.html tests that we do not fail the
            assertion in the mock GeolocationClient that the GeolocationClient
            is not updating when the GeolocationController is destroyed.
    
            * fast/dom/Geolocation/resources/window-close-popup.html: Added.
            * fast/dom/Geolocation/script-tests/window-close-crash.js: Added.
            (gotPosition):
            (waitForWindowToClose):
            (failedToCreateWatch):
            * fast/dom/Geolocation/window-close-crash-expected.txt: Added.
            * fast/dom/Geolocation/window-close-crash.html: Added.
            * platform/gtk/Skipped:
            * platform/mac-wk2/Skipped:
            * platform/qt-wk2/Skipped:
    2011-01-17  John Knottenbelt  <jknotten@chromium.org>
    
            Reviewed by Jeremy Orlow.
    
            GeolocationController should call stopUpdating on destruction
            https://bugs.webkit.org/show_bug.cgi?id=52216
    
            Test: fast/dom/Geolocation/window-close-crash.html
    
            * page/GeolocationController.cpp:
            (WebCore::GeolocationController::~GeolocationController):
    2011-01-17  John Knottenbelt  <jknotten@chromium.org>
    
            Reviewed by Jeremy Orlow.
    
            GeolocationController should call stopUpdating on destruction
            https://bugs.webkit.org/show_bug.cgi?id=52216
    
            fast/dom/Geolocation/window-close-crash.html requires that a
            Geolocation watch be started in a secondary window. Consequently,
            we need to allow geolocation permission and provide a mock
            geolocation position for the secondary window's
            GeolocationClientMock.
    
            * DumpRenderTree/chromium/LayoutTestController.cpp:
            (LayoutTestController::setGeolocationPermission):
            (LayoutTestController::setMockGeolocationPosition):
            (LayoutTestController::setMockGeolocationError):
            * DumpRenderTree/chromium/TestShell.h:
            (TestShell::windowList):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75934 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    390c2e34