Skip to content
  • commit-queue@webkit.org's avatar
    [chromium] Gesture recognizer fires taptype only every other touch · 384489d5
    commit-queue@webkit.org authored
    down/up sequence https://bugs.webkit.org/show_bug.cgi?id=68368
    
    Patch by Robert Kroeger <rjkroege@chromium.org> on 2011-09-19
    Reviewed by Adam Barth.
    
    Source/WebCore:
    
    The addition of doubletap detection to the gesture recognizer missed some of the
    outgoing edges in the recognizer state machine. This change simplifies the logic
    and handles all outgoing edges.
    
    * platform/chromium/GestureRecognizerChromium.cpp:
    (WebCore::GestureRecognizerChromium::GestureRecognizerChromium):
    (WebCore::GestureRecognizerChromium::isInSecondClickTimeWindow):
    (WebCore::GestureRecognizerChromium::updateValues):
    (WebCore::GestureRecognizerChromium::touchDown):
    (WebCore::GestureRecognizerChromium::click):
    * platform/chromium/GestureRecognizerChromium.h:
    
    Source/WebKit/chromium:
    
    The addition of doubletap detection to the gesture recognizer missed some of the
    outgoing edges in the recognizer state machine. Thsi change simplifies the logic
    and handles all outgoing edges.
    
    * tests/InnerGestureRecognizerTest.cpp:
    Additional tests added to ensure that all edges in the state
    machine are accounted for.
    (BuildablePlatformTouchEvent::BuildablePlatformTouchEvent):
    (SimulateAndTestFirstClick):
    (TEST_F):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95452 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    384489d5