Skip to content
  • commit-queue@webkit.org's avatar
    Unreviewed, rolling out r159337. · 37afb394
    commit-queue@webkit.org authored
    http://trac.webkit.org/changeset/159337
    https://bugs.webkit.org/show_bug.cgi?id=124423
    
    broke a bunch of fast/regions tests on EFL/GTK (Requested by
    philn on #webkit).
    
    Source/WebCore:
    
    * rendering/InlineFlowBox.cpp:
    (WebCore::InlineFlowBox::setLayoutOverflow):
    (WebCore::InlineFlowBox::setVisualOverflow):
    * rendering/InlineFlowBox.h:
    * rendering/RenderBlock.cpp:
    (WebCore::RenderBlock::addOverflowFromChildren):
    (WebCore::RenderBlock::paint):
    (WebCore::RenderBlock::paintObject):
    (WebCore::RenderBlock::estimateRegionRangeForBoxChild):
    (WebCore::RenderBlock::updateRegionRangeForBoxChild):
    * rendering/RenderBlockFlow.cpp:
    (WebCore::RenderBlockFlow::hasNextPage):
    (WebCore::RenderBlockFlow::relayoutForPagination):
    * rendering/RenderBlockLineLayout.cpp:
    (WebCore::RenderBlockFlow::positionNewFloatOnLine):
    * rendering/RenderBox.cpp:
    (WebCore::RenderBox::borderBoxRectInRegion):
    (WebCore::RenderBox::computeRectForRepaint):
    (WebCore::RenderBox::addLayoutOverflow):
    (WebCore::RenderBox::addVisualOverflow):
    (WebCore::RenderBox::isUnsplittableForPagination):
    (WebCore::RenderBox::overflowRectForPaintRejection):
    * rendering/RenderBox.h:
    * rendering/RenderBoxModelObject.cpp:
    (WebCore::RenderBoxModelObject::paintFillLayerExtended):
    * rendering/RenderBoxModelObject.h:
    * rendering/RenderBoxRegionInfo.h:
    (WebCore::RenderBoxRegionInfo::createOverflow):
    * rendering/RenderFlowThread.cpp:
    (WebCore::RenderFlowThread::paintFlowThreadPortionInRegion):
    (WebCore::RenderFlowThread::hitTestFlowThreadPortionInRegion):
    (WebCore::RenderFlowThread::checkRegionsWithStyling):
    (WebCore::RenderFlowThread::mapFromLocalToFlowThread):
    (WebCore::RenderFlowThread::mapFromFlowThreadToLocal):
    (WebCore::RenderFlowThread::addRegionsOverflowFromChild):
    (WebCore::CurrentRenderFlowThreadMaintainer::CurrentRenderFlowThreadMaintainer):
    * rendering/RenderFlowThread.h:
    * rendering/RenderLayer.cpp:
    (WebCore::RenderLayer::updateLayerPositions):
    (WebCore::expandClipRectForDescendantsAndReflection):
    (WebCore::RenderLayer::paintLayer):
    (WebCore::RenderLayer::paintLayerContents):
    (WebCore::RenderLayer::updatePaintingInfoForFragments):
    (WebCore::RenderLayer::paintForegroundForFragments):
    (WebCore::RenderLayer::hitTest):
    (WebCore::RenderLayer::hitTestLayer):
    (WebCore::RenderLayer::calculateClipRects):
    (WebCore::RenderLayer::parentClipRects):
    (WebCore::RenderLayer::calculateRects):
    (WebCore::RenderLayer::intersectsDamageRect):
    (WebCore::RenderLayer::repaintIncludingDescendants):
    * rendering/RenderLayer.h:
    * rendering/RenderLayerCompositor.cpp:
    (WebCore::RenderLayerCompositor::computeCompositingRequirements):
    * rendering/RenderListItem.cpp:
    (WebCore::RenderListItem::addOverflowFromChildren):
    * rendering/RenderMultiColumnSet.cpp:
    (WebCore::RenderMultiColumnSet::flowThreadPortionOverflowRect):
    (WebCore::RenderMultiColumnSet::repaintFlowThreadContent):
    * rendering/RenderMultiColumnSet.h:
    * rendering/RenderNamedFlowFragment.cpp:
    (WebCore::RenderNamedFlowFragment::createStyle):
    * rendering/RenderNamedFlowFragment.h:
    * rendering/RenderOverflow.h:
    * rendering/RenderRegion.cpp:
    (WebCore::RenderRegion::flowThreadPortionOverflowRect):
    (WebCore::RenderRegion::overflowRectForFlowThreadPortion):
    (WebCore::shouldPaintRegionContentsInPhase):
    (WebCore::RenderRegion::paintObject):
    (WebCore::RenderRegion::hitTestContents):
    (WebCore::RenderRegion::computeOverflowFromFlowThread):
    (WebCore::RenderRegion::repaintFlowThreadContent):
    (WebCore::RenderRegion::repaintFlowThreadContentRectangle):
    (WebCore::RenderRegion::insertedIntoTree):
    (WebCore::RenderRegion::ensureOverflowForBox):
    (WebCore::RenderRegion::rectFlowPortionForBox):
    (WebCore::RenderRegion::addLayoutOverflowForBox):
    (WebCore::RenderRegion::addVisualOverflowForBox):
    (WebCore::RenderRegion::layoutOverflowRectForBox):
    (WebCore::RenderRegion::visualOverflowRectForBox):
    (WebCore::RenderRegion::visualOverflowRectForBoxForPropagation):
    * rendering/RenderRegion.h:
    * rendering/RenderReplaced.cpp:
    (WebCore::RenderReplaced::shouldPaint):
    * rendering/RootInlineBox.cpp:
    (WebCore::RootInlineBox::paint):
    
    LayoutTests:
    
    * fast/regions/bottom-overflow-out-of-first-region-expected.html:
    * fast/regions/bottom-overflow-out-of-first-region.html:
    * fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005-expected.html:
    * fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005.html:
    * fast/regions/element-in-named-flow-absolute-from-fixed-expected.txt:
    * fast/regions/element-in-named-flow-fixed-from-absolute-expected.txt:
    * fast/regions/element-inflow-fixed-from-outflow-static-expected.txt:
    * fast/regions/element-outflow-static-from-inflow-fixed-expected.txt:
    * fast/regions/float-pushed-width-change-2-expected.html:
    * fast/regions/float-pushed-width-change-2.html:
    * fast/regions/float-pushed-width-change-expected.html:
    * fast/regions/float-pushed-width-change.html:
    * fast/regions/layers/dynamic-layer-added-with-no-layout-expected.txt: Removed.
    * fast/regions/layers/dynamic-layer-removed-with-no-layout-expected.txt: Removed.
    * fast/regions/layers/regions-promoted-to-layers-expected.txt: Removed.
    * fast/regions/layers/regions-promoted-to-layers-horizontal-bt-expected.txt: Removed.
    * fast/regions/layers/regions-promoted-to-layers-vertical-lr-expected.txt: Removed.
    * fast/regions/layers/regions-promoted-to-layers-vertical-rl-expected.txt: Removed.
    * fast/regions/outline-sides-in-region-expected.html:
    * fast/regions/outline-sides-in-region.html:
    * fast/regions/overflow-first-and-last-regions-expected.html: Removed.
    * fast/regions/overflow-first-and-last-regions-in-container-hidden-expected.html: Removed.
    * fast/regions/overflow-first-and-last-regions-in-container-hidden.html: Removed.
    * fast/regions/overflow-first-and-last-regions.html: Removed.
    * fast/regions/overflow-last-region-expected.html: Added.
    * fast/regions/overflow-last-region.html: Added.
    * fast/regions/overflow-nested-regions-expected.html: Removed.
    * fast/regions/overflow-nested-regions.html: Removed.
    * fast/regions/overflow-region-float-expected.html: Removed.
    * fast/regions/overflow-region-float.html: Removed.
    * fast/regions/overflow-region-inline-expected.html: Removed.
    * fast/regions/overflow-region-inline.html: Removed.
    * fast/regions/overflow-region-transform-expected.html: Removed.
    * fast/regions/overflow-region-transform.html: Removed.
    * fast/regions/overflow-scrollable-rotated-fragment-expected.html:
    * fast/regions/overflow-scrollable-rotated-fragment.html:
    * fast/regions/top-overflow-out-of-second-region-expected.html: Removed.
    * fast/regions/top-overflow-out-of-second-region.html:
    * fast/regions/webkit-flow-float-unable-to-push-expected.html:
    * fast/regions/webkit-flow-float-unable-to-push.html:
    * fast/repaint/increasing-region-content-height-expected.txt:
    * fast/repaint/increasing-region-content-height.html:
    * platform/gtk/fast/regions/text-region-split-vertical-rl-expected.txt: Added.
    * platform/mac-wk2/TestExpectations:
    * platform/mac/fast/regions/top-overflow-out-of-second-region-expected.png: Added.
    * platform/mac/fast/regions/top-overflow-out-of-second-region-expected.txt: Added.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159347 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    37afb394