Skip to content
  • commit-queue@webkit.org's avatar
    [BlackBerry] Improper initialization of ANGLEResources (resubmission) · 34165f2b
    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=114814
    
    Patch by Jonathan Feldstein <jfeldstein@blackberry.com> on 2013-04-18
    Reviewed by Yong Li, Rob Buis
    Internally reviewed by Maxim Mogilnitsky
    
    MaxDrawBuffers, OES_standard_derivatives, OES_EGL_image_external and ARB_texture_rectangle
    are initialized through the ShBuiltInResources function so these fields do not need to be
    set again in GraphicsContext3DBlackBerry.cpp. In addition, the extension flags should not
    be set to true without getExtension being called (Khronos WebGL specs, section 5.14.14.).
    In fact, as a direct result of these extensions being enabled prior to calling
    getExtension, a WebGL conformance suite test for GL_OES_standard_derivatives was failing.
    
    * platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:
    (WebCore::GraphicsContext3D::GraphicsContext3D):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148680 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    34165f2b