Skip to content
  • mihnea@adobe.com's avatar
    [CSSRegions] Consolidate use of RenderRegion::isValid · 33db4a62
    mihnea@adobe.com authored
    https://bugs.webkit.org/show_bug.cgi?id=113154
    
    Reviewed by David Hyatt.
    
    After https://bugs.webkit.org/show_bug.cgi?id=98752, the list of invalid regions is kept separately than the list of valid regions.
    A valid region has always a valid flow thread attached. We can use isValid() throughout the RenderRegion code
    instead of testing for both isValid() and m_flowThread.
    
    No new tests since there is no change is functionality, just code refactoring.
    
    * rendering/RenderNamedFlowThread.cpp:
    (WebCore::RenderNamedFlowThread::addRegionToNamedFlowThread): Added a new function to keep the code
    used in addRegionToThread and checkInvalidRegions.
    (WebCore::RenderNamedFlowThread::addRegionToThread):
    (WebCore::RenderNamedFlowThread::checkInvalidRegions):
    * rendering/RenderNamedFlowThread.h:
    * rendering/RenderRegion.cpp:
    (WebCore::RenderRegion::overflowRectForFlowThreadPortion):
    (WebCore::RenderRegion::isFirstRegion):
    (WebCore::RenderRegion::isLastRegion):
    (WebCore::RenderRegion::paintObject):
    (WebCore::RenderRegion::nodeAtPoint):
    (WebCore::RenderRegion::incrementAutoLogicalHeightCount):
    (WebCore::RenderRegion::decrementAutoLogicalHeightCount):
    (WebCore::RenderRegion::layoutBlock):
    (WebCore::RenderRegion::repaintFlowThreadContentRectangle):
    (WebCore::RenderRegion::attachRegion):
    (WebCore::RenderRegion::renderBoxRegionInfo):
    (WebCore::RenderRegion::setRenderBoxRegionInfo):
    (WebCore::RenderRegion::logicalTopOfFlowThreadContentRect):
    (WebCore::RenderRegion::logicalBottomOfFlowThreadContentRect):
    (WebCore::RenderRegion::computePreferredLogicalWidths):
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147082 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    33db4a62