Skip to content
  • eric@webkit.org's avatar
    2010-04-02 Zhenyao Mo <zmo@google.com> · 326c1776
    eric@webkit.org authored
            Reviewed by Eric Seidel.
    
            Implement and test new framebuffer object attachment behavior.
            https://bugs.webkit.org/show_bug.cgi?id=35611
    
            * fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Added, test framebuffer object attachment behavior.
            * fast/canvas/webgl/framebuffer-object-attachment.html: Added, framebuffer object attachment behavior.
            * fast/canvas/webgl/script-tests/gl-object-get-calls.js: DEPTH_COMPONENT is no longer a valid input, use DEPTH_COMPONENT16 instead.
            * platform/mac-snowleopard/Skipped: The bot does not support EXT_packed_depth_stencil, skip the framebuffer-object-attachment.html test.
    2010-04-02  Zhenyao Mo  <zmo@google.com>
    
            Reviewed by Eric Seidel.
    
            Implement and test new framebuffer object attachment behavior.
            https://bugs.webkit.org/show_bug.cgi?id=35611
    
            Test: fast/canvas/webgl/framebuffer-object-attachment.html
    
            * html/canvas/WebGLFramebuffer.cpp: Keep track of attached stencil/depth renderbuffers in WebGLFramebuffer.
            (WebCore::WebGLFramebuffer::WebGLFramebuffer):
            (WebCore::WebGLFramebuffer::setIsAttached):
            * html/canvas/WebGLFramebuffer.h: Ditto.
            (WebCore::WebGLFramebuffer::isDepthAttached):
            (WebCore::WebGLFramebuffer::isStencilAttached):
            (WebCore::WebGLFramebuffer::isDepthStencilAttached):
            * html/canvas/WebGLRenderbuffer.cpp: Keep track of internalformat.
            (WebCore::WebGLRenderbuffer::WebGLRenderbuffer):
            * html/canvas/WebGLRenderbuffer.h: Ditto.
            (WebCore::WebGLRenderbuffer::setInternalformat):
            (WebCore::WebGLRenderbuffer::getInternalformat):
            * html/canvas/WebGLRenderingContext.cpp:
            (WebCore::WebGLRenderingContext::framebufferRenderbuffer): Detect stencil/depth buffer conflicts.
            (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): Handling DEPTH_STENCIL case.
            (WebCore::WebGLRenderingContext::getRenderbufferParameter): Get correct WebGL internalformat.
            (WebCore::WebGLRenderingContext::renderbufferStorage): Detect illegal enums.
            * html/canvas/WebGLRenderingContext.idl: Add DEPTH_STENCIL enums.
            * platform/graphics/GraphicsContext3D.h: Add DEPTH_STENCIL enums.
            (WebCore::GraphicsContext3D::):
            * platform/graphics/mac/GraphicsContext3DMac.cpp: Map to correct DEPTH_STENCIL format.
            (WebCore::GraphicsContext3D::framebufferRenderbuffer):
            (WebCore::GraphicsContext3D::renderbufferStorage):
            (WebCore::GraphicsContext3D::getFramebufferAttachmentParameteriv):
    2010-04-02  Zhenyao Mo  <zmo@google.com>
    
            Reviewed by Eric Seidel.
    
            Implement and test new framebuffer object attachment behavior.
            https://bugs.webkit.org/show_bug.cgi?id=35611
    
            Test: fast/canvas/webgl/framebuffer-object-attachment.html
    
            * src/WebGraphicsContext3DDefaultImpl.cpp: Map to correct DEPTH_STENCIL format.
            (WebKit::WebGraphicsContext3DDefaultImpl::framebufferRenderbuffer):
            (WebKit::WebGraphicsContext3DDefaultImpl::getFramebufferAttachmentParameteriv):
            (WebKit::WebGraphicsContext3DDefaultImpl::renderbufferStorage):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57018 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    326c1776