Skip to content
  • barraclough@apple.com's avatar
    Source/JavaScriptCore: [JSC] WebKit allocates gigabytes of memory when doing... · 305071e3
    barraclough@apple.com authored
    Source/JavaScriptCore: [JSC] WebKit allocates gigabytes of memory when doing repeated string concatenation
    https://bugs.webkit.org/show_bug.cgi?id=63918
    
    Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-07-19
    Reviewed by Darin Adler.
    
    When allocating JSStrings during concatenation, we needed to call the Heap's reportExtraMemoryCost
    method due to additional string copying within several of the constructors when dealing with 
    UStrings.  This has been added to the UString version of the appendStringInConstruct method 
    within the JSString class.
    
    * runtime/JSString.h:
    (JSC::RopeBuilder::JSString):
    (JSC::RopeBuilder::appendStringInConstruct):
    
    LayoutTests: Chromium rebaselines r91269 and r91277.
    
    Patch by Ryosuke Niwa <rniwa@webkit.org> on 2011-07-19
    
    * platform/chromium-linux/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.png: Added.
    * platform/chromium-mac/fast/table/align-right-within-left-aligned-div-expected.png: Added.
    * platform/chromium-mac/fast/table/align-right-within-left-aligned-div-expected.txt: Added.
    * platform/chromium-mac/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.png: Added.
    * platform/chromium-win/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.png: Added.
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91290 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    305071e3