Skip to content
  • beidson@apple.com's avatar
    2009-06-23 Brady Eidson <beidson@apple.com> · 3040ad0f
    beidson@apple.com authored
            Reviewed by Darin Adler.
    
            <rdar://problem/6950660> REGRESSION: iSale 5.5.3 crashes after I click a template to load
    
            Due to some subtle WebKit changes - presumably some delegate callback behavior - a latent bug in 
            iSale was uncovered where they aren't properly retaining their FrameLoadDelegate, and we ended up
            calling back to a dealloc'ed object.
    
            * WebView/WebView.mm:
            (-[WebView _needsAdobeFrameReloadingQuirk]): Use more intelligent C++-style initialization.
            (-[WebView _needsKeyboardEventDisambiguationQuirks]): Ditto.
            (-[WebView _needsFrameLoadDelegateRetainQuirk]): YES for iSale versions under 5.6
            (-[WebView dealloc]): Release the delegate if the quirk is in effect.
            (-[WebView setFrameLoadDelegate:]): Retain the new delegate if the quirk is in effect.
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45021 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    3040ad0f