• anilsson@rim.com's avatar
    [BlackBerry] WebOverlay::pixelViewportRect() should return pixel viewport coordinates · 302250bc
    anilsson@rim.com authored
    https://bugs.webkit.org/show_bug.cgi?id=113263
    
    Reviewed by Rob Buis.
    
    PR 312404
    
    Source/WebCore:
    
    Fix WebOverlay::pixelViewportRect() to return the pixel viewport rect
    instead of the window rect. These are different if the web page is
    rendered starting at a window coordinate other than 0,0. The clip rect
    encodes the position we're rendered at, and can be used to translate
    the rect expressed in window coordinates to the pixel viewport
    coordinate system.
    
    Also perform some cleanup of related code.
    
    Only manually testable.
    
    * platform/graphics/blackberry/LayerCompositingThread.cpp:
    (WebCore::LayerCompositingThread::getTransformedHolePunchRect):
    (WebCore::LayerCompositingThread::drawTextures):
    * platform/graphics/blackberry/LayerRenderer.cpp:
    (WebCore::toPixelCoordinates):
    (WebCore):
    (WebCore::LayerRenderer::toWindowCoordinates):
    (WebCore::LayerRenderer::toPixelViewportCoordinates):
    (WebCore::LayerRenderer::toDocumentViewportCoordinates):
    (WebCore::LayerRenderer::updateLayersRecursive):
    * platform/graphics/blackberry/LayerRenderer.h:
    (LayerRenderer):
    
    Source/WebKit/blackberry:
    
    Fixed by returning pixel viewport coordinates instead of window
    coordinates.
    
    * Api/WebOverlay.cpp:
    (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::pixelViewportRect):
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146906 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    302250bc
ChangeLog 827 KB