• barraclough@apple.com's avatar
    Source/WebCore: [iOS] Tapping any link crashes in WebCore::EventHandler::mouseMoved() · 2f3625cd
    barraclough@apple.com authored
    (also crashes when scrolling certain sites)
    https://bugs.webkit.org/show_bug.cgi?id=126401
    <rdar://problem/15739334>
    
    Patch by Daniel Bates <dabates@apple.com> on 2014-01-02
    Reviewed by Tim Horton.
    
    * page/ios/EventHandlerIOS.mm:
    (WebCore::currentEventSlot): Make the shared variable have static-storage duration.
    
    Source/WebKit/mac: Remove WindowIsVisible
    https://bugs.webkit.org/show_bug.cgi?id=126270
    
    Reviewed by Tim Horton.
    
    We currently track visibility in two ways - ViewState::IsVisible and ViewState::WindowIsVisible.
    The latter detects that the content is hidden in fewer cases than the former, and as such, the
    former is always preferable.
    
    This affects the hidden state provided to FocusController::contentAreaDidShowOrHide and to
    Plugin::windowVisibilityChanged.
    
    * WebView/WebView.mm:
    (-[WebView _windowWillOrderOnScreen:]):
    (-[WebView _windowWillOrderOffScreen:]):
        - rename ContainingWindowIsVisible -> ContentIsVisible.
    
    Source/WebKit2: Remove WindowIsVisible
    https://bugs.webkit.org/show_bug.cgi?id=126270
    
    Reviewed by Tim Horton.
    
    We currently track visibility in two ways - ViewState::IsVisible and ViewState::WindowIsVisible.
    The latter detects that the content is hidden in fewer cases than the former, and as such, the
    former is always preferable.
    
    This affects the hidden state provided to FocusController::contentAreaDidShowOrHide and to
    Plugin::windowVisibilityChanged.
    
    * Shared/ViewState.h:
        - remove WindowIsVisible.
    * UIProcess/API/mac/PageClientImpl.h:
    * UIProcess/API/mac/PageClientImpl.mm:
        - remove isWindowVisible.
    * UIProcess/API/mac/WKView.mm:
    (-[WKView viewDidMoveToWindow]):
    (-[WKView _windowDidMiniaturize:]):
    (-[WKView _windowDidDeminiaturize:]):
    (-[WKView _windowDidOrderOffScreen:]):
    (-[WKView _windowDidOrderOnScreen:]):
        - remove ViewState::WindowIsVisible.
    * UIProcess/PageClient.h:
        - remove isWindowVisible.
    * UIProcess/WebPageProxy.cpp:
    (WebKit::WebPageProxy::updateViewState):
        - remove handling of ViewState::WindowIsVisible.
    * WebProcess/Plugins/PluginView.cpp:
    (WebKit::PluginView::setIsVisible):
    (WebKit::PluginView::didInitializePlugin):
    * WebProcess/Plugins/PluginView.h:
        - setWindowIsVisible -> setIsVisible.
    * WebProcess/WebPage/WebPage.cpp:
    (WebKit::WebPage::WebPage):
    (WebKit::WebPage::setViewIsVisible):
    (WebKit::WebPage::setViewState):
    (WebKit::WebPage::windowAndWebPageAreFocused):
    * WebProcess/WebPage/WebPage.h:
    (WebKit::WebPage::isVisible):
        - remove m_windowIsVisible, setWindowIsVisible (implementation moved to setViewIsVisible).
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161228 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    2f3625cd
PageClient.h 10.4 KB