Skip to content
  • jer.noble@apple.com's avatar
    <video> elements with no video tracks report false for webkitSupportsFullscreen. · 2ef5ac99
    jer.noble@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=86650
    
    Reviewed by Eric Carlson.
    
    Source/WebCore:
    
    No new tests; updated media/media-fullscreen-inline.html.
    
    With the new Full Screen API, the restriction that only video elements with
    video tracks can enter full screen seems arbitrary. Some media types will
    occasionally determine they have video tracks long after loadedmetadata, which
    breaks websites who check for webkitSupportsFullscreen(). Relax the restriction
    on webkitSupportsFullscreen() for ports where the Full Screen API is enabled and
    supported so as to no longer require hasVideo().
    
    * html/HTMLVideoElement.cpp:
    (WebCore::HTMLVideoElement::supportsFullscreen):
    
    LayoutTests:
    
    Fix media-fullscreen.js to support the new FULLSCREEN_API events, if present.
    Fix the media-fullscreen-inline.html test and unskip on Lion.
    
    * media/media-fullscreen-inline-expected.txt:
    * media/media-fullscreen-inline.html:
    * media/media-fullscreen.js:
    (fullscreenchange):
    (loadedmetadata):
    (addEventListeners):
    * platform/mac-lion/Skipped:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117326 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    2ef5ac99