Skip to content
  • abarth@webkit.org's avatar
    DirectoryEntry should use Dictionary rather than custom bindings code · 2a9aa4ae
    abarth@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=94207
    
    Reviewed by Eric Seidel.
    
    Source/WebCore:
    
    Since this code was written, we added native support for WebIDL
    Dictionary objects. This patch moves DirectoryEntry to use this
    automatic facility instead of custom code.
    
    I've also renamed and simplified WebKitFlags. This is possible because
    this object was no longer exposed via IDL (even before to this patch).
    
    * GNUmakefile.list.am:
    * Modules/filesystem/DOMFileSystemBase.cpp:
    (WebCore::DOMFileSystemBase::getFile):
    (WebCore::DOMFileSystemBase::getDirectory):
    * Modules/filesystem/DOMFileSystemBase.h:
    (DOMFileSystemBase):
    * Modules/filesystem/DirectoryEntry.cpp:
    (WebCore::DirectoryEntry::getFile):
    (WebCore::DirectoryEntry::getDirectory):
    * Modules/filesystem/DirectoryEntry.h:
    (DirectoryEntry):
    * Modules/filesystem/DirectoryEntry.idl:
    * Modules/filesystem/DirectoryEntrySync.cpp:
    (WebCore::DirectoryEntrySync::getFile):
    (WebCore::DirectoryEntrySync::getDirectory):
    * Modules/filesystem/DirectoryEntrySync.h:
    (DirectoryEntrySync):
    * Modules/filesystem/DirectoryEntrySync.idl:
    * Modules/filesystem/FileSystemCallbacks.cpp:
    (WebCore):
    (WebCore::ResolveURICallbacks::didOpenFileSystem):
    * Modules/filesystem/FileSystemFlags.h: Renamed from Source/WebCore/Modules/filesystem/WebKitFlags.h.
    (WebCore):
    (WebCore::FileSystemFlags::FileSystemFlags):
    (FileSystemFlags):
    * Modules/filesystem/WorkerContextFileSystem.cpp:
    (WebCore::WorkerContextFileSystem::webkitResolveLocalFileSystemSyncURL):
    * Target.pri:
    * UseJSC.cmake:
    * UseV8.cmake:
    * WebCore.gypi:
    * WebCore.vcproj/WebCore.vcproj:
    * WebCore.xcodeproj/project.pbxproj:
    * bindings/js/JSDirectoryEntryCustom.cpp: Removed.
    * bindings/js/JSDirectoryEntrySyncCustom.cpp: Removed.
    * bindings/v8/custom/V8DirectoryEntryCustom.cpp: Removed.
    * bindings/v8/custom/V8DirectoryEntrySyncCustom.cpp: Removed.
    
    LayoutTests:
    
    This patch changes our behavior slightly in that passing a non-object
    as a flags Dictionary throws an exception rather than being treated as
    an empty dictionary. This new behavior matches the WebIDL spec and
    hopefully won't cause compat problems.
    
    * fast/filesystem/flags-passing-expected.txt:
    * fast/filesystem/script-tests/flags-passing.js:
    (runNullTest):
    (runNonObjectTest):
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125807 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    2a9aa4ae