Skip to content
  • tkent@chromium.org's avatar
    Clean up Localizer-related functions · 24b1fce0
    tkent@chromium.org authored
    https://bugs.webkit.org/show_bug.cgi?id=97899
    
    Reviewed by Kentaro Hara.
    
    Source/WebCore:
    
    - Rename Document::getLocalizer to getCachedLocalizer
    - Add default argument to getCachedLocalizer
    - Add Element::localizer to reduce code size
    - Rename DateTimeNumericFieldElement::localizer to localizerForOwner to
      avoid conflict with Element::localizer
    - Add Localizer::createDefault to improve code readability
    
    No new tests. This shouldn't make any behavior change.
    
    * dom/Document.h:
    (Document): Rename getLocalizer to getCachedLocalizer, and add default
    argument.
    * dom/Document.cpp:
    (WebCore::Document::getCachedLocalizer): ditto.
    
    * dom/Element.h:
    (Element): Add localizer function.
    * dom/Element.cpp:
    (WebCore::Element::localizer): Added
    
    * html/shadow/DateTimeNumericFieldElement.h:
    (DateTimeNumericFieldElement): Rename localizer to localizerForOwner.
    * html/shadow/DateTimeNumericFieldElement.cpp: ditto.
    (WebCore::DateTimeNumericFieldElement::handleKeyboardEvent):
    (WebCore::DateTimeNumericFieldElement::localizerForOwner):
    (WebCore::DateTimeNumericFieldElement::value):
    
    * platform/text/Localizer.h:
    (Localizer): Add createDefault
    (WebCore::Localizer::createDefault): Implemented.
    
    * html/BaseMultipleFieldsDateAndTimeInputType.cpp:
    (WebCore::BaseMultipleFieldsDateAndTimeInputType::updateInnerTextValue):
    Use Element::localizer.
    * html/NumberInputType.cpp:
    (WebCore::NumberInputType::localizeValue): ditto.
    (WebCore::NumberInputType::convertFromVisibleValue): ditto.
    
    Source/WebKit/blackberry:
    
    * WebCoreSupport/ColorPickerClient.cpp:
    (WebCore::ColorPickerClient::localizer): Follow Document::getLocalizer renaming.
    * WebCoreSupport/DatePickerClient.cpp:
    (WebCore::SelectPopupClient::localizer): ditto.
    * WebCoreSupport/SelectPopupClient.cpp:
    (WebCore::SelectPopupClient::localizer): ditto.
    
    Source/WebKit/chromium:
    
    * src/ColorChooserUIController.cpp:
    (WebKit::ColorChooserUIController::ColorChooserUIController):
    Use Localizer::createDefault
    * src/DateTimeChooserImpl.cpp:
    (WebKit::DateTimeChooserImpl::DateTimeChooserImpl): ditto.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129903 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    24b1fce0