Skip to content
  • commit-queue@webkit.org's avatar
    Some Content Security Policy console messages are missing line numbers in JSC · 24a70122
    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=87558
    
    Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-29
    Reviewed by Adam Barth.
    
    Source/WebCore:
    
    Make ScriptController::eventHandlerPosition() behave the same way on
    JSC than V8. This means that TextPosition::minimumPosition() is
    returned if parser is null, instead of
    TextPosition::belowRangePosition(). The line numbers are now correctly
    printed in the output of Content Security Policy tests.
    
    Tests: http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url.html
           http/tests/security/contentSecurityPolicy/javascript-url-blocked.html
    
    * bindings/js/ScriptController.cpp:
    (WebCore::ScriptController::eventHandlerPosition):
    
    LayoutTests:
    
    Remove Mac/EFL/GTK/Qt-specific expectations for Content Security Policy
    tests now that the line numbers are correctly printed.
    
    * platform/efl/http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt: Removed.
    * platform/efl/http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt: Removed.
    * platform/gtk/http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt: Removed.
    * platform/gtk/http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt: Removed.
    * platform/mac/http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt: Removed.
    * platform/mac/http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt: Removed.
    * platform/qt/http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt: Removed.
    * platform/qt/http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt: Removed.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118861 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    24a70122