Skip to content
  • krit@webkit.org's avatar
    2010-06-06 Dirk Schulze <krit@webkit.org> · 21317bbb
    krit@webkit.org authored
            Reviewed by Nikolas Zimmermann.
    
            hit testing does not respect clip paths
            https://bugs.webkit.org/show_bug.cgi?id=15162
    
            Test: svg/dynamic-updates/SVGClipPath-influences-hitTesting.html
            
            Added a check, if a float point is not only in the shape/object boundaries
            but also is not in the clipped away area of a clipPath.
    
            * rendering/HitTestRequest.h:
            (WebCore::HitTestRequest::):
            (WebCore::HitTestRequest::svgClipContent):
            * rendering/RenderPath.cpp:
            (WebCore::RenderPath::fillContains):
            (WebCore::RenderPath::nodeAtFloatPoint):
            * rendering/RenderPath.h:
            * rendering/RenderSVGContainer.cpp:
            (WebCore::RenderSVGContainer::nodeAtFloatPoint):
            * rendering/RenderSVGImage.cpp:
            (WebCore::RenderSVGImage::nodeAtFloatPoint):
            * rendering/RenderSVGResourceClipper.cpp:
            (WebCore::RenderSVGResourceClipper::hitTestClipContent):
            * rendering/RenderSVGResourceClipper.h:
            * rendering/RenderSVGText.cpp:
            (WebCore::RenderSVGText::nodeAtFloatPoint):
            * rendering/SVGRenderSupport.cpp:
            (WebCore::pointInClippingArea):
            * rendering/SVGRenderSupport.h:
    2010-06-06  Dirk Schulze  <krit@webkit.org>
    
            Reviewed by Nikolas Zimmermann.
    
            hit testing does not respect clip paths
            https://bugs.webkit.org/show_bug.cgi?id=15162
            
            Two tests were incorrect, because of the assumption, that clipPath doesn't
            influence hit testing. They needed an update.
            The new test checks, that clipped areas don't throw a hit.
    
            * svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.txt: Added.
            * svg/dynamic-updates/SVGClipPath-influences-hitTesting.html: Added.
            * svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr-expected.txt:
            * svg/dynamic-updates/SVGClipPathElement-svgdom-clipPathUnits-prop-expected.txt:
            * svg/dynamic-updates/script-tests/SVGClipPath-influences-hitTesting.js: Added.
            (executeBackgroundTest):
            (executeTest):
            * svg/dynamic-updates/script-tests/SVGClipPathElement-dom-clipPathUnits-attr.js:
            (shouldBeEqualToString.executeTest):
            * svg/dynamic-updates/script-tests/SVGClipPathElement-svgdom-clipPathUnits-prop.js:
            (executeTest):
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60761 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    21317bbb