Skip to content
  • reni@webkit.org's avatar
    Outside list bullets ignore text-align style. · dfde6358
    reni@webkit.org authored
    https://bugs.webkit.org/show-bug.cgi?id=15713
    
    Patch by Renata Hodovan <reni@webkit.org> on 2010-11-22
    Reviewed by Andreas Kling.
    
    WebCore: 
    
    Fix the position of outside markers by setting its logicalLeft member. Embedded markers need special treatment.
    First, the total width of markers should be calculated. Subtracting it from logicalLeft we get the outermost bullet's
    position. As for the others, this sum should be decremented with the previous marker's width.
    In case of vertical markers the padding is unneeded.
    
    Test: fast/lists/outSideListMarkers.html
    
    * rendering/InlineFlowBox.cpp:
    (WebCore::InlineFlowBox::placeBoxesInInlineDirection):
    * rendering/RenderListItem.cpp:
    (WebCore::RenderListItem::positionListMarker):
    
    LayoutTests: 
    
    Add new test for checking outside marker's position and update the related expecteds of tests.
    
    * fast/lists/outSideListMarkers-expected.txt: Added.
    * fast/lists/outSideListMarkers.html: Added.
    * platform/mac-leopard/css1/box_properties/margin_right-expected.checksum:
    * platform/mac-leopard/css1/box_properties/margin_right-expected.png:
    * platform/mac-leopard/css1/box_properties/padding_right-expected.checksum:
    * platform/mac-leopard/css1/box_properties/padding_right-expected.png:
    * platform/mac-leopard/editing/pasteboard/merge-end-list-expected.checksum:
    * platform/mac-leopard/editing/pasteboard/merge-end-list-expected.png:
    * platform/mac-leopard/fast/css/background-shorthand-invalid-url-expected.checksum:
    * platform/mac-leopard/fast/css/background-shorthand-invalid-url-expected.png:
    * platform/mac-leopard/fast/css/empty-pseudo-class-expected.checksum:
    * platform/mac-leopard/fast/css/empty-pseudo-class-expected.png:
    * platform/mac-leopard/fast/css/first-child-pseudo-class-expected.checksum:
    * platform/mac-leopard/fast/css/first-child-pseudo-class-expected.png:
    * platform/mac-leopard/fast/css/first-of-type-pseudo-class-expected.checksum:
    * platform/mac-leopard/fast/css/first-of-type-pseudo-class-expected.png:
    * platform/mac-leopard/fast/css/last-child-pseudo-class-expected.checksum:
    * platform/mac-leopard/fast/css/last-child-pseudo-class-expected.png:
    * platform/mac-leopard/fast/css/last-of-type-pseudo-class-expected.checksum:
    * platform/mac-leopard/fast/css/last-of-type-pseudo-class-expected.png:
    * platform/mac-leopard/fast/css/only-child-pseudo-class-expected.checksum:
    * platform/mac-leopard/fast/css/only-child-pseudo-class-expected.png:
    * platform/mac-leopard/fast/css/only-of-type-pseudo-class-expected.checksum:
    * platform/mac-leopard/fast/css/only-of-type-pseudo-class-expected.png:
    * platform/mac-leopard/fast/doctypes/002-expected.checksum:
    * platform/mac-leopard/fast/doctypes/002-expected.png:
    * platform/mac-leopard/fast/lists/001-expected.checksum:
    * platform/mac-leopard/fast/lists/001-expected.png:
    * platform/mac-leopard/fast/lists/002-expected.checksum:
    * platform/mac-leopard/fast/lists/002-expected.png:
    * platform/mac-leopard/fast/lists/003-expected.checksum:
    * platform/mac-leopard/fast/lists/003-expected.png:
    * platform/mac/css1/box_properties/margin_right-expected.txt:
    * platform/mac/css1/box_properties/padding_right-expected.txt:
    * platform/mac/editing/pasteboard/merge-end-list-expected.txt:
    * platform/mac/editing/selection/extend-by-word-002-expected.checksum:
    * platform/mac/editing/selection/extend-by-word-002-expected.png:
    * platform/mac/editing/selection/extend-by-word-002-expected.txt:
    * platform/mac/fast/css/background-shorthand-invalid-url-expected.txt:
    * platform/mac/fast/css/empty-pseudo-class-expected.txt:
    * platform/mac/fast/css/first-child-pseudo-class-expected.txt:
    * platform/mac/fast/css/first-of-type-pseudo-class-expected.txt:
    * platform/mac/fast/css/last-child-pseudo-class-expected.txt:
    * platform/mac/fast/css/last-of-type-pseudo-class-expected.txt:
    * platform/mac/fast/css/only-child-pseudo-class-expected.txt:
    * platform/mac/fast/css/only-of-type-pseudo-class-expected.txt:
    * platform/mac/fast/doctypes/002-expected.txt:
    * platform/mac/fast/lists/001-expected.txt:
    * platform/mac/fast/lists/001-vertical-expected.checksum:
    * platform/mac/fast/lists/001-vertical-expected.png:
    * platform/mac/fast/lists/001-vertical-expected.txt:
    * platform/mac/fast/lists/002-expected.txt:
    * platform/mac/fast/lists/002-vertical-expected.checksum:
    * platform/mac/fast/lists/002-vertical-expected.png:
    * platform/mac/fast/lists/002-vertical-expected.txt:
    * platform/mac/fast/lists/003-expected.txt:
    * platform/mac/fast/lists/003-vertical-expected.checksum:
    * platform/mac/fast/lists/003-vertical-expected.png:
    * platform/mac/fast/lists/003-vertical-expected.txt:
    * platform/mac/fast/lists/007-vertical-expected.checksum:
    * platform/mac/fast/lists/007-vertical-expected.png:
    * platform/mac/fast/lists/007-vertical-expected.txt:
    * platform/mac/fast/lists/008-vertical-expected.checksum:
    * platform/mac/fast/lists/008-vertical-expected.png:
    * platform/mac/fast/lists/008-vertical-expected.txt:
    * platform/mac/fast/lists/outSideListMarkers-expected.checksum: Added.
    * platform/mac/fast/lists/outSideListMarkers-expected.png: Added.
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72527 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    dfde6358