Skip to content
  • ojan@chromium.org's avatar
    ec03f916
    Fixed width overrides intrinsic min-width/max-width for text inputs and listboxes · ec03f916
    ojan@chromium.org authored
    https://bugs.webkit.org/show_bug.cgi?id=106675
    
    Reviewed by Emil A Eklund.
    
    Source/WebCore:
    
    Implement computeIntrinsicLogicalWidths so that RenderBox::computeLogicalWidthInRegionUsing
    can get the correct intrinsic sizes instead of the preferred sizes.
    
    Test: fast/forms/select/listbox-intrinsic-min-width-applies-with-fixed-width.html
    
    * rendering/RenderListBox.cpp:
    (WebCore::RenderListBox::computeIntrinsicLogicalWidths):
    (WebCore):
    (WebCore::RenderListBox::computePreferredLogicalWidths):
    * rendering/RenderListBox.h:
    (RenderListBox):
    * rendering/RenderTextControl.cpp:
    (WebCore::RenderTextControl::computeIntrinsicLogicalWidths):
    (WebCore):
    (WebCore::RenderTextControl::computePreferredLogicalWidths):
    * rendering/RenderTextControl.h:
    (RenderTextControl):
    
    LayoutTests:
    
    * fast/forms/file/intrinsic-min-width-overrides-width-expected.html:
    * fast/forms/file/intrinsic-min-width-overrides-width.html:
    * fast/forms/select/listbox-intrinsic-min-width-applies-with-fixed-width-expected.html: Added.
    * fast/forms/select/listbox-intrinsic-min-width-applies-with-fixed-width.html: Added.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139536 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    ec03f916
    Fixed width overrides intrinsic min-width/max-width for text inputs and listboxes
    ojan@chromium.org authored
    https://bugs.webkit.org/show_bug.cgi?id=106675
    
    Reviewed by Emil A Eklund.
    
    Source/WebCore:
    
    Implement computeIntrinsicLogicalWidths so that RenderBox::computeLogicalWidthInRegionUsing
    can get the correct intrinsic sizes instead of the preferred sizes.
    
    Test: fast/forms/select/listbox-intrinsic-min-width-applies-with-fixed-width.html
    
    * rendering/RenderListBox.cpp:
    (WebCore::RenderListBox::computeIntrinsicLogicalWidths):
    (WebCore):
    (WebCore::RenderListBox::computePreferredLogicalWidths):
    * rendering/RenderListBox.h:
    (RenderListBox):
    * rendering/RenderTextControl.cpp:
    (WebCore::RenderTextControl::computeIntrinsicLogicalWidths):
    (WebCore):
    (WebCore::RenderTextControl::computePreferredLogicalWidths):
    * rendering/RenderTextControl.h:
    (RenderTextControl):
    
    LayoutTests:
    
    * fast/forms/file/intrinsic-min-width-overrides-width-expected.html:
    * fast/forms/file/intrinsic-min-width-overrides-width.html:
    * fast/forms/select/listbox-intrinsic-min-width-applies-with-fixed-width-expected.html: Added.
    * fast/forms/select/listbox-intrinsic-min-width-applies-with-fixed-width.html: Added.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@139536 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Loading