Skip to content
  • darin@apple.com's avatar
    2008-09-18 Darin Adler <darin@apple.com> · 1d103ae8
    darin@apple.com authored
            Reviewed by Sam Weinig.
    
            - fix https://bugs.webkit.org/show_bug.cgi?id=20925
              LEAK messages appear every time I quit
    
            * JavaScriptCore.exp: Updated, and also added an export
            needed for future WebCore use of JSC::StructureID.
    
            * wtf/RefCountedLeakCounter.cpp:
            (WTF::RefCountedLeakCounter::suppressMessages): Added.
            (WTF::RefCountedLeakCounter::cancelMessageSuppression): Added.
            (WTF::RefCountedLeakCounter::RefCountedLeakCounter): Tweaked a bit.
            (WTF::RefCountedLeakCounter::~RefCountedLeakCounter): Added code to
            log the reason there was no leak checking done.
            (WTF::RefCountedLeakCounter::increment): Tweaked a bit.
            (WTF::RefCountedLeakCounter::decrement): Ditto.
    
            * wtf/RefCountedLeakCounter.h: Replaced setLogLeakMessages with two
            new functions, suppressMessages and cancelMessageSuppression. Also
            added m_ prefixes to the data member names.
    
    2008-09-18  Darin Adler  <darin@apple.com>
    
            Reviewed by Sam Weinig.
    
            - fix https://bugs.webkit.org/show_bug.cgi?id=20925
              LEAK messages appear every time I quit
    
            * WebView/WebPreferences.mm:
            (-[WebPreferences setFullDocumentTeardownEnabled:]): Removed unneeded call
            to setLogLeakMessages.
            * WebView/WebView.mm:
            (-[WebView _closeWithFastTeardown]): Call RefCountedLeakCounter::suppressMessages,
            telling it that we can't track leaks because at least one WebView was closed with
            fast teardown.
            (-[WebView _close]): Removed unneeded call to setLogLeakMessages. Added a call to
            cancelMessageSuppression since the WebView is no longer open.
            Added an explicit garbage collect to help with the case where we're closing during
            the quit process -- the garbageCollectSoon() calls done inside WebCore won't help
            us in that case.
            (-[WebView initWithFrame:frameName:groupName:]): Call
            RefCountedLeakCounter::suppressMessages telling it that we can't track leaks
            because at least one WebView is currently open.
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36631 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    1d103ae8