Skip to content
  • commit-queue@webkit.org's avatar
    [WK2] [Mac] Implement KeyDown function for WebKit2 EventSender. · 1c00c3e3
    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=57515
    
    Source/WebKit2:
    
    The code change in WebKit2 allows key events being sent to WebProcess from UIProcess synchronously.
    
    Patch by Chang Shu <cshu@webkit.org> on 2011-09-13
    Reviewed by Darin Adler.
    
    * UIProcess/API/C/WKPage.cpp:
    (WKPageSetShouldSendKeyboardEventSynchronously):
    * UIProcess/API/C/WKPagePrivate.h:
    * UIProcess/WebPageProxy.cpp:
    (WebKit::WebPageProxy::WebPageProxy):
    (WebKit::WebPageProxy::handleKeyboardEvent):
    * UIProcess/WebPageProxy.h:
    (WebKit::WebPageProxy::setShouldSendKeyboardEventSynchronously):
    * WebProcess/WebPage/WebPage.cpp:
    (WebKit::WebPage::keyEventSyncForTesting):
    * WebProcess/WebPage/WebPage.h:
    * WebProcess/WebPage/WebPage.messages.in:
    
    Tools:
    
    The code change in WebKitTestRunner first sends keydown event from InjectedBundle to
    TestController synchronously. The latter then sends simulated event to WebKit2 module,
    which is synchronous, too.
    
    Patch by Chang Shu <cshu@webkit.org> on 2011-09-13
    Reviewed by Darin Adler.
    
    * WebKitTestRunner/EventSenderProxy.h: Added.
    (WTR::EventSenderProxy::EventSenderProxy):
    * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
    * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
    (WTR::EventSendingController::keyDown):
    * WebKitTestRunner/InjectedBundle/EventSendingController.h:
    * WebKitTestRunner/PlatformWebView.h:
    (WTR::PlatformWebView::platformWindow):
    * WebKitTestRunner/TestController.cpp:
    (WTR::TestController::TestController):
    (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
    * WebKitTestRunner/TestController.h:
    * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
    * WebKitTestRunner/mac/EventSenderProxy.mm: Added.
    (WTR::buildModifierFlags):
    (WTR::EventSenderProxy::keyDown):
    
    LayoutTests:
    
    Unskip passed tests for Mac.
    
    Patch by Chang Shu <cshu@webkit.org> on 2011-09-13
    Reviewed by Darin Adler.
    
    * platform/mac-wk2/Skipped:
    * platform/qt-wk2/Skipped:
    * platform/win-wk2/Skipped:
    * platform/wk2/Skipped:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95039 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    1c00c3e3