• commit-queue@webkit.org's avatar
    [BlackBerry] http authenticate dialog popup only once no matter authentication pass or fail · 1a7c3e81
    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=80135
    
    Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-05-28
    Reviewed by Rob Buis.
    
    Source/WebCore:
    
    RIM PR: 145660
    Fixed a regression introduced by r111810, we should cancel the new
    request when user press cancel button in http authentication challenge
    dialog, and we should also allow sending empty username and password
    with the request.
    Also removed redundant codes which checked the existence of the
    FrameLoaderClient pointer, as we've already moved authenticationChallenge()
    out of class FrameLoaderClient, it is not needed.
    
    Manual test added. Testing http authentication dialog relies on user interaction.
    
    Resubmit the patch reverted by r115104 after the digest infinite loop
    issue for BlackBerry porting get identified and fixed.
    
    Internally reviewed by Joe Mason <jmason@rim.com>
    
    * platform/blackberry/PageClientBlackBerry.h:
    * platform/network/blackberry/NetworkJob.cpp:
    (WebCore::NetworkJob::sendRequestWithCredentials):
    
    Source/WebKit/blackberry:
    
    RIM PR: 145660
    Fixed a regression introduced by r111810, which used the wrong
    credential object.
    
    Added the interface function didReceivedAuthenticaitonChallenge()
    in interface class DumpRenderTreeClient;
    Called m_dumpRenderTree->didReceiveAuthenticationChallenge() in
    WebPagePrivate::authenticationChallenge() when DRT is enabled.
    
    Test: reuse existing test cases:
    http/tests/loading/basic-credentials-sent-automatically.html
    http/tests/loading/basic-auth-resend-wrong-credentials.html
    
    Resubmit the patch reverted by r115104 after the digest infinite loop
    issue for BlackBerry porting get identified and fixed.
    
    Internally reviewed by Joe Mason <jmason@rim.com>
    
    * Api/DumpRenderTreeClient.h:
    (WebCore):
    * Api/WebPage.cpp:
    (BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
    * Api/WebPageClient.h:
    * Api/WebPage_p.h:
    (WebPagePrivate):
    
    Tools:
    
    Implemented interface function didReceiveAuthenticationChallenge in class
    DumpRenderTree.
    
    Resubmit the patch reverted by r115104 after the digest infinite loop
    issue for BlackBerry porting get identified and fixed.
    
    Internally reviewed by Joe Mason <jmason@rim.com>
    
    * DumpRenderTree/blackberry/DumpRenderTree.cpp:
    (drtCredentialDescription):
    (BlackBerry::WebKit::DumpRenderTree::didReceiveAuthenticationChallenge):
    (WebKit):
    * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
    (WebCore):
    (DumpRenderTree):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118719 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    1a7c3e81
ChangeLog 180 KB