Skip to content
  • commit-queue@webkit.org's avatar
    Source/WebCore: Assert being hit in AccessibilityRenderObject::addChildren() · 177e37cf
    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=61805
    
    Patch by Dominic Mazzoni <dmazzoni@google.com> on 2011-09-09
    Reviewed by Chris Fleizach.
    
    Fix nextSibling and previousSibling to handle adjacent continuations
    properly, otherwise nodes end up appearing in the accessibility
    tree twice (or a debug assertion could be raised).
    
    Test: accessibility/adjacent-continuations-cause-assertion-failure.html
    
    * accessibility/AccessibilityRenderObject.cpp:
    (WebCore::AccessibilityRenderObject::previousSibling):
    (WebCore::AccessibilityRenderObject::nextSibling):
    
    LayoutTests: Add a test to catch a case where adjacent continuations were
    causing nodes to get added to the accessibility tree twice, leading
    to an assertion failure or a crash. The test expectations are
    currently Mac-specific, so added the test to the Skipped file for
    gtk and win.
    https://bugs.webkit.org/show_bug.cgi?id=61805
    
    Patch by Dominic Mazzoni <dmazzoni@google.com> on 2011-09-09
    Reviewed by Chris Fleizach.
    
    * accessibility/adjacent-continuations-cause-assertion-failure.html: Added.
    * platform/mac/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt: Added.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94864 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    177e37cf