Skip to content
  • commit-queue@webkit.org's avatar
    Improve multicol intrinsic width calculation · 1115308a
    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=116677
    
    Patch by Morten Stenshorne <mstensho@opera.com> on 2013-08-27
    Reviewed by David Hyatt.
    
    Source/WebCore:
    
    Test: fast/css-intrinsic-dimensions/multicol.html
    
    * rendering/RenderBlock.cpp:
    (WebCore::RenderBlock::computeIntrinsicLogicalWidths):
    (WebCore::RenderBlock::adjustIntrinsicLogicalWidthsForColumns):
    * rendering/RenderBlock.h:
    
    LayoutTests:
    
    * css3/unicode-bidi-isolate-basic.html: The expectation seems to
    be that the columns should be as many as necessary and narrow as
    possible, and that the multicol container's width should be that
    of one column. The previous CSS didn't really ask for this,
    although that's how it happened to be rendered without this fix.
    * fast/css-intrinsic-dimensions/multicol-expected.txt: Added.
    * fast/css-intrinsic-dimensions/multicol.html: Added.
    * fast/multicol/positioned-with-constrained-height-expected.html: Copied from LayoutTests/fast/multicol/positioned-with-constrained-height.html.
    * fast/multicol/positioned-with-constrained-height.html: Turn into a reftest.
    * platform/efl/fast/multicol/positioned-with-constrained-height-expected.png: Removed.
    * platform/efl/fast/multicol/positioned-with-constrained-height-expected.txt: Removed.
    * platform/gtk/fast/multicol/positioned-with-constrained-height-expected.png: Removed.
    * platform/gtk/fast/multicol/positioned-with-constrained-height-expected.txt: Removed.
    * platform/mac/fast/multicol/positioned-with-constrained-height-expected.png: Removed.
    * platform/mac/fast/multicol/positioned-with-constrained-height-expected.txt: Removed.
    * platform/qt/fast/multicol/positioned-with-constrained-height-expected.png: Removed.
    * platform/qt/fast/multicol/positioned-with-constrained-height-expected.txt: Removed.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154714 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    1115308a