Skip to content
  • jorlow@chromium.org's avatar
    2010-08-10 Jeremy Orlow <jorlow@chromium.org> · 09d1bc4d
    jorlow@chromium.org authored
            Reviewed by Adam Barth.
    
            Some settings are linked to the PageGroup not the Page.  Create a new class for those.
            https://bugs.webkit.org/show_bug.cgi?id=43794
    
            Since persistient storage is shared between pages, there's no way to modify
            some settings related to it on a per page basis.  As such, it's not technically
            correct for these settings to be on the Page's settings.  Create a new class
            called GroupSettings, move the 2 group-wide local storage settings there, and
            add a new setting for IndexedDB's path (which is prompting this change).
    
            No behavior has changed, so no tests.
    
            * Android.mk:
            * CMakeLists.txt:
            * GNUmakefile.am:
            * WebCore.exp.in:
            * WebCore.gypi:
            * WebCore.pro:
            * WebCore.vcproj/WebCore.vcproj:
            * WebCore.xcodeproj/project.pbxproj:
            * page/PageGroup.cpp:
            (WebCore::PageGroup::PageGroup):
            (WebCore::PageGroup::localStorage):
            * page/PageGroup.h:
            (WebCore::PageGroup::groupSettings):
            * page/Settings.cpp:
            (WebCore::Settings::Settings):
            (WebCore::Settings::setSessionStorageQuota):
            * page/Settings.h:
    2010-08-10  Jeremy Orlow  <jorlow@chromium.org>
    
            Reviewed by Adam Barth.
    
            Some settings are linked to the PageGroup not the Page.  Create a new class for those.
            https://bugs.webkit.org/show_bug.cgi?id=43794
    
            Change WebView to use the new GroupSettings class rather than Settings for the
            settings that moved.  This is sub-optimal since the settings aren't really
            per-view, but we can't really change the API at this point.
    
            * WebView/WebView.mm:
            (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
            (-[WebView _preferencesChangedNotification:]):
    2010-08-11  Jeremy Orlow  <jorlow@chromium.org>
    
            Reviewed by Adam Barth.
    
            Some settings are linked to the PageGroup not the Page.  Create a new class for those.
            https://bugs.webkit.org/show_bug.cgi?id=43794
    
            Change WebSettings to use the new GroupSettings class rather than Settings for the
            settings that moved.  This is sub-optimal since the settings aren't really
            per-view, but I don't see how we can change the API at this point.
    
            * Api/qwebsettings.cpp:
            (QWebSettingsPrivate::apply):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65228 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    09d1bc4d