Skip to content
  • ap@webkit.org's avatar
    Reviewed by Adele Peterson. · 0775c54c
    ap@webkit.org authored
            https://bugs.webkit.org/show_bug.cgi?id=23949
            HTMLSelectElement is in inconsistent state when handling mutation events
    
            Test: fast/forms/mutation-event-recalc.html
    
            * dom/ContainerNode.cpp:
            (WebCore::ContainerNode::insertBefore):
            (WebCore::ContainerNode::appendChild):
            Call childrenChanged() before dispatching modification events, not after.
    
            * html/HTMLOptGroupElement.cpp:
            (WebCore::HTMLOptGroupElement::insertBefore):
            (WebCore::HTMLOptGroupElement::replaceChild):
            (WebCore::HTMLOptGroupElement::removeChild):
            (WebCore::HTMLOptGroupElement::appendChild):
            (WebCore::HTMLOptGroupElement::removeChildren):
            * html/HTMLSelectElement.cpp:
            (WebCore::HTMLSelectElement::add):
            (WebCore::HTMLSelectElement::remove):
            (WebCore::HTMLSelectElement::insertBefore):
            (WebCore::HTMLSelectElement::replaceChild):
            (WebCore::HTMLSelectElement::removeChild):
            (WebCore::HTMLSelectElement::appendChild):
            (WebCore::HTMLSelectElement::removeChildren):
            Remove calls to recalcSelectOptions(). It is too late to recalc now, after mutation events
            were already dispatched.
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41713 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    0775c54c