Skip to content
  • mnaganov@chromium.org's avatar
    [Chromium] Add supportMultipleWindows setting, needed for Android · 45854510
    mnaganov@chromium.org authored
    https://bugs.webkit.org/show_bug.cgi?id=99716
    
    Reviewed by Adam Barth.
    
    Add supportMultipleWindows settings for reusing the same view when
    opening popups. This is required for emulating the behavior of
    Android WebView. Adding into WebCore, as other ports might want to
    use this setting in the future.
    
    Source/WebCore:
    
    Tests: fast/dom/HTMLAnchorElement/anchor-no-multiple-windows.html
           fast/dom/Window/window-open-no-multiple-windows.html
           fast/forms/post-popup-no-multiple-windows.html
    
    * loader/FrameLoader.cpp:
    (WebCore::createWindow):
    * page/ContextMenuController.cpp:
    (WebCore::openNewWindow):
    * page/Settings.cpp:
    (WebCore::Settings::Settings):
    (WebCore::Settings::setSupportsMultipleWindows):
    (WebCore):
    * page/Settings.h:
    (Settings):
    (WebCore::Settings::supportsMultipleWindows):
    
    Source/WebKit/chromium:
    
    * public/WebSettings.h:
    * src/FrameLoaderClientImpl.cpp:
    (WebKit::FrameLoaderClientImpl::dispatchCreatePage):
    * src/WebSettingsImpl.cpp:
    (WebKit::WebSettingsImpl::setSupportsMultipleWindows):
    (WebKit):
    * src/WebSettingsImpl.h:
    (WebSettingsImpl):
    
    Tools:
    
    * DumpRenderTree/chromium/DRTTestRunner.cpp:
    (DRTTestRunner::overridePreference):
    * DumpRenderTree/chromium/WebPreferences.cpp:
    (WebPreferences::reset):
    (WebPreferences::applyTo):
    * DumpRenderTree/chromium/WebPreferences.h:
    (WebPreferences):
    
    LayoutTests:
    
    * fast/dom/HTMLAnchorElement/anchor-no-multiple-windows-expected.txt: Added.
    * fast/dom/HTMLAnchorElement/anchor-no-multiple-windows.html: Added.
    * fast/dom/Window/window-open-no-multiple-windows-expected.txt: Added.
    * fast/dom/Window/window-open-no-multiple-windows.html: Added.
    * fast/forms/post-popup-no-multiple-windows-expected.txt: Added.
    * fast/forms/post-popup-no-multiple-windows.html: Added.
    * platform/chromium/fast/dom/HTMLAnchorElement/anchor-no-multiple-windows-expected.txt: Added.
    * platform/chromium/fast/dom/Window/window-open-no-multiple-windows-expected.txt: Added.
    * platform/chromium/fast/forms/post-popup-no-multiple-windows-expected.txt: Added.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132478 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    45854510