Skip to content
  • oliver@apple.com's avatar
    Improve JSC Parser error messages · 039f9247
    oliver@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=123341
    
    Reviewed by Andreas Kling.
    
    Source/JavaScriptCore:
    
    This patch moves away from the current cludgy mechanisms used to produce
    error messages and moves to something closer to case by case errors.
    
    This results in a large change size as previously we may just have
    'failIfFalse(foo)', but now the logic becomes either
    'failIfFalseWithMessage(foo, "Cannot do blah with ", foo->thing())'
    Or alternatively
    
    if (!foo)
        check for 'interesting' errors, before falling back to generic error
    
    This means that this patch is large, but produces no semantic changes, and
    only hits slow (e.g. error) paths.
    
    * parser/Parser.cpp:
    (JSC::::Parser):
    (JSC::::parseSourceElements):
    (JSC::::parseVarDeclaration):
    (JSC::::parseConstDeclaration):
    (JSC::::parseDoWhileStatement):
    (JSC::::parseWhileStatement):
    (JSC::::parseVarDeclarationList):
    (JSC::::createBindingPattern):
    (JSC::::parseDeconstructionPattern):
    (JSC::::parseConstDeclarationList):
    (JSC::::parse...
    039f9247