Skip to content
  • commit-queue@webkit.org's avatar
    0320aa02
    CoordinatedGraphics: Fix integer rounding when computing pixel alignment · 0320aa02
    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=122565
    
    Patch by Sergio Correia <sergio.correia@openbossa.org> on 2013-10-09
    Reviewed by Noam Rosenthal.
    
    Source/WebCore:
    
    Replace roundedIntRect call in computePixelAlignment() with enclosingIntRect,
    so that very small rectangles (after content scaling) don't appear to be empty,
    creating a crash later.
    
    Test: transforms/3d/general/rotate-45-degrees-long-inner-text-in-dt.html
    
    * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
    (WebCore::CoordinatedGraphicsLayer::computePixelAlignment):
    
    LayoutTests:
    
    Added test that rotates 45 degrees a very long text in a dt tag that
    might crash the browser depending on how it handles the integer
    rounding when computing pixel alignment.
    
    * transforms/3d/general/rotate-45-degrees-long-inner-text-in-dt-expected.txt: Added.
    * transforms/3d/general/rotate-45-degrees-long-inner-text-in-dt.html: Added.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157180 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    0320aa02
    CoordinatedGraphics: Fix integer rounding when computing pixel alignment
    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=122565
    
    Patch by Sergio Correia <sergio.correia@openbossa.org> on 2013-10-09
    Reviewed by Noam Rosenthal.
    
    Source/WebCore:
    
    Replace roundedIntRect call in computePixelAlignment() with enclosingIntRect,
    so that very small rectangles (after content scaling) don't appear to be empty,
    creating a crash later.
    
    Test: transforms/3d/general/rotate-45-degrees-long-inner-text-in-dt.html
    
    * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
    (WebCore::CoordinatedGraphicsLayer::computePixelAlignment):
    
    LayoutTests:
    
    Added test that rotates 45 degrees a very long text in a dt tag that
    might crash the browser depending on how it handles the integer
    rounding when computing pixel alignment.
    
    * transforms/3d/general/rotate-45-degrees-long-inner-text-in-dt-expected.txt: Added.
    * transforms/3d/general/rotate-45-degrees-long-inner-text-in-dt.html: Added.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157180 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Loading