Skip to content
  • zmo@google.com's avatar
    2010-08-18 Zhenyao Mo <zmo@google.com> · 02436edc
    zmo@google.com authored
            Reviewed by Kenneth Russell.
    
            Implement strict type checking in js bindings for WebGL functions
            https://bugs.webkit.org/show_bug.cgi?id=44202
    
            Test: fast/canvas/webgl/bad-arguments-test.html
    
            * bindings/js/JSWebGLRenderingContextCustom.cpp: Add type check for wrapper types and DOMString and throw error in case of mismatch.
            (WebCore::JSWebGLRenderingContext::getAttachedShaders):
            (WebCore::JSWebGLRenderingContext::getProgramParameter):
            (WebCore::JSWebGLRenderingContext::getShaderParameter):
            (WebCore::JSWebGLRenderingContext::getUniform):
            (WebCore::dataFunctionf):
            (WebCore::dataFunctioni):
            (WebCore::dataFunctionMatrix):
            * bindings/scripts/CodeGeneratorJS.pm: Ditto.
            * bindings/scripts/CodeGeneratorV8.pm: Ditto.
            * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: Ditto.
            (WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
            (WebCore::V8WebGLRenderingContext::getProgramParameterCallback):
            (WebCore::V8WebGLRenderingContext::getShaderParameterCallback):
            (WebCore::V8WebGLRenderingContext::getUniformCallback):
            (WebCore::vertexAttribAndUniformHelperf):
            (WebCore::uniformHelperi):
            (WebCore::uniformMatrixHelper):
            * html/canvas/WebGLRenderingContext.idl: Add attribute StrictTypeChecking for WebGL functions.
    2010-08-18  Zhenyao Mo  <zmo@google.com>
    
            Reviewed by Kenneth Russell.
    
            Implement strict type checking in js bindings for WebGL functions
            https://bugs.webkit.org/show_bug.cgi?id=44202
    
            * fast/canvas/webgl/bad-arguments-test-expected.txt: Added.
            * fast/canvas/webgl/bad-arguments-test.html: Added.
            * fast/canvas/webgl/error-reporting-expected.txt: Fix bugs due to strict type checking in the js bindings.
            * fast/canvas/webgl/error-reporting.html: ditto.
            * fast/canvas/webgl/gl-object-get-calls-expected.txt: ditto.
            * fast/canvas/webgl/gl-object-get-calls.html: ditto.
            * fast/canvas/webgl/null-object-behaviour-expected.txt: ditto.
            * fast/canvas/webgl/null-object-behaviour.html: ditto.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65689 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    02436edc