ChangeLog 789 KB
Newer Older
1
2
3
4
5
6
2010-03-13  Antonio Gomes  <tonikitoo@webkit.org>

        Not reviewed identation fix.

        * manual-tests/spatial-navigation/spatial-navigation-test-cases.html:

7
8
9
10
11
12
13
14
15
16
2010-03-13  Kim Grönholm  <kim.gronholm@nomovok.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] GraphicsLayer: Opacity change from zero to non-zero doesn't always have effect with AC
        https://bugs.webkit.org/show_bug.cgi?id=36034

        * platform/graphics/qt/GraphicsLayerQt.cpp:
        (WebCore::OpacityAnimationQt::applyFrame):

17
18
19
20
21
22
23
24
25
26
2010-03-13  Kim Grönholm  <kim.gronholm@nomovok.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] GraphicsLayer: Opacity transitions end with begin value
        https://bugs.webkit.org/show_bug.cgi?id=36019

        * platform/graphics/qt/GraphicsLayerQt.cpp:
        (WebCore::AnimationQt::updateCurrentTime):

27
28
29
30
31
32
33
34
35
36
37
38
39
40
2010-03-13  Dirk Schulze  <krit@webkit.org>

        No review, rolling out r55927.
        http://trac.webkit.org/changeset/55927
        https://bugs.webkit.org/show_bug.cgi?id=35793

        Breaks Gtk build bots.

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
        (WebCore::MediaPlayerPrivate::load):
        (WebCore::MediaPlayerPrivate::setPreload):
        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
2010-03-12  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG Glyphs - transform path not context
        https://bugs.webkit.org/show_bug.cgi?id=36070

        SVGFont should transform the path of a glyph, not the context. Modifying
        the context causes wrong gradient transformations. This bug doesn't
        influence CG because we generally fill or stroke texts with a mask image.
        All other platforms provide a direct way to make the drawings.

        * svg/SVGFont.cpp:
        (WebCore::Font::drawTextUsingSVGFont):

56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
2010-03-12  Beth Dakin  <bdakin@apple.com>

        Reviewed by Simon Fraser.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=34942 Fullscreen 
        API naming is inconsistent
        -and corresponding-
        <rdar://problem/7729165>

        This patch changes all occurrences of "fullScreen" to the more 
        popular "fullscreen." webkitEnterFullScreen and 
        webkitExitFullScreen have been maintained for now for backwards 
        compatibility. 

        * html/HTMLVideoElement.cpp:
        (WebCore::HTMLVideoElement::webkitEnterFullscreen):
        (WebCore::HTMLVideoElement::webkitExitFullscreen):
        * html/HTMLVideoElement.h:
        (WebCore::HTMLVideoElement::webkitEnterFullScreen):
        (WebCore::HTMLVideoElement::webkitExitFullScreen):
        * html/HTMLVideoElement.idl:
        * platform/graphics/mac/MediaPlayerProxy.h:

79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
2010-03-12  James Robinson  <jamesr@chromium.org>

        Reviewed by Adam Barth.

        Add virtual destructor to DOMWrapperWorld
        https://bugs.webkit.org/show_bug.cgi?id=36077

        DOMWrapperWorld is RefCounted<DOMWrapperWorld>.  IsolatedWorld
        inherits from DOMWrapperWorld and has member variables
        with destructors, so DOMWrapperWorld needs to have a declared virtual
        d'tor to ensure that its derived class's destructors are called.

        No new tests, no change in behavior

        * bindings/v8/DOMWrapperWorld.h:
        (WebCore::DOMWrapperWorld::~DOMWrapperWorld):


97
98
99
100
101
102
103
104
105
106
107
108
109
2010-03-11  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Oliver Hunt.

        Bug 36075 - Clean up screwyness re static string impls & Identifiers.

        * platform/text/StringImpl.cpp:
        (WebCore::StringImpl::~StringImpl): Add ASSERT
        (WebCore::StringImpl::sharedBuffer): Add ASSERT
        * platform/text/StringImpl.h:
        (WebCore::StringImpl::setHash): Add ASSERT
        (WebCore::StringImpl::isStatic): added.

110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
2010-03-12  Enrica Casucci  <enrica@apple.com>

        Reviewed by Simon Fraser.

        Content of 3D tests appears at the bottom right corner sometimes.
        <rdar://problem/7556244>
        <https://bugs.webkit.org/show_bug.cgi?id=36027>

        There were two problems to solve here:
        - the incorrect anchoring of the rootChildLayer that was causing the composited
          content to be positioned incorrectly
        - the failure to paint the non composited content into the backing store when
          animating composited content.
          
        The first problem has been solved by leaving the original anchor point for the
        rootChildLayer and splitting the tasks of clipping and scrolling using two separate layers.
        The second problem has been solved leveraging the knowledge that WebView has of the dirty region
        of the backing store to pass this information to the layer renderer. This allows the renderer to force
        a paint into the backing store before moving to the compositing.
        
        Tests: compositing/geometry/horizontal-scroll-composited.html
               compositing/geometry/vertical-scroll-composited.html

        * manual-tests/win/horizontal-scroll-composited.html: Removed. This is now a layout test.
        * manual-tests/win/milliondollar.html: Added.
        * platform/graphics/win/WKCACFLayerRenderer.cpp:
        (WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): Added initialization of dirty flag.
        (WebCore::WKCACFLayerRenderer::setScrollFrame): 
        (WebCore::WKCACFLayerRenderer::updateScrollFrame): Updated to resize and position the clip and scroll layers.
        (WebCore::WKCACFLayerRenderer::setRootChildLayer):
        (WebCore::WKCACFLayerRenderer::createRenderer): Added new layer hierarchy.
        (WebCore::WKCACFLayerRenderer::destroyRenderer): Remove clip layer on destroy.
        (WebCore::WKCACFLayerRenderer::resize):
        (WebCore::WKCACFLayerRenderer::paint): Forcing paint massage to trigger paint into the backing store.
        * platform/graphics/win/WKCACFLayerRenderer.h:
        (WebCore::WKCACFLayerRenderer::setBackingStoreDirty): Added.

147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
2010-03-12  Robert Hogan  <robert@webkit.org>

        Not reviewed, build fix.

        Revert http://trac.webkit.org/projects/webkit/changeset/55374 which broke
        the !ENABLE(DATABASE) build on all platforms when attempting to fix the
        --minimal build on Qt.

        Support for SQLite now seems to be non-negotiable for the Qt build but making
        it mandatory requires review, so re-break --minimal Qt build for now.

        Qt build issue now tracked at https://bugs.webkit.org/show_bug.cgi?id=36073

        * page/GeolocationPositionCache.cpp:

162
163
164
165
166
167
168
169
170
171
172
173
2010-03-12  Dan Bernstein  <mitz@apple.com>

        Reviewed by Alexey Proskuryakov.

        <rdar://problem/7709115> REGRESSION: toolbar is missing at http://www.glom.org/
        https://bugs.webkit.org/show_bug.cgi?id=35507

        * css/CSSImportRule.cpp:
        (WebCore::CSSImportRule::setCSSStyleSheet): Extend the change made in
        <http://trac.webkit.org/changeset/48818> to detect the two variants of
        KHTMLFixes.css in @import rules as well as in <link> elements.

174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
2010-03-12  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Geoff Garen.

        Bug 36052 - [Qt] REGRESSION(55878) 63 test cases crash

        r55878 changed UStringImpl::empty()->characters() to be non-null,
        so TextBreakIteratorQt.cpp now should check the length of strings
        (previously was assuming all strings with a non-null data pointer
        had a length of at least 1).

        * platform/text/qt/TextBreakIteratorQt.cpp:
        (WebCore::wordBreakIterator):
        (WebCore::characterBreakIterator):
        (WebCore::lineBreakIterator):
        (WebCore::sentenceBreakIterator):

191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
2010-03-12  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG fallback color doesn't work for bogus gradients.
        https://bugs.webkit.org/show_bug.cgi?id=35479

        Use a given fallback color on ignored gradients if present. Gradients
        must be ignored, if one dimension of the objects boundingBox is zero.

        Test: svg/custom/gradient-with-1d-boundingbox.svg

        * svg/graphics/SVGPaintServer.cpp:
        (WebCore::SVGPaintServer::strokePaintServer):
        * svg/graphics/SVGPaintServerGradient.cpp:
        (WebCore::SVGPaintServerGradient::setup):

208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
2010-03-12  David Hyatt  <hyatt@apple.com>

        Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=36069
        
        Eliminate InlineRunBox.

        * WebCore.xcodeproj/project.pbxproj:
        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::adjustPosition):
        (WebCore::InlineFlowBox::paintFillLayer):
        (WebCore::InlineFlowBox::paintBoxDecorations):
        (WebCore::InlineFlowBox::paintMask):
        * rendering/InlineFlowBox.h:
        (WebCore::InlineFlowBox::InlineFlowBox):
        (WebCore::InlineFlowBox::prevLineBox):
        (WebCore::InlineFlowBox::nextLineBox):
        (WebCore::InlineFlowBox::setNextLineBox):
        (WebCore::InlineFlowBox::setPreviousLineBox):
        * rendering/InlineRunBox.h: Removed.
        * rendering/InlineTextBox.h:
        (WebCore::InlineTextBox::InlineTextBox):
        (WebCore::InlineTextBox::prevTextBox):
        (WebCore::InlineTextBox::nextTextBox):
        (WebCore::InlineTextBox::setNextTextBox):
        (WebCore::InlineTextBox::setPreviousTextBox):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::destroy):
        (WebCore::RenderBlock::rightmostPosition):
        (WebCore::RenderBlock::leftmostPosition):
        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::destroy):
        (WebCore::RenderInline::absoluteRects):
        (WebCore::RenderInline::absoluteQuads):
        (WebCore::RenderInline::linesBoundingBox):
        (WebCore::RenderInline::linesVisibleOverflowBoundingBox):
        (WebCore::RenderInline::addFocusRingRects):
        (WebCore::RenderInline::paintOutline):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::localBoundingBox):
        * rendering/RenderLineBoxList.cpp:
        (WebCore::RenderLineBoxList::deleteLineBoxTree):
        (WebCore::RenderLineBoxList::extractLineBox):
        (WebCore::RenderLineBoxList::attachLineBox):
        (WebCore::RenderLineBoxList::removeLineBox):
        (WebCore::RenderLineBoxList::deleteLineBoxes):
        (WebCore::RenderLineBoxList::dirtyLineBoxes):
        (WebCore::RenderLineBoxList::paint):
        (WebCore::RenderLineBoxList::hitTest):
        (WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
        (WebCore::RenderLineBoxList::checkConsistency):
        * rendering/RenderSVGInline.cpp:
        (WebCore::RenderSVGInline::absoluteRects):
        (WebCore::RenderSVGInline::absoluteQuads):
        * rendering/RenderSVGText.cpp:
        (WebCore::RenderSVGText::absoluteRects):
        (WebCore::RenderSVGText::absoluteQuads):
        (WebCore::RenderSVGText::objectBoundingBox):
        * rendering/RenderText.cpp:
        (WebCore::RenderText::extractTextBox):
        (WebCore::RenderText::attachTextBox):
        (WebCore::RenderText::removeTextBox):
        (WebCore::RenderText::createInlineTextBox):
        (WebCore::RenderText::positionLineBox):
        * rendering/RootInlineBox.h:
        (WebCore::RootInlineBox::nextRootBox):
        (WebCore::RootInlineBox::prevRootBox):

277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
2010-03-12  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Eric Carlson.

        media/video-preload.html fails
        https://bugs.webkit.org/show_bug.cgi?id=35793

        Only effectively load, and start buffering when playing, or when
        the preload attribute is set.

        Test: media/video-preload.html

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
        (WebCore::MediaPlayerPrivate::load):
        (WebCore::MediaPlayerPrivate::commitLoad):
        (WebCore::MediaPlayerPrivate::prepareToPlay):
        (WebCore::MediaPlayerPrivate::setPreload):
        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

dimich@chromium.org's avatar
dimich@chromium.org committed
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
2010-03-12  Dmitry Titov  <dimich@chromium.org>

        Not reviewed, build fix.

        Reverts 55920 and 55921. Landing for Jian Li.

        * Android.derived.jscbindings.mk:
        * Android.derived.v8bindings.mk:
        * DerivedSources.cpp:
        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pri:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSDOMFormDataCustom.cpp: Removed.
        * bindings/js/JSXMLHttpRequestCustom.cpp:
        (WebCore::JSXMLHttpRequest::send):
        * bindings/scripts/CodeGeneratorJS.pm:
        * bindings/v8/V8Index.h:
        * bindings/v8/custom/V8DOMFormDataCustom.cpp: Removed.
        * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
        (WebCore::V8XMLHttpRequest::sendCallback):
        * html/DOMFormData.idl: Removed.
        * page/DOMWindow.idl:

323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
2010-03-12  Jakob Petsovits  <jpetsovits@rim.com>

        Reviewed by Dirk Schulze.

        [OpenVG] Add support for drawing text to PainterOpenVG
        https://bugs.webkit.org/show_bug.cgi?id=35581

        Doesn't come with any actual font classes, as OpenVG
        by itself doesn't provide any access to platform fonts
        but just the means to draw glyphs that have been loaded
        manually before.

        * platform/graphics/openvg/PainterOpenVG.cpp:
        (WebCore::PlatformPainterState::PlatformPainterState):
        (WebCore::PlatformPainterState::copyPaintState):
        (WebCore::PainterOpenVG::textDrawingMode):
        (WebCore::PainterOpenVG::setTextDrawingMode):
        (WebCore::PainterOpenVG::drawText):
        * platform/graphics/openvg/PainterOpenVG.h:

343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
2010-03-12  Jakob Petsovits  <jpetsovits@rim.com>

        Reviewed by Dirk Schulze.

        [OpenVG] Use masks to implement non-rectilinear clipping
        https://bugs.webkit.org/show_bug.cgi?id=35544

        Requires some additional context switching logic to
        make sure the right context is current when dealing
        with the mask, because we don't store it by ourselves.

        Initial version of this code was written by
        Eli Fidler <efidler@rim.com>, I did a couple of
        bug fixes and efficiency improvements since then.

        * platform/graphics/openvg/GraphicsContextOpenVG.cpp:
        (WebCore::GraphicsContext::clipPath):
        (WebCore::GraphicsContext::clip):
        (WebCore::GraphicsContext::clipOut):
        (WebCore::GraphicsContext::clipOutEllipseInRect):
        (WebCore::GraphicsContext::addInnerRoundedRectClip):
        * platform/graphics/openvg/PainterOpenVG.cpp:
        (WebCore::PlatformPainterState::PlatformPainterState):
        (WebCore::PlatformPainterState::~PlatformPainterState):
        (WebCore::PlatformPainterState::maskingEnabled):
        (WebCore::PlatformPainterState::applyState):
        (WebCore::PlatformPainterState::saveMaskIfNecessary):
        (WebCore::PainterOpenVG::intersectClipRect):
        (WebCore::PainterOpenVG::clipPath):
        (WebCore::PainterOpenVG::save):
        * platform/graphics/openvg/PainterOpenVG.h:
        (WebCore::PainterOpenVG::):
        * platform/graphics/openvg/SurfaceOpenVG.cpp:
        (WebCore::SurfaceOpenVG::makeCurrent):
        (WebCore::SurfaceOpenVG::makeCompatibleCurrent):
        * platform/graphics/openvg/SurfaceOpenVG.h:
        (WebCore::SurfaceOpenVG::):

381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
2010-03-12  Jian Li  <jianli@chromium.org>

        Reviewed by Sam Weinig.

        Add DOMFormData.idl to expose FormData interface.
        https://bugs.webkit.org/show_bug.cgi?id=36024
        
        The implementation is based on XMLHttpRequest 2 spec:
        http://dev.w3.org/2006/webapi/XMLHttpRequest-2/#formdata

        Test: http/tests/local/send-form-data.html

        * Android.derived.jscbindings.mk:
        * Android.derived.v8bindings.mk:
        * DerivedSources.cpp:
        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.pri:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSDOMFormDataCustom.cpp: Added.
        * bindings/js/JSXMLHttpRequestCustom.cpp:
        (WebCore::JSXMLHttpRequest::send):
        * bindings/scripts/CodeGeneratorJS.pm:
        * html/DOMFormData.idl: Added.
        * page/DOMWindow.idl:

408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
2010-03-12  Jakob Petsovits  <jpetsovits@rim.com>

        Reviewed by Dirk Schulze.

        [OpenVG] Add a SurfaceOpenVG constructor for EGL client buffer surfaces
        https://bugs.webkit.org/show_bug.cgi?id=35538

        SurfaceOpenVG can now not only encapsulate pbuffer
        and window surfaces but also VGImage-based ones.

        * platform/graphics/openvg/EGLDisplayOpenVG.cpp:
        (WebCore::EGLDisplayOpenVG::createPbufferFromClientBuffer):
        * platform/graphics/openvg/EGLDisplayOpenVG.h:
        * platform/graphics/openvg/SurfaceOpenVG.cpp:
        (WebCore::SurfaceOpenVG::SurfaceOpenVG):
        * platform/graphics/openvg/SurfaceOpenVG.h:

425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
2010-03-12  Alpha Lam  <hclam@chromium.org>

        Reviewed by Eric Carlson.

        Fix a crash when resource loading of media element is canceled.
        https://bugs.webkit.org/show_bug.cgi?id=35992

        Use of HTMLMediaElement::duration() after resource loading was canceled
        will cause a crash. This is because HTMLMediaElement::m_player is used
        when NULL.
        Test: http/tests/media/video-cancel-load.html

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::duration):
        Avoid calling to m_player when it is null.
        (WebCore::HTMLMediaElement::userCancelledLoad):
        Set m_readyState to HAVE_NOTHING.

443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
2010-03-12  Dan Bernstein  <mitz@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/7725534> CSSPrimitiveValue::parserValue() returns deleted memory
        https://bugs.webkit.org/show_bug.cgi?id=20069

        No test added, since with the CSS variables feature disabled, the pointer
        to the freed memory is never dereferenced.

        * css/CSSPrimitiveValue.cpp:
        (WebCore::valueOrPropertyName): Changed to return a const AtomicString& from
        a static table.
        (WebCore::CSSPrimitiveValue::parserValue): Updated for the above change.

mitz@apple.com's avatar
mitz@apple.com committed
458
459
460
461
462
463
2010-03-12  Dan Bernstein  <mitz@apple.com>

        Build fix.

        * platform/chromium/PlatformKeyboardEventChromium.cpp:

464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
2010-03-12  Dan Bernstein  <mitz@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/7694674> Hover states not updated when overflow section scrolls under stationary mouse pointer
        https://bugs.webkit.org/show_bug.cgi?id=35949

        Test: fast/events/overflow-scroll-fake-mouse-move.html

        Soon after an overflow section scrolls under the mouse pointer, dispatch
        a fake mouse move event. This is similar to how frame scrolling is handled
        in WebKit, and has the effect of updating hover state, dispatching DOM mouse
        events, and updating the tool tip.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::EventHandler): Initialize m_fakeMouseMoveEventTimer.
        (WebCore::EventHandler::~EventHandler): Assert that the timer is not active.
        (WebCore::EventHandler::clear): Stop the timer.
        (WebCore::EventHandler::handleMousePressEvent): Cancel pending fake mouse
        move events.
        (WebCore::EventHandler::handleMouseMoveEvent): Ditto.
        (WebCore::EventHandler::dispatchFakeMouseMoveEventSoonInQuad): If the mouse
        is in the passed-in quad, ensure that a fake mouse move event is scheduled
        to fire soon.
        (WebCore::EventHandler::cancelFakeMouseMoveEvent): Does what the name says.
        (WebCore::EventHandler::fakeMouseMoveEventTimerFired): Constructs a
        PlatformMouseEvent with the current mouse location, modifier key state and
        time stamp and calls mouseMoved().
        * page/EventHandler.h:
        * platform/PlatformKeyboardEvent.h: Declared getCurrentModifierState().
        * platform/android/KeyEventAndroid.cpp:
        (WebCore::PlatformKeyboardEvent::getCurrentModifierState): Stubbed out.
        * platform/brew/PlatformKeyboardEventBrew.cpp:
        (WebCore::PlatformKeyboardEvent::getCurrentModifierState): Ditto.
        * platform/chromium/PlatformKeyboardEventChromium.cpp:
        (WebCore::PlatformKeyboardEvent::getCurrentModifierState): Added.
        * platform/efl/PlatformKeyboardEventEfl.cpp:
        (WebCore::PlatformKeyboardEvent::getCurrentModifierState): Stubbed out.
        * platform/gtk/KeyEventGtk.cpp:
        (WebCore::PlatformKeyboardEvent::getCurrentModifierState): Ditto.
        * platform/haiku/PlatformKeyboardEventHaiku.cpp:
        (WebCore::PlatformKeyboardEvent::getCurrentModifierState): Added.
        * platform/mac/KeyEventMac.mm:
        (WebCore::PlatformKeyboardEvent::getCurrentModifierState): Ditto.
        * platform/qt/PlatformKeyboardEventQt.cpp:
        (WebCore::PlatformKeyboardEvent::getCurrentModifierState): Stubbed out.
        * platform/win/KeyEventWin.cpp:
        (WebCore::PlatformKeyboardEvent::getCurrentModifierState): Added.
        * platform/wx/KeyboardEventWx.cpp:
        (WebCore::PlatformKeyboardEvent::getCurrentModifierState): Ditto.
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::scrollToOffset): Call
        EventHandler::dispatchFakeMouseMoveEventSoonInQuad(). Moved things around
        a little to avoid computing the repaint rect twice.

519
520
521
522
523
524
525
526
527
528
529
530
2010-03-12  Kent Hansen  <kent.hansen@nokia.com>

        Reviewed by Darin Adler.

        Webkit doesn't build with workers on and database off
        https://bugs.webkit.org/show_bug.cgi?id=35997

        Added missing ENABLE(DATABASE) guards.

        * workers/WorkerThread.cpp:
        (WebCore::WorkerThreadShutdownStartTask::performTask):

531
532
533
534
535
536
537
538
539
540
541
2010-03-12  Dan Winship  <danw@gnome.org>

        Reviewed by Gustavo Noronha.

        Make the defaultCookieJar use a no-third-party policy. Most
        applications set their own cookie jar, but DumpRenderTree doesn't,
        so it was failing the new third-party-cookie test.

        * platform/network/soup/CookieJarSoup.cpp:
        (WebCore::defaultCookieJar):

542
543
544
545
546
547
548
549
550
551
552
2010-03-11  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] Enable network state notifier when compiling against Qt 4.7
        https://bugs.webkit.org/show_bug.cgi?id=35983

        * WebCore.pri:
        * platform/network/qt/NetworkStateNotifierPrivate.h:
        * platform/network/qt/NetworkStateNotifierQt.cpp:

553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
2010-03-11  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Adam Treat.

        Do not render the full frame when there is some elements with fixed positioning
        https://bugs.webkit.org/show_bug.cgi?id=33150

        The frame view take into acount the list of fixed object when scrolling
        the view. If the number of object is lower than a certain threshold, the pixel
        are blitted, and the invalidated area updated.

        * page/FrameView.cpp:
        (WebCore::FrameView::FrameView):
        (WebCore::FrameView::useSlowRepaints):
        (WebCore::FrameView::useSlowRepaintsIfNotOverlapped):
        (WebCore::FrameView::addFixedObject):
        (WebCore::FrameView::removeFixedObject):
        (WebCore::FrameView::scrollContentsFastPath):
        * page/FrameView.h:
        * platform/ScrollView.cpp:
        (WebCore::ScrollView::scrollContents):
        (WebCore::ScrollView::scrollContentsFastPath):
        * platform/ScrollView.h:
        * rendering/RenderBlock.h:
        (WebCore::RenderBlock::positionedObjects):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::styleWillChange):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::styleWillChange):

583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
2010-03-11  Aaron Boodman  <aa@chromium.org>

        Kill WebDocument::applicationID() (part 1).

        Modify interface to WebCore::NotificationPresenter::checkPermission()
        and remove implementation of WebDocument::applicationID(). Breaking
        API changes will be in a subsequent change.
        https://bugs.webkit.org/show_bug.cgi?id=35846

        * notifications/Notification.cpp:
        (WebCore::Notification::Notification):
        * notifications/NotificationCenter.cpp:
        (WebCore::NotificationCenter::checkPermission):
        * notifications/NotificationPresenter.h:

598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
2010-03-11  Dmitry Titov  <dimich@chromium.org>

        Reviewed by David Levin.

        [v8] Remove obsolete code for delayed dereferencing of DOM objects for single-heap, multithread v8 usage.
        https://bugs.webkit.org/show_bug.cgi?id=36043

        No new tests, no changes in functionality.

        * bindings/v8/DOMData.cpp:
        (WebCore::DOMData::DOMData):
        * bindings/v8/DOMData.h:
        (WebCore::DOMData::handleWeakObject):
        * bindings/v8/DOMDataStore.cpp:
        * bindings/v8/DOMDataStore.h:
        (WebCore::DOMDataStore::domObjectMap):
        (WebCore::DOMDataStore::activeDomObjectMap):
        (WebCore::DOMDataStore::domSvgElementInstanceMap):
        (WebCore::DOMDataStore::domSvgObjectWithContextMap):
        * bindings/v8/ScopedDOMDataStore.cpp:
        (WebCore::ScopedDOMDataStore::ScopedDOMDataStore):
        * bindings/v8/StaticDOMDataStore.cpp:
        (WebCore::StaticDOMDataStore::StaticDOMDataStore):
        * bindings/v8/StaticDOMDataStore.h:
        * bindings/v8/V8DOMMap.cpp:
        (WebCore::removeAllDOMObjectsInCurrentThread):

625
626
627
628
629
630
631
632
2010-03-11  Gavin Barraclough  <barraclough@apple.com>

        Rubber stamped by Oliver Hunt.

        Remove nonsense comments used in development & commited in error.

        * platform/text/StringImpl.h:

633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
2010-03-11  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Oliver Hunt.

        https://bugs.webkit.org/show_bug.cgi?id=36041
        Remove unnecessary differences in common code between WebCore::StringImpl & JSC::UStringImpl

        Much of the code in WebCore::StringImpl and JSC::UStringImpl is now very similar,
        but has trivial and unnecessary formatting differences, such as the exact wording
        of comments, missing ASSERTs, functions implemented in the .h vs .cpp etc.

        * platform/text/StringImpl.cpp:
        (WebCore::StringImpl::empty): Reordered in file, made empty()->characters() return a non-null value to match JSC.
        (WebCore::StringImpl::createUninitialized): Added overflow check.
        (WebCore::StringImpl::create): Reordered in file.
        (WebCore::StringImpl::sharedBuffer): Reordered in file.
        * platform/text/StringImpl.h:
        (WebCore::StringImpl::): Remove ThreadGlobalData as friend, move SharableUChar & SharedUChar to WebCore namespace.
        (WebCore::StringImpl::StringImpl): Made static constructor method (used to create empty string) take arguments, to match JSC & prevent accidental use.
        (WebCore::StringImpl::setHash): Added missing ASSERT.
        (WebCore::StringImpl::adopt): Make adpot work with Vectors with a non-zero inline capacity.
        (WebCore::StringImpl::characters): Mark as const to match JSC.
        (WebCore::StringImpl::hash): Use !m_hash instead of m_hash == 0.
        (WebCore::StringImpl::computeHash): Remove redundant 'inline'.

658
659
660
661
662
663
664
665
666
667
2010-03-11  Mark Rowe  <mrowe@apple.com>

        Reviewed by David Kilzer.

        <rdar://problem/7745082> Make it possible to build WebKit for older Mac OS X versions from the current Mac OS X version

        Default to using the appropriate SDK if the target Mac OS X version is not the current Mac OS X version.

        * Configurations/Base.xcconfig:

668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
2010-03-11  Jungshik Shin  <jshin@chromium.org>

        [Chromium]: Plane 2 characters are rendered "blank" 
         (not even empty boxes) on Windows even when there are fonts to
         cover them. 

        https://bugs.webkit.org/show_bug.cgi?id=35605

        Test:LayoutTests/fast/text/international/plane2.html 

        * platform/graphics/chromium/FontCacheChromiumWin.cpp:
        (WebCore::LookupAltName): Add two ExtB fonts to the array (namePairs) that are used for Plane 2 character rendering.
        (WebCore::FontCache::getFontDataForCharacters): Add two more fonts to the fallback font list
        * platform/graphics/chromium/FontUtilsChromiumWin.cpp:
        (WebCore::getFallbackFamily): Fix the fallback font lookup to cover Plane 2 (CJK ExtB).

684
685
686
687
688
689
690
691
692
2010-03-11  Leandro Pereira  <leandro@profusion.mobi>

        Reviewed by Holger Freyther.

        Add EFL port files to platform/efl.
        http://webkit.org/b/35889

        * platform/efl/SystemTimeEfl.cpp: Added.

693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
2010-03-11  Mark Rowe  <mrowe@apple.com>

        Reviewed by Tim Hatcher.

        <rdar://problem/7745082> Make it possible to build WebKit for older Mac OS X versions from the current Mac OS X version

        Introduce TARGET_MAC_OS_X_VERSION_MAJOR to represent the Mac OS X version that is being targeted.  It defaults to the
        current Mac OS X version unless otherwise specified.

        Key off TARGET_MAC_OS_X_VERSION_MAJOR where we'd previously been keying off MAC_OS_X_VERSION_MAJOR.

        Explicitly map from the target Mac OS X version to the preferred compiler since Xcode's default compiler choice
        may not be usable when targetting a different Mac OS X version.

        Key off TARGET_GCC_VERSION rather than MAC_OS_X_VERSION_MAJOR in locations where we'd previously been keying off
        MAC_OS_X_VERSION_MAJOR but the decision is really related to the compiler version being used.

        * Configurations/Base.xcconfig:
        * Configurations/DebugRelease.xcconfig:
        * Configurations/FeatureDefines.xcconfig:
        * Configurations/Version.xcconfig:
        * Configurations/WebCore.xcconfig:

716
717
718
719
720
721
722
723
724
725
726
727
2010-03-11  Anders Carlsson  <andersca@apple.com>

        Reviewed by David Hyatt.

        Remove invalidateContents, it isn't used and it never makes sense to only invalidate the contents.

        * loader/EmptyClients.h:
        * page/Chrome.cpp:
        * page/Chrome.h:
        * page/ChromeClient.h:
        * platform/HostWindow.h:

728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
2010-03-11  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        [V8] Remove DOMObjectsInclude.h and update headers accordingly.

        https://bugs.webkit.org/show_bug.cgi?id=36036

        * WebCore.gypi:
        * bindings/v8/DOMData.h:
        * bindings/v8/DOMDataStore.h:
        * bindings/v8/DOMObjectsInclude.h: Removed.
        * bindings/v8/V8DOMMap.cpp:
        * bindings/v8/V8DOMWindowShell.cpp:
        * bindings/v8/V8DOMWrapper.cpp:
        * bindings/v8/V8GCController.cpp:
        * bindings/v8/V8Proxy.cpp:

746
747
748
749
750
751
752
753
2010-03-11  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Mark Rowe.

        Remove duplicate entries revealed after sorting.

        * WebCore.xcodeproj/project.pbxproj:

754
755
756
757
758
759
760
761
762
2010-03-11  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Mark Rowe.

        Sort the project file (also removing some bogus spaces that caused Xcode to rewrite the file
        every time you opened it).

        * WebCore.xcodeproj/project.pbxproj:

763
764
765
766
767
768
769
770
771
772
773
774
2010-03-11  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        Fix style issues and improve comments from 
        http://trac.webkit.org/changeset/55853.

        https://bugs.webkit.org/show_bug.cgi?id=36029

        * platform/animation/TimingFunction.h:
        (WebCore::TimingFunction::TimingFunction):

775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
2010-03-11  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Beth Dakin.

        accessibilityIsIgnoredBase() needs to respect when platform says include
        https://bugs.webkit.org/show_bug.cgi?id=36025

        Changed accessibilityIsIgnoredBase() to return a policy instead of a yes/no
        answer. This allows the platform to make a yes decision on an element.

        * accessibility/AccessibilityList.cpp:
        (WebCore::AccessibilityList::accessibilityIsIgnored):
        * accessibility/AccessibilityListBox.cpp:
        (WebCore::AccessibilityListBox::accessibilityIsIgnored):
        * accessibility/AccessibilityObject.h:
        (WebCore::):
        (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
        (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::accessibilityIsIgnoredBase):
        (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
        * accessibility/AccessibilityRenderObject.h:
        * accessibility/AccessibilitySlider.cpp:
        (WebCore::AccessibilitySlider::accessibilityIsIgnored):
        * accessibility/AccessibilityTable.cpp:
        (WebCore::AccessibilityTable::accessibilityIsIgnored):
        * accessibility/AccessibilityTableCell.cpp:
        (WebCore::AccessibilityTableCell::accessibilityIsIgnored):
        * accessibility/AccessibilityTableRow.cpp:
        (WebCore::AccessibilityTableRow::accessibilityIsIgnored):
        * accessibility/chromium/AccessibilityObjectChromium.cpp:
        (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
        * accessibility/gtk/AccessibilityObjectAtk.cpp:
        (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
        * accessibility/mac/AccessibilityObjectMac.mm:
        (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
        * accessibility/qt/AccessibilityObjectQt.cpp:
        (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
        * accessibility/win/AccessibilityObjectWin.cpp:
        (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
        * accessibility/wx/AccessibilityObjectWx.cpp:
        (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

818
819
820
821
822
823
824
825
826
827
828
829
830
2010-03-11  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        Fix build breakage with ENABLE_3D_CANVAS=0
        https://bugs.webkit.org/show_bug.cgi?id=35995

        No new tests; verified in Chromium that WebGL is disabled in
        ENABLE_3D_CANVAS=0 builds.

        * bindings/v8/custom/V8DocumentCustom.cpp:
        * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

831
832
833
834
835
836
837
838
839
840
841
2010-03-11  Nate Chapin  <japhet@chromium.org>

        Unreviewed, Chromium mac build fix.

        Add an explicit copy constructor to TimingFunction.
        http://trac.webkit.org/changeset/55835 trigged an inlining
        bug in gcc that the copy constructor resolves.

        * platform/animation/TimingFunction.h:
        (WebCore::TimingFunction::TimingFunction):

cfleizach@apple.com's avatar
cfleizach@apple.com committed
842
843
844
845
846
847
848
849
850
851
852
853
2010-03-11  Chris Fleizach  <cfleizach@apple.com>

        Fixing GTK. No review.

        support lang attribute on <option> elements
        https://bugs.webkit.org/show_bug.cgi?id=36021
 
        We don't need to cast to AccessibilityRenderObject to get language().

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (webkit_accessible_document_get_locale):

854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
2010-03-11  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Darin Adler.

        support lang attribute on <option> elements
        https://bugs.webkit.org/show_bug.cgi?id=36021

        Allow non AccessibilityRenderObject classes to access the lang
        attribute by moving the useful code into AccessibilityObject.

        Test: platform/mac/accessibility/option-with-lang.html

        * accessibility/AccessibilityListBoxOption.cpp:
        (WebCore::AccessibilityListBoxOption::language):
        * accessibility/AccessibilityListBoxOption.h:
        * accessibility/AccessibilityObject.cpp:
        (WebCore::AccessibilityObject::language):
        * accessibility/AccessibilityObject.h:
        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::language):
        * accessibility/AccessibilityRenderObject.h:

876
877
878
879
880
881
882
883
884
885
2010-03-11  Diego Gonzalez  <diego.gonzalez@openbossa.org>

        Reviewed by Simon Hausmann.

        [Qt] Access key modifier should be Ctrl+Alt for Darwin derived OS and Alt for the others
        https://bugs.webkit.org/show_bug.cgi?id=35993

        * page/qt/EventHandlerQt.cpp:
        (WebCore::EventHandler::accessKeyModifiers):

886
887
888
889
890
891
892
893
894
895
896
2010-03-08  Brett Wilson  <brettw@chromium.org>

        Reviewed by Adam Barth.

        Remove the deprecated argument to url_util::IsStandard in preparation
        for deleting that version of the function. Pull the latest googleurl
        with the new version for the Chromium builder.

        * platform/KURLGoogle.cpp:
        (WebCore::KURL::isHierarchical):

897
898
899
900
901
902
903
904
2010-03-11  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Tor Arne Vestbø.

        [Qt] Make it possible to do builds with separate debug info in packages

        * WebCore.pro:

905
906
907
908
909
910
911
912
913
914
915
916
917
2010-03-11  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Tor Arne Vestbø.

        [Qt] Avoid double-buffering with Qt image decoders

        Pass QIODevice::Unbuffered when opening the QBuffer that
        wraps the image data, to hint to Qt that no extra buffering
        is needed.

        * platform/graphics/qt/ImageDecoderQt.cpp:
        (WebCore::ImageDecoderQt::setData):

918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
2010-03-10  Ben Murdoch  <benm@google.com>

        Reviewed by Jeremy Orlow.

        [Android] The platform touch events on Android are missing support
        for key modifiers.
        https://bugs.webkit.org/show_bug.cgi?id=35521

        Add support in PlatformToucHEventAndroid for the platform supplying
        key modifiers with touch events.

        Fixes Android so it now passes basic-single-touch-events.html.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleTouchEvent): Fix two compiler warnings.
        * platform/PlatformTouchEvent.h:
        (WebCore::PlatformTouchEvent::PlatformTouchEvent): Add support for
            key modifiers on Android.
        * platform/android/PlatformTouchEventAndroid.cpp:
        (WebCore::PlatformTouchEvent::PlatformTouchEvent): ditto.

939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
2010-03-10  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        Implements Geolocation maximumAge property
        https://bugs.webkit.org/show_bug.cgi?id=30676

        Test: fast/dom/Geolocation/maximum-age.html

        * WebCore.xcodeproj/project.pbxproj: Modified. Adds GeolocationPositionCache.h to Private headers
        * page/Geolocation.cpp: Modified.
        (WebCore::Geolocation::GeoNotifier::setUseCachedPosition): Added.
        (WebCore::Geolocation::GeoNotifier::runSuccessCallback): Added.
        (WebCore::Geolocation::GeoNotifier::timerFired): Modified. Added logic to handle using a cached position
        (WebCore::Geolocation::Watchers::contains): Added. Required to determine if a notifier is a watch request
        (WebCore::Geolocation::startRequest): Modified. Added logic to check for a cached position
        (WebCore::Geolocation::requestUsesCachedPosition): Added. Callback to Geolocation object when notifier uses a cached position
        (WebCore::Geolocation::makeCachedPositionCallbacks): Added.
        (WebCore::Geolocation::haveSuitableCachedPosition): Added.
        (WebCore::Geolocation::setIsAllowed): Modified.
        (WebCore::Geolocation::positionChanged): Modified. Make callbacks using cached position where appropriate
        (WebCore::Geolocation::geolocationServiceErrorOccurred): Modified. Make callbacks using cached position where appropriate
        * page/Geolocation.h: Modified.

963
964
965
966
967
968
969
2010-03-11  Csaba Osztrogonác  <ossy@webkit.org>

        Unreviewed buildfix after r55823. (To fix Qt --minimal build.)
        I have déjà vu, I'm sure that I did it before. (r55598)

        * bindings/js/JSDOMWindowCustom.cpp: Missing #if ENABLE(DATABASE) guard added. 

970
971
972
973
974
975
976
977
978
979
980
2010-03-11  Csaba Osztrogonác  <ossy@webkit.org>

        [Qt] Unreviewed buildfix after r55833.

        Rename all instances of data() to characters()

        * bridge/qt/qt_class.cpp:
        (JSC::Bindings::QtClass::fieldNamed):
        * bridge/qt/qt_runtime.cpp:
        (JSC::Bindings::convertValueToQVariant):

981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
2010-03-11  Zoltan Horvath  <zoltan@webkit.org>

        Reviewed by Simon Hausmann.

        Allow custom memory allocation control for RenderLayerBacking class
        https://bugs.webkit.org/show_bug.cgi?id=35857

        Inherits the following class from Noncopyable because it is
        instantiated by 'new' and no need to be copyable:                                     

        class name    - instantiated at: WebCore/'location'
        RenderLayerBacking - rendering/RenderLayer.cpp:3047

        * rendering/RenderLayerBacking.h:

996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
2010-03-11  Zoltan Horvath  <zoltan@webkit.org>

        Reviewed by Simon Hausmann.

        Allow custom memory allocation control for TimingFunction struct
        https://bugs.webkit.org/show_bug.cgi?id=35855

        Inherits the following struct from FastAllocBase because it is 
        instantiated by 'new':

        class name    - instantiated at: WebCore/'location'
        TimingFuction - platform/graphics/GraphicsLayer.h:89

        * platform/animation/TimingFunction.h:

1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
2010-03-10  Gavin Barraclough  <barraclough@apple.com>

        Rubber stamped by Oliver Hunt.
        
        Rename JSC::UStringImpl::data() to characters(), to match WebCore::StringImpl.

        * bridge/jni/jsc/JavaStringJSC.h:
        (JSC::Bindings::JavaStringImpl::uchars):
        * platform/text/AtomicString.cpp:
        (WebCore::AtomicString::add):
        (WebCore::AtomicString::find):

1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
2010-03-10  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Mark Rowe.

        Fix for r55825, threadsafeCopy no longer needs to special-case for
        empty strings (in fact, doing so results in leaks).

        * platform/text/StringImpl.cpp:
        (WebCore::StringImpl::threadsafeCopy):

1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
2010-03-10  Chang Shu  <chang.shu@nokia.com>

        Reviewed by Darin Adler.

        While calculating alpha channel, convert the floating point value to
        an integer in [0, 256) with equal distribution.
        https://bugs.webkit.org/show_bug.cgi?id=22150

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseColorParameters):

1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
2010-03-10  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Darin Adler, Geoffrey Garen, Maciej Stachowiak.

        https://bugs.webkit.org/show_bug.cgi?id=35991
        Would be faster to not use a thread specific to implement StringImpl::empty()

        Copy JavaScriptCore in making 'static' strings threadsafe, make the empty string a static,
        shared by all threads.

        ~2% progression on Dromaeo DOM core & JS lib tests.

        * platform/ThreadGlobalData.cpp:
        (WebCore::ThreadGlobalData::ThreadGlobalData):
        (WebCore::ThreadGlobalData::~ThreadGlobalData):
        * platform/ThreadGlobalData.h:
        (WebCore::ThreadGlobalData::eventNames):
        * platform/text/StringImpl.cpp:
        (WebCore::StringImpl::StringImpl):
        (WebCore::StringImpl::empty):
        * platform/text/StringImpl.h:
        (WebCore::StringImpl::deref):
        (WebCore::StringImpl::hasOneRef):

1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
2010-03-08  Dumitru Daniliuc  <dumi@chromium.org>

        Reviewed by Adam Barth.

        Adding support for the optional creation callback that could be
        passed to openDatabase().

        Tests: storage/open-database-creation-callback.html
               storage/open-database-creation-callback-isolated-world.html

        https://bugs.webkit.org/show_bug.cgi?id=34726

        * Android.jscbindings.mk
        * Android.v8bindings.mk
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::openDatabase):
        * bindings/js/JSDatabaseCallback.cpp: Added.
        (WebCore::JSDatabaseCallback::JSDatabaseCallback):
        (WebCore::JSDatabaseCallback::~JSDatabaseCallback):
        (WebCore::JSDatabaseCallback::handleEvent):
        * bindings/js/JSDatabaseCallback.h: Added.
        (WebCore::JSDatabaseCallback::create):
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::V8DOMWindow::openDatabaseCallback):
        * bindings/v8/custom/V8DatabaseCallback.cpp: Added.
        (WebCore::V8DatabaseCallback::V8DatabaseCallback):
        (WebCore::V8DatabaseCallback::~V8DatabaseCallback):
        (WebCore::V8DatabaseCallback::handleEvent):
        * bindings/v8/custom/V8DatabaseCallback.h: Added.
        (WebCore::V8DatabaseCallback::create):
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::openDatabase):
        * page/DOMWindow.h:
        * page/DOMWindow.idl:
        * storage/Database.cpp:
        (WebCore::DatabaseCreationCallbackTask::create):
        (WebCore::DatabaseCreationCallbackTask::performTask):
        (WebCore::DatabaseCreationCallbackTask::DatabaseCreationCallbackTask):
        (WebCore::Database::openDatabase):
        (WebCore::Database::Database):
        (WebCore::Database::performOpenAndVerify):
        (WebCore::Database::performCreationCallback):
        * storage/Database.h:
        (WebCore::Database::isNew):
        * storage/DatabaseCallback.h: Added.
        (WebCore::DatabaseCallback::~DatabaseCallback):
        * workers/WorkerContext.cpp:
        (WebCore::WorkerContext::openDatabase):
        * workers/WorkerContext.h:

1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
2010-03-10  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Adam Barth.

        Make Chrome consistently handle leading format characters in URLs

        https://bugs.webkit.org/show_bug.cgi?id=35948

        Test: http/tests/security/xss-DENIED-window-open-javascript-url-leading-format-char.html

        * platform/KURLGoogle.cpp:

1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
2010-03-10  Jian Li  <jianli@chromium.org>

        Reviewed by Dmitry Titov.

        Implementing DOMFormData class.
        https://bugs.webkit.org/show_bug.cgi?id=35707

        This patch only addresses the implementation of DOMFormData class and
        moves the FormData construction logic from HTMLFormElement::createFormData
        to FormData::create() so that it can be used by both HTMLFormElement
        and XMLHttpRequest.

        The DOMFormData IDL interface will be exposed in another patch and the
        test will be added then.

        * Android.mk:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * html/DOMFormData.cpp: Added.
        * html/DOMFormData.h: Added.
        * html/FormDataList.h:
        (WebCore::FormDataList::encoding):
        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::createFormData):
        (WebCore::HTMLFormElement::submit):
        * html/HTMLFormElement.h:
        * platform/network/FormData.cpp:
        (WebCore::FormData::create):
        (WebCore::FormData::createMultiPart):
        (WebCore::FormData::appendDOMFormData):
        * platform/network/FormData.h:
        (WebCore::FormData::boundary):
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::send):
        * xml/XMLHttpRequest.h:

1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
2010-03-10  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Beth Dakin.

        VoiceOver can navigate to hidden content in widget (WAI-ARIA)
        https://bugs.webkit.org/show_bug.cgi?id=35986

        Elements that are subclassers of AXRenderObject have not been respecting
        aria-hidden and other cases that would make them ignored. This applies
        to tables, rows, cells, select boxes, sliders, and lists. Select boxes
        also need to make sure their option elements respect aria-hidden as well.

        Test: accessibility/aria-hidden-with-elements.html

        * accessibility/AccessibilityList.cpp:
        (WebCore::AccessibilityList::accessibilityIsIgnored):
        * accessibility/AccessibilityListBox.cpp:
        (WebCore::AccessibilityListBox::addChildren):
        (WebCore::AccessibilityListBox::accessibilityIsIgnored):
        (WebCore::AccessibilityListBox::doAccessibilityHitTest):
        * accessibility/AccessibilityListBox.h:
        * accessibility/AccessibilityListBoxOption.cpp:
        (WebCore::AccessibilityListBoxOption::accessibilityIsIgnored):
        * accessibility/AccessibilityListBoxOption.h:
        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::accessibilityIsIgnoredCommon):
        (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
        (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
        * accessibility/AccessibilityRenderObject.h:
        * accessibility/AccessibilitySlider.cpp:
        (WebCore::AccessibilitySlider::accessibilityIsIgnored):
        * accessibility/AccessibilitySlider.h:
        (WebCore::AccessibilitySlider::roleValue):
        (WebCore::AccessibilitySliderThumb::roleValue):
        (WebCore::AccessibilitySliderThumb::accessibilityIsIgnored):
        * accessibility/AccessibilityTable.cpp:
        (WebCore::AccessibilityTable::accessibilityIsIgnored):
        * accessibility/AccessibilityTableCell.cpp:
        (WebCore::AccessibilityTableCell::accessibilityIsIgnored):
        * accessibility/AccessibilityTableColumn.cpp:
        (WebCore::AccessibilityTableColumn::accessibilityIsIgnored):
        * accessibility/AccessibilityTableColumn.h:
        (WebCore::AccessibilityTableColumn::roleValue):
        * accessibility/AccessibilityTableHeaderContainer.cpp:
        (WebCore::AccessibilityTableHeaderContainer::accessibilityIsIgnored):
        * accessibility/AccessibilityTableHeaderContainer.h:
        * accessibility/AccessibilityTableRow.cpp:
        (WebCore::AccessibilityTableRow::accessibilityIsIgnored):

1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
2010-03-10  Dmitry Titov  <dimich@chromium.org>

        Reviewed by Darin Adler.

        Make Document::postTask to use a single queue of tasks, to fire them in order
        https://bugs.webkit.org/show_bug.cgi?id=35943

        Test: existing worker-cloneport.html which was broken by initial patch in http://trac.webkit.org/changeset/55593.
        Additional test which indirectly verifies the order of execution will come as part of https://bugs.webkit.org/show_bug.cgi?id=34726

        * dom/Document.cpp:
        (WebCore::Document::postTask): Always use the same task queue, independent of what thread is posting the task.

1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
2010-03-10  Sanjeev Radhakrishnan  <sanjeevr@chromium.org>

        Reviewed by Darin Fisher.

        Allow a plugin to participate in the browser's print workflow.
        https://bugs.webkit.org/show_bug.cgi?id=35550

        * loader/PluginDocument.cpp:
        * loader/PluginDocument.h:

1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
2010-03-10  Ilya Tikhonovsky  <loislo@loislo-macbookpro.local>

        Reviewed by Pavel Feldman.

        Sidebar resize element height was adjusted.
        Display name for Function Call details was adjusted.

        https://bugs.webkit.org/show_bug.cgi?id=35939

        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel.prototype._refreshRecords):
        (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):

1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
2010-03-10  Charles Wei  <charles.wei@torchmobile.com.cn>

        Reviewed by George Staikos.

        Fix https://bugs.webkig.org/show_bug.cgi?id=35207
        When XHTMLMP is enabled, all xhtml documents fail to render for webkit portings wich use libxml2 tokenizer.

        No new tests as all the xhtml test cases in LayoutTests/dom/xhtml fails without this fix when XHTMLMP is enabled.

        * dom/Document.cpp:
        (WebCore::Document::isXHTMLMPDocument):
        * dom/XMLTokenizerLibxml2.cpp:
        (WebCore::XMLTokenizer::internalSubset):
        (WebCore::externalSubsetHandler):

1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
2010-03-10  Garret Kelly  <gdk@chromium.org>

        Reviewed by Darin Fisher.

        Adding all of the touch-related sources into Chromium's WebCore build.
        https://bugs.webkit.org/show_bug.cgi?id=35874

        Patch tested against the try bots, but the feature is exercised in the
        fast/events/touch tests.

        * WebCore.gypi:

1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
2010-03-10  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: now that audits panel is added, add it to the
        enums (for storing last active, etc.).

        https://bugs.webkit.org/show_bug.cgi?id=35980

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::setWindowVisible):
        (WebCore::InspectorController::specialPanelForJSName):
        * inspector/InspectorController.h:
        (WebCore::InspectorController::):
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::showPanel):
        * inspector/front-end/inspector.js:
        (WebInspector.showAuditsPanel):

1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
2010-03-10  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        [V8] Instead of describing the type of a wrapped v8 object
        with an enum value, use a pointer to struct with more complete
        information.

        https://bugs.webkit.org/show_bug.cgi?id=35941

        Refactoring only, so new tests.

        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/DOMData.cpp:
        * bindings/v8/DOMData.h:
        * bindings/v8/NPV8Object.cpp:
        * bindings/v8/V8Collection.h:
        * bindings/v8/V8DOMWindowShell.cpp:
        * bindings/v8/V8DOMWindowShell.h:
        * bindings/v8/V8DOMWrapper.cpp:
        * bindings/v8/V8DOMWrapper.h:
        * bindings/v8/V8GCController.cpp:
        * bindings/v8/V8Helpers.cpp:
        * bindings/v8/V8Helpers.h:
        * bindings/v8/V8Index.cpp: Removed.
        * bindings/v8/V8Index.h:
        * bindings/v8/V8NPObject.cpp:
        * bindings/v8/V8Proxy.cpp:
        * bindings/v8/V8Proxy.h:
        * bindings/v8/WorkerContextExecutionProxy.cpp:
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        * bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
        * bindings/v8/custom/V8HTMLAudioElementConstructor.h:
        * bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
        * bindings/v8/custom/V8HTMLImageElementConstructor.h:
        * bindings/v8/custom/V8HTMLOptionElementConstructor.cpp:
        * bindings/v8/custom/V8HTMLOptionElementConstructor.h:
        * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
        * bindings/v8/custom/V8MessageChannelConstructor.cpp:
        * bindings/v8/custom/V8SharedWorkerCustom.cpp:
        * bindings/v8/custom/V8WebGLArrayBufferCustom.cpp:
        * bindings/v8/custom/V8WebGLArrayCustom.h:
        * bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
        * bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
        * bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
        * bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
        * bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
        * bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
        * bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
        * bindings/v8/custom/V8WebKitCSSMatrixConstructor.cpp:
        * bindings/v8/custom/V8WebKitPointConstructor.cpp:
        * bindings/v8/custom/V8WebSocketCustom.cpp:
        * bindings/v8/custom/V8WorkerCustom.cpp:
        * bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
        * bindings/v8/custom/V8XSLTProcessorCustom.cpp:

1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
2010-03-10  Antonio Gomes  <tonikitoo@webkit.org>

        Reviewed by Dave Hyatt.
        Patch by Antonio Gomes <tonikitoo@webkit.org>

        Extend keyboard navigation to allow directional navigation (Manual tests)
        https://bugs.webkit.org/show_bug.cgi?id=18662

        Adds a manual tests for the Spatial Navigation feature comprasing varios
        Html focusable elements (e.g. <a>, <table>, <iframe>) and much of the logic
        provided by the feature.

        * manual-tests/spatial-navigation/links.html: Added.
        * manual-tests/spatial-navigation/spatial-navigation-test-cases.html: Added.

1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
2010-03-10  Leandro Pereira  <leandro@profusion.mobi>

        Reviewed by Kenneth Rohde Christiansen.

        Add EFL port files to platform/efl.
        http://webkit.org/b/35890

        * platform/efl/ScrollbarEfl.h: Added.
        * platform/efl/ScrollbarThemeEfl.h: Added.

1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
2010-03-10  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Audits panel needs an icon.
        Landing icon attached by Timothy. Enabling panel!

        https://bugs.webkit.org/show_bug.cgi?id=35945

        * WebCore.gypi:
        * inspector/front-end/Images/auditsIcon.png: Added.
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.css:

1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
2010-03-10  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Roll-out r55657, as Xan noticed a bad degradation in playing
        youtube HTML5 videos with it, that is fixed with it
        reverted. Looks like we'll need to work a bit more on this.

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
        (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):
        (WebCore::MediaPlayerPrivate::volumeChangedTimerFired):
        (WebCore::MediaPlayerPrivate::volumeChanged):
        (WebCore::MediaPlayerPrivate::processBufferingStats):
        (WebCore::MediaPlayerPrivate::fillTimerFired):
        (WebCore::MediaPlayerPrivate::maxTimeLoaded):
        (WebCore::MediaPlayerPrivate::updateStates):
        (WebCore::MediaPlayerPrivate::muteChangedTimerFired):
        (WebCore::MediaPlayerPrivate::muteChanged):
        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
2010-03-10  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Rubber-stamped by Xan Lopez.

        Fix ready state when buffering under PLAYING. We should not go
        back to HaveNothing in that case.

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivate::updateStates):

adachan@apple.com's avatar
adachan@apple.com committed
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
2010-03-10  Ada Chan  <adachan@apple.com>

        Reviewed by Adam Roben.

        https://bugs.webkit.org/show_bug.cgi?id=35976

        Retrieve any dwItemData that's set on the context menu item in contextMenuItemByIdOrPosition().

        * platform/win/ContextMenuWin.cpp:

1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
2010-03-10  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Fisher.

        Add IndexedDatabase class and hook it up.
        https://bugs.webkit.org/show_bug.cgi?id=35927

        This change is mostly just adding the plumbing necessary for
        the IndexedDatabaseRequest and IndexedDatabaseSync (not written
        yet).

        This code is non-functional, so no tests (yet).

        * WebCore.gyp/WebCore.gyp:
        * WebCore.gypi:
        * platform/chromium/ChromiumBridge.h:
        * storage/IndexedDatabase.cpp: Added.
        (WebCore::IndexedDatabase::get):
        * storage/IndexedDatabase.h: Added.
        (WebCore::IndexedDatabase::~IndexedDatabase):
        * storage/IndexedDatabaseImpl.cpp: Added.
        (WebCore::IndexedDatabaseImpl::get):
        (WebCore::IndexedDatabaseImpl::IndexedDatabaseImpl):
        (WebCore::IndexedDatabaseImpl::~IndexedDatabaseImpl):
        (WebCore::IndexedDatabaseImpl::open):
        * storage/IndexedDatabaseImpl.h: Added.
        * storage/chromium/IndexedDatabase.cpp: Added.
        (WebCore::IndexedDatabase::get):

1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
2010-03-05  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Sam Weinig.

        Add one more parent check during node removal.
        https://bugs.webkit.org/show_bug.cgi?id=35818

        Test: fast/dom/Node/mutation-blur.html

        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::removeChild): Added check.

1480
1481
1482
1483
1484
1485
2010-03-10  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: added missing quote into localized strings.

        * English.lproj/localizedStrings.js:

1486
1487
1488
1489
2010-03-10  Jeremy Orlow  <jorlow@chromium.org>

        Commit files that were supposed to go in with the last checkin.

1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
2010-03-10  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Dimitry Glazkov.

        Baby steps towards IndexedDB: Start implementing callbacks.
        https://bugs.webkit.org/show_bug.cgi?id=35911

        This patch adds some infastructure for IndexedDB callbacks in V8.
        It also adds a stub of IDBDatabaseRequest.  In the near future,
        I'll gut the event based implementation code, flesh out IDBReqest
        further, and start plumbing IndexedDatabaseRequest.

        Code is not testible because it doesn't work (yet).

        * WebCore.gypi:
        * bindings/v8/DOMObjectsInclude.h:
        * bindings/v8/V8Index.cpp:
        * bindings/v8/V8Index.h:
        * bindings/v8/custom/V8CustomIDBCallback.h: Added.
        (WebCore::V8CustomIDBCallback::create):
        (WebCore::V8CustomIDBCallback::~V8CustomIDBCallback):
        (WebCore::V8CustomIDBCallback::handleEvent):
        (WebCore::V8CustomIDBCallback::V8CustomIDBCallback):
        * bindings/v8/custom/V8IndexedDatabaseRequestCustom.cpp:
        (WebCore::V8IndexedDatabaseRequest::openCallback):
        * storage/IDBDatabaseRequest.h: Added.
        (WebCore::IDBDatabaseRequest::request):
        * storage/IDBDatabaseRequest.idl: Added.
        * storage/IndexedDatabaseRequest.idl:

1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
2010-03-10  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Simon Hausmann.

        [Qt] Non animated gifs are animated in QtWebKit
        https://bugs.webkit.org/show_bug.cgi?id=35955

        Properly map Qt animated and non-animated values to WebCore's
        understanding of animated and non-animated images. Currently
        we can not map anything to the cAnimationLoopNone value.

        * manual-tests/qt/qt-anim.gif: Added.
        * manual-tests/qt/qt-gif-test.html: Added.
        * manual-tests/qt/qt-noanim.gif: Added.
        * platform/graphics/qt/ImageDecoderQt.cpp:
        (WebCore::ImageDecoderQt::repetitionCount):

1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
2010-03-07  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Darin Adler.

        [CAIRO] DoS on iexploder test with high text stroke width.
        https://bugs.webkit.org/show_bug.cgi?id=33759

        Specifying a big text stroke width can make WebKitGTK+ spend
        a very long time in the cairo library for stroking the path of
        the text. The best way to prevent this from happening right now
        is to not stroke paths with a certain width. Samuel proposed to
        not stroke with a width that is twice the width of the text. The
        reason to use twice the text width is that even one stroke of
        any charachter to be drawn would cover the full width.

        Test: fast/text/text-stroke-width-cairo-dos.html

        * platform/graphics/cairo/FontCairo.cpp:
        (WebCore::Font::drawGlyphs):

1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
1624
1625
1626
1627
1628
1629
1630
1631
1632
1633
1634
1635
1636
1637
1638
1639
1640
1641
1642
1643
1644
1645
1646
1647
2010-03-10  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: display list of active workers & support debugging
        with fake workers.
        https://bugs.webkit.org/show_bug.cgi?id=35568

        * English.lproj/localizedStrings.js:
        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * bindings/js/JSInjectedScriptHostCustom.cpp:
        (WebCore::InjectedScriptHost::createInjectedScript):
        (WebCore::InjectedScriptHost::injectedScriptFor):
        * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
        (WebCore::InjectedScriptHost::createInjectedScript):
        (WebCore::InjectedScriptHost::injectedScriptFor):
        * dom/Document.cpp:
        (WebCore::Document::inspectorController):
        * dom/Document.h:
        * dom/ScriptExecutionContext.h:
        (WebCore::ScriptExecutionContext::inspectorController):
        * inspector/InjectedScriptHost.cpp:
        (WebCore::InjectedScriptHost::InjectedScriptHost):
        (WebCore::InjectedScriptHost::injectScript):
        (WebCore::InjectedScriptHost::nextWorkerId):
        (WebCore::InjectedScriptHost::didCreateWorker):
        (WebCore::InjectedScriptHost::willDestroyWorker):
        * inspector/InjectedScriptHost.h:
        * inspector/InjectedScriptHost.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::populateScriptObjects):
        (WebCore::InspectorController::resetScriptObjects):
        (WebCore::InspectorController::didCommitLoad):
        (WebCore::InspectorController::didCreateWorker):
        (WebCore::InspectorController::willDestroyWorker):
        * inspector/InspectorController.h:
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::didCreateWorker):
        (WebCore::InspectorFrontend::willDestroyWorker):
        * inspector/InspectorFrontend.h:
        * inspector/InspectorWorkerResource.h: Added.
        (WebCore::InspectorWorkerResource::create):
        (WebCore::InspectorWorkerResource::id):
        (WebCore::InspectorWorkerResource::url):
        (WebCore::InspectorWorkerResource::isSharedWorker):
        (WebCore::InspectorWorkerResource::InspectorWorkerResource):
        * inspector/front-end/Checkbox.js: Added.
        (WebInspector.Checkbox.callbackWrapper):
        (WebInspector.Checkbox):
        (WebInspector.Checkbox.prototype.checked):
        * inspector/front-end/InjectedFakeWorker.js:
        (InjectedFakeWorker.FakeWorker):
        (InjectedFakeWorker.FakeWorker.prototype.terminate):
        (InjectedFakeWorker.FakeWorker.prototype._handleException):
        (InjectedFakeWorker.FakeWorker.prototype._importScripts):
        (InjectedFakeWorker.FakeWorker.prototype._loadScript):
        (InjectedFakeWorker.FakeWorker.prototype._expandURLAndCheckOrigin):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        (WebInspector.ScriptsPanel.prototype.debuggerWasEnabled):
        (WebInspector.ScriptsPanel.prototype.debuggerWasDisabled):
        (WebInspector.ScriptsPanel.prototype.reset):
        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylePropertiesSection.showInheritedToggleFunction):
        (WebInspector.StylePropertiesSection):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/WorkersSidebarPane.js: Added.
        (WebInspector.WorkersSidebarPane):
        (WebInspector.WorkersSidebarPane.prototype.addWorker):
        (WebInspector.WorkersSidebarPane.prototype.removeWorker):
        (WebInspector.WorkersSidebarPane.prototype.setInstrumentation):
        (WebInspector.WorkersSidebarPane.prototype.reset):
        (WebInspector.WorkersSidebarPane.prototype._onTriggerInstrument):
        (WebInspector.Worker):
        (WebInspector.didCreateWorker):
        (WebInspector.willDestroyWorker):
        * inspector/front-end/inspector.css:
        * inspector/front-end/inspector.html:
        * workers/AbstractWorker.cpp:
        (WebCore::AbstractWorker::AbstractWorker):
        (WebCore::AbstractWorker::~AbstractWorker):
        (WebCore::AbstractWorker::onDestroyWorker):
        (WebCore::AbstractWorker::contextDestroyed):
        * workers/AbstractWorker.h:
        (WebCore::AbstractWorker::id):
        * workers/SharedWorker.cpp:
        (WebCore::SharedWorker::SharedWorker):
        * workers/Worker.cpp:
        (WebCore::Worker::Worker):

1648
1649
1650
1651
1652
2010-03-10  Roland Steiner  <rolandsteiner@chromium.org>

        Unreviewed build fix. Fix variable name change that somehow didn't
        make it into the patch.

1653
1654
1655
1656
1657
1658
1659
1660
1661
1662
1663
1664
1665
1666
1667
1668
1669
1670
1671
1672
1673
1674
1675
1676
1677
1678
1679
1680
1681
1682
1683
1684
1685
1686
1687
2010-03-10  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by David Levin.

        Bug 28293 -  [Chromium] event.datatransfer.getdata("text/uri-list") is treated the same as getdata("URL")
        https://bugs.webkit.org/show_bug.cgi?id=28293
        
        Change ChromiumDataObject such that it treats types "URL" and "text/uri-list"
        correctly for event.dataTransfer.getData/setData. Currently both are treated
        as synonyms, but for "URL", getData is supposed to only return the first valid URL
        contained within the data for "text/uri-list" (see HTML5 spec).

        Tests: editing/pasteboard/dataTransfer-setData-getData.html

        * platform/chromium/ChromiumDataObject.cpp:
        (WebCore::ChromiumDataObject::clear):
        (WebCore::ChromiumDataObject::clearAllExceptFiles):
        (WebCore::ChromiumDataObject::hasData):
        (WebCore::ChromiumDataObject::ChromiumDataObject):
        * platform/chromium/ChromiumDataObject.h:
        (WebCore::ChromiumDataObject::clearURL):
        (WebCore::ChromiumDataObject::hasValidURL):
        (WebCore::ChromiumDataObject::getURL):
        (WebCore::ChromiumDataObject::setURL):
        * platform/chromium/ClipboardChromium.cpp:
        (WebCore::):
        (WebCore::clipboardTypeFromMIMEType):
        (WebCore::ClipboardChromium::clearData):
        (WebCore::ClipboardChromium::getData):
        (WebCore::ClipboardChromium::setData):
        (WebCore::ClipboardChromium::types):
        * platform/chromium/DragDataChromium.cpp:
        (WebCore::DragData::asURL):
        (WebCore::DragData::canSmartReplace):

1688
1689
1690
1691
1692
1693
1694
1695
1696
1697
2010-03-09  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: REGRESSION: Tall image resources are cropped over the bottom.

        https://bugs.webkit.org/show_bug.cgi?id=34720

        * inspector/front-end/inspector.css:

1698
1699
1700
1701
1702
1703
1704
1705
1706
1707
1708
1709
1710
2010-03-09  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: REGRESSION: Pressing up/down arrow key to change numeric
        value in CSS property takes focus away.

        https://bugs.webkit.org/show_bug.cgi?id=34697

        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylePropertyTreeElement.prototype):
        (WebInspector.StylePropertyTreeElement.prototype.):

1711
1712
1713
1714
1715
1716
1717
1718
1719
1720
1721
1722
1723
1724
1725
1726
1727
1728
1729
2010-03-09  Tony Chang  <tony@chromium.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=21840
        https://bugs.webkit.org/show_bug.cgi?id=23993

        Fix an editing bug where replacing a selection would result in the
        new text ending up inside nodes that were not visibly included in the
        selection.  Instead, move our destination position out of nodes that
        were not visibly included.

        Tests: editing/deleting/backspace-avoid-preceding-style.html
               editing/inserting/replace-at-visible-boundary.html

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::positionAvoidingPrecedingNodes):
        (WebCore::ReplaceSelectionCommand::doApply):

1730
1731
1732
1733
1734
1735
1736
1737
1738
1739
1740
1741
1742
1743
1744
1745
1746
1747
1748
1749
1750
1751
1752
1753
1754
1755
1756
1757
1758
1759
2010-03-09  Brady Eidson  <beidson@apple.com>

        Reviewed by Tim Hatcher.

        REGRESSION: WebInspector docking busted on Windows
        <rdar://problem/7728433> and https://bugs.webkit.org/show_bug.cgi?id=35953

        First off, a bit of settings-key related cleanup. If they're shared over multiple files, these 
        things should be properly declared Strings, not random loose char*'s.

        Along with that change, we move the "inspectorStartsAttachedSettingName" from WebKit down to the
        InspectorController in WebCore.

        Finally, when the controller is ready to show the WebInspector window, it can use this newly
        exposed settings key to call "setWindowVisible" directly instead of relying on "showWindow" to do
        it indirectly.

        * WebCore.base.exp:

        * inspector/InspectorBackend.cpp:
        (WebCore::InspectorBackend::saveFrontendSettings):
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::frontendSettingsSettingName):
        (WebCore::InspectorController::inspectorStartsAttachedSettingName):
        (WebCore::InspectorController::scriptObjectReady): Using the new inspectorStartsAttachedSettingName
          key and some "can I attach this?" logic, call setWindowVisible directly to display the inspector
          window.
        (WebCore::InspectorController::populateScriptObjects):
        * inspector/InspectorController.h:

ap@apple.com's avatar
ap@apple.com committed
1760
1761
1762
1763
1764
1765
1766
1767
1768
2010-03-09  Alexey Proskuryakov  <ap@apple.com>

        Reviewed by Mark Rowe.

        https://bugs.webkit.org/show_bug.cgi?id=35951
        <rdar://problem/7327060> Frequent crashes in Dashcode at JSC::Bindings::ObjcInstance::~ObjcInstance + 80

        * bridge/objc/objc_instance.mm: (createInstanceWrapperCache): Fix Tiger code path, too.

ap@apple.com's avatar
ap@apple.com committed
1769
1770
1771
1772
1773
1774
1775
1776
1777
1778
1779
2010-03-09  Alexey Proskuryakov  <ap@apple.com>

        Reviewed by Oliver Hunt.

        https://bugs.webkit.org/show_bug.cgi?id=35951
        <rdar://problem/7327060> Frequent crashes in Dashcode at JSC::Bindings::ObjcInstance::~ObjcInstance + 80

        * bridge/objc/objc_instance.mm: (createInstanceWrapperCache): It's not correct to use object
        personality for keys, because the key can be a mutable object, so its hash can change over its
        lifetime.

1780
1781
1782
1783
1784
1785
1786
1787
1788
1789
1790
2010-03-09  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Darin Adler.

        Fix review comment accidentally overlooked in bug 35713
        https://bugs.webkit.org/show_bug.cgi?id=35947

        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::setStartingSelectionOnSmartDelete):
        * editing/DeleteSelectionCommand.h:

1791
1792
1793
1794
1795
1796
1797
1798
1799
1800
1801
1802
1803
1804
1805
1806
1807
1808
1809
1810
1811
1812
2010-03-03  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        undo after smartdelete should select the deleted space
        https://bugs.webkit.org/show_bug.cgi?id=35713

        TextEdit behavior is to select the deleted space after a smartdelete.

        Tests: editing/undo/undo-smart-delete-reversed-selection.html
               editing/undo/undo-smart-delete-word.html

        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::setStartingSelectionOnSmartDelete):
        (WebCore::DeleteSelectionCommand::initializePositionData):
        * editing/DeleteSelectionCommand.h:
        * editing/VisibleSelection.cpp:
        (WebCore::VisibleSelection::setWithoutValidation):
        This assert looks bogus to me. undo-smart-delete-reversed-selection.html hits it
        but not as a result of the other changes in this patch. The granularity when
        deleting after making a wordgranularity selection is wordgranularity, not charactergranularity.

1813
1814
1815
1816
1817
1818
1819
1820
1821
2010-03-09  Steve Falkenburg  <sfalken@apple.com>

        Rubber stamped by Adam Roben.

        Load debug version of graphics library in Windows Debug_All builds.

        * platform/graphics/win/WKCACFLayerRenderer.cpp:
        (WebCore::WKCACFLayerRenderer::acceleratedCompositingAvailable):

1822
1823
1824
1825
1826
1827
1828
1829
1830
1831
1832
1833
1834
1835
1836
1837
1838
1839
1840
1841
1842
1843
1844
1845
2010-03-09  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler.

        Plug-ins don't always respect the cookie accept policy.
        <rdar://problem/7338359> and https://bugs.webkit.org/show_bug.cgi?id=26391

        The problem is that the various plug-in implementations call into a ResourceLoader
        directly instead of filtering the request through FrameLoader. This bypassed the step
        of adding extra fields to the requests, such as the firstPartyForCookies URL.

        Since plug-in code is currently so strewn about and very platform specific, I
        think reworking it needs to be a task for domain experts. I don't know the implications
        of adding *all* the extra fields to plug-in requests, for example.

        There's no harm in this targeted fix for the hole in our cookie accept policy until
        plug-ins can more fundamentally change.

        Test: http/tests/plugins/third-party-cookie-accept-policy.html

        * loader/ResourceLoader.cpp:
        (WebCore::ResourceLoader::load): Don't load a resource without first giving the request 
          a firstPartyForCookies URL.

1846
1847
1848
1849
1850
1851
1852
1853
1854
1855
1856
1857
2010-03-09  Andy Estes  <aestes@apple.com>

        Reviewed by Adele Peterson.

        Check for null renderer in scrollNode().
        https://bugs.webkit.org/show_bug.cgi?id=34700

        Test: fast/events/remove-child-onscroll.html

        * page/EventHandler.cpp:
        (WebCore::scrollNode): Return early if node->renderer() == 0

kov@webkit.org's avatar
kov@webkit.org committed
1858
1859
1860
1861
1862
1863
2010-03-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Unreviewed distcheck fix.

        * GNUmakefile.am:

1864
1865
1866
1867
1868
1869
1870
2010-03-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Unreviewed build fix (only exposed by make distcheck). The
        SharedWorkers files are not built, they need to be distributed.

        * GNUmakefile.am:

1871
1872
1873
1874
1875
1876
1877
1878
1879
1880
1881
1882
1883
1884
1885
1886
1887
1888
1889
1890
1891
1892
2010-03-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Dirk Schulze.

        [GStreamer] Buffering logic is not correct, and does not work very well
        https://bugs.webkit.org/show_bug.cgi?id=35706

        Fix buffering to match GStreamer expectancies regarding the
        pipeline state, so that videos which really need buffering to play
        correctly also work, while maintaining the convenience of
        on-disk-buffering. This required a bit of shuffling of state
        change handling.

        No behaviour change expected.

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
        (WebCore::MediaPlayerPrivate::processBufferingStats):
        (WebCore::MediaPlayerPrivate::fillTimerFired):
        (WebCore::MediaPlayerPrivate::updateStates):
        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

1893
1894
1895
1896
1897
1898
1899
1900
1901
1902
1903
1904
1905
1906
1907
2010-03-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Dirk Schulze.

        [GStreamer] Buffering logic is not correct, and does not work very well
        https://bugs.webkit.org/show_bug.cgi?id=35706

        Do not call pause(), but set the GStreamer state directly. This is
        just a GStreamer implementation detail, and this will avoid having
        side effects in case we change the pause implementation in the
        future.

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivate::load):

1908
1909
1910
1911
1912
1913
1914
1915
1916
1917
1918
1919
1920
1921
1922
1923
2010-03-09  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Darin Adler.

        AX: hit testing a list box doesn't work anymore
        https://bugs.webkit.org/show_bug.cgi?id=35893

        Since <option> elements don't have renderers, their hit testing needs
        to be handled with a special case.

        Test: platform/mac/accessibility/listbox-hit-test.html

        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::ariaIsHidden):
        (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):

1924
1925
1926
1927
1928
1929
1930
1931
1932
1933
1934
1935
1936
1937
1938
1939
1940
1941
1942
1943
1944
1945
1946
1947
1948
1949
1950
1951
1952
1953
1954
1955
1956
1957
1958
1959
1960
1961
1962
1963
1964
1965
1966
1967
1968
1969
1970
1971
1972
1973
1974
1975
1976
1977
1978
1979
1980
1981
1982
1983
1984
1985
1986
1987
1988
1989
1990
1991
1992
1993
1994
1995
1996
1997
1998
1999
2000
2001
2002
2003
2004
2005
2006
2007
2008
2009
2010
2011
2012
2010-03-09  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Refactor Audits panel presentation layer.
        This change removes unnecessary complexity:
          - Audit scores were not used
          - Audit rule parameters are passed as rule constructor arguments
          - View management aligned with the rest of the front-end
          - Single TreeOutline is used for category results (no need to create sections for those)
          - Rules code beautified and simplified where possible
          - Some UI improvements applied (see attached screenshot)

        https://bugs.webkit.org/show_bug.cgi?id=35860

        * inspector/front-end/AuditCategories.js:
        (WebInspector.AuditCategories.PagePerformance.prototype.initialize):
        (WebInspector.AuditCategories.NetworkUtilization.prototype.initialize):
        * inspector/front-end/AuditResultView.js:
        (WebInspector.AuditResultView):
        (WebInspector.AuditCategoryResultPane):
        (WebInspector.AuditCategoryResultPane.prototype._appendResult):
        * inspector/front-end/AuditRules.js:
        (WebInspector.AuditRules.GzipRule.prototype.doRun):
        (WebInspector.AuditRules.CombineExternalResourcesRule):
        (WebInspector.AuditRules.CombineExternalResourcesRule.prototype.doRun):
        (WebInspector.AuditRules.CombineJsResourcesRule):
        (WebInspector.AuditRules.CombineCssResourcesRule):
        (WebInspector.AuditRules.MinimizeDnsLookupsRule):
        (WebInspector.AuditRules.MinimizeDnsLookupsRule.prototype.doRun):
        (WebInspector.AuditRules.ParallelizeDownloadRule):
        (WebInspector.AuditRules.ParallelizeDownloadRule.prototype.doRun):
        (WebInspector.AuditRules.UnusedCssRule):
        (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback):
        (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.routine):
        (WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
        (WebInspector.AuditRules.CacheControlRule):
        (WebInspector.AuditRules.CacheControlRule.prototype.doRun):
        (WebInspector.AuditRules.CacheControlRule.prototype.execCheck):
        (WebInspector.AuditRules.BrowserCacheControlRule):
        (WebInspector.AuditRules.BrowserCacheControlRule.prototype.handleNonCacheableResources):
        (WebInspector.AuditRules.BrowserCacheControlRule.prototype.runChecks):
        (WebInspector.AuditRules.ProxyCacheControlRule):
        (WebInspector.AuditRules.ProxyCacheControlRule.prototype.runChecks):
        (WebInspector.AuditRules.ImageDimensionsRule):
        (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
        (WebInspector.AuditRules.CssInHeadRule):
        (WebInspector.AuditRules.CssInHeadRule.prototype.doRun):
        (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.routine):
        (WebInspector.AuditRules.StylesScriptsOrderRule):
        (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun):
        (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.routine):
        (WebInspector.AuditRules.CookieRuleBase):
        (WebInspector.AuditRules.CookieRuleBase.prototype.doRun.resultCallback):
        (WebInspector.AuditRules.CookieRuleBase.prototype.doRun):
        (WebInspector.AuditRules.CookieSizeRule):
        (WebInspector.AuditRules.CookieSizeRule.prototype.processCookies):
        (WebInspector.AuditRules.StaticCookielessRule):
        (WebInspector.AuditRules.StaticCookielessRule.prototype.processCookies):
        * inspector/front-end/AuditsPanel.js:
        (WebInspector.AuditsPanel):
        (WebInspector.AuditsPanel.prototype._executeAudit.ruleResultReadyCallback):
        (WebInspector.AuditsPanel.prototype._executeAudit):
        (WebInspector.AuditsPanel.prototype._reloadResources):
        (WebInspector.AuditsPanel.prototype._didMainResourceLoad):
        (WebInspector.AuditsPanel.prototype.showResults):
        (WebInspector.AuditsPanel.prototype.showLauncherView):
        (WebInspector.AuditsPanel.prototype.get visibleView):
        (WebInspector.AuditsPanel.prototype.set visibleView):
        (WebInspector.AuditsPanel.prototype.show):
        (WebInspector.AuditsPanel.prototype._clearButtonClicked):
        (WebInspector.AuditCategory.prototype.addRule):
        (WebInspector.AuditRule):
        (WebInspector.AuditRule.prototype.set severity):
        (WebInspector.AuditRule.prototype.run):
        (WebInspector.AuditRule.prototype.doRun):
        (WebInspector.AuditCategoryResult):
        (WebInspector.AuditCategoryResult.prototype.addRuleResult):
        (WebInspector.AuditRuleResult):
        (WebInspector.AuditRuleResult.prototype.addChild):
        (WebInspector.AuditRuleResult.prototype.addURL):
        (WebInspector.AuditRuleResult.prototype.addURLs):
        (WebInspector.AuditRuleResult.prototype.addSnippet):
        * inspector/front-end/Settings.js:
        * inspector/front-end/audits.css:
        * inspector/front-end/inspector.js:
        (WebInspector._createPanels):
        (WebInspector.documentKeyDown):

2013
2014
2015
2016
2017
2018
2019
2020
2021
2022
2023
2024
2025
2026
2010-03-09  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.
 
        When enable resource tracking state changes use the same method as
        location.reload for reloading inspected page.

        https://bugs.webkit.org/show_bug.cgi?id=35923

        * inspector/InspectorBackend.cpp:
        (WebCore::InspectorBackend::reloadPage):
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::enableResourceTracking):

2027
2028
2029
2030
2031
2032
2033
2034
2035
2036
2037
2010-03-09  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: highlight text node containers while searching for node.

        https://bugs.webkit.org/show_bug.cgi?id=35912

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::mouseDidMoveOverElement):

2038
2039
2040
2041
2042
2043
2044
2045
2046
2047
2048
2049
2050
2051
2052
2010-03-09  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GStreamer] player code cleanups
        https://bugs.webkit.org/show_bug.cgi?id=35868

        Cleaned up the private instance variables of the player.

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
        (WebCore::MediaPlayerPrivate::fillTimerFired):
        (WebCore::MediaPlayerPrivate::mediaLocationChanged):
        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

2053
2054
2055
2056
2057
2058
2059
2060
2061
2062
2063
2064
2065
2066
2067
2068
2069
2070
2071
2072
2073
2074
2075
2076
2010-03-09  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GStreamer] player code cleanups
        https://bugs.webkit.org/show_bug.cgi?id=35868

        Splitted GOwnPtrGtk.{cpp,h} to GOwnPtr{Soup,GStreamer}.{cpp,h}.

        * GNUmakefile.am:
        * platform/graphics/gstreamer/GOwnPtrGStreamer.cpp: Added.
        (WTF::GstElement):
        * platform/graphics/gstreamer/GOwnPtrGStreamer.h: Added.
        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        * platform/gtk/GOwnPtrGtk.cpp: Removed.
        * platform/gtk/GOwnPtrGtk.h: Removed.
        * platform/network/soup/CookieJarSoup.cpp:
        * platform/network/soup/DNSSoup.cpp:
        * platform/network/soup/GOwnPtrSoup.cpp: Added.
        (WTF::SoupURI):
        * platform/network/soup/GOwnPtrSoup.h: Added.
        * platform/network/soup/ResourceHandleSoup.cpp:
        * platform/network/soup/ResourceRequestSoup.cpp:

2077
2078
2079
2080
2081
2082
2083
2084
2085
2086
2087
2088
2089
2010-03-09  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Eric Seidel.

        [Chromium] Should remove paddings of Win/Linux chromium's buttons
        https://bugs.webkit.org/show_bug.cgi?id=35629

        No new tests, but we may need to rebaseline bunch of expectation
        images in chromium's tree.

        * rendering/RenderThemeChromiumSkia.cpp:
        * rendering/RenderThemeChromiumSkia.h:

2090
2091
2092
2093
2094
2095
2096
2097
2098
2099
2100
2101
2102
2103
2104
2105
2106
2107
2108
2109
2110
2111
2010-03-08  Kent Tamura  <tkent@chromium.org>

        Reviewed by Adam Barth.

        Implement HTML5 <hgroup> element.
        https://bugs.webkit.org/show_bug.cgi?id=33369

        <hgroup> should behave the same as <nav>, <section>, <article>, and <aside>.
        <hgroup> has no specific parsing rules.

        Test: fast/html/hgroup-element.html

        * css/html.css: Add hgroup as a block element.
        * editing/htmlediting.cpp:
        (WebCore::validBlockTag): Add hgroupTag.
        * html/HTMLElement.cpp:
        (WebCore::createTagPriorityMap): Returns 5 for hgroupTag.
        (WebCore::blockTagList): Add hgroupTag.
        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::getNode): Add hgroupTag.
        * html/HTMLTagNames.in: Add hgroup.

2112
2113
2114
2115
2116
2117
2118
2119
2120
2121
2122
2123
2124
2125
2010-03-08  Tony Chang  <tony@chromium.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=32131
        Crash when inserting an ordered list.

        Test: editing/execCommand/insert-ordered-list.html

        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::moveParagraphs):
        * editing/TextIterator.cpp:
        (WebCore::TextIterator::rangeFromLocationAndLength):

2126
2127
2128
2129
2130
2131
2132
2133
2134
2010-03-08  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Added a test for crash when you quit inside an unload handler.
        rdar://problem/6958347

        * manual-tests/quit-inside-unload.html: Added.

2135
2136
2137
2138
2139
2140
2141
2142
2143
2144
2145
2146
2147
2148
2149
2150
2151
2152
2153
2154
2155
2156
2157
2158
2159
2010-03-08  Darin Adler  <darin@apple.com>

        Reviewed by Jon Honeycutt.

        Don't auto-play <audio> and <video> elements loaded in background tabs
        https://bugs.webkit.org/show_bug.cgi?id=35886
        rdar://problem/7117745

        * manual-tests/video-in-non-frontmost-tab.html: Added.
        * manual-tests/resources/video-tab.html: Added.

        * html/HTMLMediaElement.h: Added MediaCanStartListener as a base class, and
        added the mediaCanStart function as well as a boolean,
        m_isWaitingUntilMediaCanStart.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize
        m_isWaitingUntilMediaCanStart.
        (WebCore::HTMLMediaElement::~HTMLMediaElement): Call
        removeMediaCanStartListener if m_isWaitingUntilMediaCanStart is true. 
        (WebCore::HTMLMediaElement::loadInternal): Set m_isWaitingUntilMediaCanStart
        and call addMediaCanStartListener if canStartMedia is false.
        (WebCore::HTMLMediaElement::mediaCanStart): Clear m_isWaitingUntilMediaCanStart
        and call loadInternal.

2160
2161
2162
2163
2164
2165
2166
2010-03-08  Csaba Osztrogonác  <ossy@webkit.org>

        [GTK] Unreviewed buildfix after r55688.

        * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
        (webKitWebSrcStart):

2167
2168
2169
2170
2171
2172
2173
2010-03-08  Csaba Osztrogonác  <ossy@webkit.org>

        [GTK] Unreviewed buildfix after r55688.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::):

2174
2175
2176
2177
2178
2179
2180
2010-03-08  Csaba Osztrogonác  <ossy@webkit.org>

        [Qt] Unreviewed buildfix after r55688.

        * platform/network/qt/ResourceHandleQt.cpp:
        (WebCore::ResourceHandle::loadResourceSynchronously):

ap@apple.com's avatar
ap@apple.com committed
2181
2182
2183
2184
2185
2186
2187
2188
2189
2190
2191
2192
2193
2194
2195
2196
2197
2198
2199
2200
2201
2202
2203
2204
2205
2206
2010-03-08  Alexey Proskuryakov  <ap@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=35879
        Eliminate m_mightDownloadFromHandle

        It was only used on Mac, and unnecessarily complicated the code.

        No change in behavior, thus no test.

        * loader/MainResourceLoader.cpp:
        (WebCore::MainResourceLoader::loadNow):
        * loader/ResourceLoader.cpp:
        (WebCore::ResourceLoader::load):
        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::createResourceHandle):
        * platform/network/ResourceHandle.cpp:
        (WebCore::ResourceHandle::ResourceHandle):
        (WebCore::ResourceHandle::create):
        * platform/network/ResourceHandle.h:
        * platform/network/ResourceHandleInternal.h:
        (WebCore::ResourceHandleInternal::ResourceHandleInternal):
        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::start):

2207
2208
2209
2210
2211
2212
2213
2214
2215
2216
2217
2218
2219
2220
2221
2222
2223
2224
2225
2226
2227
2228
2229
2230
2231
2232
2233
2234
2235
2236
2237
2238
2239
2240
2241
2242
2243
2244
2245
2246
2247
2248
2249
2250
2251
2252
2253
2254
2255
2256
2257
2258
2259
2260
2261
2262
2263
2264
2265
2266
2267
2268
2269
2270
2271
2010-03-02  Peter Kasting  <pkasting@google.com>

        Reviewed by Adam Barth.

        Clean up usage of m_failed in open-source image decoders, part 1.
        https://bugs.webkit.org/show_bug.cgi?id=35411
        
        Makes setFailed() virtual so subclasses can override it (none do yet) to
        do automatic cleanup on failure; makes it return a bool for easy
        tailcalling; makes failed() the only way to access m_failed so
        subclasses are assured setFailed() won't be bypassed.  Plus one or two
        other tiny cleanup bits.

        Overriding setFailed() is coming in a subsequent patch because it can be
        hairy and needs close review.

        No functional change, so no tests.

        * platform/graphics/qt/ImageDecoderQt.cpp:
        (WebCore::ImageDecoderQt::setData):
        (WebCore::ImageDecoderQt::frameBufferAtIndex):
        (WebCore::ImageDecoderQt::internalDecodeSize):
        (WebCore::ImageDecoderQt::internalReadImage):
        (WebCore::ImageDecoderQt::internalHandleCurrentImage):
        (WebCore::ImageDecoderQt::forceLoadEverything):
        (WebCore::ImageDecoderQt::clearPointers):
        * platform/graphics/qt/ImageDecoderQt.h:
        * platform/image-decoders/ImageDecoder.h:
        (WebCore::ImageDecoder::ImageDecoder):
        (WebCore::ImageDecoder::setData):
        (WebCore::ImageDecoder::setSize):
        (WebCore::ImageDecoder::setFailed):
        (WebCore::ImageDecoder::failed):
        * platform/image-decoders/bmp/BMPImageDecoder.cpp:
        (WebCore::BMPImageDecoder::isSizeAvailable):
        (WebCore::BMPImageDecoder::frameBufferAtIndex):
        (WebCore::BMPImageDecoder::processFileHeader):
        * platform/image-decoders/gif/GIFImageDecoder.cpp:
        (WebCore::GIFImageDecoder::setData):
        (WebCore::GIFImageDecoder::isSizeAvailable):
        (WebCore::GIFImageDecoder::frameBufferAtIndex):
        (WebCore::GIFImageDecoder::decode):
        (WebCore::GIFImageDecoder::initFrameBuffer):
        * platform/image-decoders/ico/ICOImageDecoder.cpp:
        (WebCore::ICOImageDecoder::decodeAtIndex):
        (WebCore::ICOImageDecoder::processDirectory):
        (WebCore::ICOImageDecoder::processDirectoryEntries):
        * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
        (WebCore::JPEGImageReader::decode):
        (WebCore::JPEGImageDecoder::setData):
        (WebCore::JPEGImageDecoder::isSizeAvailable):
        (WebCore::JPEGImageDecoder::frameBufferAtIndex):
        (WebCore::JPEGImageDecoder::outputScanlines):
        (WebCore::JPEGImageDecoder::decode):
        * platform/image-decoders/png/PNGImageDecoder.cpp:
        (WebCore::decodingFailed):
        (WebCore::PNGImageReader::decode):
        (WebCore::PNGImageDecoder::setData):
        (WebCore::PNGImageDecoder::isSizeAvailable):
        (WebCore::PNGImageDecoder::frameBufferAtIndex):
        (WebCore::PNGImageDecoder::headerAvailable):
        (WebCore::PNGImageDecoder::rowAvailable):
        (WebCore::PNGImageDecoder::decode):
        * platform/image-decoders/png/PNGImageDecoder.h:

2272
2273
2274
2275
2276
2277
2278
2279
2280
2281
2282
2283
2284
2285
2010-03-08  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Darin Adler.

        Disallow WebGL when HW comp is not turned on at runtime
        https://bugs.webkit.org/show_bug.cgi?id=35759

        When HW comp is turned off with the runtime flag, WebGL would still
        create a context, but silently fail to render. This prevents that.
        Now if HW comp is turned off getContext('webgl') will return null.

        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::getContext):

2286
2287
2288
2289
2290
2291
2292
2293
2294
2295
2296
2297
2298
2299
2300
2301
2302
2303
2304
2305
2306
2307
2308
2309
2310
2311
2312
2313
2314
2315
2316
2317
2318
2010-03-08  Darin Adler  <darin@apple.com>

        Reviewed by Jon Honeycutt.

        https://bugs.webkit.org/show_bug.cgi?id=35876

        Fix minor style issues in HTMLMediaElement and classes derived from it.
        Made many public members private and protected.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::screenRect): Got rid of a stray "const" and
        retstructured the function to use early return and get rid of a local.

        * html/HTMLMediaElement.h: Made lots of members private and some
        protected. Also use private inheritance instead of public. Removed
        some unneeded includes.

        * html/HTMLVideoElement.cpp:
        (WebCore::HTMLVideoElement::parseMappedAttribute): Use player() instead
        of m_player; HTMLMediaElement data members are now private, not protected.
        (WebCore::HTMLVideoElement::supportsFullscreen): Ditto.
        (WebCore::HTMLVideoElement::videoWidth): Ditto.
        (WebCore::HTMLVideoElement::videoHeight): Ditto.
        (WebCore::HTMLVideoElement::hasAvailableVideoFrame): Ditto.
        (WebCore::HTMLVideoElement::webkitEnterFullScreen): Use isFullscreen()
        instead of m_isFullscreen; same reason.
        (WebCore::HTMLVideoElement::webkitExitFullScreen): Ditto.
        (WebCore::HTMLVideoElement::webkitDisplayingFullscreen): Ditto.

        * html/HTMLVideoElement.h: Removed an unneeded include. Made many
        public functions private. Got rid of unused paint function, which was
        replaced with paintCurrentFrameInContext a while back.

2319
2320
2321
2322
2323
2324
2325
2326
2327
2328
2329
2330
2331
2332
2333
2334
2335
2336
2337
2338
2339
2340
2341
2010-03-08  Joanmarie Diggs  <joanmarie.diggs@gmail.com>

        Reviewed by Xan Lopez.

        https://bugs.webkit.org/show_bug.cgi?id=30895
        [Gtk] The accessible hierarchy of tables is significantly incorrect for Atk

        Gives platforms the ability to exclude parts of an AccessibilityTable
        from the accessible hierarchy.

        * accessibility/gtk/AccessibilityObjectAtk.cpp:
        (AccessibilityObject::accessibilityPlatformIncludesObject):
        * accessibility/AccessibilityRenderObject.cpp:
        (AccessibilityRenderObject::determineAccessibilityRole):
        * accessibility/AccessibilityTable.cpp:
        (AccessibilityTable::addChildren):
        * accessibility/AccessibilityTableColumn.h:
        (accessibilityIsIgnored):
        * accessibility/AccessibilityTableHeaderContainer.h:
        (accessibilityIsIgnored):
        * accessibility/AccessibilityTableRow.cpp:
        (accessibilityIsIgnored):

2342
2343
2344
2345
2346
2347
2348
2010-03-08  Jian Li  <jianli@chromium.org>

        No review. Fix build break on Tiger intel release.

        * html/Blob.cpp:
        * html/Blob.h:

2349
2350
2351
2352
2353
2354
2355
2356
2357
2358
2359
2360
2361
2362
2363
2364
2365
2366
2367
2368
2369
2370
2371
2372
2373
2374
2375
2376
2377
2378
2379
2380
2381
2382
2383
2384
2385
2010-03-02  Adam Treat  <atreat@rim.com>

        Reviewed by Dave Hyatt.

        Refactor the HostWindow methods for repaint, scroll, invalidate and blit
        of backingstore and window by eliminating the three bools that currently
        exist as params of the repaint method.
        https://bugs.webkit.org/show_bug.cgi?id=34214

        I've added extra methods to provide the hosts with more semantic
        information of what is being requested thus eliminating the need for
        these bools.

        No tests as this change should not introduce any behavior changes in any
        of the ports.

        https://bugs.webkit.org/show_bug.cgi?id=34214

        * loader/EmptyClients.h:
        (WebCore::EmptyChromeClient::invalidateContents):
        (WebCore::EmptyChromeClient::invalidateWindow):
        (WebCore::EmptyChromeClient::invalidateContentsAndWindow):
        (WebCore::EmptyChromeClient::invalidateContentsForSlowScroll):
        * page/Chrome.cpp:
        (WebCore::Chrome::invalidateContents):
        (WebCore::Chrome::invalidateWindow):
        (WebCore::Chrome::invalidateContentsAndWindow):
        (WebCore::Chrome::invalidateContentsForSlowScroll):
        * page/Chrome.h:
        * page/ChromeClient.h:
        * page/FrameView.cpp:
        (WebCore::FrameView::invalidateRect):
        * platform/HostWindow.h:
        * platform/ScrollView.cpp:
        (WebCore::ScrollView::scrollContents):
        (WebCore::ScrollView::wheelEvent):

2386
2387
2388
2389
2390
2391
2392
2393
2394
2395
2396
2397
2398
2399
2400
2401
2402
2010-03-08  Adam Barth  <abarth@webkit.org>

        Reviewed by Nate Chapin.

        [V8] Block popups from inline script
        https://bugs.webkit.org/show_bug.cgi?id=35474

        Apparently, we're supposed to look at the sourceURL to figure out
        whether we're running a script tag or a hyperlink.  This logic is
        copied from the JSC version.

        Test: http/tests/security/popup-blocked-from-window-open.html

        * bindings/v8/ScriptController.cpp:
        (WebCore::ScriptController::processingUserGesture):
        (WebCore::ScriptController::evaluate):

2403
2404
2405
2406
2407
2408
2409
2410
2411
2412
2413
2414
2415
2416
2417
2418
2419
2420
2421
2422
2423
2424
2425
2426
2427
2428
2429
2430
2431
2432
2433
2010-03-08  Stuart Morgan  <stuartmorgan@chromium.org>

        Reviewed by Darin Adler.

        Move the details of secure text mode into WebCore/platform.
        Move the higher-level logic for secure text mode from Frame
        to SelectionController.

        https://bugs.webkit.org/show_bug.cgi?id=31265

        No new tests: no functional changes.

        * WebCore.gypi:
        * WebCore.xcodeproj/project.pbxproj:
        * dom/Document.cpp:
        (WebCore::Document::setUseSecureKeyboardEntryWhenActive):
        * editing/SelectionController.cpp:
        (WebCore::SelectionController::focusedOrActiveStateChanged):
        (WebCore::SelectionController::updateSecureKeyboardEntryIfActive):
        (WebCore::SelectionController::setUseSecureKeyboardEntry):
        * editing/SelectionController.h:
        * page/Frame.cpp:
        (WebCore::Frame::setDocument):
        * page/Frame.h:
        * platform/SecureTextInput.cpp: Added.
        (WebCore::enableSecureTextInput):
        (WebCore::disableSecureTextInput):
        * platform/SecureTextInput.h: Added.
        (WebCore::enableSecureTextInput):
        (WebCore::disableSecureTextInput):

2434
2435
2436
2437
2438
2439
2440
2441
2442
2443
2444
2445
2446
2447
2448
2449
2450
2451
2452
2453
2454
2010-03-08  Brady Eidson  <beidson@apple.com>

        Reviewed by Anders Carlsson.

        Relax the 3rd party cookie policy in cases where it won't add a new tracking vector.
        <rdar://problem/7163012> and https://bugs.webkit.org/show_bug.cgi?id=35824

        Test: http/tests/cookies/third-party-cookie-relaxing.html

        If the 3rd-party domain in question already has a cookie set, allow changes
        by setting the first party url of the request to be the url of the request itself:        
        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::makeFinalRequest):

        Ditto:
        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::start):
        (WebCore::ResourceHandle::loadResourceSynchronously):

        I've filed <rdar://problem/7728508> to track changing the policy in our networking layer.

jianli@chromium.org's avatar
jianli@chromium.org committed
2455
2456
2457
2458
2459
2460
2461
2462
2463
2464
2465
2466
2467
2468
2469
2470
2471
2472
2473
2474
2475
2476
2477
2478
2479
2480
2481
2482
2483
2484
2485
2486
2487
2488
2489
2490
2491
2492
2493
2494
2495
2496
2497
2498
2499
2500
2501
2502
2503
2504
2010-03-08  Jian Li  <jianli@chromium.org>

        Reviewed by Dmitry Titov.

        Blob.slice support.
        https://bugs.webkit.org/show_bug.cgi?id=32993
        
        The following semantic is adopted per the discussions on public-webapps:
        1) File.slice() does a synchronous IO to capture the current size and
           modification time and cache them in the resulting Blob.
        2) Subsequent Blob operations, like Blob.slice and Blob.size simply
           use the cached values.
        3) When the underlying file data are accessed, like in XHR.send(), the
           UA will check the cached modification time against the current
           modification time to determine if the file has been changed or not.
           An error or exception will be thrown if needed.

        Also add ENABLE_BLOB_SLICE feature define.

        Test: http/tests/local/send-sliced-dragged-file.html

        * Configurations/FeatureDefines.xcconfig:
        * GNUmakefile.am:
        * WebCore.pri:
        * html/Blob.cpp:
        (WebCore::Blob::Blob):
        (WebCore::Blob::size):
        (WebCore::Blob::slice):
        * html/Blob.h:
        (WebCore::Blob::start):
        (WebCore::Blob::length):
        (WebCore::Blob::modificationTime):
        * html/Blob.idl:
        * platform/network/FormData.cpp:
        (WebCore::FormData::deepCopy):
        (WebCore::FormData::appendFile):
        (WebCore::FormData::appendFileRange):
        * platform/network/FormData.h:
        (WebCore::FormDataElement::FormDataElement):
        (WebCore::operator==):
        * platform/network/mac/FormDataStreamMac.mm:
        (WebCore::advanceCurrentStream):
        (WebCore::openNextStream):
        (WebCore::formCreate):
        (WebCore::formOpen):
        (WebCore::formRead):
        (WebCore::setHTTPBody):
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::send):

2505
2506
2507
2508
2509
2510
2511
2512
2513
2514
2515
2516
2517
2518
2519
2520
2521
2522
2523
2524
2525
2526
2527
2528
2010-03-08  Daniel Bates  <dbates@rim.com>

        Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=34819

        Fixes an issue where we repaint the caret rectangle even if the associated
        selection is not in a content editable element. This is extraneous since the
        caret is only visible when the selection is in a content editable element.
        Hence, we should only repaint the caret rectangle when the associated selection
        is in a content editable element.

        Note, we always paint the caret when caret browsing is enabled.

        Test: fast/repaint/no-caret-repaint-in-non-content-editable-element.html

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::recomputeCaretRect): Modified to call method
        SelectionController::shouldRepaintCaret.
        (WebCore::SelectionController::shouldRepaintCaret): Added.
        (WebCore::SelectionController::invalidateCaretRect): Modified to call method
        SelectionController::shouldRepaintCaret.
        * editing/SelectionController.h:

2529
2530
2531
2532
2533
2534
2535
2536
2537
2538
2539
2540
2541
2542
2543
2544
2545
2010-03-08  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Darin Adler.

        YouTube HTML5 video never starts playing on Windows
        https://bugs.webkit.org/show_bug.cgi?id=33954

        * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
        (WebCore::MediaPlayerPrivate::rfc2616DateStringFromTime): New, create an rfc 2616 formatted
        string for an absolute time value.
        (WebCore::addCookieParam): New, add a cookie param and value to a string builder.
        (WebCore::MediaPlayerPrivate::setUpCookiesForQuickTime): Copy cookies for the movie to
            be loaded from CFNetwork into WinINet so they are available when QuickTime tries to
            download the movie.
        (WebCore::MediaPlayerPrivate::load): Call setupCookiesForQuickTime.
        * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:

2546
2547
2548
2549
2550
2551
2552
2553
2554
2555
2556
2557
2558
2559
2010-03-08  Eric Uhrhane  <ericu@chromium.org>

        Reviewed by David Levin.

        Remove the now-redundant Settings fields for the Database
        https://bugs.webkit.org/show_bug.cgi?id=35763

        No new tests; this code isn't called.

        * WebCore.base.exp:
        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        * page/Settings.h:

levin@chromium.org's avatar
levin@chromium.org committed
2560
2561
2562
2563
2564
2565
2566
2010-03-07  David Levin  <levin@chromium.org>

        Chromium Linux build fix.

        * platform/graphics/chromium/FontPlatformDataLinux.h: Add "class String" since a debug
        only method returns a String.

mrowe@apple.com's avatar
mrowe@apple.com committed
2567
2568
2569
2570
2571
2572
2010-03-07  Mark Rowe  <mrowe@apple.com>

        Chromium build fix.

        * platform/chromium/ClipboardChromium.cpp: Include Image.h since we're using WebCore::Image.

mrowe@apple.com's avatar
mrowe@apple.com committed
2573
2574
2575
2576
2577
2578
2010-03-07  Mark Rowe  <mrowe@apple.com>

        Gtk build fix.

        * platform/network/soup/ResourceHandleSoup.cpp: Include SharedBuffer.h since we're using WebCore::SharedBuffer.

mrowe@apple.com's avatar
mrowe@apple.com committed
2579
2580
2581
2582
2583
2584
2010-03-07  Mark Rowe  <mrowe@apple.com>

        Gtk build fix.

        * platform/graphics/gtk/ImageGtk.cpp: Include SharedBuffer.h since we're using WebCore::SharedBuffer.

2585
2586
2587
2588
2589
2590
2010-03-07  Mark Rowe  <mrowe@apple.com>

        Fix builds where USE_CG_SHADING is set.

        * platform/graphics/cg/GradientCG.cpp: Include wtf/RetainPtr.h since WTF::RetainPtr is used when USE_CG_SHADING is set.

2591
2592
2593
2594
2595
2596
2597
2598
2010-03-07  Mark Rowe  <mrowe@apple.com>

        Windows build fix.  Add some required includes.

        * platform/graphics/win/ImageCGWin.cpp:
        * platform/network/cf/ResourceHandleCFNet.cpp:
        * platform/win/ClipboardWin.cpp:

mrowe@apple.com's avatar
mrowe@apple.com committed
2599
2600
2601
2602
2603
2604
2010-03-07  Mark Rowe  <mrowe@apple.com>

        Gtk build fix.

        * platform/graphics/GraphicsContext.h: Include wtf/PassOwnPtr.h since some platforms use WTF::PassOwnPtr in this header.

mrowe@apple.com's avatar
mrowe@apple.com committed
2605
2606
2607
2608
2609
2610
2010-03-07  Mark Rowe  <mrowe@apple.com>

        Qt build fix.

        * platform/network/qt/ResourceHandleQt.cpp: Include SharedBuffer.h since we're using WebCore::SharedBuffer.

mrowe@apple.com's avatar
mrowe@apple.com committed
2611
2612
2613
2614
2010-03-07  Mark Rowe  <mrowe@apple.com>

        Gtk build fix.

mrowe@apple.com's avatar
mrowe@apple.com committed
2615
        * platform/gtk/ClipboardGtk.cpp: Include Image.h since we're using WebCore::Image.
mrowe@apple.com's avatar
mrowe@apple.com committed
2616

2617
2618
2619
2620
2621
2622
2623
2624
2625
2626
2627
2628
2629
2630
2631
2632
2633
2634
2635
2636
2637
2638
2639
2010-03-07  Mark Rowe  <mrowe@apple.com>

        Rubber-stamped by Cameron Zwarich.

        Remove unnecessary includes from header files, adding them to the handful of implementation files that need them.

        * loader/CachedCSSStyleSheet.cpp:
        * loader/CachedFont.cpp:
        * loader/CachedImage.cpp:
        * loader/CachedResource.cpp:
        * loader/CachedResource.h:
        * loader/CachedScript.cpp:
        * loader/CachedXSLStyleSheet.cpp:
        * loader/icon/IconFetcher.cpp:
        * loader/loader.cpp:
        * page/Page.cpp:
        * platform/graphics/Image.cpp:
        * platform/graphics/Image.h:
        * platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
        * platform/graphics/cg/PDFDocumentImage.cpp:
        * platform/graphics/cg/PathCG.cpp:
        * platform/graphics/mac/ImageMac.mm:

mrowe@apple.com's avatar
mrowe@apple.com committed
2640
2641
2642
2643
2644
2645
2646
2010-03-07  Mark Rowe  <mrowe@apple.com>

        Chromium build fix.

        * platform/chromium/ChromiumDataObject.h: Include SharedBuffer.h since the inline constructor of this
        class means that the pointed-to type of the RefPtr member must be available.

mrowe@apple.com's avatar
mrowe@apple.com committed
2647
2648
2649
2650
2651
2652
2010-03-07  Mark Rowe  <mrowe@apple.com>

        Qt build fix.

        * platform/network/qt/DnsPrefetchHelper.cpp: Include PlatformString.h since we're using WebCore::String.

2653
2654
2655
2656
2657
2658
2659
2660
2661
2662
2663
2664
2665
2666
2667
2010-03-07  Kent Tamura  <tkent@chromium.org>

        Reviewed by Eric Seidel.

        Fix a bug that validity.valueMissing for a radio button with required
        in a form element always returns true.
        https://bugs.webkit.org/show_bug.cgi?id=35472

        Test: fast/forms/ValidityState-valueMissing-radio.html

        * html/HTMLInputElement.cpp:
        (WebCore::checkedRadioButtons): Move the location to be used by valueMissing().
        (WebCore::HTMLInputElement::valueMissing):
          Use checkedRadioButtons() instead of document()->checkedRadioButtons().

2668
2669
2670
2671
2672
2673
2674
2675
2676
2677
2678
2679
2680
2681
2682
2683
2010-03-07  Mark Rowe  <mrowe@apple.com>

        Rubber-stamped by Cameron Zwarich.

        Remove unnecessary includes from header files, adding them to the handful of implementation files that need them.

        * bindings/objc/DOM.mm:
        * loader/CachedImage.h:
        * loader/EmptyClients.h:
        * platform/graphics/GlyphPageTreeNode.cpp:
        * platform/text/CString.h:
        * platform/text/String.cpp:
        * platform/text/mac/TextCodecMac.cpp:
        * svg/graphics/SVGResourceFilter.h:
        * svg/graphics/filters/SVGFEImage.h:

2684
2685
2686
2687
2688
2689
2010-03-07  Mark Rowe  <mrowe@apple.com>

        Completely remove two files that were deleted in r55635 from the Xcode project.

        * WebCore.xcodeproj/project.pbxproj:

2690
2691
2692
2693
2694
2695
2696
2697
2698
2699
2700
2701
2702
2703
2704
2010-03-07  Sam Weinig  <sam@webkit.org>

        Reviewed by Dan Bernstein.

        Remove inconsistent "Too few arguments" handling for window.atob() and window.btoa()
        https://bugs.webkit.org/show_bug.cgi?id=35848

        - Take the opportunity to fully autogenerate window.atob() and window.btoa().

        * bindings/js/JSDOMWindowCustom.cpp:
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::btoa):
        (WebCore::DOMWindow::atob):
        * page/DOMWindow.idl:

2705
2706
2707
2708
2709
2710
2711
2712
2713
2714
2715
2716
2717
2718
2719
2720
2721
2722
2723
2724
2725
2726
2727
2728
2729
2010-03-07  Dan Bernstein  <mitz@apple.com>

        Reviewed by Simon Fraser.

        <rdar://problem/7722008> Column breaking ignores floats
        https://bugs.webkit.org/show_bug.cgi?id=35837

        Test: fast/multicol/float-truncation.html

        Introduce an earlier column-break if otherwise a float that could fit
        inside a single column will be split between columns.

        It is still possible for floats to be needlessly broken if initially
        they fit in the column, but normal flow truncation then shortens the
        column.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::visibleTopOfHighestFloatExtendingBelow): Added.
        Returns the visible top of the highest descendant float that visibly
        extends below the given y offset, ignoring floats that are taller than
        the given maximum height.
        (WebCore::RenderBlock::layoutColumns): If the initial column height
        would cause a float to be split, truncate above the float.
        * rendering/RenderBlock.h:

2730
2731
2732
2733
2734
2735
2736
2737
2738
2739
2740
2741
2742
2743
2744
2745
2746
2747
2748
2749
2750
2751
2752
2753
2754
2755
2756
2757
2758
2759
2760
2761
2762
2763
2764
2765
2010-03-07  Dmitry Titov  <dimich@chromium.org>

        Not reviewed. Revert of r55593 which caused a regression of worker-cloneports.html.

        REGRESSION(55593?): fast/workers/worker-cloneport.html is timing out on Leopard
        https://bugs.webkit.org/show_bug.cgi?id=35819

        * Android.jscbindings.mk:
        * Android.v8bindings.mk:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSDOMWindowCustom.cpp:
        * bindings/js/JSDatabaseCallback.cpp: Removed.
        * bindings/js/JSDatabaseCallback.h: Removed.
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        * bindings/v8/custom/V8DatabaseCallback.cpp: Removed.
        * bindings/v8/custom/V8DatabaseCallback.h: Removed.
        * dom/Document.cpp:
        (WebCore::Document::postTask):
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::openDatabase):
        * page/DOMWindow.h:
        * page/DOMWindow.idl:
        * storage/Database.cpp:
        (WebCore::Database::openDatabase):
        (WebCore::Database::Database):
        (WebCore::Database::performOpenAndVerify):
        * storage/Database.h:
        * storage/DatabaseCallback.h: Removed.
        * workers/WorkerContext.cpp:
        (WebCore::WorkerContext::openDatabase):
        * workers/WorkerContext.h:

2766
2767
2768
2769
2770
2771
2772
2773
2774
2775
2776
2777
2778
2779
2780
2781
2782
2783
2784
2785
2786
2787
2788
2789
2790
2791
2792
2793
2794
2795
2796
2797
2798
2799
2800
2801
2802
2803
2804
2805
2806
2010-03-06  Mark Rowe  <mrowe@apple.com>

        Rubber-stamped by Sam Weinig.

        Remove unnecessary includes of wtf/Platform.h.  This is already pulled in by config.h.

        * accessibility/AccessibilityObject.h:
        * dom/XMLTokenizer.cpp:
        * dom/XMLTokenizerLibxml2.cpp:
        * dom/XMLTokenizerQt.cpp:
        * editing/TextAffinity.h:
        * loader/FrameLoaderClient.h:
        * page/FocusController.cpp:
        * page/FrameTree.cpp:
        * page/Geolocation.h:
        * page/PositionCallback.h:
        * page/PositionErrorCallback.h:
        * platform/Cursor.h:
        * platform/FileSystem.h:
        * platform/FloatConversion.h:
        * platform/KeyboardCodes.h:
        * platform/PlatformKeyboardEvent.h:
        * platform/PlatformTouchPoint.h:
        * platform/SuddenTermination.h:
        * platform/Widget.h:
        * platform/graphics/Color.h:
        * platform/graphics/FloatPoint.h:
        * platform/graphics/FloatSize.h:
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/IntPoint.h:
        * platform/graphics/IntRect.h:
        * platform/graphics/IntSize.h:
        * platform/graphics/openvg/PainterOpenVG.h:
        * platform/graphics/openvg/SurfaceOpenVG.h:
        * platform/network/ResourceHandleClient.h:
        * platform/text/Base64.cpp:
        * rendering/style/SVGRenderStyle.h:
        * xml/XSLTProcessor.cpp:
        * xml/XSLTProcessorLibxslt.cpp:
        * xml/XSLTProcessorQt.cpp:

2807
2808
2809
2810
2811
2812
2813
2814
2815
2816
2817
2818
2819
2820
2821
2822
2823
2824
2825
2826
2827
2828
2829
2830
2831
2832
2833
2834
2835
2836
2837
2838
2839
2840
2841
2842
2843
2844
2010-03-06  Sam Weinig  <sam@webkit.org>

        Reviewed by Dan Bernstein.

        Move debug only JS wrapper-set tracking code into its own file.
        https://bugs.webkit.org/show_bug.cgi?id=35839

        * GNUmakefile.am: Added new files.
        * WebCore.gypi: Ditto.
        * WebCore.pro: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.

        * bindings/js/JSDOMBinding.cpp:
        (WebCore::cacheDOMObjectWrapper):
        (WebCore::forgetDOMObject):
        (WebCore::forgetDOMNode):
        (WebCore::cacheDOMNodeWrapper):
        (WebCore::takeWrappers):
        (WebCore::updateDOMNodeDocument):
        Updated for new signature for willCacheWrapper and didUncacheWrapper.

        * bindings/js/JSDOMWrapper.cpp: Added.
        (WebCore::DOMObject::~DOMObject):
        (WebCore::DOMObject::defineOwnProperty):
        Moved from JSDOMBinding.cpp.

        * bindings/js/JSDebugWrapperSet.cpp: Added.
        (WebCore::JSDebugWrapperSet::shared):
        (WebCore::JSDebugWrapperSet::JSDebugWrapperSet):
        * bindings/js/JSDebugWrapperSet.h: Added.
        (WebCore::JSDebugWrapperSet::add):
        (WebCore::JSDebugWrapperSet::remove):
        (WebCore::JSDebugWrapperSet::contains):
        (WebCore::JSDebugWrapperSet::willCacheWrapper):
        (WebCore::JSDebugWrapperSet::didUncacheWrapper):
        Moved from JSDOMBinding.cpp.

2845
2846
2847
2848
2849
2850
2851
2852
2853
2854
2855
2856
2857
2858
2859
2860
2861
2862
2863
2864
2865
2866
2867
2868
2869
2870
2871
2872
2873
2874
2875
2876
2877
2878
2879
2880
2881
2882
2883
2884
2010-03-06  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Dan Bernstein.

        Move DOMObjectHashTableMap, DOMWrapperWorld and WebCoreJSClientData into
        their own files.

        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/DOMObjectHashTableMap.cpp: Copied from bindings/js/JSDOMBinding.cpp.
        * bindings/js/DOMObjectHashTableMap.h: Copied from bindings/js/JSDOMBinding.h.
        (WebCore::DOMObjectHashTableMap::~DOMObjectHashTableMap):
        (WebCore::DOMObjectHashTableMap::get):
        * bindings/js/DOMWrapperWorld.cpp: Copied from bindings/js/JSDOMBinding.cpp.
        (WebCore::forgetWorldOfDOMNodesForDocument):
        * bindings/js/DOMWrapperWorld.h: Copied from bindings/js/JSDOMBinding.h.
        (WebCore::DOMWrapperWorld::create):
        (WebCore::DOMWrapperWorld::rememberDocument):
        (WebCore::DOMWrapperWorld::forgetDocument):
        (WebCore::DOMWrapperWorld::isNormal):
        (WebCore::debuggerWorld):
        (WebCore::pluginWorld):
        (WebCore::currentWorld):
        (WebCore::Document::getWrapperCache):
        * bindings/js/JSDOMBinding.cpp:
        * bindings/js/JSDOMBinding.h:
        * bindings/js/JSDOMWindowBase.cpp:
        * bindings/js/ScriptController.cpp:
        * bindings/js/WebCoreJSClientData.h: Copied from bindings/js/JSDOMBinding.h.
        (WebCore::WebCoreJSClientData::WebCoreJSClientData):
        (WebCore::WebCoreJSClientData::~WebCoreJSClientData):
        (WebCore::WebCoreJSClientData::normalWorld):
        (WebCore::WebCoreJSClientData::getAllWorlds):
        (WebCore::WebCoreJSClientData::rememberWorld):
        (WebCore::WebCoreJSClientData::forgetWorld):
        * bindings/js/WorkerScriptController.cpp:

mitz@apple.com's avatar
mitz@apple.com committed
2885
2886
2887
2888
2889
2890
2891
2892
2893
2894
2895
2010-03-06  Dan Bernstein  <mitz@apple.com>

        Rubber-stamped by Sam Weinig.

        Remove an unused method.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::layoutBlock): Changed comment.
        (WebCore::RenderBlock::floatRect): Removed.
        * rendering/RenderBlock.h: Removed floatRect().

2896
2897
2898
2899
2900
2901
2902
2903
2904
2905
2010-03-06  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: make timeline overview bars transparent to mouse events.

        https://bugs.webkit.org/show_bug.cgi?id=35832

        * inspector/front-end/inspector.css:

2906
2907
2908
2909
2910
2911
2912
2913
2914
2915
2916
2917
2918
2919
2920
2921
2922
2010-03-06  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Jeremy Orlow.

        Web Inspector: switching to/from Timeline Panel moves scroller.
        (Also added couple of record details items as I was fixing it).

        https://bugs.webkit.org/show_bug.cgi?id=35829

        * English.lproj/localizedStrings.js:
        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel):
        (WebInspector.TimelinePanel.prototype.get defaultFocusedElement):
        (WebInspector.TimelinePanel.prototype.show):
        (WebInspector.TimelinePanel.prototype._refreshRecords):
        (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):

2923
2924
2925
2926
2927
2928
2929
2930
2931
2932
2010-03-06  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Eric Seidel.

        Removed unnecessary WinCE file.
        The same functionality is provided by platform/win/SystemTimeWin.cpp.
        https://bugs.webkit.org/show_bug.cgi?id=35799

        * platform/wince/SystemTimeWince.cpp: Removed.

2933
2934
2935
2936
2937
2938
2939
2940
2941
2942
2943
2944
2945
2946
2947
2010-03-06  Joanmarie Diggs  <joanmarie.diggs@gmail.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=30895
        [Gtk] The accessible hierarchy of tables is significantly incorrect for Atk

        This completes the fixing of the Atk table hierarchy which was started
        in bug #35418.

        * accessibility/gtk/AccessibilityObjectAtk.cpp:
        (AccessibilityObject::accessibilityPlatformIncludesObject):
        * accessibility/AccessibilityRenderObject.cpp:
        (AccessibilityRenderObject::determineAccessibilityRole):

2948
2949
2950
2951
2952