ChangeLog 2.24 MB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12
2013-08-26  Andreas Kling  <akling@apple.com>

        FocusController::focusedOrMainFrame() should return a reference.
        <https://webkit.org/b/120339>

        Reviewed by Antti Koivisto.

        Now that Page::mainFrame() returns a reference, we can make this return a reference
        too, since there's always either a focused or a main frame.

        One hectogram of null checks removed as a result.

13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40
2013-08-26  Andreas Kling  <akling@apple.com>

        Document's renderer is always a RenderView.
        <https://webkit.org/b/120304>

        Reviewed by Darin Adler.

        Let's enforce this better by storing a RenderView* instead of a plain RenderObject*.
        We should switch callers that grab at Document::renderer() to calling renderView()
        instead, but that's better done separately.

        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::~Document):
        (WebCore::Document::setRenderView):
        (WebCore::Document::createRenderTree):
        (WebCore::Document::detach):
        (WebCore::Document::setInPageCache):
        * dom/Document.h:
        (WebCore::Document::renderView):
        (WebCore::Document::renderer):
        * html/parser/HTMLResourcePreloader.cpp:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::setStyle):
        * rendering/RenderView.h:
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::updateCurrentTranslate):

41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60
2013-08-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>

        Font's fast code path doesn't handle partial runs correctly when kerning or ligatures are enabled
        https://bugs.webkit.org/show_bug.cgi?id=100050

        Reviewed by Darin Adler.

        Renamed m_characterIndex to m_characterIndexOfGlyph and gave it an inline size of 10,
        which covers around 66% of all cases. The rest of the cases are now preallocated to the
        upper limit which is length of the original TextRun.

        * platform/graphics/FontFastPath.cpp:
        (WebCore::Font::getGlyphsAndAdvancesForSimpleText):
        (WebCore::Font::selectionRectForSimpleText):
        (WebCore::Font::offsetForPositionForSimpleText):
        * platform/graphics/WidthIterator.cpp:
        (WebCore::WidthIterator::WidthIterator):
        (WebCore::WidthIterator::advanceInternal):
        * platform/graphics/WidthIterator.h:

61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129
2013-08-27  Christophe Dumez  <ch.dumez@sisa.samsung.com>

        Implement DOM3 wheel event
        https://bugs.webkit.org/show_bug.cgi?id=94081

        Reviewed by Darin Adler.

        Add support for DOM Level 3 WheelEvent:
        http://www.w3.org/TR/DOM-Level-3-Events/#events-WheelEvent

        Firefox, IE10 and since recently Blink already support it so
        it increases our cross-browser compatibility.

        The non-standard 'mousewheel' event is still supported for backward
        compatibility. Note that the deltas returned by the mousewheel and
        the wheel events are not identical:
        - They have opposite signs.
        - The wheel event reports the actual amount of pixels that should be
        scrolled while the legacy mousewheel event reports a factor of the
        number of mouse wheel ticks (using a constant multiplier).

        Tests: fast/events/wheelevent-basic.html
               fast/events/wheelevent-constructor.html
               fast/events/wheelevent-mousewheel-interaction.html

        * dom/Document.h:
        * dom/Document.idl:
        * dom/Element.h:
        * dom/Element.idl:
        * dom/EventNames.h:
        * dom/EventTarget.cpp:
        (WebCore::legacyType):
        (WebCore::EventTarget::shouldObserveLegacyType):
        (WebCore::EventTarget::setupLegacyTypeObserverIfNeeded):
        (WebCore::EventTarget::fireEventListeners):
        * dom/EventTarget.h:
        * dom/Node.cpp:
        (WebCore::Node::didMoveToNewDocument):
        (WebCore::tryAddEventListener):
        (WebCore::tryRemoveEventListener):
        (WebCore::Node::defaultEventHandler):
        * dom/WheelEvent.cpp:
        (WebCore::WheelEventInit::WheelEventInit):
        (WebCore::WheelEvent::WheelEvent):
        (WebCore::WheelEvent::initWheelEvent):
        * dom/WheelEvent.h:
        (WebCore::WheelEvent::deltaX):
        (WebCore::WheelEvent::deltaY):
        (WebCore::WheelEvent::deltaZ):
        (WebCore::WheelEvent::wheelDelta):
        (WebCore::WheelEvent::wheelDeltaX):
        (WebCore::WheelEvent::wheelDeltaY):
        * dom/WheelEvent.idl:
        * html/HTMLAttributeNames.in:
        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::eventNameForAttributeName):
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::addEventListener):
        (WebCore::DOMWindow::removeEventListener):
        * page/DOMWindow.h:
        * page/DOMWindow.idl:
        * page/EventHandler.cpp:
        (WebCore::EventHandler::defaultWheelEventHandler):
        * plugins/blackberry/PluginViewBlackBerry.cpp:
        (WebCore::PluginView::handleWheelEvent):
        * svg/SVGElementInstance.cpp:
        * svg/SVGElementInstance.h:
        * svg/SVGElementInstance.idl:

130 131 132 133 134 135 136 137 138 139 140 141
2013-08-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>

        Assertion while scrolling news.google.com
        https://bugs.webkit.org/show_bug.cgi?id=115303

        Reviewed by Anders Carlsson.

        Do not relayout when accessing script elements during painting.

        * html/HTMLEmbedElement.cpp:
        (WebCore::HTMLEmbedElement::renderWidgetForJSBindings):

142 143 144 145 146 147 148 149 150 151 152 153 154 155 156
2013-08-27  Benjamin Poulain  <benjamin@webkit.org>

        Remove DOMSettableTokenList's overload of add() and remove()
        https://bugs.webkit.org/show_bug.cgi?id=120341

        Reviewed by Ryosuke Niwa.

        Little refactoring to make other cleanups easier. Instead of modifying
        SpaceSplitString directly, rely on DOMTokenList ultimately changing
        the value, which in turn updates the tokens.

        * html/DOMSettableTokenList.cpp:
        * html/DOMSettableTokenList.h:
        * html/DOMTokenList.h:

157 158 159 160 161 162 163 164 165 166 167 168 169 170
2013-08-27  Xabier Rodriguez Calvar  <calvaris@igalia.com>

        [GTK] Volume slider shows incorrect track when muted
        https://bugs.webkit.org/show_bug.cgi?id=120253

        Reviewed by Philippe Normand.

        When painting the volume bar, consider that it could be muted even
        then volume is different than zero.

        * platform/gtk/RenderThemeGtk.cpp:
        (WebCore::RenderThemeGtk::paintMediaVolumeSliderTrack): Asign
        painted volume as 0 when media is muted.

171 172 173 174 175 176 177 178 179 180 181 182 183 184 185
2013-08-26  Sam Weinig  <sam@webkit.org>

        EditorInternalCommand should use Frame& where possible
        https://bugs.webkit.org/show_bug.cgi?id=120340

        Reviewed by Andreas Kling.

        Only isSupportedFromDOM still takes a Frame*, as it still has callers that expect null to work.

        * dom/UserTypingGestureIndicator.cpp:
        * dom/UserTypingGestureIndicator.h:
        * editing/Editor.cpp:
        * editing/EditorCommand.cpp:
        * page/EventHandler.cpp:

186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201
2013-08-26  Ryosuke Niwa  <rniwa@webkit.org>

        Elements in a node list of the form element's name getter should not be added to the past names map
        https://bugs.webkit.org/show_bug.cgi?id=120279

        Reviewed by Darin Adler.

        Don't add the element in the named items to the past names map when there are multiple elements.
        This matches IE10's behavior and the specified behavior in HTML5:
        http://www.w3.org/TR/2013/WD-html51-20130528/forms.html#dom-form-nameditem

        Test: fast/forms/past-names-map-should-not-contain-nodelist-item.html

        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::getNamedElements):

202 203 204 205 206 207 208
2013-08-26  Ryosuke Niwa  <rniwa@webkit.org>

        Windows build fix after r154658.

        * page/AutoscrollController.cpp:
        (WebCore::getMainFrame):

209 210 211 212 213 214 215 216 217 218 219
2013-08-26  Andreas Kling  <akling@apple.com>

        Page::mainFrame() should return a reference.
        <http://webkit.org/b/119677>

        Reviewed by Antti Koivisto.

        Page always creates the main Frame by itself now, so it will never be null during the Page's lifetime.

        Let Page::mainFrame() return Frame& and remove a sea of null checks.

220 221 222 223 224 225 226 227 228 229
2013-08-26  Sam Weinig  <sam@webkit.org>

        Remove two unnecessary .get()s.

        Reviewed by Anders Carlsson.

        * editing/Editor.h:
        (WebCore::Editor::killRing):
        (WebCore::Editor::spellChecker):

230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248
2013-08-26  Joseph Pecoraro  <pecoraro@apple.com>

        Web Inspector: We should regenerate InspectorBackendCommands.js for Legacy Inspector.json versions
        https://bugs.webkit.org/show_bug.cgi?id=120242

        Reviewed by Timothy Hatcher.

        - Update the Inspector.json CodeGenerator to include an output_js_dir.
        - Cleanup multiple trailing newlines in some of the generated files.
        - Provide a way to not verify runtime casts, needed for Legacy inputs.

        * CMakeLists.txt:
        * DerivedSources.make:
        * DerivedSources.pri:
        * GNUmakefile.am:
        * inspector/CodeGeneratorInspector.py:
        (resolve_all_types):
        (SmartOutput.close):

249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290
2013-08-26  Sam Weinig  <sam@webkit.org>

        AlternativeTextController should hold onto Frame as a reference
        https://bugs.webkit.org/show_bug.cgi?id=120327

        Reviewed by Andreas Kling.

        While in the area I also:
          - Reference-ified Editor::killRing().
          - Const-ified Editor::m_killRing, Editor::m_spellChecker, and Editor::m_alternativeTextController.

        * editing/AlternativeTextController.cpp:
        (WebCore::AlternativeTextController::AlternativeTextController):
        (WebCore::AlternativeTextController::stopPendingCorrection):
        (WebCore::AlternativeTextController::isSpellingMarkerAllowed):
        (WebCore::AlternativeTextController::applyAlternativeTextToRange):
        (WebCore::AlternativeTextController::applyAutocorrectionBeforeTypingIfAppropriate):
        (WebCore::AlternativeTextController::respondToUnappliedSpellCorrection):
        (WebCore::AlternativeTextController::timerFired):
        (WebCore::AlternativeTextController::handleAlternativeTextUIResult):
        (WebCore::AlternativeTextController::rootViewRectForRange):
        (WebCore::AlternativeTextController::respondToChangedSelection):
        (WebCore::AlternativeTextController::respondToAppliedEditing):
        (WebCore::AlternativeTextController::respondToUnappliedEditing):
        (WebCore::AlternativeTextController::alternativeTextClient):
        (WebCore::AlternativeTextController::editorClient):
        (WebCore::AlternativeTextController::markPrecedingWhitespaceForDeletedAutocorrectionAfterCommand):
        (WebCore::AlternativeTextController::processMarkersOnTextToBeReplacedByResult):
        (WebCore::AlternativeTextController::respondToMarkerAtEndOfWord):
        (WebCore::AlternativeTextController::insertDictatedText):
        (WebCore::AlternativeTextController::applyDictationAlternative):
        * editing/AlternativeTextController.h:
        (WebCore::AlternativeTextController::UNLESS_ENABLED):
        * editing/Editor.cpp:
        (WebCore::Editor::Editor):
        (WebCore::Editor::addToKillRing):
        * editing/Editor.h:
        (WebCore::Editor::killRing):
        * editing/EditorCommand.cpp:
        (WebCore::executeYank):
        (WebCore::executeYankAndSelect):

291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323
2013-08-23  Andy Estes  <aestes@apple.com>

        Fix issues found by the Clang Static Analyzer
        https://bugs.webkit.org/show_bug.cgi?id=120230

        Reviewed by Darin Adler.

        * WebCore.xcodeproj/project.pbxproj: Removed FoundationExtras.h.
        * accessibility/mac/WebAccessibilityObjectWrapperMac.mm: Removed CFAutoreleaseHelper().
        (AXTextMarkerRange): Used HardAutorelease() instead of
        CFAutoreleaseHelper().
        (AXTextMarkerRangeStart): Ditto.
        (AXTextMarkerRangeEnd): Ditto.
        (textMarkerForVisiblePosition): Ditto.
        * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
        (-[WebCoreAVFMovieObserver initWithCallback:]): Called [super init]
        first so that we don't later use ivars from the wrong self.
        (-[WebCoreAVFLoaderDelegate initWithCallback:]): Ditto.
        * platform/mac/FoundationExtras.h: Removed.
        * platform/mac/KURLMac.mm:
        (WebCore::KURL::operator NSURL *): Used WTF's HardAutorelease().
        * platform/mac/WebCoreNSURLExtras.mm:
        (WebCore::mapHostNameWithRange): Used HardAutorelease() instead of
        WebCoreCFAutorelease().
        (WebCore::URLWithData): Ditto.
        (WebCore::userVisibleString): Ditto.
        (WebCore::URLByRemovingComponentAndSubsequentCharacter): Used Vector<>
        with an inline capacity rather than heap-allocating a buffer.
        * platform/mac/WebCoreObjCExtras.h: Used HardAutorelease() instead of
        WebCoreCFAutorelease().
        * platform/text/mac/StringImplMac.mm:
        (WTF::StringImpl::operator NSString *): Used WTF's HardAutorelease().

324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346
2013-08-26  Pratik Solanki  <psolanki@apple.com>

        Page::console() should return a reference
        https://bugs.webkit.org/show_bug.cgi?id=120320

        Reviewed by Darin Adler.

        Page::m_console is never NULL so console() can just return a reference.

        * css/CSSParser.cpp:
        (WebCore::CSSParser::logError):
        * dom/Document.cpp:
        (WebCore::Document::addConsoleMessage):
        (WebCore::Document::addMessage):
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::pageConsole):
        * page/Page.h:
        (WebCore::Page::console):
        * xml/XSLStyleSheetLibxslt.cpp:
        (WebCore::XSLStyleSheet::parseString):
        * xml/XSLTProcessorLibxslt.cpp:
        (WebCore::docLoaderFunc):

rwlbuis@webkit.org's avatar
rwlbuis@webkit.org committed
347 348 349 350 351 352 353 354 355 356 357 358 359
2013-08-26  Rob Buis  <rwlbuis@webkit.org>

        Lonely stop crashes
        https://bugs.webkit.org/show_bug.cgi?id=87964

        Reviewed by Darin Adler.

        Provide a nodeAtFloatPoint implementation for RenderSVGGradientStop to avoid hitting the assert in RenderObject::nodeAtFloatPoint.

        Test: svg/custom/stop-crash-hittest.svg

        * rendering/svg/RenderSVGGradientStop.h:

360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382
2013-08-26  Sam Weinig  <sam@webkit.org>

        Editor::spellChecker() should return a reference
        https://bugs.webkit.org/show_bug.cgi?id=120325

        Reviewed by Anders Carlsson.

        * editing/Editor.cpp:
        (WebCore::Editor::Editor):
        * editing/Editor.h:
        (WebCore::Editor::spellChecker):
        * editing/SpellChecker.cpp:
        (WebCore::SpellChecker::SpellChecker):
        (WebCore::SpellChecker::client):
        (WebCore::SpellChecker::isAsynchronousEnabled):
        (WebCore::SpellChecker::didCheck):
        (WebCore::SpellChecker::didCheckSucceed):
        * editing/SpellChecker.h:
        * page/EditorClient.h:
        * testing/Internals.cpp:
        (WebCore::Internals::lastSpellCheckRequestSequence):
        (WebCore::Internals::lastSpellCheckProcessedSequence):

383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423
2013-08-26  Bem Jones-Bey  <bjonesbe@adobe.com>

        Optimize FloatIntervalSearchAdapter::collectIfNeeded
        https://bugs.webkit.org/show_bug.cgi?id=120237

        Reviewed by David Hyatt.

        This is a port of 3 Blink patches:
        https://codereview.chromium.org/22463002 (By shatch@chromium.org)
        https://chromiumcodereview.appspot.com/22909005 (By me)
        https://chromiumcodereview.appspot.com/23084002 (By me)

        shatch optimized FloatIntervalSearchAdapter by having it store the
        outermost float instead of making a bunch of calls to
        logical(Left/Right/Bottom)ForFloat, and then only making that call
        once when heightRemaining needs to be computed.

        I noticed that now we were storing both the last float encountered and
        the outermost float, and that the behavior for shape-outside wasn't
        significantly changed by using the outermost float instead of the last
        float encountered (and in most cases, using the outermost float gives
        more reasonable behavior). Since this isn't covered in the spec yet, I
        changed shape-outside to use the outermost float, making it so that we
        only need to store one float pointer when walking the placed floats
        tree, and keeping the performance win.

        Also while changing updateOffsetIfNeeded, removed const, since that is
        a lie. Nothing about that method is const.

        Test: fast/shapes/shape-outside-floats/shape-outside-floats-outermost.html

        * rendering/RenderBlock.cpp:
        (WebCore::::updateOffsetIfNeeded):
        (WebCore::::collectIfNeeded):
        (WebCore::::getHeightRemaining):
        (WebCore::RenderBlock::logicalLeftFloatOffsetForLine):
        (WebCore::RenderBlock::logicalRightFloatOffsetForLine):
        * rendering/RenderBlock.h:
        (WebCore::RenderBlock::FloatIntervalSearchAdapter::FloatIntervalSearchAdapter):
        (WebCore::RenderBlock::FloatIntervalSearchAdapter::outermostFloat):

424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465
2013-08-26  Alexey Proskuryakov  <ap@apple.com>

        [Mac] can-read-in-dragstart-event.html and can-read-in-copy-and-cut-events.html fail
        https://bugs.webkit.org/show_bug.cgi?id=113094

        Reviewed by Darin Adler.

        Mac platform implementation has checks for pasteboard change count, but it
        didn't use to update the count when writing to pasteboad from JavaScript.

        * platform/PasteboardStrategy.h: Changed changeCount function to return a long
        instead of an int, as the underlying Mac type is NSInteger. Changed all methods
        that modify the pasteboard to return a new change count.

        * platform/PlatformPasteboard.h: Changed all methods that modify the pasteboard
        to return a new change count.

        * platform/mac/PasteboardMac.mm:
        (WebCore::Pasteboard::clear): Update m_changeCount.
        (WebCore::Pasteboard::writeSelectionForTypes): Ditto.
        (WebCore::Pasteboard::writePlainText): Ditto.
        (WebCore::writeURLForTypes): Ditto.
        (WebCore::Pasteboard::writeURL): Ditto.
        (WebCore::writeFileWrapperAsRTFDAttachment): Ditto.
        (WebCore::Pasteboard::writeImage): Ditto.
        (WebCore::Pasteboard::writePasteboard): Ditto.
        (WebCore::addHTMLClipboardTypesForCocoaType): Ditto.
        (WebCore::Pasteboard::writeString): Ditto.

        * platform/mac/PlatformPasteboardMac.mm:
        (WebCore::PlatformPasteboard::changeCount): Changed returned type to long to avoid
        data loss.
        (WebCore::PlatformPasteboard::copy): Return new change count.
        (WebCore::PlatformPasteboard::addTypes): Ditto.
        (WebCore::PlatformPasteboard::setTypes): Ditto.
        (WebCore::PlatformPasteboard::setBufferForType): Ditto.
        (WebCore::PlatformPasteboard::setPathnamesForType): Ditto.
        (WebCore::PlatformPasteboard::setStringForType): Ditto. Replaced -[NSURL writeToPasteboard:]
        with an equivalent implemnentation that tells use whether writing was successful.
        There is difference with invalid URL string handling - we used to silently ignore
        such requets, but set pasteboard content to empty URL now.

weinig@apple.com's avatar
weinig@apple.com committed
466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550
2013-08-24  Sam Weinig  <sam@webkit.org>

        Add support for Promises
        https://bugs.webkit.org/show_bug.cgi?id=120260

        Reviewed by Darin Adler.

        Add an initial implementation of Promises - http://dom.spec.whatwg.org/#promises.
        - Despite Promises being defined in the DOM, the implementation is being put in JSC
          in preparation for the Promises eventually being defined in ECMAScript.

        Tests: fast/js/Promise-already-fulfilled.html
               fast/js/Promise-already-rejected.html
               fast/js/Promise-already-resolved.html
               fast/js/Promise-catch-in-workers.html
               fast/js/Promise-catch.html
               fast/js/Promise-chain.html
               fast/js/Promise-exception.html
               fast/js/Promise-fulfill-in-workers.html
               fast/js/Promise-fulfill.html
               fast/js/Promise-init-in-workers.html
               fast/js/Promise-init.html
               fast/js/Promise-reject-in-workers.html
               fast/js/Promise-reject.html
               fast/js/Promise-resolve-chain.html
               fast/js/Promise-resolve-in-workers.html
               fast/js/Promise-resolve-with-then-exception.html
               fast/js/Promise-resolve-with-then-fulfill.html
               fast/js/Promise-resolve-with-then-reject.html
               fast/js/Promise-resolve.html
               fast/js/Promise-simple-fulfill-inside-callback.html
               fast/js/Promise-simple-fulfill.html
               fast/js/Promise-simple-in-workers.html
               fast/js/Promise-simple.html
               fast/js/Promise-static-fulfill.html
               fast/js/Promise-static-reject.html
               fast/js/Promise-static-resolve.html
               fast/js/Promise-then-in-workers.html
               fast/js/Promise-then-without-callbacks-in-workers.html
               fast/js/Promise-then-without-callbacks.html
               fast/js/Promise-then.html
               fast/js/Promise-types.html
               fast/js/Promise.html

        * GNUmakefile.list.am:
        * Target.pri:
        * UseJSC.cmake:
        * WebCore.vcxproj/WebCore.vcxproj:
        * WebCore.vcxproj/WebCore.vcxproj.filters:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSBindingsAllInOne.cpp:
        Add new files.

        * bindings/js/JSDOMGlobalObjectTask.cpp: Added.
        (WebCore::JSGlobalObjectCallback::create):
        (WebCore::JSGlobalObjectCallback::~JSGlobalObjectCallback):
        (WebCore::JSGlobalObjectCallback::call):
        (WebCore::JSGlobalObjectCallback::JSGlobalObjectCallback):
        (WebCore::JSGlobalObjectTask::JSGlobalObjectTask):
        (WebCore::JSGlobalObjectTask::~JSGlobalObjectTask):
        (WebCore::JSGlobalObjectTask::performTask):
        * bindings/js/JSDOMGlobalObjectTask.h: Added.
        (WebCore::JSGlobalObjectTask::create):
        Add a new task type to be used with the GlobalObjectMethodTable's new QueueTaskToEventLoop callback.

        * bindings/js/JSDOMWindowBase.cpp:
        (WebCore::JSDOMWindowBase::queueTaskToEventLoop):
        * bindings/js/JSDOMWindowBase.h:
        Implement the GlobalObjectMethodTable callback, QueueTaskToEventLoop. 

        * bindings/js/JSMainThreadExecState.h:
        All using JSMainThreadExecState as a simple RAII object.

        * bindings/js/JSWorkerGlobalScopeBase.cpp:
        (WebCore::JSWorkerGlobalScopeBase::JSWorkerGlobalScopeBase):
        (WebCore::JSWorkerGlobalScopeBase::allowsAccessFrom):
        (WebCore::JSWorkerGlobalScopeBase::supportsProfiling):
        (WebCore::JSWorkerGlobalScopeBase::supportsRichSourceInfo):
        (WebCore::JSWorkerGlobalScopeBase::shouldInterruptScript):
        (WebCore::JSWorkerGlobalScopeBase::javaScriptExperimentsEnabled):
        (WebCore::JSWorkerGlobalScopeBase::queueTaskToEventLoop):
        * bindings/js/JSWorkerGlobalScopeBase.h:
        Add a GlobalObjectMethodTable and implement QueueTaskToEventLoop. Forward the other callbacks
        to JSGlobalObject so they retain their existing behavior.

551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567
2013-08-26  Rob Buis  <rwlbuis@webkit.org>

        Computed style of fill/stroke properties incorrect on references
        https://bugs.webkit.org/show_bug.cgi?id=114761

        Reviewed by Darin Adler.

        The computed style of the fill and stroke properties did not include
        the url() function. Added the url() string to output.

        Updated existing tests to cover the issue.

        * css/CSSPrimitiveValue.cpp: Cleanup.
        (WebCore::CSSPrimitiveValue::customCssText):
        * svg/SVGPaint.cpp: Added "url("
        (WebCore::SVGPaint::customCssText):

568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583
2013-08-26  Zan Dobersek  <zdobersek@igalia.com>

        Prettify generated build guards in HTMLElementFactory.cpp
        https://bugs.webkit.org/show_bug.cgi?id=120310

        Reviewed by Darin Adler.

        Build guards should wrap the constructor definitions without empty lines between
        the guards and the constructor code. Similarly, build guards for addTag calls
        shouldn't put an empty line after the build guard closure.

        * dom/make_names.pl:
        (printConstructorInterior):
        (printConstructors):
        (printFunctionInits):

584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604
2013-08-26  Robert Hogan  <robert@webkit.org>

        Avoid painting every non-edge collapsed border twice over
        https://bugs.webkit.org/show_bug.cgi?id=119759

        Reviewed by David Hyatt.

        Every collapsed border that isn't on the edge of a table gets painted at least twice, once by each 
        adjacent cell. The joins are painted four times. This is unnecessary and results in tables with semi-transparent
        borders getting rendered incorrectly - each border adjoing two cells is painted twice and ends up darker than it should be. 

        Fixing the overpainting at joins is another day's work. This patch ensures each collapsed border inside a table is only
        painted once. It does this by only allowing cells at the top and left edge of the table to paint their top and left collapsed borders.
        All the others can only paint their right and bottom collapsed border. This works because the borders are painted from bottom right to top left.

        Tests: fast/table/border-collapsing/collapsed-borders-adjoining-sections-vertical-rl.html
               fast/table/border-collapsing/collapsed-borders-adjoining-sections.html

        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::paintCollapsedBorders):

akling@apple.com's avatar
akling@apple.com committed
605 606 607 608 609 610 611
2013-08-26  Andreas Kling  <akling@apple.com>

        Unreviewed build fix.

        * page/Page.cpp:
        (WebCore::Page::setNeedsRecalcStyleInAllFrames):

bfulgham@apple.com's avatar
bfulgham@apple.com committed
612 613 614 615 616 617 618
2013-08-26  Brent Fulgham  <bfulgham@apple.com>

        Unreviewed buid fix.

        * page/Page.cpp: 
        (WebCore::Page::setNeedsRecalcStyleInAllFrames): Remove extra '{' character.

619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637
2013-08-26  Pratik Solanki  <psolanki@apple.com>

        PageGroup::groupSettings() should return a reference
        https://bugs.webkit.org/show_bug.cgi?id=120319

        Reviewed by Andreas Kling.

        PageGroup::m_groupSettings is never NULL so we can just return a reference from groupSettings().

        * Modules/indexeddb/IDBFactory.cpp:
        * page/PageGroup.h:
        (WebCore::PageGroup::groupSettings):
        * storage/StorageNamespaceImpl.cpp:
        (WebCore::StorageNamespaceImpl::localStorageNamespace):
        * workers/DefaultSharedWorkerRepository.cpp:
        (WebCore::SharedWorkerProxy::groupSettings):
        * workers/WorkerMessagingProxy.cpp:
        (WebCore::WorkerMessagingProxy::startWorkerGlobalScope):

638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691
2013-08-26  Andreas Kling  <akling@apple.com>

        WebCore: Let Page create the main Frame.
        <https://webkit.org/b/119964>

        Reviewed by Anders Carlsson.

        Previously, Frame::create() would call Page::setMainFrame() when constructing the
        main Frame for a Page. Up until that point, Page had a null mainFrame().

        To guarantee that Page::mainFrame() is never null, we re-order things so that
        Page is responsible for creating its own main Frame. We do this at the earliest
        possible point; in the Page constructor initializer list.

        Constructing a Frame requires a FrameLoaderClient*, so I've added such a field to
        the PageClients struct.

        When creating a WebKit-layer frame, we now wrap the already-instantiated
        Page::mainFrame() instead of creating a new Frame.

        * loader/EmptyClients.cpp:
        (WebCore::fillWithEmptyClients):

            Add an EmptyFrameLoaderClient to the PageClients constructed here.

        * inspector/InspectorOverlay.cpp:
        (WebCore::InspectorOverlay::overlayPage):
        * svg/graphics/SVGImage.cpp:
        (WebCore::SVGImage::dataChanged):

            Updated to wrap Page::mainFrame() in a FrameView instead of creating their
            own Frame manually.

        * page/Frame.cpp:
        (WebCore::Frame::create):
        * page/Page.h:

            Remove Page::setMainFrame() and the only call site.

        * page/Page.cpp:
        (WebCore::Page::Page):

            Construct Page::m_mainFrame in the initializer list.

        (WebCore::Page::PageClients::PageClients):

            Add "FrameLoaderClient* loaderClientForMainFrame" to PageClients.

        (WebCore::Page::setNeedsRecalcStyleInAllFrames):

            Null-check the Frame::document() before calling through on it. This would
            otherwise crash when changing font-related Settings before calling init() on
            the Frame (like InspectorOverlay does.)

692 693 694 695 696 697 698 699 700 701 702
2013-08-26  Brent Fulgham  <bfulgham@apple.com>

        [Windows] Unreviewed build fix.

        * rendering/RenderMediaControls.cpp: Remove references to QuickTime controls
        that are no longer part of WKSI.
        (wkHitTestMediaUIPart): 
        (wkMeasureMediaUIPart):
        (wkDrawMediaUIPart):
        (wkDrawMediaSliderTrack):

703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732
2013-08-26  Gurpreet Kaur  <gur.trio@gmail.com>

        <https://webkit.org/b/106133> document.body.scrollTop & document.documentElement.scrollTop differ cross-browser

        Reviewed by Darin Adler.

        Webkit always uses document.body.scrollTop whether quirks or
        standard mode. Similiar behaviour is for document.body.scrollLeft.
        As per the specification webkit should return document.body.scrollTop
        for quirks mode and document.documentElement.scrollTop for standard mode.
        Same for document.body.scrollLeft and document.documentElement.scrollLeft.

        Tests: fast/dom/Element/scrollLeft-Quirks.html
               fast/dom/Element/scrollLeft.html
               fast/dom/Element/scrollTop-Quirks.html
               fast/dom/Element/scrollTop.html

        * dom/Element.cpp:
        (WebCore::Element::scrollLeft):
        (WebCore::Element::scrollTop): 
        If the element does not have any associated CSS layout box or the element
        is the root element and the Document is in quirks mode return zero.
        Else If the element is the root element return the value of scrollY
        for scrollTop and scrollX for scrollLeft.
        * html/HTMLBodyElement.cpp:
        (WebCore::HTMLBodyElement::scrollLeft):
        (WebCore::HTMLBodyElement::scrollTop):
        If the element is the HTML body element, the Document is in quirks mode,
        return the value of scrollY for scrollTop and scrollX for scrollLeft.

733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749
2013-08-26  Antti Koivisto  <antti@apple.com>

        REGRESSION (r154581): Some plugin tests failing in debug bots
        https://bugs.webkit.org/show_bug.cgi?id=120315

        Reviewed by Darin Adler.
        
        We are hitting the new no-event-dispatch-while-iterating assertion.

        Detaching deletes a plugin which modifies DOM while it dies.

        * dom/Document.cpp:
        (WebCore::Document::createRenderTree):
        (WebCore::Document::detach):
        
            Don't iterate at all. Document never has more than one Element child anyway.

750 751 752 753 754 755 756 757 758 759
2013-08-26  David Kilzer  <ddkilzer@apple.com>

        BUILD FIX (r154580): RenderObject::document() returns a reference

        See: <https://webkit.org/b/120272>

        * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
        (-[WebAccessibilityObjectWrapper _accessibilityParentForSubview:]):
        (AXAttributeStringSetHeadingLevel):

760 761 762 763 764 765 766 767
2013-08-26  Brent Fulgham  <bfulgham@apple.com>

        [Windows] Build fix after r154578.  Return Vector<String>() instead
        of ListHashSet<String>().

        * platform/win/PasteboardWin.cpp:
        (WebCore::Pasteboard::types):

768 769 770 771 772 773 774 775 776 777
2013-08-26  Brent Fulgham  <bfulgham@apple.com>

        [Windows] Build fix after r154580.

        * rendering/RenderThemeWin.cpp: Mirror changes made for other ports now that
        Frame is known to always be valid when in a render tree. This allows us to
        get rid of some unneeded null checks.
        (WebCore::RenderThemeWin::getThemeData):
        (WebCore::RenderThemeWin::paintMenuList):

778 779 780 781 782 783 784 785 786 787
2013-08-26  Brent Fulgham  <bfulgham@apple.com>

        [Windows] Build fix after r154554.

        * page/AutoscrollController.cpp: Correct various places where pointers are now
        references.
        (WebCore::AutoscrollController::stopAutoscrollTimer):
        (WebCore::AutoscrollController::startPanScrolling):
        (WebCore::AutoscrollController::autoscrollTimerFired):

788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803
2013-08-26  Andreas Kling  <akling@apple.com>

        Move DocumentTiming inside ENABLE(WEB_TIMING) guards.
        <https://webkit.org/b/120281>

        Reviewed by Anders Carlsson.

        Looks like this struct is only used by other ENABLE(WEB_TIMING) code, so don't bother
        filling it in if we're not building like that.

        * dom/Document.cpp:
        (WebCore::Document::setReadyState):
        (WebCore::Document::finishedParsing):
        * dom/Document.h:
        * dom/DocumentTiming.h:

804 805 806 807 808 809 810 811 812 813
2013-08-26  Carlos Garcia Campos  <cgarcia@igalia.com>

        [GTK] Fix compile warning in WebKitDOMCustom
        https://bugs.webkit.org/show_bug.cgi?id=120286

        Reviewed by Philippe Normand.

        * bindings/gobject/WebKitDOMCustom.cpp:
        (webkit_dom_html_element_get_item_type): Add return 0.

814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841
2013-08-25  Ryosuke Niwa  <rniwa@webkit.org>

        JSHTMLFormElement::canGetItemsForName needlessly allocates a Vector
        https://bugs.webkit.org/show_bug.cgi?id=120277

        Reviewed by Sam Weinig.

        Added HTMLFormElement::hasNamedElement and used it in JSHTMLFormElement::canGetItemsForName.

        This required fixing a bug in HTMLFormElement::getNamedElements that the first call to getNamedElements
        after replacing an element A with another element B of the same name caused it to erroneously append A
        to namedItems via the aliases mapping. Because getNamedElements used to be always called in pairs, this
        wrong behavior was never visible to the Web. Fixed the bug by not adding the old element to namedItem
        when namedItem's size is 1.

        Also renamed m_elementAliases to m_pastNamesMap along with related member functions.

        No new tests are added since there should be no Web exposed behavioral change.

        * bindings/js/JSHTMLFormElementCustom.cpp:
        (WebCore::JSHTMLFormElement::canGetItemsForName):
        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::elementFromPastNamesMap):
        (WebCore::HTMLFormElement::addElementToPastNamesMap):
        (WebCore::HTMLFormElement::hasNamedElement):
        (WebCore::HTMLFormElement::getNamedElements):
        * html/HTMLFormElement.h:

842 843 844 845 846 847 848 849 850
2013-08-25  Andreas Kling  <akling@apple.com>

        RenderLayerBacking::renderer() should return a reference.
        <https://webkit.org/b/120280>

        Reviewed by Anders Carlsson.

        It's just a forwarding call to RenderLayer::renderer() which already returns a reference.

851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866
2013-08-25  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Add toSVGMissingGlyphElement(), and use it.
        https://bugs.webkit.org/show_bug.cgi?id=120197

        Reviewed by Andreas Kling.

        As a step to clean-up static_cast<SVGXXX>, toSVGMissingGlyphElement() is added to clean-up
        static_cast<SVGMissingGlyphElement*>.

        * svg/SVGFontElement.cpp:
        (WebCore::SVGFontElement::firstMissingGlyphElement):
        (WebCore::SVGFontElement::ensureGlyphCache):
        * svg/SVGMissingGlyphElement.h:
        (WebCore::toSVGMissingGlyphElement):

867 868 869 870 871 872 873 874 875 876
2013-08-25  Andreas Kling  <akling@apple.com>

        RenderLayer::renderer() should return a reference.
        <https://webkit.org/b/120276>

        Reviewed by Anders Carlsson.

        RenderLayer is always created with a renderer, so make renderer() (and m_renderer) references.
        Nuked an assortment of useless null checks.

877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964
2013-08-25  Antti Koivisto  <antti@apple.com>

        Element child and descendant iterators
        https://bugs.webkit.org/show_bug.cgi?id=120248

        Reviewed by Sam Weinig and Andreas Kling.

        Add iterators for Element children and descendants.
        
        To iterate over element children:
        
        #include "ChildIterator.h"
        
        for (auto it = elementChildren(this).begin(), end = elementChildren(this).end(); it != end; ++it) {
            Element& element = *it;
            ...

        for (auto it = childrenOfType<HTMLAreaElement>(this).begin(), end = childrenOfType<HTMLAreaElement>(this).end(); it != end; ++it) {
            HTMLAreaElement& area = *it;
            ...

        To iteratate over element descendants in pre-order:
        
        #include "DescendantIterator.h"
        
        for (auto it = elementDescendants(this).begin(), end = elementDescendants(this).end(); it != end; ++it) {
            Element& element = *it;
            ...

        for (auto it = descendantsOfType<HTMLAreaElement>(this).begin(), end = descendantsOfType<HTMLAreaElement>(this).end(); it != end; ++it) {
            HTMLAreaElement& area = *it;
            ...
            
        The iterators assert against DOM mutations and event dispatch while iterating in debug builds.
            
        They are compatible with C++11 range-based for loops. In the future we can use
        
        for (auto& element : elementChildren(this))
            ...

        etc.
        
        The patch all uses the new iterators in a few places.

        * WebCore.xcodeproj/project.pbxproj:
        * accessibility/AccessibilityNodeObject.cpp:
        (WebCore::AccessibilityNodeObject::canvasHasFallbackContent):
        (WebCore::siblingWithAriaRole):
        * accessibility/AccessibilityRenderObject.cpp:
        * accessibility/AccessibilityTable.cpp:
        (WebCore::AccessibilityTable::isDataTable):
        * dom/ChildIterator.h: Added.
        (WebCore::ChildIterator::operator*):
        (WebCore::ChildIterator::operator->):
        (WebCore::::ChildIterator):
        (WebCore::::operator):
        (WebCore::=):
        (WebCore::::ChildIteratorAdapter):
        (WebCore::::begin):
        (WebCore::::end):
        (WebCore::elementChildren):
        (WebCore::childrenOfType):
        * dom/DescendantIterator.h: Added.
        (WebCore::DescendantIterator::operator*):
        (WebCore::DescendantIterator::operator->):
        (WebCore::::DescendantIterator):
        (WebCore::::operator):
        (WebCore::=):
        (WebCore::::DescendantIteratorAdapter):
        (WebCore::::begin):
        (WebCore::::end):
        (WebCore::elementDescendants):
        (WebCore::descendantsOfType):
        * dom/Document.cpp:
        (WebCore::Document::buildAccessKeyMap):
        (WebCore::Document::childrenChanged):
        (WebCore::Document::attach):
        (WebCore::Document::detach):
        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::cleanupUnstyledAppleStyleSpans):
        * editing/markup.cpp:
        (WebCore::completeURLs):
        * html/HTMLMapElement.cpp:
        (WebCore::HTMLMapElement::mapMouseEvent):
        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::selectMediaResource):
        (WebCore::HTMLMediaElement::textTrackModeChanged):

965 966 967 968 969 970 971 972 973 974
2013-08-25  Andreas Kling  <akling@apple.com>

        RenderObject::document() should return a reference.
        <https://webkit.org/b/120272>

        Reviewed by Antti Koivisto.

        There's always a Document. We were allocated in someone's arena, after all.
        Various null checks and assertions neutralized.

975 976 977 978 979 980 981 982
2013-08-25  David Kilzer  <ddkilzer@apple.com>

        BUILD FIX (r154578): Return Vector<String>() from Pasteboard::types() for iOS

        * platform/ios/PasteboardIOS.mm:
        (WebCore::Pasteboard::types): Return Vector<String>() instead of
        ListHashSet<String>() after r154578.

983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012
2013-08-25  Darin Adler  <darin@apple.com>

        Make JavaScript binding for Clipboard::types more normal
        https://bugs.webkit.org/show_bug.cgi?id=120271

        Reviewed by Anders Carlsson.

        * bindings/js/JSClipboardCustom.cpp:
        (WebCore::JSClipboard::types): Make a simple custom binding. Only needed because
        there is a special value, null, this can return.

        * dom/Clipboard.cpp:
        (WebCore::Clipboard::types): Return Vector<String> instead of ListHashSet<String>.
        * dom/Clipboard.h: Ditto.
        * platform/Pasteboard.h: Ditto.
        * platform/blackberry/PasteboardBlackBerry.cpp:
        (WebCore::Pasteboard::types): Ditto.
        * platform/efl/PasteboardEfl.cpp:
        (WebCore::Pasteboard::types): Ditto.
        * platform/gtk/PasteboardGtk.cpp:
        (WebCore::Pasteboard::types): Ditto.
        * platform/ios/PasteboardIOS.mm:
        (WebCore::Pasteboard::types): Ditto.
        * platform/mac/PasteboardMac.mm:
        (WebCore::Pasteboard::types): Ditto.
        * platform/qt/PasteboardQt.cpp:
        (WebCore::Pasteboard::types): Ditto.
        * platform/win/PasteboardWin.cpp:
        (WebCore::Pasteboard::types): Ditto.

1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026
2013-08-25  David Kilzer  <ddkilzer@apple.com>

        Unreviewed rollout of r154571. Broke internal iOS build.

        Reopened: No need for clearTimers function in Frame
        https://bugs.webkit.org/show_bug.cgi?id=120265

        * history/CachedFrame.cpp:
        (WebCore::CachedFrame::CachedFrame):
        (WebCore::CachedFrame::destroy):
        * page/Frame.cpp:
        (WebCore::Frame::clearTimers):
        * page/Frame.h:

1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042
2013-08-25  Darin Adler  <darin@apple.com>

        No need for hasData in Clipboard
        https://bugs.webkit.org/show_bug.cgi?id=120269

        Reviewed by Andreas Kling.

        This simple forwarder does not belong in the Clipboard class.
        The drag code that uses it already works directly with Pasteboard.

        * dom/Clipboard.cpp: Removed hasData.
        * dom/Clipboard.h: Ditto.

        * page/DragController.cpp:
        (WebCore::DragController::startDrag): Call through the pasteboard.

1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065
2013-08-25  Darin Adler  <darin@apple.com>

        No need for documentTypeString function in Frame
        https://bugs.webkit.org/show_bug.cgi?id=120262

        Reviewed by Andreas Kling.

        * WebCore.exp.in: Removed export of Frame::documentTypeString.

        * editing/markup.cpp:
        (WebCore::documentTypeString): Added. Replaces the old Frame member function.
        Makes more sense to have this here since it is both called by and calls code
        in this file; somehow this function was left behind.
        (WebCore::createFullMarkup): Changed to call the new function.
        * editing/markup.h: Added documentTypeString function. Has to be exported
        because LegacyWebArchive uses it; might be worth fixing that later.
        * loader/archive/cf/LegacyWebArchive.cpp:
        (WebCore::LegacyWebArchive::create): Changed to call the new function.
        (WebCore::LegacyWebArchive::createFromSelection): Ditto.

        * page/Frame.cpp: Removed Frame::documentTypeString.
        * page/Frame.h: Ditto.

1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078
2013-08-25  Darin Adler  <darin@apple.com>

        Clipboard is in DOM directory, but ClipboardMac is in platform directory
        https://bugs.webkit.org/show_bug.cgi?id=120267

        Reviewed by Andreas Kling.

        This file is almost gone; has just one function in it. Move it for now, and later
        we can delete it entirely.

        * WebCore.xcodeproj/project.pbxproj: Updated for new file location.
        * dom/ClipboardMac.mm: Moved from Source/WebCore/platform/mac/ClipboardMac.mm.

1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124
2013-08-25  Darin Adler  <darin@apple.com>

        No need for notifyChromeClientWheelEventHandlerCountChanged in Frame
        https://bugs.webkit.org/show_bug.cgi?id=120264

        Reviewed by Andreas Kling.

        * dom/Document.cpp:
        (WebCore::Document::createRenderTree): Renamed attach to this.
        This made it practical to remove a comment that says the same thing and
        also helps make the purpose of the function considerably more clear,
        although the relationship to the attached and detach functions is now
        less clear; should fix that soon.
        (WebCore::pageWheelEventHandlerCountChanged): Added. Contains the code
        from Frame::notifyChromeClientWheelEventHandlerCountChanged, minus some
        assertions that were only needed because the function was passed a frame
        rather than a page.
        (WebCore::Document::didBecomeCurrentDocumentInFrame): Added. Contains
        most of the code from Frame::setDocument. Looking at before and after,
        we can see that most of the work is within the document class and matches
        up with other code already in this class. Added FIXMEs about many problems
        spotted in the code.
        (WebCore::Document::topDocument): Added FIXME and tweaked formatting.
        (WebCore::wheelEventHandlerCountChanged): Moved the call to the
        pageWheelEventHandlerCountChanged in here from the two call sites.
        Also added a FIXME.
        (WebCore::Document::didAddWheelEventHandler): Removed the call to
        notifyChromeClientWheelEventHandlerCountChanged, since that's now handled
        inside wheelEventHandlerCountChanged.
        (WebCore::Document::didRemoveWheelEventHandler): Ditto.

        * dom/Document.h: Renamed attach to createRenderTree, made it private,
        and added a new didBecomeCurrentDocumentInFrame function.

        * loader/PlaceholderDocument.cpp:
        (WebCore::PlaceholderDocument::createRenderTree): Renamed from attach.
        * loader/PlaceholderDocument.h: Did the rename and made the function a
        private override.

        * page/Frame.cpp:
        (WebCore::Frame::setDocument): Moved most of this function out of here
        into the new Document::didBecomeCurrentDocumentInFrame function.
        Also deleted notifyChromeClientWheelEventHandlerCountChanged.

        * page/Frame.h: Deleted notifyChromeClientWheelEventHandlerCountChanged.

1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141
2013-08-25  Darin Adler  <darin@apple.com>

        No need for dispatchVisibilityStateChangeEvent function
        https://bugs.webkit.org/show_bug.cgi?id=120261

        Reviewed by Andreas Kling.

        * dom/Document.cpp: Removed dispatchVisibilityStateChangeEvent.
        * dom/Document.h: Ditto.
        * page/Frame.cpp: Ditto.
        * page/Frame.h: Ditto.

        * page/Page.cpp:
        (WebCore::Page::setVisibilityState): Put all the logic for dispatching the
        visibility state change event. Nothing here requires any special information
        about the internals of Frame or Document.

1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156
2013-08-25  Darin Adler  <darin@apple.com>

        No need for clearTimers function in Frame
        https://bugs.webkit.org/show_bug.cgi?id=120265

        Reviewed by Andreas Kling.

        * history/CachedFrame.cpp:
        (WebCore::clearTimers): Added. Moved here from Frame.
        (WebCore::CachedFrame::CachedFrame): Call above function.
        (WebCore::CachedFrame::destroy): Ditto.

        * page/Frame.cpp: Removed the two clearTimers functions.
        * page/Frame.h: Ditto.

1157 1158 1159 1160 1161 1162 1163 1164
2013-08-24  Ryuan Choi  <ryuan.choi@samsung.com>

        Unreviewed build fix after r154560

        * page/FrameTree.cpp:
        (WebCore::FrameTree::scopedChild): 
        Use tree(). instead of tree()->.

1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178
2013-08-24  Benjamin Poulain  <benjamin@webkit.org>

        <https://webkit.org/b/120102> Inline SelectorQuery's execution traits

        Reviewed by Sam Weinig.

        For some reason, clang does not always inline the trait. The operations are so simple
        that it shows up in profile.
        Force the inlining to match the original speed.

        * dom/SelectorQuery.cpp:
        (WebCore::AllElementExtractorSelectorQueryTrait::appendOutputForElement):
        (WebCore::SingleElementExtractorSelectorQueryTrait::appendOutputForElement):

1179 1180 1181 1182 1183 1184 1185 1186 1187
2013-08-24  Benjamin Poulain  <benjamin@webkit.org>

        Remove a useless #include from StyledElement
        https://bugs.webkit.org/show_bug.cgi?id=120245

        Reviewed by Andreas Kling.

        * dom/StyledElement.cpp:

1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202
2013-08-24  Darin Adler  <darin@apple.com>

        Move Frame::inScope into FrameTree
        https://bugs.webkit.org/show_bug.cgi?id=120257

        Reviewed by Sam Weinig.

        * page/Frame.cpp: Removed inScope.
        * page/Frame.h: Ditto.

        * page/FrameTree.cpp:
        (WebCore::inScope): Moved it here.
        (WebCore::FrameTree::scopedChild): Changed to call new function.
        (WebCore::FrameTree::scopedChildCount): Ditto.

1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219
2013-08-24  David Kilzer  <ddkilzer@apple.com>

        BUILD FIX: Include HTMLPlugInImageElement.h for ENABLE(PLUGIN_PROXY_FOR_VIDEO)

        Fixes the following build failure for iOS:

            In file included from Source/WebCore/accessibility/AccessibilityAllInOne.cpp:28:
            In file included from Source/WebCore/accessibility/AXObjectCache.cpp:42:
            In file included from Source/WebCore/accessibility/AccessibilityMediaControls.h:36:
            In file included from Source/WebCore/html/shadow/MediaControlElements.h:34:
            In file included from Source/WebCore/html/shadow/MediaControlElementTypes.h:37:
            Source/WebCore/html/HTMLMediaElement.h:324:23: error: unknown type name 'PluginCreationOption'
                void updateWidget(PluginCreationOption);
                                  ^

        * html/HTMLMediaElement.h:

1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497
2013-08-24  Darin Adler  <darin@apple.com>

        Frame::tree should return a reference instead of a pointer
        https://bugs.webkit.org/show_bug.cgi?id=120259

        Reviewed by Andreas Kling.

        * page/Frame.h:
        (WebCore::Frame::tree): Return a reference instead of a pointer.

        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::childFrameGetter):
        (WebCore::indexGetter):
        (WebCore::JSDOMWindow::getOwnPropertySlot):
        (WebCore::JSDOMWindow::getOwnPropertySlotByIndex):
        (WebCore::JSDOMWindow::setLocation):
        * bindings/js/PageScriptDebugServer.cpp:
        (WebCore::PageScriptDebugServer::setJavaScriptPaused):
        * dom/Document.cpp:
        (WebCore::canAccessAncestor):
        (WebCore::Document::adoptNode):
        (WebCore::Document::canNavigate):
        (WebCore::Document::findUnsafeParentScrollPropagationBoundary):
        (WebCore::Document::notifySeamlessChildDocumentsOfStylesheetUpdate):
        (WebCore::Document::openSearchDescriptionURL):
        (WebCore::Document::setDesignMode):
        (WebCore::Document::parentDocument):
        (WebCore::Document::initSecurityContext):
        (WebCore::Document::initContentSecurityPolicy):
        (WebCore::Document::requestFullScreenForElement):
        (WebCore::Document::webkitExitFullscreen):
        (WebCore::Document::didRemoveTouchEventHandler):
        * dom/TreeScope.cpp:
        (WebCore::focusedFrameOwnerElement):
        * editing/FrameSelection.cpp:
        (WebCore::FrameSelection::selectFrameElementInParentIfFullySelected):
        * history/CachedFrame.cpp:
        (WebCore::CachedFrameBase::CachedFrameBase):
        (WebCore::CachedFrameBase::restore):
        (WebCore::CachedFrame::CachedFrame):
        * history/CachedPage.cpp:
        (WebCore::CachedPage::restore):
        * history/PageCache.cpp:
        (WebCore::logCanCacheFrameDecision):
        (WebCore::PageCache::canCachePageContainingThisFrame):
        * html/HTMLDocument.cpp:
        (WebCore::HTMLDocument::hasFocus):
        * html/HTMLPlugInImageElement.cpp:
        (WebCore::HTMLPlugInImageElement::restartSimilarPlugIns):
        * inspector/InspectorApplicationCacheAgent.cpp:
        (WebCore::InspectorApplicationCacheAgent::getFramesWithManifests):
        * inspector/InspectorCanvasAgent.cpp:
        (WebCore::InspectorCanvasAgent::findFramesWithUninstrumentedCanvases):
        (WebCore::InspectorCanvasAgent::frameNavigated):
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::documents):
        * inspector/InspectorFileSystemAgent.cpp:
        (WebCore::InspectorFileSystemAgent::assertScriptExecutionContextForOrigin):
        * inspector/InspectorPageAgent.cpp:
        (WebCore::InspectorPageAgent::getCookies):
        (WebCore::InspectorPageAgent::deleteCookie):
        (WebCore::InspectorPageAgent::searchInResources):
        (WebCore::InspectorPageAgent::findFrameWithSecurityOrigin):
        (WebCore::InspectorPageAgent::buildObjectForFrame):
        (WebCore::InspectorPageAgent::buildObjectForFrameTree):
        * inspector/PageRuntimeAgent.cpp:
        (WebCore::PageRuntimeAgent::reportExecutionContextCreation):
        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::willSendRequest):
        (WebCore::DocumentLoader::mainResource):
        * loader/DocumentWriter.cpp:
        (WebCore::DocumentWriter::createDecoderIfNeeded):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::submitForm):
        (WebCore::FrameLoader::allChildrenAreComplete):
        (WebCore::FrameLoader::allAncestorsAreComplete):
        (WebCore::FrameLoader::loadURLIntoChildFrame):
        (WebCore::FrameLoader::outgoingReferrer):
        (WebCore::FrameLoader::updateFirstPartyForCookies):
        (WebCore::FrameLoader::setFirstPartyForCookies):
        (WebCore::FrameLoader::completed):
        (WebCore::FrameLoader::started):
        (WebCore::FrameLoader::loadURL):
        (WebCore::FrameLoader::loadWithDocumentLoader):
        (WebCore::FrameLoader::stopAllLoaders):
        (WebCore::FrameLoader::commitProvisionalLoad):
        (WebCore::FrameLoader::closeOldDataSources):
        (WebCore::FrameLoader::prepareForCachedPageRestore):
        (WebCore::FrameLoader::subframeIsLoading):
        (WebCore::FrameLoader::subresourceCachePolicy):
        (WebCore::FrameLoader::detachChildren):
        (WebCore::FrameLoader::closeAndRemoveChild):
        (WebCore::FrameLoader::checkLoadComplete):
        (WebCore::FrameLoader::numPendingOrLoadingRequests):
        (WebCore::FrameLoader::detachFromParent):
        (WebCore::FrameLoader::shouldClose):
        (WebCore::FrameLoader::handleBeforeUnloadEvent):
        (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
        (WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions):
        (WebCore::FrameLoader::findFrameForNavigation):
        (WebCore::FrameLoader::effectiveSandboxFlags):
        (WebCore::createWindow):
        * loader/HistoryController.cpp:
        (WebCore::HistoryController::saveDocumentState):
        (WebCore::HistoryController::saveDocumentAndScrollState):
        (WebCore::HistoryController::restoreDocumentState):
        (WebCore::HistoryController::goToItem):
        (WebCore::HistoryController::updateForRedirectWithLockedBackForwardList):
        (WebCore::HistoryController::recursiveUpdateForCommit):
        (WebCore::HistoryController::recursiveUpdateForSameDocumentNavigation):
        (WebCore::HistoryController::initializeItem):
        (WebCore::HistoryController::createItemTree):
        (WebCore::HistoryController::recursiveSetProvisionalItem):
        (WebCore::HistoryController::recursiveGoToItem):
        (WebCore::HistoryController::currentFramesMatchItem):
        * loader/NavigationScheduler.cpp:
        (WebCore::NavigationScheduler::mustLockBackForwardList):
        (WebCore::NavigationScheduler::scheduleFormSubmission):
        * loader/ProgressTracker.cpp:
        (WebCore::ProgressTracker::progressStarted):
        (WebCore::ProgressTracker::progressCompleted):
        (WebCore::ProgressTracker::isMainLoadProgressing):
        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::selectCache):
        (WebCore::ApplicationCacheGroup::selectCacheWithoutManifestURL):
        * loader/archive/cf/LegacyWebArchive.cpp:
        (WebCore::LegacyWebArchive::create):
        * loader/cache/CachedResourceLoader.cpp:
        (WebCore::CachedResourceLoader::checkInsecureContent):
        * loader/icon/IconController.cpp:
        (WebCore::IconController::urlsForTypes):
        (WebCore::IconController::startLoader):
        * page/Chrome.cpp:
        (WebCore::canRunModalIfDuringPageDismissal):
        (WebCore::Chrome::windowScreenDidChange):
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::length):
        (WebCore::DOMWindow::name):
        (WebCore::DOMWindow::setName):
        (WebCore::DOMWindow::parent):
        (WebCore::DOMWindow::top):
        (WebCore::DOMWindow::open):
        * page/EventHandler.cpp:
        (WebCore::EventHandler::scrollRecursively):
        (WebCore::EventHandler::logicalScrollRecursively):
        (WebCore::EventHandler::handleMouseMoveEvent):
        * page/FocusController.cpp:
        (WebCore::FocusController::setContainingWindowIsVisible):
        * page/Frame.cpp:
        (WebCore::parentPageZoomFactor):
        (WebCore::parentTextZoomFactor):
        (WebCore::Frame::setPrinting):
        (WebCore::Frame::shouldUsePrintingLayout):
        (WebCore::Frame::dispatchVisibilityStateChangeEvent):
        (WebCore::Frame::willDetachPage):
        (WebCore::Frame::setPageAndTextZoomFactors):
        (WebCore::Frame::deviceOrPageScaleFactorChanged):
        (WebCore::Frame::notifyChromeClientWheelEventHandlerCountChanged):
        (WebCore::Frame::isURLAllowed):
        * page/FrameTree.cpp:
        (WebCore::FrameTree::~FrameTree):
        (WebCore::FrameTree::setName):
        (WebCore::FrameTree::transferChild):
        (WebCore::FrameTree::appendChild):
        (WebCore::FrameTree::actuallyAppendChild):
        (WebCore::FrameTree::removeChild):
        (WebCore::FrameTree::uniqueChildName):
        (WebCore::FrameTree::scopedChild):
        (WebCore::FrameTree::scopedChildCount):
        (WebCore::FrameTree::childCount):
        (WebCore::FrameTree::child):
        (WebCore::FrameTree::find):
        (WebCore::FrameTree::isDescendantOf):
        (WebCore::FrameTree::traverseNext):
        (WebCore::FrameTree::traversePreviousWithWrap):
        (WebCore::FrameTree::deepLastChild):
        (WebCore::FrameTree::top):
        (printFrames):
        (showFrameTree):
        * page/FrameView.cpp:
        (WebCore::FrameView::setFrameRect):
        (WebCore::FrameView::hasCompositedContentIncludingDescendants):
        (WebCore::FrameView::hasCompositingAncestor):
        (WebCore::FrameView::flushCompositingStateIncludingSubframes):
        (WebCore::FrameView::updateCanBlitOnScrollRecursively):
        (WebCore::FrameView::setIsOverlapped):
        (WebCore::FrameView::shouldUseLoadTimeDeferredRepaintDelay):
        (WebCore::FrameView::updateLayerFlushThrottlingInAllFrames):
        (WebCore::FrameView::serviceScriptedAnimations):
        (WebCore::FrameView::updateBackgroundRecursively):
        (WebCore::FrameView::parentFrameView):
        (WebCore::FrameView::paintContentsForSnapshot):
        (WebCore::FrameView::setTracksRepaints):
        (WebCore::FrameView::notifyWidgetsInAllFrames):
        * page/Location.cpp:
        (WebCore::Location::ancestorOrigins):
        * page/Page.cpp:
        (WebCore::networkStateChanged):
        (WebCore::Page::~Page):
        (WebCore::Page::renderTreeSize):
        (WebCore::Page::updateStyleForAllPagesAfterGlobalChangeInEnvironment):
        (WebCore::Page::setNeedsRecalcStyleInAllFrames):
        (WebCore::Page::refreshPlugins):
        (WebCore::Page::takeAnyMediaCanStartListener):
        (WebCore::incrementFrame):
        (WebCore::Page::setDefersLoading):
        (WebCore::Page::setMediaVolume):
        (WebCore::Page::setDeviceScaleFactor):
        (WebCore::Page::setShouldSuppressScrollbarAnimations):
        (WebCore::Page::didMoveOnscreen):
        (WebCore::Page::willMoveOffscreen):
        (WebCore::Page::setIsInWindow):
        (WebCore::Page::suspendScriptedAnimations):
        (WebCore::Page::resumeScriptedAnimations):
        (WebCore::Page::userStyleSheetLocationChanged):
        (WebCore::Page::allVisitedStateChanged):
        (WebCore::Page::visitedStateChanged):
        (WebCore::Page::setDebugger):
        (WebCore::Page::setMemoryCacheClientCallsEnabled):
        (WebCore::Page::setMinimumTimerInterval):
        (WebCore::Page::setTimerAlignmentInterval):
        (WebCore::Page::dnsPrefetchingStateChanged):
        (WebCore::Page::collectPluginViews):
        (WebCore::Page::storageBlockingStateChanged):
        (WebCore::Page::privateBrowsingStateChanged):
        (WebCore::Page::checkSubframeCountConsistency):
        (WebCore::Page::suspendActiveDOMObjectsAndAnimations):
        (WebCore::Page::resumeActiveDOMObjectsAndAnimations):
        (WebCore::Page::captionPreferencesChanged):
        * page/PageGroup.cpp:
        (WebCore::PageGroup::invalidateInjectedStyleSheetCacheInAllFrames):
        * page/PageGroupLoadDeferrer.cpp:
        (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
        (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
        * page/PageSerializer.cpp:
        (WebCore::PageSerializer::serializeFrame):
        * page/PageThrottler.cpp:
        (WebCore::PageThrottler::throttlePage):
        (WebCore::PageThrottler::unthrottlePage):
        * page/Settings.cpp:
        (WebCore::setImageLoadingSettings):
        (WebCore::Settings::setTextAutosizingFontScaleFactor):
        * page/SpatialNavigation.cpp:
        (WebCore::rectToAbsoluteCoordinates):
        * page/animation/AnimationController.cpp:
        (WebCore::AnimationControllerPrivate::suspendAnimations):
        (WebCore::AnimationControllerPrivate::resumeAnimations):
        * page/mac/PageMac.cpp:
        (WebCore::Page::addSchedulePair):
        (WebCore::Page::removeSchedulePair):
        * page/scrolling/ScrollingCoordinator.cpp:
        (WebCore::ScrollingCoordinator::computeNonFastScrollableRegion):
        (WebCore::ScrollingCoordinator::computeCurrentWheelEventHandlerCount):
        * plugins/PluginView.cpp:
        (WebCore::PluginView::performRequest):
        (WebCore::PluginView::load):
        * rendering/HitTestResult.cpp:
        (WebCore::HitTestResult::targetFrame):
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::enclosingCompositorFlushingLayers):
        (WebCore::RenderLayerCompositor::updateCompositingLayers):
        (WebCore::RenderLayerCompositor::notifyIFramesOfCompositingChange):
        * rendering/TextAutosizer.cpp:
        (WebCore::TextAutosizer::processSubtree):
        * storage/StorageEventDispatcher.cpp:
        (WebCore::StorageEventDispatcher::dispatchSessionStorageEvents):
        (WebCore::StorageEventDispatcher::dispatchLocalStorageEvents):
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::currentScale):
        (WebCore::SVGSVGElement::setCurrentScale):
        * testing/Internals.cpp:
        (WebCore::Internals::formControlStateOfPreviousHistoryItem):
        (WebCore::Internals::setFormControlStateOfPreviousHistoryItem):
        (WebCore::Internals::numberOfScrollableAreas):
        * xml/parser/XMLDocumentParserLibxml2.cpp:
        (WebCore::hasNoStyleInformation):
        Use tree(). instead of tree()->.

1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512
2013-08-24  Andreas Kling  <akling@apple.com>

        Merge Document::viewportSize() logic into RenderView::viewportSize().
        <https://webkit.org/b/120254>

        Reviewed by Darin Adler.

        RenderView can just ask FrameView (the viewport) about its size directly, no need for
        a weirdly-placed method on Document.

        * dom/Document.cpp:
        * rendering/RenderView.cpp:
        (WebCore::RenderView::viewportSize):
        * rendering/RenderView.h:

1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525
2013-08-24  Andreas Kling  <akling@apple.com>

        RenderObject::frame() should return a reference.
        <https://webkit.org/b/120251>

        Reviewed by Darin Adler.

        There is now always a Frame, and we can get to it by walking this path:

            RenderObject -> Document -> RenderView -> FrameView -> Frame

        Removed the customary horde of null checks.

1526 1527 1528 1529 1530 1531 1532 1533 1534
2013-08-24  Andreas Kling  <akling@apple.com>

        RenderLayer::compositor() should return a reference.
        <https://webkit.org/b/120250>

        Reviewed by Anders Carlsson.

        It was already converting from a reference to a pointer.

1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547
2013-08-24  Yoav Weiss  <yoav@yoav.ws>

        Eliminate a useless comparison in srcset's candidate selection algorithm
        https://bugs.webkit.org/show_bug.cgi?id=120235

        There is no point in comparing the last item in the candidates vector to the DPR, since it will be returned anyway. Therefore, the
        iteration on the candidates vector now skips the last candidate.

        Reviewed by Andreas Kling.

        * html/parser/HTMLParserIdioms.cpp:
        (WebCore::bestFitSourceForImageAttributes):

1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558
2013-08-24  Andreas Kling  <akling@apple.com>

        RenderObject::view() should return a reference.
        <https://webkit.org/b/120247>

        Reviewed by Antti Koivisto.

        Now that the lifetime and accessibility characteristics of RenderView are well-defined,
        we can make RenderObject::view() return a reference, exposing a plethora of unnecessary
        null checks.

1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575
2013-08-24  Joseph Pecoraro  <pecoraro@apple.com>

        Web Inspector: Cleanup Inspector Agents a bit
        https://bugs.webkit.org/show_bug.cgi?id=120218

        Reviewed by Andreas Kling.

        Merge https://chromium.googlesource.com/chromium/blink/+/8693dcb8ba42a5c225f516c664fb0f453c8ba6f0.

        * inspector/InspectorCSSAgent.cpp:
        (WebCore::InspectorCSSAgent::elementForId):
        * inspector/InspectorStyleSheet.cpp:
        (ParsedStyleSheet::ParsedStyleSheet):
        (WebCore::InspectorStyle::setPropertyText):
        (WebCore::InspectorStyle::populateAllProperties):
        (WebCore::InspectorStyleSheet::inlineStyleSheetText):

1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595
2013-08-24  Andreas Kling  <akling@apple.com>

        Let Document keep its RenderView during render tree detach.
        <https://webkit.org/b/120233>

        Reviewed by Antti Koivisto.

        Instead of having "Document::renderer() == NULL" signify that the render tree is being
        torn down, give Document an explicit flag for this instead.

        This way, we can keep Document's RenderView in place during tree detach.

        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::detach):
        * dom/Document.h:
        (WebCore::Document::renderTreeBeingDestroyed):
        * rendering/RenderObject.h:
        (WebCore::RenderObject::documentBeingDestroyed):

1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656
2013-08-24  Antti Koivisto  <antti@apple.com>

        Tighten before/after pseudo element accessors
        https://bugs.webkit.org/show_bug.cgi?id=120204

        Reviewed by Andreas Kling.

        We have generic looking Element::pseudoElement(PseudoID) which only returns before/after pseudo elements.
        
        Switch to Element::before/afterPseudoElement(), similarly for setters.

        * WebCore.exp.in:
        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::ComputedStyleExtractor::styledNode):
        * dom/Element.cpp:
        (WebCore::Element::~Element):
        (WebCore::beforeOrAfterPseudeoElement):
        (WebCore::Element::computedStyle):
        (WebCore::Element::updatePseudoElement):
        (WebCore::Element::createPseudoElementIfNeeded):
        (WebCore::Element::updateBeforePseudoElement):
        (WebCore::Element::updateAfterPseudoElement):
        (WebCore::Element::beforePseudoElement):
        (WebCore::Element::afterPseudoElement):
        (WebCore::Element::setBeforePseudoElement):
        (WebCore::Element::setAfterPseudoElement):
        (WebCore::disconnectPseudoElement):
        (WebCore::Element::clearBeforePseudoElement):
        (WebCore::Element::clearAfterPseudoElement):
        (WebCore::Element::clearStyleDerivedDataBeforeDetachingRenderer):
        * dom/Element.h:
        * dom/ElementRareData.h:
        (WebCore::ElementRareData::beforePseudoElement):
        (WebCore::ElementRareData::afterPseudoElement):
        (WebCore::ElementRareData::hasPseudoElements):
        (WebCore::ElementRareData::~ElementRareData):
        (WebCore::ElementRareData::clearBeforePseudoElement):
        (WebCore::ElementRareData::clearAfterPseudoElement):
        (WebCore::ElementRareData::setBeforePseudoElement):
        (WebCore::ElementRareData::setAfterPseudoElement):
        
            Move detach logic to Element. ElementRareData should not implement semantics.

        * dom/Node.cpp:
        (WebCore::Node::pseudoAwarePreviousSibling):
        (WebCore::Node::pseudoAwareNextSibling):
        (WebCore::Node::pseudoAwareFirstChild):
        (WebCore::Node::pseudoAwareLastChild):
        * dom/NodeRenderingTraversal.cpp:
        (WebCore::NodeRenderingTraversal::nextSiblingSlow):
        (WebCore::NodeRenderingTraversal::previousSiblingSlow):
        * rendering/RenderTreeAsText.cpp:
        (WebCore::writeCounterValuesFromChildren):
        (WebCore::counterValueForElement):
        * style/StyleResolveTree.cpp:
        (WebCore::Style::attachRenderTree):
        (WebCore::Style::resolveTree):
        * testing/Internals.cpp:
        (WebCore::Internals::pauseAnimationAtTimeOnPseudoElement):
        (WebCore::Internals::pauseTransitionAtTimeOnPseudoElement):

1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687
2013-08-23  Simon Fraser  <simon.fraser@apple.com>

        Improve scrolling behavior in iTunes
        https://bugs.webkit.org/show_bug.cgi?id=120241
        <rdar://problem/14825344>

        Reviewed by Sam Weinig.

        When vertically scrolling a page with horizontally scrollable overflow areas,
        vertical scroll gestures would be interrupted when wheel events with non-zero
        X deltas were intercepted by the overflow areas.
        
        Fix by storing a small history of wheel events deltas and using
        it to determine of the scroll gesture is primarily vertical or horizontal.
        When this is detected, avoid dispatching scroll events on the on the
        non-dominant axis.
        
        Currently this behavior is conditionalized to only apply in iTunes.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::EventHandler):
        (WebCore::EventHandler::recordWheelEventDelta):
        (WebCore::deltaIsPredominantlyVertical):
        (WebCore::EventHandler::dominantScrollGestureDirection):
        (WebCore::EventHandler::handleWheelEvent):
        (WebCore::EventHandler::defaultWheelEventHandler):
        * page/EventHandler.h:
        * platform/RuntimeApplicationChecks.cpp:
        (WebCore::applicationIsITunes):
        * platform/RuntimeApplicationChecks.h:

1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705
2013-08-23  Pratik Solanki  <psolanki@apple.com>

        MediaQuery::expressions() should return a reference
        <https://webkit.org/b/120215>

        Reviewed by Anders Carlsson.

        m_expressions is never NULL so we can just return a reference.

        * css/MediaList.cpp:
        (WebCore::reportMediaQueryWarningIfNeeded):
        * css/MediaQuery.cpp:
        (WebCore::MediaQuery::MediaQuery):
        * css/MediaQuery.h:
        (WebCore::MediaQuery::expressions):
        * css/MediaQueryEvaluator.cpp:
        (WebCore::MediaQueryEvaluator::eval):

rniwa@webkit.org's avatar
rniwa@webkit.org committed
1706 1707 1708 1709 1710 1711 1712 1713
2013-08-23  Ryosuke Niwa  <rniwa@webkit.org>

        Build fix after r154515.

        * dom/ElementTraversal.h:
        (WebCore::Traversal<ElementType>::firstChild):
        (WebCore::Traversal<ElementType>::lastChild):

1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729
2013-08-23  Andreas Kling  <akling@apple.com>

        Simplify some Settings access where we have a Frame in reach.
        <http://webkit.org/b/120239>

        Reviewed by Anders Carlsson.

        In three cases where we can grab at a Frame, we can reach all the way to some Settings
        without having to use pointers.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::didBeginDocument):
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::addToOverlapMap):
        (WebCore::RenderLayerCompositor::requiresCompositingForPosition):

1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744
2013-08-23  Jer Noble  <jer.noble@apple.com>

        REGRESSION (r150516): Media controls are messed up on right-to-left webpages
        https://bugs.webkit.org/show_bug.cgi?id=120234

        Reviewed by Dan Bernstein.

        Test: media/video-rtl.html

        Make the media control panel explicitly direction:ltr. The captions menu and captions
        display are unaffected, so rtl content will continue to appear rtl there.

        * css/mediaControls.css:
        (audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):

1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764
2013-08-23  Beth Dakin  <bdakin@apple.com>

        REGRESSION (r132545): Some PDFs generated by WebKit are blank when viewed in 
        Adobe Reader
        https://bugs.webkit.org/show_bug.cgi?id=120240
        -and corresponding-
        <rdar://problem/14634453>

        Reviewed by Anders Carlsson.

        This patch makes it so that we don’t use the infinite rect for the PDF context, 
        and it adds WebCoreSystemInterface API to find out if the current content is the 
        PDF context. 

        * WebCore.exp.in:
        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::clipOut):
        * platform/mac/WebCoreSystemInterface.h:
        * platform/mac/WebCoreSystemInterface.mm:

1765
2013-08-23  Eric Carlson  <eric.carlson@apple.com>
1766

1767 1768
        [Mac] some track language tags are not recognized
        https://bugs.webkit.org/show_bug.cgi?id=119643
1769

1770
        Reviewed by Jere Noble.
1771

1772
        No new tests, existing tests updated.
1773 1774

        * html/HTMLMediaElement.cpp:
1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802
        (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_captionDisplayMode from settings
            if possible.
        (WebCore::HTMLMediaElement::configureTextTrackGroup): Don't enable a default track when preferences
            say captions should be disabled. Don't disable an already visible track if we don't find
            a match unless preferences say captions should be disabled. m_forcedOrAutomaticSubtitleTrackLanguage ->
            m_subtitleTrackLanguage.
        (WebCore::HTMLMediaElement::mediaPlayerCharacteristicChanged): If the language of the primary
            audio track changes, only kick off a text track recalc if caption preference are set to "automatic".
        * html/HTMLMediaElement.h:

        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
        (WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation): Initialize m_characteristicsChanged
            and m_delayCharacteristicsChangedNotification.
        (WebCore::MediaPlayerPrivateAVFoundation::setHasVideo): Call characteristicsChanged.
        (WebCore::MediaPlayerPrivateAVFoundation::setHasAudio): Ditto.
        (WebCore::MediaPlayerPrivateAVFoundation::setHasClosedCaptions): Ditto.
        (WebCore::MediaPlayerPrivateAVFoundation::characteristicsChanged): New, allows us to coalesce 
            calls to the media player when we know several characteristics may change.
        (WebCore::MediaPlayerPrivateAVFoundation::setDelayCharacteristicsChangedNotification): Enable or
            disable notification delay.
        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

        * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
        (WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Always call languageOfPrimaryAudioTrack(),
            a track may have changed so we may have a new language.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack): Call [AVAssetTrack languageCode]
            if [AVAssetTrack extendedLanguageTag] returns NULL in case the media file has an old
            QuickTime language code.
1803

1804 1805 1806 1807 1808 1809 1810 1811 1812
2013-08-23  Andreas Kling  <akling@apple.com>

        RenderView::compositor() should return a reference.
        <https://webkit.org/b/120217>

        Reviewed by Beth Dakin.

        The RenderLayerCompositor is lazily constructed by compositor() and never returns null.

1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833
2013-08-23  Yoav Weiss  <yoav@yoav.ws>

        Fix srcset's image candidate algorithm when DPR exceeds all candidates
        https://bugs.webkit.org/show_bug.cgi?id=120168

        When the DPR exceeded the 'x' qualifier of all image candidates, none was chosen.

        From the srcset spec: "If there are any entries in candidates that have an associated pixel density that is less than a
        user-agent-defined value giving the nominal pixel density of the display, then remove them, unless that would remove all the
        entries, in which case remove only the entries whose associated pixel density is less than the greatest such pixel density."

        Fixed by returning the last one in the list of candidates sorted by their qualifier, in case none of them is equal or greater than
        DPR.
        
        Reviewed by Andreas Kling.

        Test: fast/hidpi/image-srcset-fraction.html

        * html/parser/HTMLParserIdioms.cpp:
        (WebCore::bestFitSourceForImageAttributes):

1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846
2013-08-23  Chris Fleizach  <cfleizach@apple.com>

        <https://webkit.org/b/113895> Webkit exposes aria-expanded="undefined" as aria-expanded="false" (AXExpanded = NO)

        Reviewed by Darin Adler.

        Don't support the ARIA expanded attribute unless the value is one of the defined ARIA values (true/false).

        Test: platform/mac/accessibility/aria-expanded-not-exposed-when-undefined.html

        * accessibility/AccessibilityObject.cpp:
        (WebCore::AccessibilityObject::supportsARIAExpanded):

1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868
2013-08-17  Darin Adler  <darin@apple.com>

        <https://webkit.org/b/119945> Some cleanup for PasteboardIOS

        Reviewed by Andreas Kling.

        * platform/ios/PasteboardIOS.mm:
        (WebCore::Pasteboard::setFrame): Moved this function up near the
        create functions and constructors.
        (WebCore::documentFragmentWithRTF): Tweaked formatting.
        (WebCore::Pasteboard::documentFragmentForPasteboardItemAtIndex):
        Ditto.
        (WebCore::utiTypeFromCocoaType): Changed to use early return and removed
        an unneeded local variable.
        (WebCore::cocoaTypeFromHTMLClipboardType): Renamed the quaint qType and
        pbType local variables, and tweaked formatting.
        (WebCore::Pasteboard::clear): Tweaked comment.
        (WebCore::Pasteboard::readString): Tweaked formatting.
        (WebCore::addHTMLClipboardTypesForCocoaType): Tweaked formatting.
        (WebCore::Pasteboard::writeString): Streamlined logic and tweaked formatting
        (WebCore::Pasteboard::types): Renamed pbType to just type.

1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915
2013-08-23  Bem Jones-Bey  <bjonesbe@adobe.com>

        Attempt to make it more clear what FloatIntervalSearchAdaptor::collectIfNeeded is doing
        https://bugs.webkit.org/show_bug.cgi?id=119816

        Reviewed by David Hyatt.

        This is a port from Blink of
        https://src.chromium.org/viewvc/blink?revision=155885&view=revision
        Original Patch by Eric Seidel

        Original comments:

        "It seemed to me that template specifications would be clearer than an
        if.  They also allow for compile-time error checking were a 3rd type
        of float to come into existance in CSS4. :p

        For any unfamiliar with this method, this the object used for
        performing a search on a RedBlackTree in WTF.

        We create one of these adaptors, specifying that we want to search for
        values in a specific (logical) Y interval, and this adaptor is called
        back for any values in the RBTree cooresponding to that interval
        range.

        The job of this adaptor is to collect the various values we care
        about, including the left or right-most offset of the floats in that
        Y-range as well as what the last (document order) float seen in that
        range.

        It also collects the remaining available height for the block but I'm
        less clear on how that parameter is used."

        Note that in addition to the original change, I have made the
        updateOffsetIfNeeded and rangesIntersect methods inline, as this was
        shown to be a performance win in
        https://src.chromium.org/viewvc/blink?revision=156064&view=revision
        and it seemed a rather trivial change to be subject to a separate
        patch when porting.

        No new tests, no behavior change.

        * rendering/RenderBlock.cpp:
        (WebCore::::updateOffsetIfNeeded):
        (WebCore::::collectIfNeeded):
        * rendering/RenderBlock.h:

1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934 1935
2013-08-23  David Kilzer  <ddkilzer@apple.com>

        WebCore fails to link due to changes in Objective-C++ ABI in trunk clang
        <http://webkit.org/b/120183>
        <rdar://problem/14764114>

        Reviewed by Eric Carlson.

        The trunk version of clang made an ABI change for Objective-C++
        parameters that caused WebCore to fail to link.  The short-term
        fix is to change the parameter type from id<protocol> to just id
        and add an ASSERT that the parameter still conforms to the
        protocol.

        * platform/DragData.h:
        (DragDataRef): Change typedef from id<NSDragInfo> to id.
        * platform/mac/DragDataMac.mm:
        (WebCore::DragData::DragData): Add ASSERT that checks that the
        DragDataRef object implements the NSDragInfo protocol.

1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952
2013-08-23  Andreas Kling  <akling@apple.com>

        RenderLayerCompositor::m_renderView should be a reference.
        <https://webkit.org/b/120210>

        Reviewed by Antti Koivisto.

        The RenderLayerCompositor is always created by a RenderView passing itself to the constructor.
        By making m_renderView a reference, we flush out some unnecessary null checks.
        We also gain a pointer-free path to Settings through m_renderView.frameView().frame().settings()
        so we don't have to make those blocks conditional anymore, reducing ambiguity.

        * rendering/RenderLayerCompositor.cpp:
        * rendering/RenderLayerCompositor.h:
        * rendering/RenderView.cpp:
        (WebCore::RenderView::compositor):

1953 1954 1955 1956 1957 1958 1959 1960 1961 1962
2013-08-23  Andreas Kling  <akling@apple.com>

        RenderView::frameView() should return a reference.
        <https://webkit.org/b/120208>

        Reviewed by Antti Koivisto.

        A RenderView should always have a corresponding FrameView, so make frameView()
        return a reference. Also remove a myriad of now-impossible null checks.

1963 1964 1965 1966 1967 1968 1969 1970 1971 1972
2013-08-23  Allan Sandfeld Jensen  <allan.jensen@digia.com>

        REGRESSION(r153939) Fix typo in Qt build-files

        Reviewed by Antti Koivisto.

        Fix simple typo in Target.pri introduced in r153939.

        * Target.pri:

1973 1974 1975 1976 1977 1978 1979 1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990 1991 1992 1993 1994 1995 1996 1997 1998 1999 2000 2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 2017 2018 2019 2020 2021 2022 2023 2024 2025 2026 2027 2028 2029 2030 2031 2032 2033 2034 2035 2036 2037 2038 2039 2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 2051 2052 2053 2054 2055 2056 2057 2058 2059 2060 2061 2062 2063 2064 2065 2066 2067 2068 2069 2070 2071 2072 2073 2074 2075 2076 2077 2078 2079 2080 2081 2082 2083 2084 2085 2086 2087 2088 2089 2090 2091 2092 2093 2094 2095 2096 2097 2098 2099 2100 2101
2013-08-23  Antti Koivisto  <antti@apple.com>

        <https://webkit.org/b/120166> Add Traversal<ElementType> template

        Reviewed by Andreas Kling.

        It is common to traverse through a subtree looking for elements of specific type and then casting to the type. This pattern can be generalized.
        
        This patch adds a new Traversal<typename ElementType> template. It works like ElementTraversal except that the traversal is limited to the specified type.
        The patch also uses the template in a bunch of applicable places.

        * WebCore.exp.in:
        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::addImageMapChildren):
        * dom/Document.cpp:
        (WebCore::Document::removeTitle):
        (WebCore::Document::updateBaseURL):
        (WebCore::Document::processBaseElement):
        * dom/Element.h:
        * dom/ElementTraversal.h:
        (WebCore::::firstChildTemplate):
        (WebCore::::firstWithinTemplate):
        (WebCore::::lastChildTemplate):
        (WebCore::::lastWithinTemplate):
        (WebCore::::nextTemplate):
        (WebCore::::previousTemplate):
        (WebCore::::nextSiblingTemplate):
        (WebCore::::previousSiblingTemplate):
        (WebCore::::nextSkippingChildrenTemplate):
        (WebCore::::firstChild):
        (WebCore::::lastChild):
        (WebCore::::firstWithin):
        (WebCore::::lastWithin):
        (WebCore::::next):
        (WebCore::::previous):
        (WebCore::::nextSibling):
        (WebCore::::previousSibling):
        (WebCore::::nextSkippingChildren):
        (WebCore::ElementTraversal::previousIncludingPseudo):
        (WebCore::ElementTraversal::nextIncludingPseudo):
        (WebCore::ElementTraversal::nextIncludingPseudoSkippingChildren):
        (WebCore::ElementTraversal::pseudoAwarePreviousSibling):
        * dom/Node.cpp:
        (WebCore::Node::numberOfScopedHTMLStyleChildren):
        * dom/NodeIterator.cpp:
        (WebCore::NodeIterator::NodeIterator):
        * dom/NodeIterator.h:
        * dom/Traversal.cpp:
        (WebCore::NodeIteratorBase::NodeIteratorBase):
        (WebCore::NodeIteratorBase::acceptNode):
        * dom/Traversal.h:
        
            Renamed existing class called Traversal to less generic NodeIteratorBase.

        * dom/TreeScope.cpp:
        (WebCore::TreeScope::labelElementForId):
        (WebCore::TreeScope::findAnchor):
        * dom/TreeWalker.cpp:
        (WebCore::TreeWalker::TreeWalker):
        * dom/TreeWalker.h:
        * editing/FrameSelection.cpp:
        (WebCore::scanForForm):
        * editing/markup.cpp:
        (WebCore::createContextualFragment):
        * html/HTMLAnchorElement.h:
        (WebCore::isHTMLAnchorElement):
        (WebCore::HTMLAnchorElement):
        * html/HTMLAreaElement.h:
        (WebCore::isHTMLAreaElement):
        (WebCore::HTMLAreaElement):
        * html/HTMLBaseElement.h:
        (WebCore::isHTMLBaseElement):
        (WebCore::HTMLBaseElement):
        * html/HTMLElement.h:
        (WebCore::HTMLElement):
        * html/HTMLFieldSetElement.cpp:
        (WebCore::HTMLFieldSetElement::invalidateDisabledStateUnder):
        (WebCore::HTMLFieldSetElement::childrenChanged):
        (WebCore::HTMLFieldSetElement::legend):
        * html/HTMLFormControlElement.h:
        (WebCore::toHTMLFormControlElement):
        (WebCore::HTMLFormControlElement):
        * html/HTMLLabelElement.cpp:
        (WebCore::nodeAsSupportedLabelableElement):
        (WebCore::HTMLLabelElement::control):
        * html/HTMLLabelElement.h:
        (WebCore::isHTMLLabelElement):
        (WebCore::HTMLLabelElement):
        * html/HTMLLegendElement.h:
        (WebCore::isHTMLLegendElement):
        (WebCore::HTMLLegendElement):
        * html/HTMLMapElement.cpp:
        (WebCore::HTMLMapElement::mapMouseEvent):
        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::finishParsingChildren):
        * html/HTMLStyleElement.h:
        (WebCore::isHTMLStyleElement):
        (WebCore::HTMLStyleElement):
        * html/HTMLTitleElement.h:
        (WebCore::HTMLTitleElement):
        * html/HTMLTrackElement.h:
        (WebCore::isHTMLTrackElement):
        (WebCore::HTMLTrackElement):
        * html/LabelableElement.h:
        (WebCore::isLabelableElement):
        (WebCore::LabelableElement):
        * rendering/FilterEffectRenderer.cpp:
        (WebCore::FilterEffectRenderer::buildReferenceFilter):
        * svg/SVGElement.h:
        (WebCore::SVGElement):
        * svg/SVGForeignObjectElement.h:
        (WebCore::isSVGForeignObjectElement):
        (WebCore::SVGForeignObjectElement):
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::collectIntersectionOrEnclosureList):
        (WebCore::SVGSVGElement::getElementById):
        * svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::title):
        * svg/SVGTitleElement.h:
        (WebCore::SVGTitleElement):
        * svg/animation/SMILTimeContainer.cpp:
        (WebCore::SMILTimeContainer::updateDocumentOrderIndexes):
        * svg/animation/SVGSMILElement.cpp:
        (WebCore::SVGSMILElement::isSMILElement):
        * svg/animation/SVGSMILElement.h:
        (WebCore::SVGSMILElement):
        * svg/graphics/SVGImage.cpp:
        (WebCore::SVGImage::hasSingleSecurityOrigin):

2102 2103 2104 2105 2106 2107 2108 2109 2110 2111 2112 2113 2114 2115 2116 2117 2118 2119 2120 2121 2122 2123 2124 2125 2126 2127 2128 2129 2130 2131 2132
2013-08-23  Arpita Bahuguna  <a.bah@samsung.com>

        <br> does not get deleted when inlined after some non-textual content.
        https://bugs.webkit.org/show_bug.cgi?id=120006

        Reviewed by Ryosuke Niwa.

        deleteSelectionCommand does not handle the case when a <br> element is
        inlined after some non-textual content (input controls, image etc.).

        When doing a back-delete at the start of a line following such a <br>
        the two contiguous lines should merge and the <br> should get deleted.
        Currently, even though the <br> is deleted, another placeholder <br>
        is incorrectly inserted at the same point, thus effectively there is no
        change.

        We are incorrectly computing the inline <br> to be at the start of an
        empty line even though the line is not empty.

        Test: editing/deleting/delete-inline-br.html

        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::handleSpecialCaseBRDelete):
        Adding a check to verify that the inline <br> is not on an empty line
        if the end node is not a <br> element itself and it's previous sibling
        is the start <br> element.

        Basically we check whether there is another node (end node) following
        the <br>, that the node is not a <br> itself, and that the end node's
        previous node is the start <br>.

2133 2134 2135 2136 2137 2138 2139 2140 2141 2142 2143 2144 2145 2146 2147
2013-08-23  Renata Hodovan  <reni@webkit.org>

        Missing null-check in HTMLFormElement::rendererIsNeeded()
        https://bugs.webkit.org/show_bug.cgi?id=120159

        Reviewed by Ryosuke Niwa.

        Null-check parentRenderer in HTMLFormElement::rendererIsNeeded()
        and early return.

        Test: fast/forms/missing-parentrenderer-crash.html

        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::rendererIsNeeded):

2148 2149 2150 2151 2152 2153 2154 2155 2156 2157 2158 2159 2160 2161 2162 2163 2164 2165 2166
2013-08-23  Zalan Bujtas  <zalan@apple.com>

        MathML: ASSERTION FAILED: !isPreferredLogicalHeightDirty() in RenderMathMLBlock::preferredLogicalHeight() const
        https://bugs.webkit.org/show_bug.cgi?id=120157

        Reviewed by Antti Koivisto.

        RenderListMarker needs to be inserted to the render tree before
        we start computing the preferred logical widths for the associated
        RenderListItem.

        Test: mathml/mn-as-list-item-assert.html

        * rendering/RenderListItem.cpp:
        (WebCore::RenderListItem::insertOrMoveMarkerRendererIfNeeded):
        (WebCore::RenderListItem::layout):
        (WebCore::RenderListItem::computePreferredLogicalWidths):
        * rendering/RenderListItem.h:

2167 2168 2169 2170 2171 2172 2173 2174 2175 2176 2177 2178 2179 2180 2181 2182 2183 2184 2185
2013-08-22  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Introduce toSVGLinearGradientElement(), and use it
        https://bugs.webkit.org/show_bug.cgi?id=120154

        Reviewed by Andreas Kling.

        As a step to clean-up static_cast<SVGXXX>, toSVGLinearGradientElement() is added to clean-up
        static_cast<SVGLinearGradientElement*>.

        * rendering/svg/RenderSVGResourceLinearGradient.cpp:
        (WebCore::RenderSVGResourceLinearGradient::collectGradientAttributes):
        * rendering/svg/SVGRenderTreeAsText.cpp:
        (WebCore::writeSVGResourceContainer):
        * svg/SVGLinearGradientElement.cpp:
        (WebCore::SVGLinearGradientElement::collectGradientAttributes):
        * svg/SVGLinearGradientElement.h:
        (WebCore::toSVGLinearGradientElement):

2186 2187 2188 2189 2190 2191 2192 2193 2194 2195 2196 2197 2198 2199 2200 2201 2202 2203 2204 2205 2206 2207 2208 2209 2210 2211 2212 2213 2214 2215 2216 2217 2218 2219 2220 2221 2222 2223 2224 2225
2013-08-22  Simon Fraser  <simon.fraser@apple.com>

        compositing/geometry/bounds-ignores-hidden-dynamic.html has incorrect initial rendering
        https://bugs.webkit.org/show_bug.cgi?id=119825

        Reviewed by Tim Horton.
        
        r137526 and some earlier commits attempted to avoid unconditionally
        repainting layers when their size changes, because this was causing
        TiledBacking layers to repaint when the document size changed.
        
        However, the approach required that we have good information about
        whether size changes require a repaint, which in some cases is hard
        to determine, especially when RenderLayer changes affect our
        decisions about which layers are composited.
        
        Fix by pushing the decision about whether to repaint on size change
        into GraphicsLayer. The default is to repaint on size change,
        but GraphicsLayer provides a function that can be overridden to
        modify this behavior; GraphicsLayerCA does so to avoid repaints
        when layers with TiledBackings get resized.

        Test: compositing/repaint/repaint-on-layer-grouping-change.html

        * WebCore.exp.in: WebKit2 needs GraphicsLayer::setSize, which is no longer inline.
        * platform/graphics/GraphicsLayer.cpp:
        (WebCore::GraphicsLayer::setOffsetFromRenderer):
        (WebCore::GraphicsLayer::setSize):
        * platform/graphics/GraphicsLayer.h:
        (WebCore::GraphicsLayer::shouldRepaintOnSizeChange):
        * platform/graphics/ca/GraphicsLayerCA.cpp:
        (WebCore::GraphicsLayerCA::shouldRepaintOnSizeChange):
        * platform/graphics/ca/GraphicsLayerCA.h:
        * rendering/RenderLayerBacking.h: No longer need m_boundsConstrainedByClipping
        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::RenderLayerBacking):
        (WebCore::RenderLayerBacking::updateCompositedBounds):
        (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): setSize takes
        care of repainting for us now, so we can remove all the conditional code.

2226 2227 2228 2229 2230 2231 2232 2233 2234 2235 2236 2237 2238 2239 2240 2241 2242 2243 2244
2013-08-22  Simon Fraser  <simon.fraser@apple.com>

        Repaint counters are sometimes not in the corner of the compositing layer
        https://bugs.webkit.org/show_bug.cgi?id=120176

        Reviewed by Beth Dakin.

        Sometimes the repaint counters are not in the corner of the compositing layer;
        they are either inset, or partially or entirely outside the layer.
        
        Fix by making sure that we restore the CGContext before drawing
        the counter, since the WebCore code may have translated the CTM.
        
        The counter-painting code saves and restores the context itself,
        so this is safe.

        * platform/graphics/mac/WebLayer.mm:
        (drawLayerContents):

2245 2246 2247 2248 2249 2250 2251 2252 2253 2254 2255 2256 2257
2013-08-22  Tim Horton  <timothy_horton@apple.com>

        Unavailable plug-in indicator text is one pixel too low
        https://bugs.webkit.org/show_bug.cgi?id=120177
        <rdar://problem/14811951>

        Reviewed by Kevin Decker.

        Move the unavailable plug-in indicator text up one pixel.

        * rendering/RenderEmbeddedObject.cpp:
        (WebCore::RenderEmbeddedObject::paintReplaced):

2258 2259 2260 2261 2262 2263 2264 2265 2266 2267 2268 2269 2270 2271 2272 2273 2274 2275 2276 2277 2278 2279 2280 2281 2282 2283 2284 2285 2286 2287 2288 2289 2290 2291 2292 2293 2294 2295 2296 2297 2298 2299 2300 2301 2302 2303 2304 2305 2306 2307 2308 2309 2310 2311 2312 2313 2314 2315 2316 2317 2318 2319 2320 2321 2322 2323 2324 2325 2326 2327 2328 2329 2330 2331 2332 2333 2334 2335 2336 2337 2338 2339 2340 2341 2342 2343 2344 2345 2346 2347 2348 2349 2350 2351 2352 2353 2354 2355 2356 2357 2358 2359 2360 2361 2362 2363 2364 2365 2366 2367 2368 2369 2370 2371 2372 2373 2374 2375 2376 2377 2378 2379 2380 2381 2382 2383 2384 2385 2386 2387 2388 2389 2390 2391 2392 2393 2394 2395 2396 2397 2398 2399 2400 2401 2402 2403 2404 2405 2406 2407 2408 2409 2410 2411 2412 2413 2414 2415 2416 2417 2418 2419 2420 2421 2422 2423 2424 2425 2426 2427 2428 2429 2430 2431 2432 2433 2434 2435 2436 2437 2438 2439 2440 2441 2442 2443 2444 2445 2446 2447 2448 2449 2450 2451 2452 2453 2454 2455 2456 2457 2458 2459 2460 2461 2462 2463 2464 2465 2466 2467 2468 2469 2470 2471 2472 2473 2474 2475 2476 2477 2478 2479 2480 2481 2482 2483 2484 2485 2486 2487 2488 2489 2490 2491 2492 2493 2494 2495 2496 2497 2498 2499 2500 2501 2502 2503 2504 2505 2506 2507 2508 2509 2510 2511 2512 2513 2514 2515
2013-08-22  Christophe Dumez  <ch.dumez@sisa.samsung.com>

        [SVG2] Merge SVGStyledElement and SVGElement
        https://bugs.webkit.org/show_bug.cgi?id=107386

        Reviewed by Andreas Kling.

        Merge SVGStyledElement into SVGElement to simplify the SVG inheritance
        model and match the SVG2 specification:
        https://svgwg.org/svg2-draft/single-page.html#types-InterfaceSVGElement

        Test: svg/dom/svg2-inheritance.html

        * CMakeLists.txt:
        * DerivedSources.cpp:
        * DerivedSources.make:
        * DerivedSources.pri:
        * GNUmakefile.list.am:
        * Target.pri:
        * WebCore.order:
        * WebCore.vcxproj/WebCore.vcxproj:
        * WebCore.vcxproj/WebCore.vcxproj.filters:
        * WebCore.xcodeproj/project.pbxproj:
        * accessibility/AccessibilityNodeObject.cpp:
        (WebCore::AccessibilityNodeObject::alternativeText):
        (WebCore::AccessibilityNodeObject::accessibilityDescription):
        * css/SVGCSSStyleSelector.cpp:
        * rendering/style/SVGRenderStyle.cpp:
        * rendering/svg/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::RenderSVGContainer):
        * rendering/svg/RenderSVGContainer.h:
        * rendering/svg/RenderSVGHiddenContainer.cpp:
        (WebCore::RenderSVGHiddenContainer::RenderSVGHiddenContainer):
        * rendering/svg/RenderSVGHiddenContainer.h:
        * rendering/svg/RenderSVGModelObject.cpp:
        (WebCore::RenderSVGModelObject::RenderSVGModelObject):
        (WebCore::getElementCTM):
        * rendering/svg/RenderSVGModelObject.h:
        * rendering/svg/RenderSVGResourceClipper.cpp:
        (WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage):
        (WebCore::RenderSVGResourceClipper::calculateClipContentRepaintRect):
        (WebCore::RenderSVGResourceClipper::hitTestClipContent):
        * rendering/svg/RenderSVGResourceContainer.cpp:
        (WebCore::RenderSVGResourceContainer::RenderSVGResourceContainer):
        * rendering/svg/RenderSVGResourceContainer.h:
        * rendering/svg/RenderSVGResourceFilter.cpp:
        * rendering/svg/RenderSVGResourceFilterPrimitive.h:
        * rendering/svg/RenderSVGResourceMarker.cpp:
        * rendering/svg/RenderSVGResourceMarker.h:
        * rendering/svg/RenderSVGResourceMasker.cpp:
        (WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):
        (WebCore::RenderSVGResourceMasker::calculateMaskContentRepaintRect):
        * rendering/svg/RenderSVGResourcePattern.cpp:
        (WebCore::RenderSVGResourcePattern::createTileImage):
        * rendering/svg/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::RenderSVGRoot):
        * rendering/svg/RenderSVGRoot.h:
        * rendering/svg/RenderSVGViewportContainer.cpp:
        (WebCore::RenderSVGViewportContainer::RenderSVGViewportContainer):
        * rendering/svg/RenderSVGViewportContainer.h:
        * rendering/svg/SVGRenderSupport.cpp:
        (WebCore::SVGRenderSupport::layoutChildren):
        * rendering/svg/SVGRenderTreeAsText.cpp:
        * rendering/svg/SVGResources.cpp:
        (WebCore::registerPendingResource):
        * rendering/svg/SVGResourcesCache.cpp:
        * svg/SVGAElement.cpp:
        (WebCore::SVGAElement::title):
        * svg/SVGAllInOne.cpp:
        * svg/SVGAltGlyphDefElement.h:
        * svg/SVGAltGlyphItemElement.h:
        * svg/SVGAnimateElement.cpp:
        * svg/SVGAnimatedType.cpp:
        (WebCore::SVGAnimatedType::valueAsString):
        (WebCore::SVGAnimatedType::setValueAsString):
        * svg/SVGAnimationElement.cpp:
        (WebCore::SVGAnimationElement::isTargetAttributeCSSProperty):
        (WebCore::SVGAnimationElement::computeCSSPropertyValue):
        (WebCore::SVGAnimationElement::adjustForInheritance):
        (WebCore::inheritsFromProperty):
        * svg/SVGComponentTransferFunctionElement.h:
        * svg/SVGCursorElement.h:
        * svg/SVGDescElement.cpp:
        (WebCore::SVGDescElement::SVGDescElement):
        * svg/SVGDescElement.h:
        * svg/SVGDescElement.idl:
        * svg/SVGElement.cpp:
        (WebCore::mapAttributeToCSSProperty):
        (WebCore::cssPropertyToTypeMap):
        (WebCore::SVGElement::SVGElement):
        (WebCore::SVGElement::~SVGElement):
        (WebCore::SVGElement::removedFrom):
        (WebCore::SVGElement::parseAttribute):
        (WebCore::SVGElement::animatedPropertyTypeForAttribute):
        (WebCore::collectInstancesForSVGElement):
        (WebCore::SVGElement::isAnimatableAttribute):
        (WebCore::SVGElement::title):
        (WebCore::SVGElement::rendererIsNeeded):
        (WebCore::SVGElement::cssPropertyIdForSVGAttributeName):
        (WebCore::SVGElement::isAnimatableCSSProperty):
        (WebCore::SVGElement::isPresentationAttribute):
        (WebCore::SVGElement::collectStyleForPresentationAttribute):
        (WebCore::SVGElement::isKnownAttribute):
        (WebCore::SVGElement::svgAttributeChanged):
        (WebCore::SVGElement::insertedInto):
        (WebCore::SVGElement::buildPendingResourcesIfNeeded):
        (WebCore::SVGElement::childrenChanged):
        (WebCore::SVGElement::getPresentationAttribute):
        (WebCore::SVGElement::instanceUpdatesBlocked):
        (WebCore::SVGElement::setInstanceUpdatesBlocked):
        (WebCore::SVGElement::localCoordinateSpaceTransform):
        (WebCore::SVGElement::updateRelativeLengthsInformation):
        (WebCore::SVGElement::isMouseFocusable):
        (WebCore::SVGElement::isKeyboardFocusable):
        * svg/SVGElement.h:
        (WebCore::SVGElement::supportsMarkers):
        (WebCore::SVGElement::hasRelativeLengths):
        (WebCore::SVGElement::needsPendingResourceHandling):
        (WebCore::SVGElement::selfHasRelativeLengths):
        (WebCore::SVGElement::updateRelativeLengthsInformation):
        * svg/SVGElement.idl:
        * svg/SVGElementInstance.cpp:
        (WebCore::SVGElementInstance::invalidateAllInstancesOfElement):
        (WebCore::SVGElementInstance::InstanceUpdateBlocker::InstanceUpdateBlocker):
        * svg/SVGElementInstance.h:
        * svg/SVGFEBlendElement.idl:
        * svg/SVGFEColorMatrixElement.idl:
        * svg/SVGFEComponentTransferElement.idl:
        * svg/SVGFECompositeElement.idl:
        * svg/SVGFEConvolveMatrixElement.idl:
        * svg/SVGFEDiffuseLightingElement.idl:
        * svg/SVGFEDisplacementMapElement.idl:
        * svg/SVGFEDropShadowElement.idl:
        * svg/SVGFEFloodElement.idl:
        * svg/SVGFEGaussianBlurElement.idl:
        * svg/SVGFEImageElement.idl:
        * svg/SVGFELightElement.h:
        * svg/SVGFEMergeElement.idl:
        * svg/SVGFEMergeNodeElement.h:
        * svg/SVGFEMorphologyElement.idl:
        * svg/SVGFEOffsetElement.idl:
        * svg/SVGFESpecularLightingElement.idl:
        * svg/SVGFETileElement.idl:
        * svg/SVGFETurbulenceElement.idl:
        * svg/SVGFilterElement.cpp:
        (WebCore::SVGFilterElement::SVGFilterElement):
        (WebCore::SVGFilterElement::parseAttribute):
        (WebCore::SVGFilterElement::svgAttributeChanged):
        (WebCore::SVGFilterElement::childrenChanged):
        * svg/SVGFilterElement.h:
        * svg/SVGFilterElement.idl:
        * svg/SVGFilterPrimitiveStandardAttributes.cpp:
        (WebCore::SVGFilterPrimitiveStandardAttributes::SVGFilterPrimitiveStandardAttributes):
        (WebCore::SVGFilterPrimitiveStandardAttributes::parseAttribute):
        (WebCore::SVGFilterPrimitiveStandardAttributes::svgAttributeChanged):
        (WebCore::SVGFilterPrimitiveStandardAttributes::childrenChanged):
        (WebCore::SVGFilterPrimitiveStandardAttributes::rendererIsNeeded):
        * svg/SVGFilterPrimitiveStandardAttributes.h:
        * svg/SVGFontElement.cpp:
        (WebCore::SVGFontElement::SVGFontElement):
        * svg/SVGFontElement.h:
        * svg/SVGFontFaceElement.cpp:
        * svg/SVGFontFaceElement.h:
        * svg/SVGFontFaceFormatElement.h:
        * svg/SVGFontFaceNameElement.h:
        * svg/SVGFontFaceSrcElement.h:
        * svg/SVGFontFaceUriElement.h:
        * svg/SVGGElement.cpp:
        (WebCore::SVGGElement::rendererIsNeeded):
        * svg/SVGGlyphElement.cpp:
        (WebCore::SVGGlyphElement::SVGGlyphElement):
        (WebCore::SVGGlyphElement::parseAttribute):
        (WebCore::SVGGlyphElement::insertedInto):
        (WebCore::SVGGlyphElement::removedFrom):
        * svg/SVGGlyphElement.h:
        * svg/SVGGlyphRefElement.cpp:
        (WebCore::SVGGlyphRefElement::SVGGlyphRefElement):
        (WebCore::SVGGlyphRefElement::parseAttribute):
        * svg/SVGGlyphRefElement.h:
        * svg/SVGGlyphRefElement.idl:
        * svg/SVGGradientElement.cpp:
        (WebCore::SVGGradientElement::SVGGradientElement):
        (WebCore::SVGGradientElement::parseAttribute):
        (WebCore::SVGGradientElement::svgAttributeChanged):
        (WebCore::SVGGradientElement::childrenChanged):
        * svg/SVGGradientElement.h:
        * svg/SVGGradientElement.idl:
        * svg/SVGGraphicsElement.cpp:
        (WebCore::SVGGraphicsElement::SVGGraphicsElement):
        (WebCore::SVGGraphicsElement::parseAttribute):
        (WebCore::SVGGraphicsElement::svgAttributeChanged):
        * svg/SVGGraphicsElement.h:
        * svg/SVGGraphicsElement.idl:
        * svg/SVGLocatable.cpp:
        (WebCore::SVGLocatable::computeCTM):
        * svg/SVGMPathElement.h:
        * svg/SVGMarkerElement.cpp:
        (WebCore::SVGMarkerElement::SVGMarkerElement):
        (WebCore::SVGMarkerElement::parseAttribute):
        (WebCore::SVGMarkerElement::svgAttributeChanged):
        (WebCore::SVGMarkerElement::childrenChanged):
        * svg/SVGMarkerElement.h:
        * svg/SVGMarkerElement.idl:
        * svg/SVGMaskElement.cpp:
        (WebCore::SVGMaskElement::SVGMaskElement):
        (WebCore::SVGMaskElement::parseAttribute):
        (WebCore::SVGMaskElement::svgAttributeChanged):
        (WebCore::SVGMaskElement::childrenChanged):
        * svg/SVGMaskElement.h:
        * svg/SVGMaskElement.idl:
        * svg/SVGMetadataElement.h:
        * svg/SVGMissingGlyphElement.cpp:
        (WebCore::SVGMissingGlyphElement::SVGMissingGlyphElement):
        * svg/SVGMissingGlyphElement.h:
        * svg/SVGMissingGlyphElement.idl:
        * svg/SVGPatternElement.cpp:
        (WebCore::SVGPatternElement::SVGPatternElement):
        (WebCore::SVGPatternElement::parseAttribute):
        (WebCore::SVGPatternElement::svgAttributeChanged):
        (WebCore::SVGPatternElement::childrenChanged):
        * svg/SVGPatternElement.h:
        * svg/SVGPatternElement.idl:
        * svg/SVGScriptElement.h:
        * svg/SVGStopElement.cpp:
        (WebCore::SVGStopElement::SVGStopElement):
        (WebCore::SVGStopElement::parseAttribute):
        (WebCore::SVGStopElement::svgAttributeChanged):
        * svg/SVGStopElement.h:
        * svg/SVGStopElement.idl:
        * svg/SVGStyleElement.h:
        * svg/SVGStyledElement.cpp: Removed.
        * svg/SVGStyledElement.h: Removed.
        * svg/SVGStyledElement.idl: Removed.
        * svg/SVGSymbolElement.cpp:
        (WebCore::SVGSymbolElement::SVGSymbolElement):
        (WebCore::SVGSymbolElement::parseAttribute):
        (WebCore::SVGSymbolElement::svgAttributeChanged):
        * svg/SVGSymbolElement.h:
        * svg/SVGSymbolElement.idl:
        * svg/SVGTRefElement.cpp:
        (WebCore::SVGTRefElement::insertedInto):
        (WebCore::SVGTRefElement::removedFrom):
        * svg/SVGTitleElement.cpp:
        (WebCore::SVGTitleElement::SVGTitleElement):
        (WebCore::SVGTitleElement::insertedInto):
        * svg/SVGTitleElement.h:
        * svg/SVGTitleElement.idl:
        * svg/SVGTransformable.cpp:
        * svg/SVGUseElement.cpp:
        (WebCore::SVGUseElement::selfHasRelativeLengths):
        * svg/SVGViewElement.cpp:
        (WebCore::SVGViewElement::SVGViewElement):
        (WebCore::SVGViewElement::parseAttribute):
        * svg/SVGViewElement.h:
        * svg/animation/SVGSMILElement.h:
        * svg/graphics/filters/SVGFEImage.cpp:
        (WebCore::FEImage::platformApplySoftware):

2516 2517 2518 2519 2520 2521 2522 2523 2524 2525 2526 2527 2528
2013-08-22  Andreas Kling  <akling@apple.com>

        FrameLoader::history() should return a reference.
        <https://webkit.org/b/120163>

        Reviewed by Anders Carlsson.

        Rehued by Anders Carlsson.

        FrameLoader::m_history is never null, so make history() return a reference.
        Also made HistoryController::m_frame a reference, since HistoryController's
        lifetime is tied to FrameLoader, which is tied to the Frame.

2529 2530 2531 2532 2533 2534 2535 2536 2537 2538 2539 2540 2541
2013-08-21  Simon Fraser  <simon.fraser@apple.com>

        Reloading this video test shows garbage briefly
        https://bugs.webkit.org/show_bug.cgi?id=119377

        Reviewed by Anders Carlson.

        RenderVideo should not claim that it's foreground is opaque
        unless it has a video frame to display.

        * rendering/RenderVideo.cpp:
        (WebCore::RenderVideo::foregroundIsKnownToBeOpaqueInRect):

akling@apple.com's avatar