ChangeLog 8.05 MB
Newer Older
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
2013-03-27  Dean Jackson  <dino@apple.com>

        [Mac] Use fontName rather than familyName for internal fonts
        https://bugs.webkit.org/show_bug.cgi?id=113392
        <rdar://problem/13474743>

        Reviewed by Enrica Casucci.

        Some internal fonts on OS X have a family name that
        isn't listed in availableFontFamilies. In this case
        we should use the font name rather than the family
        name when looking for a match.

        * platform/mac/ThemeMac.h: NSFont category to provide a web-friendly family name.
        * platform/mac/ThemeMac.mm:
        (-[NSFont webCoreFamilyName]): Returns the font name for internal fonts, otherwise the family name.
        (WebCore::ThemeMac::controlFont):
        * rendering/RenderThemeMacShared.mm: Use the webCoreFamilyName.
        (WebCore::RenderThemeMacShared::systemFont): Ditto.
        (WebCore::RenderThemeMacShared::setFontFromControlSize): Ditto.

22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
2013-03-26  Jer Noble  <jer.noble@apple.com>

        Mac: Media Controls always hide time display elements
        https://bugs.webkit.org/show_bug.cgi?id=113355

        Reviewed by Eric Carlson.

        No new tests; rebaselined existing tests against correct behavior.

        A prior commit set the "min-width:0" property on the time display elements, which, combined
        with the "-webkit-flex-box:0 0" setting, caused the flex-box container to collapse the width
        of the elements to zero. To achieve the desired effect of hiding the time display elements,
        first set the elements' min-width to the desired width, as the new flex-box spec treats the
        default value of "min-width:auto" as the intrinsic width, and will collapse the text display
        elements to the intrinsic width of its contained text node.

        The above allows the timeline container to collapse beyond the sum of its childrens'
        intrinsic width. Create a custom renderer that detects when this happens, and hide the time
        display controls.

        * css/mediaControls.css:
        * css/mediaControlsQuickTime.css:
        (audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
            Set the "min-width:" property to equal the "width:" property.
        (audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display):
            Ditto.
        * css/mediaControlsChromium.css:
        (audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display):
            Chromium assumes the time display controls are flex-boxes, so make that explicit.
        * html/shadow/MediaControlElementTypes.cpp: Removed MediaControlTimeDisplayElement::createRenderer().
        * html/shadow/MediaControlElementTypes.h:
        (MediaControlTimeDisplayElement): Ditto.
        * html/shadow/MediaControlElements.cpp:
        (WebCore::MediaControlTimelineContainerElement::setTimeDisplaysHidden): Added, walks through the 
            container's children and shows or hides time display elements.
        (WebCore::MediaControlTimelineContainerElement::createRenderer): Added, creates a RenderMediaControlTimelineContainer.
        (WebCore::getMediaControlTimeRemainingDisplayElementShadowPseudoId): Added, allow setTimeDisplaysHidden to
            query against children's shadowPseudoId().
        (WebCore::MediaControlTimeRemainingDisplayElement::shadowPseudoId): Moved contents to getMediaControlTimeRemainingDisplayElementShadowPseudoId.
        (WebCore::getMediaControlCurrentTimeDisplayElementShadowPseudoId): Added, allow setTimeDisplaysHidden to
            query against children's shadowPseudoId().
        (WebCore::MediaControlCurrentTimeDisplayElement::shadowPseudoId): Moved contents to getMediaControlCurrentTimeDisplayElementShadowPseudoId.
        * html/shadow/MediaControlElements.h:
        (MediaControlTimelineContainerElement):
        * rendering/RenderMediaControlElements.cpp:
        (WebCore::RenderMediaControlTimelineContainer::RenderMediaControlTimelineContainer): Added, simple constructor.
        (WebCore::RenderMediaControlTimelineContainer::layout): Detect when the controller's width is greater than
            a certain value, and show or hide the time display elements in response.
        * rendering/RenderMediaControlElements.h:
        (RenderMediaControlTimelineContainer):

73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
2013-03-27  Ilya Tikhonovsky  <loislo@chromium.org>

        Web Inspector: CPU profiler. Swap FlameChart with Data Grid.
        https://bugs.webkit.org/show_bug.cgi?id=113395

        Reviewed by Pavel Feldman.

        Looks like FlameChart is more powerful and flexible instrument
        than plain old ProfileTree in DataGrid. The same action like
        'look for the most expensive function in a frame' could be easily
        done with FlameChart and need number of clicks in DataGrid.
        So in an offline discussion we decided to place FlameChart on top of DataGrid.

        * inspector/front-end/CPUProfileView.js:

88
89
90
91
92
93
94
95
96
97
98
99
100
2013-03-27  Chris Fleizach  <cfleizach@apple.com>

        Regression in tests due to https://bugs.webkit.org/show_bug.cgi?id=113339
        https://bugs.webkit.org/show_bug.cgi?id=113361

        Fix the red bots. No review.

        Ensure only pop-up buttons get the AXRequired attribute instead of all buttons.        

        * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
        (-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
        (-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):

101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
2013-03-27  Vsevolod Vlasov  <vsevik@chromium.org>

        Web Inspector: Breakpoint manager should restore breakpoints when uiSourceCode is added.
        https://bugs.webkit.org/show_bug.cgi?id=113381

        Reviewed by Pavel Feldman.

        Breakpoint manager now restores breakpoints on UISourceCodeAdded event.
        Breakpoint manager now only resets breakpoints in debugger when source mapping is changed to/from non identity one.

        * inspector/front-end/BreakpointManager.js:
        (WebInspector.BreakpointManager.prototype._uiSourceCodeAdded):
        (WebInspector.BreakpointManager.prototype._resetBreakpoints):
        (WebInspector.BreakpointManager.prototype._uiSourceCodeMappingChanged):
        * inspector/front-end/CompilerScriptMapping.js:
        (WebInspector.CompilerScriptMapping.prototype.get isIdentity):
        * inspector/front-end/DefaultScriptMapping.js:
        (WebInspector.DefaultScriptMapping.prototype.isIdentity):
        * inspector/front-end/ResourceScriptMapping.js:
        (WebInspector.ResourceScriptMapping.prototype.isIdentity):
        * inspector/front-end/SASSSourceMapping.js:
        (WebInspector.SASSSourceMapping.prototype.isIdentity):
        * inspector/front-end/ScriptSnippetModel.js:
        (WebInspector.SnippetScriptMapping.prototype.isIdentity):
        * inspector/front-end/SourceMapping.js:
        (WebInspector.SourceMapping.prototype.isIdentity):
        * inspector/front-end/StylesSourceMapping.js:
        (WebInspector.StylesSourceMapping.prototype.isIdentity):
        * inspector/front-end/UISourceCode.js:
        (WebInspector.UISourceCode.prototype.setSourceMapping):

132
133
134
135
136
137
138
139
140
141
142
143
2013-03-27  Yury Semikhatsky  <yurys@chromium.org>

        Web Inspector: update Timeline.TimelineEvent definition to include DOM counters and native memory stats
        https://bugs.webkit.org/show_bug.cgi?id=113376

        Reviewed by Vsevolod Vlasov.

        Fixed assertion failure in debug mode after r146975.

        * inspector/InspectorTimelineAgent.cpp:
        (WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):

144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
2013-03-27  Ilya Tikhonovsky  <loislo@chromium.org>

        Web Inspector: FlameChart. Provide 15px padding left for the chart so developers will see the first divider with '0' title.
        https://bugs.webkit.org/show_bug.cgi?id=113404

        Reviewed by Pavel Feldman.

        15px paddingLeft was added to the code for the chart.

        * inspector/front-end/FlameChart.js:
        (WebInspector.FlameChart):
        (WebInspector.FlameChart.Calculator.prototype._updateBoundaries):
        (WebInspector.FlameChart.Calculator.prototype.computePosition):
        (WebInspector.FlameChart.prototype.draw):

159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
2013-03-27  Kent Tamura  <tkent@chromium.org>

        Rename HTMLFormControlElement::readOnly to isReadOnly
        https://bugs.webkit.org/show_bug.cgi?id=113297

        Reviewed by Alexey Proskuryakov.

        HTMLFormControlElement::readOnly is not an implementation of
        'readOnly' IDL attribute. It's confusing and we don't need to
        violate our naming convention.

        No new tests. Just a refactoring.

        * accessibility/AccessibilityNodeObject.cpp:
        (WebCore::AccessibilityNodeObject::isReadOnly):
        * html/BaseMultipleFieldsDateAndTimeInputType.cpp:
        (WebCore::BaseMultipleFieldsDateAndTimeInputType::isEditControlOwnerReadOnly):
        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLFormControlElement::HTMLFormControlElement):
        (WebCore::HTMLFormControlElement::parseAttribute):
        * html/HTMLFormControlElement.h:
        (WebCore::HTMLFormControlElement::isReadOnly):
        (WebCore::HTMLFormControlElement::isDisabledOrReadOnly):
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::matchesReadOnlyPseudoClass):
        (WebCore::HTMLInputElement::matchesReadWritePseudoClass):
        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::matchesReadOnlyPseudoClass):
        (WebCore::HTMLTextAreaElement::matchesReadWritePseudoClass):
        * html/shadow/SliderThumbElement.cpp:
        (WebCore::SliderThumbElement::defaultEventHandler):
        (WebCore::SliderThumbElement::willRespondToMouseMoveEvents):
        (WebCore::SliderThumbElement::willRespondToMouseClickEvents):
        * html/shadow/TextControlInnerElements.cpp:
        (WebCore::InputFieldSpeechButtonElement::willRespondToMouseClickEvents):
        (WebCore::InputFieldSpeechButtonElement::setRecognitionResult):
        * html/shadow/TextFieldDecorationElement.cpp:
        (WebCore::TextFieldDecorationElement::updateImage):
        * rendering/RenderTextControl.cpp:
        (WebCore::updateUserModifyProperty):
        * rendering/RenderThemeMacShared.mm:
        (WebCore::RenderThemeMacShared::paintSearchFieldCancelButton):

202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
2013-03-27  Yury Semikhatsky  <yurys@chromium.org>

        Web Inspector: update Timeline.TimelineEvent definition to include DOM counters and native memory stats
        https://bugs.webkit.org/show_bug.cgi?id=113376

        Reviewed by Vsevolod Vlasov.

        Added missing fields to Timeline.TimelineEvent type definition in Inspector.json

        * inspector/Inspector.json:
        * inspector/InspectorTimelineAgent.cpp:
        (WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):
        (WebCore::InspectorTimelineAgent::setDOMCounters):
        Switched InspectorTimelineAgent to the new typed event builders.
        (WebCore::InspectorTimelineAgent::setNativeHeapStatistics):
        * inspector/InspectorTimelineAgent.h:
        (InspectorTimelineAgent):

220
221
222
223
224
225
226
227
228
229
230
231
2013-03-27  Vsevolod Vlasov  <vsevik@chromium.org>

        Web Inspector: Follow-up to r146898: test that uiSourceCodes are not leaking in breakpoint manager.
        https://bugs.webkit.org/show_bug.cgi?id=113368

        Reviewed by Pavel Feldman.

        Added a missed line and a test.

        * inspector/front-end/BreakpointManager.js:
        (WebInspector.BreakpointManager.prototype._projectWillReset):

232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
2013-03-27  Andrey Lushnikov  <lushnikov@chromium.org>

        Web Inspector: [CodeMirror] CodeMirrorTextEditor.highlightRange has bugs
        https://bugs.webkit.org/show_bug.cgi?id=113348

        Reviewed by Vsevolod Vlasov.

        No new tests.

        - Append additional "<class>-start" class to the first highlighted span
        and "<class>-end" class to the last highlighted span to provide a way
        to set up a css classes with borders.
        - Increment end column of the markup range to simulate inclusive range.

        * inspector/front-end/CodeMirrorTextEditor.js:
        (WebInspector.CodeMirrorTextEditor.prototype.highlightRange):

249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
2013-03-27  Andrey Lushnikov  <lushnikov@chromium.org>

        Web Inspector: Add isClean/markClean method pair to textEditor.js
        https://bugs.webkit.org/show_bug.cgi?id=112815

        Reviewed by Vsevolod Vlasov.

        No new tests: no change in behaviour.

        - Add TextEditor.isClean and TextEditor.markClean methods
        - Implement these methods in DefaultTextEditor
        - Implement these methods in CodeMirrorTextEditor

        * inspector/front-end/CodeMirrorTextEditor.js:
        (WebInspector.CodeMirrorTextEditor.prototype.isClean):
        (WebInspector.CodeMirrorTextEditor.prototype.markClean):
        * inspector/front-end/DefaultTextEditor.js:
        (WebInspector.DefaultTextEditor.prototype.isClean):
        (WebInspector.DefaultTextEditor.prototype.markClean):
        * inspector/front-end/TextEditor.js:
        (WebInspector.TextEditor.prototype.isClean):
        (WebInspector.TextEditor.prototype.markClean):
        * inspector/front-end/TextEditorModel.js:
        (WebInspector.TextEditorModel.endsWithBracketRegex.):

274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
2013-03-27  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed. Web Inspector. rename method Timeline.Calculator.grandMinimumBoundary to Timeline.Calculator.zeroTime

        No changes in behaviour.

        * inspector/front-end/FlameChart.js:
        (WebInspector.FlameChart.Calculator.prototype.zeroTime):
        (WebInspector.FlameChart.OverviewCalculator.prototype.zeroTime):
        * inspector/front-end/NetworkPanel.js:
        (WebInspector.NetworkBaseCalculator.prototype.zeroTime):
        * inspector/front-end/TimelineGrid.js:
        (WebInspector.TimelineGrid.prototype.updateDividers):
        (WebInspector.TimelineGrid.Calculator.prototype.zeroTime):
        * inspector/front-end/TimelineOverviewPane.js:
        (WebInspector.TimelineOverviewCalculator.prototype.zeroTime):
        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelineCalculator.prototype.zeroTime):

293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
2013-03-26  Ilya Tikhonovsky  <loislo@chromium.org>

        Web Inspector: Timeline. Scroll dividers with the underlying events.
        https://bugs.webkit.org/show_bug.cgi?id=113315

        Reviewed by Pavel Feldman.

        Now when TimelineGrid is able to draw dividers with any offset
        we could cut away paddingLeft member of Timeline.Calculator
        and clear the code of TimelineGrid.

        * inspector/front-end/TimelineGrid.js:
        (WebInspector.TimelineGrid.prototype.updateDividers):
        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel.prototype._refresh):
        (WebInspector.TimelineCalculator.prototype.computePosition):
        (WebInspector.TimelineCalculator.prototype.setDisplayWindow):
        (WebInspector.TimelineCalculator.prototype.grandMinimumBoundary):
        * inspector/front-end/inspectorCommon.css:
        (.resources-dividers-label-bar):

314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
2013-03-27  Kondapally Kalyan  <kalyan.kondapally@intel.com>

        [CoordGfx] Support to share GraphicsSurface flags with client.
        https://bugs.webkit.org/show_bug.cgi?id=112982

        Reviewed by Noam Rosenthal.

        Covered by existing WebGL tests.

        This patch adds support to pass GraphicsSurface flags during it's client creation.
        This would be helpful to determine cases when blending can be disabled on client
        side i.e When AlphaSupport is disabled during Graphics Surface creation.
        With GLX, we rely on Window to provide us with necessary information on client side.
        This might not be the case on other platforms or when not using Window on X.
        This patch doesn't change original behaviour of creating GraphicsSurface client
        with default flags GraphicsSurface::SupportsTextureTarget and GraphicsSurface::SupportsSharing.

        * platform/graphics/texmap/TextureMapperPlatformLayer.h:
        (WebCore::TextureMapperPlatformLayer::graphicsSurfaceFlags):
        * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
        (WebCore::CoordinatedGraphicsLayer::createCanvasIfNeeded):
        * platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
        (WebCore::CoordinatedGraphicsScene::createCanvasIfNeeded):
        * platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:
        (CoordinatedGraphicsLayerState):
        * platform/graphics/efl/GraphicsContext3DPrivate.cpp:
        (WebCore):
        (WebCore::GraphicsContext3DPrivate::graphicsSurfaceFlags):
        * platform/graphics/efl/GraphicsContext3DPrivate.h:
        (GraphicsContext3DPrivate):
        * platform/graphics/surfaces/efl/GraphicsSurfaceCommon.cpp:
        (WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
        (WebCore::GraphicsSurfacePrivate::initializeClient):

348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
2013-03-26  Takashi Sakamoto  <tasak@google.com>

        [shadow] styleForText should consider the case where parent node has no style
        https://bugs.webkit.org/show_bug.cgi?id=113275

        If a text node is distributed, its parent node for rendering and
        styling might have no style. In the case, styleForText should return
        default style.

        Reviewed by Hajime Morrita.

        Test: fast/dom/shadow/text-node-distributed-crash.html

        * css/StyleResolver.cpp:
        (WebCore::StyleResolver::styleForText):
        Check whether a parent node has any style or not. If not, return
        default style. This is the same behavior as styleForElement.

366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
2013-03-26  Takeshi Yoshino  <tyoshino@chromium.org>

        Make SocketStreamHandle (Chromium port) fully use IPC window in send()
        https://bugs.webkit.org/show_bug.cgi?id=113304

        Reviewed by Kent Tamura.

        socket_stream of Chromium buffers send data up to 32KiB (exact) bytes.

        However, SocketStreamHandleInternal::send() method now keeps in-flight
        send data not greater than m_maxPendingSendAllowed - 1 that is
        32KiB - 1. This means that SocketStreamHandleInternal consumes the
        buffered data in SocketStreamHandleBase by 32KiB - 1. It makes memory
        copy operations unaligned unnecessarily. It should just use the
        allowed size fully.

        * platform/network/chromium/SocketStreamHandle.cpp:
        (WebCore::SocketStreamHandleInternal::send):
        (WebCore):

386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
2013-03-26  Hayato Ito  <hayato@chromium.org>

        Allow ShadowContents in HitTests by default.
        https://bugs.webkit.org/show_bug.cgi?id=113171

        Reviewed by Dimitri Glazkov.

        HitTestRequest is widely used in WebCore, but AllowShadowContents
        flag is not turned on by default.  In most places, we can set the
        flag on.

        This change makes HitTests allow shadow contents by default.

        To track all existing HitTests which do not allow shadow contents,
        and discourage such a HitTest in the future, I've introduced
        disallowShadowContenet flag so that callers must turn on this flag
        explicitly if they want to disallow shadow contents in their HitTests.

        This change should be refactoring and should not include any
        behavior changes.  After this change, we'll investigate each place
        where disallowShadowContents is used step by step and get rid of
        the flag if it is okay to remove.

        No new tests, no behavior change.

        * dom/Document.h:
        (Document):
        * dom/TreeScope.cpp:
        (WebCore::nodeFromPoint):
        * editing/FrameSelection.cpp:
        (WebCore::FrameSelection::contains):
        * page/DragController.cpp:
        (WebCore::elementUnderMouse):
        (WebCore::DragController::canProcessDrag):
        (WebCore::DragController::startDrag):
        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMouseDraggedEvent):
        (WebCore::EventHandler::eventMayStartDrag):
        (WebCore::EventHandler::updateSelectionForMouseDrag):
        (WebCore::EventHandler::hitTestResultAtPoint):
        (WebCore::EventHandler::handleMousePressEvent):
        (WebCore::EventHandler::handleMouseDoubleClickEvent):
        (WebCore::EventHandler::handleMouseMoveEvent):
        (WebCore::EventHandler::handleMouseReleaseEvent):
        (WebCore::EventHandler::updateDragAndDrop):
        (WebCore::EventHandler::isInsideScrollbar):
        (WebCore::EventHandler::handleWheelEvent):
        (WebCore::EventHandler::handleGestureEvent):
        (WebCore::EventHandler::handleGestureLongPress):
        (WebCore::EventHandler::handleGestureScrollBegin):
        (WebCore::EventHandler::bestClickableNodeForTouchPoint):
        (WebCore::EventHandler::bestContextMenuNodeForTouchPoint):
        (WebCore::EventHandler::bestZoomableAreaForTouchPoint):
        (WebCore::EventHandler::sendContextMenuEvent):
        (WebCore::EventHandler::sendContextMenuEventForKey):
        (WebCore::EventHandler::hoverTimerFired):
        (WebCore::EventHandler::dragSourceEndedAt):
        (WebCore::EventHandler::handleDrag):
        (WebCore::EventHandler::handleTouchEvent):
        (WebCore::EventHandler::dispatchSyntheticTouchEventIfEnabled):
        * page/EventHandler.h:
        (EventHandler):
        * page/FocusController.cpp:
        (WebCore::updateFocusCandidateIfNeeded):
        * page/Frame.cpp:
        (WebCore::Frame::visiblePositionForPoint):
        * page/TouchDisambiguation.cpp:
        (WebCore::findGoodTouchTargets):
        * rendering/HitTestRequest.h:
        (WebCore::HitTestRequest::disallowsShadowContent):
        * rendering/HitTestResult.cpp:
        (WebCore::HitTestResult::addNodeToRectBasedTestResult):
        * rendering/RenderFlowThread.cpp:
        (WebCore::RenderFlowThread::hitTestFlowThreadPortionInRegion):
        * rendering/svg/RenderSVGResourceClipper.cpp:
        (WebCore::RenderSVGResourceClipper::hitTestClipContent):
        * testing/Internals.cpp:
        (WebCore::Internals::nodesFromRect):

465
466
467
468
469
470
471
472
473
474
475
476
477
2013-03-26  Tim Horton  <timothy_horton@apple.com>

        [ca] Tell CA to clean up unused resources if a given WebProcess won't be drawing
        https://bugs.webkit.org/show_bug.cgi?id=107539
        <rdar://problem/13032692>

        Reviewed by Simon Fraser.

        Update WebCoreSystemInterface.

        * platform/mac/WebCoreSystemInterface.h:
        * platform/mac/WebCoreSystemInterface.mm:

478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
2013-03-26  Antti Koivisto  <antti@apple.com>

        Test if non-immediate descendants obscure background
        https://bugs.webkit.org/show_bug.cgi?id=113137

        Reviewed by Simon Fraser.

        The current obscuration test only covers immediate children. We can find more cases by looking deeper into descendants.
        
        The patch makes the test sufficiently smart to stop a heavy fully obscured gif animation on micrsoft.com.

        * loader/cache/CachedImage.cpp:
        (WebCore::CachedImage::animationAdvanced):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::styleDidChange):
        
            Invalidate parents to max test depth.

        (WebCore::RenderBox::backgroundPaintedExtent):
        
            Background painting is pixel snapped.

        (WebCore::isCandidateForOpaquenessTest):
        (WebCore::RenderBox::foregroundIsKnownToBeOpaqueInRect):
        
            Separate foreground testing and make it recursive.
            Add fast bailout for common static positioned case.
            Remove maximum child count, the fast bailouts should prevent long tests.
            Add maximum depth so we know how deep we need to invalidate in styleDidChange.

        (WebCore::RenderBox::computeBackgroundIsKnownToBeObscured):
        (WebCore):
        * rendering/RenderBox.h:
        (RenderBox):
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::foregroundIsKnownToBeOpaqueInRect):
        (WebCore):
        (WebCore::RenderImage::computeBackgroundIsKnownToBeObscured):
        
        * rendering/RenderImage.h:
        (RenderImage):

520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
2013-03-26  Benjamin Poulain  <bpoulain@apple.com>

        Regression (r145601): out-of-bounds read in line breaking / new width cache
        https://bugs.webkit.org/show_bug.cgi?id=113347

        Reviewed by Geoffrey Garen.

        The values zero and 0xffff have special values with the default HashTraits. Those values
        are also valid values for UChar.

        To avoid any table inconsitency, switch from UChar to uint32_t as the key type for
        the WidthCache's single char map. The traits is also changed to allow zero as a normal
        value.

        This makes no space or time change over the previous code because:
        -The struct KeyValuePair was already 64bits due to the ABI alignment restrictions on floats.
        -The two hashes take the same number of instructions.

        * platform/graphics/WidthCache.h:
        (WidthCache):

541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
2013-03-26  Kent Tamura  <tkent@chromium.org>

        Make HTMLProgressElement::isDeterminate private
        https://bugs.webkit.org/show_bug.cgi?id=113299

        Reviewed by Kentaro Hara.

        The only callsite of isDeterminate outside of HTMLProgressElement
        is in StyleResolver::sharingCandidateHasIdenticalStyleAffectingAttributes,
        and we can replace it with Element::shouldAppearIndeterminate.

        No new tests. Just a refactoring.

        * css/StyleResolver.cpp:
        (WebCore::StyleResolver::sharingCandidateHasIdenticalStyleAffectingAttributes):
        Use Element::shouldAppearIndeterminate.
        * html/HTMLProgressElement.h:
        (HTMLProgressElement): Make isDeterminate private.

560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
2013-03-26  David Grogan  <dgrogan@chromium.org>

        IndexedDB: Histogram cause of LevelDB write errors
        https://bugs.webkit.org/show_bug.cgi?id=113350

        Reviewed by Tony Chang.

        Add histogram for source of LevelDB errors on Write in addition to
        Open.

        No new tests - no good way to test histogram code.

        * platform/leveldb/LevelDBDatabase.cpp:
        (WebCore::histogramLevelDBError):
        (WebCore):
        (WebCore::LevelDBDatabase::open):
        (WebCore::LevelDBDatabase::write):

578
579
580
581
582
583
584
585
586
587
588
589
590
591
2013-03-26  Chris Fleizach  <cfleizach@apple.com>

        WebKit does not expose @required or @aria-required as AXRequired on select elements
        https://bugs.webkit.org/show_bug.cgi?id=113339

        Reviewed by Tim Horton.

        Make sure button types can return the AXRequired attribute.

        Tests: platform/mac/accessibility/aria-required-popup-button.html

        * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
        (-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):

592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
2013-03-26  Dean Jackson  <dino@apple.com>

        When a primary plugin is restarted, also start similar plugins
        https://bugs.webkit.org/show_bug.cgi?id=113265

        Reviewed by Tim Horton.

        If we detect a primary plugin that is snapshotted, we immediately restart it.
        When this happens, we should also restart any other plugins that
        match the same origin and type. This allows sites with a lot of
        (geometrically) nearby plugins to behave as if they are a single big plugin.

        Tests: plugins/snapshotting/autoplay-similar-to-dominant-after-delay.html
               plugins/snapshotting/autoplay-similar-to-dominant.html

        * WebCore.exp.in: Export mimeTypeFromURL.
        * html/HTMLPlugInImageElement.cpp:
        (WebCore::addPlugInsFromNodeListMatchingPlugInOrigin): Use loadedMimeType helper.
        (WebCore::HTMLPlugInImageElement::restartSimilarPlugIns): New method, which copied the
            existing code from userDidClickSnapshot.
        (WebCore::HTMLPlugInImageElement::userDidClickSnapshot): Move the similar plugin detection
            out into another function and call it.
        (WebCore::HTMLPlugInImageElement::setIsPrimarySnapshottedPlugIn): Call restartSimilarPlugIns.
        (WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Use loadedMimeType helper.
        * html/HTMLPlugInImageElement.h: Declaration of restartSimilarPlugIns.
        (WebCore::HTMLPlugInImageElement::loadedMimeType): New helper method since this
            code was being often duplicated.

620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
2013-03-26  Brent Fulgham  <bfulgham@webkit.org>

        [Windows, WinCairo] Scroll offset being applied to plugins during print operations.
        https://bugs.webkit.org/show_bug.cgi?id=39889

        Reviewed by Anders Carlsson.

        This must be tested manually. See the issue for details.

        * plugins/win/PluginViewWin.cpp:
        (WebCore::PluginView::paintWindowedPluginIntoContext):
        Revise the Windows implementation of the PluginView class
        paintWindowedPluginIntoContext to use the containing window
        position when computing the plugin's position for printing.

635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
2013-03-26  Xianzhu Wang  <wangxianzhu@chromium.org>

        Non-paintsContent fixed position layer should not cause slow scrolling
        https://bugs.webkit.org/show_bug.cgi?id=113238

        Reviewed by James Robinson.

        Added NotCompositedForNoVisibleContent in ViewportConstrainedNotCompositedReason and set it in RLC.

        Test: compositing/layer-creation/fixed-position-no-content-scroll-reason.html

        * rendering/RenderLayer.h: Add NotCompositedForNoVisibleContent.
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::requiresCompositingForPosition): Set NotCompositedForNoVisibleContent reason when the fixed position layer has no visible content.

650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
2013-03-26  Zoltan Horvath  <zoltan@webkit.org>

        [CSS Exclusions] The radius of a circle should be computed based on the shorter available dimension
        https://bugs.webkit.org/show_bug.cgi?id=113255

        Reviewed by Julien Chaffraix.

        When we decide what should be the radius of a circle, we should choose the smallest available space. For instance when the
        width or height is not resolvable for the circle we should not have a radius for it. This change modifies the behavior to
        use the smaller available space, so we won't render unnecessary circle shapes.

        Test: fast/exclusions/shape-inside/shape-inside-on-nested-container-with-unresolved-height.html

        * rendering/ExclusionShape.cpp:
        (WebCore::ExclusionShape::createExclusionShape):

666
667
668
669
670
671
672
673
674
675
676
677
678
2013-03-26  Timothy Hatcher  <timothy@apple.com>

        Make the Web Inspector console work in strict mode with JavaScriptCore.

        https://webkit.org/b/65829
        rdar://problem/11271238

        Reviewed by Joseph Pecoraro.

        * inspector/InjectedScriptSource.js:
        (InjectedScript.prototype._evaluateOn): Don't use 'eval' parameter (it isn't
        allowed in strict mode). Swap window.eval with our known eval instead.

679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
2013-03-26  Ryosuke Niwa  <rniwa@webkit.org>

        Heap-use-after-free regression
        https://bugs.webkit.org/show_bug.cgi?id=113337

        Reviewed by Abhishek Arya and Alexey Proskuryakov.

        Use RefPtr instead of raw pointer in m_associatedFormControls.

        * dom/Document.cpp:
        (WebCore::Document::didAssociateFormControlsTimerFired):
        * dom/Document.h:
        (Document):
        * loader/EmptyClients.h:
        (WebCore::EmptyChromeClient::didAssociateFormControls):
        * page/ChromeClient.h:
        (WebCore::ChromeClient::didAssociateFormControls):

697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
2013-03-26  Alexey Proskuryakov  <ap@apple.com>

        <rdar://problem/13194263> Crashes in NetworkProcess due to threading issues
        https://bugs.webkit.org/show_bug.cgi?id=113256

        Reviewed by Brady Eidson.

        Added a new code path in ResourceHandle/ResourceHandleClient that doesn't need
        blocking calls. Implemented it for NSURLConnection by changing NSOperationQueue
        version to forward calls to main thread.

        * WebCore.exp.in: Export new methods.
        * WebCore.xcodeproj/project.pbxproj: Added WebCoreResourceHandleAsOperationQueueDelegate.

        * platform/network/CredentialStorage.cpp: Assert that unprotected global map operations
        happen on main thread.

        * platform/network/ResourceHandle.cpp: Added default implementations of functions
        that handle async responses.

        * platform/network/chromium/ResourceHandle.cpp: Ditto.

        * platform/network/ResourceHandle.h: Added functions that are called in response
        to new async functions in ResourceHandleClient. Changed Mac delegate type to id,
        ast can now be either WebCoreResourceHandleAsDelegate or WebCoreResourceHandleAsOperationQueueDelegate.

        * platform/network/ResourceHandleClient.cpp:
        (WebCore::ResourceHandleClient::willSendRequestAsync):
        (WebCore::ResourceHandleClient::shouldUseCredentialStorageAsync):
        (WebCore::ResourceHandleClient::canAuthenticateAgainstProtectionSpaceAsync):
        (WebCore::ResourceHandleClient::willCacheResponseAsync):
        Default implementations of async client functions. These match default behavior of
        sync versions.

        * platform/network/ResourceHandleClient.h: Added async functions. A ResourceHandle
        should use these when the client returns true from usesAsyncCallbacks().

        * platform/network/ResourceHandleInternal.h: Changed to use id for delegate type
        here, too.

        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::delegate): Create an appropriate delegate for the client.
        (WebCore::ResourceHandle::willSendRequest): Since this function has a lot of common
        behavior in sync and async cases, implement the new code path as a branch inside
        it, not as a new function.
        (WebCore::ResourceHandle::continueWillSendRequest): Unblock the connection when
        response is known.
        (WebCore::ResourceHandle::shouldUseCredentialStorage): Branched here too, for consistency.
        Perhaps we'll want to break this into separate functions though.
        (WebCore::ResourceHandle::continueShouldUseCredentialStorage): Unblock the connection.
        (WebCore::ResourceHandle::canAuthenticateAgainstProtectionSpace): Same change as above.
        (WebCore::ResourceHandle::continueCanAuthenticateAgainstProtectionSpace): Ditto.
        (WebCore::ResourceHandle::continueWillCacheResponse): Ditto. Currently, delegate
        calls the client directly, so we only have a "continue" function, and no "willCacheResponse".

        * platform/network/mac/WebCoreResourceHandleAsDelegate.mm:
        (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]): Removed some
        nonsense code.

        * platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.h: Copied from Source/WebCore/platform/network/mac/WebCoreResourceHandleAsDelegate.h.
        This delegate is responsible for forwarding calls to main thread. Unfortunately,
        this adds some code duplication, which I tried to rectify somewhat in previous patches
        by moving more logic to ResourceHandle.

        * platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm: Copied from Source/WebCore/platform/network/mac/WebCoreResourceHandleAsDelegate.mm.
        (-[WebCoreResourceHandleAsOperationQueueDelegate detachHandle]): Unblock waiting
        threads if we don't expect a response any more.
        (-[WebCoreResourceHandleAsOperationQueueDelegate dealloc]): Release the semaphore.
        (-[WebCoreResourceHandleAsOperationQueueDelegate continueWillSendRequest:]): Unblock
        a waiting thread with a response.
        (-[WebCoreResourceHandleAsOperationQueueDelegate continueShouldUseCredentialStorage:]): Ditto.
        (-[WebCoreResourceHandleAsOperationQueueDelegate continueCanAuthenticateAgainstProtectionSpace:]): Ditto.
        (-[WebCoreResourceHandleAsOperationQueueDelegate continueWillCacheResponse:]): Ditto.
        (-[WebCoreResourceHandleAsOperationQueueDelegate connection:willSendRequest:redirectResponse:]):
        Run code that uses WebCore objects on main thread.
        (-[WebCoreResourceHandleAsOperationQueueDelegate connectionShouldUseCredentialStorage:]): Ditto.
        (-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveAuthenticationChallenge:]): Ditto.
        (-[WebCoreResourceHandleAsOperationQueueDelegate connection:didCancelAuthenticationChallenge:]): Ditto.
        (-[WebCoreResourceHandleAsOperationQueueDelegate connection:canAuthenticateAgainstProtectionSpace:]): Ditto.
        (-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveResponse:]): Ditto.
        (-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveDataArray:]): Ditto.
        (-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveData:lengthReceived:]): Ditto.
        (-[WebCoreResourceHandleAsOperationQueueDelegate connection:willStopBufferingData:]): Ditto.
        (-[WebCoreResourceHandleAsOperationQueueDelegate connection:didSendBodyData:totalBytesWritten:totalBytesExpectedToWrite:]): Ditto.
        (-[WebCoreResourceHandleAsOperationQueueDelegate connectionDidFinishLoading:]): Ditto.
        (-[WebCoreResourceHandleAsOperationQueueDelegate connection:didFailWithError:]): Ditto.
        (-[WebCoreResourceHandleAsOperationQueueDelegate connection:willCacheResponse:]): Ditto.

785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
2013-03-26  Tony Chang  <tony@chromium.org>

        Autogenerate the scrollAnimatorEnabled setting in Settings.in
        https://bugs.webkit.org/show_bug.cgi?id=113253

        Reviewed by James Robinson.

        Convert scrollAnimatorEnabled into an autogenerated setting. This involves renaming
        the setter from setEnableScrollAnimator(bool) to setScrollAnimatorEnabled(bool) and
        updating the callers. I didn't change any WebKit API methods.

        Also remove the code in InternalSettings since it's never used and will now be
        autogenerated with proper resetting code.

        No new tests, this is a refactor and should compile.

        * page/Settings.cpp:
        (WebCore::Settings::Settings): Remove code that is now autogenerated.
        * page/Settings.h:
        (Settings): Remove code that is now autogenerated.
        * page/Settings.in: Add entry for scrollAnimatorEnabled.
        * testing/InternalSettings.cpp: Remove unused code.
        * testing/InternalSettings.h: Remove unused code.
        * testing/InternalSettings.idl: Remove unused code.

810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
2013-03-26  Joe Mason  <jmason@blackberry.com>

        [BlackBerry] In RSSFilterStream, don't swallow headers when there's no body
        https://bugs.webkit.org/show_bug.cgi?id=113334

        Reviewed by Rob Buis.

        RIM PR 316345

        When receiving an HTTP response that has a Content-Type header such as text/xml, but no
        body, RSSFilterStream::notifyHeadersReceived reads the Content-Type as "potential RSS", and
        calls saveHeaders. It expects to sniff the body in notifyDataReceived to see if it's RSS,
        and then call sendSavedHeaders to pass on the headers. But since there is no body,
        notifyDataReceived is never called. So call sendSavedHeaders in notifyClose too (it will not
        send them again if they were already sent.)

        * platform/network/blackberry/rss/RSSFilterStream.cpp:
        (WebCore::RSSFilterStream::notifyClose):

829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
2013-03-26  Dmitry Zvorygin  <zvorygin@chromium.org>

        Web Inspector: Faster drawer animation.
        https://bugs.webkit.org/show_bug.cgi?id=113330

        250ms -> 100ms

        Reviewed by Pavel Feldman.

        * inspector/front-end/inspector.css:
        (.animate #main):
        (.animate #floating-status-bar-container):
        (.animate #drawer):
        (.animate #bottom-status-bar-container > *):

844
845
846
847
848
849
850
851
2013-03-26  Brent Fulgham  <bfulgham@webkit.org>

        [WinCairo] Unreviewed Build fix.

        * platform/graphics/win/FontCustomPlatformDataCairo.h:
        (FontCustomPlatformData): Correct signature in header to match
        required implementation.

852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
2013-03-26  Arvid Nilsson  <anilsson@rim.com>

        [BlackBerry] Scrolling up and down can cause the screen to flash black
        https://bugs.webkit.org/show_bug.cgi?id=113269

        Reviewed by Rob Buis.

        PR 296106

        The LayerRenderer should never clear before drawing the layers, from
        now on that's the responsibility of the caller.

        Only manually testable.

        * platform/graphics/blackberry/LayerRenderer.cpp:
        (WebCore::LayerRenderer::setViewport):
        * platform/graphics/blackberry/LayerRendererClient.h:
        (LayerRendererClient):

871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
2013-03-26  Allan Sandfeld Jensen  <allan.jensen@digia.com>

        [Qt] editing/pasteboard/can-read-in-dragstart-event.html and /can-read-in-copy-and-cut-events.html are crashing
        https://bugs.webkit.org/show_bug.cgi?id=113126

        Reviewed by Jocelyn Turcotte.

        Make it possible to read from a writable Clipboard.

        Test: editing/pasteboard/can-read-in-copy-and-cut-events.html

        * platform/qt/ClipboardQt.cpp:
        (WebCore::ClipboardQt::getData):
        (WebCore::ClipboardQt::types):
        (WebCore::ClipboardQt::files):
        (WebCore::ClipboardQt::readClipboardData):
        (WebCore::ClipboardQt::hasData):
        (WebCore::ClipboardQt::items):
        * platform/qt/ClipboardQt.h:
        (ClipboardQt):

892
893
894
895
896
897
898
899
2013-03-26  Brent Fulgham  <bfulgham@webkit.org>

        [WinCairo] Unreviewed build correction.

        * platform/graphics/win/FontCustomPlatformDataCairo.cpp:
        (WebCore::FontCustomPlatformData::fontPlatformData): Update
        method signature to match CG variant.

900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
2013-03-26  Christophe Dumez  <ch.dumez@sisa.samsung.com>

        Code duplication between HTTPParsers and HTTPValidation
        https://bugs.webkit.org/show_bug.cgi?id=113283

        Reviewed by Alexey Proskuryakov.

        Merged isValidHTTPToken() from HTTPValidation.h and isRFC2616Token() from
        HTTPParsers.h. They were doing exactly the same thing and their
        implementation was almost the same.

        Removed HTTPValidation.* and moved remaining code to HTTPParsers.* as this
        seems like the proper place and it seems odd to keep HTTPValidation for
        just one function.

        No new tests, no behavior change for layout tests.

        * CMakeLists.txt:
        * GNUmakefile.list.am:
        * Target.pri:
        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.vcxproj/WebCore.vcxproj:
        * WebCore.vcxproj/WebCore.vcxproj.filters:
        * WebCore.xcodeproj/project.pbxproj:
        * platform/network/HTTPParsers.cpp:
        (WebCore::isValidHTTPHeaderValue):
        (WebCore):
        (WebCore::isValidHTTPToken): Implementation is slightly simplified based on
        isValidHTTPToken() from HTTPValidation.cpp. (c >= 0x80 || c == 0x7F) is
        replaced by (c >= 0x7F). (c <= 0x1F ||  c == ' ' || c == '\t') is replaced
        by (c <= 0x20). Those expressions are shorter but equivalent.
        (WebCore::contentDispositionType):
        * platform/network/HTTPParsers.h:
        * platform/network/HTTPValidation.cpp: Removed.
        * platform/network/HTTPValidation.h: Removed.
        * xml/XMLHttpRequest.cpp: Stop including HTTPValidation.h.

938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
2013-03-26  Sergio Villar Senin  <svillar@igalia.com>

        Implement overtype mode for editable content
        https://bugs.webkit.org/show_bug.cgi?id=112126

        Reviewed by Ryosuke Niwa.

        Tests: editing/execCommand/overtype-support.html
               editing/execCommand/overtype.html

        Add a new Overwrite command to the editor. This command will
        perform overtype operations when enabled instead of "normal" text
        insertions. As IE does, we maintain a single toggle state in the
        editor (enabled/disabled) for all the editable content in the
        page.

        This new command will be only available for richly editable
        content via keybindings or the context menu. For testing purposes
        it is also accessible via internals.

        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::replaceTextInNode): Use RefPtr for
        local variables.
        * editing/Editor.cpp:
        (WebCore::Editor::Editor):
        * editing/Editor.h:
        (WebCore::Editor::isOverwriteModeEnabled):
        (WebCore::Editor::toggleOverwriteModeEnabled):
        (Editor): Added two new functions and a new attribute.
        * editing/EditorCommand.cpp:
        (WebCore::executeToggleOverwrite): Enables/disables overwrite mode.
        (WebCore):
        (WebCore::createCommandMap): New OverWrite command.
        * editing/InsertTextCommand.cpp:
        (WebCore::InsertTextCommand::setEndingSelectionWithoutValidation):
        Refactored from performTrivialReplace(), shared by
        performOverwrite().
        (WebCore):
        (WebCore::InsertTextCommand::performTrivialReplace):
        (WebCore::InsertTextCommand::performOverwrite):
        (WebCore::InsertTextCommand::doApply): Perform overwrite if enabled.
        * editing/InsertTextCommand.h:
        (InsertTextCommand):
        * testing/Internals.cpp:
        (WebCore::Internals::resetToConsistentState): Reset OverWrite mode
        to false.
        (WebCore::Internals::isOverwriteModeEnabled):
        (WebCore):
        (WebCore::Internals::toggleOverwriteModeEnabled): Provide access
        to overwrite functionality in Editor for testing purposes.
        * testing/Internals.h:
        (Internals):
        * testing/Internals.idl:

992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
2013-03-26  Arvid Nilsson  <anilsson@rim.com>

        [BlackBerry] WebOverlay::pixelViewportRect() should return pixel viewport coordinates
        https://bugs.webkit.org/show_bug.cgi?id=113263

        Reviewed by Rob Buis.

        PR 312404

        Fix WebOverlay::pixelViewportRect() to return the pixel viewport rect
        instead of the window rect. These are different if the web page is
        rendered starting at a window coordinate other than 0,0. The clip rect
        encodes the position we're rendered at, and can be used to translate
        the rect expressed in window coordinates to the pixel viewport
        coordinate system.

        Also perform some cleanup of related code.

        Only manually testable.

        * platform/graphics/blackberry/LayerCompositingThread.cpp:
        (WebCore::LayerCompositingThread::getTransformedHolePunchRect):
        (WebCore::LayerCompositingThread::drawTextures):
        * platform/graphics/blackberry/LayerRenderer.cpp:
        (WebCore::toPixelCoordinates):
        (WebCore):
        (WebCore::LayerRenderer::toWindowCoordinates):
        (WebCore::LayerRenderer::toPixelViewportCoordinates):
        (WebCore::LayerRenderer::toDocumentViewportCoordinates):
        (WebCore::LayerRenderer::updateLayersRecursive):
        * platform/graphics/blackberry/LayerRenderer.h:
        (LayerRenderer):

1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
2013-03-26  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r146901.
        http://trac.webkit.org/changeset/146901
        https://bugs.webkit.org/show_bug.cgi?id=113321

        Was landed to soon (Requested by pfeldman on #webkit).

        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype.):
        (WebInspector.ConsoleView.prototype.filter):
        (WebInspector.ConsoleView.prototype._scheduleScrollIntoView.scrollIntoView):
        (WebInspector.ConsoleView.prototype._scheduleScrollIntoView):
        (WebInspector.ConsoleView.prototype._consoleMessageAdded):
        (WebInspector.ConsoleView.prototype._appendConsoleMessage):
        (WebInspector.ConsoleView.prototype._consoleCleared):
        (WebInspector.ConsoleView.prototype._handleContextMenuEvent.monitoringXHRItemAction):
        (WebInspector.ConsoleView.prototype._handleContextMenuEvent.get preserveLogItemAction):
        (WebInspector.ConsoleView.prototype._shouldBeVisible):
        (WebInspector.ConsoleView.prototype._updateMessageList):
        (WebInspector.ConsoleView.prototype._promptKeyDown):
        (WebInspector.ConsoleView.prototype._printResult):
        (WebInspector.ConsoleCommand.prototype.highlightSearchResults):
        * inspector/front-end/inspector.css:
        (.console-warning-level, .console-error-level, .console-log-level, .console-debug-level):
        (.filter-all .console-debug-level, .filter-debug .console-debug-level):
        (.filter-all .console-debug-level.repeated-message, .filter-debug .console-debug-level.repeated-message):

1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
2013-03-26  Rafael Weinstein  <rafaelw@chromium.org>

        HTMLStackItem should include <template> as a special tag
        https://bugs.webkit.org/show_bug.cgi?id=113016

        Reviewed by Eric Seidel.

        New test added to html5lib suite.

        * html/parser/HTMLStackItem.h:
        (WebCore::HTMLStackItem::isSpecialNode):

1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
2013-03-26  Vsevolod Vlasov  <vsevik@chromium.org>

        Web Inspector: Distinguish breakpoints and breakpoint locations in BreakpointManager API
        https://bugs.webkit.org/show_bug.cgi?id=113311

        Reviewed by Pavel Feldman.

        Made independent handling of breakpoints and breakpoint location in breakpoint manager consistent.
        JavaScriptSourceFrame now removes breakpoints originally set in it based on primary UI location.

        * inspector/front-end/BreakpointManager.js:
        (WebInspector.BreakpointManager.prototype.breakpointsForUISourceCode):
        (WebInspector.BreakpointManager.prototype.allBreakpoints):
        (WebInspector.BreakpointManager.prototype.breakpointLocationsForUISourceCode):
        (WebInspector.BreakpointManager.prototype.allBreakpointLocations):
        (WebInspector.BreakpointManager.prototype._projectWillReset.get for):
        (WebInspector.BreakpointManager.prototype._projectWillReset):
        * inspector/front-end/JavaScriptSourceFrame.js:
        (WebInspector.JavaScriptSourceFrame.prototype.onUISourceCodeContentChanged):
        (WebInspector.JavaScriptSourceFrame.prototype._restoreBreakpointsAfterEditing):
        (WebInspector.JavaScriptSourceFrame.prototype._removeAllBreakpoints):

1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
2013-03-26  Dmitry Zvorygin  <zvorygin@chromium.org>

        Web Inspector: Remove remainings of CSS-based console message filtering.
        https://bugs.webkit.org/show_bug.cgi?id=112710

        Reviewed by Pavel Feldman.

        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.get this):
        (WebInspector.ConsoleView.prototype.):
        (WebInspector.ConsoleView.prototype.filter):
        (WebInspector.ConsoleView.prototype._consoleMessageAdded):
        (WebInspector.ConsoleView.prototype._appendConsoleMessage):
        (WebInspector.ConsoleView.prototype._consoleCleared):
        (WebInspector.ConsoleView.prototype._shouldBeVisible):
        (WebInspector.ConsoleView.prototype._updateMessageList):
        (WebInspector.ConsoleView.prototype._promptKeyDown):
        (WebInspector.ConsoleView.prototype._printResult):
        (WebInspector.ConsoleCommand.prototype.highlightSearchResults):
        * inspector/front-end/inspector.css:
        (.console-debug-level.repeated-message):

1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
2013-03-26  Peter Rybin  <prybin@chromium.org>

        Web Inspector: refactor code duplication: WebInspector.ObjectPropertyTreeElement.wrapPropertyAsElements
        https://bugs.webkit.org/show_bug.cgi?id=113211

        Reviewed by Yury Semikhatsky.

        A new method WebInspector.ObjectPropertyTreeElement.wrapPropertyAsElements is added and used
        from 2 sites.

        * inspector/front-end/ObjectPropertiesSection.js:
        (WebInspector.ObjectPropertiesSection.prototype.update.callback):
        (WebInspector.ObjectPropertiesSection.prototype.update):
        (WebInspector.ObjectPropertiesSection.prototype.updateProperties):
        (.callback):
        (WebInspector.ObjectPropertyTreeElement.populate):
        (WebInspector.ObjectPropertyTreeElement.wrapPropertyAsElements):
        * inspector/front-end/WatchExpressionsSidebarPane.js:
        (WebInspector.WatchExpressionsSection.prototype.update.appendResult):
        (WebInspector.WatchExpressionsSection.prototype.update):

1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
2013-03-26  Christophe Dumez  <ch.dumez@sisa.samsung.com>

        HTTPHeaderMap::copyData() could call uncheckedAppend()
        https://bugs.webkit.org/show_bug.cgi?id=113279

        Reviewed by Alexey Proskuryakov.

        HTTPHeaderMap::copyData() calls reserveInitialCapacity() on the Vector
        but then appends items using append() function. Since we already know
        the capacity is sufficient, it is more efficient to call uncheckedAppend()
        instead to bypass capacity checks.

        No new tests, no behavior change for layout tests.

        * platform/network/HTTPHeaderMap.cpp:
        (WebCore::HTTPHeaderMap::copyData):

1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
2013-03-26  Vsevolod Vlasov  <vsevik@chromium.org>

        Web Inspector: UISourceCodes are leaking on reload sometimes.
        https://bugs.webkit.org/show_bug.cgi?id=113310

        Reviewed by Pavel Feldman.

        * inspector/front-end/BreakpointManager.js:
        (WebInspector.BreakpointManager.prototype._projectWillReset.get for):
        (WebInspector.BreakpointManager.prototype._projectWillReset):
        * inspector/front-end/ConsoleModel.js:
        (WebInspector.ConsoleModel.prototype.clearMessages):

1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
2013-03-26  Alexander Pavlov  <apavlov@chromium.org>

        Web Inspector: [Elements] Unable to "Edit as HTML" XHTML/SVG documents.
        https://bugs.webkit.org/show_bug.cgi?id=113290

        Reviewed by Pavel Feldman.

        DOMPatchSupport has been slightly augmented to handle XML (XHTML and SVG) documents.

        Test: inspector/elements/set-outer-html-for-xhtml.xhtml

        * inspector/DOMPatchSupport.cpp:
        (WebCore::DOMPatchSupport::patchDocument):
        (WebCore::DOMPatchSupport::patchNode):
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::setOuterHTML): Let HTML, XHTML, and SVG documents through.

1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
2013-03-26  Hajime Morrita  <morrita@google.com>

        https://bugs.webkit.org/show_bug.cgi?id=113164
        Custom Elements: readyCallback should be called for outerHTML and insertAdjecentHTML

        These APIs also create new elements thus should have V8DeliverCustomElementCallbacks attribute.

        Reviewed by Dimitri Glazkov.

        Test: Updated lifecycle-ready-creation-api.html.

        * html/HTMLElement.idl:

1190
1191
1192
1193
1194
1195
1196
2013-03-26  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed. WebInspector: remove unnecessary method.

        * inspector/front-end/OverviewGrid.js:
        (WebInspector.OverviewGrid.Window):

1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
2013-03-22  Ilya Tikhonovsky  <loislo@chromium.org>

        Web Inspector: Flame Chart. Scroll dividers together with underlying chart.
        http://bugs.webkit.org/show_bug.cgi?id=113080

        Reviewed by Pavel Feldman.

        * inspector/front-end/FlameChart.js:
        (WebInspector.FlameChart.Calculator.prototype.grandMinimumBoundary):
        (WebInspector.FlameChart.prototype._canvasDragging):
        * inspector/front-end/TimelineGrid.js:
        (WebInspector.TimelineGrid.prototype.updateDividers):

2013-03-26  Ilya Tikhonovsky  <loislo@chromium.org>

        Web Inspector: Flame Chart. Scroll dividers together with underlying chart.
        http://bugs.webkit.org/show_bug.cgi?id=113080

        Reviewed by Pavel Feldman.

        The only thing we need to do for this feature is to automatically adjust
        the initial offset for the dividers. I measured the speed of scrolling and found
        no difference. The speed is about 16ms so we have 60fps on dragging.

        * inspector/front-end/FlameChart.js:
        (WebInspector.FlameChart.Calculator.prototype.grandMinimumBoundary):
        (WebInspector.FlameChart.OverviewCalculator.prototype.grandMinimumBoundary):
        (WebInspector.FlameChart.prototype._canvasDragging):
        * inspector/front-end/NetworkPanel.js:
        (WebInspector.NetworkBaseCalculator.prototype.grandMinimumBoundary):
        * inspector/front-end/TimelineGrid.js:
        (WebInspector.TimelineGrid.prototype.updateDividers):
        (WebInspector.TimelineGrid.Calculator.prototype.grandMinimumBoundary):
        * inspector/front-end/TimelineOverviewPane.js:
        (WebInspector.TimelineOverviewCalculator.prototype.grandMinimumBoundary):
        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelineCalculator.prototype.grandMinimumBoundary):

1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
2013-03-26  Mike West  <mkwst@chromium.org>

        CSP 1.1: Experiment with 'base-uri' directive.
        https://bugs.webkit.org/show_bug.cgi?id=113307

        Reviewed by Jochen Eisinger.

        The 'base-uri' directive was introduced[1] as an experimental directive
        in CSP 1.1 after a bit of discussion[2][3]. The exact semantics will
        likely change, but it would be good for us to get some implementation
        experience with the API as currently specified, and to allow folks to
        play with the implementation to determine whether it meets the
        requirements the way we think it might.

        This patch is a first pass at that implementation: it will have no
        effect on ports that haven't enabled the CSP_NEXT flag.

        [1]: https://dvcs.w3.org/hg/content-security-policy/rev/4b89c246ea16
        [2]: http://lists.w3.org/Archives/Public/public-webappsec/2012Oct/0022.html
        [3]: http://lists.w3.org/Archives/Public/public-webappsec/2013Feb/0074.html

        Tests: http/tests/security/contentSecurityPolicy/1.1/base-uri-allow.html
               http/tests/security/contentSecurityPolicy/1.1/base-uri-deny.html

        * dom/Document.cpp:
        (WebCore::Document::processBaseElement):
            Check that the new base URI is allowed by CSP before using it as
            the document's base URI.
        * page/ContentSecurityPolicy.cpp:
            Add a constant for the new directive name (and, as a drive-by, split
            the list into CSP 1.0 and CSP 1.1 for clarity).
        (CSPDirectiveList):
            Add a property to hold the base URI policy directive value.
        (WebCore::CSPDirectiveList::checkSourceAndReportViolation):
            Customize the error message iff we're dealing with 'base-uri'.
        (WebCore::CSPDirectiveList::allowBaseURI):
            Check the given URI against the 'base-uri' directive's value,
            exactly as we do for every other source-list type of directive.
        (WebCore::CSPDirectiveList::addDirective):
            Accept 'base-uri' as a valid directive iff CSP_NEXT is set, and
            the embedder has opted-in via the runtime flag.
        (WebCore::ContentSecurityPolicy::allowBaseURI):
            Expose an API method on ContentSecurityPolicy to check URIs against
            the 'base-uri' directive's value.

1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
2013-03-26  Arvid Nilsson  <anilsson@rim.com>

        [BlackBerry] Main frame fixed divs not positioned correctly
        https://bugs.webkit.org/show_bug.cgi?id=112889

        Reviewed by Carlos Garcia Campos.

        PR 283363

        This was a regression from bug #112806. It caused main frame fixed
        handling to enter the iframe/scrollable div code path in LayerRenderer.

        Fixed by not setting the container for fixed flag on the main frame,
        the LayerRenderer expects this flag to be set only on non-mainframe
        containers.

        Only manually testable.

        * page/scrolling/blackberry/ScrollingCoordinatorBlackBerry.cpp:
        (WebCore::scrollLayerForFrame):
        (WebCore):
        (WebCore::ScrollingCoordinatorBlackBerry::setLayerIsContainerForFixedPositionLayers):
        (WebCore::ScrollingCoordinatorBlackBerry::setLayerIsFixedToContainerLayer):

1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
2013-03-26  Christophe Dumez  <ch.dumez@sisa.samsung.com>

        FormData::deepCopy() could use Vector::uncheckedAppend()
        https://bugs.webkit.org/show_bug.cgi?id=113309

        Reviewed by Kenneth Rohde Christiansen.

        FormData::deepCopy() calls reserveInitialCapacity() on the Vector but then uses the
        regular append() method. This patch switches to using uncheckedAppend() method
        instead to bypass capacity checks as we already know it is sufficient.

        No new tests, no behavior change.

        * platform/network/FormData.cpp:
        (WebCore::FormData::deepCopy):

1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
2013-03-26  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r146879.
        http://trac.webkit.org/changeset/146879
        https://bugs.webkit.org/show_bug.cgi?id=113312

        Multiple layout test crashes in
        WebCore::RenderListItem::updateListMarkerNumbers (Requested by
        yurys on #webkit).

        * dom/Node.cpp:
        * dom/Node.h:
        (Node):
        * dom/NodeTraversal.cpp:
        * dom/NodeTraversal.h:
        (ElementTraversal):
        (NodeTraversal):
        * html/HTMLLIElement.cpp:
        (WebCore::HTMLLIElement::attach):
        * html/HTMLOListElement.cpp:
        (WebCore::HTMLOListElement::updateItemValues):
        (WebCore::HTMLOListElement::recalculateItemCount):
        * rendering/RenderCounter.cpp:
        (WebCore::previousInPreOrder):
        (WebCore::previousSiblingOrParent):
        (WebCore::parentElement):
        (WebCore::nextInPreOrder):
        * rendering/RenderListItem.cpp:
        (WebCore::enclosingList):
        (WebCore::RenderListItem::nextListItem):
        (WebCore::previousListItem):
        (WebCore::RenderListItem::calcValue):
        (WebCore::RenderListItem::explicitValueChanged):
        (WebCore::previousOrNextItem):
        (WebCore::RenderListItem::updateListMarkerNumbers):
        * rendering/RenderListItem.h:
        (RenderListItem):

1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
2013-03-26  Hajime Morrita  <morrita@google.com>

        remoeveAllEventListeners() should be called to shadow trees
        https://bugs.webkit.org/show_bug.cgi?id=113037

        Reviewed by Dimitri Glazkov.

        Document::removeAllEventListeners() doesn't traverse shadow tree, but we should.
        This change override Element::removeAllEventListeners() so that it cleans its shadow trees up.

        Test: fast/dom/shadow/shadow-tree-listener-clearance.html

        * dom/Element.cpp:
        (WebCore::Element::removeAllEventListeners):
        (WebCore):
        * dom/Element.h:
        (Element):
        * dom/ElementShadow.cpp:
        (WebCore::ElementShadow::removeAllEventListeners): Added.
        (WebCore):
        * dom/ElementShadow.h:
        (ElementShadow):

1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
2013-03-26  Andrei Bucur  <abucur@adobe.com>

        Use DOM ordering for list counts
        https://bugs.webkit.org/show_bug.cgi?id=110352

        Reviewed by Elliott Sprehn.

        Currently the list items ordering is made by traversing the render tree. This gives bad results for:
        - list items flown inside regions because they are not rendered as descendants of their DOM list ancestors.
        - list items matched to insertion points inside a shadow tree. The insertion point may be a child of a
        list so the numbering gets broken.

        To implement correct DOM ordering I've taken into account the fact that pseudo-elements can have display: list-item
        so they should be included when traversing the DOM tree. I've added helper methods on the NodeTraversal
        namespace that should allow easily traversing the tree including the pseudo-elements (e.g. firstChildWithPseudo
        for an element with pseudo-before will return the before PseudoElement). Using these helper methods I've implemented
        pre-order traversal methods aware of the pseudo-elements.
        An effect of this change is how the list items inside shadow tree update their counting. With the patch, if there's
        no <ol> or <ul> element on the ancestor chain of a <li> element to the shadow root, the list node will be considered the
        first parent of the <li> or the shadow root if there is no ancestor.
        The RenderListItem class now makes use of this new method of traversal, replacing the one based on the render tree.
        To simplify the CSS counters implementation, I've changed the traversal functions inside RenderCounter to also make use
        of this method. The CSS counters and the list items now have the same traversal algorithm.

        In later patches I'll add tests that should cover the regions and shadow DOM use cases.
        Tests bug for shadow DOM: https://bugs.webkit.org/show_bug.cgi?id=113193
        Tests bug for regions: https://bugs.webkit.org/show_bug.cgi?id=103975

        Tests: no new tests is this patch; added the correct expectations for fast/lists/positioned-count-crash.html
        and fast/dom/shadow/shadow-and-list-elements.html

        * dom/Node.cpp:
        (WebCore::Node::pseudoAwarePreviousSibling):
        (WebCore):
        (WebCore::Node::pseudoAwareNextSibling):
        (WebCore::Node::pseudoAwareFirstChild):
        (WebCore::Node::pseudoAwareLastChild):
        * dom/Node.h:
        (Node):
        * dom/NodeTraversal.cpp:
        (WebCore):
        (WebCore::NodeTraversal::previousIncludingPseudo):
        (NodeTraversal):
        (WebCore::NodeTraversal::nextIncludingPseudo):
        (WebCore::NodeTraversal::nextIncludingPseudoSkippingChildren):
        * dom/NodeTraversal.h:
        (ElementTraversal):
        (NodeTraversal):
        (WebCore::ElementTraversal::previousIncludingPseudo):
        (WebCore::ElementTraversal::nextIncludingPseudo):
        (WebCore::ElementTraversal::nextIncludingPseudoSkippingChildren):
        (WebCore::ElementTraversal::pseudoAwarePreviousSibling):
        * html/HTMLLIElement.cpp:
        (WebCore::HTMLLIElement::attach):
        * html/HTMLOListElement.cpp:
        (WebCore::HTMLOListElement::updateItemValues):
        (WebCore::HTMLOListElement::recalculateItemCount):
        * rendering/RenderCounter.cpp:
        (WebCore::previousInPreOrder):
        (WebCore::previousSiblingOrParent):
        (WebCore::parentElement):
        (WebCore::nextInPreOrder):
        * rendering/RenderListItem.cpp:
        (WebCore):
        (WebCore::enclosingList):
        (WebCore::RenderListItem::nextListItem):
        (WebCore::previousListItem):
        (WebCore::RenderListItem::calcValue):
        (WebCore::RenderListItem::explicitValueChanged):
        (WebCore::previousOrNextItem):
        (WebCore::RenderListItem::updateListMarkerNumbers):
        * rendering/RenderListItem.h:
        (RenderListItem):

1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
2013-03-26  Allan Sandfeld Jensen  <allan.jensen@digia.com>

        [Qt] Poor rounding in GraphicsContext::drawLineForText
        https://bugs.webkit.org/show_bug.cgi?id=113301

        Reviewed by Jocelyn Turcotte.

        Round the position of the line decoration, so lines on subpixel
        coordinates are not always rounded up.

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::drawLineForText):

1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
2013-03-26  Vsevolod Vlasov  <vsevik@chromium.org>

        Web Inspector: Decorations in several consecutive lines are not moved correctly in DTE.
        https://bugs.webkit.org/show_bug.cgi?id=113296

        Reviewed by Pavel Feldman.

        Separated removing and adding decorations so that moved decorations are not removed when next line is processed.

        * inspector/front-end/DefaultTextEditor.js:
        (WebInspector.TextEditorGutterPanel.prototype.textChanged):

1480
1481
1482
1483
1484
1485
1486
1487
1488
2013-03-26  Yury Semikhatsky  <yurys@chromium.org>

        Remove references to non-chromium entries from WebCore.gypi (part 2)
        https://bugs.webkit.org/show_bug.cgi?id=103124

        Reviewed by Pavel Feldman.

        * WebCore.gypi: removed unused references to gtk, cf, win and mac

1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
2013-03-26  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r146767.
        http://trac.webkit.org/changeset/146767
        https://bugs.webkit.org/show_bug.cgi?id=113295

        Rolling out until nicer fonts / sizes are chosen (Requested by
        pfeldman on #webkit).

        * inspector/front-end/dataGrid.css:
        (.data-grid table):
        (.data-grid td):
        * inspector/front-end/inspector.css:
        (.toolbar-label):
        (body.show-toolbar-icons .toolbar-label):
        (.console-message .bubble):
        (li .status .bubble):
        (.source-frame-breakpoint-message):
        (.soft-context-menu):
        (.drawer-header-close-button):
        * inspector/front-end/inspectorCommon.css:
        (body):
        * inspector/front-end/networkLogView.css:
        (.network-log-grid.data-grid td):
        (.network-log-grid.data-grid.small td):
        * inspector/front-end/tabbedPane.css:
        (.tabbed-pane-header-tab):
        (.tabbed-pane-header-tab-close-button):
        * inspector/front-end/timelinePanel.css:
        (.timeline-tree-item .count):
        (.timeline-records-stats, .storage-application-cache-status, .storage-application-cache-connectivity):
        (.memory-counter-sidebar-info):
        (.memory-counter-value):

1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
2013-03-26  Arpita Bahuguna  <a.bah@samsung.com>

        Unable to insert a paragraph in between some text whose previous sibling is a non-editable block.
        https://bugs.webkit.org/show_bug.cgi?id=113007

        Reviewed by Ryosuke Niwa.

        Unable to insert a line break in between a text that follows a
        non-editable block but is itself contained within an editable
        block.

        While comparing the positions from the start block till the
        insertion position, we should ignore the nodes that do not
        generate a visiblePosition for the position before the node.
        This ultimately results in an assert within comparePositions().

        For this case, the firstChild of the start block is a text
        node with no renderer which would thus not generate a candidate
        position for itself.
        There is also no candidate previous to it, and since
        the position after it lies within a different editable element (root),
        no candidate after it as well.
        Such a point will thus return a null visiblePosition.

        Test: editing/inserting/insert-paragraph-between-text.html

        * editing/InsertParagraphSeparatorCommand.cpp:
        (WebCore::InsertParagraphSeparatorCommand::doApply):
        Added a check to verify the generated visiblePosition (for the
        position before the node) prior to carrying out a comparison with
        the insertion point.

1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
2013-03-26  Ilya Tikhonovsky  <loislo@chromium.org>

        Web Inspector: OverviewGrid. Dragged window may change its width due to accumulating rounding error.
        https://bugs.webkit.org/show_bug.cgi?id=113138

        Reviewed by Pavel Feldman.

        The old version had problem with rounding because it recalculates the window size on each event.
        The new version just calculates the dragging delta and moves the window
        to the new position based on the initial values and the delta.

        * inspector/front-end/OverviewGrid.js:
        (WebInspector.OverviewGrid.Window.prototype._startWindowDragging):
        (WebInspector.OverviewGrid.Window.prototype._windowDragging):
        (WebInspector.OverviewGrid.Window.prototype._onMouseWheel):

1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
2013-03-26  Kent Tamura  <tkent@chromium.org>

        Rename HTMLInputElement::isIndeterminate to Element::shouldAppearIndeterminate
        https://bugs.webkit.org/show_bug.cgi?id=113264

        Reviewed by Kentaro Hara.

        HTMLInputElement had indeterminate() and isIndeterminate(). It's very
        confusing.

        Because indeterminate is a public DOM function and isIndeterminate is
        for CSS and rendering, we rename isIndetermiante to
        shouldAppearIndeterminate. Also, HTMLProgressElement, which support
        :indeterminate pseudo class, should follow it. We add
        shouldAppearIndeterminate to Element.

        No new tests. Just a refactoring.

        * dom/Element.cpp:
        (WebCore::Element::shouldAppearIndeterminate): Added. Returns false.
        * dom/Element.h:
        (Element): Declare shouldAppearIndeterminate.
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::shouldAppearIndeterminate):
        Renamed from isIndeterminate.
        * html/HTMLInputElement.h:
        (HTMLInputElement): Rename isIndeterminate to shouldAppearIndeterminate,
        and overrides Element::shouldAppearIndeterminate.
        * html/HTMLProgressElement.cpp:
        (WebCore::HTMLProgressElement::shouldAppearIndeterminate): Added.
        * html/HTMLProgressElement.h: Add shouldAppearIndeterminate.

        * accessibility/AccessibilityNodeObject.cpp:
        (WebCore::AccessibilityNodeObject::isIndeterminate):
        Use shouldAppearIndeterminate.
        * css/SelectorChecker.cpp:
        (WebCore::SelectorChecker::checkOne): Ditto.
        * css/StyleResolver.cpp:
        (WebCore::StyleResolver::canShareStyleWithControl): Ditto.
        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::isIndeterminate): Ditto.

1613
1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
1624
1625
1626
1627
1628
2013-03-26  Pan Deng  <pan.deng@intel.com>

        Web Inspector: [FlameChart] Make function bar highlighted consistent with cursor.
        https://bugs.webkit.org/show_bug.cgi?id=113266.

        Reviewed by Vsevolod Vlasov.

        In Flamechart, the highlighted function bar is not consistent with cursor sometimes, 
        reason is that time range that converted from cursor position is truncated by floor. 
        Actually float value is expected to compare with function startTime and duration.

        No new tests.

        * inspector/front-end/FlameChart.js:
        (WebInspector.FlameChart.prototype._coordinatesToNodeIndex): Remove floor

1629
1630
1631
1632
1633
1634
1635
1636
1637
1638
1639
1640
1641
1642
1643
1644
1645
1646
1647
1648
1649
2013-03-26  Mihnea Ovidenie  <mihnea@adobe.com>

        [CSSRegions]: Crash accessing offsetParent for contentNodes inside a flow thread
        https://bugs.webkit.org/show_bug.cgi?id=112730

        Reviewed by Levi Weintraub.

        When computing the offsetParent for an element inside a flow thread, do not
        let the algorithm process past the flow thread boundaries, until we figure out
        the proper behavior. When reaching the flow thread, offsetParent will return 0,
        thus preventing the assert while calling toElement inside Element::offsetParent.

        The attached test sets the ground work and will be changed to match the right behavior.
        For now, it makes sure we do not crash or return HTMLDocument as offsetParent for
        elements inside the flow thread.

        Test: fast/regions/offsetParent-in-flow-thread.html

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::offsetParent):

1650
1651
1652
1653
1654
1655
1656
1657
1658
1659
1660
1661
1662
1663
1664
1665
1666
1667
1668
1669
1670
1671
1672
1673
1674
1675
1676
1677
1678
2013-03-26  Dominik Röttsches  <dominik.rottsches@intel.com>

        Remove HarfBuzzShaperBase
        https://bugs.webkit.org/show_bug.cgi?id=112087

        Reviewed by Martin Robinson.

        Folding HarfBuzzShaperBase into HarfBuzzShaper since
        there is no harfbuzz-old vs. harfbuzz-ng distinction anymore.

        No new tests, no change in behavior.

        * GNUmakefile.list.am: Removing HarfBuzzShaperBase.*
        * PlatformEfl.cmake: Removing HarfBuzzShaperBase.*
        * WebCore.gypi: Removing HarfBuzzShaperBase.*
        * platform/graphics/harfbuzz/HarfBuzzShaper.cpp: Folding base class members and methods into HarfBuzzShaper.
        (WebCore::HarfBuzzShaper::HarfBuzzShaper):
        (WebCore::normalizeSpacesAndMirrorChars):
        (WebCore):
        (WebCore::HarfBuzzShaper::setNormalizedBuffer):
        (WebCore::HarfBuzzShaper::isWordEnd):
        (WebCore::HarfBuzzShaper::determineWordBreakSpacing):
        (WebCore::HarfBuzzShaper::setPadding):
        * platform/graphics/harfbuzz/HarfBuzzShaper.h: Folding base class members and methods into HarfBuzzShaper.
        (HarfBuzzShaper):
        (WebCore::HarfBuzzShaper::isCodepointSpace):
        * platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp: Removed.
        * platform/graphics/harfbuzz/HarfBuzzShaperBase.h: Removed.

1679
1680
1681
1682
1683
1684
1685
1686
1687
1688
1689
1690
1691
1692
1693
1694
1695
1696
1697
1698
1699
1700
1701
1702
1703
1704
2013-03-22  Hajime Morrita  <morrita@google.com>

        Listening touch events on ShadowRoot can crash.
        https://bugs.webkit.org/show_bug.cgi?id=113035

        Reviewed by Kentaro Hara.

        TreeScope destructor clears a document reference on ShadowRoot but
        destructors of ContainerNode and Node assumed it being available
        and tried to access it for some cleanup purposes.

        This change extracts such cleanup to Node::willBeDeletedFrom() and
        calls it from ShadowRoot dtor before the document reference gets cleared.

        Test: fast/dom/shadow/shadow-root-touch-listener-crash.html

        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::~ContainerNode): Adopted willBeDeletedFrom()
        * dom/Node.cpp:
        (WebCore::Node::~Node): Adopted willBeDeletedFrom()
        (WebCore::Node::willBeDeletedFrom): Extracted from Node and ContainerNode
        (WebCore):
        * dom/Node.h:
        * dom/ShadowRoot.cpp:
        (WebCore::ShadowRoot::~ShadowRoot): Adopted willBeDeletedFrom()

1705
1706
1707
1708
1709
1710
1711
1712
1713
1714
1715
1716
1717
1718
1719
1720
1721
1722
1723
1724
1725
1726
1727
1728
1729
1730
1731
1732
1733
2013-03-25  Hajime Morrita  <morrita@google.com>

        Custom Elements Refactoring: The name V8CustomElement is confusing.
        https://bugs.webkit.org/show_bug.cgi?id=113165

        Reviewed by Kent Tamura.

        This change moves functions from V8CustomElement to CustomElementHelpers and
        removes V8CustomElement. V8CustomElement is just a heritage of old design
        and no longer makes sense.

        No new tests. No behavior change.

        * WebCore.gypi:
        * bindings/v8/CustomElementHelpers.cpp:
        (WebCore::CustomElementHelpers::createWrapper):
        (WebCore):
        * bindings/v8/CustomElementHelpers.h:
        (CustomElementHelpers):
        (WebCore::CustomElementHelpers::wrap):
        (WebCore):
        (WebCore::CustomElementHelpers::constructorOf):
        * bindings/v8/V8CustomElement.cpp: Removed.
        * bindings/v8/V8CustomElement.h: Removed.
        * bindings/v8/custom/V8CustomElementConstructorCustom.cpp:
        (WebCore::V8CustomElementConstructor::callAsFunctionCallback):
        * dom/make_names.pl:
        (printWrapperFactoryCppFile):

1734
1735
1736
1737
1738
1739
1740
1741
1742
1743
1744
1745
1746
1747
1748
2013-03-25  Eugene Klyuchnikov  <eustas@chromium.org>

        Web Inspector: [Timeline] Records sidebar is clipped.
        https://bugs.webkit.org/show_bug.cgi?id=113177

        Reviewed by Pavel Feldman.

        Analysis: depending on CSS injection order sidebar rule that overwrites
        "bottom" property may win.

        Fix: make timeline-specific rule "important".

        * inspector/front-end/timelinePanel.css:
        (.timeline .sidebar): Make "bottom" value "important".

1749
1750
1751
1752
1753
1754
1755
1756
1757
1758
1759
1760
1761
1762
1763
1764
1765
1766
1767
1768
1769
1770
2013-03-25  Kent Tamura  <tkent@chromium.org>

        Rename ENABLE_INPUT_TYPE_DATETIME
        https://bugs.webkit.org/show_bug.cgi?id=113254

        Reviewed by Kentaro Hara.

        Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
        Actually I'd like to remove the code, but we shouldn't remove it yet
        because we shipped products with it on some platforms.

        * Configurations/FeatureDefines.xcconfig:
        * bindings/generic/RuntimeEnabledFeatures.cpp:
        (WebCore):
        * bindings/generic/RuntimeEnabledFeatures.h:
        (RuntimeEnabledFeatures):
        * css/html.css:
        * html/DateTimeInputType.cpp:
        * html/DateTimeInputType.h:
        * html/InputType.cpp:
        (WebCore::createInputTypeFactoryMap):

1771
1772
1773
1774
1775
1776
1777
1778
1779
1780
1781
1782
1783
1784
1785
1786
1787
1788
1789
1790
1791
1792
1793
1794
1795
1796
1797
2013-03-25  Timothy Hatcher  <timothy@apple.com>

        Make the Web Inspector console work in strict mode with JavaScriptCore.

        https://webkit.org/b/65829
        rdar://problem/11271238

        Reviewed by Oliver Hunt.

        * bindings/js/JSInjectedScriptHostCustom.cpp:
        (WebCore::JSInjectedScriptHost::evaluate):
        Return the evalFunction directly.

        * inspector/InjectedScriptHost.h:
        (WebCore::InjectedScriptHost::evaluateReturnsEvalFunction):
        Added. Return true on JSC and false on V8.

        * inspector/InjectedScriptHost.idl:
        Added evaluateReturnsEvalFunction and change evaluate to an attribute on JSC.

        * inspector/InjectedScriptSource.js:
        (InjectedScript.prototype._evaluateOn): Change from using 'with' statements to creating
        a closure that evaluates the expression. The command line APIs are passed as parameters
        to the closure so they are in scope but not injected. This allows the code evaluated in
        the console to stay in strict mode (if is was already set), or to get strict mode by
        prefixing expressions with 'use strict';.

1798
1799
1800
1801
1802
1803
1804
1805
1806
1807
1808
1809
1810
1811
1812
1813
1814
1815
1816
1817
1818
1819
1820
1821
1822
1823
1824
1825
1826
1827
1828
1829
1830
1831
1832
1833
1834
1835
1836
1837
1838
1839
1840
1841
1842
1843
1844
1845
1846
1847
1848
1849
1850
1851
1852
1853
1854
1855
1856
1857
1858
1859
1860
1861
1862
1863
1864
1865
2013-03-25  Tony Chang  <tony@chromium.org>

        Image alt text not included in plain-text version when copying
        https://bugs.webkit.org/show_bug.cgi?id=11200

        Reviewed by Ryosuke Niwa.

        Add a setting to enable copying image alt text to the clipboard and drag and drop pasteboard.
        This setting is disabled by default, so each port can enable if they want to match IE10 and
        Firefox's behavior.

        Test: editing/pasteboard/copy-image-with-alt-text.html

        * editing/Editor.cpp:
        (WebCore::Editor::cut): Explicitly ask that the selection on the pasteboard as being for the clipboard.
        (WebCore::Editor::copy): Explicitly ask that the selection on the pasteboard as being for the clipboard.
        (WebCore::Editor::selectedText): Add a private version of selectedText() that can choose between having image alt text or not.
        (WebCore::Editor::selectedTextForClipboard): Ask for image alt text if the setting is enabled.
        * editing/Editor.h:
        * editing/TextIterator.cpp:
        (WebCore::TextIterator::TextIterator): Add a bool to keep track of whether or not to emit image alt text.
        (WebCore::TextIterator::handleReplacedElement): If there's alt text, point the iterator to it.
        * editing/TextIterator.h:
        (TextIterator):
        * editing/mac/EditorMac.mm:
        (WebCore::Editor::takeFindStringFromSelection): Use the same text as on the clipboard.
        (WebCore::Editor::writeSelectionToPasteboard): Don't include image alt text since this is
        used by Services.
        (WebCore::Editor::stringSelectionForPasteboard): Don't include image alt text since this is
        used by Services.
        * page/DragController.cpp:
        (WebCore::DragController::startDrag): Use image alt text (matches Firefox).
        * page/Settings.in: Add a setting that disables image alt text by default.
        * platform/Pasteboard.h:
        * platform/blackberry/PasteboardBlackBerry.cpp:
        (WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.
        * platform/chromium/ClipboardChromium.cpp:
        (WebCore::ClipboardChromium::writeRange): Use clipboard text when writing ranges (used by d&d).
        * platform/chromium/PasteboardChromium.cpp:
        (WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.
        * platform/efl/PasteboardEfl.cpp:
        (WebCore::Pasteboard::writeSelection): Update function param.
        * platform/gtk/ClipboardGtk.cpp:
        (WebCore::ClipboardGtk::writeRange): Use clipboard text when writing ranges (used by d&d).
        * platform/gtk/PasteboardGtk.cpp:
        (WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.
        * platform/mac/ClipboardMac.mm:
        (WebCore::ClipboardMac::writeRange): Use clipboard text when writing ranges (used by d&d).
        * platform/mac/PasteboardMac.mm:
        (WebCore::Pasteboard::getStringSelection): Use ShouldSerializeSelectedTextForClipboard to determine whether the selected
        text is for the clipboard or not.
        (WebCore::Pasteboard::writeSelectionForTypes): Pass ShouldSerializeSelectedTextForClipboard through.
        (WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.
        * platform/qt/ClipboardQt.cpp:
        (WebCore::ClipboardQt::writeRange): Use clipboard text when writing ranges (used by d&d).
        * platform/qt/PasteboardQt.cpp:
        (WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.
        * platform/win/ClipboardWin.cpp:
        (WebCore::ClipboardWin::writeRange): Use clipboard text when writing ranges (used by d&d).
        * platform/win/PasteboardWin.cpp:
        (WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.
        * platform/wince/PasteboardWinCE.cpp:
        (WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.
        * platform/wx/PasteboardWx.cpp:
        (WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.
        * rendering/RenderImage.h:
        (WebCore::RenderImage::altText): Add a getter for the alt text.

1866
1867
1868
1869
1870
1871
1872
1873
1874
1875
1876
1877
1878
1879
1880
1881
1882
1883
1884
1885
1886
2013-03-25  Dean Jackson  <dino@apple.com>

        Remove autostart hashing code from WebCore
        https://bugs.webkit.org/show_bug.cgi?id=113242

        Reviewed by Tim Horton.

        Remove PlugInOriginHash and all the related build entries.

        * CMakeLists.txt:
        * GNUmakefile.list.am:
        * Target.pri:
        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.vcxproj/WebCore.vcxproj:
        * WebCore.vcxproj/WebCore.vcxproj.filters:
        * WebCore.xcodeproj/project.pbxproj:
        * html/HTMLPlugInImageElement.cpp:
        * plugins/PlugInOriginHash.cpp: Removed.
        * plugins/PlugInOriginHash.h: Removed.

1887
1888
1889
1890
1891
1892
1893
2013-03-25  Roger Fong  <roger_fong@apple.com>

        Unreviewed. Wrong place to enable RuntimeEnabledFeature for Windows.

        * bindings/generic/RuntimeEnabledFeatures.cpp:
        (WebCore):

1894
1895
1896
1897
1898
1899
1900
1901
1902
1903
1904
1905
1906
1907
1908
1909
1910
1911
1912
1913
1914
1915
2013-03-25  James Robinson  <jamesr@chromium.org>

        [chromium] Support GraphicsLayer::setContentsToSolidColor
        https://bugs.webkit.org/show_bug.cgi?id=104396

        Reviewed by Adrienne Walker.

        This enables and implements the GraphicsLayer::setContentsToSolidColor
        path for Chromium.

        Tested by reftests in compositing/background-color/ and several other
        compositing/ tests.

        * platform/graphics/GraphicsLayer.h:
        (WebCore::GraphicsLayer::supportsBackgroundColorContent):
        * platform/graphics/chromium/GraphicsLayerChromium.cpp:
        (WebCore::GraphicsLayerChromium::setContentsToSolidColor):
        (WebCore):
        * platform/graphics/chromium/GraphicsLayerChromium.h:
        (WebKit):
        (GraphicsLayerChromium):

1916
1917
1918
1919
1920
1921
1922
1923
1924
1925
1926
1927
1928
1929
1930
1931
1932
1933
1934
1935
1936
1937
1938
1939
1940
1941
1942
1943
1944
1945
1946
1947
1948
1949
1950
1951
1952
1953
1954
1955
1956
1957
1958
1959
1960
1961
1962
1963
1964
1965
1966
2013-03-25  Victor Carbune  <vcarbune@chromium.org>

        TextTrack Extension for WebVTT Regions
        https://bugs.webkit.org/show_bug.cgi?id=109820

        Reviewed by Eric Carlson.

        Implemented the TextTrackRegionList and extended TextTrack with
        methods required for proper interaction with TextTrackRegion objects.

        Test: media/track/regions-webvtt/text-track-region-list.html

        * WebCore.gypi: Added files for proper building of TextTrackRegionList.
        * html/track/TextTrack.cpp:
        (WebCore::TextTrack::TextTrack):
        (WebCore):
        (WebCore::TextTrack::ensureTextTrackRegionList): Method for creating a
        TextTrackRegionList associated with the current track, if it does exist
        already.
        (WebCore::TextTrack::regions): Getter for the regions object.
        (WebCore::TextTrack::addRegion): Method for adding a region.
        (WebCore::TextTrack::removeRegion): Method for removing a region.
        * html/track/TextTrack.h:
        (WebCore):
        (TextTrack):
        * html/track/TextTrack.idl: Added methods specific for region handling.
        * html/track/TextTrackRegion.cpp:
        (WebCore::TextTrackRegion::TextTrackRegion): Initialized the track member variable.
        (WebCore::TextTrackRegion::setTrack): Added internal setter for the track attribute.
        (WebCore):
        (WebCore::TextTrackRegion::updateParametersFromRegion): Method to copy the parameters
        from a different region object.
        * html/track/TextTrackRegion.h: Added track member variable and copy method.
        (WebCore::TextTrackRegion::track): Getter retrieves now the member variable.
        (TextTrackRegion):
        * html/track/TextTrackRegionList.cpp: Implemented methods required by the IDL.
        (WebCore):
        (WebCore::TextTrackRegionList::TextTrackRegionList):
        (WebCore::TextTrackRegionList::length):
        (WebCore::TextTrackRegionList::item):
        (WebCore::TextTrackRegionList::getRegionById):
        (WebCore::TextTrackRegionList::add):
        (WebCore::TextTrackRegionList::remove):
        (WebCore::TextTrackRegionList::clear):
        * html/track/TextTrackRegionList.h:
        (WebCore):
        (TextTrackRegionList):
        (WebCore::TextTrackRegionList::create):
        (WebCore::TextTrackRegionList::~TextTrackRegionList):
        * html/track/TextTrackRegionList.idl: IDL defined by the specification.

1967
1968
1969
1970
1971
1972
1973
1974
1975
1976
1977
1978
1979
1980
1981
1982
1983
1984
1985
1986
1987
1988
1989
1990
1991
1992
1993
1994
1995
1996
1997
1998
1999
2013-03-25  Dean Jackson  <dino@apple.com>

        Cleanup plugin snapshotting autostart decision making
        https://bugs.webkit.org/show_bug.cgi?id=113231

        Reviewed by Tim Horton.

        Move the code that creates a hash of plugin origin info
        out of WebCore. All WebCore needs to do now is simply ask its
        host layer whether or not a tuple of (pluginOrigin, pageOrigin, mimeType)
        should autostart or not.

        As a drive-by, the code in subframeLoaderWillCreatePlugIn was not quite
        restarting properly when the displayState was Restarting or
        RestartingWithPendingMouseClick. It still worked most of the time, but usually
        because the code ran soon after a mouse click. Now it should be explicit and
        also allowed us to be more clear about snapshotting at the end of the method.

        * html/HTMLPlugInElement.h: No more pluginOriginHash().
        * html/HTMLPlugInImageElement.cpp:
        (WebCore::addPlugInsFromNodeListMatchingPlugInOrigin): Change signature to accept the tuple
            described above, and compare strings rather than hashes.
        (WebCore::HTMLPlugInImageElement::userDidClickSnapshot): Tell host layer the origin
            info rather than hash info.
        (WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Remember the url that
            the plugin was loaded from. Make some of the logging messages more clear. Test for
            plugin and page origin rather than hash.
        * html/HTMLPlugInImageElement.h:
        (WebCore::HTMLPlugInImageElement::loadedUrl): New loadedURL member function.
        * page/PlugInClient.h:
        (PlugInClient): Change signature of virtual class to accept origin and mimeType info
            rather than hash.

2000
2001
2002
2003
2004
2005
2006
2007
2008
2009
2010
2013-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r146793.
        http://trac.webkit.org/changeset/146793
        https://bugs.webkit.org/show_bug.cgi?id=113248

        Fix did not work (Requested by rfong on #webkit).

        * bindings/scripts/preprocessor.pm:
        (applyPreprocessor):

2011
2012
2013
2014
2015
2016
2017
2018
2019
2020
2021
2022
2023
2024
2025
2026
2027
2028
2029
2030
2031
2032
2033
2034
2035
2036
2037
2038
2039
2040
2041
2042
2043
2044
2045
2046
2047
2048
2049
2050
2051
2052
2053
2054
2055
2013-03-25  Brandon Jones  <bajones@google.com>

        WEBGL_compressed_texture_pvrtc needs implementation
        https://bugs.webkit.org/show_bug.cgi?id=110497

        Reviewed by Kenneth Russell.

        Test: webgl/conformance/extensions/webgl-compressed-texture-pvrtc.html

        Exposes the WEBGL_compressed_texture_pvrtc extension, but is unverified since no desktop hardware supports
        the format that I am aware of. Should enable mobile ports to expose the format, however.

        * CMakeLists.txt:
        * DerivedSources.make:
        * DerivedSources.pri:
        * GNUmakefile.list.am:
        * Target.pri:
        * WebCore.gypi:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSWebGLRenderingContextCustom.cpp:
        (WebCore::toJS):
        * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
        (WebCore::toV8Object):
        * html/canvas/WebGLCompressedTexturePVRTC.cpp: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
        (WebCore):
        (WebCore::WebGLCompressedTexturePVRTC::WebGLCompressedTexturePVRTC):
        (WebCore::WebGLCompressedTexturePVRTC::~WebGLCompressedTexturePVRTC):
        (WebCore::WebGLCompressedTexturePVRTC::getName):
        (WebCore::WebGLCompressedTexturePVRTC::create):
        (WebCore::WebGLCompressedTexturePVRTC::supported):
        * html/canvas/WebGLCompressedTexturePVRTC.h: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
        (WebCore):
        (WebGLCompressedTexturePVRTC):
        * html/canvas/WebGLCompressedTexturePVRTC.idl: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
        * html/canvas/WebGLExtension.h:
        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore):
        (WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):
        (WebCore::WebGLRenderingContext::getExtension):
        (WebCore::WebGLRenderingContext::getSupportedExtensions):
        (WebCore::WebGLRenderingContext::validateCompressedTexFuncData):
        * html/canvas/WebGLRenderingContext.h:
        (WebCore):
        (WebGLRenderingContext):

2056
2057
2058
2059
2060
2061
2062
2063
2064
2065
2013-03-25  Roger Fong  <roger_fong@apple.com>

        Enable CSS_REGIONS and CSS_EXCLUSIONS.
        https://bugs.webkit.org/show_bug.cgi?id=87519

        Reviewed by Timothy Horton.

        * bindings/generic/RuntimeEnabledFeatures.cpp:
        (WebCore):

2066
2067
2068
2069
2070
2071
2072
2073
2074
2075
2076
2077
2078
2079
2080
2013-03-25  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>

        Remove unused code from Frame class destructor
        https://bugs.webkit.org/show_bug.cgi?id=113181

        Reviewed by Alexey Proskuryakov.

        No new tests. No new functionality.

        * page/Frame.cpp:
        (WebCore::Frame::~Frame):

            Removed the code which could never have been executed
            as m_view had been set to '0'.

2081
2082
2083
2084
2085
2086
2087
2088
2089
2090
2091
2092
2013-03-25  Eric Seidel  <eric@webkit.org>

        Incorrect parsing due to hash collision
        https://bugs.webkit.org/show_bug.cgi?id=113235

        Reviewed by Adam Barth.

        Test: fast/parser/tag-hash-collision.html

        * html/parser/HTMLIdentifier.cpp:
        (WebCore::HTMLIdentifier::findIndex):

2093
2094
2095
2096
2097
2098
2099
2100
2101
2102
2103
2104
2013-03-25  Adenilson Cavalcanti  <cavalcantii@gmail.com>

        Compile without SVG will fail
        https://bugs.webkit.org/show_bug.cgi?id=113234

        Reviewed by Timothy Hatcher.

        Only make the cast to SVGStyleElement if we have SVG support built.

        * inspector/InspectorCSSAgent.cpp:
        (WebCore::InspectorCSSAgent::viaInspectorStyleSheet):

2105
2106
2107
2108
2109
2110
2111
2112
2113
2114
2115
2116
2117
2118
2119
2120
2013-03-25  Patrick Gansterer  <paroga@webkit.org>

        Enable STORE_FONT_CUSTOM_PLATFORM_DATA for all platforms
        https://bugs.webkit.org/show_bug.cgi?id=108438

        Reviewed by Andreas Kling.

        Remove the conditional code so it is turned on for all platforms.

        * loader/cache/CachedFont.cpp:
        (WebCore::CachedFont::~CachedFont):
        (WebCore::CachedFont::ensureCustomFontData):
        (WebCore::CachedFont::platformDataFromCustomData):
        (WebCore::CachedFont::allClientsRemoved):
        (WebCore::CachedFont::reportMemoryUsage):

2121
2122
2123
2124
2125
2126
2127
2128
2129
2130
2131
2132
2133
2134
2135
2136
2137
2138
2013-03-25  Eric Carlson  <eric.carlson@apple.com>

        REGRESSION(r146380): media/track/track-user-preferences.html
        https://bugs.webkit.org/show_bug.cgi?id=113083

        Reviewed by Jer Noble.

        Ignore track change notifications triggered by automatic track selection so the 
        configuration is not changed.

        No new tests, this fixes an existing test.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::configureTextTrackGroup): Clear m_processingPreferenceChange after all
            track configuration is finished.
        (WebCore::HTMLMediaElement::configureTextTrackDisplay): Do nothing if m_processingPreferenceChange
            is true.

2139
2140
2141
2142
2143
2144
2145
2146
2147
2013-03-25  Martin Robinson  <mrobinson@igalia.com>

        [GTK] [gyp] Build the final piece of WebCore
        https://bugs.webkit.org/show_bug.cgi?id=113216

        Reviewed by Nico Weber.

        * WebCore.gyp/WebCoreGTK.gyp: Add the rest of the WebCore source files to the WebCore build target.

2148
2149
2150
2151
2152
2153
2154
2155
2156
2013-03-25  Martin Robinson  <mrobinson@igalia.com>

        [GTK] [gyp] Adding support for building WebCore rendering
        https://bugs.webkit.org/show_bug.cgi?id=113213

        Reviewed by Gustavo Noronha Silva.

        * WebCore.gyp/WebCoreGTK.gyp: Build the rendering directory into a shared library.

2157
2158
2159
2160
2161
2162
2163
2164
2165
2166
2167
2168
2169
2170
2171
2172
2173
2174
2175
2176
2013-03-25  Tony Chang  <tony@chromium.org>

        Remove TextIterator argumentless constructor
        https://bugs.webkit.org/show_bug.cgi?id=113226

        Reviewed by Ryosuke Niwa.

        The TextIterator argumentless constructors are never used and wouldn't be useful
        since you can't specify a range.

        No new tests, removing dead code. There should be no behavior change.

        * editing/TextIterator.cpp: Remove constructors.
        * editing/TextIterator.h:
        (TextIterator):
        (SimplifiedBackwardsTextIterator):
        (CharacterIterator):
        (BackwardsCharacterIterator):
        (WordAwareIterator):

2177
2178
2179
2180
2181
2182
2183
2184
2185
2186
2187
2188
2189
2190
2013-03-25  Brandon Jones  <bajones@chromium.org>

        Enabled canvas.getContext("webgl") on Desktop Chrome
        https://bugs.webkit.org/show_bug.cgi?id=113079

        Reviewed by Dean Jackson.

        Test: fast/canvas/webgl/webgl-unprefixed-context-id.html

        * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
        (WebCore::V8HTMLCanvasElement::getContextMethodCustom):
        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::getContext):

2191
2192
2193
2194
2195
2196
2197
2013-03-25  Roger Fong  <roger_fong@apple.com>

        Unreviewed. Remove some suspicious looking code in an attempt to fix EWS bots.

        * bindings/scripts/preprocessor.pm:
        (applyPreprocessor):

2198
2199
2200
2201
2202
2203
2204
2205
2206
2207
2208
2013-03-25  Martin Robinson  <mrobinson@igalia.com>

        [GTK] [gyp] Add support for building the platform directory
        https://bugs.webkit.org/show_bug.cgi?id=113212

        Reviewed by Nico Weber.

        * WebCore.gyp/WebCoreGTK.gyp: Add support for building the platform directory including
        two libraries, one for platform and one for geometry files. This follows the approach
        of Chromium.

2209
2210
2211
2212
2213
2214
2215
2216
2217
2218
2219
2220
2221
2222
2223
2224
2225
2226
2013-03-25  Jochen Eisinger  <jochen@chromium.org>

        Swap both the error and change event queue before processing fullscreen events
        https://bugs.webkit.org/show_bug.cgi?id=113194

        Reviewed by Jer Noble.

        While processing the change events, not only new change events but
        also new error events might get generated. However, for the timer, we
        should only process preexisting events.

        This is covered by fullscreen/full-screen-restrictions.html which times
        out depending on the delay between requesting fullscreen and granting
        fullscreen.

        * dom/Document.cpp:
        (WebCore::Document::fullScreenChangeDelayTimerFired):

2227
2228
2229
2230
2231
2232
2233
2234
2235
2236
2237
2238
2239
2240
2241
2242
2243
2244
2245
2246
2247
2248
2249
2250
2251
2252
2253
2254
2255
2256
2257
2258
2259
2260
2261
2262
2263
2264
2265
2266
2267
2268
2269
2270
2271
2272
2273
2274
2275
2276
2277
2278
2279
2280
2281
2282
2283
2284
2285
2286
2287
2288
2289
2290
2291
2292
2293
2294
2295
2296
2297
2298
2299
2300
2301
2302
2303
2304
2013-03-25  Marja Hölttä  <marja@chromium.org>

        [V8] Generate specialized callbacks for the main world
        https://bugs.webkit.org/show_bug.cgi?id=112430

        Reviewed by Kentaro Hara.

        The new specialized bindings will be faster, because they don't need to
        do the "main world, isolated world or a worker" check, but can right
        away assume that we're in the main world.

        This patch generates main world bindings for getters and setters for a
        small amount of frequently used functions / functions used by Dromaeo.

        Added tests to TestObj.idl and updated bindings tests.

        * bindings/scripts/CodeGeneratorV8.pm:
        (GenerateOverloadedFunction):
        (GenerateFunctionCallback):
        (GenerateFunction):
        (GenerateParametersCheck):
        (GenerateSingleConstructorCallback):
        (GenerateNonStandardFunction):
        (GenerateImplementation):
        (GenerateFunctionCallString):
        * bindings/scripts/test/TestObj.idl:
        * bindings/scripts/test/V8/V8Float64Array.cpp:
        (WebCore):
        * bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
        (WebCore):
        * bindings/scripts/test/V8/V8TestEventTarget.cpp:
        (WebCore):
        * bindings/scripts/test/V8/V8TestInterface.cpp:
        (WebCore):
        * bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
        (WebCore):
        * bindings/scripts/test/V8/V8TestObj.cpp:
        (WebCore::TestObjV8Internal::perWorldReadOnlyAttributeAttrGetter):
        (TestObjV8Internal):
        (WebCore::TestObjV8Internal::perWorldReadOnlyAttributeAttrGetterCallback):
        (WebCore::TestObjV8Internal::perWorldReadOnlyAttributeAttrGetterForMainWorld):
        (WebCore::TestObjV8Internal::perWorldReadOnlyAttributeAttrGetterCallbackForMainWorld):
        (WebCore::TestObjV8Internal::perWorldAttributeAttrGetter):
        (WebCore::TestObjV8Internal::perWorldAttributeAttrGetterCallback):
        (WebCore::TestObjV8Internal::perWorldAttributeAttrGetterForMainWorld):
        (WebCore::TestObjV8Internal::perWorldAttributeAttrGetterCallbackForMainWorld):
        (WebCore::TestObjV8Internal::perWorldAttributeAttrSetter):
        (WebCore::TestObjV8Internal::perWorldAttributeAttrSetterCallback):
        (WebCore::TestObjV8Internal::perWorldAttributeAttrSetterForMainWorld):
        (WebCore::TestObjV8Internal::perWorldAttributeAttrSetterCallbackForMainWorld):
        (WebCore::TestObjV8Internal::perWorldMethodMethod):
        (WebCore::TestObjV8Internal::perWorldMethodMethodForMainWorld):
        (WebCore::TestObjV8Internal::perWorldMethodMethodCallback):
        (WebCore::TestObjV8Internal::perWorldMethodMethodCallbackForMainWorld):
        (WebCore::TestObjV8Internal::overloadedPerWorldMethod1Method):
        (WebCore::TestObjV8Internal::overloadedPerWorldMethod1MethodForMainWorld):
        (WebCore::TestObjV8Internal::overloadedPerWorldMethod2Method):
        (WebCore::TestObjV8Internal::overloadedPerWorldMethod2MethodForMainWorld):
        (WebCore::TestObjV8Internal::overloadedPerWorldMethodMethod):
        (WebCore::TestObjV8Internal::overloadedPerWorldMethodMethodForMainWorld):
        (WebCore::TestObjV8Internal::overloadedPerWorldMethodMethodCallback):
        (WebCore::TestObjV8Internal::overloadedPerWorldMethodMethodCallbackForMainWorld):
        (WebCore):
        * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
        (WebCore):
        * bindings/scripts/test/V8/V8TestTypedefs.cpp:
        (WebCore):
        * bindings/v8/V8DOMConfiguration.cpp:
        (WebCore::V8DOMConfiguration::batchConfigureCallbacks):
        (WebCore::V8DOMConfiguration::configureTemplate):
        * bindings/v8/V8DOMConfiguration.h:
        (BatchedMethod):
        (V8DOMConfiguration):
        * dom/Document.idl:
        * dom/Element.idl:
        * dom/Node.idl:
        * page/DOMWindow.idl:

2305
2306
2307
2308
2309
2310
2311
2312
2313
2314
2315
2316
2317
2318
2319
2320
2321
2013-03-25  Daniel Cheng  <dcheng@chromium.org>

        Don't allow drags to start after a mouse press that creates a context menu
        https://bugs.webkit.org/show_bug.cgi?id=112079

        Reviewed by Tony Chang.

        This appears to be the intent of the original code anyway (the comments in the corresponding
        context menu handlers indicate that they set m_mousePressed to false in order to suppress
        drags from starting). Since exact platform behavior differs quite a bit in this area, this
        will also make the behavior more consistent across different WebKit implementations.

        Manually testable using context-menu-during-drag-selection.html.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMouseDraggedEvent):

2322
2323
2324
2325
2326
2327
2328
2329
2330
2331
2332
2333
2334
2335
2013-03-25  Vsevolod Vlasov  <vsevik@chromium.org>

        Web Inspector: [Regression] Provisional breakpoints are not shown on reload.
        https://bugs.webkit.org/show_bug.cgi?id=113210

        Reviewed by Pavel Feldman.

        * inspector/front-end/BreakpointManager.js:
        (WebInspector.BreakpointManager.prototype._restoreBreakpoints):
        (WebInspector.BreakpointManager.prototype._projectWillReset.get for):
        (WebInspector.BreakpointManager.prototype._projectWillReset):
        (WebInspector.BreakpointManager.prototype._breakpointResolved):
        * inspector/front-end/utilities.js:

2336
2337
2338
2339
2340
2341
2342
2343
2344
2345
2346
2347
2013-03-25  Sergey Ryazanov  <serya@chromium.org>

        Web Inspector: Remove console warnings for *_ prefixed CSS styles
        https://bugs.webkit.org/show_bug.cgi?id=113175

        Reviewed by Pavel Feldman.

        Added separate error message for syntax CSS error in declaration list when no property detected.
        Added filter for messages starting with '*'.

        * css/CSSGrammar.y.in:

2348
2349
2350
2351
2352
2353
2354
2355
2356
2357
2358
2359
2360
2361
2362
2363
2364
2365
2366
2367
2368
2369
2370
2371
2013-03-25  Alexis Hetu  <sugoi@chromium.org>

        Integration of the Skia displacement mapping into WebKit
        https://bugs.webkit.org/show_bug.cgi?id=112927

        Reviewed by Stephen White.

        Added displacement mapping to effect-reference.html and
        effect-reference-hw.html

        * WebCore.gypi:
        * platform/graphics/filters/FEDisplacementMap.h:
        (FEDisplacementMap):
        Adding Skia specific declarations
        * platform/graphics/filters/skia/FEDisplacementMapSkia.cpp: Added.
        (WebCore):
        (WebCore::toSkiaMode):
        Provides conversion between the WebKit displacement mapping mode and
        the Skia displacement mapping mode
        (WebCore::FEDisplacementMap::platformApplySkia):
        Displacement through the Skia API. (Accelerated only for now)
        (WebCore::FEDisplacementMap::createImageFilter):
        Displacement image filter creation through the Skia API.

2372
2373
2374
2375
2376
2377
2378
2379
2380
2381
2382
2383
2384
2385
2386
2387
2388
2389
2390
2391
2013-03-25  Vladislav Kaznacheev  <kaznacheev@chromium.org>

        Web Inspector: Graduate some new Inspector APIs to public
        https://bugs.webkit.org/show_bug.cgi?id=113176

        Reviewed by Pavel Feldman.

        Summary of changes:
            DOM.highlightNode.nodeId: required parameter is now optional
            Input: domain has been added
            Runtime.enable: command has been added
            Runtime.executionContextCreated: event has been added
            Page.clearGeolocationOverride: command has been added
            Page.setGeolocationOverride: command has been added
            Page.captureScreenshot: command has been added
            Debugger.setBreakpointByUrl.locations: optional response parameter is now required


        * inspector/Inspector.json:

2392
2393
2394
2395
2396
2397
2398
2399
2400
2013-03-25  Andrey Kosyakov  <caseq@chromium.org>

        Web Inspector: [Timeline] set glue records mode off by default
        https://bugs.webkit.org/show_bug.cgi?id=113189

        Reviewed by Pavel Feldman.

        * inspector/front-end/TimelinePanel.js: /glueRecordsSetting/s/true/false/

2401
2402
2403
2404
2405
2406
2407
2408
2409
2410
2411
2412
2413
2414
2415
2416
2417
2418
2013-03-25  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        [EFL] Fix build break when media source is enabled
        https://bugs.webkit.org/show_bug.cgi?id=113143

        Unreviewed. Build error needs to be fixed in order to start to implement
        media source functionality.

        * CMakeLists.txt:
        * platform/efl/MIMETypeRegistryEfl.cpp:
        (WebCore):
        (WebCore::MIMETypeRegistry::isSupportedMediaSourceMIMEType):
        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore):
        (WebCore::MediaPlayerPrivateGStreamer::load):
        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
        (MediaPlayerPrivateGStreamer):

2419
2420
2421
2422
2423
2424
2425
2426
2427
2428
2013-03-25  Vsevolod Vlasov  <vsevik@chromium.org>

        Web Inspector: Toggling breakpoint with shortcut should be freezed as well while editing.
        https://bugs.webkit.org/show_bug.cgi?id=113188

        Reviewed by Pavel Feldman.

        * inspector/front-end/JavaScriptSourceFrame.js:
        (WebInspector.JavaScriptSourceFrame.prototype.toggleBreakpointOnCurrentLine):

2429
2430
2431
2432
2433
2434
2435
2436
2437
2438
2013-03-25  Vsevolod Vlasov  <vsevik@chromium.org>

        Web Inspector: Remove unneeded code from JavaScriptSourceFrame.
        https://bugs.webkit.org/show_bug.cgi?id=113182

        Reviewed by Pavel Feldman.

        * inspector/front-end/JavaScriptSourceFrame.js:
        (WebInspector.JavaScriptSourceFrame):

2439
2440
2441
2442
2443
2444
2445
2446
2447
2448
2449
2450
2451
2452
2453
2454
2455
2456
2457
2458
2459
2460
2461
2462
2463
2464
2465
2466
2467
2468
2469
2013-03-25  Alexei Filippov  <alph@chromium.org>

        Web Inspector: Fonts refactoring
        https://bugs.webkit.org/show_bug.cgi?id=113047

        Reviewed by Pavel Feldman.

        Unify fonts usage across inspector.
        Make inspector default font depend on platform.

        * inspector/front-end/dataGrid.css:
        (.data-grid table):
        (.data-grid td):
        * inspector/front-end/inspector.css:
        (.toolbar-label):
        (body.show-toolbar-icons .toolbar-label):
        (.console-message .bubble):
        (li .status .bubble):
        (.source-frame-breakpoint-message):
        (.soft-context-menu):
        * inspector/front-end/inspectorCommon.css:
        (body):
        * inspector/front-end/networkLogView.css:
        (.network-log-grid.data-grid td):
        (.network-log-grid.data-grid.small td):
        * inspector/front-end/tabbedPane.css:
        (.tabbed-pane-header-tab):
        (select.tabbed-pane-header-tabs-drop-down-select):
        * inspector/front-end/timelinePanel.css:
        (.memory-counter-value):

2470
2471
2472
2473
2474
2475
2476
2477
2478
2479
2480
2481
2482
2483
2484
2485
2486
2487
2488
2489
2490
2491
2492
2493
2494
2495
2496
2497
2498
2013-03-25  Vladislav Kaznacheev  <kaznacheev@chromium.org>

        Web Inspector: Use generate-inspector-protocol-version to list valid public API changes
        https://bugs.webkit.org/show_bug.cgi?id=113148

        Added --show-changes command line option.
        Used existing compare_schemas method to do a reverse compare.
        Fixed a number of small problems (missing domain name in the message,
        incorrect error messages for command parameters).

        Reviewed by Pavel Feldman.

        * inspector/generate-inspector-protocol-version:
        (named_list_to_map):
        (removed):
        (required):
        (compare_schemas):
        (compare_domains):
        (compare_commands):
        (compare_events):
        (compare_params_list):
        (compare_types):
        (self_test):
        (self_test.create_test_schema_1):
        (self_test.create_test_schema_2):
        (self_test.is_subset):
        (self_test.errors_match):
        (main):

2499
2500
2501
2502
2503
2504
2505
2506
2507
2508
2509
2510
2511
2512
2513
2514
2013-03-25  Alec Flett  <alecflett@chromium.org>

        Support Quota API in Workers
        https://bugs.webkit.org/show_bug.cgi?id=112972

        Reviewed by Adam Barth.

        Tests: fast/workers/shared-worker-storagequota-query-usage.html
               fast/workers/worker-storagequota-query-usage.html

        * Modules/quota/WorkerNavigatorStorageQuota.cpp: Added.
        * Modules/quota/WorkerNavigatorStorageQuota.h: Added.
        * Modules/quota/WorkerNavigatorStorageQuota.idl: Added.
        * WebCore.gypi: Add entries for WorkerNavigatorStorageQuota.
        * page/WorkerNavigator.h: Add a Navigator supplement that extends the worker navigator.

2515
2516
2517
2518
2519
2520
2521
2522
2523
2524
2525
2526
2527
2528
2529
2530
2531
2532
2533
2534
2535
2536
2537
2538
2013-03-25  Mike West  <mkwst@chromium.org>

        CSP 1.1: Rename SecurityPolicyViolationEvent::sourceURL to ::sourceFile.
        https://bugs.webkit.org/show_bug.cgi?id=113033

        Reviewed by Jochen Eisinger.

        Bringing our experimental implementation into line with the spec, which
        has landed on the de facto standard name Gecko has been sending out for
        years and years.

        Spec: https://dvcs.w3.org/hg/content-security-policy/rev/e44f4003e158
        Thread: http://lists.w3.org/Archives/Public/public-webappsec/2013Mar/0087.html

        * dom/SecurityPolicyViolationEvent.h:
        (SecurityPolicyViolationEventInit):
        (WebCore::SecurityPolicyViolationEvent::sourceFile):
        (WebCore::SecurityPolicyViolationEvent::SecurityPolicyViolationEvent):
        (SecurityPolicyViolationEvent):
        * dom/SecurityPolicyViolationEvent.idl:
        * page/ContentSecurityPolicy.cpp:
        (WebCore::gatherSecurityPolicyViolationEventData):
            s/sourceURL/sourceFile/

2539
2540
2541
2542
2543
2544
2545
2546
2547
2548
2549
2550
2551
2552
2553
2554
2555
2556
2557
2558
2559
2560
2561
2562
2563
2564
2565
2566
2567
2568
2569
2570
2571
2572
2013-03-25  Michelangelo De Simone  <michelangelo@webkit.org>

        [CSS Filters] Using negative drop-shadow radius values has slow performance
        https://bugs.webkit.org/show_bug.cgi?id=107848

        Setting negative blur radius values in drop-shadow() and box-shadow() led to
        significant rendering performance loss. The invalid value overflowed and the
        embedder became unresponsive for few seconds.
        This impacted SVG too (SVGFEDropShadow and SVGFEGaussianBlur).

        Reviewed by Dirk Schulze.

        Tests: css3/filters/effect-drop-shadow-negative-radius.html
               fast/box-shadow/box-shadow-parsing-invalid.html
               svg/filters/feDropShadow-negative-deviation-expected.svg
               svg/filters/feDropShadow-negative-deviation.svg
               svg/filters/feDropShadow-zero-deviation.svg
               svg/filters/feGaussianBlur-negative-deviation-expected.svg
               svg/filters/feGaussianBlur-negative-deviation.svg
               svg/filters/feGaussianBlur-zero-deviation.svg

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseShadow): Negative values are skipped during parsing: as per
        CSS Background and Borders specs, negative values shall not be allowed.
        * platform/graphics/filters/FEGaussianBlur.cpp:
        (WebCore::FEGaussianBlur::calculateUnscaledKernelSize): Added "non-negative" assertion for
        negative deviations.
        * svg/SVGFEDropShadowElement.cpp:
        (WebCore::SVGFEDropShadowElement::build): If a negative standard deviation is encountered, don't
        build the filter and returns earlier, this avoids unnecessary calls: FEGaussianBlur is not being
        created with wrong and potentially overflowing values.
        * svg/SVGFEGaussianBlurElement.cpp:
        (WebCore::SVGFEGaussianBlurElement::build): Ditto.

2573
2574
2575
2576
2577
2578
2579
2580
2581
2582
2583
2584
2013-03-25  Allan Sandfeld Jensen  <allan.jensen@digia.com>

        [Qt] REGRESSION(r146630): 8 text related test asserts on debug builds
        https://bugs.webkit.org/show_bug.cgi?id=113179

        Reviewed by Jocelyn Turcotte.

        Test if range.start is within the valid range before testing the value at that point.

        * platform/graphics/qt/FontQt.cpp:
        (WebCore::Font::initFormatForTextLayout):

2585
2586
2587
2588
2589
2590
2591
2592
2593
2594
2013-03-25  Alexander Pavlov  <apavlov@chromium.org>

        Web Inspector: Properly handle the rule addition to an XML or SVG document.
        https://bugs.webkit.org/show_bug.cgi?id=113185

        Reviewed by Pavel Feldman.

        * inspector/InspectorCSSAgent.cpp:
        (WebCore::InspectorCSSAgent::viaInspectorStyleSheet):

2595
2596
2597
2598
2599
2600
2601
2602
2603
2604
2605
2606
2607
2608
2609
2610
2611
2612
2613
2614
2615
2616
2617
2618
2619
2620
2621
2013-03-25  Peter Rybin  <prybin@chromium.org>

        Web Inspector: support changing local variables in frontend
        https://bugs.webkit.org/show_bug.cgi?id=112470

        Reviewed by Yury Semikhatsky.

        ScopeRef type is added to RemoteObject and setPropertyValue is patched accordingly.

        Test: inspector/debugger/debugger-change-variable.html

        * inspector/front-end/DebuggerModel.js:
        (WebInspector.DebuggerModel.CallFrame.prototype.get id):
        * inspector/front-end/ObjectPropertiesSection.js:
        (WebInspector.FunctionScopeMainTreeElement.prototype.onpopulate.didGetDetails):
        (WebInspector.FunctionScopeMainTreeElement.prototype.onpopulate):
        * inspector/front-end/RemoteObject.js:
        (WebInspector.RemoteObject):
        (WebInspector.RemoteObject.fromScopePayload):
        (WebInspector.RemoteObject.prototype.):
        (WebInspector.RemoteObject.prototype.setPropertyValue):
        (WebInspector.RemoteObject.prototype.setVariableValueCallback):
        (WebInspector.RemoteObject.prototype._setDeclarativeVariableValue):
        (WebInspector.ScopeRef):
        * inspector/front-end/ScopeChainSidebarPane.js:
        (WebInspector.ScopeChainSidebarPane.prototype.update):

2622
2623
2624
2625
2626
2627
2628
2629
2630
2631
2632
2633
2634
2635
2636
2637
2638
2639
2640
2641
2642
2643
2644
2645
2646
2647
2648
2649
2650
2651
2652
2653
2654
2655
2656
2657
2658
2013-03-25  Mike West  <mkwst@chromium.org>

        CSP 1.1: Strip URLs in SecurityPolicyViolationEvents, just as we do for POSTed violation reports.
        https://bugs.webkit.org/show_bug.cgi?id=113039

        Reviewed by Jochen Eisinger.

        I'd originally assumed that we didn't need to be quite so careful when
        handing URLs to JavaScript via SecurityPolicyViolationEvents. This was
        a mistake. Cross-origin URLs aren't accessible to JavaScript currently
        and there's no reason that we should begin exposing them via an event.

        This patch extracts the stripping logic from the existing reports into
        stripURLForUseInReport(), and uses that new method when populating the
        event and report objects.

        Relatedly, we were doing the wrong thing with 'file:' URLs, which this
        patch made clear. Now they're treated the same as 'data:' et al.

        Spec: https://dvcs.w3.org/hg/content-security-policy/rev/45f6ccaba0ef

        Tests: http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image-from-script.html
               http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image.html
               http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-from-script.html
               http/tests/security/contentSecurityPolicy/report-blocked-file-uri.html

        * page/ContentSecurityPolicy.cpp:
        (WebCore::stripURLForUseInReport):
            Extract the logic from blockedURI out into a reusable method:
            cross-origin URLs are stripped down to the ASCII serialization of
            their origin, and non-heirarchical (and 'file:') URLs are stripped
            down to the ASCII serialization of their protocol.
        (WebCore::gatherSecurityPolicyViolationEventData):
        (WebCore::ContentSecurityPolicy::reportViolation):
            Use ::stripURLForUseInReport for blockedURL and sourceFile
            attributes in these two methods.

2659
2660
2661
2662
2663
2664
2665
2666
2667
2668
2669
2670
2671
2672
2673
2674
2675
2676
2677
2678
2013-03-25  Eugene Klyuchnikov  <eustas@chromium.org>

        Web Inspector: Fix JSDocs.
        https://bugs.webkit.org/show_bug.cgi?id=113025

        Reviewed by Pavel Feldman.

        Next version of JS compiler finds more inconsistencies
        and ambiguous declarations.
        Some of them are resolved in this patch.

        * inspector/InjectedScriptSource.js: Fix JSDocs.
        * inspector/front-end/ConsoleModel.js: Ditto.
        * inspector/front-end/CookieParser.js: Ditto.
        * inspector/front-end/FileContentView.js: Ditto.
        * inspector/front-end/HeapSnapshotView.js: Ditto.
        * inspector/front-end/IndexedDBModel.js: Ditto.
        * inspector/front-end/ProfilesPanelDescriptor.js: Ditto.
        * inspector/front-end/utilities.js: Ditto.

2679
2680
2681
2682
2683
2684
2685
2686
2687
2688
2689
2690
2691
2692
2693
2694
2695
2696
2697
2698
2699
2013-03-25  Mike West  <mkwst@chromium.org>

        Cleanup: Tiny nits in ContentSecurityPolicy::reportViolation.
        https://bugs.webkit.org/show_bug.cgi?id=112784

        Reviewed by Jochen Eisinger.

        Just cleanup of three tiny nits I ran across in
        ContentSecurityPolicy::reportViolation while doing other work.

        - 'directiveText' and 'effectiveDirective' can't be empty; we pass in
          values at every callsite. We can safely remove the 'isEmpty()' checks.
          Moreover, even if they could possibly somehow be empty, we should
          still include those empty strings in the report, rather than
          dropping the values entirely.

        - We don't need to hold 'document->referrer()' in a temp variable.

        * page/ContentSecurityPolicy.cpp:
        (WebCore::ContentSecurityPolicy::reportViolation):

2700
2701
2702
2703
2704
2705
2706
2707
2708
2709
2710
2711
2712
2713
2714
2715
2716
2717
2013-03-25  Eugene Klyuchnikov  <eustas@chromium.org>

        Web Inspector: [Overview] Make "drag-to-move" feature more discoverable.
        https://bugs.webkit.org/show_bug.cgi?id=113032

        Reviewed by Pavel Feldman.

        To move overview window user could drag-n-drop over
        time "ribbon" on OverviewGrid.

        This feature is hard to discover.

        Setting "move" cursor will make this feature more discoverable.

        * inspector/front-end/inspectorCommon.css:
        Set "move" cursor to draggable area.
        * inspector/front-end/OverviewGrid.js: Ditto.

2718
2719
2720
2721
2722
2723
2724
2725
2726
2727
2728
2729
2013-03-25  Eugene Klyuchnikov  <eustas@chromium.org>

        Web Inspector: [Profiles] Remove unused private member.
        https://bugs.webkit.org/show_bug.cgi?id=113015

        Reviewed by Pavel Feldman.

        _profileGroupsForLinks is not used anymore.

        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype._reset): Removed unused member.

2730
2731
2732
2733
2734
2735
2736
2737
2738
2739
2740
2741
2742
2013-03-25  PhistucK  <phistuck@chromium.org>

        Web Inspector: Exception when turning on pretty print without any displayed source in the editor
        https://bugs.webkit.org/show_bug.cgi?id=113136

        Reviewed by Vsevolod Vlasov.

        No new tests.
        Added a check for the existence of currently edited document.

        * inspector/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._toggleFormatSource):

2743
2744
2745
2746
2747
2748
2749
2750
2751
2752
2753
2013-03-25  Mihnea Ovidenie  <mihnea@adobe.com>

        [CSSRegions] Remove RenderRegion::printRegionObjectsStyles
        https://bugs.webkit.org/show_bug.cgi?id=113081

        Reviewed by Tony Chang.

        No change in functionality, remove unused function..

        * rendering/RenderRegion.h:

2754
2755
2756
2757
2758
2759
2760
2761
2762
2763
2764
2765
2766
2767
2768
2769
2770
2771
2772
2013-03-25  Hurnjoo Lee  <hurnjoo.lee@samsung.com>

        [Texmap] Memory leak when closing a tab
        https://bugs.webkit.org/show_bug.cgi?id=112127

        Reviewed by Noam Rosenthal.

        When closing a tab, if there are any updates pending in CoordinatedGraphicsScene's
        render queue, the scene is not freed because reference count of m_scene is not zero.

        No new tests.

        * platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
        (WebCore::CoordinatedGraphicsScene::detach): When bind updates in CoordinatedGraphicsScene,
        the reference count of m_scene is increasing, if m_renderQueue is not empty
        before closing tab, then m_scene is never freed.
        Hence, when closing tab, need to clear m_renderQueue explicitly in order to
        destroy m_scene.

2773
2774
2775
2776
2777
2778
2779
2780
2781
2782
2783
2784
2785
2786
2787
2788
2789
2790
2013-03-25  Keishi Hattori  <keishi@webkit.org>

        Clear button visibility is not updated when restoring form state
        https://bugs.webkit.org/show_bug.cgi?id=113172

        Clear button wasn't showing up when restoring form state.

        Reviewed by Kent Tamura.

        Tests: fast/forms/date-multiple-fields/date-multiple-fields-clearbutton-visibility-after-restore.html
               fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-clearbutton-visibility-after-restore.html
               fast/forms/month-multiple-fields/month-multiple-fields-clearbutton-visibility-after-restore.html
               fast/forms/time-multiple-fields/time-multiple-fields-clearbutton-visibility-after-restore.html
               fast/forms/week-multiple-fields/week-multiple-fields-clearbutton-visibility-after-restore.html

        * html/BaseMultipleFieldsDateAndTimeInputType.cpp:
        (WebCore::BaseMultipleFieldsDateAndTimeInputType::restoreFormControlState):

2791
2792
2793
2794
2795
2796
2797
2798
2799
2800
2801
2802
2803
2804
2805
2806
2013-03-25  Eugene Klyuchnikov  <eustas@chromium.org>

        Web Inspector: [Settings] Use registry to track settings objects.
        https://bugs.webkit.org/show_bug.cgi?id=113008

        Reviewed by Pavel Feldman.

        Currently .createSetting creates new instance any time it is invoked.
        When one instance saves value, the other instance do not know about it.

        To resolve this issue we can use registry to make .createSetting return
        same object for specific key.

        * inspector/front-end/Settings.js:
        (WebInspector.Settings.prototype.createSetting): Use registry.

2807
2808
2809
2810
2811
2812
2813
2814
2815
2816
2817
2818
2819
2820
2821
2822
2823
2824
2825
2826
2827
2828
2829
2830
2831
2832
2833
2834
2835
2836
2837
2838
2839
2013-03-24  Matt Falkenhagen  <falken@chromium.org>

        Refactoring: Pull Node::disabled() and Node::isInert() down to Element.
        https://bugs.webkit.org/show_bug.cgi?id=112085

        Reviewed by Hajime Morrita.

        Node is too low a level for these methods. The plan is to rename
        Element::disabled to isDisabledFormControl and to remove
        Element::isEnabledFormControl.

        No new tests, just refactoring.

        * dom/Element.cpp:
        (WebCore::Element::disabled):
        (WebCore):
        (WebCore::Element::isInert):
        * dom/Element.h:
        (Element):
        * dom/EventDispatcher.cpp:
        (WebCore::EventDispatcher::dispatchSimulatedClick):
        * dom/GestureEvent.cpp:
        (WebCore::GestureEventDispatchMediator::dispatchEvent):
        * dom/MouseEvent.cpp:
        (WebCore::MouseEventDispatchMediator::dispatchEvent):
        * dom/Node.cpp:
        (WebCore::Node::handleLocalEvents):
        (WebCore::Node::willRespondToMouseMoveEvents):
        (WebCore::Node::willRespondToMouseClickEvents):
        (WebCore::Node::willRespondToTouchEvents):
        * dom/Node.h:
        (Node):

2840
2841
2842
2843
2844
2845
2846
2847
2848
2849
2850
2851
2852
2853
2854
2855
2013-03-24  Alpha Lam  <hclam@chromium.org>

        GIFImageReader should reports parsing error to client
        https://bugs.webkit.org/show_bug.cgi?id=113141

        Reviewed by Stephen White.

        GIFImageReader nows reports parsing error to client (GIFImageDecoder) such that errors can be handled.
        In the case of corrupted GIF images GIFImageReader will be deleted and decoding will fail.

        Unit test is updated to reflect change in behavior.
        Tested with a local corpus which showed better handling of corrupted GIF images.

        * platform/image-decoders/gif/GIFImageReader.cpp:
        (GIFImageReader::decode):

2856
2857
2858
2859
2860
2861
2862
2863
2864
2865
2866
2867
2868
2869
2870
2871
2872
2873
2874
2875
2876
2877
2878
2879
2880
2013-03-24  KondapallyKalyan  <kalyan.kondapally@intel.com>

        [EFL] Add support to check for current Drawable.
        https://bugs.webkit.org/show_bug.cgi?id=113103

        Reviewed by Kenneth Rohde Christiansen.

        Covered by existing WebGL tests.

        In MakeCurrent we do an early return if it is
        the current GL context but ignore Surface. This
        patch fixes the issue, we now check for both
        context and surface before doing an early return
        in MakeCurrent.

        * platform/graphics/opengl/GLPlatformContext.cpp:
        (WebCore::GLPlatformContext::makeCurrent):
        (WebCore::GLPlatformContext::releaseCurrent):
        (WebCore::GLPlatformContext::destroy):
        * platform/graphics/opengl/GLPlatformSurface.cpp:
        (WebCore):
        (WebCore::GLPlatformSurface::isCurrentDrawable):
        (WebCore::GLPlatformSurface::onMakeCurrent):
        * platform/graphics/opengl/GLPlatformSurface.h:

2881
2882
2883
2884
2885
2886
2887
2888
2889
2013-03-24  David Kilzer  <ddkilzer@apple.com>

        BUILD FIX (r146704): Settings::setHiddenPageDOMTimerThrottlingEnabled() isn't always built
        <http://webkit.org/b/112308>

        * WebCore.exp.in: Export
        Settings::setHiddenPageDOMTimerThrottlingEnabled()
        conditionally based on ENABLE(HIDDEN_PAGE_DOM_TIMER_THROTTLING).

2890
2891
2892
2893
2894
2895
2896
2897
2898
2899
2900
2901
2902
2903
2904
2905
2906
2907
2908
2909
2910
2911
2912
2013-03-24  Christophe Dumez  <ch.dumez@sisa.samsung.com>

        [EFL] NetworkStateNotifier::updateState() is called too often
        https://bugs.webkit.org/show_bug.cgi?id=113152

        Reviewed by Kenneth Rohde Christiansen.

        Wait until we have read all the data on the Netlink socket before
        reporting a possible network interface change. This way, we make
        sure we don't call NetworkStateNotifier::updateState() several
        times in a row for no reason.

        We also call NetworkStateNotifier::updateState() only if we get a
        RTM_NEWADDR event and we are currently offline, or if we get a
        RTM_DELADDR and we are currently online. This avoids calling
        NetworkStateNotifier::updateState() uselessly as there is no way
        the online state can change otherwise.

        No new tests, no behavior change for layout tests.

        * platform/network/efl/NetworkStateNotifierEfl.cpp:
        (WebCore::NetworkStateNotifier::readSocketCallback):

2913
2914
2915
2916
2917
2918
2919
2920
2921
2922
2923
2924
2925
2926
2927
2928
2929
2930
2931
2932
2933
2934
2935
2013-03-24  Chris Fleizach  <cfleizach@apple.com>

        AX: Crash in WebCore::AccessibilitySpinButton::incrementButton()
        https://bugs.webkit.org/show_bug.cgi?id=111582

        Reviewed by Tim Horton.

        There are two ways to create a spin button: from a textfield counter or from ARIA.
        If an ARIA spin button is created, it was returning true for isSpinButton, so we were 
        casting to the other kind of spin button, leading to a crash.

        We need to be more specific about our class types.

        Test: platform/mac/accessibility/aria-spinbutton-crash.html

        * accessibility/AccessibilityObject.h:
        (WebCore::AccessibilityObject::isNativeSpinButton):
        * accessibility/AccessibilitySpinButton.h:
        (WebCore::AccessibilitySpinButton::isNativeSpinButton):
        (WebCore::toAccessibilitySpinButton):
        * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
        (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

2936
2937
2938
2939
2940
2941
2942
2943
2944
2945
2946
2947
2948
2949
2950
2951
2952
2953
2954
2955
2956
2957
2958
2959
2960
2961
2962
2963
2964
2965
2966
2967
2968
2969
2970
2971
2972
2973
2974
2975
2976
2977
2978
2979
2980
2981
2982
2983
2984
2985
2986
2987
2988
2989
2990
2991
2992
2993
2994
2995
2996
2997
2998
2999
3000
3001
3002
3003
3004
3005
3006
3007
3008
3009
3010
3011
3012
3013
3014
3015
3016
3017
3018
3019
3020
3021
3022
3023
3024
3025
3026
3027
3028
3029
3030
3031
3032
3033
3034
3035
3036
3037
3038
3039
3040
3041
3042
3043
3044
3045
3046
2013-03-24  Chris Fleizach  <cfleizach@apple.com>

        AXObjectCache gets recreated during document tear-down.
        https://bugs.webkit.org/show_bug.cgi?id=112525

        Reviewed by Simon Fraser.

        In many cases, a document's AXObjectCache was being created after the
        document had detached, which is wasteful and could potentially lead to
        crashes because the AXObjectCache has a timer and relies on its document
        to exist.

        This patch provides a way to get the existing AX object cache, instead of
        always creating a new one.
        It moves the accessibilityEnabled() checks into the axObjectCache retrieval
        for easier readability.
        It adds a number of ASSERTs to vieryf that only the correct (top) document is used
        for cache manipulation.

        * accessibility/AXObjectCache.cpp:
        (WebCore::AXObjectCache::stopCachingComputedObjectAttributes):
        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::~ContainerNode):
        * dom/Document.cpp:
        (WebCore::Document::~Document):
        (WebCore::Document::clearAXObjectCache):
        (WebCore::Document::existingAXObjectCache):
        (WebCore::Document::axObjectCache):
        (WebCore::Document::setFocusedNode):
        * dom/Document.h:
        (Document):
        * dom/Element.cpp:
        (WebCore::Element::attributeChanged):
        * dom/Node.cpp:
        (WebCore::Node::~Node):
        (WebCore::Node::isEditableToAccessibility):
        (WebCore::Node::attach):
        (WebCore::Node::rootEditableElement):
        (WebCore::Node::didMoveToNewDocument):
        * editing/AppendNodeCommand.cpp:
        (WebCore::sendAXTextChangedIgnoringLineBreaks):
        * editing/DeleteFromTextNodeCommand.cpp:
        (WebCore::DeleteFromTextNodeCommand::doApply):
        (WebCore::DeleteFromTextNodeCommand::doUnapply):
        * editing/Editor.cpp:
        (WebCore::Editor::respondToChangedContents):
        (WebCore::Editor::markAndReplaceFor):
        * editing/InsertIntoTextNodeCommand.cpp:
        (WebCore::InsertIntoTextNodeCommand::doApply):
        (WebCore::InsertIntoTextNodeCommand::doUnapply):
        * editing/InsertNodeBeforeCommand.cpp:
        (WebCore::InsertNodeBeforeCommand::doApply):
        (WebCore::InsertNodeBeforeCommand::doUnapply):
        * editing/atk/FrameSelectionAtk.cpp:
        (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
        * editing/chromium/FrameSelectionChromium.cpp:
        (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
        * editing/mac/FrameSelectionMac.mm:
        (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::setChecked):
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::optionElementChildrenChanged):
        (WebCore::HTMLSelectElement::setRecalcListItems):
        * html/HTMLTextFormControlElement.cpp:
        (WebCore::HTMLTextFormControlElement::setInnerTextValue):
        * html/InputType.cpp:
        (WebCore::InputType::applyStep):
        * html/RangeInputType.cpp:
        (WebCore::RangeInputType::handleKeydownEvent):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::prepareForLoadStart):
        (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
        * page/FocusController.cpp:
        (WebCore::FocusController::setInitialFocus):
        * page/Frame.cpp:
        (WebCore::Frame::disconnectOwnerElement):
        * page/FrameView.cpp:
        (WebCore::FrameView::removeFromAXObjectCache):
        (WebCore::FrameView::layout):
        (WebCore::FrameView::scrollToAnchor):
        (WebCore::FrameView::axObjectCache):
        * platform/ScrollView.cpp:
        (WebCore::ScrollView::setHasHorizontalScrollbar):
        (WebCore::ScrollView::setHasVerticalScrollbar):
        * platform/Scrollbar.cpp:
        (WebCore::Scrollbar::~Scrollbar):
        (WebCore):
        (WebCore::Scrollbar::existingAXObjectCache):
        * platform/Scrollbar.h:
        (Scrollbar):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::deleteLineBoxTree):
        (WebCore::RenderBlock::createRootInlineBox):
        (WebCore::RenderBlock::createAndAppendRootInlineBox):
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::selectionChanged):
        * rendering/RenderMenuList.cpp:
        (WebCore::RenderMenuList::addChild):
        (WebCore::RenderMenuList::didUpdateActiveOption):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::styleWillChange):
        (WebCore::RenderObject::willBeDestroyed):
        * rendering/RenderObjectChildList.cpp:
        (WebCore::RenderObjectChildList::removeChildNode):
        (WebCore::RenderObjectChildList::insertChildNode):
        * rendering/RenderText.cpp:
        (WebCore::RenderText::setText):
        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::willBeDestroyed):

3047
3048
3049
3050
3051
3052
3053
3054
3055
3056
3057
3058
3059
3060
3061
3062
3063
3064
3065
3066
2013-03-23  Mike West  <mkwst@chromium.org>

        Drop full URLs from cross-origin access errors caused by sandboxing.
        https://bugs.webkit.org/show_bug.cgi?id=113029

        Reviewed by Timothy Hatcher.

        Following up on http://wkbug.com/112042, this patch brings cross-origin
        access error messages into line with the newly origin-only default
        message, and changes the error message text to explicitly refer to the
        missing 'allow-same-origin' sandbox flag that's the root cause of the
        error.

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::crossDomainAccessErrorMessage):
            Note that we're using the origin of the frames' URLs rather than
            their actual origin in these messages. This seems like a reasonable
            thing to do, since we know that at least one of the two origins will
            be "null" in this scenario.