ChangeLog 2.15 MB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15
2013-04-17  Anders Carlsson  <andersca@apple.com>

        Change storage factory functions to take a PageGroup and Page respectively
        https://bugs.webkit.org/show_bug.cgi?id=114776

        Reviewed by Beth Dakin.

        Update for WebCore changes.

        * WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
        (WebKit::WebPlatformStrategies::localStorageNamespace):
        (WebKit::WebPlatformStrategies::sessionStorageNamespace):
        * WebProcess/WebCoreSupport/WebPlatformStrategies.h:
        (WebPlatformStrategies):

16 17 18 19 20 21 22 23 24 25 26
2013-04-18  Timothy Hatcher  <timothy@apple.com>

        Remove an ASSERT that is causing flakeyness in Debug builds.

        https://webkit.org/b/113020

        Reviewed by Jessie Berlin.

        * UIProcess/WebInspectorProxy.cpp:
        (WebKit::WebInspectorProxy::open): Removed ASSERT(m_createdInspectorPage).

27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89
2013-04-18  Carlos Garcia Campos  <cgarcia@igalia.com>

        [GTK] Add WebKitWebPage::send-request signal to WebKit2 GTK+ API
        https://bugs.webkit.org/show_bug.cgi?id=83681

        Reviewed by Anders Carlsson.

        Add WebKitWebPage::send-request signal emitted in willSendRequest
        callback to allow web process extensions to modify requests before
        they are sent or cancel the resource load.
        This patch makes WebKitURIRequest and WebKitURIResponse objects
        shareable between UI process and web extensions APIs. Since both
        APIs force single header includes, the WebKitDefines.h header has
        been split moving the forward declarations specific to the UI
        process API to a new file WebKitForwardDeclarations.h. This way we
        can also  share the WebKitDefines.h header and remove the
        WebKitWebExtensionDefines.h header used in the web extensions API.

        * GNUmakefile.list.am: Add new files to compilation.
        * UIProcess/API/gtk/WebKitContextMenu.h: Include WebKitForward.h.
        * UIProcess/API/gtk/WebKitContextMenuItem.h: Ditto.
        * UIProcess/API/gtk/WebKitDefines.h: Remove forward declarations.
        * UIProcess/API/gtk/WebKitDownload.h: Include WebKitForward.h.
        * UIProcess/API/gtk/WebKitFindController.h: Ditto.
        * UIProcess/API/gtk/WebKitForwardDeclarations.h: Added. Contains
        the forward declarations moved from WebKitDefines.h.
        * UIProcess/API/gtk/WebKitPrintOperation.h: Include WebKitForward.h.
        * UIProcess/API/gtk/WebKitURIRequest.cpp:
        (webkitURIRequestSetProperty): Use webkit_uri_request_set_uri() to
        set the new URI.
        (webkit_uri_request_class_init): Make URI property construct
        instead of construct-only, since it can be updated once
        constructed. It should never be NULL, so set default value to
        about:blank instad of NULL.
        (webkit_uri_request_set_uri): New public method to set the URI of
        the WebKitURIRequest.
        * UIProcess/API/gtk/WebKitURIRequest.h: Allow to include this file
        from webkit-web-extension.h.
        * UIProcess/API/gtk/WebKitURIResponse.h: Ditto.
        * UIProcess/API/gtk/WebKitURISchemeRequest.h: Include
        WebKitForward.h.
        * UIProcess/API/gtk/WebKitWebView.h: Ditto.
        * UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add
        webkit_uri_request_set_uri.
        * UIProcess/API/gtk/tests/TestResources.cpp:
        (testWebResourceSendRequest):
        (serverCallback):
        (beforeAll):
        * UIProcess/API/gtk/tests/WebExtensionTest.cpp:
        (sendRequestCallback):
        (pageCreatedCallback):
        * UIProcess/API/gtk/webkit2marshal.list:
        * WebProcess/InjectedBundle/API/gtk/WebKitWebExtension.h: Include
        WebKitDefines.h instead of WebKitWebExtensionDefines.h.
        * WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
        (willSendRequestForFrame): Emit WebKitWebPage::send-request and
        return early if the load is cancelled.
        (webkit_web_page_class_init): Add WebKitWebPage::send-request
        signal.
        * WebProcess/InjectedBundle/API/gtk/WebKitWebPage.h: Include
        WebKitDefines.h instead of WebKitWebExtensionDefines.h.
        * WebProcess/InjectedBundle/API/gtk/webkit-web-extension.h:

90 91 92 93 94 95 96 97 98 99 100 101 102
2013-04-18  Bruno de Oliveira Abinader  <bruno.abinader@basyskom.com>

        [WK2] CoordinatedGraphicsLayerState is a struct, not a class
        https://bugs.webkit.org/show_bug.cgi?id=108855

        Reviewed by Andreas Kling.

        Fixes the forward declaration which takes CoordinatedGraphicsLayerState
        as a class.

        * UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
        (WebCore):

103 104 105 106 107 108 109 110 111 112 113 114 115
2013-04-18  Krzysztof Wolanski  <k.wolanski@samsung.com>:

        [EFL][WK2] Change inadequate return value in method setDone().
        https://bugs.webkit.org/show_bug.cgi?id=114806

        Reviewed by Andreas Kling.

        Fix possible warning in EFL port: no return statement in function returning non-void.
        Change return value from bool to void in method setDone().

        * UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
        (EWK2UnitTest::CallbackDataTimer::setDone):

116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232
2013-04-18  Grzegorz Czajkowski  <g.czajkowski@samsung.com>

        [WK2][EFL] Text Checker's settings refactor
        https://bugs.webkit.org/show_bug.cgi?id=111713

        Reviewed by Andreas Kling.

        Use WK2's TextCheckerState object as the store for the text checker settings.
        It's shared between the client (Ewk API part) and WebProcess (read only).
        Thanks to it, we don't have to keep any additional structure with
        the settings on ewk side.

        In the consistency with WKTextChecker C API, move the Ewk's text checker settings APIs
        to the ewk_text_checker.h/cpp. They're not connected to Ewk_View/Ewk_Settings object to
        keep them in ewk_setting.h/cpp.

        Introduce a new class to implement WKTextCheckerClient callbacks to call spelling
        methods through WK2 C API.
        The main purpose of this change is to detach text checker initialization from ewk_context.

        * PlatformEfl.cmake:
        Add a new files to the build.

        * UIProcess/API/efl/ewk_context.cpp:
        (EwkContext::EwkContext):
        Detach the text checker initialization from context.
        There might be more than default context.
        There is one text checker object per application.

        * UIProcess/API/efl/ewk_settings.cpp:
        * UIProcess/API/efl/ewk_settings.h:
        Remove the text checker settings.

        * UIProcess/API/efl/ewk_text_checker.cpp:
        Add the text checker settings to the ewk_text_checker.h/cpp

        (convertLanguagesToEinaList):
        Add helper function to convert Vector's values to Eina_List.

        (clientCallbacks):
        Add the client callback responsible for the continuous spell checking
        setting change to the struct.

        (ewk_text_checker_continuous_spell_checking_enabled_set):
        Do not call the client's callback responsible for the setting
        change unless WebKit changes the setting (trough the context
        'Check Spelling While Typing' option).

        * UIProcess/API/efl/ewk_text_checker.h:
        Adjust APIs name to the ewk_text_checker syntax.
        Update the documentation according to the changes.

        * UIProcess/API/efl/ewk_text_checker_private.h:
        (ClientCallbacks):
        Move ClientCallbacks structure to TextCheckerClientEfl.
        The client callbacks (Ewk API) have to be accessible in WKTextCheckerClient callbacks
        to choose what implementation will be used - the client's (if definied) or Enchant impl.

        * UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:
        Update the unit tests according to the APIs change.
        Update the test responsible for the notification about the setting change
        according to changes in 'ewk_text_checker_continuous_spell_checking_enabled_set'.

        * UIProcess/efl/TextCheckerClientEfl.cpp: Added.
        Implement WKTextCheckerClient callbacks.

        (TextCheckerClientEfl::TextCheckerClientEfl):
        (TextCheckerClientEfl::instance):
        Allow to get and create TextCheckerClientEfl object.

        (TextCheckerClientEfl::isContinuousSpellCheckingEnabled):
        Get the setting value based on WK2 C API.

        (TextCheckerClientEfl::ensureSpellCheckingLanguage):
        Load the default languages if user didn't specify any.

        (TextCheckerClientEfl::updateSpellCheckingLanguages):
        (TextCheckerClientEfl::languagesUpdateTimerFired):
        (TextCheckerClientEfl::availableSpellCheckingLanguages):
        (TextCheckerClientEfl::loadedSpellCheckingLanguages):
        (TextCheckerClientEfl::availableSpellCheckingLanguages):
        (TextCheckerClientEfl::loadedSpellCheckingLanguages):
        Provide support for languages.

        (TextCheckerClientEfl::spellCheckingSettingChangeTimerFired):
        (TextCheckerClientEfl::callContinuousSpellCheckingChangeCallbackAsync):
        Notify the client about the setting change.

        (TextCheckerClientEfl::isContinuousSpellCheckingEnabledCallback):
        (TextCheckerClientEfl::setContinuousSpellCheckingEnabledCallback):
        (TextCheckerClientEfl::uniqueSpellDocumentTagCallback):
        (TextCheckerClientEfl::closeSpellDocumentWithTagCallback):
        (TextCheckerClientEfl::checkSpellingOfStringCallback):
        (TextCheckerClientEfl::guessesForWordCallback):
        (TextCheckerClientEfl::learnWordCallback):
        (TextCheckerClientEfl::ignoreWordCallback):
        WKTextCheckerClient callbacks implementation.

        * UIProcess/efl/TextCheckerClientEfl.h: Added.
        (TextCheckerClientEfl):
        (TextCheckerClientEfl::clientCallbacks):
        Return the client callbacks to be used in ewk_text_checker.cpp.

        * UIProcess/efl/TextCheckerEfl.cpp:
        (WebKit::TextChecker::state):
        Initialize the TextCheckerState's members to false.

        (WebKit::TextChecker::setContinuousSpellCheckingEnabled):
        Set the default language if user didn't specify any.
        Notify the client about the setting change.
        This method is called when context menu 'Check Spelling While Typing'
        option has been toggled.

        (WebKit::TextChecker::continuousSpellCheckingEnabledStateChanged):
        Set the default language if user didn't specify any.
        Called by WKTextChecker's API.

233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283
2013-04-18  Manuel Rego Casasnovas  <rego@igalia.com>

        [GTK][WK2] Add WebKitWebPage::webkit_web_page_get_uri to WebKit2 GTK+ API
        https://bugs.webkit.org/show_bug.cgi?id=111288

        Reviewed by Anders Carlsson.

        Add new property URI to WebKitWebPage providing a method
        webkit_web_page_get_uri to get it and the signal "notify::uri" to
        monitor changes in the URI.

        * UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Include new method in
        GTK+ doc.
        * UIProcess/API/gtk/tests/TestLoaderClient.cpp:
        (testWebPageURI):
        (beforeAll):
        (afterAll): Add test to check that WebKitWebPage URI matches with
        WebKitWebView value. The tests is listening for changes in WebKitWebPage
        URI via D-Bus and checks that value is the same than WebKitWebView URI.
        It also checks that the order of the URIs in a redirection is right.
        When the test finishes the signals are disconnected properly.
        * UIProcess/API/gtk/tests/WebExtensionTest.cpp:
        (uriChangedCallback):
        (pageCreatedCallback): Add new D-Bus signal "URIChanged" connected to
        "notify::uri" signal of WebKitWebPage.
        * UIProcess/API/gtk/tests/WebKitTestBus.cpp:
        (WebKitTestBus::getOrCreateConnection): Rename method connection() to
        getOrCreateConnection().
        (WebKitTestBus::createProxy): Use the new method name.
        * UIProcess/API/gtk/tests/WebKitTestBus.h:
        (WebKitTestBus::connection): Add public getter for m_connection.
        (WebKitTestBus): Add private method header getOrCreateConnection().
        * WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
        (_WebKitWebPagePrivate): Add new URI attribute.
        (webkitWebPageSetURI): Method to set the URI and emit the "notify:uri"
        signal if it has changed.
        (didStartProvisionalLoadForFrame): At this point it use the unreachable
        URL from provisional document loader if any. Otherwise, it uses the URL
        from provisional document loader.
        (didReceiveServerRedirectForProvisionalLoadForFrame): In the case of
        redirections it works like for didStartProvisionalLoadForFrame getting
        the unreachable URL if any.
        (didSameDocumentNavigationForFrame): In this case it gets the URL from
        the document loader.
        (webkitWebPageGetProperty): Add code related to URI property.
        (webkit_web_page_class_init): Add bits related to URI property.
        (webkitWebPageCreate): Implement callbacks to monitor URI changes.
        (webkit_web_page_get_uri): Return URI attribute.
        * WebProcess/InjectedBundle/API/gtk/WebKitWebPage.h: Add new method
        header.

284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309
2013-04-18  Xan Lopez  <xan@igalia.com>

        [GTK] When the WebProcess crashes, a signal should be emitted
        https://bugs.webkit.org/show_bug.cgi?id=105180

        Emit a "web-process-crashed" signal when the WebProcess crashes. This
        is useful, for example, to show an error page in a web browser
        like Chrome does.

        Reviewed Carlos Garcia Campos.

        * UIProcess/API/gtk/WebKitLoaderClient.cpp:
        (processDidCrash):
        (attachLoaderClientToView):
        * UIProcess/API/gtk/WebKitWebContextPrivate.h:
        * UIProcess/API/gtk/WebKitWebView.cpp:
        (webkit_web_view_class_init):
        (webkitWebViewWebProcessCrashed):
        * UIProcess/API/gtk/tests/TestWebExtensions.cpp:
        (testWebExtensionGetTitle):
        (webProcessCrashedCallback):
        (testWebKitWebViewProcessCrashed):
        (beforeAll):
        * UIProcess/API/gtk/tests/WebExtensionTest.cpp:
        (methodCallCallback):

310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333
2013-04-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        [EFL][WK2] Add tooltip API to the WKView client
        https://bugs.webkit.org/show_bug.cgi?id=111563

        Reviewed by Andreas Kling.

        Add tooltip to the barebone Tizen C API, and implement
        the method so that the EFL API keeps working.

        * UIProcess/API/C/efl/WKView.h:
        * UIProcess/efl/ViewClientEfl.cpp:
        (WebKit::ViewClientEfl::didChangeTooltip):
        (WebKit):
        (WebKit::ViewClientEfl::ViewClientEfl):
        * UIProcess/efl/ViewClientEfl.h:
        (ViewClientEfl):
        * UIProcess/efl/WebView.cpp:
        (WebKit::WebView::toolTipChanged):
        * UIProcess/efl/WebViewClient.cpp:
        (WebKit::WebViewClient::didChangeTooltip):
        (WebKit):
        * UIProcess/efl/WebViewClient.h:

334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352
2013-04-17  Joone Hur  <joone.hur@intel.com>

        [EFL][AC] m_pendingSurfaceResize needs to be guarded by USE(ACCELERATED_COMPOSITING)
        https://bugs.webkit.org/show_bug.cgi?id=114770

        AC related code is guarded by USE(ACCELERATED_COMPOSITING) in order to build 
        WebKitEfl with no-tiled-backing-store(r147792), but m_pendingSurfaceResize is 
        not included. This patch allows m_pendingSurfaceResize to be guarded by 
        USE(ACCELERATED_COMPOSITING). 

        Reviewed by Simon Fraser.

        * UIProcess/API/efl/EwkView.cpp:
        (EwkView::EwkView):
        (EwkView::displayTimerFired):
        (EwkView::handleEvasObjectCalculate):
        * UIProcess/API/efl/EwkView.h:
        (EwkView):

353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369
2013-04-17  Anders Carlsson  <andersca@apple.com>

        The storage manager should know the local storage directory
        https://bugs.webkit.org/show_bug.cgi?id=114765

        Reviewed by Beth Dakin.

        * UIProcess/Storage/StorageManager.cpp:
        (WebKit::StorageManager::create):
        (WebKit::StorageManager::setLocalStorageDirectory):
        (WebKit::StorageManager::setLocalStorageDirectoryInternal):
        * UIProcess/Storage/StorageManager.h:
        * UIProcess/WebContext.cpp:
        (WebKit::WebContext::WebContext):
        (WebKit::WebContext::setLocalStorageDirectory):
        * UIProcess/WebContext.h:

370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385
2013-04-17  Joone Hur  <joone.hur@intel.com>

        [EFL][AC] MiniBrowser starts with a black empty view before painting a web page
        https://bugs.webkit.org/show_bug.cgi?id=103745

        Reviewed by Kenneth Rohde Christiansen.

        Evas paints empty evas objects before rendering a web page, so it shows 
        a black empty view for a moment. This patch prevents from painting the empty 
        evas objects until a GL surface is ready for rendering.  

        * UIProcess/API/efl/EwkView.cpp:
        (showEvasObjectsIfNeeded):
        (EwkView::displayTimerFired):
        (EwkView::handleEvasObjectShow):

386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403
2013-04-16  Carlos Garcia Campos  <cgarcia@igalia.com>

        [GTK] Add webkit_web_page_get_id() to WebKit2 GTK+ API
        https://bugs.webkit.org/show_bug.cgi?id=111938

        Reviewed by Anders Carlsson.

        Add API to the web extensions API to get the identifier of a web
        page.

        * UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbol.
        * UIProcess/API/gtk/tests/WebExtensionTest.cpp:
        (methodCallCallback): Check the page ID matches the one returned
        by webkit_web_page_get_id().
        * WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
        (webkit_web_page_get_id):
        * WebProcess/InjectedBundle/API/gtk/WebKitWebPage.h:

404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427
2013-04-16  Anders Carlsson  <andersca@apple.com>

        Clone storage namespaces for window.open
        https://bugs.webkit.org/show_bug.cgi?id=114703

        Reviewed by Sam Weinig.

        * UIProcess/Storage/StorageManager.cpp:
        (WebKit::StorageManager::StorageArea::clone):
        New helper function for cloning a storage area.

        (WebKit::StorageManager::StorageArea::setItem):
        Correctly handle the copy-on-write feature of StorageMap if it has multiple storage areas pointing to it.

        (WebKit::StorageManager::StorageArea::removeItem):
        Ditto.

        (WebKit::StorageManager::SessionStorageNamespace::cloneTo):
        Add cloned storage areas.

        * WebProcess/Storage/StorageNamespaceImpl.cpp:
        (WebKit::StorageNamespaceImpl::copy):
        Create a new session storage namespace for the new page.

428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454
2013-04-16  Beth Dakin  <bdakin@apple.com>

        Need a new layout milestone to notify bundle clients when the header has been 
        flushed
        https://bugs.webkit.org/show_bug.cgi?id=114706
        -and corresponding-
        <rdar://problem/13657284>

        Reviewed by Simon Fraser.

        Make this new LayoutMilestone private at the API layer. 
        * Shared/API/c/WKPageLoadTypes.h:
        * Shared/API/c/WKPageLoadTypesPrivate.h: Added.

        Handle the new milestone.
        * Shared/API/c/WKSharedAPICast.h:
        (WebKit::toWKLayoutMilestones):
        (WebKit::toLayoutMilestones):

        New file to make the milestone private.
        * WebKit2.xcodeproj/project.pbxproj:

        Add or remove the DidFirstFlushForHeaderLayer millstone based on whether we just 
        added or removed a header.
        * WebProcess/WebPage/mac/WebPageMac.mm:
        (WebKit::WebPage::setHeaderLayerWithHeight):

rniwa@webkit.org's avatar
rniwa@webkit.org committed
455 456 457 458 459 460
2013-04-16  Ryosuke Niwa  <rniwa@webkit.org>

        Another EFL build fix.

        * WebProcess/WebPage/efl/WebPageEfl.cpp:

461 462 463 464 465 466 467 468 469 470 471 472 473 474
2013-04-15  Sam Weinig  <sam@webkit.org>

        Remove more #includes from Frame.h
        https://bugs.webkit.org/show_bug.cgi?id=114642

        Reviewed by Anders Carlsson.

        * WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp:
        * WebProcess/Plugins/PluginView.cpp:
        * WebProcess/WebPage/WebFrame.cpp:
        * WebProcess/WebPage/gtk/WebPageGtk.cpp:
        * WebProcess/WebPage/mac/WebPageMac.mm:
        * WebProcess/WebPage/qt/WebPageQt.cpp:

475 476 477 478 479 480 481 482 483 484 485 486
2013-04-16  Timothy Hatcher  <timothy@apple.com>

        Make resizing the docked Web Inspector stay in sync with the inspected view.

        https://webkit.org/b/114682

        Reviewed by Joseph Pecoraro.

        * UIProcess/mac/WebInspectorProxyMac.mm:
        (WebKit::WebInspectorProxy::inspectedViewFrameDidChange):
        Disable screen updates to make sure the layers for both views resize in sync.

487 488 489 490 491 492 493 494 495 496
2013-04-15  Anders Carlsson  <andersca@apple.com>

        Remove unneeded headers from ScriptExecutionContext.h
        https://bugs.webkit.org/show_bug.cgi?id=114631

        Reviewed by Alexey Proskuryakov.

        * WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
        * WebProcess/WebPage/PageOverlay.cpp:

497 498 499 500 501 502 503 504 505
2013-04-16  Maciej Stachowiak  <mjs@apple.com>

        Remove even yet still more traces of v8
        https://bugs.webkit.org/show_bug.cgi?id=114693

        Reviewed by Anders Carlsson.

        * Scripts/generate-forwarding-headers.pl: Remove v8 from list of platforms.

506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522
2013-04-16  Alexey Proskuryakov  <ap@apple.com>

        Remove unused AlternativeTextClient::dismissDictationAlternativeUI
        https://bugs.webkit.org/show_bug.cgi?id=114598

        Reviewed by Ryosuke Niwa.

        * UIProcess/API/mac/PageClientImpl.h:
        * UIProcess/API/mac/PageClientImpl.mm:
        (WebKit::PageClientImpl::dictationAlternatives):
        * UIProcess/PageClient.h:
        * UIProcess/WebPageProxy.cpp:
        * UIProcess/WebPageProxy.h:
        * UIProcess/WebPageProxy.messages.in:
        * WebProcess/WebCoreSupport/WebAlternativeTextClient.h:
        * WebProcess/WebCoreSupport/mac/WebAlternativeTextClient.cpp:

523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574
2013-04-16  Claudio Saavedra  <csaavedra@igalia.com>

        [GTK][WK2] Add API to retrieve a snapshot from a webview
        https://bugs.webkit.org/show_bug.cgi?id=98270

        Reviewed by Anders Carlsson.

        This adds the GTK+ API necessary to retrieve a snapshot from a
        webview asynchronously. The API uses the injected bundle
        internally to get the snapshot from the WebProcess.

        * UIProcess/API/gtk/WebKitError.cpp:
        (webkit_snapshot_error_quark): Add snapshot API related error
        quark.
        * UIProcess/API/gtk/WebKitError.h: Add snapshot error handling.
        * UIProcess/API/gtk/WebKitInjectedBundleClient.cpp:
        (didReceiveWebViewMessageFromInjectedBundle): Handle the new
        "DidGetSnapshot" message.
        * UIProcess/API/gtk/WebKitPrivate.h: Add SnapshotRegion enum.
        * UIProcess/API/gtk/WebKitWebView.cpp:
        (_WebKitWebViewPrivate): Add a map for the snapshot results.
        (GetSnapshotAsyncData):
        (webKitWebViewDidReceiveSnapshot):
        (webKitSnapshotRegionToSnapshotRegion): Helper method for casting
        the region option enumeration.
        (generateSnapshotCallbackID): Method to generate unique callback
        ids.
        (webkit_web_view_get_snapshot):
        (webkit_web_view_get_snapshot_finish): New snapshotting API.
        * UIProcess/API/gtk/WebKitWebView.h: Ditto.
        * UIProcess/API/gtk/WebKitWebViewPrivate.h: Add the private method
        to handle a received snapshot.
        * UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add the new API
        bits.
        * UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
        (cairoSurfacesEqual): Add helper to compare cairo_surface_t
        structs.
        (testWebViewSnapshot): New test.
        (beforeAll): Add the new test.
        * UIProcess/API/gtk/tests/WebViewTest.cpp:
        (WebViewTest::selectAll): Add method to help test snapshots
        including selection.
        * UIProcess/API/gtk/tests/WebViewTest.h: Ditto
        * WebProcess/InjectedBundle/API/gtk/WebKitWebExtension.cpp:
        (didReceiveMessageToPage): Ditto.
        (webkitWebExtensionCreate): Register method above.
        * WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
        (webkitWebPageDidReceiveMessage): Add this method. It
        handles the new message "GetSnapshot".
        * WebProcess/InjectedBundle/API/gtk/WebKitWebPagePrivate.h:
        Add method above.

575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590
2013-04-16  Timothy Hatcher  <timothy@apple.com>

        Create full rects for the inspector and inspected views when
        adjusting to an inspected view frame change. 

        This ensures switching dock sides restores the inspected view
        and inspector to fill the parent's bounds.

        https://webkit.org/b/114666
        rdar://problem/13660796

        Reviewed by Joseph Pecoraro.

        * UIProcess/mac/WebInspectorProxyMac.mm:
        (WebKit::WebInspectorProxy::inspectedViewFrameDidChange):

591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614
2013-04-16  Balazs Kelemen  <kbalazs@webkit.org>

        Initialize logging channels for web processes
        https://bugs.webkit.org/show_bug.cgi?id=114621

        Reviewed by Sam Weinig.

        Use InitializeWebKit2 for initializing the web and plugin processes.
        It handles initializing the logging channels and it's better to have
        shared core for this. For the plugin process now we always create
        a RunLoop object which is not necessary with the -scanPlugin argument
        but it shouldn't be a problem.

        * PluginProcess/qt/PluginProcessMainQt.cpp:
        (WebKit::PluginProcessMain):
        * PluginProcess/unix/PluginProcessMainUnix.cpp:
        (WebKit::PluginProcessMainUnix):
        * WebProcess/efl/WebProcessMainEfl.cpp:
        (WebKit::WebProcessMainEfl):
        * WebProcess/gtk/WebProcessMainGtk.cpp:
        (WebKit::WebProcessMainGtk):
        * WebProcess/qt/WebProcessMainQt.cpp:
        (WebKit::WebProcessMainQt):

615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639
2013-04-16  Michał Pakuła vel Rutka  <m.pakula@samsung.com>

        [EFL][WK2] Add an API for getting context menu item's parent menu
        https://bugs.webkit.org/show_bug.cgi?id=107510

        Reviewed by Kenneth Rohde Christiansen.

        Added parent menu support and API for Ewk_Context_Menu_Item, to
        allow selecting context menus using Elementary widgets.
        Context menu unit test updated with new function. 

        * UIProcess/API/efl/ewk_context_menu.cpp:
        (EwkContextMenu::EwkContextMenu):
        * UIProcess/API/efl/ewk_context_menu_item.cpp:
        (EwkContextMenuItem::EwkContextMenuItem):
        (ewk_context_menu_item_parent_menu_get):
        * UIProcess/API/efl/ewk_context_menu_item.h:
        * UIProcess/API/efl/ewk_context_menu_item_private.h:
        (EwkContextMenuItem::create):
        (EwkContextMenuItem::parentMenu):
        (EwkContextMenuItem::setParentMenu):
        (EwkContextMenuItem):
        * UIProcess/API/efl/tests/test_ewk2_context_menu.cpp:
        (showContextMenu):

640 641 642 643 644 645
2013-04-16  Andreas Kling  <akling@apple.com>

        Fix release builds with !LOG_DISABLED.

        * Platform/mac/Logging.mac.mm:

646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664
2013-04-16  Manuel Rego Casasnovas  <rego@igalia.com>

        [GTK][EFL] Remove deprecated libsoup API usage
        https://bugs.webkit.org/show_bug.cgi?id=104894

        Reviewed by Philippe Normand.

        Remove LIBSOUP_USE_UNSTABLE_REQUEST_API and only include
        libsoup/soup.h.

        * WebProcess/Cookies/soup/WebKitSoupCookieJarSqlite.h:
        * WebProcess/efl/WebProcessMainEfl.cpp:
        * WebProcess/gtk/WebProcessMainGtk.cpp:
        * WebProcess/soup/WebKitSoupRequestGeneric.h:
        * WebProcess/soup/WebProcessSoup.cpp:
        * WebProcess/soup/WebSoupRequestManager.cpp:
        (WebKit::WebSoupRequestManager::registerURIScheme): Remove requester and
        use method soup_session_add_feature_by_type().

665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680
2013-04-15  Dean Jackson  <dino@apple.com>

        Plugins that resize might need to be snapshotted.
        https://bugs.webkit.org/show_bug.cgi?id=102157
        <rdar://problem/12696259>

        Reviewed by Tim Horton.

        Allow a running plugin to be snapshotted. All this
        means is that we start the snapshot timer again.

        * WebProcess/Plugins/PluginView.cpp:
        (WebKit::PluginView::beginSnapshottingRunningPlugin): Restart
            the timer.
        * WebProcess/Plugins/PluginView.h: Virtual method declaration.

681 682 683 684 685 686 687 688 689 690
2013-04-15  Seokju Kwon  <seokju.kwon@gmail.com>

        [EFL][WK2] build fix after r148434
        https://bugs.webkit.org/show_bug.cgi?id=114647

        Reviewed by Benjamin Poulain.

        * UIProcess/API/efl/EwkView.cpp:
        (EwkView::showContextMenu):

691 692 693 694 695 696 697 698 699 700 701 702 703 704 705
2013-04-15  Jer Noble  <jer.noble@apple.com>

        After switching to another space and back, video races to catch up with audio
        https://bugs.webkit.org/show_bug.cgi?id=114634

        Reviewed by Tim Horton.

        In Mountain Lion and previous, report that a view is "not visible" when its window
        is not in the active space. This causes us to notify AVFoundation that its CAImageQueues
        will not be serviced and results in not having the "catch up" behavior when returning
        to the browser's space.

        * UIProcess/API/mac/PageClientImpl.mm:
        (WebKit::PageClientImpl::isViewVisible):

706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722
2013-04-15  Seulgi Kim  <seulgikim@company100.net>

        Schedule rendering at regular interval (60fps)
        https://bugs.webkit.org/show_bug.cgi?id=114617

        Reviewed by Martin Robinson.

        Schedule rendering reguarly regardless of the time taken to render a
        frame. Otherwise, next flush delayed by the amount of the rendering
        time.

        * WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
        (WebKit::LayerTreeHostGtk::LayerTreeHostGtk):
        (WebKit::LayerTreeHostGtk::layerFlushTimerFired):
        (WebKit::LayerTreeHostGtk::flushAndRenderLayers):
        * WebProcess/WebPage/gtk/LayerTreeHostGtk.h:

723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767
2013-04-15  Michał Pakuła vel Rutka  <m.pakula@samsung.com>

        [EFL][WK2] Use C API in ewk_context_menu
        https://bugs.webkit.org/show_bug.cgi?id=109698

        Reviewed by Andreas Kling.

        EFL port unlike others does not handle context menus inside WebKit but exposes an API:
        ewk_context_menu and ewk_context_menu_item, and leaves context menu to application.
        Currently EFL port's context menu API uses internal C++ classes, while it should use WK2 C API,
        to avoid violating layering.
        This patch changes EFL context menu API to use only WK2 C API.

        * UIProcess/API/efl/EwkView.cpp:
        (EwkView::showContextMenu):
        * UIProcess/API/efl/EwkView.h:
        (WebKit):
        (EwkView):
        * UIProcess/API/efl/ewk_context_menu.cpp:
        (EwkContextMenu::EwkContextMenu):
        (EwkContextMenu::contextMenuItemSelected):
        (ewk_context_menu_item_select):
        (getWKTagFromEwkAction):
        * UIProcess/API/efl/ewk_context_menu_item.cpp:
        (EwkContextMenuItem::EwkContextMenuItem):
        (getEwkActionFromWKTag):
        * UIProcess/API/efl/ewk_context_menu_item.h:
        * UIProcess/API/efl/ewk_context_menu_item_private.h:
        (EwkContextMenuItem::create):
        (EwkContextMenuItem):
        * UIProcess/API/efl/ewk_context_menu_private.h:
        (EwkContextMenu::create):
        (EwkContextMenu):
        * UIProcess/efl/ContextMenuClientEfl.cpp:
        (showContextMenu):
        (hideContextMenu):
        (ContextMenuClientEfl::ContextMenuClientEfl):
        * UIProcess/efl/ContextMenuClientEfl.h:
        (WebKit::ContextMenuClientEfl::view):
        * UIProcess/efl/WebContextMenuProxyEfl.cpp:
        (WebKit::WebContextMenuProxyEfl::showContextMenu):
        (WebKit::WebContextMenuProxyEfl::hideContextMenu):
        * UIProcess/efl/WebContextMenuProxyEfl.h:
        (WebContextMenuProxyEfl):

768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783
2013-04-15  Balazs Kelemen  <kbalazs@webkit.org>

        [CoordGfx] Background color should not be part of GraphicsLayerState
        https://bugs.webkit.org/show_bug.cgi?id=113785

        Reviewed by Andreas Kling.

        Page background is independent from layer state, send it to the UI
        as soon as possible.

        * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
        (CoreIPC::::encode):
        (CoreIPC::::decode):
        * WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
        (WebKit::CoordinatedLayerTreeHost::setBackgroundColor):

784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815
2013-04-15  Michał Pakuła vel Rutka  <m.pakula@samsung.com>

        [WK2] Add new callbacks and a function for WebKit2 context menu API
        https://bugs.webkit.org/show_bug.cgi?id=111552

        Reviewed by Anders Carlsson.

        Add contextMenuHide and contextMenuShow callbacks to WKPageContextMenuClient
        and WKPageContextMenuSelected API so context menus can be handled outside
        WebKit. API version of this client was bumped so older client version still
         can be used

        * Shared/APIClientTraits.cpp:
        (WebKit):
        * Shared/APIClientTraits.h:
        * UIProcess/API/C/WKPage.cpp:
        (WKPageSelectContextMenuItem):
        * UIProcess/API/C/WKPage.h:
        * UIProcess/API/gtk/WebKitContextMenuClient.cpp:
        (attachContextMenuClientToView):
        * UIProcess/WebPageContextMenuClient.cpp:
        (WebKit::WebPageContextMenuClient::getContextMenuFromProposedMenu):
        (WebKit::WebPageContextMenuClient::showContextMenu):
        (WebKit):
        (WebKit::WebPageContextMenuClient::hideContextMenu):
        * UIProcess/WebPageContextMenuClient.h:
        (WebPageContextMenuClient):
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::internalShowContextMenu):
        * UIProcess/efl/ContextMenuClientEfl.cpp:
        (ContextMenuClientEfl::ContextMenuClientEfl):

816 817 818 819 820 821 822 823 824 825 826 827 828 829
2013-04-14  Christophe Dumez  <ch.dumez@sisa.samsung.com>

        [EFL][WK2] Regression(r148274): Broke rendering in the browser
        https://bugs.webkit.org/show_bug.cgi?id=114593

        Reviewed by Anders Carlsson.

        r148274 added a new "didChangeViewportAttributes" callback to
        WKView but did not hook it up in ViewClientEfl. This patch
        fixes this and makes rendering work again in the browser.

        * UIProcess/efl/ViewClientEfl.cpp:
        (WebKit::ViewClientEfl::ViewClientEfl):

830 831 832 833 834 835 836 837 838 839
2013-04-14  Andreas Kling  <akling@apple.com>

        Move CSSOM classes to using MutableStylePropertySet over StylePropertySet.
        <http://webkit.org/b/114581>

        Reviewed by Anders Carlsson.

        * WebProcess/WebCoreSupport/WebEditorClient.cpp:
        (WebKit::WebEditorClient::shouldApplyStyle):

840 841 842 843 844 845 846 847
2013-04-14  Christophe Dumez  <ch.dumez@sisa.samsung.com>

        Unreviewed build fix for WebKit2 EFL after r148373 due to missing
        header includes.

        * UIProcess/InspectorServer/efl/WebInspectorServerEfl.cpp:
        * UIProcess/efl/InputMethodContextEfl.cpp:

848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873
2013-04-13  Sam Weinig  <sam@webkit.org>

        Add ObjC API for setting initialization data for the WKWebProcessPlugIn
        https://bugs.webkit.org/show_bug.cgi?id=103846

        Reviewed by Darin Adler.

        * UIProcess/API/mac/WKProcessGroup.h:
        Adds a new optional processGroupWillCreateConnectionToWebProcessPlugIn: method for the WKProcessGroupDelegate protocol,
        which allows the user to pass (via an autoreleased return value) initialization data to the web process plugin.

        * UIProcess/API/mac/WKProcessGroup.mm:
        (getInjectedBundleInitializationUserData):
        (setUpInectedBundleClient):
        (-[WKProcessGroup initWithInjectedBundleURL:]):
        (-[WKProcessGroup dealloc]):
        Use the existing WKContextInjectedBundleClient infrastructure to pass the initialization data to the bundle
        via the new ObjCObjectGraph APIObject.

        * WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.h:
        Adds webProcessPlugIn:initializeWithObject: to the WKWebProcessPlugIn protocol, replacing webProcessPlugInInitialize:.

        * WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:
        (WebKit::InjectedBundle::load):
        Pass the initialization data to the web process plugin.

weinig@apple.com's avatar
weinig@apple.com committed
874 875 876 877 878 879
2013-04-13  Sam Weinig  <sam@webkit.org>

        Attempt Build Fix.

        * WebProcess/Plugins/Netscape/NPJSObject.cpp:

880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902
2013-04-12  Sam Weinig  <sam@webkit.org>

        Make Frame's ScriptController an OwnPtr and remove the #include
        https://bugs.webkit.org/show_bug.cgi?id=114105

        Reviewed by Dean Jackson.

        * Shared/WebHitTestResult.cpp:
        * Shared/WebHitTestResult.h:
        * UIProcess/Plugins/PlugInAutoStartProvider.cpp:
        * UIProcess/WebContext.h:
        * UIProcess/WebPageProxy.h:
        * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
        * WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp:
        * WebProcess/Plugins/Netscape/NPJSObject.cpp:
        * WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
        * WebProcess/Plugins/PDF/PDFPlugin.h:
        * WebProcess/Plugins/PluginView.cpp:
        * WebProcess/Storage/StorageAreaImpl.cpp:
        * WebProcess/Storage/StorageAreaMap.cpp:
        * WebProcess/WebPage/WebFrame.cpp:
        * WebProcess/WebPage/WebPage.cpp:

903 904 905 906 907 908 909 910
2013-04-13  Zan Dobersek  <zdobersek@igalia.com>

        Unreviewed GTK build fix after r148311.

        * UIProcess/API/gtk/WebKitWebViewBase.cpp:
        (resizeWebKitWebViewBaseFromAllocation): Passing IntSize() as the scroll offset
        argument to the DrawingAreaProxy::setSize method.

911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943
2013-04-12  Gavin Barraclough  <barraclough@apple.com>

        Add private interface to WKView to asynchronously update the drawing area size
        https://bugs.webkit.org/show_bug.cgi?id=114549

        Reviewed by Simon Fraser.

        This will allow a client using the WKView to resize the contents without blocking waiting for the web process to repaint.

        * UIProcess/API/mac/WKView.mm:
        (-[WKView _setDrawingAreaSize:]):
            - if the new size of teh drawing area does not match the frame size, position it according to the contentAnchor.
        (-[WKView updateLayer]):
            - Don't let a subsequent frame size change block on a prior async resize.
        (-[WKView forceAsyncDrawingAreaSizeUpdate:]):
            - resize the drawing area asynchronously, even if frame size udpates are disabled.
        (-[WKView waitForAsyncDrawingAreaSizeUpdate]):
            - wait for asynchronous updates to complete.

        * UIProcess/API/mac/WKViewPrivate.h:
            - declare new methods.

        * UIProcess/DrawingAreaProxy.cpp:
        (WebKit):
        * UIProcess/DrawingAreaProxy.h:
        (DrawingAreaProxy):
        (WebKit::DrawingAreaProxy::waitForPossibleGeometryUpdate):
        * UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
        (TiledCoreAnimationDrawingAreaProxy):
        * UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
        (WebKit::TiledCoreAnimationDrawingAreaProxy::waitForPossibleGeometryUpdate):
            - pass timeout for waitForPossibleGeometryUpdate as a parameter.

jberlin@webkit.org's avatar
jberlin@webkit.org committed
944 945 946 947 948 949 950
2013-04-12  Jessie Berlin  <jberlin@apple.com>

        32-bit build fix.

        * UIProcess/API/mac/WKView.mm:
        (-[WKView setFrameSize:]):

951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971
2013-04-12  Jeffrey Pfau  <jpfau@apple.com>

        Query directly for cache partition names
        https://bugs.webkit.org/show_bug.cgi?id=114538

        Reviewed by David Kilzer.

        Call back into WebKitSystemInterface to ask it for the cache
        partition names instead of trying to figure them out.

        * WebProcess/ResourceCache/WebResourceCacheManager.cpp:
        (WebKit::WebResourceCacheManager::getCacheOrigins):
        (WebKit):
        (WebKit::WebResourceCacheManager::returnCacheOrigins):
        * WebProcess/ResourceCache/WebResourceCacheManager.h:
        (WebResourceCacheManager):
        * WebProcess/ResourceCache/cf/WebResourceCacheManagerCFNet.cpp:
        (WebKit::WebResourceCacheManager::cfURLCacheHostNames):
        (WebKit):
        (WebKit::WebResourceCacheManager::cfURLCacheHostNamesWithCallback):

barraclough@apple.com's avatar
barraclough@apple.com committed
972 973 974 975 976 977
2013-04-12  Gavin Barraclough  <barraclough@apple.com>

        Build fix - too soon!

        * UIProcess/API/mac/WKViewPrivate.h:

barraclough@apple.com's avatar
barraclough@apple.com committed
978 979 980 981 982 983 984
2013-04-12  Gavin Barraclough  <barraclough@apple.com>

        Build fix - too soon!

        * UIProcess/API/mac/WKView.mm:
        (-[WKView setFrameSize:]):

985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023
2013-04-12  Adenilson Cavalcanti  <cavalcantii@gmail.com>

        [WK2] WebPageProxy loadURL() won't work when called just after terminateProcess()
        https://bugs.webkit.org/show_bug.cgi?id=110743

        Reviewed by Benjamin Poulain.

        A call to loadURL() just after terminating WebProcess will fail thanks to
        WebPageProxy being in an undefined state since it is in the middle of its own
        cleanup after process termination.

        To properly fix this, not only WebPageProxy cleanup should be made
        at WebProcess termination request, but also WebProcessProxy needs
        to only return to its caller after terminating the process and
        closing connections. Otherwise, WebPageProxy can even be able to
        detect that WebProcess is no longer running, but a call to respawn
        the process will fail.

        To fix these issues, this patch moves the cleanup code to a shared private function
        that is used for both the cases i.e. user termination and real crash. WebProcess
        shutdown is done using a new method that ensures that all cleanup was done before
        returning.

        A last change introduced in this patch is that for user requested termination,
        clients are no longer notified of a crash (since it is not a crash).

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::terminateProcess):
        (WebKit::WebPageProxy::processDidCrash):
        (WebKit):
        (WebKit::WebPageProxy::resetStateAfterProcessExited):
        * UIProcess/WebPageProxy.h:
        (WebPageProxy):
        * UIProcess/WebProcessProxy.cpp:
        (WebKit::WebProcessProxy::userRequestedTerminate):
        (WebKit):
        * UIProcess/WebProcessProxy.h:
        (WebProcessProxy):

1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089
2013-04-12  Gavin Barraclough  <barraclough@apple.com>

        Add contentAnchor to WKView
        http://bugs.webkit.org/show_bug.cgi?id=114469
        
        Currently if you call setFrameSize: while frame size updates are disabled, or if the geometry
        update times out, then the previously rendered page content will be rendered anchored to the
        top left corner of the frame.

        This is appropriate if the frame is being resized from the bottom right corner. In order to
        achieve a more desirable appearance if the frame is being resized from another corner we
        should allow the corner at which the content anchors to be specified.

        Reviewed by Simon Fraser.

        * UIProcess/API/mac/WKView.mm:
        (-[WKView setFrameSize:]):
            - If the content anchor has been set, then updating the frame size moves the origin within the layer.
        (-[WKView _setDrawingAreaSize:]):
            - Instruct the drawing area to paint at the correct position within the layer.
        (-[WKView _setAcceleratedCompositingModeRootLayer:]):
            - If the root layer is cleared this implicitly resets any origin position we had set within it.
        (-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
            - initialize new data members.
        (-[WKView setContentAnchor:]):
        (-[WKView contentAnchor]):
            - Accessor implementation for @property contentAnchor.

        * UIProcess/API/mac/WKViewPrivate.h:
        (NS_ENUM):
            - Added WKContentAnchor enum type, and @property contentAnchor.

        * UIProcess/DrawingAreaProxy.cpp:
        (WebKit::DrawingAreaProxy::setSize):
            - Don't suppress geometry updates where the layer poistion has changed.

        * UIProcess/DrawingAreaProxy.h:
        (DrawingAreaProxy):
            - Added m_layerPosition, layerPosition argument to setSize

        * UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
        (TiledCoreAnimationDrawingAreaProxy):
            - Added m_lastSentLayerPosition

        * UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
        (WebKit::TiledCoreAnimationDrawingAreaProxy::didUpdateGeometry):
            - Don't suppress geometry updates where the layer poistion has changed.

        (WebKit::TiledCoreAnimationDrawingAreaProxy::sendUpdateGeometry):
            - Pass layer position in UpdateGeometry message.

        * WebProcess/WebPage/DrawingArea.h:
        (WebKit::DrawingArea::updateGeometry):
            - Added layerPosition argument to updateGeometry

        * WebProcess/WebPage/DrawingArea.messages.in:
            - Added layerPosition argument to updateGeometry

        * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
        (TiledCoreAnimationDrawingArea):
            - Added layerPosition argument to updateGeometry

        * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
        (WebKit::TiledCoreAnimationDrawingArea::updateGeometry):
            - Added layerPosition argument to updateGeometry

1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100
2013-04-12  Commit Queue  <rniwa@webkit.org>

        Unreviewed, rolling out r148296 and r148297.
        http://trac.webkit.org/changeset/148296
        http://trac.webkit.org/changeset/148297
        https://bugs.webkit.org/show_bug.cgi?id=114536

        Needs more thought (Requested by ap on #webkit).

        * NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:

1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115
2013-04-12  Tim Horton  <timothy_horton@apple.com>

        REGRESSION (r138858): GIFs don't start playing when they come out of background tabs
        https://bugs.webkit.org/show_bug.cgi?id=108864
        <rdar://problem/13140489>

        Reviewed by Antti Koivisto.

        Don't repaint the world when animations resume; instead, FrameView
        will cause all animated images to repaint. This line also had no effect for
        TiledCoreAnimationDrawingArea, which does not implement setNeedsDisplay.

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::resumeActiveDOMObjectsAndAnimations):

1116 1117 1118 1119 1120 1121 1122 1123
2013-04-12  Alexey Proskuryakov  <ap@apple.com>

        <rdar://problem/13334446> [Mac] Tweak sandbox profile.

        Apply a post-landing review comment.

        * NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:

1124 1125 1126 1127 1128 1129 1130 1131
2013-04-12  Alexey Proskuryakov  <ap@apple.com>

        <rdar://problem/13334446> [Mac] Tweak sandbox profile.

        Reviewed by Jessie Berlin.

        * NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:

1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178
2013-04-12  Carlos Garcia Campos  <cgarcia@igalia.com>

        [GTK] Split GtkAuthenticationDialog in two widgets
        https://bugs.webkit.org/show_bug.cgi?id=103644

        Reviewed by Xan Lopez.

        * GNUmakefile.list.am: Add new files to compilation.
        * UIProcess/API/gtk/WebKit2GtkAuthenticationDialog.cpp: Removed.
        * UIProcess/API/gtk/WebKit2GtkAuthenticationDialog.h: Removed.
        * UIProcess/API/gtk/WebKitAuthenticationDialog.cpp: Added.
        (webkitAuthenticationDialogAuthenticate): Use the
        AuthenticationChallengeProxy to authenticate and destroy the dialog.
        (okButtonClicked): Call webkitAuthenticationDialogAuthenticate()
        with the credential.
        (cancelButtonClicked): Call
        webkitAuthenticationDialogAuthenticate() with a NULL credential to
        continue without credential.
        (webkitAuthenticationDialogInitialize): Build the UI.
        (webkitAuthenticationDialogDraw): Draw a background.
        (webkitAuthenticationDialogMap): Grab default button.
        (webkitAuthenticationDialogConstructed): Create a GtkStyleContext
        with the GtkWindow path to draw the widget background like a real
        dialog.
        (webkit_authentication_dialog_class_init):
        (webkitAuthenticationDialogNew): Create a new
        WebKitAuthenticationDialog widget.
        * UIProcess/API/gtk/WebKitAuthenticationDialog.h: Added.
        * UIProcess/API/gtk/WebKitLoaderClient.cpp:
        * UIProcess/API/gtk/WebKitWebView.cpp:
        (webkitWebViewHandleAuthenticationChallenge): Create a
        WebKitAuthenticationDialog widget and pass add it to the
        container.
        * UIProcess/API/gtk/WebKitWebViewBase.cpp:
        (_WebKitWebViewBasePrivate): Updated to use the widget directly.
        (webkitWebViewChildIsInternalWidget): Ditto.
        (webkitWebViewBaseAddAuthenticationDialog): Ditto.
        (webkitWebViewBaseCancelAuthenticationDialog): Ditto.
        (webkitWebViewBaseContainerRemove): Ditto.
        (webkitWebViewBaseContainerForall): Ditto.
        (resizeWebKitWebViewBaseFromAllocation): Ditto.
        (webkitWebViewBaseFocus): Ditto.
        (webkitWebViewBaseDestroy): Destroy the auth widget is present.
        (webkit_web_view_base_class_init): Add implementation for
        GtkWidgetClass::destroy.
        * UIProcess/API/gtk/WebKitWebViewBasePrivate.h:

1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234
2013-04-12  Carlos Garcia Campos  <cgarcia@igalia.com>

        [GTK] Web Process crash when the UI process finishes too early
        https://bugs.webkit.org/show_bug.cgi?id=112729

        Reviewed by Anders Carlsson.

        The problem is when creating the GSocket in the WorkQeue for the
        socket descriptor. GLib considers a programmer error to create a
        GSocket providing an invalid socket and finishes the process with
        g_error(). We are actually providing a valid socket when creating
        the GSocket, but it can be invalidated by the worker thread while
        the GSocket is being created. This is because
        registerEventSourceHandler is called from the main thread and
        unregisterEventSourceHandler can be called from the worker
        thread. We are currently registering two event handlers, one to
        read data from the socket and another one to close the CoreIPC
        connection when the socket connection is broken. Every event
        source registered uses its own GSocket (even if the file
        descriptor is actually the same), so that when the UI process
        finishes too early, the first event handler can be executed in the
        worker thread, closing the socket descriptor, while the main
        thread is creating the GSocket for the second one.
        We don't really need to use a separate event handler to monitor
        the connection, because GSocket always notifies when condition is
        G_IO_HUP and G_IO_ERR even if they haven't been explicitly set in
        g_socket_create_source(). We can register socket event sources
        differently, providing also a function to be called when the
        connection is closed, using a single socket and the same even source.

        * Platform/CoreIPC/unix/ConnectionUnix.cpp:
        (CoreIPC::Connection::platformInvalidate):
        (CoreIPC::Connection::open): Register a single socket event
        handler providing also a function to be called when the connection
        is closed.
        * Platform/WorkQueue.h:
        (WorkQueue):
        * Platform/gtk/WorkQueueGtk.cpp: The EventSource class has been
        split, moving everyting specific to socket event source to a
        derived class SocketEventSource.
        (WorkQueue::EventSource::EventSource):
        (WorkQueue::EventSource::performWork):
        (WorkQueue::EventSource::performWorkOnce):
        (WorkQueue::EventSource::performWorkOnTermination):
        (WorkQueue::EventSource::deleteEventSource):
        (WorkQueue::EventSource):
        (WorkQueue::SocketEventSource):
        (WorkQueue::SocketEventSource::SocketEventSource):
        (WorkQueue::SocketEventSource::cancel):
        (WorkQueue::SocketEventSource::didClose):
        (WorkQueue::SocketEventSource::checkCondition):
        (WorkQueue::SocketEventSource::eventCallback):
        (WorkQueue::registerSocketEventHandler):
        (WorkQueue::unregisterSocketEventHandler):
        (WorkQueue::dispatchOnSource):

1235 1236 1237 1238 1239 1240 1241 1242 1243
2013-04-12  Alexey Proskuryakov  <ap@apple.com>

        <rdar://problem/13126204> [Mac] Tweak sandbox profile.

        Reviewed by Anders Carlsson.

        * NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
        * WebProcess/com.apple.WebProcess.sb.in:

1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267
2013-04-12  Manuel Rego Casasnovas  <rego@igalia.com>

        [GTK][WK2] Add document-loaded signal to WebKitWebPage
        https://bugs.webkit.org/show_bug.cgi?id=110614

        Reviewed by Carlos Garcia Campos.

        Add a new signal document-loaded to WebKitWebPage that will be emitted
        when the DOM document has been loaded for the main frame.

        * UIProcess/API/gtk/tests/TestWebExtensions.cpp:
        (documentLoadedCallback):
        (testDocumentLoadedSignal):
        (beforeAll): Add test for document-loaded signal.
        * UIProcess/API/gtk/tests/WebExtensionTest.cpp:
        (documentLoadedCallback):
        (pageCreatedCallback):
        (methodCallCallback): Add new D-Bus signal DocumentLoaded in order to
        test document-loaded signal.
        * WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
        (webkit_web_page_class_init):
        (webkitWebPageCreate): Add document-loaded signal and emit it when
        didFinishDocumentLoadForFrame is called.

1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280
2013-04-12  Hanyee Kim  <choco@company100.net>

        [GTK] Webkit fails to build webkit2gtk-tests-resources.gresource.
        https://bugs.webkit.org/show_bug.cgi?id=114485

        Reviewed by Martin Robinson.

        Generating webkit2gtk-tests-resources.gresource can be failed due to
        the non-existing target directory.
        We need to make target directory before generating it.

        * UIProcess/API/gtk/tests/GNUmakefile.am:

1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310
2013-04-12  Andreas Kling  <akling@apple.com>

        REGRESSION(r145869): Right-click on SWF contents displays the context menu at the wrong place.
        <http://webkit.org/b/113836>
        <rdar://problem/13587624>

        Reviewed by Anders "Wesley Crusher" Carlsson.

        Mac plugins expect flipped-Y screen coordinates, while DOM APIs speak in unflipped coordinates,
        and we were mixing them up in the window frame caching optimization.

        Solve this by having the UIProcess send both flipped and unflipped window frames to the WebProcess.
        The flipped frame is passed on to plugins, and the unflipped frame is used for window.screenX/Y etc.

        * UIProcess/API/mac/WKView.mm:
        (-[WKView _updateWindowAndViewFrames]):

            No need to retrieve the window frame here as WebPageProxy::windowAndViewFramesChanged() will
            always override it anyway.

        * UIProcess/mac/WebPageProxyMac.mm:
        (WebKit::WebPageProxy::windowAndViewFramesChanged):
        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
        (WebKit::WebChromeClient::windowRect):
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::windowAndViewFramesChanged):
        * WebProcess/WebPage/WebPage.h:
        (WebKit::WebPage::windowFrameInUnflippedScreenCoordinates):
        * WebProcess/WebPage/WebPage.messages.in:

1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361
2013-04-12  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>

        [WK2][EFL] WebView: Add callbacks to the WKViewClient to handle page viewport update
        https://bugs.webkit.org/show_bug.cgi?id=110463

        Reviewed by Anders Carlsson.

        * UIProcess/efl/ViewClientEfl.h:
        (ViewClientEfl):
        * UIProcess/efl/WebView.cpp:
        (WebKit::WebView::didChangeViewportProperties):
        * UIProcess/efl/WebViewClient.cpp:
        (WebKit::WebViewClient::didChangeViewportAttributes):
        (WebKit):
        * UIProcess/efl/WebViewClient.h:

            Added didChangeViewportAttributes callback to the WKViewClient to
            handle page viewport updates.

        * CMakeLists.txt:
        * Shared/API/c/WKBase.h:
        * Shared/APIObject.h:
        * UIProcess/API/C/WKAPICast.h:
        (WebKit):
        * UIProcess/API/C/WKViewportAttributes.cpp: Added.
        (WKViewportAttributesGetTypeID):
        * UIProcess/API/C/WKViewportAttributes.h: Added.
        * UIProcess/API/C/efl/WKView.h:
        * UIProcess/WebViewportAttributes.cpp: Added.
        (WebKit):
        (WebKit::WebViewportAttributes::WebViewportAttributes):
        (WebKit::WebViewportAttributes::~WebViewportAttributes):
        * UIProcess/WebViewportAttributes.h: Added.
        (WebKit):
        (WebViewportAttributes):
        (WebKit::WebViewportAttributes::create):
        (WebKit::WebViewportAttributes::originalAttributes):
        (WebKit::WebViewportAttributes::type):

            Added WKViewportAttributesRef - WK2 C API object that is wrapping 
            WebCore::ViewportAttributes structure and is passed in didChangeViewportAttributes
            WKViewClient callback.

        * UIProcess/efl/ViewClientEfl.cpp:
        (WebKit::ViewClientEfl::didChangeViewportAttributes):
        (WebKit):

            Added implementaion of didChangeViewportAttributes WKViewClient 
            callback so that existing EFL WK2 funtionality is kept.


1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377
2013-04-12  Carlos Garcia Campos  <cgarcia@igalia.com>

        [GTK] The style of visited links doesn't change in WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=112175

        Reviewed by Benjamin Poulain.

        The problem is that visited links were not tracked by the web
        process. There's a web process initial parameter to set whether
        web process should track visited links or not and it's disabled by
        default.

        * UIProcess/gtk/WebContextGtk.cpp:
        (WebKit::WebContext::platformInitializeWebProcess): Always set
        shouldTrackVisitedLinks to true.

1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390
2013-04-11  Tim Horton  <timothy_horton@apple.com>

        REGRESSION (r146956): ASSERTion failure: WebKit::WebProcess::pageWillLeaveWindow
        https://bugs.webkit.org/show_bug.cgi?id=114481
        <rdar://problem/13534784>

        Reviewed by Simon Fraser.

        Inform the WebProcess of WebPages which are already in a window when created.

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::WebPage):

1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427
2013-04-11  Anders Carlsson  <andersca@apple.com>

        Add support for clearing storage areas
        https://bugs.webkit.org/show_bug.cgi?id=114479

        Reviewed by Beth Dakin.

        * UIProcess/Storage/StorageManager.cpp:
        (WebKit::StorageManager::StorageArea::StorageArea):
        Store the quota size so we can recreate the underlying StorageMap when clearing.
        
        (WebKit::StorageManager::StorageArea::clear):
        Create a new storage map and dispatch events.

        (WebKit::StorageManager::clear):
        Find the right storage area and call clear.

        * UIProcess/Storage/StorageManager.messages.in:
        Add Clear message.

        * WebProcess/Storage/StorageAreaImpl.cpp:
        (WebKit::StorageAreaImpl::clear):
        Call the storage map.

        * WebProcess/Storage/StorageAreaMap.cpp:
        (WebKit::StorageAreaMap::clear):
        Reset the cached values and send a clear message.

        (WebKit::StorageAreaMap::resetValues):
        New helper function.

        (WebKit::StorageAreaMap::didClear):
        New stub.

        * WebProcess/Storage/StorageAreaMap.messages.in:
        Add DidClear message.

1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446
2013-04-11  Beth Dakin  <bdakin@apple.com>

        WebKit should set the header and footer layers' contentsScale when the device 
        scale factor changes
        https://bugs.webkit.org/show_bug.cgi?id=114471
        -and corresponding-
        <rdar://problem/13621288>

        Reviewed by Simon Fraser.

        Update the header and footer contentsScale when the device scale factor has 
        changed.

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::setDeviceScaleFactor):
        * WebProcess/WebPage/WebPage.h:
        * WebProcess/WebPage/mac/WebPageMac.mm:
        (WebKit::WebPage::updateHeaderAndFooterLayersForDeviceScaleChange):

1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481
2013-04-11  Anders Carlsson  <andersca@apple.com>

        Implement removing storage area items
        https://bugs.webkit.org/show_bug.cgi?id=114472

        Reviewed by Beth Dakin.

        * UIProcess/Storage/StorageManager.cpp:
        (StorageManager::StorageArea):
        (WebKit::StorageManager::StorageArea::setItem):
        Rename connection to sourceConnection.

        (WebKit::StorageManager::StorageArea::removeItem):
        Remove the item from the map and dispatch events if needed.

        (WebKit::StorageManager::removeItem):
        Find the right storage area, remove the item and send back a DidRemoveItem message.

        * UIProcess/Storage/StorageManager.messages.in:
        Add RemoveItem message.

        * WebProcess/Storage/StorageAreaImpl.cpp:
        (WebKit::StorageAreaImpl::removeItem):
        Call StorageAreaMap::removeItem.

        * WebProcess/Storage/StorageAreaMap.cpp:
        (WebKit::StorageAreaMap::removeItem):
        Send a RemoveItem message to the storage manager.
        
        (WebKit::StorageAreaMap::didRemoveItem):
        Add empty stub.

        * WebProcess/Storage/StorageAreaMap.messages.in:
        Add DidRemoveItem message.

1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496
2013-04-11  Tim Horton  <timothy_horton@apple.com>

        InjectedBundleNodeHandle::imageForRect doesn't respect device scale factor or highlighting option
        https://bugs.webkit.org/show_bug.cgi?id=114466
        <rdar://problem/13508513>

        Reviewed by Simon Fraser.

        Respect the device scale factor when creating the snapshot image.
        Clear the snapshot image before drawing into it.
        Respect SnapshotOptionsExcludeSelectionHighlighting.

        * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
        (WebKit::imageForRect):

1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519
2013-04-11  Commit Queue  <rniwa@webkit.org>

        Unreviewed, rolling out r148034, r148052, r148097, and
        r148194.
        http://trac.webkit.org/changeset/148034
        http://trac.webkit.org/changeset/148052
        http://trac.webkit.org/changeset/148097
        http://trac.webkit.org/changeset/148194
        https://bugs.webkit.org/show_bug.cgi?id=114463

        broke mutiresolution favicons, among other things (Requested
        by thorton on #webkit).

        * UIProcess/WebIconDatabase.cpp:
        (WebKit::WebIconDatabase::setIconDataForIconURL):
        * UIProcess/WebIconDatabase.h:
        (WebIconDatabase):
        * UIProcess/WebIconDatabase.messages.in:
        * WebProcess/IconDatabase/WebIconDatabaseProxy.cpp:
        (WebKit::WebIconDatabaseProxy::setIconDataForIconURL):
        * WebProcess/Plugins/PDF/PDFPlugin.mm:
        (WebKit::PDFPlugin::destroy):

1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531
2013-04-11  Anders Carlsson  <andersca@apple.com>

        Implement StorageManager::getValues
        https://bugs.webkit.org/show_bug.cgi?id=114461

        Reviewed by Beth Dakin.

        * UIProcess/Storage/StorageManager.cpp:
        (WebKit::StorageManager::StorageArea::items):
        (WebKit::StorageManager::getValues):
        Return the items from the right storage area.

1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555
2013-04-11  Anders Carlsson  <andersca@apple.com>

        Clean up related storage areas when a connection is destroyed
        https://bugs.webkit.org/show_bug.cgi?id=114459

        Reviewed by Beth Dakin.

        * UIProcess/Storage/StorageManager.cpp:
        (WebKit::StorageManager::processWillCloseConnection):
        Dispatch invalidateConnectionInternal on the work queue.
        
        (WebKit::StorageManager::createStorageMap):
        (WebKit::StorageManager::destroyStorageMap):
        Rename m_storageAreas to m_storageAreasByConnection.

        (WebKit::StorageManager::invalidateConnectionInternal):
        Go over all known storage areas and remove this connection as a listener.

        (WebKit::StorageManager::findStorageArea):
        Rename m_storageAreas to m_storageAreasByConnection.

        * UIProcess/Storage/StorageManager.h:
        Rename m_storageAreas to m_storageAreasByConnection.

1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572
2013-04-11  Anders Carlsson  <andersca@apple.com>

        Make StorageAreaMap dispatch session storage events
        https://bugs.webkit.org/show_bug.cgi?id=114454

        Reviewed by Beth Dakin.

        * WebProcess/Storage/StorageAreaMap.cpp:
        (WebKit::StorageAreaMap::dispatchStorageEvent):
        Depending on the storage area type, call dispatchSessionStorageEvent or dispatchLocalStorageEvent.

        (WebKit::StorageAreaMap::dispatchSessionStorageEvent):
        Enumerate all the frames in our page and dispatch the event to the relevant ones.

        (WebKit::StorageAreaMap::dispatchLocalStorageEvent):
        Add empty stub for now.

1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632
2013-04-11  Anders Carlsson  <andersca@apple.com>

        Implement more logic in StorageAreaMap
        https://bugs.webkit.org/show_bug.cgi?id=114451

        Reviewed by Alexey Proskuryakov.

        * Platform/CoreIPC/HandleMessage.h:
        (CoreIPC::callMemberFunction):
        Add new overload.

        * UIProcess/Storage/StorageManager.cpp:
        (WebKit::StorageManager::StorageArea::addListener):
        (WebKit::StorageManager::StorageArea::removeListener):
        These take storage map IDs.

        (WebKit::StorageManager::StorageArea::setItem):
        Rename storageAreaID to sourceStorageAreaID.

        (WebKit::StorageManager::StorageArea::dispatchEvents):
        Remove the code that would not dispatch to the source connection, there may still be storage areas interested in those events.

        (WebKit::StorageManager::setItem):
        This now takes the source storage area ID.

        (WebKit::StorageManager::findStorageArea):
        This takes a storage map ID.

        * UIProcess/Storage/StorageManager.messages.in:
        SetItem now takes the source storage area ID as well.

        * WebProcess/Storage/StorageAreaImpl.cpp:
        (WebKit::StorageAreaImpl::setItem):
        Pass the source frame to StorageAreaMap::setItem.

        * WebProcess/Storage/StorageAreaMap.cpp:
        (WebKit::StorageAreaMap::StorageAreaMap):
        Send CreateStorageMap and add the object as a message receiver.

        (WebKit::StorageAreaMap::~StorageAreaMap):
        Send DestroyStorageMap and remove the object as a message receiver.

        (WebKit::StorageAreaMap::length):
        (WebKit::StorageAreaMap::key):
        (WebKit::StorageAreaMap::item):
        (WebKit::StorageAreaMap::contains):
        Load values and forward calls to the storage map.

        (WebKit::StorageAreaMap::setItem):
        This now takes the source frame as well. Update the local storage map and send a SetItem message.
        
        (WebKit::StorageAreaMap::loadValuesIfNeeded):
        Get the values from the storage manager.

        (WebKit::StorageAreaMap::dispatchStorageEvent):
        This now takes the source storage area ID.

        * WebProcess/Storage/StorageAreaMap.messages.in:
        DispatchStorageEvent now takes the source storage area ID.

1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645
2013-04-10  Brady Eidson  <beidson@apple.com>

        Web/Plugin process deadlock initializing async plugins.
        <rdar://problem/13525232> and https://bugs.webkit.org/show_bug.cgi?id=114217

        Rubberstamped by Anders Carlsson.

        Rollout r147953 and r147968 as we identified other causes for this.

        * PluginProcess/WebProcessConnection.cpp:
        (WebKit::WebProcessConnection::createPluginAsynchronously):
        * WebProcess/Plugins/PluginProxy.messages.in:

1646 1647 1648 1649 1650 1651 1652 1653 1654 1655
2013-04-11  Alexey Proskuryakov  <ap@apple.com>

        Remove some ResourceHandle.h includes
        https://bugs.webkit.org/show_bug.cgi?id=114416

        Reviewed by Ryosuke Niwa.

        * WebProcess/Network/NetworkProcessConnection.cpp: Added an include that is now
        necessary.

1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667
2013-04-11  Allan Sandfeld Jensen  <allan.jensen@digia.com>

        [Qt] EventHandler should handle Space and BackSpace 
        https://bugs.webkit.org/show_bug.cgi?id=114428

        Reviewed by Jocelyn Turcotte.

        Remove our own handling of space and backspace.

        * WebProcess/WebPage/qt/WebPageQt.cpp:
        (WebKit::WebPage::performDefaultBehaviorForKeyEvent):

1668 1669 1670 1671 1672 1673 1674
2013-04-11  Csaba Osztrogonác  <ossy@webkit.org>

        Unreviewed Qt buildfixes after r148147, r148148 and r148154.

        * DerivedSources.pri:
        * Target.pri:

1675 1676 1677 1678 1679 1680
2013-04-10  Zan Dobersek  <zdobersek@igalia.com>

        Unreviewed GTK build fix, fixing the WebKit2 build.

        * GNUmakefile.list.am:

1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692
2013-04-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        [WK2] Build warning in didReceiveMessage() generated by messages.py
        https://bugs.webkit.org/show_bug.cgi?id=112513

        Reviewed by Anders Carlsson.

        Legacy receiver makes -Wunused-parameter build warnings. This patch is to fix them.

        * Scripts/webkit2/messages.py:
        (generate_message_handler):

1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704
2013-04-10  Jaehun Lim  <ljaehun.lim@samsung.com>

        [CMAKE] Build fix after StorageArea refactoring
        https://bugs.webkit.org/show_bug.cgi?id=114398

        Unreviewed build fix.

        Change StorageAreaImpl.messages.in with StorageAreaMap.messages.in.
        Add StorageAreaMap.cpp in CMakeLists.txt.

        * CMakeLists.txt:

1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744
2013-04-10  Anders Carlsson  <andersca@apple.com>

        Make StorageAreaImpl a wrapper around StorageAreaMap
        https://bugs.webkit.org/show_bug.cgi?id=114404

        Reviewed by Oliver Hunt.

        Prepare for moving all the code that deals with local storage values to StorageAreaMap,
        and make StorageAreaImpl a dumb wrapper that simply calls through to the map.

        * WebProcess/Storage/StorageAreaImpl.cpp:
        (WebKit::StorageAreaImpl::create):
        (WebKit::StorageAreaImpl::StorageAreaImpl):
        (WebKit::StorageAreaImpl::~StorageAreaImpl):
        (WebKit::StorageAreaImpl::storageType):
        (WebKit::StorageAreaImpl::length):
        (WebKit::StorageAreaImpl::key):
        (WebKit::StorageAreaImpl::getItem):
        (WebKit::StorageAreaImpl::setItem):
        (WebKit::StorageAreaImpl::contains):
        * WebProcess/Storage/StorageAreaImpl.h:
        (WebKit::StorageAreaImpl::storageAreaID):
        * WebProcess/Storage/StorageAreaMap.cpp:
        (WebKit::generateStorageMapID):
        (WebKit::StorageAreaMap::create):
        (WebKit::StorageAreaMap::StorageAreaMap):
        (WebKit::StorageAreaMap::storageType):
        (WebKit::StorageAreaMap::length):
        (WebKit::StorageAreaMap::key):
        (WebKit::StorageAreaMap::item):
        (WebKit::StorageAreaMap::setItem):
        (WebKit::StorageAreaMap::contains):
        (WebKit::StorageAreaMap::didSetItem):
        (WebKit::StorageAreaMap::dispatchStorageEvent):
        * WebProcess/Storage/StorageAreaMap.h:
        * WebProcess/Storage/StorageNamespaceImpl.cpp:
        (WebKit::StorageNamespaceImpl::storageArea):
        * WebProcess/Storage/StorageNamespaceImpl.h:
        (StorageNamespaceImpl):

1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761
2013-04-10  Anders Carlsson  <andersca@apple.com>

        Rename StorageManager messages to refer to the StorageMap instead of the StorageArea
        https://bugs.webkit.org/show_bug.cgi?id=114401

        Reviewed by Ryosuke Niwa.

        * UIProcess/Storage/StorageManager.cpp:
        (WebKit::StorageManager::createStorageMap):
        (WebKit::StorageManager::destroyStorageMap):
        (WebKit::StorageManager::setItem):
        * UIProcess/Storage/StorageManager.h:
        * UIProcess/Storage/StorageManager.messages.in:
        * WebProcess/Storage/StorageAreaImpl.cpp:
        (WebKit::StorageAreaImpl::StorageAreaImpl):
        (WebKit::StorageAreaImpl::~StorageAreaImpl):

1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812
2013-04-10  Benjamin Poulain  <bpoulain@apple.com>

        Mass remove all the empty directories

        Rubberstamped by Ryosuke Niwa.

        * Platform/CoreIPC/gtk: Removed.
        * Platform/CoreIPC/qt: Removed.
        * PluginProcess/EntryPoint/mac/XPCService/PluginService.32: Removed.
        * PluginProcess/EntryPoint/mac/XPCService/PluginService.64: Removed.
        * PluginProcess/gtk: Removed.
        * Shared/API/c/win: Removed.
        * Shared/Plugins/Netscape/win: Removed.
        * Shared/cg/win: Removed.
        * Shared/win: Removed.
        * UIProcess/API/C/win: Removed.
        * UIProcess/API/gtk/webkit: Removed.
        * UIProcess/Launcher/win: Removed.
        * UIProcess/Plugins/gtk: Removed.
        * UIProcess/Plugins/win: Removed.
        * UIProcess/texmap: Removed.
        * UIProcess/win: Removed.
        * WebProcess/Authentication/mac: Removed.
        * WebProcess/Cookies/efl: Removed.
        * WebProcess/Cookies/gtk: Removed.
        * WebProcess/Downloads/cf/win: Removed.
        * WebProcess/Downloads/cfnet: Removed.
        * WebProcess/Downloads/curl: Removed.
        * WebProcess/Downloads/efl: Removed.
        * WebProcess/Downloads/gtk: Removed.
        * WebProcess/Downloads/mac: Removed.
        * WebProcess/Downloads/qt: Removed.
        * WebProcess/Downloads/soup: Removed.
        * WebProcess/FullScreen/gtk: Removed.
        * WebProcess/FullScreen/mac: Removed.
        * WebProcess/FullScreen/qt: Removed.
        * WebProcess/FullScreen/win: Removed.
        * WebProcess/InjectedBundle/API/c/win: Removed.
        * WebProcess/InjectedBundle/win: Removed.
        * WebProcess/KeyValueStorage: Removed.
        * WebProcess/Network/CustomProtocols/mac: Removed.
        * WebProcess/Plugins/Netscape/gtk: Removed.
        * WebProcess/Plugins/Netscape/win: Removed.
        * WebProcess/WebCoreSupport/win: Removed.
        * WebProcess/WebPage/LayerTreeCoordinator: Removed.
        * WebProcess/WebPage/ca/mac: Removed.
        * WebProcess/WebPage/ca/win: Removed.
        * WebProcess/WebPage/win: Removed.
        * WebProcess/win: Removed.
        * qt/Resources: Removed.

1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823
2013-04-10  Jaehun Lim  <ljaehun.lim@samsung.com>

        [CMAKE] Build fix after r148147, r148148
        https://bugs.webkit.org/show_bug.cgi?id=114395

        Unreviewed build fix.

        Use StorageAreaImpl, StorageNamespaceImpl instead of StorageAreaProxy, StorageNamespaceProxy.

        * CMakeLists.txt:

1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854
2013-04-10  Anders Carlsson  <andersca@apple.com>

        Add a stubbed out StorageAreaMap class
        https://bugs.webkit.org/show_bug.cgi?id=114392

        Reviewed by Andreas Kling.

        The intention is that StorageAreaMap is going to take over responsibility for storing the storage values in the
        web process, as well as dispatching events. A StorageAreaMap will be shared between multiple StorageAreaImpl objects,
        for example if multiple frames with the same origin use local storage.

        * DerivedSources.make:
        * UIProcess/Storage/StorageManager.cpp:
        (WebKit::StorageManager::StorageArea::dispatchEvents):
        (WebKit::StorageManager::setItem):
        * WebKit2.xcodeproj/project.pbxproj:
        * WebProcess/Storage/StorageAreaImpl.cpp:
        (WebKit::StorageAreaImpl::StorageAreaImpl):
        (WebKit::StorageAreaImpl::~StorageAreaImpl):
        * WebProcess/Storage/StorageAreaMap.cpp: Added.
        (WebKit):
        (WebKit::StorageAreaMap::create):
        (WebKit::StorageAreaMap::StorageAreaMap):
        (WebKit::StorageAreaMap::~StorageAreaMap):
        (WebKit::StorageAreaMap::didSetItem):
        (WebKit::StorageAreaMap::dispatchStorageEvent):
        * WebProcess/Storage/StorageAreaMap.h: Added.
        (WebKit):
        (StorageAreaMap):
        * WebProcess/Storage/StorageAreaMap.messages.in: Renamed from Source/WebKit2/WebProcess/Storage/StorageAreaImpl.messages.in.

1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874
2013-04-10  Anders Carlsson  <andersca@apple.com>

        Rename StorageAreaProxy to StorageAreaImpl.

        Rubber-stamped by Beth Dakin.

        * DerivedSources.make:
        * UIProcess/Storage/StorageManager.cpp:
        (WebKit::StorageManager::StorageArea::dispatchEvents):
        (WebKit::StorageManager::setItem):
        * WebKit2.xcodeproj/project.pbxproj:
        * WebProcess/Storage/StorageAreaImpl.cpp: Renamed from Source/WebKit2/WebProcess/Storage/StorageAreaProxy.cpp.
        * WebProcess/Storage/StorageAreaImpl.h: Renamed from Source/WebKit2/WebProcess/Storage/StorageAreaProxy.h.
        * WebProcess/Storage/StorageAreaImpl.messages.in: Renamed from Source/WebKit2/WebProcess/Storage/StorageAreaProxy.messages.in.
        * WebProcess/Storage/StorageNamespaceImpl.cpp:
        (WebKit::StorageNamespaceImpl::storageArea):
        * WebProcess/Storage/StorageNamespaceImpl.h:
        (WebKit):
        (StorageNamespaceImpl):

1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891
2013-04-10  Anders Carlsson  <andersca@apple.com>

        Rename StorageNamespaceProxy to StorageNamespaceImpl.

        Rubber-stamped by Beth Dakin.

        * WebKit2.xcodeproj/project.pbxproj:
        * WebProcess/Storage/StorageAreaProxy.cpp:
        (WebKit::StorageAreaProxy::create):
        (WebKit::StorageAreaProxy::StorageAreaProxy):
        * WebProcess/Storage/StorageAreaProxy.h:
        (StorageAreaProxy):
        * WebProcess/Storage/StorageNamespaceImpl.cpp: Renamed from Source/WebKit2/WebProcess/Storage/StorageNamespaceProxy.cpp.
        * WebProcess/Storage/StorageNamespaceImpl.h: Renamed from Source/WebKit2/WebProcess/Storage/StorageNamespaceProxy.h.
        * WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
        (WebKit::WebPlatformStrategies::sessionStorageNamespace):

1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905 1906 1907
2013-04-10  Tim Horton  <timothy_horton@apple.com>

        [wk2] Un-pollute TCADA methods with "PageOverlayLayerMap::iterator end"
        https://bugs.webkit.org/show_bug.cgi?id=114387

        Reviewed by Simon Fraser.

        * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
        (WebKit::TiledCoreAnimationDrawingArea::updatePreferences):
        (WebKit::TiledCoreAnimationDrawingArea::paintContents):
        (WebKit::TiledCoreAnimationDrawingArea::flushLayers):
        (WebKit::TiledCoreAnimationDrawingArea::setExposedRect):
        (WebKit::TiledCoreAnimationDrawingArea::mainFrameScrollabilityChanged):
        (WebKit::TiledCoreAnimationDrawingArea::updateGeometry):
        (WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):

1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926
2013-04-10  Tim Horton  <timothy_horton@apple.com>

        [wk2] REGRESSION: Find highlight does not update when the view is resized
        https://bugs.webkit.org/show_bug.cgi?id=114382
        <rdar://problem/13599797>

        Reviewed by Simon Fraser.

        Invalidate the page overlays from TiledCoreAnimationDrawingArea::updateGeometry.
        This will have no effect if the page overlay hasn't previously asked to be painted
        (as drawsContent will remain false on the layer).

        * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
        (TiledCoreAnimationDrawingArea): Add invalidateAllPageOverlays.
        * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
        (WebKit::TiledCoreAnimationDrawingArea::invalidateAllPageOverlays): Factor this out of didChangeScrollOffsetForAnyFrame.
        (WebKit::TiledCoreAnimationDrawingArea::didChangeScrollOffsetForAnyFrame): Call invalidateAllPageOverlays.
        (WebKit::TiledCoreAnimationDrawingArea::updateGeometry): Call invalidateAllPageOverlays.

1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940
2013-04-10  Beth Dakin  <bdakin@apple.com>

        FindBanner matches are offset when the WKView has a header or footer
        https://bugs.webkit.org/show_bug.cgi?id=114314
        -and corresponding-
        <rdar://problem/13522434>

        Reviewed by Simon Fraser.

        When calculating the matching rects, also adjust to the scroll offset that is  
        relative to the Document.
        * WebProcess/WebPage/FindController.cpp:
        (WebKit::FindController::rectsForTextMatches):

1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952 1953 1954 1955 1956 1957 1958 1959 1960 1961
2013-04-10  Tobias Mueller  <tobiasmue@gnome.org>

        Fixed build failure in Plugin.h: FloatPoint was not in namespace WebCore

        make[1]: *** Waiting for unfinished jobs....
        In file included from Source/WebKit2/PluginProcess/PluginCreationParameters.h:31:0,
                         from Source/WebKit2/PluginProcess/PluginCreationParameters.cpp:27:
        ./Source/WebKit2/WebProcess/Plugins/Plugin.h:268:58: error: 'FloatPoint' in namespace 'WebCore' does not name a type
        ./Source/WebKit2/WebProcess/Plugins/Plugin.h:268:77: error: ISO C++ forbids declaration of 'parameter' with no type [-fpermissive]
        cc1plus: warning: unrecognized command line option "-Wno-c++11-extensions" [enabled by default]
        make[1]: *** [Source/WebKit2/PluginProcess/libwebkit2gtk_3_0_la-PluginCreationParameters.lo] Error 1

        It now passes that make target.

        https://bugs.webkit.org/show_bug.cgi?id=111862

        Reviewed by Darin Adler.

        * WebProcess/Plugins/Plugin.h:
        (WebCore): Added FloatPoint to the WebCore namespace

1962 1963 1964 1965 1966 1967 1968 1969 1970 1971 1972 1973 1974
2013-04-08  Anders Carlsson  <andersca@apple.com>

        Remove unneeded headers from FrameLoader.h
        https://bugs.webkit.org/show_bug.cgi?id=114223

        Reviewed by Geoffrey Garen.

        Include HistoryController.h from WebCore.

        * WebProcess/Plugins/PDF/SimplePDFPlugin.h:
        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
        * WebProcess/WebPage/WebPage.cpp:

1975 1976 1977 1978 1979 1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990 1991 1992
2013-04-09  Geoffrey Garen  <ggaren@apple.com>

        Removed bitrotted TimeoutChecker code
        https://bugs.webkit.org/show_bug.cgi?id=114336

        Reviewed by Alexey Proskuryakov.

        This mechanism hasn't worked for a while.

        MarkL is working on a new version of this feature with a distinct
        implementation.

        * WebProcess/Plugins/Netscape/NPJSObject.cpp:
        (WebKit::NPJSObject::construct):
        (WebKit::NPJSObject::invoke):
        * WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
        (WebKit::NPRuntimeObjectMap::evaluate):

1993 1994 1995 1996 1997 1998
2013-04-09  Mark Rowe  <mrowe@apple.com>

        <rdar://problem/13617144> WKNavigationData needs to expose the destination of the navigation

        Introduce WKNavigationDataCopyNavigationDestinationURL to access the destination of the navigation.

1999
        Reviewed by Dan Bernstein.
2000 2001 2002 2003 2004 2005 2006 2007 2008 2009

        * UIProcess/API/C/WKNavigationData.cpp:
        (WKNavigationDataCopyURL): Add a note about returning the URL from the original request for sake of
        backwards-compatibility.
        (WKNavigationDataCopyNavigationDestinationURL): Return the URL from our underlying WebNavigationDataStore.
        * UIProcess/API/C/WKNavigationData.h:
        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebKit::WebFrameLoaderClient::updateGlobalHistory): Store the current URL in to the WebNavigationDataStore
        object. WKNavigationData can retrieve the value that we were previously storing here via the originalRequest.

2010 2011 2012 2013 2014 2015 2016 2017 2018 2019 2020 2021 2022 2023 2024 2025 2026
2013-04-09  Mark Rowe  <mrowe@apple.com>

        <rdar://problem/13617104> WKPageCopySessionState needs to provide more context to the filter callback

        Introduce a new value type for WKPageSessionStateFilterCallback that represents the passing
        of whole WKBackForwardListItemRefs to the filter callback. This allows clients to consider
        more than the original URL of the item when filtering entries from the session state.

        Reviewed by Darin Adler.

        * UIProcess/API/C/WKPage.cpp:
        (WKPageGetSessionBackForwardListItemValueType): Return a static string representing our new value type.
        * UIProcess/API/C/WKPage.h:
        * UIProcess/cf/WebBackForwardListCF.cpp:
        (WebKit::WebBackForwardList::createCFDictionaryRepresentation): Call the filter function with each of the
        possible value types in turn, respecting the first false value, if any, that is returned.

2027 2028 2029 2030 2031 2032 2033 2034 2035 2036 2037 2038 2039 2040 2041 2042
2013-04-10  Anton Obzhirov  <a.obzhirov@samsung.com>

        [GTK] Add support for Page Visibility
        https://bugs.webkit.org/show_bug.cgi?id=97324

        Reviewed by Sam Weinig.

        Added new unittest to test page visibility using GTK Widget visibility API.

        * UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
        (testWebViewPageVisibility):
        (beforeAll):
        * UIProcess/API/gtk/tests/WebViewTest.cpp:
        (WebViewTest::showInWindow):
        * UIProcess/API/gtk/tests/WebViewTest.h:

2043 2044 2045 2046 2047 2048 2049 2050 2051 2052 2053 2054 2055 2056 2057 2058 2059 2060 2061 2062 2063 2064 2065 2066 2067 2068 2069 2070 2071 2072 2073 2074 2075 2076 2077 2078 2079 2080 2081
2013-04-10  Zan Dobersek  <zdobersek@igalia.com>

        REGRESSION (r146518): WebKit2APITests/TestInspector is failing
        https://bugs.webkit.org/show_bug.cgi?id=113281

        Reviewed by Darin Adler.

        Changes to the WebInspectorProxy opening processing in r146518 caused the change in how the GTK-specific
        WebInspectorProxy code operates, specifically the 'bring-to-front' signal is not emitted anymore when opening the
        inspector due to the WebInspectorProxy::bringToFront method now only bringing the inspector window to front if it exists
        and opening it (and thus unable to bring it to front) otherwise.

        Closing of the inspector through the didClose method is now done immediately after sending the WebInspector::Close()
        message to the WebProcess rather than waiting for the WebProcess to communicate back the order of closing. Due to this
        the relevant code in the test cases had to be changed to not run the loop but rather just check that the closing was
        successful.

        (InspectorTest::InspectorTest): Remove the initialization of the now redundant m_quitOnBringToFront member variable.
        (InspectorTest::bringToFront): Quit the loop without checking the removed member variable.
        (InspectorTest::closed): Do not quit the loop as it is not run anymore.
        (InspectorTest::showIdle): A helper method that asynchronously calls the webkit_web_inspector_show method, removing some
        unnecessary complexity about under what exact circumstances to quit the loop in open-window/bring-to-front callbacks.
        (InspectorTest::show): Replaces the showAndWaitUntilFinished method, adding an idle invocation of the showIdle helper
        method and running the loop.
        (InspectorTest::close): Formerly closeAndWaitUntilClosed, now does not run the loop anymore as there's no need for it.
        (testInspectorDefault): Only the window opening event is now expected upon showing the inspector for the first time.
        Adjusting callsites to use InspectorTest::show and InspectorTest::close instead of
        InspectorTest::showAndWaitUntilFinished and InspectorTest::showAndWaitUntilFinished.
        (CustomInspectorTest::destroyWindow): Formerly destroyWindowAndWaitUntilClosed, the closing is not asynchronous anymore
        so the loop is not run.
        (testInspectorManualAttachDetach): Only the window opening event is now expected upon showing the inspector for the first time.
        Adjusting callsites to use InspectorTest::show and InspectorTest::close instead of
        InspectorTest::showAndWaitUntilFinished and InspectorTest::showAndWaitUntilFinished.
        (testInspectorCustomContainerDestroyed): Adjusting callsites to use InspectorTest::show and CustomInspectorTest::destroyWindow
        instead of InspectorTest::showAndWaitUntilFinished and CustomInspectorTest::destroyWindowAndWaitUntilClosed.
        * UIProcess/WebInspectorProxy.cpp:
        (WebKit::WebInspectorProxy::show): When showing a connected WebInspectorProxy, call the bringToFront method which will
        open the inspector if it's not yet visible or bring it to the front otherwise. 

2082 2083 2084 2085 2086 2087 2088 2089 2090 2091 2092 2093 2094 2095 2096 2097 2098 2099
2013-04-10  Zan Dobersek  <zandobersek@gmail.com>

        [GTK][WK2] Implement WebInspectorProxy::platformInspectedWindowWidth
        https://bugs.webkit.org/show_bug.cgi?id=113498

        Reviewed by Martin Robinson.

        The method was introduced in r147004.

        * UIProcess/API/gtk/tests/TestInspector.cpp: Specify the gMinimumAttachedInspectorWidth variable, reflecting the value
        of WebInspectorProxy::minimumAttachedWidth. Use it as the width to which the inspected view should be resized in
        InspectorTest::resizeViewAndAttach.
        * UIProcess/gtk/WebInspectorProxyGtk.cpp:
        (WebKit::WebInspectorProxy::platformInspectedWindowHeight): Use the gtk_widget_get_allocated_height method to return the
        widget height.
        (WebKit::WebInspectorProxy::platformInspectedWindowWidth): Newly implemented, similarly uses the
        gtk_widget_get_allocated_width method to return the widget width.

2100 2101 2102 2103 2104 2105 2106 2107 2108 2109 2110 2111 2112
2013-04-09  Antoine Quint  <graouts@apple.com>

        WKFrameIsDisplayingMarkupDocument should return true for Web Archives
        https://bugs.webkit.org/show_bug.cgi?id=114291

        Reviewed by Dean Jackson.

        Also return true for the Web Archive MIME type since a Web Archive
        is displaying a markup document by nature.

        * UIProcess/WebFrameProxy.cpp:
        (WebKit::WebFrameProxy::isDisplayingMarkupDocument):

2113 2114 2115 2116 2117 2118 2119 2120 2121 2122 2123 2124 2125
2013-04-09  Anders Carlsson  <andersca@apple.com>

        REGRESSION (r147454): Youtube annotation links to new window broken
        https://bugs.webkit.org/show_bug.cgi?id=114242
        <rdar://problem/13609940>

        Reviewed by Beth Dakin.

        Set the current user gesture to "DefinitelyProcessingNewUserGesture" if popups are allowed.

        * WebProcess/Plugins/PluginView.cpp:
        (WebKit::PluginView::performFrameLoadURLRequest):

2126 2127 2128 2129 2130 2131 2132 2133 2134 2135 2136 2137 2138
2013-04-09  Anders Carlsson  <andersca@apple.com>

        If we fail to decode a message name, pass the message length as the name
        https://bugs.webkit.org/show_bug.cgi?id=114305
        <rdar://problem/13605703>

        Reviewed by Sam Weinig.

        * Platform/CoreIPC/ArgumentDecoder.h:
        (CoreIPC::ArgumentDecoder::length):
        * Platform/CoreIPC/Connection.cpp:
        (CoreIPC::Connection::processIncomingMessage):

2139 2140 2141 2142 2143 2144 2145 2146 2147 2148 2149 2150 2151 2152 2153 2154 2155 2156 2157 2158 2159 2160 2161 2162 2163 2164 2165 2166 2167 2168 2169 2170 2171 2172 2173 2174 2175 2176 2177 2178 2179 2180 2181
2013-04-08  Dean Jackson  <dino@apple.com>

        Don't create another plugin process for restarted plugins
        https://bugs.webkit.org/show_bug.cgi?id=114233

        Reviewed by Geoff Garen.

        A snapshotting plugin starts in a separate process from
        regular plugins. This can be a little confusing to users
        because they might see two plugin processes. We can set
        the minimum life and timeout on the snapshotting process
        to much smaller values, since the process doesn't need
        to live that long. This will reduce some potential
        confusion. Also, since there is another plugin process
        running real plugins, it should be paged in if it needs
        to restart.

        There was, however, a bug in the process management. A
        restarted plugin received a special PluginProcess::Type,
        so that it could cross fade into the page nicely. This
        caused it to start a *third* plugin process. Instead
        mark a restarted flag directly on the PluginProxy and
        revert back to two process types.

        * PluginProcess/PluginProcess.h: Remove TypeRestartedProcess.

        * UIProcess/Plugins/PluginProcessProxy.cpp: Add two new
            timeout values for snapshotting processes.
        (WebKit::PluginProcessProxy::didFinishLaunching): Chose which
            of the timeout pairs to use.

        * WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:
        (WebKit::PluginProxy::pluginLayer): Don't look at the process type, instead
            look at the process flag to see if we are restarted.
        * WebProcess/Plugins/PluginProxy.cpp:
        (WebKit::PluginProxy::create): Copy the new flag into constructor.
        (WebKit::PluginProxy::PluginProxy): Remember the flag.
        * WebProcess/Plugins/PluginProxy.h: Add a new m_restartedProcess flag.

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::createPlugin): When we are creating the proxy, separate
            the concept of snapshotting and restarting.

2182 2183 2184 2185 2186 2187 2188 2189 2190 2191 2192 2193 2194 2195 2196 2197 2198 2199 2200 2201 2202 2203 2204 2205 2206 2207
2013-04-09  Tim Horton  <timothy_horton@apple.com>

        [wk2] IconDatabase images should be decoded in the WebProcess
        https://bugs.webkit.org/show_bug.cgi?id=112524
        <rdar://problem/10133914>

        Reviewed by Oliver Hunt.

        In the interests of keeping decoding of data coming in from the greater Internet
        in the WebProcess, move decoding of favicons from the UIProcess to the WebProcess.

        * UIProcess/WebIconDatabase.cpp:
        (WebKit::WebIconDatabase::setIconBitmapForIconURL):
        Receive a ShareableBitmap handle from the WebProcess instead of a DataReference.
        Use the new setIconBitmapForIconURL IconDatabase method.

        * UIProcess/WebIconDatabase.h:
        (WebIconDatabase):
        Rename setIconDataForIconURL to setIconBitmapForIconURL.

        * UIProcess/WebIconDatabase.messages.in: Ditto.

        * WebProcess/IconDatabase/WebIconDatabaseProxy.cpp:
        (WebKit::WebIconDatabaseProxy::setIconDataForIconURL):
        In the WebProcess, decode the incoming icon and draw it into a ShareableBitmap.

2208 2209 2210 2211 2212 2213 2214 2215 2216 2217
2013-04-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>

        [EFL] Declare TEST_THEME_DIR in a single place.
        https://bugs.webkit.org/show_bug.cgi?id=114285

        Reviewed by Anders Carlsson.

        * PlatformEfl.cmake: Remove definition of `TEST_THEME_DIR', which is
        now defined in OptionsEfl.cmake.

2218 2219 2220 2221 2222 2223 2224 2225 2226 2227 2228 2229 2230 2231
2013-04-09  Rafael Brandao  <rafael.lobo@openbossa.org>

        [CoordinatedGraphics] serviceScriptedAnimations expects time in seconds
        https://bugs.webkit.org/show_bug.cgi?id=112582

        Reviewed by Andreas Kling.

        We've been exposing different time unit for requestAnimationFrame because
        of wrong conversion before serviceScriptedAnimations function calls.
        Fixed it to use seconds instead of milliseconds.

        * WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
        (WebKit::CoordinatedLayerTreeHost::syncDisplayState): Remove unnecessary conversion.

2232 2233 2234 2235 2236 2237 2238 2239 2240 2241 2242 2243 2244
2013-04-09  Michael Brüning  <michael.bruning@digia.com>

        [Qt][WK2] Remove obsolete QtWebPageFindClient forward declaration from qquickwebview_p.h.
        https://bugs.webkit.org/show_bug.cgi?id=114284

        Reviewed by Andreas Kling.

        The class QtWebPageFindClient was removed in r142073 when the functionality
        was folded into QQuickWebViewPrivate.

        * UIProcess/API/qt/qquickwebview_p.h:
        (WebKit):

2245 2246 2247 2248 2249 2250 2251 2252 2253 2254 2255 2256
2013-04-09  Michael Brüning  <michael.bruning@digia.com>

        Fix GTK WebKit2 build after r148005.
        https://bugs.webkit.org/show_bug.cgi?id=114270

        Reviewed by Andreas Kling.

        Fix GTK build break that went through the buildbot undetected.

        * UIProcess/API/gtk/WebKitFileChooserRequest.cpp:
        (webkit_file_chooser_request_get_selected_files):

2257 2258 2259 2260 2261 2262 2263 2264 2265 2266 2267 2268 2269 2270 2271 2272 2273 2274 2275 2276 2277 2278 2279 2280 2281 2282 2283 2284 2285 2286 2287 2288 2289 2290 2291 2292 2293 2294 2295 2296 2297 2298 2299 2300 2301 2302 2303 2304 2305 2306
2013-04-09  Michael Brüning  <michael.bruning@digia.com>

        [Qt][WK2] Remove direct references to WebPageProxy from QQuickWebPage.
        https://bugs.webkit.org/show_bug.cgi?id=112850

        Reviewed by Andreas Kling.

        Removes direct references to WebPageProxy from QQuickWebPage and prepares the
        class for the move to QRawWebView. The access to the device scale factor and
        CoordinatedGraphicsScene is provided through QQuickWebViewPrivate, and therefore
        accessors to these properties are temporarily added. Eventually, this access will
        be provided through QRawWebView when the move is complete.

        This also moves the pointer to QtWebPageEventHandler from QQuickWebPagePrivate
        to QQuickWebViewPrivate as it is mainly used from there.

        * UIProcess/API/qt/qquickwebpage.cpp:
        (QQuickWebPagePrivate::QQuickWebPagePrivate):
        (QQuickWebPagePrivate::paint):
        (QQuickWebPage::updatePaintNode):
        * UIProcess/API/qt/qquickwebpage_p.h:
        * UIProcess/API/qt/qquickwebpage_p_p.h:
        (QQuickWebPagePrivate):
        * UIProcess/API/qt/qquickwebview.cpp:
        (QQuickWebViewPrivate::initialize):
        (QQuickWebViewPrivate::handleMouseEvent):
        (QQuickWebViewPrivate::processDidCrash):
        (QQuickWebViewPrivate::coordinatedGraphicsScene):
        (QQuickWebViewPrivate::deviceScaleFactor):
        (QQuickWebViewPrivate::setIntrinsicDeviceScaleFactor):
        (QQuickWebViewFlickablePrivate::onComponentComplete):
        (QQuickWebView::keyPressEvent):
        (QQuickWebView::keyReleaseEvent):
        (QQuickWebView::inputMethodEvent):
        (QQuickWebView::focusInEvent):
        (QQuickWebView::itemChange):
        (QQuickWebView::touchEvent):
        (QQuickWebView::wheelEvent):
        (QQuickWebView::hoverEnterEvent):
        (QQuickWebView::hoverMoveEvent):
        (QQuickWebView::hoverLeaveEvent):
        (QQuickWebView::dragMoveEvent):
        (QQuickWebView::dragEnterEvent):
        (QQuickWebView::dragLeaveEvent):
        (QQuickWebView::dropEvent):
        * UIProcess/API/qt/qquickwebview_p_p.h:
        (WebCore):
        (WebKit):
        (QQuickWebViewPrivate):

2307 2308 2309 2310 2311 2312 2313 2314 2315 2316 2317 2318 2319
2013-04-09  Michael Brüning  <michael.bruning@digia.com>

        [Qt][WK2] Use C API to enable Navigator Qt Object.
        https://bugs.webkit.org/show_bug.cgi?id=112810

        Reviewed by Andreas Kling.

        Replace the direct reference to the WebPageProxy with use of
        C API.

        * UIProcess/API/qt/qquickwebview.cpp:
        (QQuickWebViewPrivate::setNavigatorQtObjectEnabled):

2320 2321 2322 2323 2324 2325 2326 2327 2328 2329 2330 2331 2332 2333 2334 2335 2336 2337 2338 2339 2340 2341 2342 2343 2344 2345 2346 2347
2013-04-09  Michael Brüning  <michael.bruning@digia.com>

        [WK2] Add C API to copy selected files from WebOpenPanelParameters.
        https://bugs.webkit.org/show_bug.cgi?id=112339

        Reviewed by Andreas Kling.

        Replaces the existing WebOpenPanelParameters::selectedFileNames() method
        to return a copy of the selected file names and exposes it through the
        C API. This is done in order to reduce the direct use of WebKit2 internal
        classes. The implementation is very similar to the one in 
        WebOpenPanelParameters::acceptMIMETypes().

        This also updates the GTK port, which is the other user of selectedFileNames.

        * Shared/WebOpenPanelParameters.cpp:
        (WebKit::WebOpenPanelParameters::selectedFileNames):
        (WebKit):
        * Shared/WebOpenPanelParameters.h:
        (WebOpenPanelParameters):
        * UIProcess/API/C/WKOpenPanelParameters.cpp:
        (WKOpenPanelParametersCopySelectedFileNames):
        * UIProcess/API/C/WKOpenPanelParameters.h:
        * UIProcess/API/gtk/WebKitFileChooserRequest.cpp:
        (webkit_file_chooser_request_get_selected_files):
        * UIProcess/qt/QtWebPageUIClient.cpp:
        (WebKit::QtWebPageUIClient::runOpenPanel):

2348 2349 2350 2351 2352 2353 2354 2355 2356 2357 2358 2359 2360 2361 2362 2363 2364 2365 2366 2367 2368 2369 2370 2371 2372 2373
2013-04-09  Jinwoo Song  <jinwoo7.song@samsung.com>

        [WK2] Remove build warnings for unused parameters
        https://bugs.webkit.org/show_bug.cgi?id=114234

        Reviewed by Andreas Kling.

        Fix build warnings -Wunused-parameter.

        * UIProcess/Storage/StorageManager.cpp:
        (WebKit::StorageManager::SessionStorageNamespace::cloneTo):
        * UIProcess/WebContext.cpp:
        (WebKit::WebContext::requestNetworkingStatistics):
        (WebKit::WebContext::pluginInfoStoreDidLoadPlugins):
        * WebProcess/Storage/StorageAreaProxy.cpp:
        (WebKit::StorageAreaProxy::removeItem):
        (WebKit::StorageAreaProxy::clear):
        (WebKit::StorageAreaProxy::dispatchSessionStorageEvent):
        (WebKit::StorageAreaProxy::dispatchLocalStorageEvent):
        * WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
        (WebKit::CoordinatedLayerTreeHost::didUninstallPageOverlay):
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::didFinishLoad):
        * WebProcess/WebProcess.cpp:
        (WebKit::WebProcess::shouldPlugInAutoStartFromOrigin):

2374 2375 2376 2377 2378 2379 2380 2381 2382 2383 2384 2385 2386 2387 2388 2389 2390 2391 2392 2393 2394 2395 2396 2397 2398 2399 2400 2401 2402 2403 2404 2405 2406 2407 2408 2409 2410 2411 2412 2413 2414 2415 2416 2417 2418 2419 2420 2421 2422 2423 2424 2425 2426 2427 2428 2429 2430 2431 2432 2433 2434 2435 2436 2437 2438 2439 2440 2441 2442 2443 2444 2445 2446 2447 2448 2449 2450 2451 2452 2453 2454 2455 2456 2457 2458 2459 2460 2461 2462 2463 2464 2465 2466 2467 2468 2469 2470 2471 2472 2473 2474 2475 2476 2477 2478 2479 2480 2481 2482 2483 2484 2485 2486 2487 2488 2489 2490 2491 2492 2493 2494 2495 2496 2497 2498 2499 2500 2501 2502 2503 2504 2505 2506 2507 2508 2509 2510 2511 2512 2513 2514 2515 2516 2517 2518 2519 2520 2521
2013-04-09  Thiago Marcos P. Santos  <thiago.santos@intel.com>

        [WK2] Drop WebProcess capabilities on Linux using seccomp filters
        https://bugs.webkit.org/show_bug.cgi?id=89875

        Reviewed by Maciej Stachowiak.

        Introduce the foundations of the SeccompFilter-based sandbox. The
        hardening of the WebProcess (and potentially PluginProcess, etc)
        works by a combination of the two things:

        - Blocking syscalls that are not used, reducing the size of the attack
        surface.
        - Trapping sensitive syscalls and delegating the execution of these
        syscalls to a separated trusted process subject to a set of policies.

        The initial implementation traps the open()-family of syscalls on WebKit
        EFL's and Qt's WebProcess, but it could be easily used by any Linux port,
        since the code is suppose to be Linux-compliant. The list of syscalls handled
        by the broker process should definitely grow as we mature the
        implementation. Other syscalls needs to be handled to get this sandbox
        fully functional, like unlink(), mkdir(), etc.

        The broker process should be initialized as early as possible on the
        sandboxed process main() function, because it only does a fork(), which
        is cheap on Linux. That also aims to minimize the resident memory footprint
        of the broker process.

        Opening of files for upload and saving downloads is not supported yet,
        since it should be handled to the UIProcess in a similar fashion as
        the Mac port does.

        * PlatformEfl.cmake:
        * Shared/linux/SeccompFilters/OpenSyscall.cpp: Added.
        (WebKit):
        (WebKit::OpenSyscall::createFromOpenatContext):
        (WebKit::OpenSyscall::createFromCreatContext):
        (WebKit::OpenSyscall::OpenSyscall):
        (WebKit::OpenSyscall::setResult):
        (WebKit::OpenSyscall::execute):
        (WebKit::OpenSyscall::encode):
        (WebKit::OpenSyscall::decode):
        (WebKit::OpenSyscallResult::OpenSyscallResult):
        (WebKit::OpenSyscallResult::~OpenSyscallResult):
        (WebKit::OpenSyscallResult::encode):
        (WebKit::OpenSyscallResult::decode):
        * Shared/linux/SeccompFilters/OpenSyscall.h: Added.
        (CoreIPC):
        (WebKit):
        (OpenSyscall):
        (WebKit::OpenSyscall::setPath):
        (WebKit::OpenSyscall::setFlags):
        (WebKit::OpenSyscall::setMode):
        (OpenSyscallResult):
        (WebKit::OpenSyscallResult::fd):
        (WebKit::OpenSyscallResult::errorNumber):
        * Shared/linux/SeccompFilters/SeccompBroker.cpp: Added.
        (WebKit):
        (SeccompBrokerClient):
        (WebKit::sendMessage):
        (WebKit::receiveMessage):
        (WebKit::SIGSYSHandler):
        (WebKit::registerSIGSYSHandler):
        (WebKit::SeccompBrokerClient::shared):
        (WebKit::SeccompBrokerClient::SeccompBrokerClient):
        (WebKit::SeccompBrokerClient::~SeccompBrokerClient):
        (WebKit::SeccompBrokerClient::dispatch):
        (WebKit::SeccompBrokerClient::handleIfOpeningOnlineCPUCount):
        (WebKit::SeccompBroker::launchProcess):
        (WebKit::SeccompBroker::initialize):
        (WebKit::SeccompBroker::runLoop):
        * Shared/linux/SeccompFilters/SeccompBroker.h: Added.
        (WebKit):
        (SeccompBroker):
        (WebKit::SeccompBroker::setSyscallPolicy):
        (WebKit::SeccompBroker::SeccompBroker):
        * Shared/linux/SeccompFilters/SeccompFilters.cpp: Added.
        (WebKit):
        (WebKit::SeccompFilters::SeccompFilters):
        (WebKit::SeccompFilters::~SeccompFilters):
        (WebKit::SeccompFilters::addRule):
        (WebKit::SeccompFilters::initialize):
        * Shared/linux/SeccompFilters/SeccompFilters.h: Added.
        (WebKit):
        (SeccompFilters)