JSArray.cpp 74.6 KB
Newer Older
darin's avatar
darin committed
1 2
/*
 *  Copyright (C) 1999-2000 Harri Porten (porten@kde.org)
3
 *  Copyright (C) 2003, 2007, 2008, 2009 Apple Inc. All rights reserved.
darin's avatar
darin committed
4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23
 *  Copyright (C) 2003 Peter Kelly (pmk@post.com)
 *  Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com)
 *
 *  This library is free software; you can redistribute it and/or
 *  modify it under the terms of the GNU Lesser General Public
 *  License as published by the Free Software Foundation; either
 *  version 2 of the License, or (at your option) any later version.
 *
 *  This library is distributed in the hope that it will be useful,
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 *  Lesser General Public License for more details.
 *
 *  You should have received a copy of the GNU Lesser General Public
 *  License along with this library; if not, write to the Free Software
 *  Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
 *
 */

#include "config.h"
darin@apple.com's avatar
darin@apple.com committed
24
#include "JSArray.h"
darin's avatar
darin committed
25

darin@apple.com's avatar
darin@apple.com committed
26
#include "ArrayPrototype.h"
mhahnenberg@apple.com's avatar
mhahnenberg@apple.com committed
27 28
#include "CopiedSpace.h"
#include "CopiedSpaceInlineMethods.h"
29
#include "CachedCall.h"
30
#include "Error.h"
31
#include "Executable.h"
32
#include "GetterSetter.h"
darin's avatar
darin committed
33
#include "PropertyNameArray.h"
ap@webkit.org's avatar
ap@webkit.org committed
34
#include <wtf/AVLTree.h>
35
#include <wtf/Assertions.h>
36
#include <wtf/OwnPtr.h>
37
#include <Operations.h>
darin's avatar
darin committed
38

39
using namespace std;
ap@webkit.org's avatar
ap@webkit.org committed
40
using namespace WTF;
bdash's avatar
bdash committed
41

42
namespace JSC {
darin's avatar
darin committed
43

44

ggaren@apple.com's avatar
ggaren@apple.com committed
45
ASSERT_CLASS_FITS_IN_CELL(JSArray);
46
ASSERT_HAS_TRIVIAL_DESTRUCTOR(JSArray);
ggaren@apple.com's avatar
ggaren@apple.com committed
47

barraclough@apple.com's avatar
barraclough@apple.com committed
48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64
// Overview of JSArray
//
// Properties of JSArray objects may be stored in one of three locations:
//   * The regular JSObject property map.
//   * A storage vector.
//   * A sparse map of array entries.
//
// Properties with non-numeric identifiers, with identifiers that are not representable
// as an unsigned integer, or where the value is greater than  MAX_ARRAY_INDEX
// (specifically, this is only one property - the value 0xFFFFFFFFU as an unsigned 32-bit
// integer) are not considered array indices and will be stored in the JSObject property map.
//
// All properties with a numeric identifer, representable as an unsigned integer i,
// where (i <= MAX_ARRAY_INDEX), are an array index and will be stored in either the
// storage vector or the sparse map.  An array index i will be handled in the following
// fashion:
//
65 66
//   * Where (i < MIN_SPARSE_ARRAY_INDEX) the value will be stored in the storage vector,
//     unless the array is in SparseMode in which case all properties go into the map.
barraclough@apple.com's avatar
barraclough@apple.com committed
67 68 69 70 71 72 73 74 75
//   * Where (MIN_SPARSE_ARRAY_INDEX <= i <= MAX_STORAGE_VECTOR_INDEX) the value will either
//     be stored in the storage vector or in the sparse array, depending on the density of
//     data that would be stored in the vector (a vector being used where at least
//     (1 / minDensityMultiplier) of the entries would be populated).
//   * Where (MAX_STORAGE_VECTOR_INDEX < i <= MAX_ARRAY_INDEX) the value will always be stored
//     in the sparse array.

// The definition of MAX_STORAGE_VECTOR_LENGTH is dependant on the definition storageSize
// function below - the MAX_STORAGE_VECTOR_LENGTH limit is defined such that the storage
76 77 78
// size calculation cannot overflow.  (sizeof(ArrayStorage) - sizeof(WriteBarrier<Unknown>)) +
// (vectorLength * sizeof(WriteBarrier<Unknown>)) must be <= 0xFFFFFFFFU (which is maximum value of size_t).
#define MAX_STORAGE_VECTOR_LENGTH static_cast<unsigned>((0xFFFFFFFFU - (sizeof(ArrayStorage) - sizeof(WriteBarrier<Unknown>))) / sizeof(WriteBarrier<Unknown>))
barraclough@apple.com's avatar
barraclough@apple.com committed
79 80 81 82 83

// These values have to be macros to be used in max() and min() without introducing
// a PIC branch in Mach-O binaries, see <rdar://problem/5971391>.
#define MIN_SPARSE_ARRAY_INDEX 10000U
#define MAX_STORAGE_VECTOR_INDEX (MAX_STORAGE_VECTOR_LENGTH - 1)
84
// 0xFFFFFFFF is a bit weird -- is not an array index even though it's an integer.
barraclough@apple.com's avatar
barraclough@apple.com committed
85
#define MAX_ARRAY_INDEX 0xFFFFFFFEU
darin's avatar
darin committed
86

87 88 89 90 91 92 93 94
// The value BASE_VECTOR_LEN is the maximum number of vector elements we'll allocate
// for an array that was created with a sepcified length (e.g. a = new Array(123))
#define BASE_VECTOR_LEN 4U
    
// The upper bound to the size we'll grow a zero length array when the first element
// is added.
#define FIRST_VECTOR_GROW 4U

darin's avatar
darin committed
95
// Our policy for when to use a vector and when to use a sparse map.
barraclough@apple.com's avatar
barraclough@apple.com committed
96 97
// For all array indices under MIN_SPARSE_ARRAY_INDEX, we always use a vector.
// When indices greater than MIN_SPARSE_ARRAY_INDEX are involved, we use a vector
darin's avatar
darin committed
98 99 100
// as long as it is 1/8 full. If more sparse than that, we use a map.
static const unsigned minDensityMultiplier = 8;

101
const ClassInfo JSArray::s_info = {"Array", &JSNonFinalObject::s_info, 0, 0, CREATE_METHOD_TABLE(JSArray)};
darin's avatar
darin committed
102

103 104 105 106 107
// We keep track of the size of the last array after it was grown.  We use this
// as a simple heuristic for as the value to grow the next array from size 0.
// This value is capped by the constant FIRST_VECTOR_GROW defined above.
static unsigned lastArraySize = 0;

darin's avatar
darin committed
108 109
static inline bool isDenseEnoughForVector(unsigned length, unsigned numValues)
{
110
    return length <= MIN_SPARSE_ARRAY_INDEX || length / minDensityMultiplier <= numValues;
darin's avatar
darin committed
111 112
}

113 114 115 116 117 118 119
static bool reject(ExecState* exec, bool throwException, const char* message)
{
    if (throwException)
        throwTypeError(exec, message);
    return false;
}

120 121
#if !CHECK_ARRAY_CONSISTENCY

darin@apple.com's avatar
darin@apple.com committed
122
inline void JSArray::checkConsistency(ConsistencyCheckType)
123 124 125 126 127
{
}

#endif

128 129
JSArray::JSArray(JSGlobalData& globalData, Structure* structure)
    : JSNonFinalObject(globalData, structure)
130
    , m_indexBias(0)
131
    , m_storage(0)
132 133
    , m_sparseValueMap(0)
    , m_subclassData(0)
weinig@apple.com's avatar
weinig@apple.com committed
134
{
135 136
}

137
void JSArray::finishCreation(JSGlobalData& globalData, unsigned initialLength)
138 139
{
    Base::finishCreation(globalData);
140 141
    ASSERT(inherits(&s_info));

142 143
    unsigned initialVectorLength = BASE_VECTOR_LEN;
    unsigned initialStorageSize = storageSize(initialVectorLength);
weinig@apple.com's avatar
weinig@apple.com committed
144

145 146 147 148 149
    void* newStorage = 0;
    if (!globalData.heap.tryAllocateStorage(initialStorageSize, &newStorage))
        CRASH();
    
    m_storage = static_cast<ArrayStorage*>(newStorage);
150
    m_storage->m_allocBase = m_storage;
151 152 153 154 155 156
    m_storage->m_length = initialLength;
    m_vectorLength = initialVectorLength;
    m_storage->m_numValuesInVector = 0;
#if CHECK_ARRAY_CONSISTENCY
    m_storage->m_inCompactInitialization = false;
#endif
weinig@apple.com's avatar
weinig@apple.com committed
157

158
    checkConsistency();
weinig@apple.com's avatar
weinig@apple.com committed
159 160
}

161
JSArray* JSArray::tryFinishCreationUninitialized(JSGlobalData& globalData, unsigned initialLength)
darin's avatar
darin committed
162
{
163
    Base::finishCreation(globalData);
164 165
    ASSERT(inherits(&s_info));

166 167 168 169 170 171 172
    // Check for lengths larger than we can handle with a vector.
    if (initialLength > MAX_STORAGE_VECTOR_LENGTH)
        return 0;

    unsigned initialVectorLength = max(initialLength, BASE_VECTOR_LEN);
    unsigned initialStorageSize = storageSize(initialVectorLength);

173 174 175 176 177
    void* newStorage = 0;
    if (!globalData.heap.tryAllocateStorage(initialStorageSize, &newStorage))
        CRASH();
    
    m_storage = static_cast<ArrayStorage*>(newStorage);
178
    m_storage->m_allocBase = m_storage;
179 180 181
    m_storage->m_length = 0;
    m_vectorLength = initialVectorLength;
    m_storage->m_numValuesInVector = initialLength;
182

183
#if CHECK_ARRAY_CONSISTENCY
184
    m_storage->m_inCompactInitialization = true;
185
#endif
186

187
    return this;
darin's avatar
darin committed
188 189
}

190 191
// This function can be called multiple times on the same object.
void JSArray::finalize(JSCell* cell)
darin's avatar
darin committed
192
{
193 194 195
    JSArray* thisObject = jsCast<JSArray*>(cell);
    thisObject->checkConsistency(DestructorConsistencyCheck);
    thisObject->deallocateSparseMap();
196 197
}

198
inline std::pair<SparseArrayValueMap::iterator, bool> SparseArrayValueMap::add(JSArray* array, unsigned i)
199
{
200 201 202 203 204 205 206 207
    SparseArrayEntry entry;
    std::pair<iterator, bool> result = m_map.add(i, entry);
    size_t capacity = m_map.capacity();
    if (capacity != m_reportedCapacity) {
        Heap::heap(array)->reportExtraMemoryCost((capacity - m_reportedCapacity) * (sizeof(unsigned) + sizeof(WriteBarrier<Unknown>)));
        m_reportedCapacity = capacity;
    }
    return result;
208 209
}

210
inline void SparseArrayValueMap::put(ExecState* exec, JSArray* array, unsigned i, JSValue value, bool shouldThrow)
211
{
212 213 214 215 216 217 218 219
    std::pair<SparseArrayValueMap::iterator, bool> result = add(array, i);
    SparseArrayEntry& entry = result.first->second;

    // To save a separate find & add, we first always add to the sparse map.
    // In the uncommon case that this is a new property, and the array is not
    // extensible, this is not the right thing to have done - so remove again.
    if (result.second && !array->isExtensible()) {
        remove(result.first);
220 221
        if (shouldThrow)
            throwTypeError(exec, StrictModeReadonlyPropertyWriteError);
222 223
        return;
    }
224

225
    if (!(entry.attributes & Accessor)) {
226
        if (entry.attributes & ReadOnly) {
227 228
            if (shouldThrow)
                throwTypeError(exec, StrictModeReadonlyPropertyWriteError);
229 230 231 232
            return;
        }

        entry.set(exec->globalData(), array, value);
233
        return;
234
    }
235

236 237 238 239 240
    JSValue accessor = entry.Base::get();
    ASSERT(accessor.isGetterSetter());
    JSObject* setter = asGetterSetter(accessor)->setter();
    
    if (!setter) {
241 242
        if (shouldThrow)
            throwTypeError(exec, StrictModeReadonlyPropertyWriteError);
243
        return;
244
    }
245 246 247 248 249 250 251 252

    CallData callData;
    CallType callType = setter->methodTable()->getCallData(setter, callData);
    MarkedArgumentBuffer args;
    args.append(value);
    call(exec, setter, callType, callData, array, args);
}

253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270
inline bool SparseArrayValueMap::putDirect(ExecState* exec, JSArray* array, unsigned i, JSValue value, bool shouldThrow)
{
    std::pair<SparseArrayValueMap::iterator, bool> result = add(array, i);
    SparseArrayEntry& entry = result.first->second;

    // To save a separate find & add, we first always add to the sparse map.
    // In the uncommon case that this is a new property, and the array is not
    // extensible, this is not the right thing to have done - so remove again.
    if (result.second && !array->isExtensible()) {
        remove(result.first);
        return reject(exec, shouldThrow, "Attempting to define property on object that is not extensible.");
    }

    entry.attributes = 0;
    entry.set(exec->globalData(), array, value);
    return true;
}

271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315
inline void SparseArrayEntry::get(PropertySlot& slot) const
{
    JSValue value = Base::get();
    ASSERT(value);

    if (LIKELY(!value.isGetterSetter())) {
        slot.setValue(value);
        return;
    }

    JSObject* getter = asGetterSetter(value)->getter();
    if (!getter) {
        slot.setUndefined();
        return;
    }

    slot.setGetterSlot(getter);
}

inline void SparseArrayEntry::get(PropertyDescriptor& descriptor) const
{
    descriptor.setDescriptor(Base::get(), attributes);
}

inline JSValue SparseArrayEntry::get(ExecState* exec, JSArray* array) const
{
    JSValue result = Base::get();
    ASSERT(result);

    if (LIKELY(!result.isGetterSetter()))
        return result;

    JSObject* getter = asGetterSetter(result)->getter();
    if (!getter)
        return jsUndefined();

    CallData callData;
    CallType callType = getter->methodTable()->getCallData(getter, callData);
    return call(exec, getter, callType, callData, array, exec->emptyList());
}

inline JSValue SparseArrayEntry::getNonSparseMode() const
{
    ASSERT(!attributes);
    return Base::get();
316 317 318 319 320 321 322 323 324
}

inline void SparseArrayValueMap::visitChildren(SlotVisitor& visitor)
{
    iterator end = m_map.end();
    for (iterator it = m_map.begin(); it != end; ++it)
        visitor.append(&it->second);
}

325 326 327 328 329 330 331 332 333 334 335 336 337
void JSArray::allocateSparseMap(JSGlobalData& globalData)
{
    m_sparseValueMap = new SparseArrayValueMap;
    globalData.heap.addFinalizer(this, finalize);
}

void JSArray::deallocateSparseMap()
{
    delete m_sparseValueMap;
    m_sparseValueMap = 0;
}

void JSArray::enterDictionaryMode(JSGlobalData& globalData)
338 339
{
    ArrayStorage* storage = m_storage;
340
    SparseArrayValueMap* map = m_sparseValueMap;
341

342 343 344 345
    if (!map) {
        allocateSparseMap(globalData);
        map = m_sparseValueMap;
    }
346 347 348 349 350 351 352 353 354 355 356 357 358 359 360

    if (map->sparseMode())
        return;

    map->setSparseMode();

    unsigned usedVectorLength = min(storage->m_length, m_vectorLength);
    for (unsigned i = 0; i < usedVectorLength; ++i) {
        JSValue value = storage->m_vector[i].get();
        // This will always be a new entry in the map, so no need to check we can write,
        // and attributes are default so no need to set them.
        if (value)
            map->add(this, i).first->second.set(globalData, this, value);
    }

361 362 363 364 365
    void* newRawStorage = 0;
    if (!globalData.heap.tryAllocateStorage(storageSize(0), &newRawStorage))
        CRASH();
    
    ArrayStorage* newStorage = static_cast<ArrayStorage*>(newRawStorage);
366 367 368 369 370 371 372 373 374 375 376 377
    memcpy(newStorage, m_storage, storageSize(0));
    newStorage->m_allocBase = newStorage;
    m_storage = newStorage;
    m_indexBias = 0;
    m_vectorLength = 0;
}

void JSArray::putDescriptor(ExecState* exec, SparseArrayEntry* entryInMap, PropertyDescriptor& descriptor, PropertyDescriptor& oldDescriptor)
{
    if (descriptor.isDataDescriptor()) {
        if (descriptor.value())
            entryInMap->set(exec->globalData(), this, descriptor.value());
378 379
        else if (oldDescriptor.isAccessorDescriptor())
            entryInMap->set(exec->globalData(), this, jsUndefined());
380
        entryInMap->attributes = descriptor.attributesOverridingCurrent(oldDescriptor) & ~Accessor;
381 382 383 384 385
        return;
    }

    if (descriptor.isAccessorDescriptor()) {
        JSObject* getter = 0;
386 387 388 389
        if (descriptor.getterPresent())
            getter = descriptor.getterObject();
        else if (oldDescriptor.isAccessorDescriptor())
            getter = oldDescriptor.getterObject();
390
        JSObject* setter = 0;
391 392 393 394
        if (descriptor.setterPresent())
            setter = descriptor.setterObject();
        else if (oldDescriptor.isAccessorDescriptor())
            setter = oldDescriptor.setterObject();
395 396 397 398 399 400 401 402

        GetterSetter* accessor = GetterSetter::create(exec);
        if (getter)
            accessor->setGetter(exec->globalData(), getter);
        if (setter)
            accessor->setSetter(exec->globalData(), setter);

        entryInMap->set(exec->globalData(), this, accessor);
403
        entryInMap->attributes = descriptor.attributesOverridingCurrent(oldDescriptor) & ~ReadOnly;
404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422
        return;
    }

    ASSERT(descriptor.isGenericDescriptor());
    entryInMap->attributes = descriptor.attributesOverridingCurrent(oldDescriptor);
}

// Defined in ES5.1 8.12.9
bool JSArray::defineOwnNumericProperty(ExecState* exec, unsigned index, PropertyDescriptor& descriptor, bool throwException)
{
    ASSERT(index != 0xFFFFFFFF);

    if (!inSparseMode()) {
        // Fast case: we're putting a regular property to a regular array
        // FIXME: this will pessimistically assume that if attributes are missing then they'll default to false
        // – however if the property currently exists missing attributes will override from their current 'true'
        // state (i.e. defineOwnProperty could be used to set a value without needing to entering 'SparseMode').
        if (!descriptor.attributes()) {
            ASSERT(!descriptor.isAccessorDescriptor());
423
            return putDirectIndex(exec, index, descriptor.value(), throwException);
424 425
        }

426
        enterDictionaryMode(exec->globalData());
427 428
    }

429
    SparseArrayValueMap* map = m_sparseValueMap;
430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475
    ASSERT(map);

    // 1. Let current be the result of calling the [[GetOwnProperty]] internal method of O with property name P.
    std::pair<SparseArrayValueMap::iterator, bool> result = map->add(this, index);
    SparseArrayEntry* entryInMap = &result.first->second;

    // 2. Let extensible be the value of the [[Extensible]] internal property of O.
    // 3. If current is undefined and extensible is false, then Reject.
    // 4. If current is undefined and extensible is true, then
    if (result.second) {
        if (!isExtensible()) {
            map->remove(result.first);
            return reject(exec, throwException, "Attempting to define property on object that is not extensible.");
        }

        // 4.a. If IsGenericDescriptor(Desc) or IsDataDescriptor(Desc) is true, then create an own data property
        // named P of object O whose [[Value]], [[Writable]], [[Enumerable]] and [[Configurable]] attribute values
        // are described by Desc. If the value of an attribute field of Desc is absent, the attribute of the newly
        // created property is set to its default value.
        // 4.b. Else, Desc must be an accessor Property Descriptor so, create an own accessor property named P of
        // object O whose [[Get]], [[Set]], [[Enumerable]] and [[Configurable]] attribute values are described by
        // Desc. If the value of an attribute field of Desc is absent, the attribute of the newly created property
        // is set to its default value.
        // 4.c. Return true.

        PropertyDescriptor defaults;
        entryInMap->setWithoutWriteBarrier(jsUndefined());
        entryInMap->attributes = DontDelete | DontEnum | ReadOnly;
        entryInMap->get(defaults);

        putDescriptor(exec, entryInMap, descriptor, defaults);
        if (index >= m_storage->m_length)
            m_storage->m_length = index + 1;
        return true;
    }

    // 5. Return true, if every field in Desc is absent.
    // 6. Return true, if every field in Desc also occurs in current and the value of every field in Desc is the same value as the corresponding field in current when compared using the SameValue algorithm (9.12).
    PropertyDescriptor current;
    entryInMap->get(current);
    if (descriptor.isEmpty() || descriptor.equalTo(exec, current))
        return true;

    // 7. If the [[Configurable]] field of current is false then
    if (!current.configurable()) {
        // 7.a. Reject, if the [[Configurable]] field of Desc is true.
476
        if (descriptor.configurablePresent() && descriptor.configurable())
477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510
            return reject(exec, throwException, "Attempting to change configurable attribute of unconfigurable property.");
        // 7.b. Reject, if the [[Enumerable]] field of Desc is present and the [[Enumerable]] fields of current and Desc are the Boolean negation of each other.
        if (descriptor.enumerablePresent() && current.enumerable() != descriptor.enumerable())
            return reject(exec, throwException, "Attempting to change enumerable attribute of unconfigurable property.");
    }

    // 8. If IsGenericDescriptor(Desc) is true, then no further validation is required.
    if (!descriptor.isGenericDescriptor()) {
        // 9. Else, if IsDataDescriptor(current) and IsDataDescriptor(Desc) have different results, then
        if (current.isDataDescriptor() != descriptor.isDataDescriptor()) {
            // 9.a. Reject, if the [[Configurable]] field of current is false.
            if (!current.configurable())
                return reject(exec, throwException, "Attempting to change access mechanism for an unconfigurable property.");
            // 9.b. If IsDataDescriptor(current) is true, then convert the property named P of object O from a
            // data property to an accessor property. Preserve the existing values of the converted property‘s
            // [[Configurable]] and [[Enumerable]] attributes and set the rest of the property‘s attributes to
            // their default values.
            // 9.c. Else, convert the property named P of object O from an accessor property to a data property.
            // Preserve the existing values of the converted property‘s [[Configurable]] and [[Enumerable]]
            // attributes and set the rest of the property‘s attributes to their default values.
        } else if (current.isDataDescriptor() && descriptor.isDataDescriptor()) {
            // 10. Else, if IsDataDescriptor(current) and IsDataDescriptor(Desc) are both true, then
            // 10.a. If the [[Configurable]] field of current is false, then
            if (!current.configurable() && !current.writable()) {
                // 10.a.i. Reject, if the [[Writable]] field of current is false and the [[Writable]] field of Desc is true.
                if (descriptor.writable())
                    return reject(exec, throwException, "Attempting to change writable attribute of unconfigurable property.");
                // 10.a.ii. If the [[Writable]] field of current is false, then
                // 10.a.ii.1. Reject, if the [[Value]] field of Desc is present and SameValue(Desc.[[Value]], current.[[Value]]) is false.
                if (descriptor.value() && !sameValue(exec, descriptor.value(), current.value()))
                    return reject(exec, throwException, "Attempting to change value of a readonly property.");
            }
            // 10.b. else, the [[Configurable]] field of current is true, so any change is acceptable.
        } else {
511
            ASSERT(current.isAccessorDescriptor() && current.getterPresent() && current.setterPresent());
512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535
            // 11. Else, IsAccessorDescriptor(current) and IsAccessorDescriptor(Desc) are both true so, if the [[Configurable]] field of current is false, then
            if (!current.configurable()) {
                // 11.i. Reject, if the [[Set]] field of Desc is present and SameValue(Desc.[[Set]], current.[[Set]]) is false.
                if (descriptor.setterPresent() && descriptor.setter() != current.setter())
                    return reject(exec, throwException, "Attempting to change the setter of an unconfigurable property.");
                // 11.ii. Reject, if the [[Get]] field of Desc is present and SameValue(Desc.[[Get]], current.[[Get]]) is false.
                if (descriptor.getterPresent() && descriptor.getter() != current.getter())
                    return reject(exec, throwException, "Attempting to change the getter of an unconfigurable property.");
            }
        }
    }

    // 12. For each attribute field of Desc that is present, set the correspondingly named attribute of the property named P of object O to the value of the field.
    putDescriptor(exec, entryInMap, descriptor, current);
    // 13. Return true.
    return true;
}

void JSArray::setLengthWritable(ExecState* exec, bool writable)
{
    ASSERT(isLengthWritable() || !writable);
    if (!isLengthWritable() || writable)
        return;

536
    enterDictionaryMode(exec->globalData());
537

538
    SparseArrayValueMap* map = m_sparseValueMap;
539 540 541 542 543 544 545 546 547 548 549 550 551
    ASSERT(map);
    map->setLengthIsReadOnly();
}

// Defined in ES5.1 15.4.5.1
bool JSArray::defineOwnProperty(JSObject* object, ExecState* exec, const Identifier& propertyName, PropertyDescriptor& descriptor, bool throwException)
{
    JSArray* array = static_cast<JSArray*>(object);

    // 3. If P is "length", then
    if (propertyName == exec->propertyNames().length) {
        // All paths through length definition call the default [[DefineOwnProperty]], hence:
        // from ES5.1 8.12.9 7.a.
552
        if (descriptor.configurablePresent() && descriptor.configurable())
553 554
            return reject(exec, throwException, "Attempting to change configurable attribute of unconfigurable property.");
        // from ES5.1 8.12.9 7.b.
555
        if (descriptor.enumerablePresent() && descriptor.enumerable())
556 557 558 559 560 561 562
            return reject(exec, throwException, "Attempting to change enumerable attribute of unconfigurable property.");

        // a. If the [[Value]] field of Desc is absent, then
        // a.i. Return the result of calling the default [[DefineOwnProperty]] internal method (8.12.9) on A passing "length", Desc, and Throw as arguments.
        if (descriptor.isAccessorDescriptor())
            return reject(exec, throwException, "Attempting to change access mechanism for an unconfigurable property.");
        // from ES5.1 8.12.9 10.a.
563
        if (!array->isLengthWritable() && descriptor.writablePresent() && descriptor.writable())
564 565 566
            return reject(exec, throwException, "Attempting to change writable attribute of unconfigurable property.");
        // This descriptor is either just making length read-only, or changing nothing!
        if (!descriptor.value()) {
567 568
            if (descriptor.writablePresent())
                array->setLengthWritable(exec, descriptor.writable());
569 570 571 572 573 574 575 576 577 578 579 580 581 582
            return true;
        }
        
        // b. Let newLenDesc be a copy of Desc.
        // c. Let newLen be ToUint32(Desc.[[Value]]).
        unsigned newLen = descriptor.value().toUInt32(exec);
        // d. If newLen is not equal to ToNumber( Desc.[[Value]]), throw a RangeError exception.
        if (newLen != descriptor.value().toNumber(exec)) {
            throwError(exec, createRangeError(exec, "Invalid array length"));
            return false;
        }

        // Based on SameValue check in 8.12.9, this is always okay.
        if (newLen == array->length()) {
583 584
            if (descriptor.writablePresent())
                array->setLengthWritable(exec, descriptor.writable());
585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605
            return true;
        }

        // e. Set newLenDesc.[[Value] to newLen.
        // f. If newLen >= oldLen, then
        // f.i. Return the result of calling the default [[DefineOwnProperty]] internal method (8.12.9) on A passing "length", newLenDesc, and Throw as arguments.
        // g. Reject if oldLenDesc.[[Writable]] is false.
        if (!array->isLengthWritable())
            return reject(exec, throwException, "Attempting to change value of a readonly property.");
        
        // h. If newLenDesc.[[Writable]] is absent or has the value true, let newWritable be true.
        // i. Else,
        // i.i. Need to defer setting the [[Writable]] attribute to false in case any elements cannot be deleted.
        // i.ii. Let newWritable be false.
        // i.iii. Set newLenDesc.[[Writable] to true.
        // j. Let succeeded be the result of calling the default [[DefineOwnProperty]] internal method (8.12.9) on A passing "length", newLenDesc, and Throw as arguments.
        // k. If succeeded is false, return false.
        // l. While newLen < oldLen repeat,
        // l.i. Set oldLen to oldLen – 1.
        // l.ii. Let deleteSucceeded be the result of calling the [[Delete]] internal method of A passing ToString(oldLen) and false as arguments.
        // l.iii. If deleteSucceeded is false, then
606
        if (!array->setLength(exec, newLen, throwException)) {
607 608 609 610
            // 1. Set newLenDesc.[[Value] to oldLen+1.
            // 2. If newWritable is false, set newLenDesc.[[Writable] to false.
            // 3. Call the default [[DefineOwnProperty]] internal method (8.12.9) on A passing "length", newLenDesc, and false as arguments.
            // 4. Reject.
611 612
            if (descriptor.writablePresent())
                array->setLengthWritable(exec, descriptor.writable());
613 614 615 616
            return false;
        }

        // m. If newWritable is false, then
617 618 619 620 621
        // i. Call the default [[DefineOwnProperty]] internal method (8.12.9) on A passing "length",
        //    Property Descriptor{[[Writable]]: false}, and false as arguments. This call will always
        //    return true.
        if (descriptor.writablePresent())
            array->setLengthWritable(exec, descriptor.writable());
622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645
        // n. Return true.
        return true;
    }

    // 4. Else if P is an array index (15.4), then
    bool isArrayIndex;
    // a. Let index be ToUint32(P).
    unsigned index = propertyName.toArrayIndex(isArrayIndex);
    if (isArrayIndex) {
        // b. Reject if index >= oldLen and oldLenDesc.[[Writable]] is false.
        if (index >= array->length() && !array->isLengthWritable())
            return reject(exec, throwException, "Attempting to define numeric property on array with non-writable length property.");
        // c. Let succeeded be the result of calling the default [[DefineOwnProperty]] internal method (8.12.9) on A passing P, Desc, and false as arguments.
        // d. Reject if succeeded is false.
        // e. If index >= oldLen
        // e.i. Set oldLenDesc.[[Value]] to index + 1.
        // e.ii. Call the default [[DefineOwnProperty]] internal method (8.12.9) on A passing "length", oldLenDesc, and false as arguments. This call will always return true.
        // f. Return true.
        return array->defineOwnNumericProperty(exec, index, descriptor, throwException);
    }

    return JSObject::defineOwnProperty(object, exec, propertyName, descriptor, throwException);
}

646
bool JSArray::getOwnPropertySlotByIndex(JSCell* cell, ExecState* exec, unsigned i, PropertySlot& slot)
647
{
648
    JSArray* thisObject = jsCast<JSArray*>(cell);
649
    ArrayStorage* storage = thisObject->m_storage;
650

ggaren@apple.com's avatar
ggaren@apple.com committed
651
    if (i >= storage->m_length) {
barraclough@apple.com's avatar
barraclough@apple.com committed
652
        if (i > MAX_ARRAY_INDEX)
653
            return thisObject->methodTable()->getOwnPropertySlot(thisObject, exec, Identifier::from(exec, i), slot);
darin's avatar
darin committed
654 655 656
        return false;
    }

657
    if (i < thisObject->m_vectorLength) {
658 659 660
        JSValue value = storage->m_vector[i].get();
        if (value) {
            slot.setValue(value);
darin's avatar
darin committed
661 662
            return true;
        }
663
    } else if (SparseArrayValueMap* map = thisObject->m_sparseValueMap) {
664 665
        SparseArrayValueMap::iterator it = map->find(i);
        if (it != map->notFound()) {
666
            it->second.get(slot);
667
            return true;
darin's avatar
darin committed
668 669 670
        }
    }

671
    return JSObject::getOwnPropertySlot(thisObject, exec, Identifier::from(exec, i), slot);
darin's avatar
darin committed
672 673
}

674 675
bool JSArray::getOwnPropertySlot(JSCell* cell, ExecState* exec, const Identifier& propertyName, PropertySlot& slot)
{
676
    JSArray* thisObject = jsCast<JSArray*>(cell);
darin's avatar
darin committed
677
    if (propertyName == exec->propertyNames().length) {
678
        slot.setValue(jsNumber(thisObject->length()));
darin's avatar
darin committed
679 680 681 682
        return true;
    }

    bool isArrayIndex;
683
    unsigned i = propertyName.toArrayIndex(isArrayIndex);
darin's avatar
darin committed
684
    if (isArrayIndex)
685
        return JSArray::getOwnPropertySlotByIndex(thisObject, exec, i, slot);
darin's avatar
darin committed
686

687
    return JSObject::getOwnPropertySlot(thisObject, exec, propertyName, slot);
darin's avatar
darin committed
688 689
}

690
bool JSArray::getOwnPropertyDescriptor(JSObject* object, ExecState* exec, const Identifier& propertyName, PropertyDescriptor& descriptor)
691
{
692
    JSArray* thisObject = jsCast<JSArray*>(object);
693
    if (propertyName == exec->propertyNames().length) {
694
        descriptor.setDescriptor(jsNumber(thisObject->length()), thisObject->isLengthWritable() ? DontDelete | DontEnum : DontDelete | DontEnum | ReadOnly);
695 696
        return true;
    }
697

698
    ArrayStorage* storage = thisObject->m_storage;
699 700
    
    bool isArrayIndex;
701
    unsigned i = propertyName.toArrayIndex(isArrayIndex);
702
    if (isArrayIndex) {
703
        if (i >= storage->m_length)
704
            return false;
705
        if (i < thisObject->m_vectorLength) {
706
            WriteBarrier<Unknown>& value = storage->m_vector[i];
707
            if (value) {
708
                descriptor.setDescriptor(value.get(), 0);
709 710
                return true;
            }
711
        } else if (SparseArrayValueMap* map = thisObject->m_sparseValueMap) {
712 713
            SparseArrayValueMap::iterator it = map->find(i);
            if (it != map->notFound()) {
714
                it->second.get(descriptor);
715
                return true;
716 717 718
            }
        }
    }
719
    return JSObject::getOwnPropertyDescriptor(thisObject, exec, propertyName, descriptor);
720 721
}

722 723 724
// ECMA 15.4.5.1
void JSArray::put(JSCell* cell, ExecState* exec, const Identifier& propertyName, JSValue value, PutPropertySlot& slot)
{
725
    JSArray* thisObject = jsCast<JSArray*>(cell);
darin's avatar
darin committed
726
    bool isArrayIndex;
727
    unsigned i = propertyName.toArrayIndex(isArrayIndex);
darin's avatar
darin committed
728
    if (isArrayIndex) {
729
        putByIndex(thisObject, exec, i, value, slot.isStrictMode());
darin's avatar
darin committed
730 731 732 733
        return;
    }

    if (propertyName == exec->propertyNames().length) {
weinig@apple.com's avatar
weinig@apple.com committed
734 735
        unsigned newLength = value.toUInt32(exec);
        if (value.toNumber(exec) != static_cast<double>(newLength)) {
736
            throwError(exec, createRangeError(exec, "Invalid array length"));
darin's avatar
darin committed
737 738
            return;
        }
739
        thisObject->setLength(exec, newLength, slot.isStrictMode());
darin's avatar
darin committed
740 741 742
        return;
    }

743
    JSObject::put(thisObject, exec, propertyName, value, slot);
darin's avatar
darin committed
744 745
}

746
void JSArray::putByIndex(JSCell* cell, ExecState* exec, unsigned i, JSValue value, bool shouldThrow)
747
{
748
    JSArray* thisObject = jsCast<JSArray*>(cell);
749 750 751
    thisObject->checkConsistency();

    ArrayStorage* storage = thisObject->m_storage;
752

753
    // Fast case - store to the vector.
754
    if (i < thisObject->m_vectorLength) {
755
        WriteBarrier<Unknown>& valueSlot = storage->m_vector[i];
756 757 758 759 760 761 762 763 764 765
        unsigned length = storage->m_length;

        // Update m_length & m_numValuesInVector as necessary.
        if (i >= length) {
            length = i + 1;
            storage->m_length = length;
            ++storage->m_numValuesInVector;
        } else if (!valueSlot)
            ++storage->m_numValuesInVector;

766 767
        valueSlot.set(exec->globalData(), thisObject, value);
        thisObject->checkConsistency();
darin's avatar
darin committed
768 769 770
        return;
    }

771 772
    // Handle 2^32-1 - this is not an array index (see ES5.1 15.4), and is treated as a regular property.
    if (UNLIKELY(i > MAX_ARRAY_INDEX)) {
773
        PutPropertySlot slot(shouldThrow);
774 775 776 777 778
        thisObject->methodTable()->put(thisObject, exec, Identifier::from(exec, i), value, slot);
        return;
    }

    // For all other cases, call putByIndexBeyondVectorLength.
779
    thisObject->putByIndexBeyondVectorLength(exec, i, value, shouldThrow);
780
    thisObject->checkConsistency();
781 782
}

783
void JSArray::putByIndexBeyondVectorLength(ExecState* exec, unsigned i, JSValue value, bool shouldThrow)
784
{
785 786
    JSGlobalData& globalData = exec->globalData();

787
    // i should be a valid array index that is outside of the current vector.
788
    ASSERT(i >= m_vectorLength);
789
    ASSERT(i <= MAX_ARRAY_INDEX);
790

791
    ArrayStorage* storage = m_storage;
792
    SparseArrayValueMap* map = m_sparseValueMap;
ap@webkit.org's avatar
ap@webkit.org committed
793

794 795
    // First, handle cases where we don't currently have a sparse map.
    if (LIKELY(!map)) {
796 797 798
        // If the array is not extensible, we should have entered dictionary mode, and created the spare map.
        ASSERT(isExtensible());
    
799 800 801 802
        // Update m_length if necessary.
        if (i >= storage->m_length)
            storage->m_length = i + 1;

803
        // Check that it is sensible to still be using a vector, and then try to grow the vector.
804
        if (LIKELY((isDenseEnoughForVector(i, storage->m_numValuesInVector)) && increaseVectorLength(globalData, i + 1))) {
805
            // success! - reread m_storage since it has likely been reallocated, and store to the vector.
806
            storage = m_storage;
807
            storage->m_vector[i].set(globalData, this, value);
808
            ++storage->m_numValuesInVector;
809
            return;
darin's avatar
darin committed
810
        }
811
        // We don't want to, or can't use a vector to hold this property - allocate a sparse map & add the value.
812 813
        allocateSparseMap(exec->globalData());
        map = m_sparseValueMap;
814
        map->put(exec, this, i, value, shouldThrow);
815
        return;
darin's avatar
darin committed
816 817
    }

818 819 820 821
    // Update m_length if necessary.
    unsigned length = storage->m_length;
    if (i >= length) {
        // Prohibit growing the array if length is not writable.
822
        if (map->lengthIsReadOnly() || !isExtensible()) {
823 824
            if (shouldThrow)
                throwTypeError(exec, StrictModeReadonlyPropertyWriteError);
825 826 827 828 829 830
            return;
        }
        length = i + 1;
        storage->m_length = length;
    }

831 832 833
    // We are currently using a map - check whether we still want to be doing so.
    // We will continue  to use a sparse map if SparseMode is set, a vector would be too sparse, or if allocation fails.
    unsigned numValuesInArray = storage->m_numValuesInVector + map->size();
834
    if (map->sparseMode() || !isDenseEnoughForVector(length, numValuesInArray) || !increaseVectorLength(exec->globalData(), length)) {
835
        map->put(exec, this, i, value, shouldThrow);
barraclough@apple.com's avatar
barraclough@apple.com committed
836 837
        return;
    }
darin's avatar
darin committed
838

839
    // Reread m_storage afterincreaseVectorLength, update m_numValuesInVector.
840
    storage = m_storage;
841
    storage->m_numValuesInVector = numValuesInArray;
842

843 844 845 846
    // Copy all values from the map into the vector, and delete the map.
    WriteBarrier<Unknown>* vector = storage->m_vector;
    SparseArrayValueMap::const_iterator end = map->end();
    for (SparseArrayValueMap::const_iterator it = map->begin(); it != end; ++it)
847
        vector[it->first].set(globalData, this, it->second.getNonSparseMode());
848
    deallocateSparseMap();
849 850 851 852 853 854

    // Store the new property into the vector.
    WriteBarrier<Unknown>& valueSlot = vector[i];
    if (!valueSlot)
        ++storage->m_numValuesInVector;
    valueSlot.set(globalData, this, value);
darin's avatar
darin committed
855 856
}

857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927
bool JSArray::putDirectIndexBeyondVectorLength(ExecState* exec, unsigned i, JSValue value, bool shouldThrow)
{
    JSGlobalData& globalData = exec->globalData();

    // i should be a valid array index that is outside of the current vector.
    ASSERT(i >= m_vectorLength);
    ASSERT(i <= MAX_ARRAY_INDEX);

    ArrayStorage* storage = m_storage;
    SparseArrayValueMap* map = m_sparseValueMap;

    // First, handle cases where we don't currently have a sparse map.
    if (LIKELY(!map)) {
        // If the array is not extensible, we should have entered dictionary mode, and created the spare map.
        ASSERT(isExtensible());
    
        // Update m_length if necessary.
        if (i >= storage->m_length)
            storage->m_length = i + 1;

        // Check that it is sensible to still be using a vector, and then try to grow the vector.
        if (LIKELY((isDenseEnoughForVector(i, storage->m_numValuesInVector)) && increaseVectorLength(globalData, i + 1))) {
            // success! - reread m_storage since it has likely been reallocated, and store to the vector.
            storage = m_storage;
            storage->m_vector[i].set(globalData, this, value);
            ++storage->m_numValuesInVector;
            return true;
        }
        // We don't want to, or can't use a vector to hold this property - allocate a sparse map & add the value.
        allocateSparseMap(exec->globalData());
        map = m_sparseValueMap;
        return map->putDirect(exec, this, i, value, shouldThrow);
    }

    // Update m_length if necessary.
    unsigned length = storage->m_length;
    if (i >= length) {
        // Prohibit growing the array if length is not writable.
        if (map->lengthIsReadOnly())
            return reject(exec, shouldThrow, StrictModeReadonlyPropertyWriteError);
        if (!isExtensible())
            return reject(exec, shouldThrow, "Attempting to define property on object that is not extensible.");
        length = i + 1;
        storage->m_length = length;
    }

    // We are currently using a map - check whether we still want to be doing so.
    // We will continue  to use a sparse map if SparseMode is set, a vector would be too sparse, or if allocation fails.
    unsigned numValuesInArray = storage->m_numValuesInVector + map->size();
    if (map->sparseMode() || !isDenseEnoughForVector(length, numValuesInArray) || !increaseVectorLength(exec->globalData(), length))
        return map->putDirect(exec, this, i, value, shouldThrow);

    // Reread m_storage afterincreaseVectorLength, update m_numValuesInVector.
    storage = m_storage;
    storage->m_numValuesInVector = numValuesInArray;

    // Copy all values from the map into the vector, and delete the map.
    WriteBarrier<Unknown>* vector = storage->m_vector;
    SparseArrayValueMap::const_iterator end = map->end();
    for (SparseArrayValueMap::const_iterator it = map->begin(); it != end; ++it)
        vector[it->first].set(globalData, this, it->second.getNonSparseMode());
    deallocateSparseMap();

    // Store the new property into the vector.
    WriteBarrier<Unknown>& valueSlot = vector[i];
    if (!valueSlot)
        ++storage->m_numValuesInVector;
    valueSlot.set(globalData, this, value);
    return true;
}

928 929
bool JSArray::deleteProperty(JSCell* cell, ExecState* exec, const Identifier& propertyName)
{
930
    JSArray* thisObject = jsCast<JSArray*>(cell);
darin's avatar
darin committed
931
    bool isArrayIndex;
932
    unsigned i = propertyName.toArrayIndex(isArrayIndex);
darin's avatar
darin committed
933
    if (isArrayIndex)
934
        return thisObject->methodTable()->deletePropertyByIndex(thisObject, exec, i);
darin's avatar
darin committed
935 936 937 938

    if (propertyName == exec->propertyNames().length)
        return false;

939
    return JSObject::deleteProperty(thisObject, exec, propertyName);
darin's avatar
darin committed
940 941
}

942
bool JSArray::deletePropertyByIndex(JSCell* cell, ExecState* exec, unsigned i)
943
{
944
    JSArray* thisObject = jsCast<JSArray*>(cell);
945 946
    thisObject->checkConsistency();

947 948 949
    if (i > MAX_ARRAY_INDEX)
        return thisObject->methodTable()->deleteProperty(thisObject, exec, Identifier::from(exec, i));

950
    ArrayStorage* storage = thisObject->m_storage;
951
    
952
    if (i < thisObject->m_vectorLength) {
953
        WriteBarrier<Unknown>& valueSlot = storage->m_vector[i];
954 955 956
        if (valueSlot) {
            valueSlot.clear();
            --storage->m_numValuesInVector;
957
        }
958
    } else if (SparseArrayValueMap* map = thisObject->m_sparseValueMap) {
959 960
        SparseArrayValueMap::iterator it = map->find(i);
        if (it != map->notFound()) {
961 962
            if (it->second.attributes & DontDelete)
                return false;
963
            map->remove(it);
darin's avatar
darin committed
964 965 966
        }
    }

967
    thisObject->checkConsistency();
968 969
    return true;
}
970

971 972
static int compareKeysForQSort(const void* a, const void* b)
{
973 974
    unsigned da = *static_cast<const unsigned*>(a);
    unsigned db = *static_cast<const unsigned*>(b);
975
    return (da > db) - (da < db);
darin's avatar
darin committed
976 977
}

978
void JSArray::getOwnPropertyNames(JSObject* object, ExecState* exec, PropertyNameArray& propertyNames, EnumerationMode mode)
darin's avatar
darin committed
979
{
980
    JSArray* thisObject = jsCast<JSArray*>(object);
darin's avatar
darin committed
981
    // FIXME: Filling PropertyNameArray with an identifier for every integer
982 983
    // is incredibly inefficient for large arrays. We need a different approach,
    // which almost certainly means a different structure for PropertyNameArray.
darin's avatar
darin committed
984

985
    ArrayStorage* storage = thisObject->m_storage;
986
    
987
    unsigned usedVectorLength = min(storage->m_length, thisObject->m_vectorLength);
darin's avatar
darin committed
988
    for (unsigned i = 0; i < usedVectorLength; ++i) {
989
        if (storage->m_vector[i])
ap@webkit.org's avatar
ap@webkit.org committed
990
            propertyNames.add(Identifier::from(exec, i));
darin's avatar
darin committed
991 992
    }

993
    if (SparseArrayValueMap* map = thisObject->m_sparseValueMap) {
994
        Vector<unsigned> keys;
995 996
        keys.reserveCapacity(map->size());
        
997
        SparseArrayValueMap::const_iterator end = map->end();
998 999
        for (SparseArrayValueMap::const_iterator it = map->begin(); it != end; ++it) {
            if (mode == IncludeDontEnumProperties || !(it->second.attributes & DontEnum))
1000
                keys.append(static_cast<unsigned>(it->first));
1001 1002
        }

1003
        qsort(keys.begin(), keys.size(), sizeof(unsigned), compareKeysForQSort);
1004
        for (unsigned i = 0; i < keys.size(); ++i)
1005
            propertyNames.add(Identifier::from(exec, keys[i]));
darin's avatar
darin committed
1006
    }
1007

1008 1009 1010
    if (mode == IncludeDontEnumProperties)
        propertyNames.add(exec->propertyNames().length);

1011
    JSObject::getOwnPropertyNames(thisObject, exec, propertyNames, mode);
darin's avatar
darin committed
1012 1013
}

1014 1015 1016 1017 1018
ALWAYS_INLINE unsigned JSArray::getNewVectorLength(unsigned desiredLength)
{
    ASSERT(desiredLength <= MAX_STORAGE_VECTOR_LENGTH);

    unsigned increasedLength;