ChangeLog 2.54 MB
Newer Older
1
2
3
4
5
6
7
8
9
10
11
12
13
14
2008-05-20  Alice Liu  <alice.liu@apple.com>

        Reviewed by Brady.

        fix <rdar://problem/5908580> 10A58: Dictionary Panel hangs in WebCore::Cache::pruneDeadResources()

        * loader/Cache.cpp:
        (WebCore::Cache::requestUserCSSStyleSheet):
        Add a call to resourceAccessed() to more closely mirror what is done in requestResource()
        (WebCore::Cache::insertInLRUList):
        Assert that any resource in the LRU list has been accessed.  This is early detection of a
        potential hang later when pruning resources, and also agrees with the early return in 
        removeFromLRUList().

mitz@apple.com's avatar
mitz@apple.com committed
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
2008-05-20  Dan Bernstein  <mitz@apple.com>

        Reviewed by Darin Adler.

        - fix https://bugs.webkit.org/show_bug.cgi?id=17655
          <rdar://problem/5778077> REGRESSION (3.1.1-TOT): Reproducible crash calling querySelector on viewless Document

        Test: fast/dom/SelectorAPI/viewless-document.html

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::CSSStyleSelector): Updated to initialize the
        selector checker.
        (WebCore::CSSStyleSelector::init): Removed initialization of
        m_collectRulesOnly, which is now part of the selector checker.
        (WebCore::CSSStyleSelector::matchRules): Updated for renames and data
        moved into the selector checker.
        (WebCore::CSSStyleSelector::matchRulesForList): Ditto.
        (WebCore::CSSStyleSelector::initForStyleResolve): Added a PseudoId
        argument, which is used to initialize a data member of the selector
        checker. Updated for renames. Removed initialization of m_isXMLDoc
        because this bit is now initialized only once in the selector checker's
        constructor.
        (WebCore::CSSStyleSelector::SelectorChecker::SelectorChecker): Added.
        (WebCore::CSSStyleSelector::SelectorChecker::checkPseudoState): Changed
        into a SelectorChecker method.
        (WebCore::CSSStyleSelector::SelectorChecker::checkSelector): Added. Used
        by querySelector() and querySelectorAll().
        (WebCore::CSSStyleSelector::canShareStyleWithElement): Updated for data
        moved into the selector checker.
        (WebCore::CSSStyleSelector::matchUARules): Ditto.
        (WebCore::CSSStyleSelector::styleForElement):
        (WebCore::CSSStyleSelector::pseudoStyleForElement): Ditto. Also removed
        code that set the parentStyle variable after the last place it is
        accessed, and changed to ensure that m_style is set early in this
        function.
        (WebCore::CSSStyleSelector::adjustRenderStyle): Updated for data moved
        into the selector checker.
        (WebCore::CSSStyleSelector::styleRulesForElement): Ditto.
        (WebCore::CSSStyleSelector::checkSelector): Ditto. Also changed to pass
        the element's style and the parent style to the selector checker, as
        well as the dynamic pseudo variable and the selector attributes vector.
        (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Added
        arguments for the style of the base element and its parent. When the
        elementStyle argument is 0, the style is fetched from the element
        and its parent as needed. Also changed to take a reference to the
        dynamic pseudo ID and a pointer to the vector of attributes affecting
        the match.
        (WebCore::CSSStyleSelector::applyProperty): Updated for data moved
        into the selector checker.
        (WebCore::CSSStyleSelector::checkForGenericFamilyChange): Ditto.
        (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize): Ditto.
        (WebCore::CSSStyleSelector::fontSizeForKeyword): Ditto.
        (WebCore::CSSStyleSelector::getColorFromPrimitiveValue): Ditto.
        (WebCore::CSSStyleSelector::SelectorChecker::allVisitedStateChanged):
        Changed into a SelectorChecker method.
        (WebCore::CSSStyleSelector::SelectorChecker::visitedStateChanged):
        Ditto.

        * css/CSSStyleSelector.h:
        Added a SelectorChecker class and moved data and methods used in
        checking selectors into it.
        (WebCore::CSSStyleSelector::allVisitedStateChanged): Changed to call the
        SelectorChecker method.
        (WebCore::CSSStyleSelector::visitedStateChanged): Ditto.
        * dom/Node.cpp:
        (WebCore::Node::querySelector): Changed to use a SelectorChecker instead
        of the document's style selector.
        * dom/SelectorNodeList.cpp:
        (WebCore::SelectorNodeList::SelectorNodeList): Ditto.

85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
2008-05-20  Timothy Hatcher  <timothy@apple.com>

        Implements the Profiles panel and Profile view.

        Reviewed by Kevin McCullough.

        * English.lproj/localizedStrings.js: Added new strings.
        * page/inspector/Images/profileIcon.png: Added.
        * page/inspector/Images/profilesIcon.png: Changed. New icon design
        that fits in with the other toolbar icons.
        * page/inspector/ProfileView.js:
        (WebInspector.ProfileView): Remove custom table elements
        and create a DataGrid. Sorts the profile by descending total time,
        since the profiles aren't sorted by default.
        (WebInspector.ProfileView.prototype.refresh): Clears the DataGrid
        and recreates all the nodes. The selection is preserved.
        (WebInspector.ProfileView.prototype.refreshShowAsPercents): Traverse
        all the children and change showTotalTimeAsPercent and showSelfTimeAsPercent
        to match the ProfileView values. Then call refresh on the child.
        (WebInspector.ProfileView.prototype._sortData): Determine the sort
        function to call on the head profile node. Call it and then call
        refresh to rebuild the DataGrid.
        (WebInspector.ProfileView.prototype._mouseDownInDataGrid): Return early
        if the event is not a double-click. When it is a double-click, determine
        the column that was targeted and if it was total or self toggle the
        show as percent property. Call refreshShowAsPercents.
        (WebInspector.ProfileDataGridNode): 
        (WebInspector.ProfileDataGridNode.prototype.get data): 
        (WebInspector.ProfileDataGridNode.prototype.expand): 
        (WebInspector.ProfileDataGridNode.prototype.collapse): 
        (WebInspector.ProfileDataGridNode.prototype._populate): 
        * page/inspector/ProfilesPanel.js:
        (WebInspector.ProfilesPanel): 
        (WebInspector.ProfilesPanel.prototype.show): Populate the sidebar
        with all profiles. This is a workaround until the Inspector
        is told about new profiles.
        (WebInspector.ProfilesPanel.prototype.reset): Clear the sidebar and
        profile views.
        (WebInspector.ProfilesPanel.prototype.handleKeyEvent): Pass the key
        event to the sidebar.
        (WebInspector.ProfilesPanel.prototype.addProfile): Create a
        ProfileSidebarTreeElement object and add it to the sidebar.
        (WebInspector.ProfilesPanel.prototype.showProfile): Create a ProfileView
        and show it.
        (WebInspector.ProfilesPanel.prototype.closeVisibleView): Hide the
        visible view.
        (WebInspector.ProfilesPanel.prototype._startSidebarDragging): Call
        WebInspector.elementDragStart.
        (WebInspector.ProfilesPanel.prototype._sidebarDragging): Call _updateSidebarWidth.
        (WebInspector.ProfilesPanel.prototype._endSidebarDragging):
        Call WebInspector.elementDragEnd.
        (WebInspector.ProfilesPanel.prototype._updateSidebarWidth): Update the
        sidebar width based on the passed in value.
        (WebInspector.ProfileSidebarTreeElement): Subclass WebInspector.SidebarTreeElement.
        (WebInspector.ProfileSidebarTreeElement.prototype.onselect): Call ProfilesPanel.showProfile.
        (WebInspector.ProfileSidebarTreeElement.prototype.get mainTitle): Return profile.title.
        (WebInspector.ProfileSidebarTreeElement.prototype.set mainTitle): Do nothing.
        (WebInspector.ProfileSidebarTreeElement.prototype.get subtitle): Ditto.
        (WebInspector.ProfileSidebarTreeElement.prototype.set subtitle): Ditto.
        * page/inspector/inspector.css: New styles for the profile sidebar
        item and profile data grid columns.
        * page/inspector/inspector.js:
        * page/inspector/utilities.js:
        (Number.secondsToString): Added a higherResolution argument
        that returns fractional milliseconds.

151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
2008-05-20  chris fleizach  <cfleizach@apple.com>

        Reviewed by Darin Adler, Alice Liu

        <rdar://problem/3438014> Might need accessibility solution for context menus in web pages
        <rdar://problem/5060458> Elements without AXActions should not return kAXErrorFailure

        * page/AccessibilityObject.cpp:
        (WebCore::AccessibilityObject::clickPoint):
        * page/AccessibilityObject.h:
        * page/mac/AccessibilityObjectWrapper.mm:
        (-[AccessibilityObjectWrapper accessibilityActionNames]):
        (-[AccessibilityObjectWrapper accessibilityPerformPressAction]):
        (-[AccessibilityObjectWrapper accessibilityPerformShowMenuAction]):
        (-[AccessibilityObjectWrapper accessibilityShowContextMenu]):
        (-[AccessibilityObjectWrapper accessibilityPerformAction:]):

168
169
170
171
172
173
174
175
176
177
178
179
2008-05-20  Timothy Hatcher  <timothy@apple.com>

        Expose the ProfileNode functionName sorting functions on
        JavaScriptProfileNode.

        Reviewed by Kevin McCullough.

        * page/JavaScriptProfileNode.cpp:
        (WebCore::sortFunctionNameDescending): Call ProfileNode.
        (WebCore::sortFunctionNameAscending): Ditto.
        (WebCore::ProfileNodeClass): Add static functions.

180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
2008-05-20  Darin Adler  <darin@apple.com>

        Reviewed by Mitz.

        - a first small step of CSS DOM refactoring -- the eventual goal is to
          reduce StyleBase and possibly eliminate it, since it has multiple
          purposes and unneccessarily ties many classes together

        * css/CSSCursorImageValue.cpp:
        (WebCore::isSVGCursorIdentifier): Mark static so it has internal linkage.
        (WebCore::resourceReferencedByCursorElement): Ditto.
        (WebCore::CSSCursorImageValue::CSSCursorImageValue): Removed unused style
        argument.
        (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed): Removed code to
        check if X and Y changed before changing them -- there's no reason to do
        that. Removed code that depended on the internals of CSSImageValue. The
        new code uses only protected functions rather than going right at the
        fields and uing internal knowledge of the base class.
        * css/CSSCursorImageValue.h: Added a create function, made constructor
        private, removed unused style argument.

        * css/CSSImageValue.cpp:
        (WebCore::CSSImageValue::CSSImageValue): Removed unused style argument.
        (WebCore::CSSImageValue::cachedImageURL): Added. A protected function for
        use by CSSCursorImageValue that gives the URL.
        (WebCore::CSSImageValue::clearCachedImage): Added. A protected function for
        use by CSSCursorImageValue that clears the CachedImage.
        * css/CSSImageValue.h: Added create functions, made constructors protected
        and private, removed unused style argument, made data members private, added
        some protected functions for use by CSSCursorImageValue.

        * css/CSSImportRule.cpp:
        (WebCore::CSSImportRule::setCSSStyleSheet): Changed to call checkLoaded on
        the parent. This is part of preparation to move the checkLoaded function from
        StyleBase to StyleSheet.
        (WebCore::CSSImportRule::insertedIntoParent): Changed code to check the URL
        of the style sheet to use the href function of the style sheet rather than
        the baseURL function. This eliminates an O(n^2) algorithm here and reduces
        the use of baseURL, part of preparation to move it from StyleBase
        to CSSStyleSheet.

        * css/CSSMutableStyleDeclaration.cpp:
        (WebCore::CSSMutableStyleDeclaration::setImageProperty): Changed to use create
        function instead of a direct call to new for the CSSImageValue classes.
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue): Ditto.
        (WebCore::CSSParser::parseContent): Ditto.
        (WebCore::CSSParser::parseFillImage): Ditto.
        (WebCore::CSSParser::parseBorderImage): Ditto.

        * css/CSSStyleSelector.cpp: Removed unneeded include of CSSImageValue.h.
        * rendering/style/RenderStyle.h: Removed unneeded include of
        CSSCursorImageValue.h, which was causing us to rebuild the world way too often.

        * xml/XSLImportRule.cpp:
        (WebCore::XSLImportRule::setXSLStyleSheet): See change to CSSImportRule above.
        (WebCore::XSLImportRule::loadSheet): Ditto.

238
239
240
241
242
243
244
245
246
2008-05-20  Kevin McCullough  <kmccullough@apple.com>

        Rubber stamped by Adam.

        -Minor fix. Should not use a reference since the original may disappear.

        * page/Console.cpp:
        (WebCore::Console::profile):

247
248
249
250
251
252
253
2008-05-20  Kevin Ollivier  <kevino@theolliviers.com>

        wx build fix. userAgent should return a value.

        * plugins/wx/PluginViewWx.cpp:
        (WebCore::PluginView::userAgent):

254
255
256
257
258
259
260
261
262
263
264
265
266
2008-05-19  Timothy Hatcher  <timothy@apple.com>

        Expose the ProfileNode sorting functions on JavaScriptProfileNode.

        Reviewed by Kevin McCullough.

        * page/JavaScriptProfileNode.cpp:
        (WebCore::sortTotalTimeDescending): Call ProfileNode.
        (WebCore::sortTotalTimeAscending): Ditto.
        (WebCore::sortSelfTimeDescending): Ditto.
        (WebCore::sortSelfTimeAscending): Ditto.
        (WebCore::sortCallsDescending): Ditto.
        (WebCore::sortCallsAscending): Ditto.
267
        (WebCore::ProfileNodeClass): Add static functions.
268

269
270
271
272
273
2008-05-19  Timothy Hatcher  <timothy@apple.com>

        * page/InspectorController.cpp: Change the include for
        JavaScriptProfile.h to sue double quotes instead of backets.

274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
2008-05-19  Timothy Hatcher  <timothy@apple.com>

        Adds a DataGrid object that is used for multi-column data
        and can contain hierarchical content with disclosure arrows.
        A lot of DataGrid was copied from treeoutline.js. This change
        makes the database views use the DataGrid. It will later be
        used by the ProfileView.

        Reviewed by Adam Roben.

        * page/inspector/DataGrid.js: Added. Most copied from treeoutline.js
        and modified to work with table elements.
        * page/inspector/DatabaseQueryView.js:
        (WebInspector.DatabaseQueryView.prototype._queryFinished):
        Call DatabasesPanel.dataGridForResult and adds the inline style to
        the DataGrid element.
        * page/inspector/DatabaseTableView.js:
        (WebInspector.DatabaseTableView.prototype._queryFinished):
        Call DatabasesPanel.dataGridForResult.
        * page/inspector/DatabasesPanel.js:
        (WebInspector.DatabasesPanel.prototype._tableForResult): Removed.
        (WebInspector.DatabasesPanel.prototype.dataGridForResult): Added.
        Similar to the previous _tableForResult function, but makes a DataGrid.
        * page/inspector/inspector.css: Changes to the data-grid
        style rules.
        * WebCore.vcproj/WebCore.vcproj: Add DataGrid.js.
        * page/inspector/WebKit.qrc: Ditto.
        * page/inspector/inspector.html: Ditto.

303
304
305
306
307
308
309
310
311
312
313
314
315
2008-05-19  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Adam.

        -build fix.

        * bindings/js/JSConsoleCustom.cpp:
        (WebCore::JSConsole::profile):
        * page/Console.cpp:
        (WebCore::Console::profile):
        * page/Console.h:
        * page/Console.idl:

316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
2008-05-19  Alp Toker  <alp@nuanti.com>

        Reviewed by Maciej.

        GTK+/soup fixes:

        Remove the fragment part of the URL since the file backend doesn't
        deal with it.

        Fix a typo in the cleanup function.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::cleanupGioOperation):
        (WebCore::ResourceHandle::startGio):

kmccullough@apple.com's avatar
kmccullough@apple.com committed
331
332
333
334
335
336
337
338
339
340
341
342
343
344
2008-05-19  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Adam.

        <rdar://problem/5770054> JavaScript profiler (10928)
        - Send the executing context to the profiler so it can attribute time
        correctly to parent functions when calling profile() and profileEnd()
        while nested.

        * page/Console.cpp:
        (WebCore::Console::profile):
        (WebCore::Console::profileEnd):
        * page/Console.h:

345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
2008-05-19  Alp Toker  <alp@nuanti.com>

        Reviewed by Anders and Beth.

        http://bugs.webkit.org/show_bug.cgi?id=16495
        [GTK] Accessibility support with ATK/AT-SPI

        Initial ATK/AT-SPI accessibility support for the GTK+ port.

        * GNUmakefile.am:
        * page/AccessibilityObject.cpp:
        (WebCore::AccessibilityObject::AccessibilityObject):
        (WebCore::AccessibilityObject::detach):
        * page/AccessibilityObject.h:
        * page/gtk/AXObjectCacheAtk.cpp: Added.
        (WebCore::AXObjectCache::detachWrapper):
        (WebCore::AXObjectCache::attachWrapper):
        (WebCore::AXObjectCache::postNotification):
        (WebCore::AXObjectCache::postNotificationToElement):
        (WebCore::AXObjectCache::handleFocusedUIElementChanged):
        * page/gtk/AccessibilityObjectWrapperAtk.cpp: Added.
        (WebCore::):
        (WebCore::AccessibilityObject::wrapper):
        (WebCore::AccessibilityObject::setWrapper):
        * page/gtk/AccessibilityObjectWrapperAtk.h: Added.

andersca@apple.com's avatar
andersca@apple.com committed
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
2008-05-19  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        <rdar://problem/5946454>
        Support navigator.onLine from HTML5.

        Add Windows NetworkStateNotifier implementation using the IP Helper API.

        * WebCore.vcproj/WebCore.vcproj:
        * platform/network/NetworkStateNotifier.h:
        (WebCore::updateState):
        * platform/network/win/NetworkStateNotifierWin.cpp: Added.
        (WebCore::NetworkStateNotifier::updateState):
        (WebCore::NetworkStateNotifier::addressChanged):
        (WebCore::NetworkStateNotifier::callAddressChanged):
        (WebCore::NetworkStateNotifier::addrChangeCallback):
        (WebCore::NetworkStateNotifier::registerForAddressChange):
        (WebCore::NetworkStateNotifier::NetworkStateNotifier):

391
392
393
394
395
396
397
398
2008-05-19  Steve Falkenburg  <sfalken@apple.com>

        Disable C4273, C4565 for CSSGrammar.cpp, XPathGrammar.cpp to fix build.
        
        Reviewed by Adam Roben.

        * WebCore.vcproj/WebCore.vcproj:

399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
2008-05-19  Adam Roben  <aroben@apple.com>

        Fix Bug 19065: Resources with a space in their URL don't get
        error/warning bubbles

        <https://bugs.webkit.org/show_bug.cgi?id=19065>

        Reviewed by Dan Bernstein.

        Test: manual-tests/inspector/errors-with-space in-url.html

        * manual-tests/inspector/errors-with-space in-url.html: Added.
        * page/Console.cpp:
        (WebCore::Console::error):
        (WebCore::Console::info):
        (WebCore::Console::log):
        (WebCore::Console::warn):
        Pass the raw URL to the Inspector, not the pretty URL, to match the
        URL that was used when initially telling the Inspector about this
        resource. We continue to pass the pretty URL to the ChromeClient for
        backwards compatibility.

421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
2008-05-19  Stephanie Lewis  <slewis@apple.com>

        Reviewed by Darin.

        more fast teardown performance work, WebCore plumbing

        * page/Chrome.cpp:
        (WebCore::Chrome::disableSuddenTermination):
        (WebCore::Chrome::enableSuddenTermination):
        (WebCore::ChromeClient::disableSuddenTermination):
        (WebCore::ChromeClient::enableSuddenTermination):
        * page/Chrome.h:
        * page/ChromeClient.h:
        * page/Page.cpp:
        (WebCore::Page::changePendingUnloadEventCount):
        (WebCore::Page::changePendingBeforeUnloadEventCount):

438
439
440
441
442
443
444
445
446
2008-05-19  Kuchhal  <kuchal@yahoo.com>

        Reviewed by Justin.

        <rdar://problem/5863412> Crash when Ctrl C is pressed after a series of specific mouse events (18506)

        * editing/markup.cpp:
        (WebCore::createMarkup): Null check.

447
448
449
450
451
452
453
454
455
2008-05-19  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Beth Dakin.

        <rdar://problem/5912195> CrashTracer: [USER] 1 crash in Mail at -[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]

        * page/mac/AccessibilityObjectWrapper.mm:
        (visiblePositionForTextMarker):

456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
2008-05-19  Ada Chan  <adachan@apple.com>

        Added CookieStorageWin.h/cpp, introducing methods to get/set the current CFHTTPCookieStorageRef.
        When setting cookies-related attributes in CFURLRequest, make sure we get them from the
        current CFHTTPCookieStorageRef.  Also, set the cookie storage in CFURLRequest.

        Reviewed by Steve Falkenburg.

        * WebCore.vcproj/WebCore.vcproj:
        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::makeFinalRequest):
        * platform/network/cf/ResourceRequestCFNet.cpp:
        (WebCore::ResourceRequest::doUpdatePlatformRequest):
        * platform/network/win/CookieJarCFNetWin.cpp:
        (WebCore::setCookies):
        (WebCore::cookies):
        (WebCore::cookiesEnabled):
        * platform/network/win/CookieStorageWin.cpp: Added.
        (WebCore::currentCookieStorage):
        (WebCore::setCurrentCookieStorage):
        * platform/network/win/CookieStorageWin.h: Added.

ap@webkit.org's avatar
ap@webkit.org committed
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
2008-05-19  Alexey Proskuryakov  <ap@webkit.org>

        Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=18308
        SVG Encoding error with fill attribute

        This is caused by problems with data: URL loading. Besides what is fixed by this patch,
        I filed <rdar://problem/5845875> for CFNetwork.

        While at it, fixed a related javascript: URL issue.

        Tests: fast/loader/data-url-encoding-html.html
               fast/loader/data-url-encoding-svg.html
               fast/loader/javascript-url-encoding.html

        * platform/KURL.cpp:
        (WebCore::KURL::parse): Fix a FIXME, use UTF-8 instead of dropping high bytes. This fixes
        javascript: URL handling.
        (WebCore::encodeRelativeString): Like mailto: URLs, data: ones are all UTF-8. Restructured
        the code to not search for "#" if both parts are to be encoded as UTF-8 anyway.

ap@webkit.org's avatar
ap@webkit.org committed
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
2008-05-19  Alexey Proskuryakov  <ap@webkit.org>

        Reviewed by Darin.

        https://bugs.webkit.org/show_bug.cgi?id=18421
        <rdar://problem/5857369> XMLHttpRequest does not properly encode & and < in outgoing messages

        Test: http/tests/xmlhttprequest/serialize-document.html

        * bindings/js/JSXMLHttpRequestCustom.cpp:
        (WebCore::JSXMLHttpRequest::send): Use createMarkup() instead of Document::toString().

        * dom/Attr.cpp:
        * dom/Attr.h:
        * dom/Document.cpp:
        * dom/Document.h:
        * dom/DocumentFragment.cpp:
        * dom/DocumentFragment.h:
        * dom/Element.cpp:
        * dom/Element.h:
        * dom/Entity.cpp:
        * dom/Entity.h:
        * dom/EntityReference.cpp:
        * dom/EntityReference.h:
        * dom/Node.h:
        * dom/Text.cpp:
        * dom/Text.h:
        * html/HTMLElement.cpp:
        * html/HTMLElement.h:
        Removed most Node::toString() methods, which were massively wrong, and only used for
        XMLHttpRequest::send(). The remanining ones are still used in markup.cpp, but should probably
        be folded into it for consistency.

533
534
535
536
537
538
539
540
541
2008-05-19  Anders Carlsson  <andersca@apple.com>

        Fix Windows build.
        
        * plugins/win/PluginViewWin.cpp:
        (WebCore::PluginView::userAgentStatic):
        (WebCore::PluginView::getValueStatic):
        (WebCore::PluginView::getValue):

542
543
544
545
546
547
548
549
550
2008-05-19  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/5935694> AX: crash in text marker range

        * page/mac/AccessibilityObjectWrapper.mm:
        (textMarkerRangeFromMarkers):

551
552
553
554
555
556
2008-05-19  Darin Adler  <darin@apple.com>

        - fix WebKit build

        * WebCore.xcodeproj/project.pbxproj: Make CSSReflectionDirection.h "private" instead of "project".

557
558
559
560
561
562
563
564
565
2008-05-19  chris fleizach  <cfleizach@apple.com>

        Reviewed by Darin Adler

        <rdar://problem/5700830> VO: VoiceOver should fall back to title attr if form element is not labeled

        * page/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::title):

566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
2008-05-19  Darin Adler  <darin@apple.com>

        Reviewed by Mitz.

        - tweak CSSReflectValue, possibly fixing the leaks seen on the buildbot

        * WebCore.vcproj/WebCore.vcproj: Added CSSReflectionDirection.h. 
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * css/CSSReflectionDirection.h: Added.

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::valueForReflection): Changed to use CSSReflectValue::create.
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseReflect): Ditto.

        * css/CSSReflectValue.h: Added a create function. Got rid of the setter
        functions, which had const PassRefPtr& arguments -- those probably caused
        the leaks although I'm not exactly sure why. Made the contructor and all
        the data members private.

        * rendering/style/RenderStyle.h: Changed to include CSSReflectionDirection.h
        instead of CSSReflectValue.h so we can tweak CSSReflectValue without
        recompiling the world.

590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
2008-05-19  Holger Hans Peter Freyther  <zecke@selfish.org>

        Rubber Stamped by Simon.

        Enforce the WebKit Coding Style.

        * plugins/PluginView.cpp:
        (WebCore::PluginView::load):
        (WebCore::PluginView::setValue):
        * plugins/gtk/PluginViewGtk.cpp:
        (WebCore::PluginView::setFocus):
        (WebCore::PluginView::show):
        (WebCore::PluginView::hide):
        (WebCore::PluginView::attachToWindow):
        (WebCore::PluginView::detachFromWindow):
        (WebCore::PluginView::getValueStatic):
        (WebCore::PluginView::getValue):
        * plugins/qt/PluginViewQt.cpp:
        (WebCore::PluginView::updateWindow):
        (WebCore::PluginView::detachFromWindow):
        (WebCore::PluginView::handlePostReadFile):
        (WebCore::PluginView::getValueStatic):
        (WebCore::PluginView::getValue):

614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
2008-05-14  Marc Ordinas i Llopis  <marc.ordinasillopis@collabora.co.uk>

        Reviewed by Holger.

        https://bugs.webkit.org/show_bug.cgi?id=18882
        https://bugs.webkit.org/show_bug.cgi?id=18892
        Based also on work by Chris Lord.
        
        Provides support for NPAPI plugins that pass NULL as their instance
        info. There are two kinds:
        - Some call NPN_UserAgent and NPN_GetValue before a PluginView has
        been created. For those we provide static versions of those functions.
        - Others call NPN_* functions with a NULL instance inside NPP_*
        calls, for those we've added extra currentPluginView guards.

        * plugins/PluginView.cpp: Add additional currentPluginView guards and
        some small style changes.
        (WebCore::PluginView::start):
        (WebCore::PluginView::performRequest):
        (WebCore::PluginView::bindingInstance):
        (WebCore::PluginView::handlePost):
        * plugins/PluginView.h: Added static versions of NPN_UserAgent and
        NPN_GetValue.
        * plugins/gtk/PluginViewGtk.cpp: Add additional currentPluginView
        guards and some small style changes.
        (WebCore::PluginView::setNPWindowRect):
        (WebCore::PluginView::stop):
        (WebCore::PluginView::userAgentStatic): Added to deal with plugins
        that query this before having a PluginView.
        (WebCore::PluginView::getValueStatic): Added to deal with plugins
        that call this before we have created a PluginView.
        (WebCore::PluginView::getValue): Moved some code to getValueStatic.
        (WebCore::PluginView::init):
        * plugins/npapi.cpp: Call PluginView::userAgentStatic
        and PluginView::getValueStatic if no PluginView is
        present.
        (NPN_UserAgent):
        (NPN_GetValue):
        * plugins/qt/PluginPackageQt.cpp:
        (WebCore::PluginPackage::fetchInfo): Corrected split args because ignoring
        empty entries crashed.
        (WebCore::PluginPackage::load): Resolve all symbols when loading plugins
        to protect against XPCOM dependencies.
        * plugins/qt/PluginViewQt.cpp: Add additional currentPluginView guards and
        some small style changes.
        (WebCore::PluginView::updateWindow):
        (WebCore::PluginView::setNPWindowRect):
        (WebCore::PluginView::stop):
        (WebCore::PluginView::userAgentStatic): Added to deal with plugins
        that query this before having a PluginView.
        (WebCore::PluginView::handlePostReadFile):
        (WebCore::PluginView::getValueStatic): Added to deal with plugins
        that call this before we have created a PluginView.
        (WebCore::PluginView::getValue): Moved some code to getValueStatic.
        (WebCore::PluginView::init): m_needsXEmbed init was moved to constructor.

670
671
672
673
674
675
676
677
678
2008-05-19  Alp Toker  <alp@nuanti.com>

        GTK+ build fix on Mac. Conditionalize XP_UNIX use.

        * plugins/gtk/PluginPackageGtk.cpp:
        (WebCore::PluginPackage::fetchInfo):
        (WebCore::PluginPackage::load):
        * plugins/gtk/PluginViewGtk.cpp:

679
680
681
682
683
684
685
686
2008-05-18  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Darin Adler

        <rdar://problem/5942076> WebKit can no longer find URL links with VoiceOVer-U command (19100)

        * page/AccessibilityObject.h:

darin@apple.com's avatar
darin@apple.com committed
687
688
689
690
691
692
693
694
695
696
697
698
699
700
2008-05-18  Darin Adler  <darin@apple.com>

        Reviewed by Sam.

        - fix <rdar://problem/5943569> crash due to stale ownerNode pointer

        Test: fast/dom/StyleSheet/ownerNode-lifetime.html

        * bindings/js/JSStyleSheetCustom.cpp:
        (WebCore::JSStyleSheet::mark): Added code to mark ownerNode. Includes a comment about how
        it would be even better to solve this in the DOM rather than just in the JavaScript binding.

        * css/StyleSheet.idl: Added CustomMarkFunction attribute.

beidson@apple.com's avatar
beidson@apple.com committed
701
702
703
704
705
706
707
708
709
710
711
712
713
714
2008-05-18  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig

        Fix for https://bugs.webkit.org/show_bug.cgi?id=19111
        Allow `delete storage.itemName` syntax as an alias for `storage.removeItem("itemName")`

        Tests: storage/domstorage/localstorage/delete-removal.html
               storage/domstorage/sessionstorage/delete-removal.html

        * bindings/js/JSStorageCustom.cpp:
        (WebCore::JSStorage::deleteProperty): Only do the delete for non-built in properties
        * storage/Storage.idl:

715
716
717
718
719
720
721
722
723
724
725
726
2008-05-17  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Re-factor core setRequestHeader logic into setRequestHeaderInternal.

        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::sameOriginRequest):
        (WebCore::XMLHttpRequest::setRequestHeader):
        (WebCore::XMLHttpRequest::setRequestHeaderInternal):
        * xml/XMLHttpRequest.h:

weinig@apple.com's avatar
weinig@apple.com committed
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
2008-05-17  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Differentiate between cancelation errors and generic network error in XHR.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::requestFromDelegate):
        (WebCore::FrameLoader::cancelledError):
        * platform/network/ResourceErrorBase.h:
        (WebCore::ResourceErrorBase::setIsCancelation):
        (WebCore::ResourceErrorBase::isCancelation):
        (WebCore::ResourceErrorBase::ResourceErrorBase):
        Add state that differentiates between errors created by cancelation and those made
        by all other generic network errors as this differentiation is needed by some specs.

        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::open):
        (WebCore::XMLHttpRequest::loadRequestSynchronously):
        (WebCore::XMLHttpRequest::clearResponseEntityBody):
        (WebCore::XMLHttpRequest::genericError):
        (WebCore::XMLHttpRequest::networkError):
        (WebCore::XMLHttpRequest::abortError):
        (WebCore::XMLHttpRequest::didFail):
        * xml/XMLHttpRequest.h:
        * xml/XMLHttpRequestException.h:
        (WebCore::XMLHttpRequestException::):
        * xml/XMLHttpRequestException.idl:
        Add ABORT_ERR. This error cannot be raised with the current WebKit architecture
        as it requires the ability to cancel a synchronous XHR, which we cannot currently
        do.  It may be possible in the future though.

759
760
761
762
763
764
765
766
767
768
2008-05-17  Mark Rowe  <mrowe@apple.com>

        Reviewed by Sam Weinig.

        Including wtf/Platform.h or using any of the macros it defines in headers that may be
        included from outside of the WebKit project causes any project using those headers to
        fail to build.

        * page/mac/WebDashboardRegion.h:

769
770
771
772
773
774
775
776
777
778
779
780
781
2008-05-17  Sam Weinig  <sam@webkit.org>

        Reviewed by Brady Eidson.

        Re-factor send() logic a little to make adding cross-site requests easier.

        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::send):
        (WebCore::XMLHttpRequest::sameOriginRequest):
        (WebCore::XMLHttpRequest::loadRequestSynchronously):
        (WebCore::XMLHttpRequest::loadRequestAsynchronously):
        * xml/XMLHttpRequest.h:

782
783
784
785
786
787
788
789
2008-05-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mitz.

        Copy appcache headers.
        
        * WebCore.vcproj/WebCore.vcproj:

antti@apple.com's avatar
antti@apple.com committed
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
2008-05-16  Antti Koivisto  <antti@apple.com>

        Reviewed by Anders.
        
        Fix <rdar://problem/5934400> 
        Movie controller does not update on first load of http://www.apple.com/getamac/ads/
        
        The issue is that we execute scripts while there are still pending stylesheet loads.
        If the script depends on a stylesheet having been applied it may fail.
        
        This will make external script execution block on external stylesheet loads. A full
        fix (as discussed with Hyatt) will also need to block inline script execution.

        Test: http/tests/local/stylesheet-and-script-load-order-http.html

        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::notifyFinished):

808
809
810
811
812
813
814
815
816
817
2008-05-16  chris fleizach  <cfleizach@apple.com>

        Reviewed by Jon Honeycutt

        <rdar://problem/5582483> Mail compose area needs to allow AXValue to be settable

        * page/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::isReadOnly):
        (WebCore::AccessibilityRenderObject::canSetValueAttribute):

818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
2008-05-16  Stephanie Lewis  <slewis@apple.com>

        Reviewed by Maciej.

        track onbeforeunlaod event counts. Pretty much identical to unload event tracking.
        Also rename methods from onunload tracking to be more clear.

        increment/decrement event counts when onunload and onbeforeunload events are added/removed
        * dom/Document.cpp:
        (WebCore::Document::removeHTMLWindowEventListener):
        (WebCore::Document::addWindowEventListener):
        (WebCore::Document::removeWindowEventListener):
        (WebCore::Document::addPendingFrameUnloadEventCount):
        (WebCore::Document::removePendingFrameUnloadEventCount):
        (WebCore::Document::addPendingFrameBeforeUnloadEventCount):
        (WebCore::Document::removePendingFrameBeforeUnloadEventCount):
        * dom/Document.h:
        
        clear onunload count after unload events are dispatched
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::stopLoading):

        track onunload and onbeforeunload event counts for each frame
        * page/EventHandler.cpp:
        (WebCore::EventHandler::EventHandler):
        (WebCore::EventHandler::addPendingFrameUnloadEventCount):
        (WebCore::EventHandler::removePendingFrameUnloadEventCount):
        (WebCore::EventHandler::clearPendingFrameUnloadEventCount):
        (WebCore::EventHandler::pendingFrameBeforeUnloadEventCount):
        (WebCore::EventHandler::addPendingFrameBeforeUnloadEventCount):
        (WebCore::EventHandler::removePendingFrameBeforeUnloadEventCount):
        (WebCore::EventHandler::clearPendingFrameBeforeUnloadEventCount):
        * page/EventHandler.h:
        
        clear unbeforeunload count after unbeforeunload events are detached
        * page/Frame.cpp:
        (WebCore::Frame::shouldClose):

        track total event count at page level
        * page/Page.cpp:
        (WebCore::Page::Page):
        (WebCore::Page::changePendingUnloadEventCount):
        (WebCore::Page::pendingBeforeUnloadEventCount):
        (WebCore::Page::changePendingBeforeUnloadEventCount):
        * page/Page.h:

andersca@apple.com's avatar
andersca@apple.com committed
864
865
866
867
868
869
870
871
872
873
874
875
2008-05-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mitz.

        <rdar://problem/5787788>
        REGRESSION: fast/loader/xmlhttprequest-missing-file-exception.html fails on Windows.
        
        Replicate the Mac behavior when a sync load fails.
        
        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::ResourceHandle::loadResourceSynchronously):

876
877
878
879
880
881
882
883
884
885
886
887
2008-05-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Brady.

        Parse and set the headers on the response.

        * loader/appcache/ApplicationCacheStorage.cpp:
        (WebCore::ApplicationCacheStorage::store):
        (WebCore::parseHeader):
        (WebCore::parseHeaders):
        (WebCore::ApplicationCacheStorage::loadCache):

888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
2008-05-16  Timothy Hatcher  <timothy@apple.com>

        Adds the "this" object to the Local scope section of the
        Scope Variables pane.

        <rdar://problem/5774773> Web Inspector doesn't show the "this"
        object in its variables list (10438)

        Reviewed by Oliver Hunt.

        * bindings/js/JSJavaScriptCallFrameCustom.cpp:
        (WebCore::JSJavaScriptCallFrame::thisObject): Returns the thisObject
        of the JavaScriptCallFrame impl. Returns jsNull if the impl is invalid.
        * page/JavaScriptCallFrame.cpp:
        (WebCore::JavaScriptCallFrame::thisObject): Return the thisValue from
        the ExecState. Return 0 if m_exec is null.
        * page/JavaScriptCallFrame.h:
        * page/JavaScriptCallFrame.idl: Add thisObject.
        * page/inspector/ObjectPropertiesSection.js:
        (WebInspector.ObjectPropertiesSection): Adds two new arguments.
        The ignoreHasOwnProperty tells the section to show all properties,
        including inherited ones. And extraProperties is an object of
        additional properties to show.
        (WebInspector.ObjectPropertiesSection.prototype): Honor the
        extraProperties and ignoreHasOwnProperty properties.
        * page/inspector/ScopeChainSidebarPane.js:
        (WebInspector.ScopeChainSidebarPane.prototype.update): Add a this
        property to an extra object that is passed to the ObjectPropertiesSection.
        Also pass true for ignoreHasOwnProperty since we want to show all properties.

918
919
920
921
922
923
924
925
926
927
928
2008-05-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Brady.

        Add mimeType and textEncodingName to the resource table.
        
        * loader/appcache/ApplicationCacheStorage.cpp:
        (WebCore::ApplicationCacheStorage::openDatabase):
        (WebCore::ApplicationCacheStorage::store):
        (WebCore::ApplicationCacheStorage::loadCache):

kmccullough@apple.com's avatar
kmccullough@apple.com committed
929
930
931
932
933
934
935
936
937
938
939
940
2008-05-16  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Tim.

        <rdar://problem/5770054> JavaScript profiler (10928)
        Use a Vector instead of a Deque since we don't use the extra capabilities
        of the Deque.

        * page/JavaScriptProfileNode.cpp:
        (WebCore::getChildren):
        (WebCore::toJS):

941
942
943
944
945
946
947
948
949
950
951
2008-05-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Brady.

        Add a version table to the database.

        * loader/appcache/ApplicationCacheStorage.cpp:
        (WebCore::ApplicationCacheStorage::verifySchemaVersion):
        (WebCore::ApplicationCacheStorage::openDatabase):
        * loader/appcache/ApplicationCacheStorage.h:

952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
2008-05-16  Timothy Hatcher  <timothy@apple.com>

        Adds the ability to evaluate expressions in the local scope
        of the selected call frame.

        https://bugs.webkit.org/show_bug.cgi?id=19052

        Reviewed by Geoff Garen.

        * bindings/js/JSJavaScriptCallFrameCustom.cpp:
        (WebCore::JSJavaScriptCallFrame::evaluate): Pass the exception
        from evaluate to the calling ExecState.
        * page/JavaScriptCallFrame.cpp:
        (WebCore::JavaScriptCallFrame::evaluate): Added an exception out
        argument. Simplified the code by calling KJS:eval directly.
        * page/JavaScriptCallFrame.h: Change evalutate to take an exception
        out argument.
        * page/inspector/Console.js: Check if the debugger is paused and
        call evaluateInSelectedCallFrame on the Scripts panel.
        * page/inspector/ScriptsPanel.js: Added a paused getter and
        evaluateInSelectedCallFrame which does the evaluation and updates
        the scope variables pane afterwards.

975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
2008-05-16  Timothy Hatcher  <timothy@apple.com>

        Fixed the bug where the Inspector node highlight would not show
        in the correct place for nodes in frames.

        <rdar://problem/5712834> Elements in iframes are highlighted incorrectly (14408)

        Reviewed by John Sullivan.

        * page/InspectorController.cpp:
        (WebCore::convertFromFrameToMainFrame): Helper function to convert
        IntRect coordinates from one frame to the main frame.
        (WebCore::InspectorController::drawNodeHighlight): Call the
        convertFromFrameToMainFrame helper for all the rects we get from
        the node since they are in the owner frame's coordinate space.

jchaffraix@webkit.org's avatar
jchaffraix@webkit.org committed
991
992
993
994
995
996
997
998
999
1000
2008-05-16  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Eric.

        Preparatory work for bug 9191: JS*ElementWrapperFactory should be autogenerated

        Make video tags use a header guard so that make_names.pl for factory generation.

        - Add video tag guard in HTMLTagNames.in & give an extraDefines parameter to make_names.pl
        when generating HTMLNames.
For faster browsing, not all history is shown. View entire blame