ChangeLog 2.43 MB
Newer Older
ap@webkit.org's avatar
ap@webkit.org committed
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15
2008-05-13  Alexey Proskuryakov  <ap@webkit.org>

        Reviewed by John Sullivan.

        <rdar://problem/4852077> REGRESSION: The content of the HTML file which is saved as Thai
        (ISO 8859-11) disappear.

        <rdar://problem/5842597> Thai ISO-8859-11 should be upgraded to Windows-874

        Test: fast/encoding/char-decoding.html

        * platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerExtendedEncodingNames):
        Register ISO-8859-11, which doesn't have a standard IANA name, despite following
        the usual 8859 naming scheme. Also, made TIS-620 map to windows-874-2000 explicitly.

16 17 18 19 20 21 22 23 24
2008-05-13  chris fleizach  <cfleizach@apple.com>

        Reviewed by Beth Dakin

        <rdar://problem/5471973> Some AXLinks are not getting AXTitles though there is title text

        * page/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::title):

ap@webkit.org's avatar
ap@webkit.org committed
25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49
2008-05-13  Alexey Proskuryakov  <ap@webkit.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=18681
        <rdar://problem/5888130> WebKit should not remove BOM characters from content.

        We were only trying to match Firefox, and it doesn't do this any more.

        Tests: fast/encoding/bom-in-content.html
               fast/encoding/bom-in-content-utf16.html

        * platform/text/TextDecoder.cpp: (WebCore::TextDecoder::checkForBOM): Skip the BOM if it's
        at the start of input stream.

        * platform/text/TextCodec.cpp:
        * platform/text/TextCodec.h:
        * platform/text/TextCodecICU.cpp:
        (WebCore::TextCodecICU::decode):
        * platform/text/TextCodecUTF16.cpp:
        (WebCore::TextCodecUTF16::decode):
        * platform/text/mac/TextCodecMac.cpp:
        (WebCore::TextCodecMac::decode):
        Don't remove the BOM.

andersca@apple.com's avatar
andersca@apple.com committed
50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68
2008-05-13  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.

        Don't crash when a document loader is destroyed while an initial caching attempt
        is in progress.

        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::~ApplicationCacheGroup):
        Stop loading.
        
        (WebCore::ApplicationCacheGroup::stopLoading):
        New method that stops a cache update.
        
        (WebCore::ApplicationCacheGroup::documentLoaderDestroyed):
        Delete ourselves here.
        
        * loader/appcache/ApplicationCacheGroup.h:

ap@webkit.org's avatar
ap@webkit.org committed
69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84
2008-05-13  Alexey Proskuryakov  <ap@webkit.org>

        Reviewed by Darin.

        <rdar://problem/5841351> Turkish ISO 8859-9 encoding should be treated as windows-1254

        Match IE and upgrade ISO-8859-9 to windows-1254, which is its strict superset.

        Test: fast/encoding/char-decoding.html

        * platform/text/TextCodecICU.cpp:
        (WebCore::TextCodecICU::registerExtendedEncodingNames): Register the standard name
        unconditionally. Previously, we registered windows-949-2000 as a special case that lacked 
        an IANA standard name, and got away with not registering GBK because it happened
        to be reported by ICU normally earlier than any encoding upgraded to it.

85 86 87 88 89 90 91 92 93 94
2008-05-13  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon

        Fix QtWebKit build on Qt embedded.

        * WebCore.pro:
        * platform/FileSystem.h:
        * platform/qt/FileSystemQt.cpp:

95 96 97 98 99 100 101 102 103 104
2008-05-13  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Simon.

        For Gtk/X11 and Qt/X11, use a more extensive plug-ins scan directories set

        * plugins/PluginDatabase.cpp:
        (WebCore::addMozillaPluginDirectories):
        (WebCore::PluginDatabase::isPreferredPluginDirectory):

105 106 107 108 109 110 111 112 113 114
2008-05-12  Adam Roben  <aroben@apple.com>

        Turn on warnings as errors in WebCore.vcproj

        Rubberstamped by Anders Carlsson.

        * WebCore.vcproj/WebCore.vcproj: Also let VS reformat the file as it
        saw fit. The important part is the removal of the WarnAsError="false"
        lines.

115 116 117 118 119 120 121 122 123 124 125 126
2008-05-12  Adam Roben  <aroben@apple.com>

        Fix a MSVC warning in PluginViewWin

        Reviewed by Anders Carlsson.

        Test: http/tests/plugins/post-url-file.html

        * plugins/win/PluginViewWin.cpp:
        (WebCore::PluginView::handlePostReadFile): Added a missing return
        statement.

127 128 129 130 131 132 133 134 135 136 137 138
2008-05-12  Adam Roben  <aroben@apple.com>

        Fix a MSVC warning in GetEOTHeader

        Reviewed by Dan Bernstein.

        * platform/graphics/win/GetEOTHeader.cpp:
        (WebCore::getEOTHeader): MSVC complains that having a 0-sized array in
        a struct is a non-standard extension. I've replaced the 0-sized arrays
        with arrays of 1 element, and replaced sizeof(structType) with
        offsetof(structType, arrayMember).

139 140 141 142 143 144 145 146 147 148 149 150 151 152 153
2008-05-09  Adam Roben  <aroben@apple.com>

        Fix a MSVC warning in TextCodecICU

        Reviewed by John Sullivan and Dan Bernstein.

        * platform/text/TextCodecICU.cpp:
        (WebCore::ErrorCallbackSetter::~ErrorCallbackSetter):
        UCNV_SUB_STOP_ON_ILLEGAL is a string literal, so using == with it
        doesn't really do what we want. Use strcmp instead. It's OK to pass an
        unknown value to strcmp here since 1) UCNV_SUB_STOP_ON_ILLEGAL is only
        a single character long so we're not going to ready more than 2 bytes
        from oldContext, and 2) we're inside an ASSERT which will cause a
        crash anyway if it fails.

154 155 156 157 158 159 160 161 162
2008-05-09  Adam Roben  <aroben@apple.com>

        Fix a MSVC warning in CSSComputedStyleDeclaration

        Reviewed by Geoff Garen.

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::valueForRepeatRule): Removed some unreachable code.

163 164 165 166 167 168 169 170 171 172 173
2008-05-09  Adam Roben  <aroben@apple.com>

        Fix a MSVC warning in InlineTextBox

        Reviewed by Dan Bernstein.

        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paint): Initialize some variables that MSVC
        isn't smart enough to figure out will always be initialized in the
        cases where they are used.

174 175 176 177 178 179 180 181 182 183
2008-05-09  Adam Roben  <aroben@apple.com>

        Fix a MSVC warning in Position

        Reviewed by Darin Adler.

        * dom/Position.cpp:
        (WebCore::Position::getInlineBoxAndOffset): Use parentheses to make
        the precedence of our expressions explicit.

184 185 186 187 188 189 190 191 192 193 194
2008-05-09  Adam Roben  <aroben@apple.com>

        Fix a MSVC warning in String

        Reviewed by Geoff Garen.

        * platform/text/String.cpp:
        (WebCore::toIntegralType): Disable a bogus warning about using unary -
        on an unsigned value. MSVC isn't smart enough to figure out that
        isNegative will always be false when value is unsigned.

195 196 197 198 199 200 201 202 203 204
2008-05-09  Adam Roben  <aroben@apple.com>

        Fix a MSVC warning in XMLHttpRequest

        Reviewed by Geoff Garen.

        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::XMLHttpRequest): Added static_cast<unsigned
        long>.

andersca@apple.com's avatar
andersca@apple.com committed
205 206 207 208 209 210 211 212 213
2008-05-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Handle the case when a resource with the same URL as the manifest is listed in the manifest.

        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::addEntry):

214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239
2008-05-12  Sam Weinig  <sam@webkit.org>

        Reviewed by Dan Bernstein.

        Add parsing of AccessControlHeader and AccessItemRule.

        * xml/AccessControlList.cpp:
        (WebCore::AccessControlList::parseAccessControlHeader): When multiple http headers are sent
        in the response, the engine will concatenate them with commas separating the rules.  This simply
        reverses that process by splitting on the commas.
        (WebCore::AccessControlList::show):
        * xml/AccessControlList.h:
        * xml/AccessItem.cpp:
        (WebCore::AccessItem::AccessItem):
        (WebCore::AccessItem::show):
        * xml/AccessItem.h:
        (WebCore::AccessItem::isValid):
        * xml/AccessItemRule.cpp:
        (WebCore::skipLWS):
        (WebCore::AccessItemRule::parseAccessItemRule): Parse the rule according to the BNF provided by
        the Access Control spec.
        (WebCore::AccessItemRule::parsePatternList):
        (WebCore::AccessItemRule::invalidate):
        (WebCore::AccessItemRule::show):
        * xml/AccessItemRule.h:

240 241 242 243 244 245 246 247 248 249 250
2008-05-12  David Kilzer  <ddkilzer@apple.com>

        Fix logic error in DocLoader::clearPreloads()

        Reviewed by Antti.

        * loader/DocLoader.cpp:
        (WebCore::DocLoader::clearPreloads): Be sure to decrease the preload count for
        the cached resource before trying to remove it from the cache.  A non-zero
        preload count can prevent the resource from being removed from the cache.

andersca@apple.com's avatar
andersca@apple.com committed
251 252 253 254 255 256 257 258 259
2008-05-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Handle empty manifest files without crashing.
        
        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::startLoadingEntry):

260 261 262 263 264 265
2008-05-12  Alp Toker  <alp@nuanti.com>

        GTK+ build fix for breakage in r33056. Include limits.h for INT_MAX.

        * platform/graphics/FontCache.h:

266 267 268 269 270 271 272 273 274 275 276
2008-05-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Add user agent to requests when loading/updating the cache.
    
        * loader/FrameLoader.h:
        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::update):
        (WebCore::ApplicationCacheGroup::startLoadingEntry):

andersca@apple.com's avatar
andersca@apple.com committed
277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295
2008-05-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Make it possible to perform synchronous loads from the application cache.
        
        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::shouldLoadResourceFromApplicationCache):
        Factor out code from scheduleApplicationCacheLoad in its own method.
        
        (WebCore::DocumentLoader::scheduleApplicationCacheLoad):
        Call shouldLoadResourceFromApplicationCache here instead.
        
        * loader/DocumentLoader.h:
        
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::loadResourceSynchronously):
        Call shouldLoadResourceFromApplicationCache.

mitz@apple.com's avatar
mitz@apple.com committed
296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372
2008-05-12  Dan Bernstein  <mitz@apple.com>

        Reviewed by Ada Chan and Sam Weinig.

        - WebCore changes for https://bugs.webkit.org/show_bug.cgi?id=17097
          <rdar://problem/5715471> CGFontRefs (and HFONTs on Windows) leak because FontCache grows without bound

        Added a way for clients to let the cache know that they no longer need
        font data, which lets the cache release it. Changed clients to track
        most of the font data they get from the cache so that they can later
        release it. Some instances of font data -- namely, those used for system
        font fallback -- are still not tracked and will therefore remain in the
        cache indefinitely.

        * WebCore.base.exp: Added exports for WebCoreStatistics in WebKit.

        * platform/graphics/Font.cpp:
        (WebCore::Font::Font): Changed to use FontFallbackList::create().
        (WebCore::Font::update): Ditto.

        * platform/graphics/FontCache.cpp:
        (WebCore::FontCache::getCachedFontData): Added code to track the number
        of times a SimpleFontData instance has been requested from the cache,
        remove requested instances from the inactive list, and purge inactive
        font data if the inactive list has grown above its maximum allowed size.
        (WebCore::FontCache::releaseFontData): Added. Called by clients to let
        the cache know that they no longer need the font data. Adds the font
        data to the inactive list if the last client has released it.
        (WebCore::FontCache::purgeInactiveFontData): Added. Removes inactive
        font data from the cache (and the inactive list).
        (WebCore::FontCache::fontDataCount): Added to provide statistics.
        (WebCore::FontCache::inactiveFontDataCount): Ditto.

        * platform/graphics/FontCache.h:

        * platform/graphics/FontData.h:
        (WebCore::FontData::FontData): Added a member variable to store the
        highest glyph page tree level in which there is a node for this FontData.
        This is used to limit the depth of the search when pruning glyph page
        trees.
        (WebCore::FontData::setMaxGlyphPageTreeLevel): Added this accessor.
        (WebCore::FontData::maxGlyphPageTreeLevel): Ditto.

        * platform/graphics/FontFallbackList.cpp:
        (WebCore::FontFallbackList::FontFallbackList): Changed to start with a
        refcount of 1.
        (WebCore::FontFallbackList::invalidate): Added a call to
        releaseFontData().
        (WebCore::FontFallbackList::releaseFontData): Added. Lets the font cache
        know that we no longer need the FontData in our font list.
        (WebCore::FontFallbackList::fontDataAt): Changed to record in the font
        list whether the font data is a custom font data or not.
        (WebCore::FontFallbackList::setPlatformFont): Ditto.

        * platform/graphics/FontFallbackList.h:
        (WebCore::FontFallbackList::create): Added and made the constructor
        private.
        (WebCore::FontFallbackList::~FontFallbackList): Added a call to
        releaseFontData().

        * platform/graphics/GlyphPageTreeNode.cpp:
        (WebCore::GlyphPageTreeNode::treeGlyphPageCount): Added to provide
        statistics.
        (WebCore::GlyphPageTreeNode::pageCount): Ditto.

        (WebCore::GlyphPageTreeNode::pruneTreeFontData): Added.
        (WebCore::GlyphPageTreeNode::getChild): Added code to update the font
        data's maximum glyph page tree level.
        (WebCore::GlyphPageTreeNode::pruneFontData): Added.

        * platform/graphics/GlyphPageTreeNode.h:

        * platform/graphics/SimpleFontData.cpp:
        (WebCore::SimpleFontData::~SimpleFontData): Added code to let the font
        cache know that we no longer need the small caps font data and to prune
        the glyph page trees.

andersca@apple.com's avatar
andersca@apple.com committed
373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392
2008-05-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Alexey.

        Add ApplicationCacheStorage::empty() method which will empty
        the application cache database.
        
        * WebCore.base.exp:
        * loader/appcache/ApplicationCache.cpp:
        (WebCore::ApplicationCache::clearStorageID):
        * loader/appcache/ApplicationCache.h:
        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::clearStorageID):
        * loader/appcache/ApplicationCacheGroup.h:
        * loader/appcache/ApplicationCacheResource.h:
        (WebCore::ApplicationCacheResource::clearStorageID):
        * loader/appcache/ApplicationCacheStorage.cpp:
        (WebCore::ApplicationCacheStorage::empty):
        * loader/appcache/ApplicationCacheStorage.h:

393 394 395 396 397 398 399 400 401
2008-05-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by John.

        Don't throw an exception if the string passed in is an invalid URL.
        
        * loader/appcache/DOMApplicationCache.cpp:
        (WebCore::DOMApplicationCache::remove):

402 403 404 405 406 407 408 409
2008-05-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mitz.

        Add the variable enums for getting the input vtables.
        
        * bridge/npapi.h:

aroben@apple.com's avatar
aroben@apple.com committed
410 411 412 413 414 415 416
2008-05-12  Adam Roben  <aroben@apple.com>

        Windows build fix

        * WebCorePrefix.cpp: Touched this so that it will rebuild now that
        ENABLE_CROSS_DOCUMENT_MESSAGING has been removed.

417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624
2008-05-12  Alexey Proskuryakov  <ap@webkit.org>

        Roll out recent  threading changes (r32807, r32810, r32819, r32822) to simplify
        SquirrelFish merging.

        * bindings/js/GCController.cpp:
        (WebCore::collect):
        (WebCore::GCController::gcTimerFired):
        (WebCore::GCController::garbageCollectNow):
        * bindings/js/JSAudioConstructor.cpp:
        (WebCore::JSAudioConstructor::JSAudioConstructor):
        * bindings/js/JSCSSRuleCustom.cpp:
        (WebCore::toJS):
        * bindings/js/JSCSSStyleDeclarationCustom.cpp:
        (WebCore::JSCSSStyleDeclaration::nameGetter):
        * bindings/js/JSCSSValueCustom.cpp:
        (WebCore::toJS):
        * bindings/js/JSCanvasPixelArrayCustom.cpp:
        (WebCore::JSCanvasPixelArray::indexGetter):
        (WebCore::toJS):
        * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
        (WebCore::toJS):
        * bindings/js/JSClipboardCustom.cpp:
        (WebCore::JSClipboard::types):
        (WebCore::JSClipboard::getData):
        * bindings/js/JSCustomXPathNSResolver.cpp:
        (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
        * bindings/js/JSDOMApplicationCacheCustom.cpp:
        (WebCore::JSDOMApplicationCache::addEventListener):
        (WebCore::JSDOMApplicationCache::removeEventListener):
        (WebCore::JSDOMApplicationCache::setOnchecking):
        (WebCore::JSDOMApplicationCache::setOnerror):
        (WebCore::JSDOMApplicationCache::setOnnoupdate):
        (WebCore::JSDOMApplicationCache::setOndownloading):
        (WebCore::JSDOMApplicationCache::setOnprogress):
        (WebCore::JSDOMApplicationCache::setOnupdateready):
        (WebCore::JSDOMApplicationCache::setOncached):
        * bindings/js/JSDOMWindowBase.cpp:
        (WebCore::JSDOMWindowBase::JSDOMWindowBase):
        (WebCore::JSDOMWindowBase::getValueProperty):
        (WebCore::JSDOMWindowBase::setListener):
        (WebCore::JSDOMWindowBase::findOrCreateJSEventListener):
        (WebCore::JSDOMWindowBase::findJSUnprotectedEventListener):
        (WebCore::JSDOMWindowBase::findOrCreateJSUnprotectedEventListener):
        (WebCore::windowProtoFuncAToB):
        (WebCore::windowProtoFuncBToA):
        (WebCore::windowProtoFuncSetTimeout):
        (WebCore::windowProtoFuncSetInterval):
        (WebCore::windowProtoFuncAddEventListener):
        * bindings/js/JSDOMWindowBase.h:
        * bindings/js/JSDOMWindowShell.cpp:
        * bindings/js/JSDOMWindowShell.h:
        * bindings/js/JSDocumentCustom.cpp:
        (WebCore::toJS):
        * bindings/js/JSEventCustom.cpp:
        (WebCore::toJS):
        * bindings/js/JSEventTargetBase.cpp:
        (WebCore::jsEventTargetAddEventListener):
        * bindings/js/JSEventTargetBase.h:
        (WebCore::JSEventTargetPrototype::self):
        * bindings/js/JSEventTargetNode.cpp:
        (WebCore::JSEventTargetNode::setListener):
        * bindings/js/JSHTMLCollectionCustom.cpp:
        (WebCore::getNamedItems):
        (WebCore::toJS):
        * bindings/js/JSHTMLElementWrapperFactory.cpp:
        (WebCore::createJSHTMLWrapper):
        * bindings/js/JSHTMLFormElementCustom.cpp:
        (WebCore::JSHTMLFormElement::nameGetter):
        * bindings/js/JSHTMLInputElementBase.cpp:
        (WebCore::JSHTMLInputElementBase::getValueProperty):
        * bindings/js/JSHTMLOptionElementConstructor.cpp:
        (WebCore::JSHTMLOptionElementConstructor::JSHTMLOptionElementConstructor):
        * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
        (WebCore::JSHTMLOptionsCollection::length):
        * bindings/js/JSInspectedObjectWrapper.cpp:
        (WebCore::JSInspectedObjectWrapper::wrap):
        * bindings/js/JSInspectorCallbackWrapper.cpp:
        (WebCore::JSInspectorCallbackWrapper::wrap):
        * bindings/js/JSLocationCustom.cpp:
        (WebCore::JSLocation::toString):
        * bindings/js/JSNamedNodesCollection.cpp:
        (WebCore::JSNamedNodesCollection::lengthGetter):
        * bindings/js/JSNavigatorCustom.cpp:
        (WebCore::JSNavigator::appVersion):
        * bindings/js/JSNodeCustom.cpp:
        (WebCore::toJS):
        * bindings/js/JSNodeFilterCustom.cpp:
        (WebCore::JSNodeFilter::acceptNode):
        * bindings/js/JSRGBColor.cpp:
        (WebCore::getJSRGBColor):
        * bindings/js/JSSQLResultSetRowListCustom.cpp:
        (WebCore::JSSQLResultSetRowList::item):
        * bindings/js/JSSVGElementWrapperFactory.cpp:
        (WebCore::createJSSVGWrapper):
        * bindings/js/JSSVGLazyEventListener.cpp:
        (WebCore::JSSVGLazyEventListener::eventParameterName):
        * bindings/js/JSStorageCustom.cpp:
        (WebCore::JSStorage::nameGetter):
        * bindings/js/JSStyleSheetCustom.cpp:
        (WebCore::toJS):
        * bindings/js/JSXMLHttpRequestConstructor.cpp:
        (WebCore::JSXMLHttpRequestConstructor::construct):
        * bindings/js/JSXMLHttpRequestCustom.cpp:
        (WebCore::JSXMLHttpRequest::setOnreadystatechange):
        (WebCore::JSXMLHttpRequest::setOnload):
        (WebCore::JSXMLHttpRequest::setOnprogress):
        (WebCore::JSXMLHttpRequest::getResponseHeader):
        (WebCore::JSXMLHttpRequest::addEventListener):
        (WebCore::JSXMLHttpRequest::removeEventListener):
        * bindings/js/JSXSLTProcessorConstructor.cpp:
        (WebCore::JSXSLTProcessorConstructor::construct):
        * bindings/js/JSXSLTProcessorCustom.cpp:
        (WebCore::JSXSLTProcessor::getParameter):
        * bindings/js/kjs_binding.cpp:
        (WebCore::jsStringOrNull):
        (WebCore::jsOwnedStringOrNull):
        (WebCore::jsStringOrUndefined):
        (WebCore::jsStringOrFalse):
        (WebCore::nonCachingStaticFunctionGetter):
        (WebCore::objectToStringFunctionGetter):
        * bindings/js/kjs_binding.h:
        (WebCore::DOMObject::DOMObject):
        (WebCore::cacheDOMObject):
        (WebCore::cacheSVGDOMObject):
        * bindings/js/kjs_events.cpp:
        (WebCore::JSLazyEventListener::eventParameterName):
        (WebCore::JSLazyEventListener::parseCode):
        * bindings/js/kjs_html.cpp:
        (WebCore::getRuntimeObject):
        * bindings/scripts/CodeGeneratorJS.pm:
        * bridge/c/c_instance.cpp:
        (KJS::Bindings::CInstance::defaultValue):
        (KJS::Bindings::CInstance::stringValue):
        (KJS::Bindings::CInstance::numberValue):
        (KJS::Bindings::CInstance::valueOf):
        * bridge/c/c_instance.h:
        * bridge/c/c_utility.cpp:
        (KJS::Bindings::convertNPVariantToValue):
        * bridge/jni/jni_instance.cpp:
        (JavaInstance::stringValue):
        (JavaInstance::numberValue):
        (JavaInstance::invokeMethod):
        (JavaInstance::defaultValue):
        (JavaInstance::valueOf):
        * bridge/jni/jni_instance.h:
        * bridge/jni/jni_jsobject.h:
        * bridge/jni/jni_jsobject.mm:
        (JavaJSObject::call):
        (JavaJSObject::setMember):
        (JavaJSObject::setSlot):
        (JavaJSObject::convertJObjectToValue):
        (JavaJSObject::getListFromJArray):
        * bridge/jni/jni_objc.mm:
        (KJS::Bindings::dispatchJNICall):
        * bridge/jni/jni_runtime.cpp:
        (JavaArray::convertJObjectToArray):
        (JavaField::dispatchValueFromInstance):
        (JavaField::valueFromInstance):
        (JavaField::dispatchSetValueToInstance):
        (JavaArray::valueAt):
        * bridge/jni/jni_utility.h:
        * bridge/objc/objc_class.mm:
        (KJS::Bindings::ObjcClass::fallbackObject):
        * bridge/objc/objc_instance.h:
        * bridge/objc/objc_instance.mm:
        (ObjcInstance::defaultValue):
        (ObjcInstance::stringValue):
        (ObjcInstance::numberValue):
        (ObjcInstance::valueOf):
        * bridge/objc/objc_utility.h:
        * bridge/objc/objc_utility.mm:
        (KJS::Bindings::convertNSStringToString):
        (KJS::Bindings::convertObjcValueToValue):
        * bridge/qt/qt_class.cpp:
        (KJS::Bindings::QtClass::fallbackObject):
        * bridge/qt/qt_instance.cpp:
        (KJS::Bindings::QtRuntimeObjectImp::construct):
        (KJS::Bindings::QtInstance::getRuntimeObject):
        (KJS::Bindings::QtInstance::invokeDefaultMethod):
        (KJS::Bindings::QtInstance::defaultValue):
        (KJS::Bindings::QtInstance::stringValue):
        (KJS::Bindings::QtInstance::numberValue):
        (KJS::Bindings::QtInstance::valueOf):
        * bridge/qt/qt_instance.h:
        * bridge/qt/qt_runtime.cpp:
        (KJS::Bindings::convertValueToQVariant):
        (KJS::Bindings::convertQVariantToValue):
        (KJS::Bindings::QtRuntimeMetaMethod::lengthGetter):
        (KJS::Bindings::QtRuntimeMetaMethod::connectGetter):
        (KJS::Bindings::QtRuntimeMetaMethod::disconnectGetter):
        (KJS::Bindings::QtRuntimeConnectionMethod::lengthGetter):
        (KJS::Bindings::QtConnectionObject::execute):
        * bridge/runtime.cpp:
        (KJS::Bindings::Instance::createRuntimeObject):
        * bridge/runtime.h:
        (KJS::Bindings::Instance::valueOf):
        * bridge/runtime_array.cpp:
        (RuntimeArray::lengthGetter):
        * bridge/runtime_method.cpp:
        (RuntimeMethod::lengthGetter):
        * bridge/runtime_object.cpp:
        (RuntimeObjectImp::RuntimeObjectImp):
        (RuntimeObjectImp::methodGetter):
        (RuntimeObjectImp::defaultValue):
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::dropProtection):

625 626 627 628 629 630 631 632 633 634 635 636 637
2008-05-11  Robin Dunn  <robin@alldunn.com>

        Reviewed by Kevin Ollivier.

        Since wx popup menus dismiss themselves when an item is selected we need to
        call hidePopup so webkit's internal state is correct.
        
        https://bugs.webkit.org/show_bug.cgi?id=19000

        * platform/wx/PopupMenuWx.cpp:
        (WebCore::PopupMenu::OnMenuItemSelected):
        (WebCore::PopupMenu::hide):

638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653
2008-05-11  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Move some generic parsing functions into a new ParserUtilities header so that
        they can be used for non-SVG builds too.

        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * platform/text/ParserUtilities.h: Added.
        (WebCore::skipString):
        * svg/SVGParserUtilities.h:
        (WebCore::isWhitespace):
        (WebCore::skipOptionalSpaces):
        (WebCore::skipOptionalSpacesOrDelimiter):

654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680
2008-05-11  Sam Weinig  <sam@webkit.org>

        Reviewed by Dan Bernstein.

        Add scaffolding for the implementation of Access Control for Cross-site Requests. 

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * xml/AccessControlList.cpp: Added.
        (WebCore::AccessControlList::AccessControlList):
        (WebCore::AccessControlList::~AccessControlList):
        (WebCore::AccessControlList::parseAccessControlHeader):
        (WebCore::AccessControlList::checkOrigin):
        * xml/AccessControlList.h: Added.
        * xml/AccessItem.cpp: Added.
        (WebCore::AccessItem::AccessItem):
        (WebCore::AccessItem::parseAccessItem):
        (WebCore::AccessItem::matches):
        * xml/AccessItem.h: Added.
        * xml/AccessItemRule.cpp: Added.
        (WebCore::AccessItemRule::AccessItemRule):
        (WebCore::AccessItemRule::parseAccessItemRule):
        * xml/AccessItemRule.h: Added.

681 682 683 684 685 686 687
2008-05-11  Julien Chaffraix  <jchaffraix@webkit.org>

        Debug build fix.

        * loader/appcache/ApplicationCache.cpp: Include stdio.h
        as we are using printf in ApplicationCache::dump().

mitz@apple.com's avatar
mitz@apple.com committed
688 689 690 691 692 693 694 695 696 697 698 699 700 701
2008-05-10  Dan Bernstein  <mitz@apple.com>

        Reviewed by Jessica Kahn.

        - add a copy assignment operator to FontPlatformData on Mac to properly
          retain the m_font data member.

        * platform/graphics/mac/FontPlatformData.h:
        * platform/graphics/mac/FontPlatformDataMac.mm:
        (WebCore::FontPlatformData::FontPlatformData):
        (WebCore::~FontPlatformData):
        (WebCore::FontPlatformData::operator=):
        (WebCore::FontPlatformData::setFont):

702 703 704 705 706 707 708 709 710
2008-05-10  Adele Peterson  <adele@apple.com>

        Reviewed by Tim Hatcher.

        Fix crash for WebKit clients that don't set a group name for the WebView/Page.

        * page/PageGroup.cpp: (WebCore::PageGroup::PageGroup): Instead of adding the Page directly to the group,
          call the addPage method, since it does extra work initializing m_localStorage.

weinig@apple.com's avatar
weinig@apple.com committed
711 712 713 714 715 716 717 718 719 720 721 722
2008-05-09  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=18958
        NULL pointer dereference in NamedAttrMap::setNamedItem

        Test: fast/dom/NamedNodeMap-setNamedItem-crash.html

        * dom/NamedAttrMap.cpp:
        (WebCore::NamedAttrMap::setNamedItem): Null check the argument.

723 724 725 726 727 728 729
2008-05-09  Kevin McCullough  <kmccullough@apple.com>

        Build fix.

        * page/Console.cpp:
        (WebCore::Console::profile):

weinig@apple.com's avatar
weinig@apple.com committed
730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758
2008-05-09  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Mark Rowe.

        Remove the ENABLE_CROSS_DOCUMENT_MESSAGING #ifdefs.

        * Configurations/WebCore.xcconfig:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.vcproj/build-generated-files.sh:
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::customGetOwnPropertySlot):
        (WebCore::JSDOMWindow::postMessage):
        * bindings/js/JSEventCustom.cpp:
        (WebCore::toJS):
        * bindings/objc/DOMEvents.mm:
        (+[DOMEvent _wrapEvent:WebCore::]):
        * dom/Document.cpp:
        (WebCore::Document::createEvent):
        * dom/Event.cpp:
        (WebCore::Event::isMessageEvent):
        * dom/Event.h:
        * dom/MessageEvent.cpp:
        * dom/MessageEvent.h:
        * dom/MessageEvent.idl:
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::postMessageTimerFired):
        * page/DOMWindow.h:
        * page/DOMWindow.idl:

weinig@apple.com's avatar
weinig@apple.com committed
759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775
2008-05-09  Adam Barth  <abarth-webkit@adambarth.com>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=18771

        Make postMessage generate an event on the window instead of the
        document.

        Test: http/tests/messaging/cross-domain-message-event-dispatch.html

        * dom/EventTargetNode.cpp:
        (WebCore::EventTargetNode::dispatchWindowEvent):
        * dom/EventTargetNode.h:
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::postMessageTimerFired):

776 777 778 779 780 781 782 783 784 785
2008-05-09  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon.

        Replaced all instances of qDebug() with LOG(Media, ...)
        in MediaPlayerPrivatePhonon.

        * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
        (WebCore::MediaPlayerPrivate::updateStates):

786 787 788 789 790 791 792 793
2008-05-09  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon

        Fix the Qt/Mac build.

        * platform/qt/FileSystemQt.cpp:

794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817
2008-05-08  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Rename the XMLHttpRequestState enum values to match the spec.

        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::responseXML):
        (WebCore::XMLHttpRequest::XMLHttpRequest):
        (WebCore::XMLHttpRequest::callReadyStateChangeListener):
        (WebCore::XMLHttpRequest::open):
        (WebCore::XMLHttpRequest::send):
        (WebCore::XMLHttpRequest::abort):
        (WebCore::XMLHttpRequest::setRequestHeader):
        (WebCore::XMLHttpRequest::getAllResponseHeaders):
        (WebCore::XMLHttpRequest::getResponseHeader):
        (WebCore::XMLHttpRequest::status):
        (WebCore::XMLHttpRequest::statusText):
        (WebCore::XMLHttpRequest::processSyncLoadResults):
        (WebCore::XMLHttpRequest::didFinishLoading):
        (WebCore::XMLHttpRequest::didReceiveData):
        * xml/XMLHttpRequest.h:
        (WebCore::):

mitz@apple.com's avatar
mitz@apple.com committed
818 819 820 821 822 823 824 825 826 827 828 829 830 831
2008-05-08  Dan Bernstein  <mitz@apple.com>

        Reviewed by Mark Rowe.

        - fix https://bugs.webkit.org/show_bug.cgi?id=18818
          <rdar://problem/5901544> REGRESSION (3.1.1-TOT): Character order (float:left ordered after the first letter)

        Test: fast/css/first-letter-float-after-float.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::updateFirstLetter): Changed to add the first
        letter container right before the rest of the text it is taken from,
        instead of at the beginning of the block.

832 833 834 835 836 837 838 839 840 841
2008-05-08  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/5921046> AX: list box options have wrong AXPosition

        * page/AccessibilityObject.cpp:
        (WebCore::AccessibilityObject::documentFrameView):
        * page/AccessibilityObject.h:

842 843 844 845 846 847 848 849 850 851 852 853 854
2008-05-08  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Eric.

        Bug 18916: make_names.pl --factory needs to support custom c++ guard

        Add --guardFactoryWith to handle the cpp guard around generated factories.

        * DerivedSources.make: Set the guardFactoryWith variable for SVG factory.
        * GNUmakefile.am: Ditto.
        * WebCore.pro: Ditto.
        * dom/make_names.pl: Add guardFactoryWith option.

855 856 857 858 859 860 861 862 863 864 865 866 867 868
2008-05-08  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Adam Roben.

        wx & Gtk build fix.

        Should also fix the cURL backend for the Windows port.

        * WebCore.vcproj/WebCore.vcproj: Add FormDataStreamCurl information.
        * platform/network/curl/FormDataStreamCurl.h: Include stdio.h which
        fixes the build on some machine.

        * webcore-wx.bkl: Add FormDataStreamCurl.cpp.

869 870 871 872 873 874 875 876 877 878 879
2008-05-08  Timothy Hatcher  <timothy@apple.com>

        Fixes the bug where the Web Inspector could not
        find any localization strings.

        Reviewed by Mark Rowe.

        * WebCore.xcodeproj/project.pbxproj: Add the localizedStrings.js
        file to the WebCore Copy Resources phase. Also removes an idl from
        the Copy Resources phase.

mitz@apple.com's avatar
mitz@apple.com committed
880 881 882 883 884 885 886 887 888 889
2008-05-08  Dan Bernstein  <mitz@apple.com>

        Reviewed by Adam Roben.

        - fix <rdar://problem/5697957> "No recent searches" label in a narrow search field's history popup is truncated

        * platform/win/PopupMenuWin.cpp:
        (WebCore::PopupMenu::calculatePositionAndSize): Changed to use a bold
        font for measuring labels.

mitz@apple.com's avatar
mitz@apple.com committed
890 891 892 893 894 895 896 897 898 899
2008-05-08  Dan Bernstein  <mitz@apple.com>

        Reviewed by Geoffrey Garen.

        - cross-platform fix for http://bugs.webkit.org/show_bug.cgi?id=17590 
          ASSERTION FAILED: subject in jsRegExpExecute()

        * page/Frame.cpp:
        (WebCore::Frame::matchLabelsAgainstElement):

900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922
2008-05-08  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Simon.

        Simple ImageBuffer::image implementation.

        In contrast to cg and cairo we do not use a special BitmapImage because
        the ownership of the FrameData inside the BitmapImage is a bit backward
        (actually owned by the ImageDecoderQt...). Further work is needed for image
        and pixmap handling in the qt port...

        * WebCore.pro:
        * platform/graphics/ImageBuffer.h:
        * platform/graphics/qt/ImageBufferQt.cpp:
        (WebCore::ImageBuffer::image):
        * platform/graphics/qt/ImageQt.cpp:
        * platform/graphics/qt/StillImageQt.cpp: Added.
        (WebCore::StillImage::StillImage):
        (WebCore::StillImage::size):
        (WebCore::StillImage::getPixmap):
        (WebCore::StillImage::draw):
        * platform/graphics/qt/StillImageQt.h: Added.

923 924 925 926 927 928 929 930
2008-05-08  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Simon.

        Update the WebKit.qrc of the inspector to be functional again

        * page/inspector/WebKit.qrc:

931 932 933 934 935 936 937 938
2008-05-08  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon

        Fix the Qt/Mac build.

        * platform/FileSystem.h:

939 940 941 942 943 944 945 946 947 948 949 950
2008-05-08  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Simon.

        Use native Windows library handling (instead of QLibrary) 
        for Qt/Win32's PlatformModule.

        * platform/FileSystem.h:
        (WebCore::PlatformModuleVersion::PlatformModuleVersion):
        * platform/qt/FileSystemQt.cpp:
        (WebCore::unloadModule):

951 952 953 954 955 956 957 958 959
2008-05-08  Simon Hausmann  <hausmann@webkit.org>

        Reviewed and found by Holger.

        Include .css in the list of extensions for text/css. Fixes
        fast/loader/local-css-allowed-in-strict-mode.html.

        * platform/qt/MIMETypeRegistryQt.cpp:

960 961 962 963 964 965 966
2008-05-08  Simon Hausmann  <hausmann@webkit.org>

        Fix the Qt and Wx build when compiling without offline app support.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::canCachePage):

967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982
2008-05-07  Sam Weinig  <sam@webkit.org>

        Reviewed by Adele Peterson

        Update MessageEvent to match the latest version of the HTML5 spec,
        adding the lastEventId attribute.

        * dom/MessageEvent.cpp:
        (WebCore::MessageEvent::MessageEvent):
        (WebCore::MessageEvent::initMessageEvent):
        * dom/MessageEvent.h:
        (WebCore::MessageEvent::lastEventId):
        * dom/MessageEvent.idl:
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::postMessage):

983 984 985 986 987 988 989 990 991 992 993 994 995 996 997
2008-05-07  Stephanie Lewis <slewis@apple.com>

        Reviewed by Maciej.

        remove non-functioning code.  If onunload should be fired from these nodes then
        a WindowEventListener needs to be set.  However, Firefox and IE also do not
        fire onunload events for these cases.

        Test: fast/events/onunload-not-on-body.html 
        
        * html/HTMLFrameElementBase.cpp:
        (WebCore::HTMLFrameElementBase::parseMappedAttribute):
        * html/HTMLObjectElement.cpp
        (WebCore::HTMLObjectElement::parseMappedAttribute):

mitz@apple.com's avatar
mitz@apple.com committed
998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014
2008-05-07  Dan Bernstein  <mitz@apple.com>

        Reviewed by John Sullivan.

        - fix https://bugs.webkit.org/show_bug.cgi?id=18909
          <rdar://problem/5914165> REGRESSION (r31872-r31878): Viewed photos not closing completely at indycar.com

        Test: fast/dynamic/positioned-movement-with-positioned-children.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::layoutOnlyPositionedObjects): Cover the case of
        a positioned object that has only moved and has only positioned children
        that have changed.
        * rendering/RenderObject.h:
        (WebCore::RenderObject::needsPositionedMovementLayout): Added this
        accessor.

1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034
2008-05-07  Anders Carlsson  <andersca@apple.com>

        Reviewed by John.

        When no document loaders are associated with an application cache group,
        release the reference to the newest cache group. This prevents reference cycles.
        
        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::ApplicationCacheGroup):
        (WebCore::ApplicationCacheGroup::documentLoaderDestroyed):
        (WebCore::ApplicationCacheGroup::cacheDestroyed):
        * loader/appcache/ApplicationCacheGroup.h:
        
        * loader/appcache/ApplicationCacheStorage.cpp:
        (WebCore::ApplicationCacheStorage::cacheGroupForURL):
        Return early if the datbase wasn't open.
        
        (WebCore::ApplicationCacheStorage::loadCache):
        Add error.

1035 1036 1037 1038 1039 1040 1041 1042 1043
2008-05-07  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Don't put pages with an application cache in the BF cache.
        
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::canCachePage):

justin.garcia@apple.com's avatar
justin.garcia@apple.com committed
1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061
2008-05-07  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by John Sullivan.

        <rdar://problem/5666354> Crashes in Mail at WebCore::RemoveNodeCommand::doApply
        
        When a single tab or series of tabs was copied, we weren't putting them into a 
        tab span.  On Paste, we would be given a text node with a single tab or series
        of tabs in it, and we would crash when inserting it at the start of a block
        (where that kind of text becomes completely unrendered).

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds): Clean
        up correctly and early return if we removed everything that was inserted.
        * editing/markup.cpp:
        (WebCore::createMarkup):  Include the tab span when the only thing copied
        was a tab or a series of tabs.

1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073
2008-05-07  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Adam Roben.

        wx & Gtk build fix.

        * platform/network/curl/FormDataStreamCurl.cpp: Added stdint.h include. We need to define
        __STDC_LIMIT_MACROS to have SIZE_MAX exported.
        * platform/network/curl/FormDataStreamCurl.h: Removed cstdint include (replaced by stdint.h)
        as it is not present on the build bots.
        * plugins/gtk/PluginDatabaseGtk.cpp: Added missing #endif.

ddkilzer@apple.com's avatar
ddkilzer@apple.com committed
1074 1075 1076 1077
2008-05-07  David Kilzer  <ddkilzer@apple.com>

        Bug 18900: Password field has focus but can't type text (i.rememberthemilk.com)
        <https://bugs.webkit.org/show_bug.cgi?id=18900>
1078
        <rdar://problem/5912383>
ddkilzer@apple.com's avatar
ddkilzer@apple.com committed
1079 1080 1081 1082 1083 1084 1085 1086 1087 1088

        Original patch by Aaron Golden and Tim Omernick.  Reviewed by Adele.

        Test: fast/forms/textfield-to-password-on-focus.html

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::setInputType): If the current node has
        focus, call updateFocusAppearance() to make sure its state is correct
        after changing its type.

1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108
2008-05-07  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Alice Liu

        <rdar://problem/4867889> REGRESSION: "Choose File.." buttons are exposed as AXGroup instead of AXButton

        * page/AccessibilityObject.h:
        (WebCore::AccessibilityObject::isFileUploadButton):
        * page/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::isFileUploadButton):
        (WebCore::AccessibilityRenderObject::actionElement):
        (WebCore::AccessibilityRenderObject::textUnderElement):
        (WebCore::AccessibilityRenderObject::stringValue):
        (WebCore::AccessibilityRenderObject::roleValue):
        * page/AccessibilityRenderObject.h:
        * rendering/RenderFileUploadControl.cpp:
        (WebCore::RenderFileUploadControl::buttonValue):
        (WebCore::RenderFileUploadControl::fileTextValue):
        * rendering/RenderFileUploadControl.h:

1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134
2008-05-07  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Eric.

        Bug 17971: [Curl] FormData processing should be moved to its own class

        Move FormData treatment into FormDataStream. The aim is to have FormDataStream behave like a stream that cURL
        could manipulate.

        First step into having complete file uploading facility in cURL.

        No test case as it is only code refactoring.

        * GNUmakefile.am: Add FormDataStreamCurl.cpp
        * platform/network/ResourceHandleInternal.h: Move code to FormStreamDataCurl.h
        (WebCore::ResourceHandleInternal::ResourceHandleInternal):
        * platform/network/curl/FormDataStreamCurl.cpp: Added.
        (WebCore::FormDataStream::~FormDataStream):
        (WebCore::FormDataStream::read):
        * platform/network/curl/FormDataStreamCurl.h: Added.
        (WebCore::FormDataStream::FormDataStream):
        * platform/network/curl/ResourceHandleCurl.cpp:
        (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
        * platform/network/curl/ResourceHandleManager.cpp:
        (WebCore::readCallback): Move code to FormDataStreamCurl.cpp

1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146
2008-05-07  Adam Treat  <treat@kde.org>

        Reviewed by Simon.

        https://bugs.webkit.org/show_bug.cgi?id=18898

        Fixed wrong transform being used for creating the pixmap for a new
        transparency layer. This fixes the popup menus on dell.com.

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::beginTransparencyLayer):

1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162
2008-05-07  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Simon.

        Share the plug-in directories between Gtk and Qt/X11 port.

        * platform/qt/FileSystemQt.cpp:
        (WebCore::homeDirectoryPath): Implement it for Qt.
        * plugins/PluginDatabase.cpp:
        (WebCore::addMozillaPluginDirectories): Shared code.
        (WebCore::PluginDatabase::defaultPluginDirectories):
        (WebCore::PluginDatabase::isPreferredPluginDirectory): Shared code.
        * plugins/gtk/PluginDatabaseGtk.cpp:
        (WebCore::PluginDatabase::isPreferredPluginDirectory): Refactored.
        * plugins/qt/PluginDatabaseQt.cpp: Refactored.

1163 1164 1165 1166 1167 1168 1169 1170 1171 1172
2008-05-07  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon

        Fix build issues on Mac and refeactor the .pro file a bit.

        * WebCore.pro:
        * platform/qt/TemporaryLinkStubs.cpp:
        (PluginPackage::fetchInfo):

1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184
2008-05-07  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon

        Draw scrollview corners (between scrollbars) using the Qt style.

        https://bugs.webkit.org/show_bug.cgi?id=18894

        * platform/qt/ScrollViewQt.cpp:
        (WebCore::drawScrollbarCorner):
        (WebCore::ScrollView::paint):

1185 1186 1187 1188 1189 1190 1191
2008-05-07  Simon Hausmann  <hausmann@webkit.org>

        Fix the Qt build, added AccessibilityListBox and ListBoxOption.cpp to
        the build.

        * WebCore.pro:

1192 1193 1194 1195 1196 1197 1198 1199 1200
2008-05-07  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Rubber-stamped by Holger.

        Fix building without storage support.

        * page/PageGroup.cpp:
        (WebCore::PageGroup::closeLocalStorage): proper #if

1201 1202 1203 1204 1205 1206 1207 1208 1209
2008-05-07  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Rubber-stamped by Oliver Hunt.

        Fix building without accessibility.

        * page/AXObjectCache.cpp:
        (WebCore::AXObjectCache::selectedChildrenChanged): proper #if

mitz@apple.com's avatar
mitz@apple.com committed
1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220
2008-05-06  Dan Bernstein  <mitz@apple.com>

        Reviewed by Darin Adler.

        - fix <rdar://problem/5914544> Crash in layoutInlineChildren()

        Test: fast/block/float/float-on-zero-height-line.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::markLinesDirtyInVerticalRange):

alice.liu@apple.com's avatar
alice.liu@apple.com committed
1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243
2008-05-06  Alice Liu  <alice.liu@apple.com>

        Reviewed by Adele Peterson and John Sullivan.

        changes needed to build on Windows after r32911 and r32927

        * WebCore.vcproj/WebCore.vcproj:
        * page/AXObjectCache.cpp:
        (WebCore::AXObjectCache::selectedChildrenChanged):
        * page/AccessibilityObject.h:
        (WebCore::AccessibilityObject::document):
        (WebCore::AccessibilityObject::topDocumentFrameView):
        (WebCore::AccessibilityObject::documentFrameView):
        * page/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::document):
        (WebCore::AccessibilityRenderObject::topDocumentFrameView):
        (WebCore::AccessibilityRenderObject::documentFrameView):
        * page/AccessibilityRenderObject.h:
        * page/mac/AXObjectCacheMac.mm:
        * page/mac/AccessibilityObjectWrapper.mm:
        (-[AccessibilityObjectWrapper position]):
        (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267
2008-05-06  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig

        Fix a few bugs with the final sync'ing of LocalStorageAreas when the thread is shut down.
        1 - A sync task actually needs to be scheduled for each LocalStorageArea when the shut down occurs.
        2 - Pending sync timers all need to be cancelled.

        * storage/LocalStorage.cpp:
        (WebCore::LocalStorage::storageArea):
        (WebCore::LocalStorage::close): Tell each LocalStorageArea to schedule it's final sync before scheduling
          thread termination.
        * storage/LocalStorage.h:  Change the map to be of LocalStorageAreas instead of StorageAreas

        * storage/LocalStorageArea.cpp:
        (WebCore::LocalStorageArea::LocalStorageArea):
        (WebCore::LocalStorageArea::~LocalStorageArea): ASSERT the timer has been cancelled, but make SURE it is
          in release builds.
        (WebCore::LocalStorageArea::scheduleFinalSync): Cancel the sync timer, schedule the final sync, and set the
          "final sync scheduled" flag
        (WebCore::LocalStorageArea::scheduleItemForSync): ASSERT that the final sync hasn't already been scheduled
        (WebCore::LocalStorageArea::scheduleClear): Ditto
        * storage/LocalStorageArea.h:

1268 1269 1270 1271 1272 1273
2008-05-06  Kevin Ollivier  <kevino@theolliviers.com>

        wx build fix. Adding files added in  r32925 to the bakefiles.

        * WebCoreSources.bkl:

1274 1275 1276 1277 1278 1279 1280
2008-05-06  Alp Toker  <alp@nuanti.com>

        GTK+ build fix. Add empty stub to keep non-accessible ports building.

        * page/AXObjectCache.h:
        (WebCore::AXObjectCache::selectedChildrenChanged):

1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325
2008-05-06  Beth Dakin  <bdakin@apple.com>

        Reviewed by Darin.

        Fix for <rdar://problem/5907916> Implement 'aria-labeledby' and 
        'aria-describedby' attributes.

        * html/HTMLAttributeNames.in: Added new attributes. Added both the 
        British spelling (since that is what is specified in the spec), and 
        the American spelling (since the bug filer and I are two Americans 
        who keep spelling it the American way by accident). 
        * page/AccessibilityObject.cpp: Added empty wrappers. These 
        functions can't do anything meaningful without a renderer.
        (WebCore::AccessibilityObject::ariaAccessiblityName):
        (WebCore::AccessibilityObject::ariaLabeledByAttribute):
        (WebCore::AccessibilityObject::ariaDescribedByAttribute):
        * page/AccessibilityObject.h:

        Here is where the real work is done.
        * page/AccessibilityRenderObject.h:
        * page/AccessibilityRenderObject.cpp:
        (WebCore::accessibleNameForNode): Takes a node and finds its 
        contribution to the accessible name, as defined by the Mozilla ARIA 
        Implementer's Guide. 
        (WebCore::AccessibilityRenderObject::ariaAccessiblityName): Takes a 
        string of space-separated IDs, fetches the corresponding element 
        for each ID, and concatenates an accessible name based on the 
        elements.
        (WebCore::AccessibilityRenderObject::ariaLabeledByAttribute): 
        Retrieve the labeledby attribute and send its contents to 
        ariaAccessibilityName().
        (WebCore::AccessibilityRenderObject::title): Return the ARIA 
        labeledby value if one exists.
        (WebCore::AccessibilityRenderObject::ariaDescribedByAttribute): 
        Retrieve the describedby attribute and send its contents to 
        ariaAccessibilityName().
        (WebCore::AccessibilityRenderObject::accessibilityDescription): 
        Return the ARIA describedby attribute if one exists. 

        These are two bugs I spotted. 
        (WebCore::AccessibilityRenderObject::accessibilityIsIgnored): Don't 
        ignore anything with an ARIA role.
        (WebCore::AccessibilityRenderObject::roleValue): Button tags maps 
        to ButtonRole.

1326 1327 1328 1329
2008-05-06  Anders Carlsson  <andersca@apple.com>

        Reviewed by Brady.

andersca@apple.com's avatar
andersca@apple.com committed
1330
        Support reading back app caches from the database.
1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368
    
        * loader/appcache/ApplicationCache.cpp:
        (WebCore::ApplicationCache::ApplicationCache):
        Initialize m_storageID to 0.
        
        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::cacheDestroyed):
        If the cache being destroyed is not the newest cache, it should no longer be 
        stored in the database. Remove it.
        
        (WebCore::ApplicationCacheGroup::setNewestCache):
        Don't store the cache here.
        
        (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
        Store it here instead.
        
        * loader/appcache/ApplicationCacheStorage.cpp:
        (WebCore::ApplicationCacheStorage::loadCacheGroup):
        New method that loads a cache group with a given manifest URL (or returns 0 if the load fails).
        
        (WebCore::ApplicationCacheStorage::findOrCreateCacheGroup):
        Search for the group in the database.
        
        (WebCore::ApplicationCacheStorage::loadManifestHostHashes):
        New method that loads the host hashes from the database.
        
        (WebCore::ApplicationCacheStorage::cacheGroupForURL):
        Search in the database for a cache that contains the resource.
        
        (WebCore::ApplicationCacheStorage::loadCache):
        New method that loads a cache with a given ID.
        
        (WebCore::ApplicationCacheStorage::remove):
        New method that removes a cache.
        
        * loader/appcache/ApplicationCacheStorage.h:
        Add definitions.

1369 1370 1371 1372 1373 1374 1375 1376 1377
2008-05-06  Alp Toker  <alp@nuanti.com>

        Partial GTK+ build fix. Add files from r32925 to the build and replace
        'nil' return with 0.

        * GNUmakefile.am:
        * page/AccessibilityListBoxOption.cpp:
        (WebCore::AccessibilityListBoxOption::parentObject):

1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425
2008-05-06  Brady Eidson  <beidson@apple.com>

        Reviewed by Anders

        Make LocalStorage persistent using a SQLite database.

        There's a few things going on here.  Whenever an item is changed, we add it to a set of
        "items to be sync'ed."  Instead of immediately scheduling the sync'ing on the background
        thread, we set a "sync timer" instead.  This is to shield against a series of rapid changes
        to avoid thread churn.

        When the sync timer fires, we move the "items to be sync'ed" set to a background thread set
        and schedule the sync task which is where the items are actually committed to disk.

        Current design for reading items back in from disk is to be as aggressive as possible.
        When a page first accesses it's LocalStorage area, we begin to import all items in from disk so
        they are immediately available.  A future enhancement will be to being this pre-fetching the
        moment we start loading a page when we know that page has LocalStorage.

        * storage/LocalStorageArea.cpp:
        (WebCore::LocalStorageArea::LocalStorageArea):
        (WebCore::LocalStorageArea::length): Return the length, or wait for the import to complete then return it.
        (WebCore::LocalStorageArea::key): Return the key, or wait for the import to complete then return it.
        (WebCore::LocalStorageArea::getItem): Return the item, or wait for the import to complete then return it.
        (WebCore::LocalStorageArea::setItem): Set the item, or hold the import lock and set it.  The second case is
          because if the item is set while the import is still in progress, the new value should override whatever
          the imported value is.
        (WebCore::LocalStorageArea::removeItem): Remove the item, or hold the import lock and remove it.  See the 
          explanation for setItem()
        (WebCore::LocalStorageArea::contains): Return whether or not the item is contained.  Do the same dance with
          the import flag, import lock, and import condition that the above methods do.

        (WebCore::LocalStorageArea::itemChanged): Schedule the item for sync'ing
        (WebCore::LocalStorageArea::itemRemoved): Schedule the removal of the item for sync'ing
        (WebCore::LocalStorageArea::areaCleared): Schedule the clear for sync'ing, and clear all previously 
          scheduled items.

        (WebCore::LocalStorageArea::scheduleItemForSync): Add an item to the sync set.
        (WebCore::LocalStorageArea::scheduleClear): Set a bool flag denoting "All items removed."  If any
          items are later set before the actual removal takes place, they will be written *after* the removal.
        (WebCore::LocalStorageArea::syncTimerFired): Move the current sync-set to the background thread sync set, then 
          schedule a sync task.  Also transfer the "items cleared" flag to the "background thread items cleared" flag
        (WebCore::LocalStorageArea::performImport): Import all items from disk, then signal the import complete.
        (WebCore::LocalStorageArea::markImported): Set the imported flag and signal the import complete
        (WebCore::LocalStorageArea::performSync): If the clear flag is set then drop all items.  Then update or delete 
          each item waiting to be sync'ed
        * storage/LocalStorageArea.h:

1426 1427 1428 1429 1430 1431 1432
2008-05-06  Brady Eidson  <beidson@apple.com>

        Rubberstamped by Mitz Pettel RTL

        * storage/LocalStorage.cpp:
        (WebCore::LocalStorage::fullDatabaseFilename): Filename extensions for localstorage = all lowercase

1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455
2008-05-06  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin, Sam Weinig, and Anders

        Preparation for upcoming work making LocalStorage persistent.

        The final step before code that actually does storage and retrieval of LocalStorage items.

        The LocalStorage set is responsible for controlling the path and filenames that individual
        LocalStorageAreas will use for their persistent store.  This adds the ability to return that
        filename.

        Also, add the scheduling methods that LocalStorageArea will use for importing and syncing 
        it's persistent items.

        * storage/LocalStorage.cpp:
        (WebCore::LocalStorage::storageArea):  Add some comments re: the future direction of this
          method once we actually do quota tracking.
        (WebCore::LocalStorage::fullDatabaseFilename):
        (WebCore::LocalStorage::scheduleImport):
        (WebCore::LocalStorage::scheduleSync):
        * storage/LocalStorage.h:

1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524
2008-05-06  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Beth Dakin.

        rdar://problem/5408464> REGRESSION: Unable to use Voiceover on combo boxes (disneyjobs.com)

        * WebCore.xcodeproj/project.pbxproj:
        * html/HTMLOptGroupElement.cpp:
        (WebCore::HTMLOptGroupElement::ownerSelectElement):
        (WebCore::HTMLOptGroupElement::accessKeyAction):
        * html/HTMLOptGroupElement.h:
        * html/HTMLOptionElement.cpp:
        (WebCore::HTMLOptionElement::accessKeyAction):
        (WebCore::HTMLOptionElement::index):
        (WebCore::HTMLOptionElement::setSelected):
        (WebCore::HTMLOptionElement::childrenChanged):
        (WebCore::HTMLOptionElement::ownerSelectElement):
        (WebCore::HTMLOptionElement::insertedIntoDocument):
        * html/HTMLOptionElement.h:
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::childrenChanged):
        (WebCore::HTMLSelectElement::accessKeySetSelectedIndex):
        * html/HTMLSelectElement.h:
        * page/AXObjectCache.cpp:
        (WebCore::AXObjectCache::get):
        * page/AccessibilityListBox.cpp: Added.
        (WebCore::AccessibilityListBox::AccessibilityListBox):
        (WebCore::AccessibilityListBox::~AccessibilityListBox):
        (WebCore::AccessibilityListBox::create):
        (WebCore::AccessibilityListBox::addChildren):
        (WebCore::AccessibilityListBox::selectedChildren):
        (WebCore::AccessibilityListBox::visibleChildren):
        (WebCore::AccessibilityListBox::listBoxOptionAccessibilityObject):
        (WebCore::AccessibilityListBox::doAccessibilityHitTest):
        * page/AccessibilityListBox.h: Added.
        (WebCore::AccessibilityListBox::accessibilityShouldUseUniqueId):
        (WebCore::AccessibilityListBox::isListBox):
        (WebCore::AccessibilityListBox::canSetFocusAttribute):
        (WebCore::AccessibilityListBox::roleValue):
        (WebCore::AccessibilityListBox::accessibilityIsIgnored):
        * page/AccessibilityListBoxOption.cpp: Added.
        (WebCore::AccessibilityListBoxOption::AccessibilityListBoxOption):
        (WebCore::AccessibilityListBoxOption::~AccessibilityListBoxOption):
        (WebCore::AccessibilityListBoxOption::create):
        (WebCore::AccessibilityListBoxOption::isEnabled):
        (WebCore::AccessibilityListBoxOption::isSelected):
        (WebCore::AccessibilityListBoxOption::elementRect):
        (WebCore::AccessibilityListBoxOption::title):
        (WebCore::AccessibilityListBoxOption::size):
        (WebCore::AccessibilityListBoxOption::actionElement):
        (WebCore::AccessibilityListBoxOption::parentObject):
        (WebCore::AccessibilityListBoxOption::listBoxOptionParentNode):
        (WebCore::AccessibilityListBoxOption::listBoxOptionIndex):
        * page/AccessibilityListBoxOption.h: Added.
        (WebCore::AccessibilityListBoxOption::setHTMLElement):
        (WebCore::AccessibilityListBoxOption::roleValue):
        (WebCore::AccessibilityListBoxOption::accessibilityIsIgnored):
        (WebCore::AccessibilityListBoxOption::isListBoxOption):
        * page/AccessibilityObject.h:
        (WebCore::AccessibilityObject::isListBox):
        * page/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
        * page/mac/AccessibilityObjectWrapper.mm:
        (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
        (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::selectionChanged):
        * rendering/RenderListBox.h:

1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535
2008-05-06  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Beth Dakin.

         <rdar://problem/5455287> AXWebArea should include AXURL

        * page/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::url):
        * page/mac/AccessibilityObjectWrapper.mm:
        (-[AccessibilityObjectWrapper accessibilityAttributeNames]):

1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546
2008-05-06  Alice Liu  <alice.liu@apple.com>

        Rubber-stamped by Beth
        
        stab-in-the-dark attempt at fixing non-mac builds.

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCoreSources.bkl:

1547 1548 1549 1550 1551 1552 1553 1554 1555
2008-05-06  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Only use the toplevel application cache when loading subframes.

        * loader/MainResourceLoader.cpp:
        (WebCore::MainResourceLoader::load):

weinig@apple.com's avatar
weinig@apple.com committed
1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579
2008-05-06  Adam Barth  <abarth-webkit@adambarth.com>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=18725
        Implement asynchronous postMessage.
        MessageEvent no longer bubbles as per r1237 in the HTML 5 working draft.

        Collin Jackson <collinj-webkit@collinjackson.com> also contributed to this patch.

        Test: http/tests/security/postMessage/delivery-order.html

        * dom/MessageEvent.cpp:
        (WebCore::MessageEvent::MessageEvent):
        * page/DOMWindow.cpp:
        (WebCore::PostMessageTimer::PostMessageTimer):
        (WebCore::PostMessageTimer::event):
        (WebCore::PostMessageTimer::targetOrigin):
        (WebCore::PostMessageTimer::fired):
        (WebCore::DOMWindow::postMessage):
        (WebCore::DOMWindow::postMessageTimerFired):
        * page/DOMWindow.h:
        * page/DOMWindow.idl:
        
1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639
2008-05-06  Anders Carlsson  <andersca@apple.com>

        Reviewed by Brady.

        Store cache to the database.

        * loader/appcache/ApplicationCache.cpp:
        (WebCore::ApplicationCache::addResource):
        If the cache has been saved to disk, save the resource as well.
        
        * loader/appcache/ApplicationCache.h:
        (WebCore::ApplicationCache::onlineWhitelist):
        New method which returns the online whitelist.

        (WebCore::ApplicationCache::setStorageId):
        (WebCore::ApplicationCache::storageId):
        Setter/getter for the application cache storage ID.

        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
        Save the cache/group to disk.
        
        * loader/appcache/ApplicationCacheGroup.h:
        (WebCore::ApplicationCacheGroup::setStorageID):
        (WebCore::ApplicationCacheGroup::storageID):
        Setter/getter for the application cache group storage ID.
        
        * loader/appcache/ApplicationCacheResource.cpp:
        (WebCore::ApplicationCacheResource::addType):
        We can't add a new type if the resource has been saved to disk.
        
        * loader/appcache/ApplicationCacheResource.h:
        (WebCore::ApplicationCacheResource::setStorageID):
        (WebCore::ApplicationCacheResource::storageID):
        Setter/getter for the application cache resource storage ID.

        * loader/appcache/ApplicationCacheStorage.cpp:
        * loader/appcache/ApplicationCacheStorage.cpp:
        (WebCore::ApplicationCacheStorage::executeSQLCommand):
        New method for executing SQL and logging any errors.
        
        (WebCore::ApplicationCacheStorage::openDatabase):
        Create new tables.
        
        (WebCore::ApplicationCacheStorage::executeStatement):
        New method for executing an SQL statement and logging any errors.
        
        (WebCore::ApplicationCacheStorage::store):
        New methods for storing a cache group, cache and cache resource to the store.

        (WebCore::ApplicationCacheStorage::storeNewestCache):
        New method which stores the newest cache and updates the newest cache field in the cache group.
        
        * loader/appcache/ApplicationCacheStorage.h:
        Add new methods.
        
        * platform/sql/SQLiteStatement.h:
        (WebCore::SQLiteStatement::query):
        Getter for the SQL query.

1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709
2008-05-06  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler

        Preparation for upcoming work making LocalStorage persistent.

        Writing persistent values for LocalStorage will take place on a background thread.
        Here is that background thread, as well as most of the hooks that will be utilized to
        make the whole song and dance work.

        The thread itself is very simple and MessageQueue based.  LocalStorageTasks are what 
        mark the work that needs to be done and come in 5 flavors:  Import and Sync a LocalStorage set,
        Import and Sync a LocalStorageArea, and terminate the thread.

        This patch accomplished 2 things:
        
        1 - Each PageGroup has its own LocalStorage set.  Upon its creation its LocalStorageThread is 
            created and started.

        2 - At application shutdown, each thread is synchronously terminated.

        What happens between steps 1 and 2 will come later.

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:

        * storage/LocalStorage.cpp: Add some threading ASSERTs to make it clear which thread each
          method is meant to be called from.
        (WebCore::LocalStorage::LocalStorage):
        (WebCore::LocalStorage::storageArea):
        (WebCore::LocalStorage::performImport): Placeholder for importing known origins and quotas
        (WebCore::LocalStorage::performSync): Placeholder for writing out updated origins and quotas
        (WebCore::LocalStorage::close): Synchronously terminate the thread.
        * storage/LocalStorage.h:

        * storage/LocalStorageArea.cpp: Add some threading ASSERTs to make it clear which thread each
          method is meant to be called from.
        (WebCore::LocalStorageArea::itemChanged):
        (WebCore::LocalStorageArea::itemRemoved):
        (WebCore::LocalStorageArea::areaCleared):
        (WebCore::LocalStorageArea::dispatchStorageEvent):
        (WebCore::LocalStorageArea::performImport): Placeholder for importing all items for this 
          LocalStorageArea to prime the page before the items are needed
        (WebCore::LocalStorageArea::performSync): Placeholder for writing out dirty items to disk
        * storage/LocalStorageArea.h:

        * storage/LocalStorageTask.cpp: Added.
        (WebCore::LocalStorageTask::LocalStorageTask):
        (WebCore::LocalStorageTask::performTask):
        * storage/LocalStorageTask.h: Added.
        (WebCore::LocalStorageTask::):
        (WebCore::LocalStorageTask::createImport):
        (WebCore::LocalStorageTask::createSync):
        (WebCore::LocalStorageTask::createTerminate):

        * storage/LocalStorageThread.cpp: Added.
        (WebCore::LocalStorageThread::create):
        (WebCore::LocalStorageThread::LocalStorageThread):
        (WebCore::LocalStorageThread::start):
        (WebCore::LocalStorageThread::localStorageThreadStart):
        (WebCore::LocalStorageThread::localStorageThread):
        (WebCore::LocalStorageThread::scheduleImport):
        (WebCore::LocalStorageThread::scheduleSync):
        (WebCore::LocalStorageThread::terminate): 
        (WebCore::LocalStorageThread::performTerminate):
        * storage/LocalStorageThread.h: Added.

1710 1711 1712 1713 1714 1715 1716 1717 1718
2008-05-06  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.

        Add NPN_PopUpContextMenu.
        
        * bridge/npapi.h:
        * plugins/npfunctions.h:

1719 1720 1721 1722 1723 1724
2008-05-06  Alp Toker  <alp@nuanti.com>

        GTK+ build fix. Add file from r32911 to the build.

        * GNUmakefile.am:

1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735
2008-05-06  Gwenole Beauchesne  <gbeauchesne@splitted-desktop.org>

        Reviewed by Alp Toker.

        http://bugs.webkit.org/show_bug.cgi?id=18906
        [GTK] Fix varargs terminator in g_build_filename()

        * plugins/gtk/PluginDatabaseGtk.cpp:
        (WebCore::PluginDatabase::isPreferredPluginDirectory): Fix varargs
        terminator.

1736 1737 1738 1739 1740 1741
2008-05-06  Kevin McCullough  <kmccullough@apple.com>

        - Forgot to update localized Strings from previous checkin.

        * English.lproj/localizedStrings.js:

1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952 1953 1954 1955 1956 1957 1958 1959 1960 1961 1962 1963 1964 1965 1966 1967 1968 1969 1970 1971 1972 1973 1974 1975 1976 1977 1978 1979 1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990 1991 1992 1993
2008-05-06  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Beth Dakin

        <rdar://problem/5408464> REGRESSION: Unable to use Voiceover on combo boxes (disneyjobs.com)
        <rdar://problem/5895634> AX: AccessibilityObjectWrapper is being leaked all over the place
        <rdar://problem/5893907> CrashTracer: [REGRESSION] 44 crashes in Safari at com.apple.WebCore: WebCore::AccessibilityObject::clearChildren + 9
        
        Initial prep work to support accessibility objects that do not have renderers. 

        * WebCore.xcodeproj/project.pbxproj:
        * page/AXObjectCache.cpp:
        (WebCore::AXObjectCache::~AXObjectCache):
        (WebCore::AXObjectCache::get):
        (WebCore::AXObjectCache::remove):
        (WebCore::AXObjectCache::getAXID):
        (WebCore::AXObjectCache::removeAXID):
        (WebCore::AXObjectCache::childrenChanged):
        * page/AXObjectCache.h:
        (WebCore::AXObjectCache::isIDinUse):
        * page/AccessibilityObject.cpp:
        (WebCore::AccessibilityObject::AccessibilityObject):
        (WebCore::AccessibilityObject::create):
        (WebCore::AccessibilityObject::detach):
        (WebCore::AccessibilityObject::firstChild):
        (WebCore::AccessibilityObject::lastChild):
        (WebCore::AccessibilityObject::previousSibling):
        (WebCore::AccessibilityObject::nextSibling):
        (WebCore::AccessibilityObject::parentObject):
        (WebCore::AccessibilityObject::layoutCount):
        (WebCore::AccessibilityObject::text):
        (WebCore::AccessibilityObject::helpText):
        (WebCore::AccessibilityObject::textUnderElement):
        (WebCore::AccessibilityObject::isARIAInput):
        (WebCore::AccessibilityObject::isARIAControl):
        (WebCore::AccessibilityObject::intValue):
        (WebCore::AccessibilityObject::stringValue):
        (WebCore::AccessibilityObject::title):
        (WebCore::AccessibilityObject::accessibilityDescription):
        (WebCore::AccessibilityObject::boundingBoxRect):
        (WebCore::AccessibilityObject::elementRect):
        (WebCore::AccessibilityObject::size):
        (WebCore::AccessibilityObject::linkedUIElement):
        (WebCore::AccessibilityObject::textLength):
        (WebCore::AccessibilityObject::ariaSelectedTextDOMRange):
        (WebCore::AccessibilityObject::selectedText):
        (WebCore::AccessibilityObject::accessKey):
        (WebCore::AccessibilityObject::selection):
        (WebCore::AccessibilityObject::selectedTextRange):
        (WebCore::AccessibilityObject::setSelectedTextRange):
        (WebCore::AccessibilityObject::url):
        (WebCore::AccessibilityObject::setFocused):
        (WebCore::AccessibilityObject::setValue):
        (WebCore::AccessibilityObject::axObjectCache):
        (WebCore::AccessibilityObject::getDocumentLinks):
        (WebCore::AccessibilityObject::widget):
        (WebCore::AccessibilityObject::widgetForAttachmentView):
        (WebCore::AccessibilityObject::anchorElement):
        (WebCore::AccessibilityObject::actionElement):
        (WebCore::AccessibilityObject::visiblePositionRange):
        (WebCore::AccessibilityObject::doAXTextMarkerRangeForLine):
        (WebCore::AccessibilityObject::visiblePositionForIndex):
        (WebCore::AccessibilityObject::indexForVisiblePosition):
        (WebCore::AccessibilityObject::doAXBoundsForTextMarkerRange):
        (WebCore::AccessibilityObject::doSetAXSelectedTextMarkerRange):
        (WebCore::AccessibilityObject::doAXTextMarkerForPosition):
        (WebCore::AccessibilityObject::textMarkerForIndex):
        (WebCore::AccessibilityObject::rangeForTextMarkerRange):
        (WebCore::AccessibilityObject::indexForTextMarker):
        (WebCore::AccessibilityObject::doAXRangeForLine):
        (WebCore::AccessibilityObject::doAXRangeForPosition):
        (WebCore::AccessibilityObject::doAXRangeForIndex):
        (WebCore::AccessibilityObject::doAXStyleRangeForIndex):
        (WebCore::AccessibilityObject::doAXStringForRange):
        (WebCore::AccessibilityObject::doAXBoundsForRange):
        (WebCore::AccessibilityObject::doAccessibilityHitTest):
        (WebCore::AccessibilityObject::focusedUIElement):
        (WebCore::AccessibilityObject::observableObject):
        (WebCore::AccessibilityObject::roleValue):
        (WebCore::AccessibilityObject::ariaRoleAttribute):
        (WebCore::AccessibilityObject::childrenChanged):
        (WebCore::AccessibilityObject::addChildren):
        (WebCore::AccessibilityObject::removeAXObjectID):
        * page/AccessibilityObject.h:
        (WebCore::):
        (WebCore::PlainTextRange::PlainTextRange):
        (WebCore::PlainTextRange::isNull):
        (WebCore::AccessibilityObject::isAccessibilityRenderObject):
        (WebCore::AccessibilityObject::isAnchor):
        (WebCore::AccessibilityObject::isAttachment):
        (WebCore::AccessibilityObject::isHeading):
        (WebCore::AccessibilityObject::isLink):
        (WebCore::AccessibilityObject::isImage):
        (WebCore::AccessibilityObject::isNativeImage):
        (WebCore::AccessibilityObject::isImageButton):
        (WebCore::AccessibilityObject::isPasswordField):
        (WebCore::AccessibilityObject::isTextControl):
        (WebCore::AccessibilityObject::isNativeTextControl):
        (WebCore::AccessibilityObject::isWebArea):
        (WebCore::AccessibilityObject::isCheckboxOrRadio):
        (WebCore::AccessibilityObject::isChecked):
        (WebCore::AccessibilityObject::isEnabled):
        (WebCore::AccessibilityObject::isSelected):
        (WebCore::AccessibilityObject::isFocused):
        (WebCore::AccessibilityObject::isHovered):
        (WebCore::AccessibilityObject::isIndeterminate):
        (WebCore::AccessibilityObject::isLoaded):
        (WebCore::AccessibilityObject::isMultiSelect):
        (WebCore::AccessibilityObject::isOffScreen):
        (WebCore::AccessibilityObject::isPressed):
        (WebCore::AccessibilityObject::isReadOnly):
        (WebCore::AccessibilityObject::isVisited):
        (WebCore::AccessibilityObject::canSetFocusAttribute):
        (WebCore::AccessibilityObject::canSetTextRangeAttributes):
        (WebCore::AccessibilityObject::canSetValueAttribute):
        (WebCore::AccessibilityObject::hasIntValue):
        (WebCore::AccessibilityObject::accessibilityShouldUseUniqueId):
        (WebCore::AccessibilityObject::accessibilityIsIgnored):
        (WebCore::AccessibilityObject::children):
        (WebCore::AccessibilityObject::hasChildren):
        (WebCore::AccessibilityObject::setWrapper):
        (WebCore::AccessibilityObject::isDetached):
        * page/AccessibilityRenderObject.cpp: Added.
        (WebCore::AccessibilityRenderObject::AccessibilityRenderObject):
        (WebCore::AccessibilityRenderObject::~AccessibilityRenderObject):
        (WebCore::AccessibilityRenderObject::create):
        (WebCore::AccessibilityRenderObject::detach):
        (WebCore::AccessibilityRenderObject::firstChild):
        (WebCore::AccessibilityRenderObject::lastChild):
        (WebCore::AccessibilityRenderObject::previousSibling):
        (WebCore::AccessibilityRenderObject::nextSibling):
        (WebCore::AccessibilityRenderObject::parentObject):
        (WebCore::AccessibilityRenderObject::isWebArea):
        (WebCore::AccessibilityRenderObject::isImageButton):
        (WebCore::AccessibilityRenderObject::isAnchor):
        (WebCore::AccessibilityRenderObject::isNativeTextControl):
        (WebCore::AccessibilityRenderObject::isTextControl):
        (WebCore::AccessibilityRenderObject::isNativeImage):
        (WebCore::AccessibilityRenderObject::isImage):
        (WebCore::AccessibilityRenderObject::isAttachment):
        (WebCore::AccessibilityRenderObject::isPasswordField):
        (WebCore::AccessibilityRenderObject::isCheckboxOrRadio):
        (WebCore::AccessibilityRenderObject::isPressed):
        (WebCore::AccessibilityRenderObject::isIndeterminate):
        (WebCore::AccessibilityRenderObject::isChecked):
        (WebCore::AccessibilityRenderObject::isHovered):
        (WebCore::AccessibilityRenderObject::isMultiSelect):
        (WebCore::AccessibilityRenderObject::isReadOnly):
        (WebCore::AccessibilityRenderObject::isOffScreen):
        (WebCore::AccessibilityRenderObject::headingLevel):
        (WebCore::AccessibilityRenderObject::isHeading):
        (WebCore::AccessibilityRenderObject::isLink):
        (WebCore::AccessibilityRenderObject::anchorElement):
        (WebCore::AccessibilityRenderObject::actionElement):
        (WebCore::AccessibilityRenderObject::mouseButtonListener):
        (WebCore::AccessibilityRenderObject::helpText):
        (WebCore::AccessibilityRenderObject::textUnderElement):
        (WebCore::AccessibilityRenderObject::hasIntValue):
        (WebCore::AccessibilityRenderObject::intValue):
        (WebCore::AccessibilityRenderObject::stringValue):
        (WebCore::labelForElement):
        (WebCore::AccessibilityRenderObject::title):
        (WebCore::AccessibilityRenderObject::accessibilityDescription):
        (WebCore::AccessibilityRenderObject::boundingBoxRect):
        (WebCore::AccessibilityRenderObject::elementRect):
        (WebCore::AccessibilityRenderObject::size):
        (WebCore::AccessibilityRenderObject::linkedUIElement):
        (WebCore::AccessibilityRenderObject::accessibilityShouldUseUniqueId):
        (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
        (WebCore::AccessibilityRenderObject::isLoaded):
        (WebCore::AccessibilityRenderObject::layoutCount):
        (WebCore::AccessibilityRenderObject::text):
        (WebCore::AccessibilityRenderObject::textLength):
        (WebCore::AccessibilityRenderObject::ariaSelectedTextDOMRange):
        (WebCore::AccessibilityRenderObject::selectedText):
        (WebCore::AccessibilityRenderObject::accessKey):
        (WebCore::AccessibilityRenderObject::selection):
        (WebCore::AccessibilityRenderObject::selectedTextRange):
        (WebCore::AccessibilityRenderObject::setSelectedTextRange):
        (WebCore::AccessibilityRenderObject::url):
        (WebCore::AccessibilityRenderObject::isVisited):
        (WebCore::AccessibilityRenderObject::isSelected):
        (WebCore::AccessibilityRenderObject::isFocused):
        (WebCore::AccessibilityRenderObject::setFocused):
        (WebCore::AccessibilityRenderObject::setValue):
        (WebCore::AccessibilityRenderObject::isEnabled):
        (WebCore::AccessibilityRenderObject::topRenderer):
        (WebCore::AccessibilityRenderObject::widget):
        (WebCore::AccessibilityRenderObject::axObjectCache):
        (WebCore::AccessibilityRenderObject::getDocumentLinks):
        (WebCore::AccessibilityRenderObject::widgetForAttachmentView):
        (WebCore::AccessibilityRenderObject::frameViewIfRenderView):
        (WebCore::AccessibilityRenderObject::visiblePositionRange):
        (WebCore::AccessibilityRenderObject::doAXTextMarkerRangeForLine):
        (WebCore::AccessibilityRenderObject::visiblePositionForIndex):
        (WebCore::AccessibilityRenderObject::indexForVisiblePosition):
        (WebCore::AccessibilityRenderObject::doAXBoundsForTextMarkerRange):
        (WebCore::AccessibilityRenderObject::doSetAXSelectedTextMarkerRange):
        (WebCore::AccessibilityRenderObject::doAXTextMarkerForPosition):
        (WebCore::AccessibilityRenderObject::textMarkerForIndex):
        (WebCore::AccessibilityRenderObject::indexForTextMarker):
        (WebCore::AccessibilityRenderObject::doAXRangeForLine):
        (WebCore::AccessibilityRenderObject::doAXRangeForIndex):
        (WebCore::AccessibilityRenderObject::doAXStringForRange):
        (WebCore::AccessibilityRenderObject::doAXBoundsForRange):
        (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
        (WebCore::AccessibilityRenderObject::focusedUIElement):
        (WebCore::AccessibilityRenderObject::observableObject):
        (WebCore::createARIARoleMap):
        (WebCore::RoleEntry::):
        (WebCore::ariaRoleToWebCoreRole):
        (WebCore::AccessibilityRenderObject::ariaRoleAttribute):
        (WebCore::AccessibilityRenderObject::roleValue):
        (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
        (WebCore::AccessibilityRenderObject::canSetValueAttribute):
        (WebCore::AccessibilityRenderObject::canSetTextRangeAttributes):
        (WebCore::AccessibilityRenderObject::childrenChanged):
        (WebCore::AccessibilityRenderObject::children):
        (WebCore::AccessibilityRenderObject::addChildren):
        (WebCore::AccessibilityRenderObject::removeAXObjectID):
        (WebCore::AccessibilityRenderObject::actionVerb):
        * page/AccessibilityRenderObject.h: Added.
        (WebCore::AccessibilityRenderObject::isAccessibilityRenderObject):
        (WebCore::AccessibilityRenderObject::areaElement):
        (WebCore::AccessibilityRenderObject::setRenderer):
        (WebCore::AccessibilityRenderObject::renderer):
        (WebCore::AccessibilityRenderObject::setRenderObject):
        (WebCore::AccessibilityRenderObject::isDetached):
        * page/mac/AXObjectCacheMac.mm:
        (WebCore::AXObjectCache::detachWrapper):
        (WebCore::AXObjectCache::selectedChildrenChanged):
        (WebCore::AXObjectCache::postNotification):
        * page/mac/AccessibilityObjectWrapper.mm:
        (textMarkerForVisiblePosition):
        (CreateCGColorIfDifferent):
        (AXAttributeStringSetHeadingLevel):
        (AXLinkElementForNode):
        (AXAttributeStringSetElement):
        (AXAttributedStringAppendText):
        (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
        (-[AccessibilityObjectWrapper documentFrameView:]):
        (-[AccessibilityObjectWrapper position]):
        (RoleEntry::):
        (-[AccessibilityObjectWrapper roleDescription]):
        (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
        (-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
        (-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
        (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
        (-[AccessibilityObjectWrapper _accessibilityParentForSubview:]):
        (-[AccessibilityObjectWrapper doAXAttributedStringForRange:]):
        (-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

rwlbuis@webkit.org's avatar
rwlbuis@webkit.org committed
1994 1995 1996 1997 1998 1999 2000 2001 2002 2003 2004
2008-05-06  Jonathan Haas  <myrdred@gmail.com>

        Reviewed by Rob Buis.

        https://bugs.webkit.org/show_bug.cgi?id=18859\
        Prevented SVGRootInlineBox from static_casting a
        node to a class it doesn't inherit
        
        * rendering/SVGRootInlineBox.cpp:
        (WebCore::SVGRootInlineBox::buildTextChunks):

beidson@apple.com's avatar
beidson@apple.com committed
2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 2017 2018 2019 2020 2021 2022 2023 2024 2025
2008-05-06  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler

        Preparation for upcoming work making LocalStorage persistent.

        When the application terminates, all pending local storage writes need to be
        sync'ed out to disk.
        This works n combination with platform specific code in WebKit that calls it.

        * WebCore.base.exp:

        * page/PageGroup.cpp:
        (WebCore::PageGroup::closeLocalStorage): Close all open LocalStorage objects
        * page/PageGroup.h:

        * storage/LocalStorage.cpp:
        (WebCore::LocalStorage::close): Placeholder for what will sync and terminate the
          local storage thread in the future.
        * storage/LocalStorage.h:

2026 2027 2028 2029 2030 2031
2008-05-06  Brady Eidson  <beidson@apple.com>

        Rubberstamped by David Kilzer

        * WebCore.base.exp:  Sort this mess!

2032 2033 2034 2035 2036 2037 2038 2039 2040 2041 2042 2043 2044
2008-05-05  Mark Rowe  <mrowe@apple.com>

        Reviewed by Dan Bernstein.

        Fix 60 crashes seen on the buildbots that were misreported as hangs.

        * dom/Document.cpp:
        (WebCore::Document::detachNodeIterator): Null-check page() before dereferencing it.
        (WebCore::Document::nodeWillBeRemoved): Ditto.
        (WebCore::Document::textInserted): Ditto.
        (WebCore::Document::textNodesMerged): Ditto.
        (WebCore::Document::textRemoved): Ditto.

2045 2046 2047 2048 2049 2050 2051 2052 2053 2054 2055 2056
2008-05-05  Brady Eidson  <beidson@apple.com>

        Reviewed by Mitz Pettel RTL

        Preparation for upcoming work making LocalStorage persistent.

        The other half of the StorageMap::importItem() addition.

        * storage/StorageArea.cpp:
        (WebCore::StorageArea::importItem):
        * storage/StorageArea.h:

2057 2058 2059 2060 2061 2062 2063 2064 2065 2066 2067 2068 2069 2070 2071 2072 2073 2074 2075 2076 2077 2078 2079 2080 2081
2008-05-05  Brady Eidson  <beidson@apple.com>

        Reviewed by Mitz Pettel RTL

        Preparation for upcoming work making LocalStorage persistent.

        - Create the LocalStorage object for a PageGroup the moment the first Page is added to it
          The Settings of the first Page define what persistent path the LocalStorage will use
        - Add a Frame argument for the LocalStorageArea request - this will allow a client object
          to be queried before the LocalStorageArea is established

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::localStorage):

        * page/PageGroup.cpp:
        (WebCore::PageGroup::addPage):
        (WebCore::PageGroup::localStorage):

        * storage/LocalStorage.cpp:
        (WebCore::LocalStorage::LocalStorage): Take the path as a constructor argument.  Deep copy
          the path as it will be used from another thread.
        (WebCore::LocalStorage::storageArea):
        * storage/LocalStorage.h:
        (WebCore::LocalStorage::create):

2082 2083 2084 2085 2086 2087 2088 2089 2090 2091 2092 2093 2094 2095 2096
2008-05-05  Brady Eidson  <beidson@apple.com>

        Reviewed by Mitz Pettel RTL

        Preparation for upcoming work making LocalStorage persistent.

        StorageMaps normally have copy-on-write semantics to help support SessionStorage.
        For LocalStorage, we never want this behavior.  When we forcefully import items into 
        a StorageMap from the LocalStorage background thread, this new import method will be used.

        * storage/StorageMap.cpp:
        (WebCore::StorageMap::importItem): Add a deep-copy of the item to the map without worrying
          about copy-on-write.
        * storage/StorageMap.h:

2097 2098 2099 2100 2101 2102 2103 2104 2105 2106 2107 2108 2109 2110 2111 2112 2113 2114 2115 2116 2117 2118 2119
2008-05-05  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Tim.

        -<rdar://problem/5770054> JavaScript profiler (10928)
        -Begininings of a UI for the Profiler in the WebInspector.

        * English.lproj/InspectorLocalizedStrings.js: Add new strings to be
        localized.
        * page/inspector/DatabasesPanel.js: Changed the name of the Databae's
        results table to be more generic as it is now also used by the profiler.
        * page/inspector/Images/glossySelected.png: Added.
        * page/inspector/Images/profilesIcon.png: Added.
        * page/inspector/Images/treeUpTriangleBlack.png: Added.
        * page/inspector/Images/treeUpTriangleWhite.png: Added.
        * page/inspector/ProfileView.js: Added. Sets up the header of the table.
        * page/inspector/ProfilesPanel.js: Added.
        * page/inspector/ProfilesPanel.js: Added. Sets up the containers of the
        profiler's content.
        * page/inspector/inspector.css: Change database-result-table to be more
        generic as well as add the styles needed by the profiler.
        * page/inspector/inspector.html: Add profiler support.

2120 2121 2122 2123 2124 2125 2126 2127 2128
2008-05-05  Brady Eidson  <beidson@apple.com>

        Change by Darin, reviewed by Brady

        Small efficiency improvement Darin just spotted

        * storage/StorageMap.cpp:
        (WebCore::StorageMap::setItem):

2129 2130 2131 2132 2133 2134 2135 2136 2137 2138
2008-05-05  Antti Koivisto  <antti@apple.com>

        Reviewed by Anders.

        Fix https://bugs.webkit.org/show_bug.cgi?id=18899
        Bug 18899: REGRESSION (r32871): Non-Safari crash in WTF::HashTable on startup

        * loader/loader.cpp:
        (WebCore::Loader::Loader):

2139 2140 2141 2142 2143 2144 2145 2146 2147 2148
2008-05-05  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig

        Fix a bug in StorageMap iterator tracking where the iterator was not successfully
        invalidated at an appropriate time.

        * storage/StorageMap.cpp:
        (WebCore::StorageMap::setItem): ALWAYS invalidate it here