ChangeLog 698 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45
2011-01-06  James Robinson  <jamesr@chromium.org>

        Reviewed by Simon Fraser.

        Implement mozilla's animationTime property
        https://bugs.webkit.org/show_bug.cgi?id=51952

        Implements mozilla's animationTime property as described here:
        https://developer.mozilla.org/en/DOM/window.mozAnimationStartTime
        and http://hacks.mozilla.org/2010/08/more-efficient-javascript-animations-with-mozrequestanimationframe/
        The property is called webkitAnimationTime as calling it the 'Start' time is not very informative.
        This property exposes a notion of a 'current' time to use for declarative animations and allows
        scripts to synchronize imperative animations with declarative ones if they choose to.  Once queried
        this time is saved and used for all declarative animation updates until the embedder paints/composites
        the next frame and clears it, or 15ms elapse (in case the embedder isn't producing frames, for example
        if the page is in a background tab).

        This patch also ensures that all declarative animations started in the same script execution block
        are synchronized even if some time elapses while script is running.

        Test: fast/animation/animation-time.html

        * WebCore.gypi:
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::webkitAnimationTime):
        * page/DOMWindow.h:
        * page/DOMWindow.idl:
        * page/Frame.cpp:
        (WebCore::Frame::currentAnimationTime):
        * page/Frame.h:
        * page/Page.cpp:
        (WebCore::Page::Page):
        * page/Page.h:
        (WebCore::Page::animationTime):
        * page/animation/AnimationController.cpp:
        (WebCore::AnimationControllerPrivate::beginAnimationUpdateTime):
        * page/animation/AnimationTimeController.cpp: Added.
        (WebCore::AnimationTimeController::AnimationTimeController):
        (WebCore::AnimationTimeController::~AnimationTimeController):
        (WebCore::AnimationTimeController::currentAnimationTime):
        (WebCore::AnimationTimeController::clearCurrentAnimationTime):
        (WebCore::AnimationTimeController::clearCurrentAnimationTimeTimerFired):
        * page/animation/AnimationTimeController.h: Added.
        (WebCore::AnimationTimeController::create):

46 47 48 49 50 51 52 53 54 55 56 57 58 59 60
2011-01-06  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Simon Fraser.

        Null out the parent stylesheet pointer when a css rule is removed.
        https://bugs.webkit.org/show_bug.cgi?id=51993

        Tests: fast/dom/StyleSheet/removed-media-rule-deleted-parent-crash.html
               fast/dom/StyleSheet/removed-stylesheet-rule-deleted-parent-crash.html

        * css/CSSRuleList.cpp:
        (WebCore::CSSRuleList::deleteRule):
        * css/CSSStyleSheet.cpp:
        (WebCore::CSSStyleSheet::deleteRule):

61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76
2011-01-04  Adrienne Walker  <enne@google.com>

        Reviewed by Kenneth Russell.

        NaN in a TypedArray should be converted to zero only for Float32Array.
        https://bugs.webkit.org/show_bug.cgi?id=46990

        Test: LayoutTests/fast/canvas/webgl/array-unit-tests.html

        * bindings/js/JSArrayBufferViewHelper.h:
        (WebCore::convertArrayValue):
        (WebCore::constructArrayBufferView):
        * html/canvas/Float32Array.h:
        (WebCore::Float32Array::set):
        (WebCore::Float32Array::item):

77 78 79 80 81 82
2011-01-06  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed Windows build fix for r75161.

        * platform/graphics/cg/GraphicsContextCG.cpp: Missing include added.

83 84 85 86 87 88 89 90
2011-01-06  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed WinCE build fix for r75139.

        Try to remove include after adding forward-declaration in r75145.

        * platform/graphics/Gradient.h:

91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125
2011-01-06  Renata Hodovan  <reni@webkit.org>

        Reviewed by Andreas Kling.

        https://bugs.webkit.org/show_bug.cgi?id=51811
        Merge m_height and m_width members of ImageData into the new m_size member.

        Image (BitmapImage, ImageSource) types in WebKit use IntSize to store their
        width and height argument, except ImageData. This patch refactors ImageData
        to follow the style of other Image types in WebKit.
        Using of PassRefPtrs other than argument passing is not allowed in WebKit anymore.
        This patch also refactors the PassRefPtr usages of ImageData.

        It's just a refactoring, so we don't need any new tests.

        * bindings/js/SerializedScriptValue.cpp:
        (WebCore::CloneSerializer::write):
        (WebCore::CloneDeserializer::readTerminal):
        * bindings/v8/SerializedScriptValue.cpp:
        (WebCore::ZigZag::Reader::readImageData):
        * html/ImageData.cpp:
        (WebCore::ImageData::create):
        (WebCore::ImageData::ImageData):
        * html/ImageData.h:
        (WebCore::ImageData::size):
        (WebCore::ImageData::width):
        (WebCore::ImageData::height):
        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::createEmptyImageData):
        (WebCore::CanvasRenderingContext2D::createImageData):
        (WebCore::CanvasRenderingContext2D::getImageData):
        * html/canvas/CanvasRenderingContext2D.h:
        * platform/graphics/haiku/ImageBufferHaiku.cpp:
        (WebCore::getImageData):

126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147
2011-01-06  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Darin Adler.

        document.querySelector(':nth-child(foo)') should throw a syntax error
        https://bugs.webkit.org/show_bug.cgi?id=51231

        Also fixes 
        CSSNthSelector parsing code is illegible and buggy (allows "n3" as a valid selector)
        https://bugs.webkit.org/show_bug.cgi?id=21815

        Add a check in the parser that other than an+b, only "odd" or "even" would be allowed
        as parameters to nth selector.

        Tests: fast/css/css3-nth-tokens-script.html
               fast/css/css3-nth-tokens-style.html

        * css/CSSGrammar.y:
        * css/CSSParser.cpp:
        (WebCore::isValidNthToken):
        * css/CSSParser.h:

148 149 150 151 152 153 154 155 156 157 158 159 160 161
2011-01-06  Jan Erik Hanssen  <jhanssen@sencha.com>

        Reviewed by Andreas Kling.

        [Qt] crash in QNetworkReplyHandler::sendResponseIfNeeded()
        https://bugs.webkit.org/show_bug.cgi?id=51453

        Check if m_reply is NULL before accessing.

        * manual-tests/load-deferrer-resume-crash.html: Added.
        * platform/network/qt/QNetworkReplyHandler.cpp:
        (WebCore::QNetworkReplyHandler::setLoadMode):
        (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):

162 163 164 165 166 167 168 169 170 171
2011-01-06  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Csaba Osztrogonác.

        [Qt][V8] Fix the build when DEVICE_ORIENTATION is enabled.

        No new tests needed.

        * WebCore.pro: remove duplications and globally add RuntimeEnabledFeatures.

172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194
2011-01-06  Helder Correia  <helder@sencha.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt][GTK] Use GraphicsContext::hasShadow() in port-specific code
        https://bugs.webkit.org/show_bug.cgi?id=51985

        r75139 introduced GraphicsContext::hasShadow(). This can now simplify
        and unify some code in the Qt and GTK ports.

        No new tests necessary for this refactoring.

        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::fillRect):
        (WebCore::GraphicsContext::fillRoundedRect):
        * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::drawConvexPolygon):
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::strokePath):
        (WebCore::GraphicsContext::fillRect):
        (WebCore::GraphicsContext::fillRoundedRect):

darin@apple.com's avatar
darin@apple.com committed
195 196 197 198 199 200 201 202 203 204
2011-01-05  Darin Adler  <darin@apple.com>

        Fix Chromium Mac build.

        * platform/graphics/Gradient.h: Forward-declare CGContextRef.
        This might even make it possible to remove the include of
        <CoreGraphics/CoreGraphics.h> for PLATFORM(WIN), but I did not
        do that at this time because I don't want to break the Windows
        build when fixing the Chromium build.

205 206 207 208 209 210 211 212 213 214 215 216 217 218 219
2011-01-05  Xianzhu Wang  <wangxianzhu@google.com>

        Reviewed by David Levin.

        Implement RemoteFontStream's skip behavior (in FontCustomPlatformData.cpp)
        https://bugs.webkit.org/show_bug.cgi?id=51736

        No new tests. This change has potential effect on @font-face CSS feature
        on ports using Skia. Tested on Chromium that this change won't break
        fast/css/font-face-remote.html. This change can make the test pass on
        other ports using Skia.

        * platform/graphics/skia/FontCustomPlatformData.cpp:
        (WebCore::RemoteFontStream::read):

220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244
2011-01-05  Helder Correia  <helder@sencha.com>

        Reviewed by Simon Fraser.

        Shadows are not drawn when filling a rect with a gradient fillStyle on Mac and Chromium-Mac
        https://bugs.webkit.org/show_bug.cgi?id=51869

        GraphicsContext::fillRect(const FloatRect&) is clipping to the rect.
        The shadow is being drawn, but getting clipped to the rect being filled.
        The solution is to draw the gradient into a CGLayer (when a shadow is
        required), then render the layer to the GraphicsContext.

        This patch also fixes:
        canvas/philip/tests/2d.shadow.gradient.alpha.html
        canvas/philip/tests/2d.shadow.gradient.basic.html
        canvas/philip/tests/2d.shadow.gradient.transparent.2.html

        Test: fast/canvas/canvas-fillRect-gradient-shadow.html

        * platform/graphics/Gradient.h:
        * platform/graphics/cg/GradientCG.cpp:
        (WebCore::Gradient::paint):
        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::fillRect):

245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275
2011-01-05  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Darin Adler.

        Debug and Release builds on Windows clobber each other
        https://bugs.webkit.org/show_bug.cgi?id=49185

        Changes the structure of WebKitBuild build products directory so we
        completely separate each build configuration into independent directories.
        
        Although we previously had per-configuration directories for obj, this change adds
        per-configuration directories for bin, lib, obj, and include. Each configuration's
        build products are stored within a directory inside of WebKitBuild.
        
        Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
        defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).

        * WebCore.vcproj/QTMovieWinCommon.vsprops:
        * WebCore.vcproj/QTMovieWinPostBuild.cmd:
        * WebCore.vcproj/QTMovieWinPreBuild.cmd:
        * WebCore.vcproj/WebCore.make:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.vcproj/WebCoreCommon.vsprops:
        * WebCore.vcproj/WebCoreGeneratedCairo.vsprops:
        * WebCore.vcproj/WebCoreGeneratedCommon.vsprops:
        * WebCore.vcproj/WebCoreMediaQT.vsprops:
        * WebCore.vcproj/WebCorePostBuild.cmd:
        * WebCore.vcproj/WebCorePreBuild.cmd:
        * WebCore.vcproj/copyForwardingHeaders.cmd:
        * WebCore.vcproj/copyInspectorFiles.cmd:

276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300
2011-01-05  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Ariya Hidayat.

        Directly composited SVG images fail to render
        https://bugs.webkit.org/show_bug.cgi?id=51975
        
        There was already code, added in r67900, to detect whether an image
        may be directly composited, by checking to see if it's a bitmap image.
        
        However, CachedImage::image() returns the nullImage() if m_image is null,
        which is a BitmapImage, confusing this test.

        Test: compositing/images/direct-svg-image.html

        * loader/cache/CachedImage.cpp: Remove nullImage(), since Image has
        exactly the same method.
        (WebCore::CachedImage::image): Use Image::nullImage().
        * loader/cache/CachedImage.h:
        (WebCore::CachedImage::hasImage): New method to ask whether the m_image is
        non-null.
        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::isDirectlyCompositedImage): Use hasImage()
        so that we don't test the nullImage.

301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318
2011-01-05  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        Fix percentage values in radius of radial gradients
        https://bugs.webkit.org/show_bug.cgi?id=51979
        
        Handle percentage values for the ending size of radial gradients.

        Test: fast/gradients/css3-radial-gradients3.html

        * css/CSSGradientValue.cpp:
        (WebCore::CSSRadialGradientValue::resolveRadius): Add parameter for height or width, which is
        non-null if percentage values are allowed, and compute percentage values when we see them.
        (WebCore::CSSRadialGradientValue::createGradient): Pass height or width down to say that
        percentages are OK when resolving end radii.
        * css/CSSGradientValue.h: New parameter for resolveRadius.

319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347
2011-01-05  James Simonsen  <simonjam@chromium.org>

        Reviewed by Adam Barth.

        [Web Timing] Zero out some values on cross-origin redirects
        https://bugs.webkit.org/show_bug.cgi?id=49294

        Tests: http/tests/misc/webtiming-cross-origin-redirect.php
               http/tests/misc/webtiming-origins.html

        * loader/DocumentLoadTiming.h:
        (WebCore::DocumentLoadTiming::DocumentLoadTiming): Add flags for cross-origin redirects and same-origin navigation.
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::~FrameLoader):
        (WebCore::FrameLoader::stopLoading): Don't overwrite previous unload times.
        (WebCore::FrameLoader::completed):
        (WebCore::FrameLoader::loadWithDocumentLoader): Remember previous URL to see if navigation is same-origin.
        (WebCore::FrameLoader::commitProvisionalLoad): Set flag if navigation is same-origin.
        * loader/FrameLoader.h:
        * loader/MainResourceLoader.cpp:
        (WebCore::MainResourceLoader::willSendRequest): Set flag on cross-origin redirects.
        * page/PerformanceNavigation.cpp:
        (WebCore::PerformanceNavigation::redirectCount): Clear if cross-origin redirect flag is set.
        * page/PerformanceTiming.cpp:
        (WebCore::PerformanceTiming::redirectStart): Ditto.
        (WebCore::PerformanceTiming::redirectEnd): Ditto.
        (WebCore::PerformanceTiming::unloadEventStart): Clear if cross-origin navigation is set.
        (WebCore::PerformanceTiming::unloadEventEnd): Ditto.

348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363
2011-01-05  Helder Correia  <helder@sencha.com>

        Reviewed by Ariya Hidayat.

        [Qt] Default focus ring is too wide
        https://bugs.webkit.org/show_bug.cgi?id=51854

        This is an intermediate step to solve this bug. Use QPalette::Highlight
        instead of default half-transparent black as the focus ring color.

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::drawFocusRingForPath):
        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::platformFocusRingColor):
        * platform/qt/RenderThemeQt.h:

364 365 366 367 368 369 370 371 372 373 374 375 376
2011-01-05  James Simonsen  <simonjam@chromium.org>

        Reviewed by Darin Fisher.

        [Web Timing] requestStart and responseStart should be available even if the document is still loading
        https://bugs.webkit.org/show_bug.cgi?id=51368

        Test: http/tests/misc/webtiming-slow-load.php

        * page/PerformanceTiming.cpp:
        (WebCore::getPossiblySkewedTimeInKnownRange): Handle case where response is not yet complete.
        (WebCore::PerformanceTiming::resourceLoadTimeRelativeToAbsolute): Use full upper bound.

377 378 379 380 381 382 383 384 385 386 387 388
2011-01-05  Chris Rogers  <crogers@google.com>

        Reviewed by Darin Fisher.

        Add WebKitClient::createAudioDevice() for Chromium port of web audio API
        https://bugs.webkit.org/show_bug.cgi?id=51424

        No new tests since audio API is not yet implemented.

        * WebCore.gyp/WebCore.gyp:
        * WebCore.gypi:

andersca@apple.com's avatar
andersca@apple.com committed
389 390 391 392 393 394
2011-01-05  Anders Carlsson  <andersca@apple.com>

        Try again.

        * WebCore.exp.in:

395 396 397 398 399 400
2011-01-05  Anders Carlsson  <andersca@apple.com>

        Attempt to fix Leopard build.

        * WebCore.exp.in:

401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455
2011-01-05  Evan Martin  <evan@chromium.org>

        Reviewed by Tony Chang.

        [chromium] refactor complex text on Linux
        https://bugs.webkit.org/show_bug.cgi?id=51956

        Pull out TextRunWalker from FontLinux.cpp.  Put it in its own file.
        Rename it to ComplexTextController, to match platform/graphics/mac
        more closely.

        No tests because the change is just renaming a class.

        * WebCore.gyp/WebCore.gyp:
        * platform/graphics/chromium/ComplexTextControllerLinux.cpp: Added.
        (WebCore::ComplexTextController::ComplexTextController):
        (WebCore::ComplexTextController::~ComplexTextController):
        (WebCore::ComplexTextController::isWordBreak):
        (WebCore::ComplexTextController::determineWordBreakSpacing):
        (WebCore::ComplexTextController::setPadding):
        (WebCore::ComplexTextController::reset):
        (WebCore::ComplexTextController::setBackwardsIteration):
        (WebCore::ComplexTextController::nextScriptRun):
        (WebCore::ComplexTextController::widthOfFullRun):
        (WebCore::ComplexTextController::setupFontForScriptRun):
        (WebCore::ComplexTextController::allocHarfbuzzFont):
        (WebCore::ComplexTextController::deleteGlyphArrays):
        (WebCore::ComplexTextController::createGlyphArrays):
        (WebCore::ComplexTextController::resetGlyphArrays):
        (WebCore::ComplexTextController::shapeGlyphs):
        (WebCore::ComplexTextController::setGlyphXPositions):
        (WebCore::ComplexTextController::normalizeSpacesAndMirrorChars):
        (WebCore::ComplexTextController::getNormalizedTextRun):
        * platform/graphics/chromium/ComplexTextControllerLinux.h: Added.
        (WebCore::ComplexTextController::setWordSpacingAdjustment):
        (WebCore::ComplexTextController::setLetterSpacingAdjustment):
        (WebCore::ComplexTextController::letterSpacing):
        (WebCore::ComplexTextController::setXOffsetToZero):
        (WebCore::ComplexTextController::rtl):
        (WebCore::ComplexTextController::glyphs):
        (WebCore::ComplexTextController::length):
        (WebCore::ComplexTextController::xPositions):
        (WebCore::ComplexTextController::advances):
        (WebCore::ComplexTextController::width):
        (WebCore::ComplexTextController::logClusters):
        (WebCore::ComplexTextController::numCodePoints):
        (WebCore::ComplexTextController::fontPlatformDataForScriptRun):
        (WebCore::ComplexTextController::isCodepointSpace):
        * platform/graphics/chromium/FontLinux.cpp:
        (WebCore::Font::drawComplexText):
        (WebCore::Font::floatWidthForComplexText):
        (WebCore::glyphIndexForXPositionInScriptRun):
        (WebCore::Font::offsetForPositionForComplexText):
        (WebCore::Font::selectionRectForComplexText):

456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480
2011-01-05  Pratik Solanki  <psolanki@apple.com>

        Reviewed by Darin Adler.

        Merge cf and mac header files with same name
        https://bugs.webkit.org/show_bug.cgi?id=51916

        Since most of the code in the header files is identical, we can merge them and have #if
        USE(CFNETWORK) to separate out the network specific parts.

        * WebCore.xcodeproj/project.pbxproj:
        * platform/network/cf/AuthenticationChallenge.h:
        (WebCore::AuthenticationChallenge::sender):
        (WebCore::AuthenticationChallenge::nsURLAuthenticationChallenge):
        * platform/network/cf/ResourceError.h:
        (WebCore::ResourceError::ResourceError):
        * platform/network/cf/ResourceRequest.h:
        (WebCore::ResourceRequest::ResourceRequest):
        * platform/network/cf/ResourceResponse.h:
        (WebCore::ResourceResponse::ResourceResponse):
        * platform/network/mac/AuthenticationChallenge.h: Removed.
        * platform/network/mac/ResourceError.h: Removed.
        * platform/network/mac/ResourceRequest.h: Removed.
        * platform/network/mac/ResourceResponse.h: Removed.

481 482 483 484 485 486 487 488 489 490 491
2011-01-05  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adele Peterson.

        Implement word transformation
        https://bugs.webkit.org/show_bug.cgi?id=51943

        Export Editor functions needed by WebKit2.

        * WebCore.exp.in:

492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536
2011-01-05  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt.

        Implement repeating CSS3 gradients
        https://bugs.webkit.org/show_bug.cgi?id=51843
        
        Add support for repeating gradients, via the new gradient functions
        -webkit-repeating-linear-gradient and -webkit-repeating-radial-gradient.

        Tests: fast/gradients/css3-repeating-linear-gradients.html
               fast/gradients/css3-repeating-radial-gradients.html

        * css/CSSGradientValue.h:
        (WebCore::CSSGradientValue::isRepeating): Accessor for whethe the gradient repeats.
        (WebCore::CSSGradientValue::CSSGradientValue): Pass CSSGradientRepeat in.
        (WebCore::CSSLinearGradientValue::create): Pass CSSGradientRepeat.
        (WebCore::CSSLinearGradientValue::CSSLinearGradientValue): Ditto
        (WebCore::CSSRadialGradientValue::create): Ditto.
        (WebCore::CSSRadialGradientValue::CSSRadialGradientValue): Ditto.

        * css/CSSGradientValue.cpp:
        (WebCore::CSSGradientValue::addStops): Pass maxLengthForRepeat, which
        is used for repeating radial gradients. Add code to repeat the stops,
        adding stops before the start, and after the end until the 0-N range is
        covered, where N is large enough to ensure the box is covered. Fix an issue
        with repeating gradients where if both stops were < 0, it would fail to clamp
        them to 0.
        
        (WebCore::CSSLinearGradientValue::cssText): Output strings for repeating gradients.
        (WebCore::CSSLinearGradientValue::createGradient): maxExtent for linear gradients is 1,
        because they are guaranteed to fill the box already.
        (WebCore::CSSRadialGradientValue::cssText): Output strings for repeating gradients.
        (WebCore::CSSRadialGradientValue::createGradient): Compute the distance to the furthest
        corner in order to inform addStops() how much additional extent is required.

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseDeprecatedGradient): Old gradients never repeat.
        (WebCore::CSSParser::parseLinearGradient): Pass down CSSGradientRepeat.
        (WebCore::CSSParser::parseRadialGradient): Ditto.
        (WebCore::CSSParser::isGeneratedImageValue): Add repeating gradient functions.
        (WebCore::CSSParser::parseGeneratedImage): Ditto.
        * css/CSSParser.h: Pass CSSGradientRepeat to gradient functions.
        * platform/graphics/cg/GradientCG.cpp: Remove unused #include.

537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554
2011-01-05  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Ariya Hidayat.

        ContextShadow::blurLayerImage() not endian-safe
        https://bugs.webkit.org/show_bug.cgi?id=51822

        Correct the channel map in ContextShadow to reflect the different
        ordering of pixels on processors with different endianness.

        No new tests. This is covered by the existing shadow tests. It was
        not discovered, because all of the bots using ContextShadow are
        little-endian.

        * platform/graphics/ContextShadow.cpp:
        (WebCore::ContextShadow::blurLayerImage): Initialize the channel mapping
        based on machine endianness.

555 556 557 558 559 560 561 562 563 564 565 566 567 568 569
2011-01-05  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Nate Chapin.

        [Chromium] Crash when drawing PDF plug-in scrollbars
        https://bugs.webkit.org/show_bug.cgi?id=51942

        Pepper plug-in scrollbars don't have a parent, guard against that before
        seeing if the parent is a FrameView.

        Not testable via layout tests, verified fix by hand.
        
        * platform/chromium/ScrollbarThemeChromiumMac.mm:
        (WebCore::ScrollbarThemeChromiumMac::paint):

570 571 572 573 574 575 576 577 578
2011-01-05  Abhishek Arya  <inferno@chromium.org>

        Unreviewed.

        Update FIXME comment to sound better. Also initialize the block to fix compile.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::removeChild):

579 580 581 582 583 584 585 586 587 588 589 590
2011-01-05  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dave Hyatt.

        Do not merge anonymous blocks when one of them is the one getting removed.
        https://bugs.webkit.org/show_bug.cgi?id=51919

        Test: fast/block/merge-anonymous-block-remove-child-crash.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::removeChild):

591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622
2011-01-05  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        ApplyStyleCommand::applyRelativeFontStyleChange should take EditingStyle*
        https://bugs.webkit.org/show_bug.cgi?id=50641

        Modified applyRelativeFontStyleChange to take EditingStyle instead of CSSMutableStyleDeclaration.
        Also extracted the logic to obtain the font size delta from ApplyStyleCommand to EditingStyle.
        The font size delta is now stored as a member variable of EditingStyle as supposed to a property
        in CSSMutableStyleDeclration as soon as EditingStyle is instantiated.

        No new tests are added since this is a refactoring.

        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::doApply): Calls applyRelativeFontStyleChange.
        (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Takes EditingStyle.
        * editing/ApplyStyleCommand.h:
        * editing/EditingStyle.cpp:
        (WebCore::EditingStyle::EditingStyle): Initializes m_fontSizeDelta.
        (WebCore::EditingStyle::init): Ditto.
        (WebCore::EditingStyle::extractFontSizeDelta): Extracted from applyRelativeFontStyleChange.
        (WebCore::EditingStyle::isEmpty): Takes care of m_fontSizeDelta.
        (WebCore::EditingStyle::setStyle): Calls extractFontSizeDelta.
        (WebCore::EditingStyle::overrideWithStyle): Ditto.
        (WebCore::EditingStyle::clear): Initializes m_fontSizeDelta.
        (WebCore::EditingStyle::copy): Calls extractFontSizeDelta.
        * editing/EditingStyle.h:
        (WebCore::EditingStyle::fontSizeDelta): Added.
        (WebCore::EditingStyle::hasFontSizeDelta): Added.
        * editing/Editor.h:

623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641
2011-01-05  Dan Bernstein  <mitz@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/8799835> hyphenate-character: auto should fall back to hyphen-minus if the primary font lacks a hyphen glyph
        https://bugs.webkit.org/show_bug.cgi?id=51915

        This changes the results of existing tests in fast/text.

        * platform/graphics/Font.h:
        * platform/graphics/FontFastPath.cpp:
        (WebCore::Font::primaryFontHasGlyphForCharacter): Added.
        * rendering/style/RenderStyle.cpp:
        * platform/graphics/qt/FontQt.cpp:
        (WebCore::Font::primaryFontHasGlyphForCharacter): Added a stub.
        (WebCore::RenderStyle::hyphenString): For hyphenate-character: auto, return a
        hyphen only if the primary font has a hyphen glyph, and otherwise return a
        hyphen-minus.

642 643 644 645 646 647 648 649 650 651 652 653 654 655
2011-01-05  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Ariya Hidayat.

        [Qt] [Symbian] Make CONFIG-=def_files the default configuration for trunk builds
        https://bugs.webkit.org/show_bug.cgi?id=51888

        Overrule Qt's default from qconfig.pri for non-production builds so
        that CONFIG(def_files) evaluates to false and QtWebKit trunk builds succeed.

        No new tests as there is no new functionality.

        * WebCore.pro:

656 657 658 659 660 661 662 663 664 665 666 667 668
2011-01-05  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r74778.
        http://trac.webkit.org/changeset/74778
        https://bugs.webkit.org/show_bug.cgi?id=51930

        Android and QtWebKit-V8 uses V8DOMWindowShell::setContext.
        (Requested by bbandix on #webkit).

        * bindings/v8/V8DOMWindowShell.cpp:
        (WebCore::V8DOMWindowShell::setContext):
        * bindings/v8/V8DOMWindowShell.h:

669 670 671 672 673 674 675 676 677 678 679 680
2011-01-05  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Animated GIF images does not animate 10x as expected by default.
        https://bugs.webkit.org/show_bug.cgi?id=36818

        Add a test animated GIF which should be displayed 2 times and stop.

        * manual-tests/animated-gif-looping.html:
        * manual-tests/resources/animated-2x.gif: Added.

681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709
2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Fork code of ScrollbarThemeGtk that will differ for GTK+ 3
        https://bugs.webkit.org/show_bug.cgi?id=51923

        Split out pieces of ScrollbarThemeGtk into ScrollbarThemeGtk2 and
        ScrollbarThemeGtk3 that will differ between GTK+ 2 and GTK+ 3.

        No new tests. This should not change functionality.

        * GNUmakefile.am: Add ScrollbarThemeGtk2.cpp and ScrollbarThemeGtk3.cpp
        * platform/gtk/ScrollbarThemeGtk.cpp:
        (WebCore::ScrollbarThemeGtk::updateScrollbarsFrameThickness):
        * platform/gtk/ScrollbarThemeGtk.h:
        * platform/gtk/ScrollbarThemeGtk2.cpp: Added.
        (WebCore::ScrollbarThemeGtk::updateThemeProperties):
        (WebCore::ScrollbarThemeGtk::paintTrackBackground):
        (WebCore::ScrollbarThemeGtk::paintScrollbarBackground):
        (WebCore::ScrollbarThemeGtk::paintThumb):
        (WebCore::ScrollbarThemeGtk::paintButton):
        * platform/gtk/ScrollbarThemeGtk3.cpp: Added.
        (WebCore::ScrollbarThemeGtk::updateThemeProperties):
        (WebCore::ScrollbarThemeGtk::paintTrackBackground):
        (WebCore::ScrollbarThemeGtk::paintScrollbarBackground):
        (WebCore::ScrollbarThemeGtk::paintThumb):
        (WebCore::ScrollbarThemeGtk::paintButton):

710 711 712 713 714 715 716 717 718
2011-01-05  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Andreas Kling.

        [CMake] Fix the usage of SOURCE_GROUP
        https://bugs.webkit.org/show_bug.cgi?id=51739

        * CMakeLists.txt:

719 720 721 722 723 724 725 726 727 728
2011-01-05  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Csaba Osztrogonác.

        [Qt][V8] Fix the build after recent changes.

        No new tests needed.

        * WebCore.pro: Add missing files, and remove obsolete ones.

729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758
2011-01-05  Yong Li  <yoli@rim.com>

        Reviewed by Adam Barth.

        Suspend HTMLParserScheduler when page load is deferred to
        avoid potential JS re-entrancy. Otherwise, when JS execution is triggered
        from an external script or by events, and is blocked by a modal dialog,
        WebKit can parse more HTML source and also start another JS execution.
        
        https://bugs.webkit.org/show_bug.cgi?id=48077

        Test case: WebCore/manual-tests/bugzilla-48077.html.

        * dom/DocumentParser.cpp:
        (WebCore::DocumentParser::suspendScheduledTasks):
        (WebCore::DocumentParser::resumeScheduledTasks):
        * dom/DocumentParser.h:
        * html/parser/HTMLDocumentParser.cpp:
        (WebCore::HTMLDocumentParser::suspendScheduledTasks):
        (WebCore::HTMLDocumentParser::resumeScheduledTasks):
        * html/parser/HTMLParserScheduler.cpp:
        (WebCore::HTMLParserScheduler::HTMLParserScheduler):
        (WebCore::HTMLParserScheduler::suspend):
        (WebCore::HTMLParserScheduler::resume):
        * html/parser/HTMLParserScheduler.h:
        (WebCore::HTMLParserScheduler::isScheduledForResume):
        * page/PageGroupLoadDeferrer.cpp:
        (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
        (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):

759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777
2011-01-05  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Kenneth Rohde Christiansen, Gustavo Noronha Silva

        [GStreamer] MediaPlayerPrivateGStreamer::totalBytes() does not work reliably
        https://bugs.webkit.org/show_bug.cgi?id=51926

        Work around potential upstream bug: Querying a GstBin for the duration,
        will forward the query to all sink children. Our WebKitWebSrc however
        is a bin with only source children, therefore the query fails. Until
        this is changed upstream, this patch works around it as follows,
        based on suggestion by Philippe Normand and Sebastian Dröge:

        When the initial query fails, attempt the same query on all source
        pads and take the maximum length reported.

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivateGStreamer::totalBytes):

778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793
2011-01-05  Philippe Normand  <pnormand@igalia.com>

        Rubber-stamped by Eric Seidel.

        [GStreamer] build fails with gstreamer core 0.10.31 and -plugins-base 0.10.30
        https://bugs.webkit.org/show_bug.cgi?id=51810

        Based on a patch by Mart Raudsepp.

        No new tests, build fix only.

        * platform/graphics/gstreamer/GStreamerGWorld.cpp:
        (WebCore::GStreamerGWorld::setWindowOverlay): Use the new xoverlay
        API if the GST_CHECK_PLUGINS_BASE_VERSION macro is defined. It was
        introduced in same version as the xoverlay API change.

794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812
2011-01-05  Leo Yang  <leo.yang@torchmobile.com.cn>

        Reviewed by Dirk Schulze.

        Malformed SVG causes crash in updateContainerOffset
        https://bugs.webkit.org/show_bug.cgi?id=44610

        We should check recursive <use> at the begining of
        WebCore::SVGUseElement::buildInstanceTree instead
        of at the end of it because the target element's
        children may cause infinite recursive <use>.

        Test: svg/custom/recursive-use.svg

        * svg/SVGUseElement.cpp:
        (WebCore::SVGUseElement::buildInstanceTree):
        (WebCore::SVGUseElement::hasCycleUseReferencing):
        * svg/SVGUseElement.h:

813 814 815 816 817 818 819 820 821 822 823 824
2011-01-04  Antti Koivisto  <antti@apple.com>

        Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=51907
        Style selector should only be recalculated when the pending sheet count goes to zero
        
        Shark says this is a significant performance improvement on some sites with lots of stylesheets.

        * dom/Document.cpp:
        (WebCore::Document::removePendingSheet):

825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851
2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Use GtkStyleContext to get platform colors
        https://bugs.webkit.org/show_bug.cgi?id=51830

        Use GtkStyleContext API to get platform colors when building with
        GTK+ 3.x.

        No new tests. This should not change functionality.

        * platform/graphics/Color.h: Add specialized constructor for GdkRGBA.
        * platform/graphics/gtk/ColorGtk.cpp:
        (WebCore::Color::Color):
        (WebCore::Color::operator GdkRGBA):
        * platform/gtk/RenderThemeGtk3.cpp:
        (WebCore::RenderThemeGtk::platformActiveSelectionBackgroundColor):
        (WebCore::RenderThemeGtk::platformInactiveSelectionBackgroundColor):
        (WebCore::RenderThemeGtk::platformActiveSelectionForegroundColor):
        (WebCore::RenderThemeGtk::platformInactiveSelectionForegroundColor):
        (WebCore::RenderThemeGtk::activeListBoxSelectionBackgroundColor):
        (WebCore::RenderThemeGtk::inactiveListBoxSelectionBackgroundColor):
        (WebCore::RenderThemeGtk::activeListBoxSelectionForegroundColor):
        (WebCore::RenderThemeGtk::inactiveListBoxSelectionForegroundColor):
        (WebCore::RenderThemeGtk::systemColor):

852 853 854 855 856 857 858 859
2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>

        Unreviewed. Build fix for GTK when using gtk+-3 after r75009.

        * platform/gtk/RenderThemeGtk3.cpp:
        (WebCore::RenderThemeGtk::getStockIcon): Use adoptGRef instead of
        adoptGRefPtr which doesn't exist.

860 861 862 863 864 865 866 867 868
2011-01-05  Alexey Proskuryakov  <ap@apple.com>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=51903
        Tell UI process which subframe is largest

        * WebCore.exp.in: Exported FrameView::contentsSize().

869 870 871 872 873 874 875 876 877 878
2011-01-04  Chris Fleizach  <cfleizach@apple.com>

        Unreviewed. GTK build fix.

        WK2: Support Accessibility
        https://bugs.webkit.org/show_bug.cgi?id=51859

        * page/FrameView.cpp:
        (WebCore::FrameView::axObjectCache):

879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899
2011-01-04  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r74992.
        http://trac.webkit.org/changeset/74992
        https://bugs.webkit.org/show_bug.cgi?id=51917

        Crash in HTMLDocumentParser::suspendScheduledTasks()
        (Requested by tkent on #webkit).

        * dom/DocumentParser.cpp:
        * dom/DocumentParser.h:
        * html/parser/HTMLDocumentParser.cpp:
        * html/parser/HTMLDocumentParser.h:
        * html/parser/HTMLParserScheduler.cpp:
        (WebCore::HTMLParserScheduler::HTMLParserScheduler):
        * html/parser/HTMLParserScheduler.h:
        (WebCore::HTMLParserScheduler::isScheduledForResume):
        * page/PageGroupLoadDeferrer.cpp:
        (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
        (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):

900 901 902 903 904 905 906 907 908 909 910 911 912 913
2011-01-04  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] [WK2] Add support for non-trivial context menu action
        https://bugs.webkit.org/show_bug.cgi?id=51902

        Fix the preprocessor guard for ContextMenuItemTagSelectAll in
        the implementation of ContextMenuController::contextMenuItemSelected(). The guard was
        inconsistent with what is defined in ContextMenuItem.h.

        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::contextMenuItemSelected):

914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937
2011-01-04  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Ryosuke Niwa.

        Avoid manual ref/deref in AsyncScriptRunner by using PendingScript
        https://bugs.webkit.org/show_bug.cgi?id=51723

        ScriptElement should also be able to keep its Element+CachedScript in
        a PendingScript, and then executeScriptSoon can accept a PendingScript.
        Once HTMLScriptRunner, ScriptElement, and AsyncScriptRunner all use
        PendingScripts, then generic request and execute which operate on
        PendingScripts can be factored out to avoid code duplicate that we have.

        No new tests because no new functionality.

        * dom/AsyncScriptRunner.cpp:
        (WebCore::AsyncScriptRunner::~AsyncScriptRunner):
        (WebCore::AsyncScriptRunner::executeScriptSoon):
        (WebCore::AsyncScriptRunner::timerFired):
        * dom/AsyncScriptRunner.h:
        * dom/PendingScript.h: Add ctor which sets element and cachedScript. Rename adoptElement->setElement.
        * dom/HTMLScriptRunner.cpp:
        (WebCore::HTMLScriptRunner::requestPendingScript):

938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961
2011-01-04  Jeff Miller  <jeffm@apple.com>

        Reviewed by Darin Adler.

        Member variable and method naming cleanup to be consistent with WebKit2.
        https://bugs.webkit.org/show_bug.cgi?id=51228

        * page/win/EventHandlerWin.cpp:
        (WebCore::EventHandler::eventActivatedView):
        Rename activatedWebView() to didActivateWebView().
        
        * platform/PlatformMouseEvent.h:
        Rename m_activatedWebView to m_didActivateWebView.
        
        (WebCore::PlatformMouseEvent::PlatformMouseEvent):
        Initialize platform-specific member variables in PlatformMouseEvent constructors.
        
        (WebCore::PlatformMouseEvent::didActivateWebView):
        Rename activatedWebView() to didActivateWebView().

        * platform/win/PlatformMouseEventWin.cpp:
        (WebCore::PlatformMouseEvent::PlatformMouseEvent):
        Rename m_activatedWebView to m_didActivateWebView.

962 963 964 965 966 967 968 969 970 971 972 973 974
2011-01-04  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Darin Adler.

        CSS3 :nth-child selector and valid whitespace test fails
        https://bugs.webkit.org/show_bug.cgi?id=36279

        Teach the tokenizer to allow white spaces around [+/-] signs in nth constructs.

        Test: fast/css/css3-nth-space.html

        * css/tokenizer.flex:

cfleizach@apple.com's avatar
cfleizach@apple.com committed
975 976 977 978 979 980 981 982 983 984
2011-01-04  Chris Fleizach  <cfleizach@apple.com>

        Unreviewed. Build fix.

        WK2: Support Accessibility
        https://bugs.webkit.org/show_bug.cgi?id=51859

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (fallbackObject):

985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002
2011-01-04  Cosmin Truta  <ctruta@chromium.org>

        Reviewed by Eric Seidel.

        [chromium] PNG compression settings optimized for speed
        https://bugs.webkit.org/show_bug.cgi?id=51719

        Although Z_HUFFMAN_ONLY is the fastest on hard-to-compress images,
        it is also the slowest, by a wide margin, on easy-to-compress images.
        Use a more balanced configuration, based on the libpng compression defaults,
        but with a faster compression level (3 instead of 6), and a faster filter
        ("sub" instead of "all").

        No change in behaviour, so no new tests.

        * platform/image-encoders/skia/PNGImageEncoder.cpp:
        (WebCore::PNGImageEncoder::encode):

1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120
2011-01-04  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Sam Weinig.

        WK2: Support Accessibility
        https://bugs.webkit.org/show_bug.cgi?id=51859

        WK2 doesn't use platform scroll views anymore. Accessibility code
        needs to have its own scroll views. 

        Test: platform/mac/accessibility/webkit-scrollarea.html

        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.exp.in:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * accessibility/AXObjectCache.cpp:
        (WebCore::AXObjectCache::AXObjectCache):
        (WebCore::AXObjectCache::get):
        (WebCore::AXObjectCache::getOrCreate):
        (WebCore::AXObjectCache::rootObject):
        (WebCore::AXObjectCache::remove):
        (WebCore::AXObjectCache::handleScrollbarUpdate):
        * accessibility/AXObjectCache.h:
        (WebCore::AXObjectCache::handleScrollbarUpdate):
        * accessibility/AccessibilityARIAGrid.h:
        * accessibility/AccessibilityAllInOne.cpp:
        * accessibility/AccessibilityImageMapLink.cpp:
        * accessibility/AccessibilityImageMapLink.h:
        * accessibility/AccessibilityListBoxOption.cpp:
        * accessibility/AccessibilityListBoxOption.h:
        * accessibility/AccessibilityObject.cpp:
        (WebCore::AccessibilityObject::updateChildrenIfNecessary):
        (WebCore::AccessibilityObject::elementAccessibilityHitTest):
        (WebCore::AccessibilityObject::axObjectCache):
        (WebCore::AccessibilityObject::focusedUIElement):
        * accessibility/AccessibilityObject.h:
        (WebCore::AccessibilityObject::isAccessibilityScrollView):
        (WebCore::AccessibilityObject::isScrollView):
        (WebCore::AccessibilityObject::canSetNumericValue):
        (WebCore::AccessibilityObject::scrollBar):
        (WebCore::AccessibilityObject::size):
        (WebCore::AccessibilityObject::setValue):
        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::parentObject):
        (WebCore::AccessibilityRenderObject::accessibilityHitTest):
        (WebCore::AccessibilityRenderObject::updateChildrenIfNecessary):
        (WebCore::AccessibilityRenderObject::addChildren):
        * accessibility/AccessibilityRenderObject.h:
        * accessibility/AccessibilityScrollView.cpp: Added.
        (WebCore::AccessibilityScrollView::AccessibilityScrollView):
        (WebCore::AccessibilityScrollView::create):
        (WebCore::AccessibilityScrollView::scrollBar):
        (WebCore::AccessibilityScrollView::children):
        (WebCore::AccessibilityScrollView::updateChildrenIfNecessary):
        (WebCore::AccessibilityScrollView::removeChildScrollbar):
        (WebCore::AccessibilityScrollView::addChildScrollbar):
        (WebCore::AccessibilityScrollView::addChildren):
        (WebCore::AccessibilityScrollView::webAreaObject):
        (WebCore::AccessibilityScrollView::accessibilityHitTest):
        (WebCore::AccessibilityScrollView::document):
        (WebCore::AccessibilityScrollView::elementRect):
        (WebCore::AccessibilityScrollView::parentObject):
        * accessibility/AccessibilityScrollView.h: Added.
        (WebCore::AccessibilityScrollView::roleValue):
        (WebCore::AccessibilityScrollView::scrollView):
        (WebCore::AccessibilityScrollView::accessibilityIsIgnored):
        (WebCore::AccessibilityScrollView::isAccessibilityScrollView):
        (WebCore::toAccessibilityScrollView):
        * accessibility/AccessibilityScrollbar.cpp:
        (WebCore::AccessibilityScrollbar::AccessibilityScrollbar):
        (WebCore::AccessibilityScrollbar::create):
        (WebCore::AccessibilityScrollbar::elementRect):
        (WebCore::AccessibilityScrollbar::document):
        (WebCore::AccessibilityScrollbar::orientation):
        (WebCore::AccessibilityScrollbar::isEnabled):
        (WebCore::AccessibilityScrollbar::valueForRange):
        (WebCore::AccessibilityScrollbar::setValue):
        * accessibility/AccessibilityScrollbar.h:
        (WebCore::AccessibilityScrollbar::setParent):
        (WebCore::AccessibilityScrollbar::canSetValueAttribute):
        (WebCore::AccessibilityScrollbar::canSetNumericValue):
        (WebCore::AccessibilityScrollbar::isAccessibilityScrollbar):
        (WebCore::AccessibilityScrollbar::parentObject):
        (WebCore::AccessibilityScrollbar::roleValue):
        * accessibility/mac/AccessibilityObjectMac.mm:
        (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
        * accessibility/mac/AccessibilityObjectWrapper.mm:
        (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
        (-[AccessibilityObjectWrapper remoteAccessibilityParentObject]):
        (-[AccessibilityObjectWrapper position]):
        (-[AccessibilityObjectWrapper scrollViewParent]):
        (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
        (-[AccessibilityObjectWrapper accessibilityHitTest:]):
        (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
        * dom/Document.cpp:
        (WebCore::Document::axObjectCache):
        * loader/EmptyClients.h:
        (WebCore::EmptyFrameLoaderClient::accessibilityRemoteObject):
        * loader/FrameLoaderClient.h:
        * page/FrameView.cpp:
        (WebCore::FrameView::~FrameView):
        (WebCore::FrameView::axObjectCache):
        * page/FrameView.h:
        * platform/ScrollView.cpp:
        (WebCore::ScrollView::setHasHorizontalScrollbar):
        (WebCore::ScrollView::setHasVerticalScrollbar):
        * platform/Scrollbar.cpp:
        (WebCore::Scrollbar::~Scrollbar):
        (WebCore::Scrollbar::scroll):
        (WebCore::Scrollbar::axObjectCache):
        * platform/Scrollbar.h:
        * platform/Widget.h:
        (WebCore::Widget::axObjectCache):

1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142
2011-01-04  W. James MacLean  <wjmaclean@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Add support to compositor to composite to offscreen texture.
        https://bugs.webkit.org/show_bug.cgi?id=50833

        A patch to extend compositor to be able to composite into an offscreen texture instead
        of just directly to the display buffer. Builds on RenderSurfaceChromium support.
        Explicitly resets alpha channel before rendering to display.

        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::LayerRendererChromium):
        (WebCore::LayerRendererChromium::updateAndDrawRootLayer):
        (WebCore::LayerRendererChromium::drawLayers):
        (WebCore::LayerRendererChromium::setCompositeOffscreen):
        (WebCore::LayerRendererChromium::useRenderSurface):
        (WebCore::LayerRendererChromium::setScissorToRect):
        * platform/graphics/chromium/LayerRendererChromium.h:
        (WebCore::LayerRendererChromium::isCompositingOffscreen):
        (WebCore::LayerRendererChromium::getOffscreenLayerTexture):

1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155
2011-01-04  Evan Martin  <evan@chromium.org>

        Reviewed by Tony Chang.

        [chromium] depend on harfbuzz explicitly
        https://bugs.webkit.org/show_bug.cgi?id=51895

        platform/graphics/chromium uses Harfbuzz directly.  Rather than
        expecting Skia to adjust the include paths, be explicit about
        the dependency.

        * WebCore.gyp/WebCore.gyp:

1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176
2011-01-04  Darin Adler  <darin@apple.com>

        Reviewed by Brady Eidson.

        Add back/forward encoding and decoding to WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=51901

        * WebCore.exp.in: Export functions used in WebKit2.

        * history/HistoryItem.cpp:
        (WebCore::HistoryItem::encodeBackForwardTree): Use references instead of pointers.
        (WebCore::HistoryItem::encodeBackForwardTreeNode): Ditto.
        (WebCore::HistoryItem::decodeBackForwardTree): Ditto.
        * history/HistoryItem.h: Ditto.
        * platform/network/FormData.cpp:
        (WebCore::encode): Ditto.
        (WebCore::decode): Ditto.
        (WebCore::FormData::encodeForBackForward): Ditto.
        (WebCore::FormData::decodeForBackForward): Ditto.
        * platform/network/FormData.h: Ditto.

1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193
2011-01-04  Xiaomei Ji  <xji@chromium.org>

        Reviewed by Dan Bernstein.

        Implement sel.modify('move', 'left'/'right', 'lineBoundary').
        https://bugs.webkit.org/show_bug.cgi?id=33435

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::modifyMovingRight):
        (WebCore::SelectionController::modifyMovingLeft):
        * editing/visible_units.cpp:
        (WebCore::logicalStartOfLine):
        (WebCore::logicalEndOfLine):
        (WebCore::leftBoundaryOfLine):
        (WebCore::rightBoundaryOfLine):
        * editing/visible_units.h:

1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212
2011-01-04  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Use the default CSS text input control border width of relying on the GTK+ theme
        https://bugs.webkit.org/show_bug.cgi?id=51887

        Do not rely on the GTK+ theme to determine text control borders. This simplifies
        the RenderTheme code, prevents metrics differences between GTK+ 2.x and 3.x and
        doesn't break the rendering of any theme that I've encountered.

        * platform/gtk/RenderThemeGtk.cpp:
        (WebCore::RenderThemeGtk::adjustSearchFieldStyle): No longer call setTextInputBorders, but
        still disable any border radius.
        * platform/gtk/RenderThemeGtk.h: Remove setTextInputBorders and no longer override the
        default style of text areas and text input controls.
        * platform/gtk/RenderThemeGtk2.cpp: Ditto.
        * platform/gtk/RenderThemeGtk3.cpp: Ditto.

1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224
2011-01-03  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Darin Adler.

        Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
        https://bugs.webkit.org/show_bug.cgi?id=51846

        No new tests. This should not introduce any functional changes.

        Changed all references to PlatformRefPtr in GTK+ code to GRefPtr. Changed
        all references to PlatformRefPtr in Brew code to RefPtr.

1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239
2011-01-04  David Kilzer  <ddkilzer@apple.com>

        <http://webkit.org/b/51890> Move ResourceLoadPriority.h into WebCore/platform/network

        Reviewed by Antti Koivisto.

        This is needed to prevent a WebCore/platform policy violation in
        my next patch.

        * WebCore.gypi: Updated for moved header.
        * WebCore.pro: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * platform/network/ResourceLoadPriority.h: Renamed from WebCore/loader/ResourceLoadPriority.h.

1240 1241 1242 1243 1244 1245
2011-01-04  Brady Eidson  <beidson@apple.com>

        Reviewed by a spell checker.

        * storage/StorageMap.h: mesured?  Really?

1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272
2011-01-04  Carlos Garcia Campos  <cgarcia@igalia.com> and Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Port stock icon painting to GtkStyleContext
        https://bugs.webkit.org/show_bug.cgi?id=51764

        Port stock icon painting for media and search input elements to
        GtkStyleContext. Also create the initial machinery for accessing
        style contexts for all GTK+ 3.x based widgets.

        No new tests. This should not change functionality.

        * platform/gtk/RenderThemeGtk.cpp:
        (WebCore::paintGdkPixbuf):
        (WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration):
        (WebCore::RenderThemeGtk::paintSearchFieldCancelButton):
        (WebCore::RenderThemeGtk::paintMediaButton):
        * platform/gtk/RenderThemeGtk.h:
        * platform/gtk/RenderThemeGtk2.cpp:
        (WebCore::RenderThemeGtk::getStockIcon):
        * platform/gtk/RenderThemeGtk3.cpp:
        (WebCore::gtkStyleChangedCallback):
        (WebCore::styleContextMap):
        (WebCore::getStyleContext):
        (WebCore::RenderThemeGtk::paintMenuList):

1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302
2010-12-31  Antti Koivisto  <antti@apple.com>

        Reviewed by Dave Hyatt.

        Scripts should not be executed before preceding stylesheets are loaded
        https://bugs.webkit.org/show_bug.cgi?id=8852

        Block inline script execution on pending stylesheet loads. This matches
        other browsers and HTML5.

        Tests: fast/tokenizer/inline-script-stylesheet-write.html
               fast/tokenizer/inline-script-stylesheet.html

        * dom/PendingScript.cpp:
        (WebCore::PendingScript::releaseElementAndClear):
        * dom/PendingScript.h:
        (WebCore::PendingScript::PendingScript):
        (WebCore::PendingScript::operator=):
        (WebCore::PendingScript::startingPosition):
        (WebCore::PendingScript::setStartingPosition):
        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::process):
        
        This fixes an unrelated bug with beforeload events that was exposed by the other
        changes (fast/dom/beforeload/remove-link-in-beforeload-listener.html).
        
        * html/parser/HTMLScriptRunner.cpp:
        (WebCore::HTMLScriptRunner::sourceFromPendingScript):
        (WebCore::HTMLScriptRunner::runScript):

1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325
2011-01-04  Xianzhu Wang  <wangxianzhu@google.com>

        Reviewed by Darin Adler.

        Let DataView.getInt8() and DataView.setInt8() use int8_t instead of
        ambiguous 'char' to fix fast/canvas/webgl/data-view-test.html failure
        on ARM.
        https://bugs.webkit.org/show_bug.cgi?id=51861

        By the way, changed other getIntXX() and setIntXX() methods to use
        more precise integer types.

        * bindings/js/JSDataViewCustom.cpp:
        (WebCore::setDataViewMember):
        * bindings/v8/custom/V8DataViewCustom.cpp:
        (WebCore::V8DataView::getInt8Callback):
        (WebCore::V8DataView::setInt8Callback):
        * html/canvas/DataView.cpp:
        (WebCore::DataView::getInt8):
        (WebCore::DataView::setInt8):
        * html/canvas/DataView.h:
        * html/canvas/DataView.idl:

1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355
2011-01-04  Yong Li  <yoli@rim.com>

        Reviewed by Adam Barth.

        Suspend HTMLParserScheduler when page load is deferred to
        avoid potential JS re-entrancy. Otherwise, when JS execution is triggered
        from an external script or by events, and is blocked by a modal dialog,
        WebKit can parse more HTML source and also start another JS execution.
        
        https://bugs.webkit.org/show_bug.cgi?id=48077

        Test case: WebCore/manual-tests/bugzilla-48077.html.

        * dom/DocumentParser.cpp:
        (WebCore::DocumentParser::suspendScheduledTasks):
        (WebCore::DocumentParser::resumeScheduledTasks):
        * dom/DocumentParser.h:
        * html/parser/HTMLDocumentParser.cpp:
        (WebCore::HTMLDocumentParser::suspendScheduledTasks):
        (WebCore::HTMLDocumentParser::resumeScheduledTasks):
        * html/parser/HTMLParserScheduler.cpp:
        (WebCore::HTMLParserScheduler::HTMLParserScheduler):
        (WebCore::HTMLParserScheduler::suspend):
        (WebCore::HTMLParserScheduler::resume):
        * html/parser/HTMLParserScheduler.h:
        (WebCore::HTMLParserScheduler::isScheduledForResume):
        * page/PageGroupLoadDeferrer.cpp:
        (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
        (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):

1356 1357 1358 1359 1360 1361 1362 1363 1364
2011-01-04  Tony Gentilcore  <tonyg@chromium.org>

        Unreviewed build fix.

        Include glib-object.h for GObject
        https://bugs.webkit.org/show_bug.cgi?id=51876

        * bindings/gobject/DOMObjectCache.cpp:

1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379
2011-01-04  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Dan Bernstein.

        Clicking on the first or the last letter of LTR/RTL text in a RTL/LTR block puts caret on the opposite side.
        https://bugs.webkit.org/show_bug.cgi?id=50992

        Fixed the bug by interchanging the offset when the direction of inline text box and the containing block
        does not match. Reused the code added by http://trac.webkit.org/changeset/73553.

        Test: editing/selection/caret-bidi-first-and-last-letters.html

        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::offsetForPosition):

1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401
2010-12-29  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Darin Adler.

        Remove 2 unnecessary includes from Document.h
        https://bugs.webkit.org/show_bug.cgi?id=51727

        No new tests because no changed functionality.

        * dom/Document.cpp:
        * dom/Document.h:
        * editing/Editor.cpp:
        * editing/SpellChecker.h:
        * editing/SplitTextNodeCommand.cpp:
        * editing/TextCheckingHelper.cpp:
        * page/FrameView.cpp:
        * page/Page.cpp:
        * rendering/HitTestResult.cpp:
        * rendering/InlineTextBox.cpp:
        * rendering/InlineTextBox.h:
        * rendering/svg/SVGInlineFlowBox.cpp:

1402 1403 1404 1405 1406 1407
2011-01-04  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed WinCE build fix.

        * CMakeListsWinCE.txt: Added missing include directories, files and libraries.

1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422
2011-01-04  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Simon Hausmann.

        Provide an interface to require using fullscreen mediaplayer
        https://bugs.webkit.org/show_bug.cgi?id=51133

        Only video should be displayed in fullscreen when 
        requiresFullscreenForVideoPlayback is specified.

        No new tests because no client implements requiresFullscreenForVideoPlayback yet.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::updatePlayState):

1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435
2011-01-04  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] [WK2] create an initial implementation of the context menu handling for WebKit 2
        https://bugs.webkit.org/show_bug.cgi?id=51825

        Implement contextMenuItemVector() for Qt, this method is used in WebKit 2 to get the
        platform independent menu informations.

        * platform/qt/ContextMenuQt.cpp:
        (WebCore::contextMenuItemVector):

1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447
2011-01-04  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r74960.
        http://trac.webkit.org/changeset/74960
        https://bugs.webkit.org/show_bug.cgi?id=51868

        Rollout since we hit an assert after this patch. (Requested by
        krit on #webkit).

        * svg/SVGUseElement.cpp:
        (WebCore::SVGUseElement::buildInstanceTree):

1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459
2011-01-04  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r74961.
        http://trac.webkit.org/changeset/74961
        https://bugs.webkit.org/show_bug.cgi?id=51867

        breaks 32/64-bits debug bots build (Requested by philn-tp on
        #webkit).

        * platform/graphics/gstreamer/GStreamerGWorld.cpp:
        (WebCore::GStreamerGWorld::setWindowOverlay):

1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475
2011-01-03  Philippe Normand  <pnormand@igalia.com>

        Rubber-stamped by Eric Seidel.

        [GStreamer] build fails with gstreamer core 0.10.31 and -plugins-base 0.10.30
        https://bugs.webkit.org/show_bug.cgi?id=51810

        Based on a patch by Mart Raudsepp.

        No new tests, build fix only.

        * platform/graphics/gstreamer/GStreamerGWorld.cpp:
        (WebCore::GStreamerGWorld::setWindowOverlay): Use the new xoverlay
        API if the GST_CHECK_PLUGINS_BASE_VERSION macro is defined. It was
        introduced in same version as the xoverlay API change.

1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492
2011-01-04  Leo Yang  <leo.yang@torchmobile.com.cn>

        Reviewed by Dirk Schulze.

        Malformed SVG causes crash in updateContainerOffset
        https://bugs.webkit.org/show_bug.cgi?id=44610

        We should check recursive <use> at the begining of
        WebCore::SVGUseElement::buildInstanceTree instead
        of at the end of it because the target element's
        children may cause infinite recursive <use>.

        Test: svg/custom/recursive-use.svg

        * svg/SVGUseElement.cpp:
        (WebCore::SVGUseElement::buildInstanceTree):

1493 1494 1495 1496 1497 1498 1499 1500 1501 1502
2011-01-04  Kent Tamura  <tkent@chromium.org>

        Unreviewed, build fix.

        Try to fix Clang build.

        * css/CSSParser.cpp:
        (WebCore::valueFromSideKeyword):
        (WebCore::CSSParser::parseLinearGradient):

1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517
2011-01-03  Julie-Jeongeun-Kim  <Jeongeun.Kim@obigo.com>

        Reviewed by Darin Adler.

        HTML5 Conformance Test failure: approved/xhtml5/object_border_pixel.xhtml
        https://bugs.webkit.org/show_bug.cgi?id=48596
        
        border attribute was not parsed in HTMLObjectElement.
        I added code for it as HTMLImageElement handled.

        new test:fast/html/object-border.html

        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::parseMappedAttribute):

darin@apple.com's avatar
darin@apple.com committed
1518 1519 1520 1521 1522 1523 1524 1525 1526
2011-01-03  Darin Adler  <darin@apple.com>

        Try to fix Chromium build.

        * history/HistoryItem.cpp:
        (WebCore::HistoryItem::encodeBackForwardTreeNode): Added a V8 case here.
        Not sure this ever will be used with V8.
        (WebCore::HistoryItem::decodeBackForwardTree): Ditto.

darin@apple.com's avatar
darin@apple.com committed
1527 1528 1529 1530 1531 1532 1533 1534
2011-01-03  Darin Adler  <darin@apple.com>

        Try to fix Leopard build.

        * history/HistoryItem.cpp: Use a consistent type, uint64_t, for the
        size variable.

2011-01-03  Abhishek Arya  <inferno@chromium.org>
1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557

        Reviewed by Darin Adler.

        Fixes before child calculation when adding anonymous childs to table parts.
        https://bugs.webkit.org/show_bug.cgi?id=50932

        Fix in r74364 was incomplete. When before child is equal to the table part(to
        which the new child is getting added), it confuses the table part to add it
        incorrectly as an after child. The patch fixes by passing the before child as
        the table part's first child.

        Tests: fast/css-generated-content/table-before-after-child-add.html
               fast/css-generated-content/table-cell-before-after-child-add.html
               fast/css-generated-content/table-row-before-after-child-add.html
               fast/css-generated-content/table-row-before-after-child-add.html

        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::addChild):
        * rendering/RenderTableRow.cpp:
        (WebCore::RenderTableRow::addChild):
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::addChild):

mitz@apple.com's avatar
mitz@apple.com committed
1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569
2011-01-03  Dan Bernstein  <mitz@apple.com>

        Reviewed by Simon Fraser.

        Shrink HTMLTableCellElement
        https://bugs.webkit.org/show_bug.cgi?id=51858

        * html/HTMLTableCellElement.cpp:
        (WebCore::HTMLTableCellElement::HTMLTableCellElement): Removed intialization of m_row and
        m_col.
        * html/HTMLTableCellElement.h: Removed m_row and m_col and their accessors.

darin@apple.com's avatar
darin@apple.com committed
1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584
2011-01-03  Darin Adler  <darin@apple.com>

        Fix build.

        * platform/network/FormData.cpp:
        (WebCore::FormData::create): Roll back uint8_t change.
        (WebCore::FormData::flatten): Ditto.
        (WebCore::FormData::flattenToString): Ditto.
        (WebCore::encode): Ditto.
        (WebCore::decode): Ditto.
        (WebCore::FormData::encodeForBackForward):
        * platform/network/FormData.h: Ditto.
        * platform/network/mac/FormDataStreamMac.mm:
        (WebCore::advanceCurrentStream): Ditto.

1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611
2011-01-03  Darin Adler  <darin@apple.com>

        Reviewed by Brady Eidson.

        Add code to encode/decode the back/forward tree
        https://bugs.webkit.org/show_bug.cgi?id=51853

        * history/HistoryItem.cpp:
        (WebCore::HistoryItem::encodeBackForwardTree): Added.
        (WebCore::HistoryItem::encodeBackForwardTreeNode): Added.
        (WebCore::HistoryItem::decodeBackForwardTree): Added.
        * history/HistoryItem.h: Added functions above.

        * platform/network/FormData.cpp:
        (WebCore::FormData::create): Changed type to Vector<uint8_t> instead of
        Vector<char>. This type is used in our newer code for vectors of bytes.
        (WebCore::FormData::flatten): Ditto.
        (WebCore::FormData::flattenToString): Ditto. Had to add a cast here.
        (WebCore::FormData::encodeForBackForward): Added.
        (WebCore::FormData::decodeForBackForward): Added.
        * platform/network/FormData.h: Changed type to Vector<uint8_t> instead of
        Vector<char>. Also made some single-argument constructors explicit.
        Also added the new functions.

        * platform/network/mac/FormDataStreamMac.mm:
        (WebCore::advanceCurrentStream): Changed to use uint8_t to match above.

1612 1613 1614 1615 1616 1617 1618
2011-01-03  Simon Fraser  <simon.fraser@apple.com>

        Attempt to fix GTK build.

        * platform/graphics/gtk/FontGtk.cpp:
        (WebCore::drawGlyphsShadow):

1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662
2011-01-03  Helder Correia  <helder@sencha.com>

        Reviewed by Simon Fraser.

        ContextShadow can avoid code duplication for getting the CTM
        https://bugs.webkit.org/show_bug.cgi?id=51799

        ContextShadow defines its own getTransformationMatrixFromContext()
        which does exactly the same as GraphicsContext::getCTM().

        Existing tests: fast/canvas/canvas*shadow*html

        * platform/graphics/ContextShadow.cpp:
        (WebCore::ContextShadow::mustUseContextShadow):
        (WebCore::ContextShadow::adjustBlurDistance):
        (WebCore::ContextShadow::calculateLayerBoundingRect):
        * platform/graphics/ContextShadow.h:
        * platform/graphics/cairo/ContextShadowCairo.cpp:
        (WebCore::ContextShadow::beginShadowLayer):
        (WebCore::ContextShadow::endShadowLayer):
        (WebCore::ContextShadow::drawRectShadowWithoutTiling):
        * platform/graphics/cairo/FontCairo.cpp:
        (WebCore::drawGlyphsShadow):
        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        (WebCore::drawPathShadow):
        * platform/graphics/cairo/ImageCairo.cpp:
        (WebCore::BitmapImage::draw):
        * platform/graphics/gtk/FontGtk.cpp:
        (WebCore::drawGlyphsShadow):
        * platform/graphics/qt/ContextShadowQt.cpp:
        (WebCore::ContextShadow::beginShadowLayer):
        (WebCore::ContextShadow::endShadowLayer):
        * platform/graphics/qt/FontQt.cpp:
        (WebCore::drawTextCommon):
        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::strokePath):
        (WebCore::GraphicsContext::fillRect):
        (WebCore::GraphicsContext::fillRoundedRect):
        * platform/graphics/qt/ImageQt.cpp:
        (WebCore::BitmapImage::draw):
        * platform/graphics/qt/StillImageQt.cpp:
        (WebCore::StillImage::draw):

1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675
2011-01-03  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        InsertTextCommand::m_charactersAdded is unused
        https://bugs.webkit.org/show_bug.cgi?id=51849

        * editing/InsertTextCommand.cpp:
        (WebCore::InsertTextCommand::InsertTextCommand): Don't initialize m_charactersAdded.
        (WebCore::InsertTextCommand::input): Don't update m_charactersAdded.
        * editing/InsertTextCommand.h: Removed charactersAdded function and
        m_charactersAdded data member.

1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691
2011-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Move paintMenuListButton() to RenderThemeGtk.cpp
        https://bugs.webkit.org/show_bug.cgi?id=51832

        Method paintMenuListButton() contains code common to both gtk 2
        and 3, so it can be moved to RenderThemeGtk.cpp instead of
        duplicating it.

        * platform/gtk/RenderThemeGtk.cpp:
        (WebCore::RenderThemeGtk::paintMenuListButton):
        * platform/gtk/RenderThemeGtk2.cpp:
        * platform/gtk/RenderThemeGtk3.cpp:

1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732
2011-01-03  Pratik Solanki  <psolanki@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=51850
        Put CFNetwork loader code inside USE(CFNETWORK)

        Add USE(CFNETWORK) macros around all the cf/mac network files. Also added all CFNetwork
        files to the WebCore Xcode project.

        * WebCore.xcodeproj/project.pbxproj:
        * loader/cf/ResourceLoaderCFNet.cpp:
        * loader/mac/ResourceLoaderMac.mm:
        * platform/network/cf/AuthenticationCF.cpp:
        * platform/network/cf/AuthenticationCF.h:
        * platform/network/cf/CookieJarCFNet.cpp:
        * platform/network/cf/CookieStorageCFNet.cpp:
        * platform/network/cf/CookieStorageCFNet.h:
        * platform/network/cf/CredentialStorageCFNet.cpp:
        * platform/network/cf/FormDataStreamCFNet.cpp:
        * platform/network/cf/FormDataStreamCFNet.h:
        * platform/network/cf/LoaderRunLoopCF.cpp:
        * platform/network/cf/LoaderRunLoopCF.h:
        * platform/network/cf/ResourceError.h:
        * platform/network/cf/ResourceHandleCFNet.cpp:
        * platform/network/cf/ResourceRequest.h:
        * platform/network/cf/ResourceRequestCFNet.cpp:
        * platform/network/cf/ResourceRequestCFNet.h:
        * platform/network/cf/ResourceResponse.h:
        * platform/network/cf/ResourceResponseCFNet.cpp:
        * platform/network/mac/AuthenticationMac.h:
        * platform/network/mac/AuthenticationMac.mm:
        * platform/network/mac/FormDataStreamMac.h:
        * platform/network/mac/FormDataStreamMac.mm:
        * platform/network/mac/ResourceError.h:
        * platform/network/mac/ResourceHandleMac.mm:
        * platform/network/mac/ResourceRequest.h:
        * platform/network/mac/ResourceRequestMac.mm:
        * platform/network/mac/ResourceResponse.h:
        * platform/network/mac/ResourceResponseMac.mm:

1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749
2011-01-03  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Adam Barth.

        [Qt] Add SelectAll option to the context menu for the editor
        https://bugs.webkit.org/show_bug.cgi?id=50049

        Enable SelectAll for the Qt context menu.

        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::populate):
        * platform/ContextMenuItem.h:
        * platform/LocalizationStrategy.h:
        * platform/LocalizedStrings.cpp:
        (WebCore::contextMenuItemTagSelectAll):
        * platform/LocalizedStrings.h:

mitz@apple.com's avatar
mitz@apple.com committed
1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763
2011-01-03  Dan Bernstein  <mitz@apple.com>

        Reviewed by Darin Adler.

        Shrink RootInlineBox
        https://bugs.webkit.org/show_bug.cgi?id=51847

        * rendering/RootInlineBox.cpp:
        (WebCore::RootInlineBox::alignBoxesInBlockDirection): Changed to use the baselineType()
        accessor.
        * rendering/RootInlineBox.h: Rolled m_baselineType into a bitfield. Changed its type to
        unsigned because otherwise MSVC treats it as signed.
        (WebCore::RootInlineBox::baselineType): Added a cast.

kov@webkit.org's avatar
kov@webkit.org committed
1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776
2011-01-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Martin Robinson.

        [GTK] Split webkitprivate.{cpp,h} in more manageable chunks
        https://bugs.webkit.org/show_bug.cgi?id=50698

        Fix DOM bindings generation to no longer include the now-gone
        webkitprivate.h header, including the appropriate replacements
        instead.

        * bindings/scripts/CodeGeneratorGObject.pm:

1777 1778 1779 1780 1781 1782 1783 1784 1785
2011-01-03  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler.

        Add Encode/Decode machinery Darin and I plan to work with for back/forward stuff in WebKit2.

        * ForwardingHeaders/wtf/Decoder.h: Added.
        * ForwardingHeaders/wtf/Encoder.h: Added.

1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799
2011-01-03  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Darin Adler.

        AX: Regression: WebKit no longer auto-scrolls with VoiceOver navigation
        https://bugs.webkit.org/show_bug.cgi?id=51833

        Make sure the web area returns the contentsSize, not the same size as what is displayed.

        Test: platform/mac/accessibility/webarea-size-equals-content-size.html

        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::boundingBoxRect):

1800 1801 1802 1803 1804 1805 1806
2011-01-03  Simon Fraser  <simon.fraser@apple.com>

        Fix warning in 32-bit builds.

        * css/CSSGradientValue.cpp:
        (WebCore::CSSLinearGradientValue::createGradient):

1807 1808 1809 1810 1811 1812 1813 1814 1815
2011-01-03  Benjamin C Meyer  <bmeyer@rim.com>

        Reviewed by Daniel Bates.

        In the cmake build system move logic related to ENABLE_NOTIFICATIONS into its own block.
        https://bugs.webkit.org/show_bug.cgi?id=51827

        * CMakeLists.txt:

1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826
2011-01-03  Dan Bernstein  <mitz@apple.com>

        Reviewed by Simon Fraser.

        Remove the unused RenderTableCell::m_percentageHeight
        https://bugs.webkit.org/show_bug.cgi?id=51837

        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::RenderTableCell): Removed initialization of m_percentageHeight.
        * rendering/RenderTableCell.h: Removed m_percentageHeight.

1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891
2011-01-03  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by David Hyatt.

        Implement -webkit-linear-gradient and -webkit-radial-gradient
        https://bugs.webkit.org/show_bug.cgi?id=28152

        Add support for -webkit-radial-gradients.

        Tests: fast/gradients/css3-radial-gradients.html
               fast/gradients/css3-radial-gradients2.html

        * css/CSSGradientValue.cpp:
        (WebCore::blend): Used to blend colors, which is necessary when truncating
        the start of radial gradients.
        (WebCore::GradientStop): Small struct to aid gradient stop processing.
        (WebCore::CSSGradientValue::addStops): Rename 'positions' to 'stops', and store
        the color so that we can blend it when truncating radial gradients. Changed
        to handle both linear and radial gradients.
        (WebCore::CSSRadialGradientValue::cssText): Update to follow the spec.
        (WebCore::CSSRadialGradientValue::resolveRadius): Stylistic change.
        (WebCore::distanceToClosestCorner): New utility method.
        (WebCore::distanceToFarthestCorner): Ditto.
        (WebCore::CSSRadialGradientValue::createGradient): New logic to deal with shape and
        fill rules.

        * css/CSSGradientValue.h:
        (WebCore::CSSGradientValue::isLinearGradient): Color-stop processing needs to know what
        kind of gradient it's dealing with, so add new isFooGradient methods.
        (WebCore::CSSGradientValue::isRadialGradient): Ditto.
        (WebCore::CSSLinearGradientValue::isLinearGradient):
        (WebCore::CSSRadialGradientValue::setShape): New setters for shape, size etc.
        (WebCore::CSSRadialGradientValue::setSizingBehavior):
        (WebCore::CSSRadialGradientValue::setEndHorizontalSize):
        (WebCore::CSSRadialGradientValue::setEndVerticalSize):
        (WebCore::CSSRadialGradientValue::isRadialGradient):

        * css/CSSParser.h:
        * css/CSSParser.h: Pass a CSSParserValueList* into parseFillPositionXY() and parseFillPosition()
        so we can use parseFillPosition() when parsing a gradient function.
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseFillPositionXY): Pass in a CSSParserValueList*
        (WebCore::CSSParser::parseFillPosition): Ditto
        (WebCore::CSSParser::parseFillProperty): Pass m_valueList to parseFillPosition.
        (WebCore::CSSParser::parseTransformOriginShorthand): Ditto
        (WebCore::CSSParser::parseRadialGradient): Flesh out radial gradient parsing.
        (WebCore::CSSParser::parseTransformOrigin): Pass m_valueList to parseFillPosition.
        (WebCore::CSSParser::parsePerspectiveOrigin): Ditto

        * css/CSSValueKeywords.in: New keywords for radial gradient shape and fill behaviors.

        * platform/graphics/Gradient.cpp:
        (WebCore::Gradient::Gradient): Pass aspect ratio for elliptical gradients.
        * platform/graphics/Gradient.h: Add aspect ratio for elliptical gradients.
        (WebCore::Gradient::create):
        (WebCore::Gradient::startRadius): Expose radii.
        (WebCore::Gradient::endRadius):
        (WebCore::Gradient::setStartRadius): Setters are required for when we need to scale color stops.
        (WebCore::Gradient::setEndRadius):
        (WebCore::Gradient::aspectRatio):
        * platform/graphics/cg/GradientCG.cpp:
        (WebCore::Gradient::paint): For elliptical gradients, scale the CTM.
        * platform/graphics/wince/GraphicsContextWinCE.cpp:
        (WebCore::GraphicsContext::fillRect): Use start/endRadius() rather than r0() and r1().

1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952
2011-01-03  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by David Hyatt.

        Implement -webkit-linear-gradient and -webkit-radial-gradient
        https://bugs.webkit.org/show_bug.cgi?id=28152
        
        Add support for the parsing and rendering of non-repeating CSS3 linear gradients,
        according to <http://dev.w3.org/csswg/css3-images/#linear-gradients>.

        Tests: fast/gradients/css3-color-stop-units.html
               fast/gradients/css3-color-stops.html
               fast/gradients/css3-gradient-parsing.html
               fast/gradients/css3-linear-angle-gradients.html

        * css/CSSGradientValue.h:
        Add subclasses of CSSGradientValue for linear and radial gradients.
        
        * css/CSSGradientValue.cpp:
        (WebCore::CSSGradientValue::image): Add FIXME comment about why we can't cache
        the gradient sometimes.
        (WebCore::compareStops): positions are CSSValues now.
        (WebCore::CSSGradientValue::sortStopsIfNeeded): Add assertion that this is only called
        for old-style gradients.
        (WebCore::CSSGradientValue::addStops): New method that handles the spec rules about
        missing positions, ensuring that stop position is ordered, and spacing out stops
        without positions. Also normalize gradients which use stops outside the 0-1 range
        so that platforms can render them correctly.
        (WebCore::positionFromValue): Determin the position on the gradient line for percentage,
        number and length values.
        (WebCore::CSSGradientValue::computeEndPoint):
        (WebCore::CSSLinearGradientValue::cssText):
        (WebCore::endPointsFromAngle): Compute endpoints for a gradient which covers the rectangle
        given an angle.
        (WebCore::CSSLinearGradientValue::createGradient):
        (WebCore::CSSRadialGradientValue::cssText):
        (WebCore::CSSRadialGradientValue::resolveRadius):
        (WebCore::CSSRadialGradientValue::createGradient):

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue): Style fix.
        (WebCore::CSSParser::parseContent): Use isGeneratedImageValue() and parseGeneratedImage()
        (WebCore::CSSParser::parseFillImage): Use isGeneratedImageValue() and parseGeneratedImage()
        (WebCore::CSSParser::parseBorderImage): Use isGeneratedImageValue() and parseGeneratedImage()
        (WebCore::parseDeprecatedGradientPoint): Renamed to indicate that it's only used for -webkit-gradient.
        (WebCore::parseDeprecatedGradientColorStop): Renamed to indicate that it's only used for -webkit-gradient,
        and fixed to store CSSValues for the stop position.
        (WebCore::CSSParser::parseDeprecatedGradient): Renamed to indicate that it's only used for -webkit-gradient,
        and create CSSLinearGradientValue and CSSRadialGradientValue as appropriate.
        (WebCore::valueFromSideKeyword):
        (WebCore::parseGradientColorOrKeyword): Color parsing utility.
        (WebCore::CSSParser::parseLinearGradient): New method to parse linear gradients.
        (WebCore::CSSParser::parseRadialGradient): Stub for new method to parse radial gradients.
        (WebCore::CSSParser::isGeneratedImageValue): Detect gradients and CSS canvas.
        (WebCore::CSSParser::parseGeneratedImage): Parser for generated images like gradients
        and CSS canvas.
        * css/CSSParser.h:
        * platform/graphics/Gradient.h:
        (WebCore::Gradient::setP0): We need to be able to change the points when normalizing gradients.
        (WebCore::Gradient::setP1): Ditto.

1953 1954 1955 1956 1957 1958 1959 1960 1961 1962 1963 1964 1965 1966 1967 1968 1969 1970 1971 1972
2011-01-03  Noam Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] document.getElementById(...) doesn't return the right object in combination with QGraphicsWidget
        https://bugs.webkit.org/show_bug.cgi?id=51464

        Added a way to bind any QObject created as a plugin to JavaScript, 
        by adding a custom member (qtObject) to WebCore::Widget. 
        Added a test to tst_qwebpage to make sure plugins created 
        as QGraphicsWidget are accessible through JavaScript.

        * bindings/js/ScriptControllerQt.cpp:
        (WebCore::ScriptController::createScriptInstanceForWidget):
        * platform/Widget.h:
        * platform/qt/WidgetQt.cpp:
        (WebCore::Widget::Widget):
        (WebCore::Widget::setBindingObject):
        (WebCore::Widget::bindingObject):

1973 1974 1975 1976 1977 1978 1979 1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990
2011-01-03  David Hyatt  <hyatt@apple.com>

        Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=51328

        Printing on a page with body { height: 100% } clips out the overflow contents.  This happened
        because the computePageRects function was never correct.  It was using the layer's width and height
        for the document's width and height, and the layer no longer includes overflow in its width and
        height.  It was also incorrectly assuming the first page would begin at (0,0), and this is an invalid
        assumption in RTL or vertical text environments.

        Added printing/page-count-percentage-height.html

        * page/PrintContext.cpp:
        (WebCore::PrintContext::computePageRects):
        (WebCore::PrintContext::computePageRectsWithPageSizeInternal):

1991 1992 1993 1994 1995 1996 1997
2011-01-03  Csaba Osztrogonác  <ossy@webkit.org>

        [Qt] Unreviewed buildfix for --minimal build after r74895.

        * html/InputType.cpp: Missing include added.
        * html/NumberInputType.cpp: Missing include added.

1998 1999 2000 2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 2017 2018 2019 2020 2021 2022 2023 2024 2025 2026 2027 2028 2029 2030 2031 2032 2033 2034 2035 2036 2037 2038 2039 2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 2051 2052 2053 2054 2055 2056 2057 2058 2059 2060 2061 2062 2063 2064 2065 2066 2067 2068 2069 2070 2071 2072 2073 2074 2075 2076 2077 2078 2079 2080 2081 2082 2083 2084 2085 2086 2087 2088 2089 2090 2091 2092 2093 2094 2095 2096 2097 2098 2099 2100 2101 2102 2103 2104 2105 2106 2107 2108 2109 2110 2111 2112 2113 2114 2115 2116 2117 2118 2119 2120 2121 2122 2123 2124 2125 2126 2127 2128 2129 2130 2131 2132 2133 2134 2135 2136 2137 2138 2139 2140 2141 2142 2143 2144 2145 2146 2147 2148 2149 2150 2151 2152 2153 2154 2155 2156 2157 2158 2159 2160 2161 2162 2163 2164 2165 2166 2167 2168 2169 2170 2171 2172 2173 2174 2175 2176 2177 2178 2179 2180 2181 2182 2183 2184 2185 2186 2187 2188 2189 2190 2191 2192 2193 2194 2195 2196 2197 2198 2199 2200 2201 2202 2203 2204 2205 2206 2207 2208 2209 2210 2211 2212 2213 2214 2215 2216 2217 2218 2219 2220 2221 2222 2223 2224 2225 2226 2227 2228 2229 2230 2231 2232 2233 2234 2235 2236 2237 2238 2239 2240 2241 2242 2243 2244 2245 2246 2247 2248 2249 2250 2251 2252 2253 2254 2255 2256 2257 2258 2259 2260 2261 2262 2263 2264 2265 2266 2267 2268 2269 2270 2271 2272 2273 2274 2275 2276 2277 2278 2279 2280 2281 2282 2283 2284 2285 2286 2287 2288 2289 2290 2291 2292 2293 2294 2295 2296 2297 2298 2299 2300 2301 2302 2303 2304 2305 2306 2307 2308 2309 2310 2311 2312 2313 2314 2315 2316 2317 2318 2319 2320 2321 2322 2323 2324 2325 2326 2327 2328 2329 2330 2331 2332 2333 2334 2335 2336 2337 2338 2339 2340 2341 2342 2343 2344 2345 2346 2347 2348 2349 2350 2351 2352 2353 2354 2355 2356 2357 2358 2359 2360 2361 2362 2363 2364 2365 2366 2367 2368 2369 2370 2371 2372 2373 2374 2375
2011-01-02  Darin Adler  <darin@apple.com>

        Reviewed by Kent Tamura.

        Eliminate HTMLInputElement::m_deprecatedTypeNumber, other input refactoring and renaming
        https://bugs.webkit.org/show_bug.cgi?id=51791

        * dom/InputElement.h: Make sanitizeValueForTextField public so it can
        be called by InputType.

        * html/BaseButtonInputType.cpp:
        (WebCore::BaseButtonInputType::accessKeyAction): Added.
        (WebCore::BaseButtonInputType::storesValueSeparateFromAttribute): Added.
        * html/BaseButtonInputType.h: Ditto.

        * html/BaseCheckableInputType.cpp:
        (WebCore::BaseCheckableInputType::canSetStringValue): Added.
        (WebCore::BaseCheckableInputType::accessKeyAction): Added.
        (WebCore::BaseCheckableInputType::fallbackValue): Added.
        (WebCore::BaseCheckableInputType::storesValueSeparateFromAttribute): Added.
        (WebCore::BaseCheckableInputType::isCheckable): Added.
        * html/BaseCheckableInputType.h: Ditto.

        * html/BaseDateAndTimeInputType.cpp:
        (WebCore::BaseDateAndTimeInputType::hasSpinButton): Added.
        * html/BaseDateAndTimeInputType.h: Ditto.

        * html/BaseTextInputType.h: Made more functions private.

        * html/ButtonInputType.cpp:
        (WebCore::ButtonInputType::isTextButton): Added.
        * html/ButtonInputType.h: Ditto.

        * html/CheckboxInputType.cpp:
        (WebCore::CheckboxInputType::willDispatchClick): Added.
        (WebCore::CheckboxInputType::didDispatchClick): Added.
        (WebCore::CheckboxInputType::isCheckbox): Added.
        * html/CheckboxInputType.h: Ditto.

        * html/DateTimeInputType.cpp:
        (WebCore::DateTimeInputType::scaledStepValueShouldBeInteger): Fixed
        typo in name of this function.
        * html/DateTimeInputType.h: Ditto.
        * html/DateTimeLocalInputType.cpp:
        (WebCore::DateTimeLocalInputType::scaledStepValueShouldBeInteger): Ditto.
        * html/DateTimeLocalInputType.h: Ditto.

        * html/EmailInputType.cpp:
        (WebCore::EmailInputType::isEmailField): Added.
        * html/EmailInputType.h: Ditto.

        * html/FileInputType.cpp:
        (WebCore::FileInputType::FileInputType): Added.
        (WebCore::FileInputType::canSetStringValue): Added.
        (WebCore::FileInputType::canChangeFromAnotherType): Added.
        (WebCore::FileInputType::files): Added.
        (WebCore::FileInputType::canSetValue): Added.
        (WebCore::FileInputType::getTypeSpecificValue): Added.
        (WebCore::FileInputType::storesValueSeparateFromAttribute): Added.
        (WebCore::FileInputType::setFileList): Added.
        (WebCore::FileInputType::isFileUpload): Added.
        * html/FileInputType.h: Ditto.

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::HTMLInputElement): Updated for data member
        renaming and removal.
        (WebCore::HTMLInputElement::isValidValue): Call canSetStringValue
        instead of checking specific type numbers.
        (WebCore::HTMLInputElement::getAllowedValueStepWithDecimalPlaces):
        Use fastGetAttribute and fixed typo in the name of the
        scaledStepValueShouldBeInteger function.
        (WebCore::HTMLInputElement::isKeyboardFocusable): Call
        InputType::isKeyboardFocusable; moved most of the type-specific
        logic there.
        (WebCore::HTMLInputElement::shouldUseInputMethod): Call
        InputType::shouldUseInputMethod; moved the type-specific logic there.
        (WebCore::HTMLInputElement::handleBlurEvent): Call
        InputType::handleBlurEvent; moved the type-specific logic there.
        (WebCore::HTMLInputElement::setType): Tweak the names and types
        in this function.
        (WebCore::HTMLInputElement::updateType): Removed the code that
        set m_deprecatedTypeNumber. Compare types by comparing the value
        from formControlType. Removed file-specific logic and instead call
        InputType::canChangeFromAnotherType. Streamlined the logic for
        activation callbacks.
        (WebCore::HTMLInputElement::accessKeyAction): Call
        InputType::accessKeyAction; moved the type-specific logic there.
        (WebCore::HTMLInputElement::mapToEntry): Call
        InputType::shouldRespectHeightAndWidthAttributes and
        InputType::shouldRespectAlignAttribute.
        (WebCore::HTMLInputElement::parseMappedAttribute): Updated
        for name changes and the removal of m_defaultChecked. Changed the
        alt attribute logic to be based on the class of the renderer.
        Call InputType::srcAttributeChanged and moved the type-specific
        logic there. Call shouldRespectAlignAttribute and
        shouldRespectHeightAndWidthAttributes rather than having
        type-specific logic here. Call minOrMaxAttributeChanged.
        (WebCore::HTMLInputElement::rendererIsNeeded): Call
        InputType::rendererIsNeeded; moved the type-specific logic there.
        (WebCore::HTMLInputElement::attach): Removed the unneeded m_inited
        flag, which was redundant with the m_haveType flag. Call
        InputType::attach; moved the type-specific logic there.
        (WebCore::HTMLInputElement::altText): Use fastGetAttribute.
        (WebCore::HTMLInputElement::isSuccessfulSubmitButton): Call
        InputType::canBeSuccessfulSubmitButton; moved the type-specific
        logic there.
        (WebCore::HTMLInputElement::isActivatedSubmit): Updated for
        name changes.
        (WebCore::HTMLInputElement::setActivatedSubmit): Ditto.
        (WebCore::HTMLInputElement::reset): Updated to use
        InputType::storesValueSeparateFromAttribute. Also use
        hasAttribute(checkedAttr) rather than m_defaultChecked,
        since both are the same. Also updated for name change.
        (WebCore::HTMLInputElement::setChecked): Updated for name
        changes. Also added call to
        InputType::shouldSendChangeEventAfterCheckedChanged and
        moved the type-specific logic there.
        (WebCore::HTMLInputElement::setIndeterminate): Call
        isCheckable to see if indeterminate is allowed.
        Also updated for name changes.
        (WebCore::HTMLInputElement::copyNonAttributeProperties):
        Updated for name changes and removed data members.
        (WebCore::HTMLInputElement::value): Call
        InputType::getTypeSpecificValue and InputType::fallbackValue.
        Moved the type-specific logic there.
        (WebCore::HTMLInputElement::valueWithDefault): Call
        InputType::defaultValue. Moved the type-specific logic there.
        (WebCore::HTMLInputElement::setSuggestedValue): Call
        InputType::canSetSuggestedValue. Moved the type-specific logic
        there.
        (WebCore::HTMLInputElement::setValue): Call
        InputType::canSetValue. Moved the type-specific logic there.
        Clear the file list if it exists rather than checking the
        type explicitly. We could probably do that a more elegant way.
        (WebCore::HTMLInputElement::placeholder): Use fastGetAttribute.
        (WebCore::HTMLInputElement::setValueFromRenderer): Use the
        isFileUpload function in the assertion.
        (WebCore::HTMLInputElement::setFileListFromRenderer): Put most
        of the code from this function into FileInputType::setFileList.
        (WebCore::HTMLInputElement::preDispatchEventHandler): Changed
        to call InputType::willDispatchClick, which does the type-specific
        work. Still need to use a single struct for all types, because
        the type of the element could change during the event handling.
        (WebCore::HTMLInputElement::postDispatchEventHandler): Changed
        to call InputType::didDispatchClick.
        (WebCore::HTMLInputElement::defaultValue): Use fastGetAttribute.
        (WebCore::HTMLInputElement::accept): Use fastGetAttribute.
        (WebCore::HTMLInputElement::alt): Use fastGetAttribute.
        (WebCore::HTMLInputElement::src): Use fastGetAttribute.
        (WebCore::HTMLInputElement::setAutofilled): Updated for name
        changes.
        (WebCore::HTMLInputElement::files): Use InputType::files.
        (WebCore::HTMLInputElement::isAcceptableValue): Use
        InputType::isAcceptableValue.
        (WebCore::HTMLInputElement::sanitizeValue): Use
        InputType::sanitizeValue.
        (WebCore::HTMLInputElement::hasUnacceptableValue): Use
        InputType::hasUnacceptableValue.
        (WebCore::HTMLInputElement::needsActivationCallback): Use
        InputType::shouldResetOnDocumentActivation.
        (WebCore::HTMLInputElement::willMoveToNewOwnerDocument): Use
        InputType::willMoveToNewOwnerDocument.
        (WebCore::HTMLInputElement::dataList): Use
        InputType::shouldRespectListAttribute.
        (WebCore::HTMLInputElement::selectedOption): Tweaked logic
        and naming a bit.
        (WebCore::HTMLInputElement::stepUpFromRenderer): Use
        fastGetAttribute.
        (WebCore::HTMLInputElement::isSpeechEnabled): Use
        InputType::shouldRespectSpeechAttribute.
        (WebCore::HTMLInputElement::isTextButton): No longer inline.
        Calls through to InputType.
        (WebCore::HTMLInputElement::isRadioButton): Ditto.
        (WebCore::HTMLInputElement::isSearchField): Ditto.
        (WebCore::HTMLInputElement::isInputTypeHidden): Ditto.
        (WebCore::HTMLInputElement::isPasswordField): Ditto.
        (WebCore::HTMLInputElement::isCheckbox): Ditto.
        (WebCore::HTMLInputElement::isText): Ditto.
        (WebCore::HTMLInputElement::isEmailField): Ditto.
        (WebCore::HTMLInputElement::isFileUpload): Ditto.
        (WebCore::HTMLInputElement::isImageButton): Ditto.
        (WebCore::HTMLInputElement::isNumberField): Ditto.
        (WebCore::HTMLInputElement::isSubmitButton): Ditto.
        (WebCore::HTMLInputElement::isTelephoneField): Ditto.
        (WebCore::HTMLInputElement::isURLField): Ditto.
        (WebCore::HTMLInputElement::isEnumeratable): Ditto.
        (WebCore::HTMLInputElement::isChecked): No longer inline.
        Calls InputType::isCheckable.
        (WebCore::HTMLInputElement::hasSpinButton): No longer inline.
        Calls through to InputType.
        (WebCore::HTMLInputElement::supportsPlaceholder): No longer
        inline. Calls isTextType as before, but with no special case
        for ISINDEX. That special case was unneeded since it returns
        true from isTextType.
        (WebCore::HTMLInputElement::checkedRadioButtons): No longer
        inline.
        (WebCore::HTMLInputElement::handleBeforeTextInsertedEvent):
        No longer inline.

        * html/HTMLInputElement.h: Removed multiple unneeded includes.
        The big one is probably InputType.h, but also HTMLFormElement.h.
        Removed unneeded forward declarations. Made many functions
        no longer inline since they now need to make virtual function
        dispatches. Removed the unneeded defaultChecked and
        webkitdirectory functions. Both are handled by HTML attribute
        reflection for DOM bindings, and the callers instead can get
        at the attribute. Made updateCheckedRadioButtons public so it
        can be called by an InputType class. Removed
        DeprecatedInputType, InputTypeMap, createTypeMap,
        deprecatedInputType, allowsIndeterminate,
        respectHeightAndWidthAttrs, storesValueSeparateFromAttribute,
        m_imageLoader, m_fileList, m_deprecatedTypeNumber,
        m_defaultChecked, and m_inited. Renamed m_checked to
        m_isChecked, m_useDefaultChecked to m_reflectsCheckedAttribute,
        m_indeterminate tom_isIndeterminate, m_haveType to m_hasType,
        m_activeSubmit to m_isActivatedSubmit, and m_autofilled to
        m_isAutofilled.
        
        * html/HiddenInputType.cpp:
        (WebCore::HiddenInputType::accessKeyAction): Added.
        (WebCore::HiddenInputType::rendererIsNeeded) Added.:
        (WebCore::HiddenInputType::storesValueSeparateFromAttribute): Added.
        (WebCore::HiddenInputType::isHiddenType): Added.
        (WebCore::HiddenInputType::shouldRespectHeightAndWidthAttributes): Added.
        * html/HiddenInputType.h: Ditto.

        * html/ImageInputType.cpp:
        (WebCore::ImageInputType::ImageInputType): Moved out of the header file.
        (WebCore::ImageInputType::srcAttributeChanged): Added.
        (WebCore::ImageInputType::attach): Added.
        (WebCore::ImageInputType::willMoveToNewOwnerDocument): Added.
        (WebCore::ImageInputType::shouldRespectAlignAttribute): Added.
        (WebCore::ImageInputType::canBeSuccessfulSubmitButton): Added.
        (WebCore::ImageInputType::isImageButton): Added.
        (WebCore::ImageInputType::isEnumeratable): Added.
        (WebCore::ImageInputType::shouldRespectHeightAndWidthAttributes): Added.
        * html/ImageInputType.h: Ditto.

        * html/InputType.cpp:
        (WebCore::InputType::create): Changed argument type to String. There
        is no value in taking an AtomicString here.
        (WebCore::InputType::scaledStepValueShouldBeInteger): Fixed typo in
        this function name.
        (WebCore::InputType::canSetStringValue): Added.
        (WebCore::InputType::isKeyboardFocusable): Added.
        (WebCore::InputType::shouldUseInputMethod): Added.
        (WebCore::InputType::handleBlurEvent): Added.
        (WebCore::InputType::accessKeyAction): Added.
        (WebCore::InputType::attach): Added.
        (WebCore::InputType::srcAttributeChanged): Added.
        (WebCore::InputType::willMoveToNewOwnerDocument): Added.
        (WebCore::InputType::shouldRespectAlignAttribute): Added.
        (WebCore::InputType::canChangeFromAnotherType): Added.
        (WebCore::InputType::minOrMaxAttributeChanged): Added.
        (WebCore::InputType::canBeSuccessfulSubmitButton): Added.
        (WebCore::InputType::rendererIsNeeded): Added.
        (WebCore::InputType::files): Added.
        (WebCore::InputType::getTypeSpecificValue): Added.
        (WebCore::InputType::fallbackValue): Added.
        (WebCore::InputType::defaultValue): Added.
        (WebCore::InputType::canSetSuggestedValue): Added.
        (WebCore::InputType::shouldSendChangeEventAfterCheckedChanged): Added.
        (WebCore::InputType::storesValueSeparateFromAttribute): Added.
        (WebCore::InputType::canSetValue): Added.
        (WebCore::InputType::willDispatchClick): Added.
        (WebCore::InputType::didDispatchClick): Added.
        (WebCore::InputType::isAcceptableValue): Added.
        (WebCore::InputType::sanitizeValue): Added.
        (WebCore::InputType::hasUnacceptableValue): Added.
        (WebCore::InputType::setFileList): Added.
        (WebCore::InputType::shouldResetOnDocumentActivation): Added.
        (WebCore::InputType::shouldRespectListAttribute): Added.
        (WebCore::InputType::shouldRespectSpeechAttribute): Added.
        (WebCore::InputType::isTextButton): Added.
        (WebCore::InputType::isRadioButton): Added.
        (WebCore::InputType::isSearchField): Added.
        (WebCore::InputType::isHiddenType): Added.
        (WebCore::InputType::isPasswordField): Added.
        (WebCore::InputType::isCheckbox): Added.
        (WebCore::InputType::isEmailField): Added.
        (WebCore::InputType::isFileUpload): Added.
        (WebCore::InputType::isImageButton): Added.
        (WebCore::InputType::isNumberField): Added.
        (WebCore::InputType::isSubmitButton): Added.
        (WebCore::InputType::isTelephoneField): Added.
        (WebCore::InputType::isURLField): Added.
        (WebCore::InputType::isEnumeratable): Added.
        (WebCore::InputType::isCheckable): Added.
        (WebCore::InputType::hasSpinButton): Added.
        (WebCore::InputType::shouldRespectHeightAndWidthAttributes): Added.

        * html/InputType.h: Removed unneeded ExceptionCode.h include and
        used a typedef instead as we do when we want for forward declare it.
        Added includes and forward declarations needed for new functions.
        Added ClickHandlingState structure. Changed the argument to create
        to a String rather than AtomicString. Added many virtual functions.
        
        * html/IsIndexInputType.cpp:
        (WebCore::IsIndexInputType::shouldRespectListAttribute): Added.
        * html/IsIndexInputType.h: Ditto.

        * html/NumberInputType.cpp:
        (WebCore::NumberInputType::handleBlurEvent): Added.
        (WebCore::NumberInputType::isAcceptableValue): Added.
        (WebCore::NumberInputType::sanitizeValue): Added.
        (WebCore::NumberInputType::hasUnacceptableValue): Added.
        (WebCore::NumberInputType::shouldRespectSpeechAttribute): Added.
        (WebCore::NumberInputType::isNumberField): Added.
        (WebCore::NumberInputType::hasSpinButton): Added.
        * html/NumberInputType.h: Ditto.

        * html/PasswordInputType.cpp:
        (WebCore::PasswordInputType::shouldUseInputMethod): Added.
        (WebCore::PasswordInputType::shouldResetOnDocumentActivation): Added.
        (WebCore::PasswordInputType::shouldRespectListAttribute): Added.
        (WebCore::PasswordInputType::shouldRespectSpeechAttribute): Added.
        (WebCore::PasswordInputType::isPasswordField): Added.
        * html/PasswordInputType.h: Ditto.

        * html/RadioInputType.cpp:
        (WebCore::RadioInputType::isKeyboardFocusable): Added.
        (WebCore::RadioInputType::attach): Added.
        (WebCore::RadioInputType::shouldSendChangeEventAfterCheckedChanged): Added.
        (WebCore::RadioInputType::willDispatchClick): Added.
        (WebCore::RadioInputType::didDispatchClick): Added.
        (WebCore::RadioInputType::isRadioButton): Added.
        * html/RadioInputType.h: Ditto.

        * html/RangeInputType.cpp:
        (WebCore::RangeInputType::accessKeyAction): Added.
        (WebCore::RangeInputType::minOrMaxAttributeChanged): Added.
        (WebCore::RangeInputType::fallbackValue): Added.
        (WebCore::RangeInputType::sanitizeValue): Added.
        (WebCore::RangeInputType::shouldRespectListAttribute): Added.
        * html/RangeInputType.h: Ditto.

        * html/ResetInputType.cpp:
        (WebCore::ResetInputType::defaultValue): Added.
        (WebCore::ResetInputType::isTextButton): Added.
        * html/ResetInputType.h: Ditto.

        * html/SearchInputType.cpp:
        (WebCore::SearchInputType::shouldRespectSpeechAttribute): Added.
        (WebCore::SearchInputType::isSearchField): Added.
        * html/SearchInputType.h: Ditto.

        * html/SubmitInputType.cpp:
        (WebCore::SubmitInputType::canBeSuccessfulSubmitButton): Added.
        (WebCore::SubmitInputType::defaultValue): Added.
        (WebCore::SubmitInputType::isSubmitButton): Added.
        (WebCore::SubmitInputType::isTextButton): Added.
        * html/SubmitInputType.h: Ditto.

        * html/TelephoneInputType.cpp:
        (WebCore::TelephoneInputType::shouldRespectSpeechAttribute): Added.
        (WebCore::TelephoneInputType::isTelephoneField): Added.
        * html/TelephoneInputType.h: Ditto.

        * html/TextFieldInputType.cpp:
        (WebCore::TextFieldInputType::shouldUseInputMethod): Added.
        (WebCore::TextFieldInputType::sanitizeValue): Added.
        (WebCore::TextFieldInputType::shouldRespectListAttribute): Added.
        * html/TextFieldInputType.h: Ditto.

        * html/TextInputType.cpp:
        (WebCore::TextInputType::canSetSuggestedValue): Added.
        (WebCore::TextInputType::shouldRespectSpeechAttribute): Added.
        * html/TextInputType.h: Ditto.

        * html/TimeInputType.cpp:
        (WebCore::TimeInputType::scaledStepValueShouldBeInteger): Fixed
        typo in the name of this function.
        * html/TimeInputType.h: Ditto.

        * html/URLInputType.cpp:
        (WebCore::URLInputType::isURLField): Added.
        * html/URLInputType.h: Ditto.

2376 2377 2378 2379 2380 2381 2382 2383 2384 2385 2386 2387 2388 2389 2390
2011-01-03  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed.

        NSScrollView-based scrollbars and ScrollBarTheme-based scrollbars don't look the same
        https://bugs.webkit.org/show_bug.cgi?id=51151

        Flip switch to use WebThemeEngine for Chromium/Mac scrollbar rendering,
        so that it can match Safari's (and thus use the same baselines).

        No new tests, should be covered by layout tests (which will need
        expectation changes)

        * platform/chromium/ScrollbarThemeChromiumMac.mm:

2391 2392 2393 2394 2395 2396 2397 2398 2399 2400 2401
2011-01-03  Antonio Gomes  <agomes@rim.com>

        Unreviewed build fix for WebKit/Gtk+.

        RenderThemeGtk::initMediaColors() in RenderThemeGtk2.cpp needs to be
        guarded by ENABLE(VIDEO), as it is in its header.

        No new tests.

        * platform/gtk/RenderThemeGtk2.cpp:

2402 2403 2404 2405 2406 2407 2408 2409
2011-01-02  Dan Bernstein  <mitz@apple.com>

        Rubber-stamped by Simon Fraser.

        <rdar://problem/8812159> Update copyright strings

        * Info.plist:

2410 2411 2412 2413 2414 2415 2416 2417 2418 2419 2420 2421 2422
2011-01-02  Dan Bernstein  <mitz@apple.com>

        Reviewed by Sam Weinig.

        <rdar://problem/8806570> REGRESSION (r73337): Incorrect text match count when a match occurs in a text field
        https://bugs.webkit.org/show_bug.cgi?id=51623

        * editing/Editor.cpp:
        (WebCore::Editor::countMatchesForText): Actually remember the original search range end
        container and offset and restore them when needed, instead of using two references to the
        same Range.
        * manual-tests/find-count-matches-after-text-control.html: Added.

2423 2424 2425 2426 2427 2428 2429 2430 2431 2432 2433 2434 2435
2011-01-02  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Csaba Osztrogonác.

        WebKit 2 does not build on 64bits with a recent GCC
        https://bugs.webkit.org/show_bug.cgi?id=51754

        Use explicitely 64 bits types for the attributes of DatabaseDetails.

        * storage/DatabaseDetails.h:
        (WebCore::DatabaseDetails::expectedUsage):
        (WebCore::DatabaseDetails::currentUsage):

2436 2437 2438 2439 2440 2441 2442
2011-01-02  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed WinCE build fix for r74868.

        * platform/graphics/wince/ImageBufferWinCE.cpp:
        (WebCore::getImageData):

2443 2444 2445 2446 2447 2448 2449 2450 2451 2452 2453 2454 2455 2456 2457 2458 2459 2460 2461 2462 2463 2464 2465 2466 2467 2468 2469 2470 2471 2472 2473 2474
2011-01-02  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r74847.
        http://trac.webkit.org/changeset/74847
        https://bugs.webkit.org/show_bug.cgi?id=51803

        "Preprocessor guards should be in header files" (Requested by
        ap on #webkit).

        * bindings/js/JSDOMWindowBase.cpp:
        * dom/Document.cpp:
        (WebCore::Document::recalcStyle):
        * html/HTMLDocument.cpp:
        * loader/FrameLoader.cpp:
        * loader/ResourceLoadNotifier.cpp:
        * page/Chrome.cpp:
        * page/Console.cpp:
        * page/ContextMenuController.cpp:
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::dispatchEvent):
        * page/EventHandler.cpp:
        * page/Page.cpp:
        * storage/Database.cpp:
        * workers/AbstractWorker.cpp:
        * workers/DefaultSharedWorkerRepository.cpp:
        * workers/SharedWorker.cpp:
        * workers/Worker.cpp:
        * workers/WorkerContext.cpp:
        * workers/WorkerMessagingProxy.cpp:
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::callReadyStateChangeListener):

2475 2476 2477 2478 2479 2480
2011-01-02  Patrick Gansterer  <paroga@webkit.org>

        [CMake] Unreviewed build fix.

        * CMakeLists.txt:

2481 2482 2483 2484 2485 2486 2487 2488 2489