ChangeLog 1.92 MB
Newer Older
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
2008-04-07  Luca Bruno  <lethalman88@gmail.com>

        Reviewed by Alp Toker.

        http://bugs.webkit.org/show_bug.cgi?id=18297
        Bug #18297 - Acid2/Acid3 -tests don't load load with soup.

        Fixes in the libsoup backend: data url parsing, acid tests, redirects,
        response headers handling and re-entrancy issues on job cancellation.
        Thanks to Dan Winship for libsoup hints.

        * platform/network/ResourceHandleInternal.h:
        (WebCore::ResourceHandleInternal::ResourceHandleInternal): add m_cancelled and remove unuseful m_session
        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::restartedCallback): added to route redirects to webkit
        (WebCore::dataCallback): add response headers, some checks and fix re-entrancy
        (WebCore::parseDataUrl): be an idle callback for the main loop
        (WebCore::ResourceHandle::start):
        (WebCore::ResourceHandle::cancel): fixed re-entrancy

21
22
23
24
25
26
2008-04-07  Jan Michael Alonzo  <jmalonzo@unpluggable.com>

        Build fix, rubber-stamped and landed by ap.

        * GNUmakefile.am: Fix dom_storage conditional and typo: ENABLE_DOM_STORAG

27
28
29
30
31
32
2008-04-07  Brady Eidson  <beidson@apple.com>

        Whoops, idls don't go in the vcproj!

        * WebCore.vcproj/WebCore.vcproj:

33
34
35
36
37
38
2008-04-06  Brady Eidson <beidson@apple.com>

        Attempt to tickle Windows build into accepting this idl

        * storage/StorageEvent.idl:

39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
2008-04-06  Brady Eidson <beidson@apple.com>

        Reviewed by Sam

        HTML5 Session and Local Storage

        Land a bunch of empty files and interfaces to keep things building while 
        I finish off the rest of the implementation of SessionStorage

        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:

        * storage/OriginStorage.cpp: Added.
        * storage/OriginStorage.h: Added.

        * storage/SessionStorage.cpp: Added.
        * storage/SessionStorage.h: Added.

        * storage/Storage.cpp: Added.
        (WebCore::Storage::length):
        (WebCore::Storage::key):
        (WebCore::Storage::getItem):
        (WebCore::Storage::setItem):
        (WebCore::Storage::removeItem):
        * storage/Storage.h: Added.
        * storage/Storage.idl: Added.

        * storage/StorageEvent.cpp: Added.
        * storage/StorageEvent.h: Added.
        (WebCore::StorageEvent::key):
        (WebCore::StorageEvent::oldValue):
        (WebCore::StorageEvent::newValue):
        (WebCore::StorageEvent::uri):
        (WebCore::StorageEvent::source):
        (WebCore::StorageEvent::initStorageEvent):
        * storage/StorageEvent.idl: Added.

        * storage/StorageMap.cpp: Added.
        * storage/StorageMap.h: Added.

kevino@webkit.org's avatar
kevino@webkit.org committed
83
84
85
86
87
88
89
90
91
92
93
94
2008-04-05  Kevin Ollivier  <kevino@theolliviers.com>

        Reviewed by Mark Rowe.

        Add CSS to the MIMETypeRegistry, which ensures CSS files get
        the right MIMEType when loaded from disk.

        * platform/gtk/MIMETypeRegistryGtk.cpp:
        (WebCore::):
        * platform/wx/MimeTypeRegistryWx.cpp:
        (WebCore::):

rwlbuis@webkit.org's avatar
rwlbuis@webkit.org committed
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
2008-04-05  Rob Buis  <buis@kde.org>

        Reviewed by Eric.

        http://bugs.webkit.org/show_bug.cgi?id=17129
        Incorrect style resolution in CSS styled SVG, with multiple style sheets

        Fix the style resolution on the svg by ensuring xml-stylesheet pseudo
        attributes title and alternate are transferred to the stylesheet
        created from the ProcessingInstruction.

        * dom/ProcessingInstruction.cpp:
        (WebCore::ProcessingInstruction::ProcessingInstruction):
        (WebCore::ProcessingInstruction::checkStyleSheet):
        (WebCore::ProcessingInstruction::setCSSStyleSheet):
        * dom/ProcessingInstruction.h:

mitz@apple.com's avatar
mitz@apple.com committed
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
2008-04-05  Dan Bernstein  <mitz@apple.com>

        Reviewed by Darin Adler.

        - fix <rdar://problem/5843719> Excessive repainting of cells in tables with non-auto height

        Test: fast/repaint/table-two-pass-layout-overpaint.html

        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::layout): Changed the first pass over the sections
        to only call calcRowHeight() and recalcOuterBorder() but not
        layoutRows(), because the section's final height is unknown yet.
        Removed caching of m_height before the call to calcHeight(), because
        for non-positioned tables, calcHeight() only calculates the vertical
        margins and does not change m_height.
        Added a second pass over the sections, after the table height is known,
        to call layoutRows() on each section, with additional height if needed.
        Did minimal cleanup including caching the value of collapseBorders() in
        a local variable and changing a while loop into a for loop.
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::calcRowHeight): Changed to return the
        height of the section based on row height calculations.
        (WebCore::RenderTableSection::layoutRows): Removed a call to
        recalcOuterBorder(), which is now done by RenderTable::layout().
        * rendering/RenderTableSection.h: Changed calcRowHeight() to have a
        return value.

139
140
141
142
143
144
145
146
147
2008-04-05  Simon Hausmann  <shausman@trolltech.com>

        Reviewed by Holger.

        Fixes: Disable "unimplemented" warnings when building WebKit inside Qt.

        * WebCore.pro:
        * platform/NotImplemented.h:

148
149
150
151
152
153
154
155
156
157
158
159
2008-04-05  Simon Hausmann  <hausmann@webkit.org>

        Rubber-stamped by Holger

        Revert "* Load images incrementally. This will show warnings on the console"
        This rolls out -r29739.

        This unfortunately caused some crashes and drawing errors. Backing out for now.

        * platform/graphics/qt/ImageDecoderQt.cpp:
        (WebCore::ImageDecoderQt::setData):

160
161
162
163
164
165
2008-04-04  Kevin Ollivier  <kevino@theolliviers.com>

        Add GradientWx.cpp to the wx build process. 

        * webcore-wx.bkl:

mitz@apple.com's avatar
mitz@apple.com committed
166
167
168
169
170
171
172
173
174
175
176
2008-04-04  Dan Bernstein  <mitz@apple.com>

        Reviewed by Sam Weinig.

        - speed up CSSFontSelector::getFontData()

        * css/CSSFontSelector.cpp:
        (WebCore::fontDataForGenericFamily): Factored out of getFontData().
        (WebCore::CSSFontSelector::getFontData): Changed to call
        fontDataForGenericFamily() directly if the map is empty.

177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
2008-04-04  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Oliver.

        Replace AccessibilityObject::isRenderImage() with a virtual
        RenderObject::isRenderImage().

        * page/AccessibilityObject.cpp:
        (WebCore::AccessibilityObject::accessibilityIsIgnored):
        (WebCore::AccessibilityObject::addChildren):
        * page/AccessibilityObject.h:
        (WebCore::AccessibilityObject::isDetached):
        * rendering/RenderImage.h:
        (WebCore::RenderImage::isRenderImage):
        * rendering/RenderObject.h:
        (WebCore::RenderObject::isRenderImage):

mitz@apple.com's avatar
mitz@apple.com committed
194
195
196
197
198
199
200
201
2008-04-04  Dan Bernstein  <mitz@apple.com>

        - try to fix the wx build

        * platform/graphics/wx/FontPlatformDataWx.cpp:
        (WebCore::fontWeightToWxFontWeight):
        (WebCore::FontPlatformData::FontPlatformData):

202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
2008-04-04  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Beth.

        Some more clean-up of AccessibilityObject:
        - Rearranged/grouped methods.
        - Marked many methods const.
        - Changed many methods to take args by const ref instead of by val.
        - Made headingLevel() static.
        - Renamed detached() to isDetached(), loaded() to isLoaded(),
          documentLinks to getDocumentLinks().
        - Made clearChildren(), removeAXObjectID(), isDetached() private.
        - Added notImplemented() calls for unimplemented methods.
        - Replaced stringForReplacedNode method with static function.

        * page/AccessibilityObject.cpp:
        (WebCore::AccessibilityObject::~AccessibilityObject):
        (WebCore::AccessibilityObject::firstChild):
        (WebCore::AccessibilityObject::lastChild):
        (WebCore::AccessibilityObject::previousSibling):
        (WebCore::AccessibilityObject::nextSibling):
        (WebCore::AccessibilityObject::parentObject):
        (WebCore::AccessibilityObject::parentObjectUnignored):
        (WebCore::AccessibilityObject::headingLevel):
        (WebCore::AccessibilityObject::anchorElement):
        (WebCore::AccessibilityObject::actionElement):
        (WebCore::AccessibilityObject::mouseButtonListener):
        (WebCore::AccessibilityObject::helpText):
        (WebCore::AccessibilityObject::textUnderElement):
        (WebCore::AccessibilityObject::hasIntValue):
        (WebCore::AccessibilityObject::intValue):
        (WebCore::AccessibilityObject::stringValue):
        (WebCore::AccessibilityObject::title):
        (WebCore::AccessibilityObject::accessibilityDescription):
        (WebCore::AccessibilityObject::boundingBoxRect):
        (WebCore::AccessibilityObject::size):
        (WebCore::AccessibilityObject::linkedUIElement):
        (WebCore::AccessibilityObject::accessibilityShouldUseUniqueId):
        (WebCore::AccessibilityObject::accessibilityIsIgnored):
        (WebCore::AccessibilityObject::isLoaded):
        (WebCore::AccessibilityObject::layoutCount):
        (WebCore::AccessibilityObject::textLength):
        (WebCore::AccessibilityObject::selectedText):
        (WebCore::AccessibilityObject::selection):
        (WebCore::AccessibilityObject::selectedTextRange):
        (WebCore::AccessibilityObject::setSelectedText):
        (WebCore::AccessibilityObject::setSelectedTextRange):
        (WebCore::AccessibilityObject::makeRangeVisible):
        (WebCore::AccessibilityObject::url):
        (WebCore::AccessibilityObject::isVisited):
        (WebCore::AccessibilityObject::isFocused):
        (WebCore::AccessibilityObject::setValue):
        (WebCore::AccessibilityObject::isEnabled):
        (WebCore::AccessibilityObject::topRenderer):
        (WebCore::AccessibilityObject::textControl):
        (WebCore::AccessibilityObject::widget):
        (WebCore::AccessibilityObject::axObjectCache):
        (WebCore::AccessibilityObject::getDocumentLinks):
        (WebCore::AccessibilityObject::documentFrameView):
        (WebCore::AccessibilityObject::widgetForAttachmentView):
        (WebCore::AccessibilityObject::frameViewIfRenderView):
        (WebCore::AccessibilityObject::visiblePositionRange):
        (WebCore::AccessibilityObject::doAXTextMarkerRangeForLine):
        (WebCore::AccessibilityObject::doAXTextMarkerRangeForUnorderedTextMarkers):
        (WebCore::AccessibilityObject::doAXLeftWordTextMarkerRangeForTextMarker):
        (WebCore::AccessibilityObject::doAXRightWordTextMarkerRangeForTextMarker):
        (WebCore::AccessibilityObject::doAXLeftLineTextMarkerRangeForTextMarker):
        (WebCore::AccessibilityObject::doAXRightLineTextMarkerRangeForTextMarker):
        (WebCore::AccessibilityObject::doAXSentenceTextMarkerRangeForTextMarker):
        (WebCore::AccessibilityObject::doAXParagraphTextMarkerRangeForTextMarker):
        (WebCore::AccessibilityObject::doAXStyleTextMarkerRangeForTextMarker):
        (WebCore::AccessibilityObject::textMarkerRangeForRange):
        (WebCore::stringForReplacedNode):
        (WebCore::AccessibilityObject::doAXStringForTextMarkerRange):
        (WebCore::AccessibilityObject::doAXBoundsForTextMarkerRange):
        (WebCore::AccessibilityObject::doAXLengthForTextMarkerRange):
        (WebCore::AccessibilityObject::doSetAXSelectedTextMarkerRange):
        (WebCore::AccessibilityObject::doAXTextMarkerForPosition):
        (WebCore::AccessibilityObject::doAXNextTextMarkerForTextMarker):
        (WebCore::AccessibilityObject::doAXPreviousTextMarkerForTextMarker):
        (WebCore::AccessibilityObject::doAXNextWordEndTextMarkerForTextMarker):
        (WebCore::AccessibilityObject::doAXPreviousWordStartTextMarkerForTextMarker):
        (WebCore::AccessibilityObject::doAXNextLineEndTextMarkerForTextMarker):
        (WebCore::AccessibilityObject::doAXPreviousLineStartTextMarkerForTextMarker):
        (WebCore::AccessibilityObject::doAXNextSentenceEndTextMarkerForTextMarker):
        (WebCore::AccessibilityObject::doAXPreviousSentenceStartTextMarkerForTextMarker):
        (WebCore::AccessibilityObject::doAXNextParagraphEndTextMarkerForTextMarker):
        (WebCore::AccessibilityObject::doAXPreviousParagraphStartTextMarkerForTextMarker):
        (WebCore::AccessibilityObject::textMarkerForIndex):
        (WebCore::AccessibilityObject::doAXUIElementForTextMarker):
        (WebCore::AccessibilityObject::doAXLineForTextMarker):
        (WebCore::AccessibilityObject::rangeForTextMarkerRange):
        (WebCore::AccessibilityObject::indexForTextMarker):
        (WebCore::AccessibilityObject::doAXRangeForLine):
        (WebCore::AccessibilityObject::doAXRangeForPosition):
        (WebCore::AccessibilityObject::doAXRangeForIndex):
        (WebCore::AccessibilityObject::doAXStyleRangeForIndex):
        (WebCore::AccessibilityObject::doAXStringForRange):
        (WebCore::AccessibilityObject::doAXBoundsForRange):
        (WebCore::AccessibilityObject::doAccessibilityHitTest):
        (WebCore::AccessibilityObject::focusedUIElement):
        (WebCore::AccessibilityObject::observableObject):
        (WebCore::AccessibilityObject::roleValue):
        (WebCore::AccessibilityObject::canSetFocusAttribute):
        (WebCore::AccessibilityObject::canSetValueAttribute):
        (WebCore::AccessibilityObject::canSetTextRangeAttributes):
        (WebCore::AccessibilityObject::hasChildren):
        (WebCore::AccessibilityObject::axObjectID):
        * page/AccessibilityObject.h:
        (WebCore::VisiblePositionRange::VisiblePositionRange):
        (WebCore::AccessibilityObject::PlainTextRange::PlainTextRange):
        (WebCore::AccessibilityObject::areaElement):
        (WebCore::AccessibilityObject::renderer):
        (WebCore::AccessibilityObject::children):
        (WebCore::AccessibilityObject::wrapper):
        (WebCore::AccessibilityObject::isDetached):
        * page/mac/AccessibilityObjectWrapper.mm:
        (AXAttributeStringSetHeadingLevel):
        (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
2008-04-04  Timothy Hatcher  <timothy@apple.com>

        Restore the user entered text when clearing the auto-completion.
        This is important when the user typed text that is a different
        case than the completion. This has no affect on the Console, since
        it matches completions case-sensitively. This is used in the up-coming
        Database Query view for words like "SELECT" and "INSERT".

        Reviewed by Adam Roben.

        * page/inspector/TextPrompt.js:
        (WebInspector.TextPrompt.prototype.clearAutoComplete): Restore the user typed
        text in the original DOM range that complete() saved away.
        (WebInspector.TextPrompt.prototype.complete): Store away the fullWordRange
        and it's text content so clearAutoComplete can restore it.

338
339
340
341
342
343
344
345
346
2008-04-04  Timothy Hatcher  <timothy@apple.com>

        Don't trim whitespace when looking for the current match, this prevents
        tabbing through matches in the up-coming Database Query view.

        Reviewed by Adam Roben.

        * page/inspector/TextPrompt.js: Removed a trimTrailingWhitespace() call.

347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
2008-04-04  Timothy Hatcher  <timothy@apple.com>

        Factor out the Console text completion and command history into
        a new TextPrompt object. This TextPrompt object will be used later
        other parts of the Inspector that need text completion and history.
        Not functionality changed, just moved code around.

        Reviewed by Adam Roben.

        * WebCore.vcproj/WebCore.vcproj: Add TextPrompt.js.
        * page/inspector/Console.js: Call the new prompt object and
          delete all the code that moved.
        * page/inspector/TextPrompt.js: Added. Moved code from Console.js.
        * page/inspector/WebKit.qrc: Add TextPrompt.js.
        * page/inspector/inspector.html: Add TextPrompt.js.

363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
2008-04-04  Timothy Hatcher  <timothy@apple.com>

        Makes setting shouldRefreshChildren on a TreeElement perform the refresh
        immediately if the element is already expanded.

        Reviewed by Adam Roben.

        * page/inspector/treeoutline.js:
        (TreeElement.prototype.get shouldRefreshChildren): Return this._shouldRefreshChildren.
        (TreeElement.prototype.set shouldRefreshChildren): If changing to true, and
        already expanded,
        call expand again to trigger the refresh. Sets this._shouldRefreshChildren.
        (TreeElement.prototype._attach): Check for this._shouldRefreshChildren.
        (TreeElement.prototype.expand): Ditto.

378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
2008-04-04  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Beth.

        Some clean up of AccessibilityObject:
        - Use existing isImage() in more places.
        - Use existing isTextControl() in more places.
        - Added isRenderImage(). Check this before casting to RenderImage,
          since other, non-RenderImage derived RenderObjects (e.g.
          RenderListMarker) can return true for isImage().
        - Fix two copy/paste errors with improper semicolons.

        * page/AccessibilityObject.cpp:
        (WebCore::AccessibilityObject::isImageButton): Use isImage().
        (WebCore::AccessibilityObject::isRenderImage): Added.
        (WebCore::AccessibilityObject::isAnchor): Use isImage().
        (WebCore::AccessibilityObject::isAttachment): Same.
        (WebCore::AccessibilityObject::accessibilityDescription): Same.
        (WebCore::AccessibilityObject::accessibilityIsIgnored): Use
        isRenderImage() instead of isImage().
        (WebCore::AccessibilityObject::url): Use isImage().
        (WebCore::AccessibilityObject::textControl): Remove improper semicolon, 
        and use isTextControl().
        (WebCore::AccessibilityObject::textMarkerForIndex): Same.
        (WebCore::AccessibilityObject::indexForTextMarker): Use isTextControl().
        (WebCore::AccessibilityObject::doAXRangeForLine): Same.
        (WebCore::AccessibilityObject::doAXRangeForIndex): Same
        (WebCore::AccessibilityObject::doAXStringForRange): Same.
        (WebCore::AccessibilityObject::roleValue):  Use isImage().
        (WebCore::AccessibilityObject::addChildren): Use isRenderImage().
        * page/AccessibilityObject.h:

410
411
412
413
414
415
416
417
418
419
2008-04-04  Timothy Hatcher  <timothy@apple.com>

        Fixes a null exception when hovering in some areas of the DOM tree.

        Reviewed by Adam Roben.

        * page/inspector/treeoutline.js:
        (TreeOutline.prototype.treeElementFromPoint): Check listNode for null/undefined
        before accessing any properties. Return null if listNode is null.

420
421
422
423
424
425
426
427
428
429
430
431
2008-04-04  Timothy Hatcher  <timothy@apple.com>

        Changing WebInspector.currentFocusElement to/from an input element
        does not change the actual focus of that input element. You see this
        in the search field.

        Reviewed by Adam Roben.

        * page/inspector/inspector.js:
        (WebInspector.set currentFocusElement): Call blur and focus if the
        node implements them.

432
433
434
435
436
437
438
439
440
441
442
2008-04-04  David Hyatt  <hyatt@apple.com>

        Improve the background size heuristic for SVGs used as background images with no intrinsic size specified.
        Treat them as having a background-size of 100%.  This means their maximal size will be the box established
        by background-origin.

        Reviewed by Beth

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::calculateBackgroundSize):

443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
2008-04-04  Timothy Hatcher  <timothy@apple.com>

        Correctly show DOCTYPE in the breadcrumbs and match the CSS rules
        from view-source.css for the DOCTYPE in the DOM tree.

        Reviewed by Adam Roben.

        * css/view-source.css: Add and correct comments about keeping
        in-sync with inspector.css.
        * page/inspector/ElementsPanel.js:
        (WebInspector.DocumentPanel.prototype.updateBreadcrumb):
        Add a case for Node.DOCUMENT_TYPE_NODE.
        * page/inspector/inspector.css: Add a rule for .webkit-html-doctype.
        * page/inspector/utilities.js:
        (nodeTitleInfo): Use the webkit-html-doctype class for nodes
        with Node.DOCUMENT_TYPE_NODE.

460
461
462
463
464
465
2008-04-04  Dan Bernstein  <mitz@apple.com>

        - try to fix the Tiger build

        * icu/unicode/uscript.h: Copied from WebKit/mac/icu/unicode/uscript.h.

466
467
468
469
470
471
472
473
474
475
2008-04-04  Adam Roben  <aroben@apple.com>

        Copy icu/ to PrivateHeaders for WebKit's benefit

        Rubberstamped by Tim Hatcher.

        * WebCore.xcodeproj/project.pbxproj: Renamed the Copy Forwarding
        Headers build phase to Copy Forwarding and ICU Headers, and added the
        icu/ directory to it.

476
477
478
479
480
481
482
483
484
485
486
2008-04-04  Adam Roben  <aroben@apple.com>

        Fix <rdar://problem/5804776> Would like to use WebCore's
        ForwardingHeaders in WebKit without manually creating copies

        Patch by Tim Hatcher, typed by me.

        * WebCore.xcodeproj/project.pbxproj: Added a new build phase, Copy
        Forwarding Headers, that copies the ForwardingHeaders directory to
        WebCore's PrivateHeaders directory.

adachan@apple.com's avatar
adachan@apple.com committed
487
488
489
490
491
492
493
494
495
496
497
2008-04-04  Ada Chan  <adachan@apple.com>

        Changed the signature of imageTitleForFilename so we can pass in the width
        and height as integers.

        Reviewed by Dan.

        * page/mac/WebCoreViewFactory.h:
        * platform/mac/LocalizedStringsMac.mm:
        (WebCore::imageTitle):

mitz@apple.com's avatar
mitz@apple.com committed
498
499
500
501
502
503
504
2008-04-03  Dan Bernstein  <mitz@apple.com>

        - Windows build fix

        * platform/graphics/win/FontCacheWin.cpp:
        (WebCore::matchImprovingEnumProc):

505
506
507
508
509
510
2008-04-03  Kevin Ollivier  <kevino@theolliviers.com>

        Fix PlatformGradient so that it's a pointer on all platforms.

        * platform/graphics/Gradient.h:

mitz@apple.com's avatar
mitz@apple.com committed
511
512
513
514
515
516
517
2008-04-03  Dan Bernstein  <mitz@apple.com>

        - 64-bit build fix

        * platform/mac/WebFontCache.mm:
        (+[WebFontCache internalFontWithFamily:traits:weight:size:]):

518
519
520
521
522
523
524
525
2008-04-03  Kevin Ollivier  <kevino@theolliviers.com>

        wx build fix. Add stubs for gradient class platform functions.

        * platform/graphics/wx/GradientWx.cpp: Added.
        (WebCore::Gradient::platformDestroy):
        (WebCore::Gradient::platformGradient):

kevino@webkit.org's avatar
kevino@webkit.org committed
526
527
528
529
530
531
532
533
534
2008-04-03  Kevin Ollivier  <kevino@theolliviers.com>

        Reviewed by Dan Bernstein.

        Refactor Gradient.h to have the same API on platforms 
        without a gradient class.

        * platform/graphics/Gradient.h:

mitz@apple.com's avatar
mitz@apple.com committed
535
536
537
538
539
540
541
2008-04-03  Dan Bernstein  <mitz@apple.com>

        - Qt build fix

        * platform/graphics/qt/FontQt.cpp:
        (WebCore::Font::Font):

mitz@apple.com's avatar
mitz@apple.com committed
542
543
544
545
546
547
548
2008-04-03  Dan Bernstein  <mitz@apple.com>

        - Tiger build fix

        * platform/mac/WebFontCache.mm:
        * rendering/RenderThemeMac.mm:

mitz@apple.com's avatar
mitz@apple.com committed
549
550
551
552
553
554
555
556
557
558
559
2008-04-03  Dan Bernstein  <mitz@apple.com>

        - Gtk build fix

        * platform/graphics/gtk/FontPlatformData.h:
        (WebCore::FontPlatformData::size):
        * platform/graphics/gtk/FontPlatformDataGtk.cpp:
        (WebCore::FontPlatformData::FontPlatformData):
        * platform/graphics/gtk/FontPlatformDataPango.cpp:
        (WebCore::FontPlatformData::FontPlatformData):

560
561
562
563
564
565
566
567
2008-04-03  Dan Bernstein  <mitz@apple.com>

        - project file updates in preparation for build fixes

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCoreSources.bkl:

mitz@apple.com's avatar
mitz@apple.com committed
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
2008-04-03  Nicholas Shanks  <webkit@nickshanks.com>

        Updated by Dan Bernstein. Reviewed by Dave Hyatt.

        - WebCore part of fixing http://bugs.webkit.org/show_bug.cgi?id=6484
          font-weight does not properly support graded weights

        Tests to come: <http://bugs.webkit.org/show_bug.cgi?id=18306>

        Build fixes for platforms other than Mac and Windows to come.

        * WebCore.vcproj/WebCore.vcproj: Added FontDescription.cpp.

        * WebCore.xcodeproj/project.pbxproj: Ditto.

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Changed to
        return additional weight value keywords 100, 200, 300, 500, 600, 800
        and 900.

        * css/CSSFontSelector.cpp:
        (WebCore::hashForFont): Changed the bold parameter into a weight
        parameter and added the weight to the string to be hashed.
        (WebCore::CSSFontSelector::addFontFaceRule): Changed to apply all CSS
        weight values to the font description.
        (WebCore::CSSFontSelector::getFontData): Updated the fallback logic to
        go through all weights equal or lighter from the desired weight. For
        SVG, to also consider heavier weights.

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue): Cleaned up parsing of the font-weight
        property.

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty): Changed to apply all CSS
        weight values to the font description.

        * platform/graphics/Font.h:
        (WebCore::Font::weight): Updated for the change to
        FontDescription::weight().

        * platform/graphics/FontCache.cpp:
        (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey): Replaced
        the bold component of the key with a weight component.
        (WebCore::FontPlatformDataCacheKey::operator==): Updated for the above.
        (WebCore::computeHash): Ditto.
        (WebCore::FontPlatformDataCacheKeyTraits::deletedValue): Removed
        unnecessary parameters.
        (WebCore::FontPlatformDataCacheKeyTraits::emptyValue): Ditto.
        (WebCore::FontCache::getCachedFontPlatformData): Updated for the change
        in FontPlatformDataCacheKey.

        * platform/graphics/FontDescription.cpp: Added.
        (WebCore::FontDescription::lighterWeight): Added. Returns a lighter CSS
        font-weight value if there is one, or the lightest value.
        (WebCore::FontDescription::bolderWeight): Added. Returns a heavier CSS
        font-weight value if there is one, or the heaviest value.

        * platform/graphics/FontDescription.h:
        (WebCore::FontWeight): Added this enumeration.
        (WebCore::FontDescription::FontDescription):
        (WebCore::FontDescription::bold): Removed.
        (WebCore::FontDescription::weight): Changed to return a FontWeight.
        (WebCore::FontDescription::setBold): Removed.
        (WebCore::FontDescription::setWeight): Changed to take a FontWeight.

        * platform/graphics/mac/FontCacheMac.mm:
        (WebCore::toAppKitFontWeight): Added. Maps a FontWeight to the AppKit
        font weight scale of 0-15.
        (WebCore::isAppKitFontWeightBold): Added.
        (WebCore::FontCache::getFontDataForCharacters): Changed to use a weight
        instead of the bold trait for custom fonts, and to decide whether to
        synthesize bold based on the weights rather than the bold trait.
        (WebCore::FontCache::fontExists): Updated for the change in
        WebFontCache .
        (WebCore::FontCache::createFontPlatformData): Ditto. Also changed to
        decide whether to synthesize bold based on the weights rather than on
        the bold trait.

        * platform/graphics/win/FontCacheWin.cpp:
        (WebCore::toGDIFontWeight): Added. Maps a FontWeight to a GDI font
        weight constant.
        (WebCore::isGDIFontWeightBold): Added.
        (WebCore::adjustedGDIFontWeight): Added.
        (WebCore::MatchImprovingProcData::MatchImprovingProcData): Added this
        data structure for use by the following callback.
        (WebCore::matchImprovingEnumProc): Added. The logic of this method is a
        simplification of the betterChoice() predicate in WebFontCache.mm, which
        considers only the italic trait and the weight.
        (WebCore::createGDIFont): Added. Similarly to
        +[WebFontCache fontWithFamily:traits:weight:size:], this function
        finds the closest match in the family for the desired italic bit and
        weight.
        (WebCore::FontCache::fontExists): Changed to call createGDIFont().
        (WebCore::FontCache::createFontPlatformData): Ditto. Also changed to
        compute the synthetic bold and synthetic italic flags based on weights
        and italic bits and pass them to the FontPlatformData constructor.

        * platform/graphics/win/FontPlatformDataWin.cpp:
        (WebCore::FontPlatformData::FontPlatformData): Changed the bold and
        oblique parameters to mean whether these should be synthesized and
        removed the font enumeration code that used to decide that.

        * platform/graphics/win/SimpleFontDataWin.cpp:
        (WebCore::SimpleFontData::smallCapsFontData): Changed to pass the
        synthetic bold and oblique flags from the full-size FontPlatformData to
        the FontPlatformData constructor for the small caps font.

        * platform/mac/WebCoreTextRenderer.h:
        * platform/mac/WebCoreTextRenderer.mm:
        (WebCoreFindFont): Added a weight parameter, which is passed to
        +[WebFontCache fontWithFamily:traits:weight:size:].

        * platform/mac/WebFontCache.h:
        * platform/mac/WebFontCache.mm:
        (acceptableChoice):
        (betterChoice): Changed to ignore the bold trait. Changed the logic for
        deciding based on weights to prefer the font whose weight is closer to
        the desired one, or, if both candidates' weights are the same distance
        from the desired weight, the one that is more "off-center". 
        (+[WebFontCache internalFontWithFamily:traits:weight:size:]): Changed to
        check for weight when matching by full name. Changed to pass
        the actual desired weight instead of the constant 5 to
        acceptableChoice() and betterChoice(). Changed to use weights to decide
        whether to synthesize bold.
        (+[WebFontCache fontWithFamily:traits:weight:size:]): Added a weight
        parameter, which is passed to the internal method.

        * platform/win/PopupMenuWin.cpp:
        (WebCore::PopupMenu::paint): Updated for the change to FontDescription.

        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::updateFromElement): Ditto.
        (WebCore::RenderListBox::paintItemForeground): Ditto.

        * rendering/RenderThemeMac.mm:
        (WebCore::toFontWeight): Added. Maps the AppKit font weight range of
        0-15 to the FontWeight range.
        (WebCore::RenderThemeMac::systemFont): Updated for the change to
        FontDescription.

        * rendering/RenderThemeSafari.cpp:
        (WebCore::RenderThemeSafari::systemFont): Ditto.

712
713
714
715
716
717
718
2008-04-03  Dan Bernstein  <mitz@apple.com>

        - another Gtk build fix attempt

        * platform/graphics/cairo/GradientCairo.cpp:
        (WebCore::Gradient::platformDestroy):

mitz@apple.com's avatar
mitz@apple.com committed
719
720
721
722
723
724
2008-04-03  Dan Bernstein  <mitz@apple.com>

        - attempted Gtk build fix

        * GNUmakefile.am:

mitz@apple.com's avatar
mitz@apple.com committed
725
726
727
728
729
730
731
2008-04-03  Dan Bernstein  <mitz@apple.com>

        - attempted Qt build fix

        * platform/graphics/qt/GradientQt.cpp:
        (WebCore::Gradient::platformDestroy):

mitz@apple.com's avatar
mitz@apple.com committed
732
733
734
735
736
737
738
2008-04-03  Dan Bernstein  <mitz@apple.com>

        - attempted Gtk build fix

        * html/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::stroke):

mitz@apple.com's avatar
mitz@apple.com committed
739
740
741
742
743
744
745
2008-04-03  Dan Bernstein  <mitz@apple.com>

        - attempted Qt build fix

        * html/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::stroke):

746
747
748
749
750
751
752
753
754
2008-04-03  Beth Dakin  <bdakin@apple.com>

        Reviewed by Alice.

        Build fix for non-Macs.

        * page/AXObjectCache.h:
        (WebCore::AXObjectCache::isIDinUse):

755
756
757
758
759
760
761
762
763
764
2008-04-03  Brent Fulgham  <bfulgham@gmail.com>

        Reviewed by Darin.

        Correct build error due to incomplete merging of changes to project
        files from Issue 17985.  This small project file patch corrects
        the build issue (see http://bugs.webkit.org/show_bug.cgi?id=18195).

        * WebCore.vcproj/WebCore.vcproj:

765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
2008-04-02  Beth Dakin  <bdakin@apple.com>

        Reviewed by Hyatt.

        This patch eliminates AccessibilityObjectMac. All of the platform-
        specific code is now in AccessibilityObjectWrapper.

        * WebCore.xcodeproj/project.pbxproj:
        * dom/Element.h:
        (WebCore::Element::isPasswordField):
        * html/HTMLInputElement.h:
        (WebCore::HTMLInputElement::isPasswordField):
        * page/AXObjectCache.h:
        (WebCore::AXObjectCache::isIDinUse):
        * page/AccessibilityObject.cpp:
        (WebCore::AccessibilityObject::isPasswordField):
        (WebCore::AccessibilityObject::press):
        (WebCore::AccessibilityObject::widgetForAttachmentView):
        (WebCore::AccessibilityObject::doAXBoundsForTextMarkerRange):
        (WebCore::AccessibilityObject::doAXTextMarkerForPosition):
        * page/AccessibilityObject.h:
        (WebCore::AccessibilityObject::areaElement):
        (WebCore::AccessibilityObject::setWrapper):
        * page/mac/AXObjectCacheMac.mm:
        * page/mac/AccessibilityObjectMac.mm: Removed.
        * page/mac/AccessibilityObjectWrapper.h:
        * page/mac/AccessibilityObjectWrapper.mm:
        (-[AccessibilityObjectWrapper attachmentView]):
        (textMarkerForVisiblePosition):
        (visiblePositionForTextMarker):
        (visiblePositionForStartOfTextMarkerRange):
        (visiblePositionForEndOfTextMarkerRange):
        (textMarkerRangeFromMarkers):
        (AXAttributeStringSetFont):
        (CreateCGColorIfDifferent):
        (AXAttributeStringSetColor):
        (AXAttributeStringSetNumber):
        (AXAttributeStringSetStyle):
        (blockquoteLevel):
        (AXAttributeStringSetBlockquoteLevel):
        (AXAttributeStringSetSpelling):
        (AXAttributeStringSetHeadingLevel):
        (AXLinkElementForNode):
        (AXAttributeStringSetElement):
        (AXAttributedStringAppendText):
        (nsStringForReplacedNode):
        (-[AccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]):
        (textMarkerRangeFromVisiblePositions):
        (-[AccessibilityObjectWrapper accessibilityActionNames]):
        (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
        (-[AccessibilityObjectWrapper visiblePositionRangeForTextMarkerRange:]):
        (-[AccessibilityObjectWrapper textMarkerRangeForSelection]):
        (-[AccessibilityObjectWrapper position]):
        (createAccessibilityRoleMap):
        (RoleEntry::):
        (roleValueToNSString):
        (-[AccessibilityObjectWrapper role]):
        (-[AccessibilityObjectWrapper subrole]):
        (-[AccessibilityObjectWrapper roleDescription]):
        (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
        (-[AccessibilityObjectWrapper accessibilityIsIgnored]):
        (-[AccessibilityObjectWrapper accessibilityPerformAction:]):
        (-[AccessibilityObjectWrapper doAXAttributedStringForRange:]):
        (-[AccessibilityObjectWrapper doAXRTFForRange:]):
        (-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
        (-[AccessibilityObjectWrapper accessibilityShouldUseUniqueId]):
        * platform/ScrollView.h:
        * platform/mac/ScrollViewMac.mm:
        (WebCore::ScrollView::viewRectToScreen):
        (WebCore::ScrollView::absolutePointToView):

836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
2008-04-03  David Hyatt  <hyatt@apple.com>

        Create a new cross-platform Gradient abstraction and make CanvasGradient wrap it.  This first
        step just cleans up CanvasGradient.  The code that calls it remains ifdef'd however.

        Reviewed by olliej

        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
        (WebCore::toJS):
        * html/CanvasGradient.cpp:
        (WebCore::CanvasGradient::CanvasGradient):
        * html/CanvasGradient.h:
        (WebCore::CanvasGradient::gradient):
        (WebCore::CanvasGradient::addColorStop):
        (WebCore::CanvasGradient::getColor):
        * html/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::fill):
        (WebCore::CanvasRenderingContext2D::stroke):
        (WebCore::CanvasRenderingContext2D::fillRect):
        * html/CanvasStyle.h:
        (WebCore::CanvasStyle::canvasGradient):
        * platform/graphics/Gradient.cpp: Added.
        (WebCore::Gradient::Gradient):
        (WebCore::Gradient::~Gradient):
        (WebCore::Gradient::addColorStop):
        (WebCore::compareStops):
        (WebCore::Gradient::getColor):
        (WebCore::Gradient::findStop):
        * platform/graphics/Gradient.h: Added.
        (WebCore::Gradient::ColorStop::ColorStop):
        (WebCore::Gradient::platformInit):
        * platform/graphics/cairo/GradientCairo.cpp: Added.
        (WebCore::Gradient::platformDestroy):
        (WebCore::Gradient::platformGradient):
        * platform/graphics/cg/GradientCG.cpp: Added.
        (WebCore::Gradient::platformDestroy):
        (WebCore::gradientCallback):
        (WebCore::Gradient::platformGradient):
        * platform/graphics/qt/GradientQt.cpp: Added.
        (WebCore::Gradient::platformDestroy):
        (WebCore::Gradient::platformGradient):

882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
2008-04-03  Simon Hausmann  <hausmann@webkit.org>

        Reviewed by Mark Rowe.

        Roll out r31599 and r31605 again after discussion with Mark Rowe.

        * history/HistoryItem.cpp:
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::startIconLoader):
        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::iconForPageURL):
        (WebCore::IconDatabase::readIconForPageURLFromDisk):
        * loader/icon/IconDatabase.h:
        * loader/icon/IconDatabaseNone.cpp:

897
898
899
900
901
902
903
904
905
2008-04-03  David Hyatt  <hyatt@apple.com>

        Fix for bug 18194, resizable text fields get messed up when resizing in the presence of zoom.

        Reviewed by adele

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::resize):

906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
2008-04-03  Oliver Hunt  <oliver@apple.com>

        Reviewed by NOBODY (Rollout).

        Rollout r31566 as there were a few issues i missed during review (thanks to antti for pointing them out)

        * dom/Element.h:
        * dom/NamedAttrMap.h:
        * rendering/SVGRootInlineBox.cpp:
        (WebCore::SVGRootInlineBox::buildLayoutInformation):
        (WebCore::SVGRootInlineBox::buildTextChunks):
        * svg/SVGAElement.h:
        (WebCore::SVGAElement::contextElement):
        * svg/SVGAltGlyphElement.h:
        (WebCore::SVGAltGlyphElement::contextElement):
        * svg/SVGAnimateColorElement.h:
        * svg/SVGAnimateElement.h:
        * svg/SVGAnimateMotionElement.h:
        * svg/SVGAnimateTransformElement.h:
        * svg/SVGAnimatedTemplate.h:
        (WebCore::SVGAnimatedTemplate::associatedAttributeName):
        (WebCore::lookupOrCreateWrapper):
        * svg/SVGAnimationElement.h:
        * svg/SVGCircleElement.h:
        (WebCore::SVGCircleElement::contextElement):
        * svg/SVGClipPathElement.h:
        (WebCore::SVGClipPathElement::contextElement):
        * svg/SVGComponentTransferFunctionElement.cpp:
        * svg/SVGComponentTransferFunctionElement.h:
        * svg/SVGCursorElement.cpp:
        (WebCore::SVGCursorElement::SVGCursorElement):
        * svg/SVGCursorElement.h:
        (WebCore::SVGCursorElement::contextElement):
        * svg/SVGDefsElement.h:
        (WebCore::SVGDefsElement::contextElement):
        * svg/SVGElement.cpp:
        * svg/SVGElement.h:
        (WebCore::SVGElement::svgAttributeChanged):
        * svg/SVGEllipseElement.cpp:
        (WebCore::SVGEllipseElement::SVGEllipseElement):
        * svg/SVGEllipseElement.h:
        (WebCore::SVGEllipseElement::contextElement):
        * svg/SVGExternalResourcesRequired.h:
        * svg/SVGFEBlendElement.h:
        * svg/SVGFEColorMatrixElement.cpp:
        * svg/SVGFEColorMatrixElement.h:
        * svg/SVGFEComponentTransferElement.h:
        * svg/SVGFECompositeElement.h:
        * svg/SVGFEDiffuseLightingElement.h:
        * svg/SVGFEDisplacementMapElement.h:
        * svg/SVGFEFloodElement.h:
        * svg/SVGFEGaussianBlurElement.h:
        * svg/SVGFEImageElement.cpp:
        * svg/SVGFEImageElement.h:
        (WebCore::SVGFEImageElement::contextElement):
        * svg/SVGFELightElement.h:
        * svg/SVGFEMergeElement.h:
        * svg/SVGFEMergeNodeElement.h:
        * svg/SVGFEOffsetElement.h:
        * svg/SVGFESpecularLightingElement.h:
        * svg/SVGFETileElement.h:
        * svg/SVGFETurbulenceElement.h:
        * svg/SVGFilterElement.cpp:
        (WebCore::SVGFilterElement::SVGFilterElement):
        * svg/SVGFilterElement.h:
        (WebCore::SVGFilterElement::contextElement):
        * svg/SVGFilterPrimitiveStandardAttributes.cpp:
        (WebCore::SVGFilterPrimitiveStandardAttributes::SVGFilterPrimitiveStandardAttributes):
        * svg/SVGFilterPrimitiveStandardAttributes.h:
        * svg/SVGFitToViewBox.cpp:
        * svg/SVGFitToViewBox.h:
        * svg/SVGFontElement.h:
        * svg/SVGForeignObjectElement.cpp:
        (WebCore::SVGForeignObjectElement::SVGForeignObjectElement):
        * svg/SVGForeignObjectElement.h:
        (WebCore::SVGForeignObjectElement::contextElement):
        * svg/SVGGElement.h:
        (WebCore::SVGGElement::contextElement):
        * svg/SVGGradientElement.cpp:
        * svg/SVGGradientElement.h:
        * svg/SVGImageElement.cpp:
        (WebCore::SVGImageElement::SVGImageElement):
        * svg/SVGImageElement.h:
        (WebCore::SVGImageElement::contextElement):
        * svg/SVGLength.cpp:
        * svg/SVGLength.h:
        * svg/SVGLengthList.cpp:
        * svg/SVGLengthList.h:
        * svg/SVGLineElement.cpp:
        (WebCore::SVGLineElement::SVGLineElement):
        * svg/SVGLineElement.h:
        (WebCore::SVGLineElement::contextElement):
        * svg/SVGLinearGradientElement.cpp:
        (WebCore::SVGLinearGradientElement::SVGLinearGradientElement):
        (WebCore::SVGLinearGradientElement::collectGradientProperties):
For faster browsing, not all history is shown. View entire blame