ChangeLog 5.15 MB
Newer Older
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
2012-09-04  Otto Derek Cheung  <otcheung@rim.com>

        [BlackBerry] Browser is not sending secured Cookie back to server over HTTPS connection
        https://bugs.webkit.org/show_bug.cgi?id=95747

        PR199729

        Reviewed by Rob Buis.
        Internally Reviewed by Joe Mason.

        If the browser has never saved a secure protocol cookie in its mapping before,
        and it tries to set and retreive a secure cookie over a non-secure
        protocol, it will not show up because the link between the secure and
        non-secure mapping isn't created until a cookie (sent through secure) is set.

        The fix is to also check for the linkage in getRawCookies. Note that we cannot
        map the secure CookieMap to the non-secure one because getRawCookies is a const
        function.

        Manually tested using our Browser Test suite.

        * platform/blackberry/CookieManager.cpp:
        (WebCore::CookieManager::getRawCookies):

25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
2012-09-04  Philippe Normand  <pnormand@igalia.com>

        [GStreamer] 0.11 build breaks due to rename of gst_message_new_duration
        https://bugs.webkit.org/show_bug.cgi?id=95751

        Reviewed by Martin Robinson.

        In gstreamer commit f712a9596c2bc1863edf9b816d9854eefca9ba45
        gst_message_new_duration was renamed to
        gst_message_new_duration_changed.

        However the only place where we used this is in the HTTP source
        element and only if appsrc < 0.10.27 is used at runtime. In the
        case of GStreamer 1.0 this condition will be always false so we
        can disable this code at build time.

        * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
        (StreamingClient::didReceiveResponse):

44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
2012-09-04  Andrei Poenaru  <poenaru@adobe.com>

        Web Inspector: Protocol Extension: Add "regionLayoutUpdate" event
        https://bugs.webkit.org/show_bug.cgi?id=93443

        Reviewed by Pavel Feldman.

        Added "regionLayoutUpdate" event to the protocol.

        Removed "getFlowByName" from protocol.

        The front-end keeps in sync the requested Named Flow Collections.

        Modified existing test: inspector/styles/protocol-css-regions-commands.html

        * dom/NamedFlowCollection.cpp:
        (WebCore::NamedFlowCollection::ensureFlowWithName):
        (WebCore::NamedFlowCollection::discardNamedFlow):
        * inspector/Inspector.json:
        * inspector/InspectorCSSAgent.cpp:
        (WebCore::InspectorCSSAgent::didCreateNamedFlow):
        (WebCore::InspectorCSSAgent::willRemoveNamedFlow):
        (WebCore):
        (WebCore::InspectorCSSAgent::didUpdateRegionLayout):
        (WebCore::InspectorCSSAgent::getNamedFlowCollection):
        (WebCore::InspectorCSSAgent::documentNodeWithRequestedFlowsId):
        * inspector/InspectorCSSAgent.h:
        (InspectorCSSAgent):
        * inspector/InspectorInstrumentation.cpp:
        (WebCore):
        (WebCore::InspectorInstrumentation::didCreateNamedFlowImpl):
        (WebCore::InspectorInstrumentation::willRemoveNamedFlowImpl):
        (WebCore::InspectorInstrumentation::didUpdateRegionLayoutImpl):
        * inspector/InspectorInstrumentation.h:
        (InspectorInstrumentation):
        (WebCore::InspectorInstrumentation::didCreateNamedFlow):
        (WebCore::InspectorInstrumentation::willRemoveNamedFlow):
        (WebCore):
        (WebCore::InspectorInstrumentation::didUpdateRegionLayout):
        * inspector/front-end/CSSStyleModel.js:
        (WebInspector.CSSStyleModel):
        (WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync.callback):
        (WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync):
        (WebInspector.CSSStyleModel.prototype.getFlowByNameAsync.callback):
        (WebInspector.CSSStyleModel.prototype.getFlowByNameAsync):
        (WebInspector.CSSStyleModel.prototype._namedFlowCreated):
        (WebInspector.CSSStyleModel.prototype._namedFlowRemoved):
        (WebInspector.CSSStyleModel.prototype._regionLayoutUpdated):
        (WebInspector.CSSStyleModel.prototype._resetNamedFlowCollections):
        (WebInspector.CSSDispatcher.prototype.namedFlowCreated):
        (WebInspector.CSSDispatcher.prototype.namedFlowRemoved):
        (WebInspector.CSSDispatcher.prototype.regionLayoutUpdated):
        (WebInspector.NamedFlow):
        (WebInspector.NamedFlowCollection):
        (WebInspector.NamedFlowCollection.prototype.appendNamedFlow):
        (WebInspector.NamedFlowCollection.prototype.removeNamedFlow):
        (WebInspector.NamedFlowCollection.prototype.flowByName):
        * rendering/RenderNamedFlowThread.cpp:
        (WebCore::RenderNamedFlowThread::dispatchRegionLayoutUpdateEvent):

104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
2012-09-04  Jonathan Liu  <net147@gmail.com>

        Fix IDL dependency generation correctly
        https://bugs.webkit.org/show_bug.cgi?id=95730

        Reviewed by Csaba Osztrogonác.

        IDL dependency generation is still not working after
        https://bugs.webkit.org/show_bug.cgi?id=88304. This is because spaces
        added after the filename in an echo command end up being added to the
        file which isn't handled correctly by preprocess-idls.pl. The problem
        is fixed by removing the space after the filename.

        * DerivedSources.pri:

119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
2012-09-04  Mario Sanchez Prada  <msanchez@igalia.com>

        [Stable] [GTK] Crash in WebCore::HTMLSelectElement::selectedIndex
        https://bugs.webkit.org/show_bug.cgi?id=95618

        Reviewed by Martin Robinson.

        Make sure we only emit the the signal for menu lists and list
        boxes rendered from actual HTML select elements.

        * accessibility/gtk/AXObjectCacheAtk.cpp:
        (WebCore::notifyChildrenSelectionChange): We support accessibility
        ListBoxes and MenuLists only here, assuming they represent HTML
        select elements, which might be not always true (e.g. ARIA). Thus,
        check if that condition is true, early returning in other case.

135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
2012-09-04  Martin Robinson  <mrobinson@igalia.com>

        [Cairo] [TextureMapper] Assertion failure in TextureMapperGL
        https://bugs.webkit.org/show_bug.cgi?id=95713

        Reviewed by Noam Rosenthal.

        Fix an assertion failure by returning a valid context always for GraphicsContext3D::platformContext.
        This is important because TextureMapperGL uses the platform context to perform hashing.

        No new tests. This is covered by existing accelerated compositing tests.

        * platform/graphics/cairo/GraphicsContext3DPrivate.cpp:
        (WebCore::GraphicsContext3DPrivate::platformContext): Return the current GLContext
        when getting the platform context for private GraphicsContext3DPrivates that render
        to the currently active context.

152
153
154
155
156
157
158
159
160
161
162
163
164
2012-09-04  Alexander Shalamov  <alexander.shalamov@intel.com>

        [EFL] Check if ecore_x is initialised before calling ecore_x_bell to avoid crash
        https://bugs.webkit.org/show_bug.cgi?id=86961

        Reviewed by Kenneth Rohde Christiansen.

        Add ecore_x initialisation check before calling ecore_x_bell
        to avoid crashes when X server is not running.

        * platform/efl/SoundEfl.cpp:
        (WebCore::systemBeep):

165
166
167
168
169
170
171
172
173
174
175
176
177
2012-09-04  Alexander Shalamov  <alexander.shalamov@intel.com>

        [EFL] Check if ecore_x is initialised before calling ecore_x_bell to avoid crash
        https://bugs.webkit.org/show_bug.cgi?id=86961

        Reviewed by Kenneth Rohde Christiansen.

        Add ecore_x initialisation check before calling ecore_x_bell
        to avoid crashes when X server is not running.

        * platform/efl/SoundEfl.cpp:
        (WebCore::systemBeep):

178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
2012-09-04  Alexander Shalamov  <alexander.shalamov@intel.com>

        [EFL][WK2] CSS3 Media Queries functionality is broken
        https://bugs.webkit.org/show_bug.cgi?id=95680

        Reviewed by Kenneth Rohde Christiansen.

        In WK2, WebProcess doesn't have access to ewk_view evas object.
        Methods that get screen rect or screen depth either return incorrect value or crash.
        This patch removes dependency to ewk_view evas object and relies on ecore_x_* functions
        to get screen rectangle or color depth of the screen.

        * platform/efl/EflScreenUtilities.cpp: removed unused getPixelDepth method definition
        * platform/efl/EflScreenUtilities.h: removed unsused getPixelDepth method declaration
        (WebCore):
        * platform/efl/PlatformScreenEfl.cpp:
        (WebCore):
        (WebCore::screenHorizontalDPI):
        (WebCore::screenVerticalDPI):
        (WebCore::screenDepth):
        (WebCore::screenDepthPerComponent):
        (WebCore::screenIsMonochrome):
        (WebCore::screenRect):

202
203
204
205
206
207
208
209
210
211
212
213
2012-09-04  Michał Pakuła vel Rutka  <m.pakula@samsung.com>

        [EFL] Context menu restore.
        https://bugs.webkit.org/show_bug.cgi?id=74179

        Reviewed by Gyuyoung Kim.

        Adds context menu support for EFL port using non-CROSS_PLATFORM_CONTEXT_MENUS
        approach, the same as used in WebKit2.

        * PlatformEfl.cmake: Removed -DWTF_USE_CROSS_PLATFORM_CONTEXT_MENUS=1

214
215
216
217
218
219
220
221
222
223
224
225
2012-09-04  Andrey Adaikin  <aandrey@chromium.org>

        Web Inspector: [WebGL] Bugfix: wrong texture binding target in replay for 3D textures
        https://bugs.webkit.org/show_bug.cgi?id=95687

        Reviewed by Vsevolod Vlasov.

        gl.bindTexture accepts either TEXTURE_2D or TEXTURE_CUBE_MAP targets, but we tried to replay with TEXTURE_CUBE_MAP_POSITIVE_X and others for 3D textures.

        * inspector/InjectedScriptWebGLModuleSource.js:
        (.):

226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
2012-09-04  Allan Sandfeld Jensen  <allan.jensen@nokia.com>

        Allow child-frame content in hit-tests.
        https://bugs.webkit.org/show_bug.cgi?id=95204

        Reviewed by Antonio Gomes.

        Refactors how EventHandler::hitTestResultAtPoint handles child-frame content,
        it is now handled by the hit test itself controlled by the AllowChildFrameContent
        flag in HitTestRequest.

        Tests: fast/dom/nodesFromRect/nodesFromRect-child-frame-content.html
               touchadjustment/iframe-boundary.html

        * WebCore.exp.in:
        * WebCore.order:
        * dom/Document.cpp:
        (WebCore::Document::nodesFromRect):
        * dom/Document.h:
        (Document):
        * page/EventHandler.cpp:
        (WebCore::EventHandler::hitTestResultAtPoint):
        * rendering/HitTestRequest.h:
        (WebCore::HitTestRequest::allowChildFrameContent):
        (WebCore::HitTestRequest::childFrameHitTest):
        (WebCore::HitTestRequest::testChildFrameScrollBars):
        * rendering/RenderFrameBase.cpp:
        (WebCore::RenderFrameBase::nodeAtPoint):
        (WebCore):
        * rendering/RenderFrameBase.h:
        (RenderFrameBase):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::hitTest):
        * testing/Internals.cpp:
        (WebCore::Internals::nodesFromRect):
        * testing/Internals.h:
        (Internals):
        * testing/Internals.idl:

265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
2012-09-04  Christophe Dumez  <christophe.dumez@intel.com>

        [EFL] Fix build error in NetworkStateNotifierEfl.cpp
        https://bugs.webkit.org/show_bug.cgi?id=95724

        Unreviewed EFL build fix.

        Make sure <sys/socket.h> is included before
        <linux/netlink.h> to fix build errors on some
        systems (e.g. Ubuntu 11.10).

        No new tests, no behavior change.

        * platform/network/efl/NetworkStateNotifierEfl.cpp:

280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
2012-09-04  Vsevolod Vlasov  <vsevik@chromium.org>

        Web Inspector: Create JavaScriptSources based on network resources.
        https://bugs.webkit.org/show_bug.cgi?id=95352

        Reviewed by Pavel Feldman.

        Introduced NetworkUISourceCodeProvider that is listening for ResourceTreeModel and creates UISourceCodes for them.
        RawSourceCode does not create uiSourceCodes based on resource anymore (this is done by NetworkUISourceCodeProvider instead).
        Moved script <-> uiSourceCode binding logic from RawSourceCode to ResourceScriptMapping.
        Removed rawSourceCode as it was not needed anymore.

        Tests: inspector/debugger/network-uisourcecode-provider.html
               inspector/debugger/resource-script-mapping.html

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/compile-front-end.py:
        * inspector/front-end/CompilerScriptMapping.js:
        * inspector/front-end/DebuggerModel.js:
        (WebInspector.DebuggerDispatcher.prototype.scriptFailedToParse):
        * inspector/front-end/JavaScriptSource.js:
        (WebInspector.JavaScriptSource):
        * inspector/front-end/NetworkUISourceCodeProvider.js: Renamed from Source/WebCore/inspector/front-end/StylesUISourceCodeProvider.js.
        (WebInspector.NetworkUISourceCodeProvider):
        (WebInspector.NetworkUISourceCodeProvider.prototype._populate):
        (WebInspector.NetworkUISourceCodeProvider.prototype._styleResourceAdded):
        (WebInspector.NetworkUISourceCodeProvider.prototype._scriptResourceAdded.resourceFinished):
        (WebInspector.NetworkUISourceCodeProvider.prototype._scriptResourceAdded):
        (WebInspector.NetworkUISourceCodeProvider.prototype._addJavaScriptSource):
        (WebInspector.NetworkUISourceCodeProvider.prototype._addUISourceCode):
        (WebInspector.NetworkUISourceCodeProvider.prototype._resourceAdded):
        (WebInspector.NetworkUISourceCodeProvider.prototype._reset):
        * inspector/front-end/RawSourceCode.js:
        * inspector/front-end/ResourceScriptMapping.js:
        (WebInspector.ResourceScriptMapping):
        (WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
        (WebInspector.ResourceScriptMapping.prototype._bindUISourceCodeToScripts):
        (WebInspector.ResourceScriptMapping.prototype._scriptsForSourceURL):
        (WebInspector.ResourceScriptMapping.prototype._addOrReplaceTemporaryUISourceCode.get var):
        (WebInspector.ResourceScriptMapping.prototype._addOrReplaceTemporaryUISourceCode):
        (WebInspector.ResourceScriptMapping.prototype.get _uiSourceCodeReplaced):
        (WebInspector.ResourceScriptMapping.prototype._reset):
        * inspector/front-end/ScriptSnippetModel.js:
        (WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
        (WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):
        (WebInspector.SnippetJavaScriptSource):
        * inspector/front-end/UISourceCode.js:
        (WebInspector.UISourceCode):
        (WebInspector.UISourceCode.prototype.uiLocationToRawLocation):
        (WebInspector.UISourceCode.prototype.setSourceMapping):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/Workspace.js: Drive-by: fixed duplicating uiSourceCodes in workspace.
        * inspector/front-end/inspector.html:
        * inspector/front-end/inspector.js:

336
337
338
339
340
341
342
343
344
345
346
347
2012-09-04  Andrey Adaikin  <aandrey@chromium.org>

        Web Inspector: [WebGL] Save gl.getError() status before taking a WebGL state snapshot and restore it afterwards
        https://bugs.webkit.org/show_bug.cgi?id=95443

        Reviewed by Vsevolod Vlasov.

        Save gl.getError() status before taking the GL snapshot and restore it afterwards.

        * inspector/InjectedScriptWebGLModuleSource.js:
        (.):

348
349
350
351
352
353
354
355
356
357
358
2012-09-04  Alexander Pavlov  <apavlov@chromium.org>

        Web Inspector: More directional control characters for debugging in inspector
        https://bugs.webkit.org/show_bug.cgi?id=95696

        Reviewed by Vsevolod Vlasov.

        Entities for text directionality-related characters added (LRE, RLE, LRO, RLO, PDF).

        * inspector/front-end/ElementsTreeOutline.js:

359
360
361
362
363
364
365
366
367
368
369
370
2012-09-04  Yury Semikhatsky  <yurys@chromium.org>

        Web Inspector: new CPU Profiles are not shown after reattach
        https://bugs.webkit.org/show_bug.cgi?id=95686

        Reviewed by Vsevolod Vlasov.

        * inspector/InspectorProfilerAgent.cpp:
        (WebCore::InspectorProfilerAgent::restore): set m_headersRequested flags
        to true and clear all profiles on the front-end since there are no
        collected profiles yet immediately after render process sitching.

371
372
373
374
375
376
377
378
379
380
381
382
383
2012-09-04  Ilya Tikhonovsky  <loislo@chromium.org>

        Web Inspector: NMI: cosmetic change, rename m_domMemoryUsage to m_memoryInstrumentation.
        https://bugs.webkit.org/show_bug.cgi?id=95716

        Also m_memoryInstrumentation became a reference to external object because it has other life time than domNodeVisitor.

        Reviewed by Yury Semikhatsky.

        * inspector/InspectorMemoryAgent.cpp:
        (WebCore):
        (WebCore::collectDomTreeInfo):

384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
2012-08-31  Simon Hausmann  <simon.hausmann@nokia.com>

        [Qt] Port the Qt pixmap JS bindings to use the JSC C API
        https://bugs.webkit.org/show_bug.cgi?id=94702

        Reviewed by Kenneth Rohde Christiansen.

        Based on patch by Noam Rosenthal.

        The conversion uses a simple JSClassRef based binding and only a few
        uses of private JSC API for the HTML element DOM bindings remain.

        This is essentially used for wrapping QPixmap and QImage types in
        JavaScript and the other way around, for retrieving the image data
        out of a HTML image element when converting from JS/DOM to Qt.

        * bridge/qt/qt_pixmapruntime.cpp:
        (JSC::Bindings::copyPixels):
        (JSC::Bindings::toPixmap):
        (JSC::Bindings::toImage):
        (JSC::Bindings::imageSizeForVariant):
        (JSC::Bindings::getPixmapWidth):
        (JSC::Bindings::getPixmapHeight):
        (JSC::Bindings::assignToHTMLImageElement):
        (JSC::Bindings::pixmapToImageData):
        (JSC::Bindings::pixmapToDataUrl):
        (JSC::Bindings::pixmapToString):
        (JSC::Bindings::QtPixmapRuntime::toJS):
        (JSC::Bindings::QtPixmapRuntime::toQt):
        (JSC::Bindings::QtPixmapRuntime::canHandle):
        (JSC::Bindings::QtPixmapRuntime::getClassRef):
        * bridge/qt/qt_pixmapruntime.h:
        (QtPixmapRuntime):
        * bridge/qt/qt_runtime.cpp:
        (JSC::Bindings::convertValueToQVariant):
        (JSC::Bindings::convertQVariantToValue):

421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
2012-09-03  Andreas Kling  <kling@webkit.org>

        Share immutable ElementAttributeData between elements with identical attributes.
        <http://webkit.org/b/94990>

        Reviewed by Antti Koivisto.

        Keep a cache of ElementAttributeData objects for a given set of attributes and reuse
        them in elements with identical attribute maps. ElementAttributeData is made ref-counted
        to facilitate this. A copy-on-write mechanism is already in place, since mutating call
        sites have to go via Element::mutableAttributeData().

        The cache is held by Document and cleared in Document::finishedParsing() since the vast
        majority of immutable ElementAttributeData will be constructed during parsing.

        On the HTML5 spec at <http://whatwg.org/c/>, we get a cache hit rate of nearly 80%,
        translating into a 3.5MB reduction in memory use.

        * dom/Document.cpp:
        (WebCore::Document::finishedParsing):
        (ImmutableAttributeDataCacheKey):
        (WebCore::ImmutableAttributeDataCacheKey::ImmutableAttributeDataCacheKey):
        (WebCore::ImmutableAttributeDataCacheKey::operator!=):
        (WebCore::ImmutableAttributeDataCacheKey::hash):
        (ImmutableAttributeDataCacheEntry):
        (WebCore::Document::cachedImmutableAttributeData):
        * dom/Document.h:
        * dom/Element.cpp:
        (WebCore::Element::parserSetAttributes):
        * dom/Element.h:
        * dom/ElementAttributeData.cpp:
        (WebCore::ElementAttributeData::createImmutable):
        (WebCore::ElementAttributeData::ElementAttributeData):
        * dom/ElementAttributeData.h:
        (WebCore::ElementAttributeData::create):
        (ElementAttributeData):
        (WebCore::ElementAttributeData::makeMutable):

459
460
461
462
463
464
465
466
467
468
469
470
471
472
2012-09-03  Peter Wang  <peter.wang@torchmobile.com.cn>

        Web Inspector: the URL of worker inspector window sometimes is invalid
        https://bugs.webkit.org/show_bug.cgi?id=95334

        Reviewed by Pavel Feldman.

        In "_openInspectorWindow", before "&dedicatedWorkerId=" should have a '?' to make the whole URL valid.

        No new tests case for this bug.

        * inspector/front-end/WorkerManager.js:
        (WebInspector.WorkerManager.prototype._openInspectorWindow):

473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
2012-09-03  Jinwoo Song  <jinwoo7.song@samsung.com>

        [EFL] Fix e_dbus_shutdown() error when exiting the Minibrowser
        https://bugs.webkit.org/show_bug.cgi?id=95636

        Reviewed by Gyuyoung Kim.

        Check if the m_timer is active in stopUpdating()
        to know the BatteryProvider is updating or not.
        By checking the timer, stopUpdating() will be called 
        only BatteryProviderEfl is updating.

        * platform/efl/BatteryProviderEfl.cpp:
        (WebCore::BatteryProviderEfl::stopUpdating):

488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
2012-09-03  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r127427.
        http://trac.webkit.org/changeset/127427
        https://bugs.webkit.org/show_bug.cgi?id=95695

        Breaks some inspector/debugger tests on JSC (Requested by
        vsevik on #webkit).

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/compile-front-end.py:
        * inspector/front-end/CompilerScriptMapping.js:
        * inspector/front-end/JavaScriptSource.js:
        (WebInspector.JavaScriptSource):
        * inspector/front-end/NetworkUISourceCodeProvider.js: Removed.
        * inspector/front-end/RawSourceCode.js:
        (WebInspector.RawSourceCode):
        (WebInspector.RawSourceCode.prototype.addScript):
        (WebInspector.RawSourceCode.prototype.rawLocationToUILocation):
        (WebInspector.RawSourceCode.prototype._createUISourceCode):
        (WebInspector.RawSourceCode.prototype.uiLocationToRawLocation):
        (WebInspector.RawSourceCode.prototype.uiSourceCode):
        (WebInspector.RawSourceCode.prototype._finishedLoading):
        * inspector/front-end/ResourceScriptMapping.js:
        (WebInspector.ResourceScriptMapping):
        (WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
        (WebInspector.ResourceScriptMapping.prototype.addScript):
        (WebInspector.ResourceScriptMapping.prototype._shouldBindScriptToContentProvider):
        (WebInspector.ResourceScriptMapping.prototype._handleUISourceCodeChanged):
        (WebInspector.ResourceScriptMapping.prototype._uiSourceCodeAdded):
        (WebInspector.ResourceScriptMapping.prototype._uiSourceCodeReplaced):
        (WebInspector.ResourceScriptMapping.prototype._uiSourceCodeRemoved):
        (WebInspector.ResourceScriptMapping.prototype._bindScriptToRawSourceCode):
        (WebInspector.ResourceScriptMapping.prototype._reset):
        * inspector/front-end/ScriptSnippetModel.js:
        (WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
        (WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):
        (WebInspector.SnippetJavaScriptSource):
        * inspector/front-end/StylesUISourceCodeProvider.js: Added.
        (WebInspector.StylesUISourceCodeProvider):
        (WebInspector.StylesUISourceCodeProvider.prototype._populate):
        (WebInspector.StylesUISourceCodeProvider.prototype._resourceAdded):
        (WebInspector.StylesUISourceCodeProvider.prototype._reset):
        * inspector/front-end/UISourceCode.js:
        (WebInspector.UISourceCode):
        (WebInspector.UISourceCode.prototype.uiLocationToRawLocation):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.html:
        * inspector/front-end/inspector.js:

539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
2012-09-03  Vsevolod Vlasov  <vsevik@chromium.org>

        Web Inspector: Create JavaScriptSources based on network resources.
        https://bugs.webkit.org/show_bug.cgi?id=95352

        Reviewed by Pavel Feldman.

        Introduced NetworkUISourceCodeProvider that is listening for ResourceTreeModel and creates UISourceCodes for them.
        RawSourceCode does not create uiSourceCodes based on resource anymore (this is done by NetworkUISourceCodeProvider instead).
        Moved script <-> uiSourceCode binding logic from RawSourceCode to ResourceScriptMapping.
        Removed rawSourceCode as it was not needed anymore.

        Tests: inspector/debugger/network-uisourcecode-provider.html
               inspector/debugger/resource-script-mapping.html

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/compile-front-end.py:
        * inspector/front-end/CompilerScriptMapping.js:
        * inspector/front-end/JavaScriptSource.js:
        (WebInspector.JavaScriptSource):
        * inspector/front-end/NetworkUISourceCodeProvider.js: Renamed from Source/WebCore/inspector/front-end/StylesUISourceCodeProvider.js.
        (WebInspector.NetworkUISourceCodeProvider):
        (WebInspector.NetworkUISourceCodeProvider.prototype._populate):
        (WebInspector.NetworkUISourceCodeProvider.prototype._styleResourceAdded):
        (WebInspector.NetworkUISourceCodeProvider.prototype._scriptResourceAdded.resourceFinished):
        (WebInspector.NetworkUISourceCodeProvider.prototype._scriptResourceAdded):
        (WebInspector.NetworkUISourceCodeProvider.prototype._addJavaScriptSource):
        (WebInspector.NetworkUISourceCodeProvider.prototype._addUISourceCode):
        (WebInspector.NetworkUISourceCodeProvider.prototype._resourceAdded):
        (WebInspector.NetworkUISourceCodeProvider.prototype._reset):
        * inspector/front-end/RawSourceCode.js:
        * inspector/front-end/ResourceScriptMapping.js:
        (WebInspector.ResourceScriptMapping):
        (WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
        (WebInspector.ResourceScriptMapping.prototype._bindUISourceCodeToScripts):
        (WebInspector.ResourceScriptMapping.prototype._scriptsForSourceURL):
        (WebInspector.ResourceScriptMapping.prototype._addOrReplaceTemporaryUISourceCode.get var):
        (WebInspector.ResourceScriptMapping.prototype._addOrReplaceTemporaryUISourceCode):
        (WebInspector.ResourceScriptMapping.prototype.get _uiSourceCodeReplaced):
        (WebInspector.ResourceScriptMapping.prototype._reset):
        * inspector/front-end/ScriptSnippetModel.js:
        (WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
        (WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):
        (WebInspector.SnippetJavaScriptSource):
        * inspector/front-end/UISourceCode.js:
        (WebInspector.UISourceCode):
        (WebInspector.UISourceCode.prototype.uiLocationToRawLocation):
        (WebInspector.UISourceCode.prototype.setSourceMapping):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.html:
        * inspector/front-end/inspector.js:

592
593
594
595
596
597
598
599
600
601
602
603
604
605
2012-09-03  Andrey Adaikin  <aandrey@chromium.org>

        Web Inspector: [WebGL] Make the injected __resourceObject property non-enumerable
        https://bugs.webkit.org/show_bug.cgi?id=95682

        Reviewed by Pavel Feldman.

        Make the injected auxiliary property __resourceObject non-enumerable to hide it from for..in iterations.
        Ideally this property should be completely hidden from the user's code.
        Drive-by: Fix couple of small FIXME's.

        * inspector/InjectedScriptWebGLModuleSource.js:
        (.):

606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
2012-09-03  Tommy Widenflycht  <tommyw@google.com>

        MediaStream API: Add Ice-related functionality to RTCPeerConnection
        https://bugs.webkit.org/show_bug.cgi?id=95565

        Reviewed by Adam Barth.

        Adds all Ice-related functionality to RTCPeerConnection, including
        events, callbacks and methods.

        Test: fast/mediastream/RTCPeerConnection-ice.html

        * CMakeLists.txt:
        * GNUmakefile.list.am:
        * Modules/mediastream/RTCIceCandidateEvent.cpp: Added.
        (WebCore):
        (WebCore::RTCIceCandidateEvent::create):
        (WebCore::RTCIceCandidateEvent::RTCIceCandidateEvent):
        (WebCore::RTCIceCandidateEvent::~RTCIceCandidateEvent):
        (WebCore::RTCIceCandidateEvent::candidate):
        (WebCore::RTCIceCandidateEvent::interfaceName):
        * Modules/mediastream/RTCIceCandidateEvent.h: Added.
        (WebCore):
        (RTCIceCandidateEvent):
        * Modules/mediastream/RTCIceCandidateEvent.idl: Added.
        * Modules/mediastream/RTCPeerConnection.cpp:
        (WebCore::RTCPeerConnection::RTCPeerConnection):
        (WebCore::RTCPeerConnection::updateIce):
        (WebCore):
        (WebCore::RTCPeerConnection::addIceCandidate):
        (WebCore::RTCPeerConnection::iceState):
        (WebCore::RTCPeerConnection::close):
        (WebCore::RTCPeerConnection::didGenerateIceCandidate):
        (WebCore::RTCPeerConnection::didChangeIceState):
        (WebCore::RTCPeerConnection::stop):
        (WebCore::RTCPeerConnection::changeIceState):
        * Modules/mediastream/RTCPeerConnection.h:
        (RTCPeerConnection):
        * Modules/mediastream/RTCPeerConnection.idl:
        * WebCore.gypi:
        * dom/EventNames.h:
        (WebCore):
        * dom/EventNames.in:
        * platform/chromium/support/WebRTCICECandidateDescriptor.cpp: Copied from Source/WebCore/platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp.
        (WebKit):
        (WebKit::WebRTCICECandidateDescriptor::WebRTCICECandidateDescriptor):
        (WebKit::WebRTCICECandidateDescriptor::assign):
        (WebKit::WebRTCICECandidateDescriptor::reset):
        (WebKit::WebRTCICECandidateDescriptor::initialize):
        (WebKit::WebRTCICECandidateDescriptor::operator PassRefPtr<WebCore::RTCIceCandidateDescriptor>):
        (WebKit::WebRTCICECandidateDescriptor::candidate):
        (WebKit::WebRTCICECandidateDescriptor::sdpMid):
        (WebKit::WebRTCICECandidateDescriptor::sdpMLineIndex):
        * platform/mediastream/RTCIceCandidateDescriptor.h:
        (WebCore::RTCIceCandidateDescriptor::candidate):
        (WebCore::RTCIceCandidateDescriptor::sdpMid):
        (WebCore::RTCIceCandidateDescriptor::sdpMLineIndex):
        * platform/mediastream/RTCPeerConnectionHandler.h:
        (WebCore):
        (RTCPeerConnectionHandler):
        * platform/mediastream/RTCPeerConnectionHandlerClient.h:
        (WebCore):
        (RTCPeerConnectionHandlerClient):
        * platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:
        (WebCore::RTCPeerConnectionHandlerChromium::updateIce):
        (WebCore):
        (WebCore::RTCPeerConnectionHandlerChromium::addIceCandidate):
        (WebCore::RTCPeerConnectionHandlerChromium::didGenerateICECandidate):
        (WebCore::RTCPeerConnectionHandlerChromium::didChangeICEState):
        * platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:
        (WebKit):
        (RTCPeerConnectionHandlerChromium):

679
680
681
682
683
684
685
2012-09-03  Allan Sandfeld Jensen  <allan.jensen@nokia.com>

        Unreviewed build fix after r127421

        * rendering/HitTestResult.cpp:
        (WebCore::HitTestLocation::HitTestLocation):

686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
2012-09-03  Allan Sandfeld Jensen  <allan.jensen@nokia.com>

        Move AllowShadowContent flag to HitTestRequest 
        https://bugs.webkit.org/show_bug.cgi?id=95685

        Reviewed by Antonio Gomes.

        Moves the flag and updates the interface for HitTestResult::addNodeToRectBasedTestResult so that
        it can read the flag from HitTestRequest instead of from HitTestResult.

        No change in functionality. No new tests.

        * dom/Document.cpp:
        (WebCore::Document::nodesFromRect):
        * page/EventHandler.cpp:
        (WebCore::EventHandler::hitTestResultAtPoint):
        * rendering/HitTestRequest.h:
        * rendering/HitTestResult.cpp:
        (WebCore::HitTestLocation::HitTestLocation):
        (WebCore::HitTestResult::HitTestResult):
        (WebCore::HitTestResult::operator=):
        (WebCore::HitTestResult::addNodeToRectBasedTestResult):
        * rendering/HitTestResult.h:
        (HitTestLocation):
        (HitTestResult):
        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::nodeAtPoint):
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::nodeAtPoint):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::nodeAtPoint):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::nodeAtPoint):
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::nodeAtPoint):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::hitTestLayer):
        (WebCore::RenderLayer::hitTestList):
        * rendering/RenderMultiColumnSet.cpp:
        (WebCore::RenderMultiColumnSet::nodeAtPoint):
        * rendering/RenderRegion.cpp:
        (WebCore::RenderRegion::nodeAtPoint):
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::nodeAtPoint):
        * rendering/svg/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::nodeAtPoint):
        * rendering/svg/SVGInlineTextBox.cpp:
        (WebCore::SVGInlineTextBox::nodeAtPoint):

735
736
737
738
739
740
741
742
743
744
745
746
2012-09-03  Alexander Pavlov  <apavlov@chromium.org>

        Web Inspector: Unhide hidden characters
        https://bugs.webkit.org/show_bug.cgi?id=93888

        Reviewed by Pavel Feldman.

        Certain invisible characters will be rendered as HTML entity references in the DOM tree to make them visible to the user.

        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype._startEditingTextNode):

747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
2012-09-03  Pavel Feldman  <pfeldman@chromium.org>

        Web Inspector: rename JavaScriptContextManager to RuntimeModel for consistency.
        https://bugs.webkit.org/show_bug.cgi?id=95677

        Reviewed by Yury Semikhatsky.

        - renamed the file and the usages
        - renamed isolatedContextCreated to executionContextCreated for consistency.

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/Inspector.json:
        * inspector/PageRuntimeAgent.cpp:
        (WebCore::PageRuntimeAgent::notifyContextCreated):
        * inspector/compile-front-end.py:
        * inspector/front-end/RuntimeModel.js: Renamed from Source/WebCore/inspector/front-end/JavaScriptContextManager.js.
        (WebInspector.RuntimeModel):
        (WebInspector.RuntimeModel.prototype._frameAdded):
        (WebInspector.RuntimeModel.prototype._frameDetached):
        (WebInspector.RuntimeModel.prototype._executionContextCreated):
        (WebInspector.RuntimeDispatcher):
        (WebInspector.RuntimeDispatcher.prototype.executionContextCreated):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.html:

773
774
775
776
777
778
779
780
781
782
783
784
785
786
2012-09-03  Andrey Kosyakov  <caseq@chromium.org>

        Web Inspector: use linkifyResourceAsNode, not linkifyLocation when linkifying resources in Timeline
        https://bugs.webkit.org/show_bug.cgi?id=95540

        Reviewed by Pavel Feldman.

        Linkify recource details using WebInspector.linkifyResourceAsNode(), so these bypass linkifier. Also
        fix closure compiler warning.

        * inspector/front-end/TimelinePresentationModel.js:
        (WebInspector.TimelinePresentationModel.Record.prototype._generatePopupContentWithImagePreview):
        (WebInspector.TimelinePresentationModel.Record.prototype._linkifyLocation):

787
788
789
790
791
792
793
794
2012-09-03  'Pavel Feldman'  <pfeldman@chromium.org>

        Web Inspector: fixed front-end compilation warnings.
        Not reviewed.

        * inspector/front-end/FilteredItemSelectionDialog.js:
        * inspector/front-end/HeapSnapshotView.js:

795
796
797
798
799
800
801
802
803
804
805
2012-09-03  Pavel Feldman  <pfeldman@chromium.org>

        Web Inspector: paint grid on top of box highlight.
        https://bugs.webkit.org/show_bug.cgi?id=95676

        Reviewed by Alexander Pavlov.

        Otherwise, ruler numbers are not visible when selecting body.

        * inspector/InspectorOverlayPage.html:

806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
2012-08-31  Pavel Feldman  <pfeldman@chromium.org>

        Web Inspector: get rid of context execution id fallback.
        https://bugs.webkit.org/show_bug.cgi?id=95567

        Reviewed by Yury Semikhatsky.

        We now assign execution context id upon changes in the UI.

        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype.get statusBarItems):
        (WebInspector.ConsoleView.prototype._contextAdded):
        (WebInspector.ConsoleView.prototype._addContextList):
        (WebInspector.ConsoleView.prototype._contextListRemoved):
        (WebInspector.ConsoleView.prototype._updateExecutionContextSelector):
        (WebInspector.ConsoleView.prototype._appendExecutionContextOption):
        (WebInspector.ConsoleView.prototype._executionContextChanged):
        (WebInspector.ConsoleView.prototype._contextListUpdated):
        (WebInspector.ConsoleView.prototype._addedExecutionContext):
        (WebInspector.ConsoleView.prototype.evalInInspectedWindow.evalCallback):
        (WebInspector.ConsoleView.prototype.evalInInspectedWindow):
        (WebInspector.ConsoleView.prototype._enterKeyPressed):
        * inspector/front-end/JavaScriptContextManager.js:
        (WebInspector.JavaScriptContextManager):
        (WebInspector.JavaScriptContextManager.prototype.contextLists):
        (WebInspector.JavaScriptContextManager.prototype.contextByFrameAndSecurityOrigin):
        (WebInspector.JavaScriptContextManager.prototype._frameAdded):
        (WebInspector.JavaScriptContextManager.prototype._frameNavigated):
        (WebInspector.JavaScriptContextManager.prototype._frameDetached):
        (WebInspector.JavaScriptContextManager.prototype.isolatedContextCreated):
        (WebInspector.FrameExecutionContextList):
        (WebInspector.FrameExecutionContextList.prototype._frameNavigated):
        (WebInspector.FrameExecutionContextList.prototype._addExecutionContext):
        (WebInspector.FrameExecutionContextList.prototype.executionContexts):
        (WebInspector.FrameExecutionContextList.prototype.contextBySecurityOrigin):

842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
2012-09-03  Grzegorz Czajkowski  <g.czajkowski@samsung.com>

        [GTK][EFL] 'dictIter' iterator is not initialized for an inner loop
        https://bugs.webkit.org/show_bug.cgi?id=95436

        Reviewed by Gustavo Noronha Silva.

        The 'checkSpellingOfString' method assumes that the given string is concatenation of words.
        To properly handle spellchecking of each word we need to iterate over the all available
        dictionaries ('dictIter').

        To allow spellchecking for multiple words, 'dictIter' should be initialized at the beginning
        of vector while spellchecking of the word. This ensures performing of spelling for word based on
        at least one dictionary.

        * platform/text/enchant/TextCheckerEnchant.cpp:
        (TextCheckerEnchant::checkSpellingOfString): Moved initialization of 'dictIter' to an inner loop.

860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
2012-09-02  Yoshifumi Inoue  <yosin@chromium.org>

        [Forms] Empty visible value of AM/PM field of multiple fields time input UI should display variable number of "-" based on maximum number of labels
        https://bugs.webkit.org/show_bug.cgi?id=95660

        Reviewed by Kent Tamura.

        This patch changes visible empty value of AM/PM field in multiple
        fields time input UI to "-", "--", "---", and so on based on maximum
        length of AM/PM labels. In current implementation, it is always "--"
        regardless locale, although on Arabic, AM/PM are represented in one
        character.

        This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
        ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

        No new tests. Once multiple field time input UI uses "lang" HTML
        attribute to take time format, we can write a test for this patch.

        * html/shadow/DateTimeSymbolicFieldElement.cpp:
        (makeVisibleEmptyValue): Build visible empty value from maximum length
        of labels.
        (WebCore::DateTimeSymbolicFieldElement::visibleEmptyValue): Changed to
        use m_visibleEmptyValue.
        * html/shadow/DateTimeSymbolicFieldElement.h:
        (WebCore::DateTimeSymbolicFieldElement): Added new member variable
        m_visibleEmptyValue to hold visible empty value.

888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
2012-09-02  Yoshifumi Inoue  <yosin@chromium.org>

        [Forms] AM/PM field of multiple fields time input UI should be fixed width
        https://bugs.webkit.org/show_bug.cgi?id=95542

        Reviewed by Kent Tamura.

        This patch changes width of AM/PM field of multiple field time input
        UI fixed as maximum width of labels or "--".

        This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
        ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

        No new tests. Once multiple field time input UI uses "lang" HTML
        attribute to take time format, we can write a test for this patch.

        * css/html.css:
        (input::-webkit-datetime-edit-ampm-field): Added "display" property to "inline-block" for setting width.
        Added "text-align" property to "center".
        * html/shadow/DateTimeSymbolicFieldElement.cpp:
        (WebCore::DateTimeSymbolicFieldElement::DateTimeSymbolicFieldElement): Changed to call setHasCustomCallback().
        (WebCore::DateTimeSymbolicFieldElement::customStyleForRenderer): Added for setting field with from maximum width of labels.
        * html/shadow/DateTimeSymbolicFieldElement.h:
        (WebCore::DateTimeSymbolicFieldElement::visibleEmptyValue): Added for using visible empty value in customStyleForRenderer() and visibleValue().
        (WebCore::DateTimeSymbolicFieldElement::visibleValue): Changed to call visibleEmptyValue() instead of using literal "--".
        (DateTimeSymbolicFieldElement): Added a declaration of customStyleForRenderer().

915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
2012-09-02  Benjamin Poulain  <bpoulain@apple.com>

        Improve the way we use convertedSpaceString() in convertHTMLTextToInterchangeFormat()
        https://bugs.webkit.org/show_bug.cgi?id=95301

        Reviewed by Darin Adler.

        The static string convertedSpaceString() had a couple of annoying side effects:
        -The string was 16bits due to noBreakSpace, which forced any input to be converted to 16bits.
        -The string was kept in the heap for no particular reason.

        This patch redefines convertedSpaceString as a constant literal so that we can use it efficiently.

        The patch also make the binary a tiny bit smaller (700 bytes).

        * editing/HTMLInterchange.cpp:
        (WebCore::convertHTMLTextToInterchangeFormat):

933
934
935
936
937
938
939
940
941
942
943
944
2012-09-02  Mike West  <mkwst@chromium.org>

        Build is broken when SVG is disabled.
        https://bugs.webkit.org/show_bug.cgi?id=95653

        Reviewed by Dirk Schulze.

        Adding CSSPropertyWebkitClipPath to the massive switch statement in StyleResolver.

        * css/StyleResolver.cpp:
        (WebCore::StyleResolver::collectMatchingRulesForList):

945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
2012-08-31  Antti Koivisto  <antti@apple.com>

        Repaints should not be deferred after initial page load is complete
        https://bugs.webkit.org/show_bug.cgi?id=95480

        Reviewed by Simon Fraser

        Any dynamically triggered resource loading currently sends us back to deferred paint mode, making animation choppy. 
        This is not the intention of this code.

        This patch adds an additional condition that prevents page from re-entering deferred repaint mode after the initial
        load has completed. It also cleans up the code slightly.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::checkCompleted):
        
            Add additional call to checkStopDelayingDeferredRepaints() after a frame load completes as the
            new condition in shouldUseLoadTimeDeferredRepaintDelay() looks for this change too.

        * page/FrameView.cpp:
        (WebCore):
        
            Reduced the normal delay from 25ms to 16ms to not interfere with full framerate animation.

        (WebCore::FrameView::syncCompositingStateForThisFrame):
        (WebCore::FrameView::checkFlushDeferredRepaintsAfterLoadComplete):
        
            Ensure the repaint delay is reset after load completes even if we don't currently need a repaint.

        (WebCore::FrameView::flushDeferredRepaints):
        
            We had to identical functions, flushDeferredRepaints() and stopDelayingDeferredRepaints(). Remove
            the latter.

        (WebCore::FrameView::shouldUseLoadTimeDeferredRepaintDelay):
        
            Factor the test for using load time repaint timings to a functions. The test for
            initial page load having completed is new.

        (WebCore::FrameView::updateDeferredRepaintDelay):
        (WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive):
        (WebCore::FrameView::setRepaintThrottlingDeferredRepaintDelay):
        * page/FrameView.h:
        (FrameView):

990
991
992
993
994
995
996
997
998
999
1000
2012-09-02  Filip Pizlo  <fpizlo@apple.com>

        Don't create access error strings if there is no access error
        https://bugs.webkit.org/show_bug.cgi?id=95652

        Reviewed by Adam Barth.
        
        This undoes the 50% performance regression in pdfjs caused by
        http://trac.webkit.org/changeset/126165

        No new tests because behavior is unchanged.
For faster browsing, not all history is shown. View entire blame