ChangeLog 2.1 MB
Newer Older
1
2
3
4
5
6
7
8
9
10
11
2008-04-17  Alice Liu  <alice.liu@apple.com>

        Reviewed by Jon Honeycutt.

        Added some asserts to catch undesirable usage of setWrapper and addChildren.

        * page/AccessibilityObject.cpp:
        (WebCore::AccessibilityObject::addChildren):
        * page/AccessibilityObject.h:
        (WebCore::AccessibilityObject::setWrapper):

12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
2008-04-17  Brady Eidson  <beidson@apple.com>

        Reviewed by the Mitzpettel

        Before things get much more intertwined, move away from a global LocalStorage model
        to a per-PageGroup LocalStorage model.

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::localStorage): Get it from the current PageGroup, not the global
          LocalStorage (which doesn't exist anymore).

        * page/Page.cpp:
        * page/PageGroup.cpp:
        (WebCore::PageGroup::localStorage): Create a LocalStorage object on demand.
        * page/PageGroup.h:

        * storage/LocalStorage.cpp:
        (WebCore::LocalStorage::LocalStorage): Hold a back pointer to the owning PageGroup.
        (WebCore::LocalStorage::storageArea):
        * storage/LocalStorage.h:
        (WebCore::LocalStorage::create):

        * storage/LocalStorageArea.cpp:
        (WebCore::LocalStorageArea::LocalStorageArea): Hold a back pointer to the owning LocalStorage.
        * storage/LocalStorageArea.h:
        (WebCore::LocalStorageArea::create):

39
40
41
42
43
44
45
2008-04-17  Anders Carlsson  <andersca@apple.com>

        Fix indentation.
        
        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::scheduleArchiveLoad):

46
47
48
49
50
51
52
53
54
55
56
57
58
59
2008-04-17  Anders Carlsson  <andersca@apple.com>

        Reviewed by Brady.

        When in the web archive debug mode, don't call didFail immediately. Instead,
        add the loader to the substitute resource map, but with a null resource, which
        indicates to substituteResourceDeliveryTimerFired that the load should fail.
        
        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):
        (WebCore::DocumentLoader::scheduleArchiveLoad):
        * loader/ResourceLoader.cpp:
        (WebCore::ResourceLoader::load):

60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
2008-04-17  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam.

        Add JS bindings for the DOMApplicationCache object.
        
        * bindings/js/JSDOMApplicationCacheCustom.cpp:
        (WebCore::JSDOMApplicationCache::add):
        (WebCore::JSDOMApplicationCache::remove):
        (WebCore::JSDOMApplicationCache::addEventListener):
        (WebCore::JSDOMApplicationCache::removeEventListener):
        (WebCore::JSDOMApplicationCache::dispatchEvent):
        (WebCore::JSDOMApplicationCache::setOnchecking):
        (WebCore::JSDOMApplicationCache::onchecking):
        (WebCore::JSDOMApplicationCache::setOnerror):
        (WebCore::JSDOMApplicationCache::onerror):
        (WebCore::JSDOMApplicationCache::setOnnoupdate):
        (WebCore::JSDOMApplicationCache::onnoupdate):
        (WebCore::JSDOMApplicationCache::setOndownloading):
        (WebCore::JSDOMApplicationCache::ondownloading):
        (WebCore::JSDOMApplicationCache::setOnprogress):
        (WebCore::JSDOMApplicationCache::onprogress):
        (WebCore::JSDOMApplicationCache::setOnupdateready):
        (WebCore::JSDOMApplicationCache::onupdateready):
        (WebCore::JSDOMApplicationCache::setOncached):
        (WebCore::JSDOMApplicationCache::oncached):
        (WebCore::JSDOMApplicationCache::mark):
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::mark):
        * bindings/js/JSEventTargetBase.cpp:
        (WebCore::toJS):
        * loader/appcache/DOMApplicationCache.idl:
        * page/DOMWindow.idl:

94
95
96
97
98
99
100
101
102
103
104
105
2008-04-17 Eric Carlson  <eric.carlson@apple.com> 

        Reviewed by Adele. 

        Fix for <rdar://problem/5861642> QTMovieWin returns uninitialized values

        * platform/graphics/win/QTMovieWin.cpp:
        (QTMovieWin::rate):
        (QTMovieWin::setRate):
        (QTMovieWin::setVolume):
        (QTMovieWin::getNaturalSize):

106
107
108
109
110
111
112
113
114
115
116
117
118
119
2008-04-17  Marco Barisione  <marco.barisione@collabora.co.uk>

        Reviewed by Alp Toker.

        http://bugs.webkit.org/show_bug.cgi?id=18335
        Pango font backend unable to display japanese properly

        Different fonts can have different glyph indices, so we need to pass
        the right font when retrieving a glyph index.

        * platform/graphics/gtk/GlyphPageTreeNodePango.cpp:
        (WebCore::pango_font_get_glyph): Temporarily override the font in the
        PangoAnalysis passed to pango_shape.

120
121
122
123
124
125
126
127
128
129
2008-04-17  Anders Carlsson  <andersca@apple.com>

        According to Sam and David, it's "topLevel", not "toplevel".
        
        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::topLevelApplicationCache):
        * loader/DocumentLoader.h:
        * loader/appcache/DOMApplicationCache.cpp:
        (WebCore::DOMApplicationCache::associatedCache):

130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
2008-04-17  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam.

        Add DOMApplicationCache implementation.
        
        * dom/EventNames.h:
        Add new event names.
        
        * dom/EventTarget.cpp:
        (WebCore::EventTarget::toDOMApplicationCache):
        * dom/EventTarget.h:
        Add EventTarget conversion method.
        
        * loader/appcache/ApplicationCacheGroup.h:
        (WebCore::ApplicationCacheGroup::):
        (WebCore::ApplicationCacheGroup::status):
        (WebCore::ApplicationCacheGroup::update):
        (WebCore::ApplicationCacheGroup::newestCache):
        Add more stubs.
        
        * loader/appcache/DOMApplicationCache.cpp:
        * loader/appcache/DOMApplicationCache.h:

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::clear):
        (WebCore::DOMWindow::applicationCache):
        * page/DOMWindow.h:
        (WebCore::DOMWindow::optionalApplicationCache):
        Add ApplicationCache member.
        
161
162
163
164
165
166
2008-04-17  Anders Carlsson  <andersca@apple.com>

        Build fix.

        * WebCore.vcproj/WebCore.vcproj:

adele@apple.com's avatar
adele@apple.com committed
167
168
169
170
171
172
173
174
175
176
177
2008-04-17  Dean Jackson  <dino@apple.com>

        Reviewed by Hyatt.

        Fix for <rdar://problem/5849968> translate method should have Y=0 when only X is present

        Test: fast/css/transform-default-parameter.html

        * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
        translate function with only X parameter now leaves the Y parameter as zero.

178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
2008-04-17  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam.
        
        Add plumbing for associating document loaders with application caches.
        
        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::DocumentLoader):
        (WebCore::DocumentLoader::~DocumentLoader):
        (WebCore::DocumentLoader::originalURL):
        (WebCore::DocumentLoader::requestURL):
        (WebCore::DocumentLoader::responseURL):
        (WebCore::DocumentLoader::responseMIMEType):
        (WebCore::DocumentLoader::setCandidateApplicationCacheGroup):
        (WebCore::DocumentLoader::setApplicationCache):
        (WebCore::DocumentLoader::toplevelApplicationCache):
        * loader/DocumentLoader.h:
        (WebCore::DocumentLoader::candidateApplicationCacheGroup):
        (WebCore::DocumentLoader::applicationCache):
        * loader/appcache/ApplicationCacheGroup.h:
        (WebCore::ApplicationCacheGroup::documentLoaderDestroyed):

200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
2008-04-17  Adam Roben  <aroben@apple.com>

        Fix Bug 18544: REGRESSION (r31951): Two fast/xsl tests crash

        <https://bugs.webkit.org/show_bug.cgi?id=18544>

        r31951 changed XSLTProcessor::parseErrorFunc to expect a Console* as
        the context parameter. The caller in XSLTProcessor was changed, but
        the one in XSLStyleSheet was missed.

        Reviewed by Alexey Proskuryakov.

        * xml/XSLStyleSheet.cpp:
        (WebCore::XSLStyleSheet::parseString): Pass the Console as the context
        to parseErrorFunc.

216
217
218
219
220
221
2008-04-17  Adam Roben  <aroben@apple.com>

        Windows build fix after r31981

        * dom/Document.idl: Omit getCSSCanvasContext from the COM bindings.

222
223
224
225
226
227
228
229
230
2008-04-17  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Simon.

        Implemented getFileModificationTime and pathGetFileName for the Qt port.

        * platform/qt/FileSystemQt.cpp:
        (WebCore::getFileModificationTime):

231
232
233
234
235
236
237
238
2008-04-17  Mark Rowe  <mrowe@apple.com>

        Fix the non-Mac builds that I broke with my Mac build fix.

        * css/CSSMutableStyleDeclaration.cpp:
        (WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue): Explicitly use the size_t version of max
        to avoid making assumptions about sizeof(size_t).

239
240
241
242
243
244
245
246
247
248
249
2008-04-17  Mark Rowe  <mrowe@apple.com>

        Rubber-stamped by Dan Bernstein.

        Fix the Mac build.

        * css/CSSMutableStyleDeclaration.cpp:
        (WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue): Update to use size_t in place of unsigned.
        * dom/NamedNodeMap.h: Ditto.
        * page/AccessibilityObject.h: Forward-declare AccessibilityObjectWrapper in the non-Objective-C case too.

250
251
252
253
2008-04-16  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Darin.

254
255
256
257
258
259
260
261
262
263
        Use size_t instead of unsigned where appropriate.

        * css/CSSValueList.h:
        * dom/NamedAttrMap.h:
        * rendering/RenderStyle.h:

2008-04-15  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Darin.

264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
        Add some methods to check AccessibilityObject state.

        * page/AccessibilityObject.cpp:
        (WebCore::AccessibilityObject::AccessibilityObject): Assert that the
        passed renderer is not null.
        (WebCore::AccessibilityObject::isPasswordField): Refactored to use early
        return.
        (WebCore::AccessibilityObject::isPressed): Return true if this is a
        button in the pressed state.
        (WebCore::AccessibilityObject::isIndeterminate): Return true if this is
        a tri-state checkbox in the indeterminate state.
        (WebCore::AccessibilityObject::isChecked): True if this is a radio
        button or checkbox in the checked state.
        (WebCore::AccessibilityObject::isHovered): True if object is currently
        under the mouse cursor.
        (WebCore::AccessibilityObject::isMultiSelect): True if this is a select
        element capable of multi-select.
        (WebCore::AccessibilityObject::isReadOnly): False if this object has
        editable content.
        (WebCore::AccessibilityObject::isOffScreen): True if this object is not
        in the visible portion of the view.
        * page/AccessibilityObject.h: Grouped methods into is-state and is-kind.

2008-04-15  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Darin.

291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
        Add AccessibilityObjectWrapper to Windows.

        * WebCore.vcproj/WebCore.vcproj: Add AccessibilityObjectWrapperWin.h
        * page/AccessibilityObject.h: Include COMPtr.h,
        AccessibilityObjectWrapperWin.h on Windows. Define wrapper() and
        setWrapper() if accessibility is present. Add an m_wrapper on Windows.
        * page/AccessibilityObject.cpp:
        (WebCore::AccessibilityObject::detach): Clear m_wrapper if
        accessibility is present.
        * page/win/AccessibilityObjectWrapperWin.h: Added; defines a wrapper for
        AccessibilityObjects on Windows.
        (WebCore::AccessibilityObjectWrapper::attached): Return true if attached
        to an object.
        (WebCore::AccessibilityObjectWrapper::accessibilityObject): Return the
        wrapped object.
        (WebCore::AccessibilityObjectWrapper::AccessibilityObjectWrapper):

2008-04-15  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Darin.

312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
        Add AXObjectCache to Windows.

        * WebCore.vcproj/WebCore.vcproj: Add AXObjectCacheWin.cpp.
        * page/AXObjectCache.h: Add handleFocusedUIElementChanged definition to
        non-Mac platforms, and added stub for it. Replace PLATFORM(MAC)
        conditional with HAVE(ACCESSIBILITY) for stubs.
        (WebCore::AXObjectCache::enableAccessibility):
        (WebCore::AXObjectCache::accessibilityEnabled):
        * page/win/AXObjectCacheWin.cpp: Added; contains stubs for the methods
        below.
        (WebCore::AXObjectCache::detachWrapper):
        (WebCore::AXObjectCache::attachWrapper):
        (WebCore::AXObjectCache::postNotification):
        (WebCore::AXObjectCache::postNotificationToElement):
        * config.h: Define HAVE_ACCESSIBILITY on Mac and Windows.

2008-04-15  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Darin.

332
333
        * WebCore.vcproj/WebCore.vcproj: Fix path to AXObjectCache.h.

334
335
336
337
338
2008-04-16  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler

        Merge the StorageAreaClient into the StorageArea class itself as pure virtual methods.
339
        Add "LocalStorageArea" and "SessionStorageArea" implementations, and have SessionStorage
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
        and LocalStorage instantiate the appropriate type of StorageArea object.

        This purpose of this change is because while adding the persistent store to LocalStorage,
        it became obvious that the client approach wasn't scaling well.  Additionally, a StorageArea
        backing a local storage area required vastly different data members compared to one backing
        a session storage area.

        This will be much cleaner going forward.

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:

        * storage/LocalStorage.cpp:
        (WebCore::LocalStorage::storageArea):
        * storage/LocalStorage.h:

        * storage/LocalStorageArea.cpp: Added.
        (WebCore::LocalStorageArea::LocalStorageArea):
        (WebCore::LocalStorageArea::itemChanged):
        (WebCore::LocalStorageArea::itemRemoved):
        (WebCore::LocalStorageArea::dispatchStorageEvent):
        * storage/LocalStorageArea.h: Added.
        (WebCore::LocalStorageArea::create):

        * storage/SessionStorage.cpp:
        (WebCore::SessionStorage::copy):
        (WebCore::SessionStorage::storageArea):
        * storage/SessionStorage.h:

        * storage/SessionStorageArea.cpp: Added.
        (WebCore::SessionStorageArea::copy):
        (WebCore::SessionStorageArea::SessionStorageArea):
        (WebCore::SessionStorageArea::itemChanged):
        (WebCore::SessionStorageArea::itemRemoved):
        (WebCore::SessionStorageArea::dispatchStorageEvent):
        * storage/SessionStorageArea.h: Added.
        (WebCore::SessionStorageArea::create):
        (WebCore::SessionStorageArea::page):

        * storage/StorageArea.cpp:
        (WebCore::StorageArea::StorageArea):
        (WebCore::StorageArea::setItem):
        (WebCore::StorageArea::removeItem):
        (WebCore::StorageArea::storageMap):
        * storage/StorageArea.h:

        * storage/StorageAreaClient.h: Removed.

391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
2008-04-16  David Hyatt  <hyatt@apple.com>

        Add support for the ability to draw directly into CSS images using CanvasRenderingContext2D.

        Reviewed by olliej

        Added fast/canvas/canvas-bg.html

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * css/CSSCanvasValue.cpp: Added.
        (WebCore::CSSCanvasValue::~CSSCanvasValue):
        (WebCore::CSSCanvasValue::cssText):
        (WebCore::CSSCanvasValue::canvasChanged):
        (WebCore::CSSCanvasValue::canvasResized):
        (WebCore::CSSCanvasValue::fixedSize):
        (WebCore::CSSCanvasValue::element):
        (WebCore::CSSCanvasValue::image):
        * css/CSSCanvasValue.h: Added.
        (WebCore::CSSCanvasValue::CSSCanvasValue):
        (WebCore::CSSCanvasValue::isFixedSize):
        (WebCore::CSSCanvasValue::setName):
        * css/CSSGradientValue.cpp:
        * css/CSSGradientValue.h:
        * css/CSSImageGeneratorValue.cpp:
        (WebCore::CSSImageGeneratorValue::generatedImage):
        * css/CSSImageGeneratorValue.h:
        (WebCore::CSSImageGeneratorValue::isFixedSize):
        (WebCore::CSSImageGeneratorValue::fixedSize):
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseContent):
        (WebCore::CSSParser::parseBackgroundImage):
        (WebCore::CSSParser::parseBorderImage):
        (WebCore::CSSParser::parseCanvas):
        * css/CSSParser.h:
        * dom/Document.cpp:
        (WebCore::Document::getCSSCanvasContext):
        (WebCore::Document::getCSSCanvasElement):
        * dom/Document.h:
        * dom/Document.idl:
        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::HTMLCanvasElement):
        (WebCore::HTMLCanvasElement::reset):
        * html/HTMLCanvasElement.h:
        (WebCore::HTMLCanvasElement::setSize):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::calculateBackgroundSize):
        (WebCore::RenderBox::imageChanged):
        * rendering/RenderBox.h:
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::imageChanged):
        * rendering/RenderImage.h:
        (WebCore::RenderImage::imagePtr):
        (WebCore::RenderImage::intrinsicSizeChanged):
        * rendering/RenderImageGeneratedContent.h:
        (WebCore::RenderImageGeneratedContent::imageSize):
        (WebCore::RenderImageGeneratedContent::imagePtr):
        * rendering/RenderListMarker.cpp:
        (WebCore::RenderListMarker::layout):
        (WebCore::RenderListMarker::imageChanged):
        (WebCore::RenderListMarker::calcPrefWidths):
        (WebCore::RenderListMarker::getRelativeMarkerRect):
        * rendering/RenderListMarker.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::paintBorderImage):
        (WebCore::RenderObject::imageChanged):
        * rendering/RenderObject.h:
        (WebCore::RenderObject::imageChanged):
        * rendering/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::imageChanged):
        * rendering/RenderSVGImage.h:
        * rendering/RenderStyle.cpp:
        (WebCore::StyleCachedImage::imageSize):
        (WebCore::StyleGeneratedImage::imageSize):
        * rendering/RenderStyle.h:
        (WebCore::StyleCachedImage::data):
        (WebCore::StyleGeneratedImage::StyleGeneratedImage):
        (WebCore::StyleGeneratedImage::data):
        (WebCore::StyleGeneratedImage::imageHasRelativeWidth):
        (WebCore::StyleGeneratedImage::imageHasRelativeHeight):
        (WebCore::StyleGeneratedImage::usesImageContainerSize):
        * rendering/RenderTableCol.cpp:
        (WebCore::RenderTableCol::imageChanged):
        * rendering/RenderTableCol.h:
        * rendering/RenderTableRow.cpp:
        (WebCore::RenderTableRow::imageChanged):
        * rendering/RenderTableRow.h:
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::imageChanged):
        * rendering/RenderTableSection.h:

485
486
487
488
489
490
491
492
493
494
495
496
2008-04-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.

        Add manifest parser.

        * loader/appcache/ManifestParser.cpp:
        (WebCore::):
        (WebCore::parseManifest):
        * loader/appcache/ManifestParser.h:
        * platform/text/CharacterNames.h:

darin@apple.com's avatar
darin@apple.com committed
497
498
499
500
501
502
503
504
505
506
507
508
509
510
2008-04-16  Darin Adler  <darin@apple.com>

        Reviewed by Mitz.

        - fix <rdar://problem/5858617> REGRESSION (r21452-Safari 3.1):
          Safari does not find words containing ß (German letter sharp-s)

        Test: fast/text/find-case-folding.html

        * platform/text/StringImpl.cpp:
        (WebCore::StringImpl::foldCase):
        Pass the folded length to foldCase rather than the original string length.
        Without this, we get an error code every time.

511
512
513
514
515
516
517
518
519
2008-04-16  Anders Carlsson  <andersca@apple.com>

        Fix build.
        
        * loader/appcache/ApplicationCache.cpp:
        (WebCore::ApplicationCache::ApplicationCache):
        (WebCore::ApplicationCache::setManifestResource):
        (WebCore::ApplicationCache::addResource):

520
521
522
523
524
525
526
527
528
529
530
531
532
533
2008-04-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.

        Add new protocolHostAndPortAreEqual function.
        
        * platform/KURL.cpp:
        (WebCore::KURL::host):
        (WebCore::KURL::setHost):
        (WebCore::KURL::setHostAndPort):
        (WebCore::protocolHostAndPortAreEqual):
        * platform/KURL.h:
        (WebCore::KURL::hostStart):

534
535
536
537
538
539
540
541
542
543
544
545
546
547
2008-04-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam.
        
        Fix some style nits.
        
        * loader/appcache/ApplicationCache.cpp:
        (WebCore::ApplicationCache::ApplicationCache):
        (WebCore::ApplicationCache::setManifestResource):
        (WebCore::ApplicationCache::addResource):
        (WebCore::ApplicationCache::removeResource):
        (WebCore::ApplicationCache::dump):
        * loader/appcache/ApplicationCacheGroup.h:

548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
2008-04-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Brady and Sam.

        Add ApplicationCache implementation. Stub out ApplicationCacheGroup methods
        needed by ApplicationCache.
        
        * loader/appcache/ApplicationCache.cpp:
        (WebCore::ApplicationCache::ApplicationCache):
        (WebCore::ApplicationCache::~ApplicationCache):
        (WebCore::ApplicationCache::setManifestResource):
        (WebCore::ApplicationCache::addResource):
        (WebCore::ApplicationCache::removeResource):
        (WebCore::ApplicationCache::resourceForURL):
        (WebCore::ApplicationCache::resourceForRequest):
        (WebCore::ApplicationCache::numDynamicEntries):
        (WebCore::ApplicationCache::dynamicEntry):
        (WebCore::ApplicationCache::addDynamicEntry):
        (WebCore::ApplicationCache::removeDynamicEntry):
        (WebCore::ApplicationCache::setOnlineWhitelist):
        (WebCore::ApplicationCache::isURLInOnlineWhitelist):
        (WebCore::ApplicationCache::dump):
        * loader/appcache/ApplicationCache.h:
        (WebCore::ApplicationCache::create):
        (WebCore::ApplicationCache::manifestResource):
        (WebCore::ApplicationCache::group):
        (WebCore::ApplicationCache::begin):
        (WebCore::ApplicationCache::end):
        * loader/appcache/ApplicationCacheGroup.h:
        (WebCore::ApplicationCacheGroup::manifestURL):
        (WebCore::ApplicationCacheGroup::cacheDestroyed):

580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
2008-04-16  Adam Roben  <aroben@apple.com>

        Fix Bug 18505: REGRESSION: Search is disabled and not functional

        <https://bugs.webkit.org/show_bug.cgi?id=18505>

        Reviewed by Tim Hatcher.

        * page/inspector/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.sourceFrameForResource): Added.
        * page/inspector/inspector.css: Added back rules for the search field
        that were removed in r31736.
        * page/inspector/inspector.html:
          - Removed the disabled attribute from the search field
          - Added back the #searchResults and #searchResultsResizer divs which
            were removed in r31736
        * page/inspector/inspector.js:
        (WebInspector.set showingSearchResults): Updated for class rename
        panels -> main-panels.
        (WebInspector.loaded): Added back the mousedown event listener for the
        search results resizer that was removed in r31736.
        (WebInspector.searchResultsResizerDrag): Updated for class rename
        panels -> main-panels.
        (WebInspector.performSearch):
          - Changed to use sourceFrameForResource
          - Changed to use showResource
          - Changed to save/restore the focused element around the setting of
            the current panel
          - Changed to get the source document from the match range instead of
            by crawling back up to the source view
          - Changed to bind the onselect handlers to this so that we can
            access the Elements/Resources panels

beidson@apple.com's avatar
beidson@apple.com committed
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
2008-04-16  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig

        Changing ThreadSafeShared to start with a ref count of 1, so updating all users to
        adoptRef() that initial reference.

        * bindings/js/JSCustomSQLStatementCallback.h:
        (WebCore::JSCustomSQLStatementCallback::create):
        * bindings/js/JSCustomSQLStatementErrorCallback.h:
        (WebCore::JSCustomSQLStatementErrorCallback::create):
        * bindings/js/JSCustomSQLTransactionCallback.h:
        (WebCore::JSCustomSQLTransactionCallback::create):
        * bindings/js/JSCustomSQLTransactionErrorCallback.h:
        (WebCore::JSCustomSQLTransactionErrorCallback::create):

        * bindings/js/JSDatabaseCustom.cpp:
        (WebCore::JSDatabase::changeVersion):
        (WebCore::JSDatabase::transaction):

        * bindings/js/JSSQLTransactionCustom.cpp:
        (WebCore::JSSQLTransaction::executeSql):

        * dom/Document.cpp:
        (WebCore::Document::databaseThread):

        * platform/SecurityOrigin.cpp:
        (WebCore::SecurityOrigin::create):

        * platform/sql/SQLiteAuthorizer.h:
        (WebCore::SQLiteAuthorizer::create):
        (WebCore::SQLiteAuthorizer::SQLiteAuthorizer):

        * storage/ChangeVersionWrapper.cpp:
        (WebCore::ChangeVersionWrapper::performPreflight):
        (WebCore::ChangeVersionWrapper::performPostflight):
        * storage/ChangeVersionWrapper.h:
        (WebCore::ChangeVersionWrapper::create):

        * storage/Database.cpp:
        (WebCore::Database::openAndVerifyVersion):
        (WebCore::Database::markAsDeletedAndClose):
        (WebCore::Database::changeVersion):
        (WebCore::Database::transaction):
        (WebCore::Database::scheduleTransaction):
        (WebCore::Database::scheduleTransactionStep):
        (WebCore::Database::tableNames):

        * storage/DatabaseAuthorizer.h:
        (WebCore::DatabaseAuthorizer::create):

        * storage/DatabaseTask.h:
        (WebCore::DatabaseOpenTask::create):
        (WebCore::DatabaseCloseTask::create):
        (WebCore::DatabaseTransactionTask::create):
        (WebCore::DatabaseTableNamesTask::create):

        * storage/DatabaseThread.cpp:
        (WebCore::DatabaseThread::scheduleTask): Change to take a PassRefPtr instead of raw
        (WebCore::DatabaseThread::scheduleImmediateTask): Ditto
        * storage/DatabaseThread.h:
        (WebCore::DatabaseThread::create):

        * storage/SQLError.h:
        (WebCore::SQLError::create):
        (WebCore::SQLError::SQLError):

        * storage/SQLResultSet.h:
        (WebCore::SQLResultSet::create):

        * storage/SQLStatement.cpp:
        (WebCore::SQLStatement::create):
        (WebCore::SQLStatement::execute):
        (WebCore::SQLStatement::setDatabaseDeletedError):
        (WebCore::SQLStatement::setVersionMismatchedError):
        (WebCore::SQLStatement::setFailureDueToQuota):
        * storage/SQLStatement.h:

        * storage/SQLTransaction.cpp:
        (WebCore::SQLTransaction::create):
        (WebCore::SQLTransaction::executeSQL):
        (WebCore::SQLTransaction::openTransactionAndPreflight):
        (WebCore::SQLTransaction::deliverTransactionCallback):
        (WebCore::SQLTransaction::handleCurrentStatementError):
        (WebCore::SQLTransaction::deliverStatementCallback):
        (WebCore::SQLTransaction::postflightAndCommit):
        * storage/SQLTransaction.h:

701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
2008-04-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam and Brady.
        
        Add implementation of ApplicationCacheResource.
        
        * loader/appcache/ApplicationCacheResource.cpp:
        (WebCore::ApplicationCacheResource::ApplicationCacheResource):
        (WebCore::ApplicationCacheResource::dumpType):
        * loader/appcache/ApplicationCacheResource.h:
        (WebCore::ApplicationCacheResource::):
        (WebCore::ApplicationCacheResource::create):
        (WebCore::ApplicationCacheResource::type):
        (WebCore::ApplicationCacheResource::addType):

716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
2008-04-16  Timothy Hatcher  <timothy@apple.com>

        Fixes an issue where the source for a resource that had errors would
        not be shown because the view was created before the resource load
        finished. The right view is now created, even if the resource isn't 
        finished. The SourceView just makes sure to not load the source until
        the resource is finished. Only if the category changes, does the view
        need to be recreated.

        Reviewed by Adam Roben.

        * page/inspector/Resource.js:
        (WebInspector.Resource.prototype.set category): Call recreateViewForResourceIfNeeded.
        * page/inspector/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):
        Added. Tries to make a new view, if the view is the same prototype of the
        previous view, return early. If they differ, close and detach the old view
        and associate the resource with the new view. Calling updateErrorsAndWarnings
        is needed, because the errors and warnings that might have been added to the
        previous view will be lost, so make the tree element match.
        (WebInspector.Resource.prototype._createResourceView): Always create a view
        that matches the resource category. Ignore the loading and failed status.
        * page/inspector/SourceView.js:
        (WebInspector.SourceView.prototype.setupSourceFrameIfNeeded): Don't setup the
        frame if the resource hasn't finished or if the load failed.

742
743
744
745
746
747
748
749
750
751
752
753
2008-04-16  Timothy Hatcher  <timothy@apple.com>

        Adds a console formatter for Error objects. So typing a expression in the
        console that ends in an exception will print meaningful info. Also calling
        console.{log,error,warn,info} with an error object will output nicely.

        Reviewed by Adam Roben.

        * page/inspector/Console.js:
        (WebInspector.Console.prototype._formaterror): Added. Formats an error
        object by showing it like other exceptions, with a clickable file URL.

754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
2008-04-16  Timothy Hatcher  <timothy@apple.com>

        Refactors code that updates the errors and warnings count in the
        resources sidebar so other functions can easily trigger updates.

        Reviewed by Adam Roben.

        * page/inspector/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype.addMessageToResource): Call updateErrorsAndWarnings.
        Removes code that updates the bubbleText and class names.
        (WebInspector.ResourcesPanel.prototype.clearMessages): Ditto.
        (WebInspector.ResourceSidebarTreeElement.prototype.updateErrorsAndWarnings):
        Added. Updates the bubbleText and adds or removes the class names
        depending on if the values are zero.

antti@apple.com's avatar
antti@apple.com committed
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
2008-04-16  Antti Koivisto  <antti@apple.com>

        Reviewed by Alexey.
        
        Fix <rdar://problem/5863728>
        REGRESSION: Garbage character shown in temperatures in the Weather widget (encoding issue with degree symbol)
        
        Parse the encoding attribute in PreloadScanner.

        Test: fast/encoding/script-preload-encoding.html

        * html/PreloadScanner.cpp:
        (WebCore::PreloadScanner::processAttribute):
        (WebCore::PreloadScanner::emitTag):
        (WebCore::PreloadScanner::emitCSSRule):
        * html/PreloadScanner.h:
        * loader/DocLoader.cpp:
        (WebCore::DocLoader::preload):
        * loader/DocLoader.h:

789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
2008-04-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Generate the DOMApplicationCache JS wrapper, add JSDOMApplicationCacheCustom.cpp and 
        fix typos in the #if line.
        
        * DerivedSources.make:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSDOMApplicationCacheCustom.cpp: Added.
        * loader/appcache/ApplicationCache.cpp:
        * loader/appcache/ApplicationCache.h:
        * loader/appcache/ApplicationCacheGroup.cpp:
        * loader/appcache/ApplicationCacheGroup.h:
        * loader/appcache/ApplicationCacheResource.cpp:
        * loader/appcache/ApplicationCacheResource.h:
        * loader/appcache/DOMApplicationCache.cpp:
        * loader/appcache/DOMApplicationCache.h:
        * loader/appcache/DOMApplicationCache.idl:
        * loader/appcache/ManifestParser.cpp:
        * loader/appcache/ManifestParser.h:

weinig@apple.com's avatar
weinig@apple.com committed
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
2008-04-16  Sam Weinig  <sam@webkit.org>

        Reviewed by Geoffrey Garen.

        - To keep the behavior of the WebKit and JavaScriptCore API's the same,
          we need to hide the fact that the global object and the window object
          are no longer the same thing, and the the global object now changes on
          navigations.  To do this, only the wrapper should ever be exposed.  This
          fixes the two remaining spots where the internal global object is exposed,
          the windowScriptObject returned from [WebFrame windowObject] and the object
          return by calling JSContextGetGlobalObject on [WebFrame globalContext]

        * bindings/js/JSDOMWindowWrapper.cpp:
        (WebCore::JSDOMWindowWrapper::putWithAttributes):
        * bindings/js/JSDOMWindowWrapper.h:
        Forward this new method so that JSObjectSetProperty doesn't set properties on the 
        wrapper.

        * page/mac/FrameMac.mm:
        (WebCore::Frame::windowScriptObject):
        Return the wrapper instead of the global object.

834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
2008-04-16  David Hyatt  <hyatt@apple.com>

        Eliminate the paintBuffer and drawImage(ImageBuffer*) methods from GraphicsContext* in favor of just
        snagging an Image* from the ImageBuffer and drawing that instead.

        Enhance canvas with a CanvasObserver so that notifications of dirtying or resizing can be tracked by
        a consumer.

        Reviewed by olliej

        * html/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::drawImage):
        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::HTMLCanvasElement):
        (WebCore::HTMLCanvasElement::willDraw):
        (WebCore::HTMLCanvasElement::reset):
        (WebCore::HTMLCanvasElement::paint):
        * html/HTMLCanvasElement.h:
        (WebCore::CanvasObserver::~CanvasObserver):
        (WebCore::HTMLCanvasElement::setSize):
        (WebCore::HTMLCanvasElement::setObserver):
        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::drawImage):
        (WebCore::GraphicsContext::drawTiledImage):
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/ImageBuffer.h:
        (WebCore::ImageBuffer::clearImage):
        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        * platform/graphics/cg/GraphicsContextCG.cpp:
        * platform/graphics/cg/ImageCG.cpp:
        (WebCore::BitmapImage::draw):
        (WebCore::Image::drawPattern):
        * platform/graphics/cg/ImageSourceCG.cpp:
        (WebCore::ImageSource::createFrameAtIndex):
        * platform/graphics/qt/GraphicsContextQt.cpp:
        * platform/graphics/wx/GraphicsContextWx.cpp:

871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
2008-04-16  Steve Falkenburg  <sfalken@apple.com>

        Improve timer latency/resolution.
                
        The primary timing mechanism is now CreateTimerQueueTimer, with a PostMessage from
        the callback proc.  This event will be delivered sooner than if we used SetTimer(),
        since it is higher priority than other messages.
        
        If there is an input message pending, we'll use we SetTimer() based timers to avoid
        starving user input.

        Don't call PostMessage immediately on all timers < 10ms.  Only call immediately if
        timer is already expired.  This avoids the case where no timers would be processed,
        causing the timer to be re-posted via the slower SetTimer method.

        Don't call PostMessage immediately if there's a pending WM_PAINT, since
        we don't want to starve all paints when bombarded with a continuous stream of low
        duration timers.

        Removed reentrancy check, since we're now looking for specific starvation cases,
        and will typically defer non-expired timers through CreateTimerQueueTimer.

        The reason Windows wouldn't starve paints in favor of timers with the old code:
        When we went to reset the timer when it fired, the timer reset code treated this as a
        reentrant timer, causing us to hit the slow SetTimer code rather than calling PostMessage,
        even for timers expiring in < 10ms.  I corrected that, exposing the paint starvation problem.

        Use timeBeginPeriod/timeEndPeriod to improve resolution of system timers.
        Limit this resolution change to within 20ms of the last high resolution timer request.
                        
        Corrected GetQueueStatus to check for specific input (and paint) messages rather than
        checking QS_ALLINPUT.  Contrary to its name, QS_ALLINPUT actually indicates interest
        in ALL queued messages, not just input messages.
        
        Fix SetTimer/KillTimer calls to pass our window handle.

        Reviewed by Brady.

        * platform/win/SharedTimerWin.cpp:
        (WebCore::):
        (WebCore::TimerWindowWndProc):
        (WebCore::queueTimerProc):
        (WebCore::setSharedTimerFireTime):
        (WebCore::stopSharedTimer):

916
917
918
919
920
921
922
923
924
925
926
927
928
2008-04-16  Adam Roben  <aroben@apple.com>

        Fix console-log-formatting to truly test formatting an undefined value

        Exceptions thrown by the test will also now be shown as errors.

        Reviewed by Tim Hatcher.

        * manual-tests/inspector/console-log-formatting.html:
        (test): Use console.error to report exceptions.
        (runTests): Use window.noSuchVariable instead of just noSuchVariable
        to avoid an exception.

929
930
931
932
933
934
935
936
937
2008-04-16  Anatoli Papirovski  <apapirovski@mac.com>

        Reviewed by David.

        Optimized the calculation of background-size.

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::calculateBackgroundSize):

938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
2008-04-16  Adam Roben  <aroben@apple.com>

        Fix Bug 17228: console.{log,warn,info,error} should support format
        strings, variable arguments

        <https://bugs.webkit.org/show_bug.cgi?id=17228>
        <rdar://problem/5732828>

        Reviewed by Tim Hatcher.

        Test: manual-tests/inspector/console-log-formatting.html

        * page/inspector/Console.js:
        (WebInspector.ConsoleMessage): Pass any extra arguments down to
        _format.
        (WebInspector.ConsoleMessage._format): This method constructs
        this.formattedMessage. We treat the first parameter as a format
        string. Any parameters that have not been used after substituting into
        the format string are concatenated together, separated by spaces.
        (WebInspector.ConsoleMessage.toMessageElement): Updated to use
        this.formattedMessage.
        (WebInspector.ConsoleMessage.toString): Ditto.

961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
2008-04-15  Adam Roben  <aroben@apple.com>

        Make String.format return an array of unused substitutions

        String.format now returns an object with two properties:
        formattedResult and unusedSubstitutions.

        Reviewed by Tim Hatcher.

        * page/inspector/utilities.js:
        (String.vsprintf): Updated for changes to String.format. We throw away
        the array of unused substitutions.
        (String.format): Changed to keep track of which substitutions are used
        when formatting. We then return both the formatted result and the
        array of unused substitutions.

977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
2008-04-15  Adam Roben  <aroben@apple.com>

        Generalize String.format some more

        String.format now takes an initial value and an append function which
        it uses to build the result. Each time a token is processed,
        append(valueSoFar, newValue) is called.

        Reviewed by Tim Hatcher.

        * page/inspector/utilities.js:
        (String.vsprintf): Pass the empty string for the initial value, and
        a function that concatenates two strings as the append function.
        (String.format): Use initialValue and append to build the result
        instead of only working with strings.

aroben@apple.com's avatar
aroben@apple.com committed
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
2008-04-15  Adam Roben  <aroben@apple.com>

        Add String.format

        String.format is a more generic form of String.vsprintf that takes a
        set of formatter functions, one for each supported format specifier.
        Each formatter function is passed the relevant token and substitution
        value, and returns the formatted result.

        Reviewed by Tim Hatcher.

        * page/inspector/utilities.js:
        (String.standardFormatters): Added.
        (String.vsprintf): Changed to call through to String.format.
        (String.format): Added. Most of the code came from String.vsprintf,
        except that we use the passed-in formatters to format the
        substitutions rather than hard-coding how to handle each format
        specifier.

1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
2008-04-15  Adam Roben  <aroben@apple.com>

        Refactor String.vsprintf to separate tokenizing and substituting

        This will eventually be useful for the various console methods that
        take a format string.

        Reviewed by Tim Hatcher.

        * page/inspector/utilities.js:
        (String.tokenizeFormatString): Added. This uses the format parsing
        code from String.vsprintf but just returns an array of "string" and
        "specifier" tokens.
        (String.vsprintf): Now calls String.tokenizeFormatString and processes
        the tokens one at a time.

1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
2008-04-15  Adam Roben  <aroben@apple.com>

        Pass all arguments to console.{log,warn,info,error} into the Inspector's JS

        Part of Bug 17228: console.{log,warn,info,error} should support format
        strings, variable arguments
        <http://bugs.webkit.org/show_bug.cgi?id=17228>
        <rdar://problem/5732828>

        We don't use the extra arguments yet.

        Reviewed by Tim Hatcher.

        * page/Console.cpp:
        (WebCore::Console::error): Pass the arguments list to
        InspectorController.
        (WebCore::Console::info): Ditto.
        (WebCore::Console::log): Ditto.
        (WebCore::Console::warn): Ditto.
        * page/InspectorController.cpp:
        (WebCore::ConsoleMessage::ConsoleMessage): Added a new constructor
        that takes an ExecState and a List instead of a String. We wrap and
        store the JSValues from the List in a Vector<ProtectedPtr<JSValue> >.
        (WebCore::InspectorController::addMessageToConsole): Added an overload
        that takes an ExecState and a List.
        (WebCore::InspectorController::addConsoleMessage): Moved code here
        from addMessageToConsole. Both overloads of addMessageToConsole now
        call this helper method.
        (WebCore::InspectorController::addScriptConsoleMessage): Updated for
        the new parameter order of WebInspector.ConsoleMessage. If the
        ConsoleMessage has a non-empty wrappedArguments Vector, we use that
        instead of the ConsoleMessage's message String.
        * page/InspectorController.h:
        * page/inspector/Console.js:
        (WebInspector.ConsoleMessage): Removed the explicit message parameter.
        We now get the message from the unnamed 5th parameter.
        * page/inspector/Resource.js: Updated for the change to
        WebInspector.ConsoleMessage's parameter order.

1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
2008-04-15  Adam Roben  <aroben@apple.com>

        Change calls to Chrome::addMessageToConsole to use Console::addMessage

        Part of Bug 17228: console.{log,warn,info,error} should support format
        strings, variable arguments
        <http://bugs.webkit.org/show_bug.cgi?id=17228>
        <rdar://problem/5732828>

        Console now takes care of calling ChromeClient::addMessageToConsole
        for the appropriate messages (i.e., just messages from JavaScript). If
        you ever want to add a message to the console, Console is the place to
        do it.

        Reviewed by Darin Adler.

        * WebCore.xcodeproj/project.pbxproj: Mark Console.h Private.
        * page/Chrome.cpp: Removed addMessageToConsole
        * page/Chrome.h: Moved MessageSource/MessageLevel to Console.h.
        * page/Console.cpp:
        (WebCore::Console::addMessage): Added. Calls
        ChromeClient::addMessageToConsole for JS messages, and calls
        InspectorController::addMessageToConsole for all messages.
        (WebCore::Console::error): Changed to call directly to
        InspectorController in addition to ChromeClient.
        (WebCore::Console::info): Ditto.
        (WebCore::Console::log): Ditto.
        (WebCore::Console::warn): Ditto.
        * page/Console.h: Added MessageSource/MessageLevel enums from Chrome.h.

1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
2008-04-15  Adam Roben  <aroben@apple.com>

        Pass JSConsole's arguments unmodified to Console

        Part of Bug 17228: console.{log,warn,info,error} should support format
        strings, variable arguments
        <http://bugs.webkit.org/show_bug.cgi?id=17228>
        <rdar://problem/5732828>

        All of JSConsole's methods are now custom, so that we can pass the
        arguments unmodified to Console. Console now handles calling
        toString() on the first argument. Later it will pass the arguments off
        to InspectorController.

        There should be no behavioral changes caused by this patch.

        Reviewed by Darin Adler.

        * ForwardingHeaders/kjs/list.h: Added.
        * GNUmakefile.am: Added JSConsoleCustom.cpp to the project.
        * WebCore.pro: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * WebCoreSources.bkl: Ditto.
        * bindings/js/JSConsoleCustom.cpp: Added.
        (WebCore::JSConsole::error):
        (WebCore::JSConsole::info):
        (WebCore::JSConsole::log):
        (WebCore::JSConsole::warn):
        * page/Console.cpp: Changed all methods to take an ExecState* and a
        const List&. The first item in the List is toString()ed and passed to
        Chrome.
        (WebCore::Console::error):
        (WebCore::Console::info):
        (WebCore::Console::log):
        (WebCore::Console::warn):
        * page/Console.h:
        * page/Console.idl:

weinig@apple.com's avatar
weinig@apple.com committed
1136
1137
1138
1139
1140
1141
1142
1143
1144
2008-04-16  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Adler.

        Rename kjs_strtod to KJS::strtod.

        * platform/text/String.cpp:
        (WebCore::charactersToDouble):

ap@webkit.org's avatar
ap@webkit.org committed
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
2008-04-16  Alexey Proskuryakov  <ap@webkit.org>

        Reviewed by Adam.

        http://bugs.webkit.org/show_bug.cgi?id=18259
        XML+XSLT pages in iframe contains document.location of a parent window

        Test: fast/xsl/subframe-location.html

        * xml/XSLTProcessor.cpp:
        (WebCore::XSLTProcessor::createDocumentFromSource): Set resulting document URL before opening
        it, so that the document loader picks a correct URL, too.

1158
1159
1160
1161
1162
1163
1164
1165
1166
2008-04-16  Dan Bernstein  <mitz@apple.com>

        Rubber-stamped by John Sullivan.

        - remove unreachable code which was added in r8802

        * rendering/RenderText.cpp:
        (WebCore::RenderText::caretRect):

1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
2008-04-15  Timothy Hatcher  <timothy@apple.com>

        Adds a script resource icon. Update the CSS icon to better match the script icon.

        https://bugs.webkit.org/show_bug.cgi?id=18499

        Rubber-stamped by Adele Peterson.

        * page/inspector/Images/resourceCSSIcon.png: Updated.
        * page/inspector/Images/resourceJSIcon.png: Added.
        * page/inspector/inspector.css: Changed the script icon rule to reference the new image.

eric@webkit.org's avatar
eric@webkit.org committed
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
2008-04-16  Eric Seidel  <eric@webkit.org>

        Reviewed by hyatt.

        Fix leaky ImageBuffer code.

        * platform/graphics/GeneratedImage.cpp:
        (WebCore::GeneratedImage::drawPattern):
        * platform/graphics/ImageBuffer.h:
        * platform/graphics/cg/ImageBufferCG.cpp:
        (WebCore::ImageBuffer::image):

justin.garcia@apple.com's avatar
justin.garcia@apple.com committed
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
2008-04-15  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Oliver.

        <rdar://problem/5665299> REGRESSION (r27369): Paste text into a contenteditable div creates a contenteditable div for each line (16661)

        * editing/markup.cpp:
        (WebCore::createFragmentFromText): Don't use clones of the enclosing block to hold
        paragraphs if the enclosing block is the root editable element.

1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
2008-04-15  Mark Rowe  <mrowe@apple.com>

        Reviewed by Jon Honeycutt.

        Don't treat the misnamed NSAccessibilitySortButtonRole as an accessibility role.  It is really
        a subrole of NSAccessibilityButtonRole.  As it is not used inside WebCore there is no change in
        behaviour as a result of doing this.  This fixes <rdar://problem/5866444>.

        * page/AccessibilityObject.cpp:
        (WebCore::AccessibilityObject::canSetFocusAttribute): Remove SortButtonRole as it is unused.
        * page/AccessibilityObject.h: Ditto.
        (WebCore::):
        * page/mac/AccessibilityObjectWrapper.mm:
        (RoleEntry::):

1216
1217
1218
1219
1220
1221
1222
1223
2008-04-15  Anders Carlsson  <andersca@apple.com>

        Fix leaks seen on bot.
        
        * loader/SubstituteResource.h:
        (WebCore::SubstituteResource::~SubstituteResource):
        Add a virtual destructor.

1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
2008-04-15  Brady Eidson  <beidson@apple.com>

        Reviewed by Anders Carlsson

        Fix for <rdar://problem/5820819> - Crash sometime occurs when interrupting a load.

        Each SubresourceLoader has a client.  That client is often a Loader::Host object.  
        The Loader/Host/CachedResource system predates our ref-counting and ownership models, and therefore manages
        object lifetime manually.

        The cause of this crash was that we would sometimes call "didFail()" on a Host object twice - Once when 
        beginning the new navigation, and once when the new navigation is committed.

        The problem is after the first time Host::didFail() gets called, the Host is almost always deleted shortly 
        thereafter.  But the SubresourceLoader had a dangling pointer to the Host which is now invalid.

        I explored a few options to fix this bug.  The one that was most obviously "clean" was to call cancel() on
        the SubresourceLoader itself, which would end up calling Host::didFail() and doing the appropriate cache
        cleanup.

        This problem with that approach was that it had other side effects - when you cut off a load that had already
        partially displayed in the WebView, images that hadn't finished loading would be invalidated and immediately
        turn into broken image icons.  This was visually jarring and pretty unacceptable. 

        So I decided to follow a much simpler approach, which was to have the Host clear the client pointer from each
        SubresourceLoader before it forgets about it.  This leaves things the same visually and fixes the crash.

        Note that the layout test for this - if possible - will require other enhancements to DRT including possibly 
        adding support for window.stop(). That task is non-trivial, and is documented in <rdar://problem/5061826> 

        * loader/SubresourceLoader.h:
        (WebCore::SubresourceLoader::clearClient): Add a method to clear the SubresourceLoaderClient.  This is 
          perfectly safe to do on an in-flight SubresourceLoader as they are already designed to be client-less,
          and already null-check the client before calling it.

        * loader/loader.cpp:
        (WebCore::Loader::Host::didFail): The SubresourceLoader itself might not be finished loading and might decide 
          to call into its client later.  Since the client has no guaranteed lifetime and is liable to be deleted 
          after didFail() is called, call clearClient() on the SubresourceLoader so such an invalid call can't happen.

andersca@apple.com's avatar
andersca@apple.com committed
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
2008-04-15  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Add empty files for the application cache.
        
        * Configurations/WebCore.xcconfig:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.vcproj/build-generated-files.sh:
        Add ENABLE_OFFLINE_WEB_APPLICATIONS to FEATURE_DEFINES.
        
        * WebCore.xcodeproj/project.pbxproj:
        * loader/appcache: Added.
        * loader/appcache/ApplicationCache.cpp: Added.
        * loader/appcache/ApplicationCache.h: Added.
        * loader/appcache/ApplicationCacheGroup.cpp: Added.
        * loader/appcache/ApplicationCacheGroup.h: Added.
        * loader/appcache/ApplicationCacheResource.cpp: Added.
        * loader/appcache/ApplicationCacheResource.h: Added.
        * loader/appcache/DOMApplicationCache.cpp: Added.
        * loader/appcache/DOMApplicationCache.h: Added.
        * loader/appcache/DOMApplicationCache.idl: Added.
        * loader/appcache/ManifestParser.cpp: Added.
        * loader/appcache/ManifestParser.h: Added.

1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
2008-04-15  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Tim.

        - <rdar://problem/5792587> AJAX (XMLHttpRequest) support for the Inspector (17776)
        - Add XMLHttpRequest support to the inspector.

        * English.lproj/InspectorLocalizedStrings.js: Specify capitalization
        instead of using text-transform because XHR must capitalize all the letters.
        * page/inspector/Resource.js: Assume XHRs are textType even though this
        may not always be true.
        Also add the XHR category and let all mime types be consistent with it.
        * page/inspector/ResourcesPanel.js: Set the XHR category color.
        * page/inspector/inspector.css: Make XHRs yellow and fonts red because
        XHRs are more common than fonts and yellow next to orange (scripts) is
        not as harsh on the eyes as red next to orange.
        * page/inspector/inspector.js: Specify capitalization again.

1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
2008-04-15  David Hyatt  <hyatt@apple.com>

        Fix the zoom property so that it works properly with font-size.

        Reviewed by John Sullivan

        Added fast/css/zoom-font-size.html

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::updateFont):
        (WebCore::CSSStyleSelector::applyProperty):
        (WebCore::CSSStyleSelector::checkForZoomChange):
        * css/CSSStyleSelector.h:

1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
2008-04-15  Timothy Hatcher  <timothy@apple.com>

        Fixes the bug where a resource view could still be shown after the inspected
        page navigates to another page.

        https://bugs.webkit.org/show_bug.cgi?id=18517

        Reviewed by Adam Roben.

        * page/inspector/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype.reset): Close the visible resource.
        Iterate over all the resources and zero errors and warnings and delete the
        resource view and tree element. Removes all children of resourceViews. Passes
        true to _updateGraphDividersIfNeeded to force an immediate update.
        (WebInspector.ResourcesPanel.prototype.removeResource): Added. Closes
        the resource view if it is visible. Removes the resource from the _resources
        array. Removes the tree element from the outline tree. Zeros out the errors
        and warnings properties. Deletes the tree element and resource view properties.
        (WebInspector.ResourcesPanel.prototype.closeVisibleResource): Null check
        this._calculator for times when reset is called before the calculator is set.
        * page/inspector/inspector.js:
        (WebInspector.removeResource): Call ResourcesPanel.removeResource.

1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
2008-04-15  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Rename "archive" to "substitute" in a couple of places.
        
        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::DocumentLoader):
        (WebCore::DocumentLoader::clearArchiveResources):
        (WebCore::DocumentLoader::deliverSubstituteResourcesAfterDelay):
        (WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):
        (WebCore::DocumentLoader::isSubstituteLoadPending):
        (WebCore::DocumentLoader::cancelPendingSubstituteLoad):
        (WebCore::DocumentLoader::scheduleArchiveLoad):
        (WebCore::DocumentLoader::setDefersLoading):
        * loader/DocumentLoader.h:
        * loader/ResourceLoader.cpp:
        (WebCore::ResourceLoader::load):
        (WebCore::ResourceLoader::didCancel):

1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
2008-04-15  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Move the URL, response and data to SubstituteResource.
        
        * loader/SubstituteResource.h:
        (WebCore::SubstituteResource::url):
        (WebCore::SubstituteResource::response):
        (WebCore::SubstituteResource::data):
        (WebCore::SubstituteResource::SubstituteResource):
        * loader/archive/ArchiveResource.cpp:
        (WebCore::ArchiveResource::ArchiveResource):
        * loader/archive/ArchiveResource.h:
        (WebCore::ArchiveResource::frameName):

1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
2008-04-15  David Hyatt  <hyatt@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=18467

        Make sure to ignore zoom:0.  That is not supposed to actually do anything.  It's a hack in IE
        to cause an element to set "hasLayout."

        Reviewed by Anders

        Added fast/css/zoom-property-parsing.html

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):

1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
2008-04-15  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Add a (currently empty) SubstituteResource class and make ArchiveResource inherit from it.
        
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * loader/SubstituteResource.h: Added.
        * loader/archive/ArchiveResource.h:

1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
2008-04-15  Antti Koivisto  <antti@apple.com>

        Reviewed by Geoff.

        Fix <rdar://problem/5862921>
        REGRESSION: Leak in SVGSVGElement::SVGSVGElement
        
        In these strange days RefCounted starts with count of one.

        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::SVGSVGElement):
        * svg/animation/SMILTimeContainer.h:
        (WebCore::SMILTimeContainer::create):

hyatt@apple.com's avatar
hyatt@apple.com committed
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
2008-04-15  Anatoli Papirovski  <apapirovski@mac.com>

        Reviewed by hyatt

        [CSS1, CSS3] Fixed the background-origin calculation for root elements
        (background-size and background-position are affected), r10794
        [CSS3] Fixed the background-size transformation where width is specified in percentage and height is left to auto

        Test: fast/backgrounds/background-origin-root-element.html

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::calculateBackgroundSize):
        (WebCore::RenderBox::calculateBackgroundImageGeometry):

1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
2008-04-15  Timothy Hatcher  <timothy@apple.com>

        Fixes the regression where the error and warning counts did not show up in the Resources
        sidebar next to resources.

        https://bugs.webkit.org/show_bug.cgi?id=18494

        Reviewed by Adam Roben.

        * page/inspector/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype.addMessageToResource): Increment errors or warnings
        on the resource. Set the bubbleText to the total of the errors and warnings. Add a error
        or warning class to the bubble.
        (WebInspector.ResourcesPanel.prototype.clearMessages): Zero out the errors and warnings
        properties on each resource. Set the bubbleText back to an empty string.
        * page/inspector/SidebarTreeElement.js:
        (WebInspector.SidebarTreeElement): Create a statusElement.
        (WebInspector.SidebarTreeElement.prototype.get bubbleText): Return _bubbleText.
        (WebInspector.SidebarTreeElement.prototype.set bubbleText): Create bubbleElement if needed.
        Assign the value to _bubbleText and bubbleElement.textContent.
        (WebInspector.SidebarTreeElement.prototype.onattach): Append statusElement to _listItemNode.
        * page/inspector/inspector.css: Style rules for bubbles and status elements.

1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
2008-04-15  Timothy Hatcher  <timothy@apple.com>

        Fixes the regression where error and warning bubbles would not be added
        to the source view of a resource.

        https://bugs.webkit.org/show_bug.cgi?id=18495

        Reviewed by Adam Roben.

        * css/view-source.css:
        (.webkit-html-message-bubble): Add a min-height to make sure the border-radius
        has enough room to apply.
        * page/inspector/Console.js:
        (WebInspector.Console.prototype.addMessage): Removed code that added messages
        to resource panels and incremented error and warning counts on resources.
        Now just call ResourcesPanel.addMessageToResource after assigning the resource
        to the console message.
        (WebInspector.Console.prototype.clearMessages): Removed code that cleared error
        and warning counts from resources an call ResourcesPanel.clearMessages.
        * page/inspector/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype.addMessageToResource): Call addMessage
        on the resource's view, if it is implemented.
        (WebInspector.ResourcesPanel.prototype.clearMessages): Call clearMessages
        on all the resource views for the ones that implement it.
        (WebInspector.ResourcesPanel.prototype.refreshResource): Call _resourceView
        to make the resource's view if needed. Use a local view variable.
        (WebInspector.ResourcesPanel.prototype._resourceView): Added helper function
        to create a resource view if needed.
        * page/inspector/SourceView.js:
        (WebInspector.SourceView.prototype.setupSourceFrameIfNeeded): Delete the 
        _frameNeedsSetup property at the beginning to prevent recursion. Get the
        length of the messages array when assigning the local length variable.
        (WebInspector.SourceView.prototype.addMessage): Renamed from addMessageToSource.
        (WebInspector.SourceView.prototype.clearMessages): Added. Clear all the message
        bubbles that might be sprinkled in the source. Also clears the messages array.
        (WebInspector.SourceView.prototype._addMessageToSource): Create the image
        element in the Inspector's document so we can use relative image URLs. Then
        adopt the image element into the frame's document.

beidson@apple.com's avatar
beidson@apple.com committed
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
2008-04-15  Brady Eidson  <beidson@apple.com>

        Reviewed by Anders

        Hook up event dispatching for window.localStorage changes.

        Tests: storage/domstorage/localstorage/enumerate-storage.html
               storage/domstorage/localstorage/iframe-events.html
               storage/domstorage/localstorage/index-get-and-set.html
               storage/domstorage/localstorage/onstorage-attribute-markup.html
               storage/domstorage/localstorage/onstorage-attribute-setattribute.html
               storage/domstorage/localstorage/simple-events.html
               storage/domstorage/localstorage/simple-usage.html
               storage/domstorage/localstorage/window-open.html

        * storage/LocalStorage.cpp:
        (WebCore::LocalStorage::dispatchStorageEvent): Walk every Page in the PageGroup, adding
          each Frame that matches the storage area's security origin to a Vector.  Then dispatch
          the StorageEvent to each Frame in the Vector

        * storage/SessionStorage.cpp:
        (WebCore::SessionStorage::dispatchStorageEvent): Adopt the technique used in LocalStorage,
          which is to only add the Frames to the Vector if their security origin matches

1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
2008-04-15  Olivier Goffart  <ogoffart@trolltech.com>

        Reviewed by Simon.

        Fixes: copy to clipboard when selecting, and paste when clicking with the middle button

        * platform/Pasteboard.h: Added Qt-specific selection mode
        * platform/qt/PasteboardQt.cpp: Choose the clipboard or the selecton
        according to the selection mode
        (WebCore::Pasteboard::writeSelection):
        (WebCore::Pasteboard::plainText):
        (WebCore::Pasteboard::documentFragment):
        (WebCore::Pasteboard::writeURL):
        (WebCore::Pasteboard::clear):
        (WebCore::Pasteboard::isSelectionMode):

1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
2008-04-15  Andre Poenitz  <andre.poenitz@trolltech.com>

        Reviewed by Simon.

        Fix compilation with Qt namespaces

        Qt can be configured to have all of its classes inside a specified namespaces.
        This is for example used in plugin/component environments like Eclipse.

        This change makes it possible to let the Qt port compile against a namespaced
        Qt by the use of macros Qt provides to properly forward declare Qt classes in
        the namespace.

        * WebCore.pro:
        * bridge/qt/qt_class.h:
        * bridge/qt/qt_instance.h:
        * html/HTMLCanvasElement.h:
        * platform/DragData.h:
        * platform/DragImage.h:
        * platform/KURL.h:
        * platform/PlatformKeyboardEvent.h:
        * platform/PlatformMouseEvent.h:
        * platform/PlatformWheelEvent.h:
        * platform/Widget.h:
        * platform/graphics/Color.h:
        * platform/graphics/FloatPoint.h:
        * platform/graphics/FloatRect.h:
        * platform/graphics/Gradient.h:
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/ImageBuffer.h:
        * platform/graphics/ImageSource.h:
        * platform/graphics/IntPoint.h:
        * platform/graphics/IntRect.h:
        * platform/graphics/IntSize.h:
        * platform/graphics/Path.h:
        * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
        * platform/graphics/qt/MediaPlayerPrivatePhonon.h:
        * platform/network/qt/QNetworkReplyHandler.h:
        * platform/network/qt/ResourceRequest.h:
        * platform/qt/ClipboardQt.h:
        * platform/qt/RenderThemeQt.h:
        * platform/text/PlatformString.h:
        * platform/text/qt/TextCodecQt.h:
        * svg/graphics/SVGPaintServer.h:
        * svg/graphics/SVGPaintServerGradient.h:

beidson@apple.com's avatar
beidson@apple.com committed
1583
1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
1624
1625
1626
1627
1628
1629
1630
1631
1632
1633
1634
1635
1636
1637
1638
1639
1640
1641
1642
1643
1644
1645
1646
1647
2008-04-14  Brady Eidson  <beidson@apple.com>

        Reviewed by Anders

        Lay the underpinnings for LocalStorage.

        For now, this just exposes window.localStorage to the dom which returns an in-memory Storage object, much
        like SessionStorage.  The primary difference at this point is that the object returned is shared globally,
        and isn't copied for new top-level browsing contexts like SessionStorage.

        Later, I'll add proper event dispatch and a persistent storage backing.

        * GNUmakefile.am:
        * WebCore.base.exp:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:

        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::mark): Mark the optionalLocalStorage

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::clear):
        (WebCore::DOMWindow::localStorage):
        * page/DOMWindow.h:
        (WebCore::DOMWindow::optionalLocalStorage):

        * storage/LocalStorage.cpp: Added.
        (WebCore::LocalStorage::sharedLocalStorage):
        (WebCore::LocalStorage::LocalStorage):
        (WebCore::LocalStorage::storageArea):
        (WebCore::LocalStorage::itemChanged):
        (WebCore::LocalStorage::itemRemoved):
        (WebCore::LocalStorage::dispatchStorageEvent):
        * storage/LocalStorage.h: Added.

        * storage/SessionStorage.cpp: Refactor to use the client interface for event dispatching for sessionStorage objects
        (WebCore::SessionStorage::SessionStorage):
        (WebCore::SessionStorage::copy):
        (WebCore::SessionStorage::storageArea):
        (WebCore::SessionStorage::itemChanged):
        (WebCore::SessionStorage::itemRemoved):
        (WebCore::SessionStorage::dispatchStorageEvent):
        * storage/SessionStorage.h:

        * storage/StorageArea.cpp: Add a client parameter, and call to the client when an item is changed or removed.
        (WebCore::StorageArea::create):
        (WebCore::StorageArea::StorageArea):
        (WebCore::StorageArea::copy):
        (WebCore::StorageArea::setItem):
        (WebCore::StorageArea::removeItem):
        (WebCore::StorageArea::setClient):
        * storage/StorageArea.h:
        (WebCore::StorageArea::page):
        (WebCore::StorageArea::securityOrigin):

        * storage/StorageAreaClient.h: Added.  Break out "itemChanged" and "itemRemoved" to a StorageAreaClient
          This way, both SessionStorage and LocalStorage areas can have different behavior on changes with
          that behavior managed from a central location.
        (WebCore::StorageAreaClient::~StorageAreaClient):
        (WebCore::StorageAreaClient::StorageAreaClient):
        (WebCore::StorageAreaClient::itemChanged):
        (WebCore::StorageAreaClient::itemRemoved):

beidson@apple.com's avatar
beidson@apple.com committed
1648
1649
1650
1651
1652
1653
2008-04-14  Brady Eidson  <beidson@apple.com>

        Reviewed by Anders

        Add a hidden pref to debug WebArchive loading.  With this pref on, when loading a WebArchive,
        if the resource isn't in the ArchiveResourceCollection, the loader will not fall back to the 
1654
        network and will instead fail the load with a "cannot show URL" error.
beidson@apple.com's avatar
beidson@apple.com committed
1655
1656
1657
1658
1659
1660
1661
1662
1663
1664

        * loader/ResourceLoader.cpp:
        (WebCore::ResourceLoader::load): Do the check here.

        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        (WebCore::Settings::setWebArchiveDebugModeEnabled):
        * page/Settings.h:
        (WebCore::Settings::webArchiveDebugModeEnabled):

1665
1666
1667
1668
1669
1670
1671
1672
1673
1674
1675
1676
1677
1678
1679
1680
1681
1682
1683
1684
1685
1686
1687
1688
1689
1690
1691
1692
1693
1694
1695
1696
1697
1698
1699
2008-04-14  Antti Koivisto  <antti@apple.com>

        Reviewed by Eric.

        Some preparations for additive animations and animations in <use>.
        - Disallow animation elements in instance trees.
        - Fix buggy SVGUseElement::removeDisallowedElementsFromSubtree(), make it 
          public and static
        - Invoke it from SVGElementInstance::updateInstance() to clean up the instance tree
          there as well.
        - Add mechanism for blocking instance updates when an animation changes
          the referenced tree.
        
        The added assert in SVGSMILElement::insertedIntoDocument() verifies the fixes
        with the existing test cases.

        * svg/SVGAElement.cpp:
        (WebCore::SVGAElement::defaultEventHandler):
        * svg/SVGElementInstance.cpp:
        (WebCore::SVGElementInstance::updateInstance):
        * svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::updateElementInstance):
        (WebCore::SVGStyledElement::setInstanceUpdatesBlocked):
        * svg/SVGStyledElement.h:
        * svg/SVGUseElement.cpp:
        (WebCore::isDisallowedElement):
        (WebCore::SVGUseElement::removeDisallowedElementsFromSubtree):
        * svg/SVGUseElement.h:
        * svg/animation/SVGSMILElement.cpp:
        (WebCore::SVGSMILElement::insertedIntoDocument):
        (WebCore::SVGSMILElement::isSMILElement):
        (WebCore::SVGSMILElement::connectConditions):
        (WebCore::SVGSMILElement::disconnectConditions):
        * svg/animation/SVGSMILElement.h:

1700
1701
1702
1703
1704
1705
1706
1707
1708
1709
1710
1711
1712
1713
1714
1715
1716
1717
1718
1719
1720
1721
1722
1723
1724
1725
1726
1727
1728
1729
1730
1731
1732
1733
1734
1735
1736
1737
1738
1739
1740
1741
1742
1743
1744
1745
1746
1747
1748
1749
1750
1751
1752
1753
1754
1755
1756
1757
1758
1759
1760
1761
1762
1763
1764
1765
1766
1767
1768
1769
1770
1771
1772
1773
1774
1775
1776
1777
1778
1779
1780
1781
1782
1783
1784
1785
1786
1787
1788
1789
1790
1791
1792
1793
1794
1795
1796
1797
1798
1799
1800
1801
1802
1803
1804
1805
1806
1807
1808
1809
1810
1811
1812
1813
1814
1815
1816
1817
1818
1819
1820
1821
1822
1823
1824
1825
1826
1827
1828
1829
1830
1831
1832
1833
1834
1835
1836
1837
1838
1839
1840
1841
1842
1843
1844
1845
1846
1847
1848
1849
1850
1851
1852
1853
1854
1855
1856
1857
1858
1859
1860
1861
1862
1863
1864
1865
1866
1867
2008-04-14  Adam Roben  <aroben@apple.com>

        Don't let the inspected page overwrite properties of JS objects in the
        Inspector

        <https://bugs.webkit.org/show_bug.cgi?id=16011>
        <rdar://problem/5604409>

        <https://bugs.webkit.org/show_bug.cgi?id=16837>
        <rdar://problem/5813850>

        Reviewed by Sam Weinig and Geoff Garen.

        Tests (contributed by Adam Barth and Collin Jackson):
        manual-tests/inspector-wrappers

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        Added new files to the projects.

        * bindings/js/JSQuarantinedObjectWrapper.cpp: Added.
        (WebCore::):
        (WebCore::JSQuarantinedObjectWrapper::asWrapper): Converts a JSValue
        into a JSQuarantinedObjectWrapper, if the JSValue is in fact a
        JSQuarantinedObjectWrapper.
        (WebCore::JSQuarantinedObjectWrapper::cachedValueGetter): Callback to
        be used with PropertySlot.
        (WebCore::JSQuarantinedObjectWrapper::JSQuarantinedObjectWrapper):
        Hold onto the object we're wrapping and its global object. Pass the
        wrapped prototype up to the JSObject constructor.
        (WebCore::JSQuarantinedObjectWrapper::~JSQuarantinedObjectWrapper):
        (WebCore::JSQuarantinedObjectWrapper::unwrappedExecStateMatches):
        Returns true if our underlying object originated from the same global
        object as the passed-in ExecState.
        (WebCore::JSQuarantinedObjectWrapper::unwrappedExecState):
        (WebCore::JSQuarantinedObjectWrapper::transferExceptionToExecState):
        Wraps and moves an exception from our underlying ExecState to the
        passed-in one.
        (WebCore::JSQuarantinedObjectWrapper::mark): Marks ourselves and the
        objects we're holding references to.

        (WebCore::JSQuarantinedObjectWrapper::getOwnPropertySlot):
        (WebCore::JSQuarantinedObjectWrapper::put):
        (WebCore::JSQuarantinedObjectWrapper::deleteProperty):
        (WebCore::JSQuarantinedObjectWrapper::implementsConstruct):
        (WebCore::JSQuarantinedObjectWrapper::construct):
        (WebCore::JSQuarantinedObjectWrapper::implementsHasInstance):
        (WebCore::JSQuarantinedObjectWrapper::hasInstance):
        (WebCore::JSQuarantinedObjectWrapper::implementsCall):
        (WebCore::JSQuarantinedObjectWrapper::callAsFunction):
        (WebCore::JSQuarantinedObjectWrapper::getPropertyNames):
        JSObject overrides. These each check the appropriate permission before
        allowing the call to proceed. We wrap all outgoing values using
        m_wrapOutgoingValue, and we prepare all incoming values with the
        virtual prepareIncomingValue function. If an exception is raised when
        calling the underlying object, we transfer the exception in wrapped
        form to the passed-in ExecState.

        * bindings/js/JSQuarantinedObjectWrapper.h: Added.
        (WebCore::JSQuarantinedObjectWrapper::unwrappedObject):
        (WebCore::JSQuarantinedObjectWrapper::className): We return the
        underlying object's class name so that we can successfully masquerade
        as that underlying object when, e.g., Object.prototype.toString is
        called on us.
        (WebCore::JSQuarantinedObjectWrapper::classInfo):

        (WebCore::JSQuarantinedObjectWrapper::allowsGetProperty):
        (WebCore::JSQuarantinedObjectWrapper::allowsSetProperty):
        (WebCore::JSQuarantinedObjectWrapper::allowsDeleteProperty):
        (WebCore::JSQuarantinedObjectWrapper::allowsConstruct):
        (WebCore::JSQuarantinedObjectWrapper::allowsHasInstance):
        (WebCore::JSQuarantinedObjectWrapper::allowsCallAsFunction):
        (WebCore::JSQuarantinedObjectWrapper::allowsGetPropertyNames):
        These virtual methods let subclasses define the allowed operations on
        the wrapped object. By default all operations are disabled.

        * bindings/js/JSInspectedObjectWrapper.cpp: Added. This subclass of
        JSQuarantinedObjectWrapper is used to wrap objects from the inspected
        page being passed to the Inspector.
        (WebCore::wrappers):
        (WebCore::):
        (WebCore::JSInspectedObjectWrapper::wrap): Wraps the passed-in object
        if needed and returns the wrapper. If this object has been wrapped
        previously we'll return the old wrapper rather than make a new one.
        (WebCore::JSInspectedObjectWrapper::JSInspectedObjectWrapper): Add
        ourselves to the wrapper map.
        (WebCore::JSInspectedObjectWrapper::~JSInspectedObjectWrapper): Remove
        ourselves from the wrapper map.
        (WebCore::JSInspectedObjectWrapper::prepareIncomingValue): Ensure that
        any objects passed to the inspected object are either wrappers around
        objects from the inspected page (in which case we unwrap them so that
        the inspected page never sees the wrapper), or wrapped callbacks from
        the Inspector.
        * bindings/js/JSInspectedObjectWrapper.h: Added.
        (WebCore::JSInspectedObjectWrapper::classInfo):
        (WebCore::JSInspectedObjectWrapper::allowsGetProperty):
        (WebCore::JSInspectedObjectWrapper::allowsSetProperty):
        (WebCore::JSInspectedObjectWrapper::allowsDeleteProperty):
        (WebCore::JSInspectedObjectWrapper::allowsConstruct):
        (WebCore::JSInspectedObjectWrapper::allowsHasInstance):
        (WebCore::JSInspectedObjectWrapper::allowsCallAsFunction):
        (WebCore::JSInspectedObjectWrapper::allowsGetPropertyNames):
        These all return true so that the Inspector can use objects from the
        inspected page however it needs.
        (WebCore::JSInspectedObjectWrapper::wrapOutgoingValue): Wrap all
        outgoing values as JSInspectedObjectWrappers.

        * bindings/js/JSInspectorCallbackWrapper.cpp: Added. This subclass of
        JSQuarantinedObjectWrapper is used to wrap callbacks that the
        Inspector passes to the inspected page (e.g., for event listeners or
        client-side storage callbacks).
        (WebCore::wrappers):
        (WebCore::):
        (WebCore::JSInspectorCallbackWrapper::wrap): Wraps the passed-in
        object if needed and returns the wrapper. If this object has been
        wrapped previously we'll return the old wrapper rather than make a new
        one.
        (WebCore::JSInspectorCallbackWrapper::JSInspectorCallbackWrapper): Add
        ourselves to the wrapper map.
        (WebCore::JSInspectorCallbackWrapper::~JSInspectorCallbackWrapper):
        Remove ourselves from the wrapper map.
        (WebCore::JSInspectorCallbackWrapper::prepareIncomingValue): Ensure
        that values passed from the inspected page to an Inspector callback
        are wrapped in JSInspectedObjectWrappers. We also allow the inspected
        page to pass ourselves in (which will happen in the case of a
        client-side storage callback, where the callback itself is passed as
        the `this` object). In this case we unwrap ourselves so that the
        Inspector doesn't have to deal with the wrapper.
        * bindings/js/JSInspectorCallbackWrapper.h: Added.
        (WebCore::JSInspectorCallbackWrapper::classInfo):
        (WebCore::JSInspectorCallbackWrapper::allowsCallAsFunction):
        This is the only allowed operation on a JSInspectorCallbackWrapper.
        (WebCore::JSInspectorCallbackWrapper::wrapOutgoingValue): Wrap all
        outgoing values as JSInspectorCallbackWrappers.

        * page/InspectorController.cpp:
        (WebCore::getResourceDocumentNode): Wrap the Document before passing
        it to the Inspector.
        (WebCore::highlightDOMNode): Unwrap the Node that the Inspector passed
        to us.
        (WebCore::databaseTableNames): Unwrap the Database that the Inspector
        passed to us.
        (WebCore::inspectedWindow): Wrap the Window before passing it to the
        Inspector.
        (WebCore::InspectorController::focusNode): Wrap the Node before
        passing it to the Inspector.
        (WebCore::wrapCallback): Wraps the passed-in callback in a
        JSInspectorCallbackWrapper.
        (WebCore::InspectorController::addDatabaseScriptResource): Wrap the
        Database beore pasing it to the Inspector.
        (WebCore::InspectorController::windowScriptObjectAvailable): Add the
        new wrapCallback function to the InspectorController JS object.

        * page/inspector/ElementsPanel.js:
        (WebInspector.ElementsPanel.reset): Wrap the contentLoaded callback.

        * page/inspector/DatabaseQueryView.js:
        (WebInspector.DatabaseQueryView._enterKeyPressed):
        * page/inspector/DatabaseTableView.js:
        (WebInspector.DatabaseTableView.update):
        Pass null instead of an empty array to executeSql since we're no
        longer allowed to pass any unwrapped objects to the inspected page.
        We now wrap all callbacks being passed to the inspected page using
        InspectorController.wrapCallback.

1868
1869
1870
1871
1872
1873
1874
1875
1876
1877
1878
1879
1880
1881
1882
1883
1884
1885
1886
1887
2008-04-14  Adam Roben  <aroben@apple.com>

        Use prototypes/constructors from the inspected page when operating on
        objects from the inspected page

        Reviewed by Tim Hatcher.

        * page/inspector/Console.js:
        (WebInspector.ConsolePanel._format): Use the Node constructor from the
        inspected Window with the instanceof operator.
        * page/inspector/ElementsPanel.js:
        (WebInspector.DOMNodeTreeElement._attributeEditingCommitted): Use the
        Element prototype from the inspected Window instead of the Element
        prototype from this Window.
        * page/inspector/inspector.js:
        (WebInspector.performSearch): Ditto for Document prototype.
        * page/inspector/utilities.js:
        (Object.type): Now takes an optional Window parameter that is used to
        find the built-in constructors.

1888
1889
1890
1891
1892
1893
1894
1895
1896
1897
1898
1899
1900
2008-04-14  Adam Roben  <aroben@apple.com>

        Don't store objects from the Inspector on CSSStyleRules from the
        inspected page

        Reviewed by Tim Hatcher.

        * page/inspector/StylesSidebarPane.js:
        (WebInspector.StylesSidebarPane.update): Don't store raw CSSStyleRules
        from the inspected page in the styleRules array. Instead, always use a
        wrapper object. This will keep us from setting Inspector objects as
        properties of inspected objects.

1901
1902
1903
1904
1905
1906
1907
1908
1909
1910
1911
1912
1913
1914
1915
1916
1917
1918
1919
1920
1921
1922
1923
1924
1925
1926
1927
1928
1929
1930
1931
1932
1933
1934
1935
1936
1937
1938
1939
1940
2008-04-14  Timothy Hatcher  <timothy@apple.com>

        Fixes a regression where clicking a resource URL in the Console would not
        show the resource in the Resources panel.

        https://bugs.webkit.org/show_bug.cgi?id=18493

        Reviewed by Adam Roben.

        * page/inspector/Console.js:
        (WebInspector.Console.prototype._messagesClicked): Removed console-message-url
        handling to show resources. This is now handled by WebInspector.showResourceForURL.
        (WebInspector.ConsoleMessage.prototype.toMessageElement): Add the webkit-html-resource-link
        class name to the URL anchor. Also add the line number as a property to the anchor.
        * page/inspector/ResourcesPanel.js:
        (WebInspector.ResourcesPanel): Add a reference to the tree element to each calculator.
        (WebInspector.ResourcesPanel.prototype.showResource): Select and reveal the resource in
        the sidebar. Call showLine on the resource view if it is implemented.
        (WebInspector.ResourcesPanel.prototype.closeVisibleResource): Select the current calculator's
        tree element in the sidebar.
        (WebInspector.ResourcesPanel.prototype._graphSelected): Call closeVisibleResource after
        the calculator changes since closeVisibleResource uses the calculator.
        * page/inspector/SourceView.js:
        (WebInspector.SourceView.prototype.sourceRow): Early return if the line is null/zero.
        (WebInspector.SourceView.prototype.showLine):  Renamed from showSourceLine.
        * page/inspector/inspector.css:
        (body.console-visible #main-panels): Made the bottom 24px to match
        the height of #main-status-bar.
        (.console-message-url): Make the color important so it wins over
        the .webkit-html-resource-link rule.
        (.resource-view .resource-view-content): Made more generic from .image
        so all resource views get sized correctly.
        (.resource-view.image .resource-view-content): Removed.
        * page/inspector/inspector.js:
        (WebInspector.documentClick): Pass the line number from the anchor to
        WebInspector.showResourceForURL.
        (WebInspector.showResourceForURL): Add line number support. Pass the line
        to ResourcesPanel.showResource.
        (WebInspector.addMainEventListeners): Use bind for the event listeners.

1941
1942
1943
1944
1945
1946
1947
1948
1949
1950
1951
1952
1953
1954
1955
1956
1957
1958
1959
1960
1961
1962
1963
1964
2008-04-14  Xan Lopez  <xan@gnome.org>

        Reviewed by Alp Toker.

        http://bugs.webkit.org/show_bug.cgi?id=17917
        Bug 17917: Cookie support for HTTP soup backend

        Initial implementation of cookies for the http soup backend.

        Moved CookieJarGtk to CookieJarSoup in network/soup and left the original
        one as CookieJarCurl in network/curl.

        * GNUmakefile.am:
        * platform/CookieJar.h:
        * platform/network/curl/CookieJarCurl.cpp: Renamed from WebCore/platform/gtk/CookieJarGtk.cpp.
        (WebCore::setCookies):
        (WebCore::cookies):
        * platform/network/soup/CookieJarSoup.cpp: Added.
        (WebCore::getCookieJar):
        (WebCore::setCookies):
        (WebCore::cookies):
        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::ResourceHandle::start):

1965
1966
1967
1968
1969
1970
1971
1972
1973
1974
1975
1976
1977
1978
1979
1980
1981
1982
2008-04-14  Holger Freyther  <zecke@selfish.org>

        Reviewed by Alp Toker.

        https://bugs.webkit.org/show_bug.cgi?id=18411
        Enable Page caching and create FrameViews on the fly

        Create the FrameView on the fly and cache pages

        - Keep a copy of the GtkAdjustment to be able to reuse it for the
          FrameViews
        - Do not initially create a FrameView and update the WebKit code to
          cope with not having a view.
        - Cache seven pages by default.

        * platform/gtk/ScrollViewGtk.cpp:
        (WebCore::ScrollView::setGtkAdjustments):

1983
1984
1985
1986
1987
1988
1989
1990
1991
1992
1993
1994
1995
1996
1997
1998
1999
2000
2001
2002
2003
2004
2005
2006
2007
2008
2009
2010
2011
2008-04-14  David Hyatt  <hyatt@apple.com>

        Add a new optimized layout path for positioned objects that move.  Also avoid always marking the <html>
        object for layout when it has a percentage height, since the RenderView already does that when its size
        changes.

        Reviewed by mjs

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::layoutBlockChildren):
        (WebCore::RenderBlock::layoutPositionedObjects):
        * rendering/RenderBox.h:
        (WebCore::RenderBox::layoutDoingPositionedMovementOnly):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::RenderObject):
        (WebCore::RenderObject::setNeedsLayout):
        (WebCore::RenderObject::setChildNeedsLayout):
        (WebCore::RenderObject::setNeedsPositionedMovementLayout):
        (WebCore::RenderObject::setStyle):
        * rendering/RenderObject.h:
        (WebCore::RenderObject::needsLayout):
        (WebCore::RenderObject::needsPositionedMovementLayoutOnly):
        (WebCore::RenderObject::layoutDoingPositionedMovementOnly):
        * rendering/RenderStyle.cpp:
        (WebCore::positionedObjectMoved):
        (WebCore::RenderStyle::diff):
        * rendering/RenderStyle.h:
        (WebCore::RenderStyle::):

2012
2013
2014
2015
2016
2017
2018
2019
2020
2021
2022
2023
2024
2025
2026
2027
2028
2029
2030
2031
2032
2033
2034
2035
2036
2037
2038
2039
2040
2041
2042
2043
2044
2045
2046
2047
2048
2049
2050
2051
2052
2053
2054
2055
2056
2057
2058
2059
2060
2061
2062
2063
2064
2065
2066
2067
2068
2069
2070
2071
2072
2073
2074
2075
2076
2077
2078
2079
2080
2081
2082
2008-04-14  David Hyatt  <hyatt@apple.com>

        Add support for gradients in the CSS content property.

        Reviewed by olliej

        Added fast/gradients/generated-gradients.html

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseContent):
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        (WebCore::CSSStyleSelector::styleImage):
        (WebCore::CSSStyleSelector::mapBackgroundImage):
        * css/CSSStyleSelector.h:
        * html/HTMLImageElement.cpp:
        (WebCore::HTMLImageElement::attach):
        * rendering/RenderContainer.cpp:
        (WebCore::RenderContainer::updateBeforeAfterContentForContainer):
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::RenderImage):
        (WebCore::RenderImage::setCachedImage):
        (WebCore::RenderImage::paintReplaced):
        (WebCore::RenderImage::calcReplacedWidth):
        (WebCore::RenderImage::calcReplacedHeight):
        (WebCore::RenderImage::calcAspectRatioWidth):
        (WebCore::RenderImage::calcAspectRatioHeight):
        * rendering/RenderImage.h:
        (WebCore::RenderImage::hasImage):
        (WebCore::RenderImage::image):
        (WebCore::RenderImage::errorOccurred):
        (WebCore::RenderImage::usesImageContainerSize):
        (WebCore::RenderImage::setImageContainerSize):
        (WebCore::RenderImage::imageHasRelativeWidth):
        (WebCore::RenderImage::imageHasRelativeHeight):
        (WebCore::RenderImage::imageSize):
        * rendering/RenderImageGeneratedContent.cpp: Added.
        (WebCore::RenderImageGeneratedContent::RenderImageGeneratedContent):
        (WebCore::RenderImageGeneratedContent::~RenderImageGeneratedContent):
        (WebCore::RenderImageGeneratedContent::setStyleImage):
        * rendering/RenderImageGeneratedContent.h: Added.
        (WebCore::RenderImageGeneratedContent::hasImage):
        (WebCore::RenderImageGeneratedContent::image):
        (WebCore::RenderImageGeneratedContent::errorOccurred):
        (WebCore::RenderImageGeneratedContent::usesImageContainerSize):
        (WebCore::RenderImageGeneratedContent::setImageContainerSize):
        (WebCore::RenderImageGeneratedContent::imageHasRelativeWidth):
        (WebCore::RenderImageGeneratedContent::imageHasRelativeHeight):
        (WebCore::RenderImageGeneratedContent::imageSize):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::createObject):
        * rendering/RenderStyle.cpp:
        (WebCore::StyleCachedImage::imageHasRelativeWidth):
        (WebCore::StyleCachedImage::imageHasRelativeHeight):
        (WebCore::StyleCachedImage::usesImageContainerSize):
        (WebCore::RenderStyle::contentDataEquivalent):
        (WebCore::RenderStyle::setContent):
        (WebCore::ContentData::clear):
        * rendering/RenderStyle.h:
        (WebCore::StyleGeneratedImage::imageHasRelativeWidth):
        (WebCore::StyleGeneratedImage::imageHasRelativeHeight):
        (WebCore::StyleGeneratedImage::usesImageContainerSize):
        (WebCore::BackgroundLayer::setBackgroundImage):
        (WebCore::ContentData::):
        (WebCore::RenderStyle::setListStyleImage):

2083
2084
2085
2086
2087
2088
2089
2090
2091
2092
2093
2094
2095
2096
2097
2098
2099
2100
2101
2102
2103
2104
2008-04-14  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam, but Anders too, and he was more thorough in his review
        and thats the only reason Sam beat him

        Swap the Page and SecurityOrigin arguments when creating a StorageArea.

        SecurityOrigin is really the primary identifying characteristic of a StorageArea,
        and StorageAreas that represent LocalStorage won't have an owner Page.

        * storage/SessionStorage.cpp:
        (WebCore::SessionStorage::copy):
        (WebCore::SessionStorage::storageArea):

        * storage/StorageArea.cpp:
        (WebCore::StorageArea::create):
        (WebCore::StorageArea::StorageArea):
        (WebCore::StorageArea::copy):
        (WebCore::StorageArea::dispatchStorageEvent): Null check m_page here, as in the future
          it might be null
        * storage/StorageArea.h:

2105
2106
2107
2108
2109
2110
2111
2112
2113
2114
2115
2116
2117
2118
2119
2120
2121
2122
2123
2008-04-14  Timothy Hatcher  <timothy@apple.com>

        Add support for changing the sort order of the resources. The two sorting
        methods supported current are Time and Size.

        Reviewed by Adam Roben.

        * page/inspector/Images/statusbarMenuButton.png: Added.
        * page/inspector/Images/statusbarMenuButtonSelected.png: Added.
        * page/inspector/ResourcesPanel.js:
        (WebInspector.ResourcesPanel): Create the status bar menu button and
        setup the event listener to call _changeSortingFunction. Each option in
        the select references a sorting function.
        (WebInspector.ResourcesPanel.get statusBarItems): Add the sorting menu to the
        items returned.
        (WebInspector.ResourcesPanel._changeSortingFunction): Set the sorting function
        to the selected option's function in the sorting menu.
        * page/inspector/inspector.css: Added CSS rules for select elements in status bars.

2124
2125
2126
2127
2128
2129
2130
2131
2132
2133
2134
2135
2136
2137
2138
2139
2140
2141
2142
2143
2008-04-14  Timothy Hatcher  <timothy@apple.com>

        Add support for toggling between small and large resource rows
        in the Resources panel.

        Reviewed by Adam Roben.

        * English.lproj/InspectorLocalizedStrings.js: Added new tooltip string.
        * page/inspector/Images/largerResourcesButtons.png: Added.
        * page/inspector/Images/resourceDocumentIconSmall.png: Added.
        * page/inspector/Images/resourcePlainIconSmall.png: Added.
        * page/inspector/ResourcesPanel.js:
        (WebInspector.ResourcesPanel): Create the status bar button and
        setup the event listener to call _toggleLargerResources.
        (WebInspector.ResourcesPanel.get statusBarItems): Return the status bar button.
        (WebInspector.ResourcesPanel._toggleLargerResources): Toggle the class names
        for the resources children list and the status bar button.
        * page/inspector/inspector.css: New style rules for small resources
        and the status bar item.

2144
2145
2146
2147
2148
2149
2150
2151
2152
2153
2154
2155
2008-04-14  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Darin Adler

        <rdar://problem/5854572> REGRESSION: AXPosition seems to be flipped in nightly build
        AX was using the wrong method to determine the view to use to create the screen position 

        * page/AccessibilityObject.cpp:
        (WebCore::AccessibilityObject::documentFrameView):
        * page/mac/AccessibilityObjectWrapper.mm:
        (-[AccessibilityObjectWrapper position]):

2156
2157
2158
2159
2160
2161
2162
2163
2164
2165
2166
2008-04-14  David Smith  <catfish.man@gmail.com>

        Reviewed by Timothy Hatcher.
        
        - Fix https://bugs.webkit.org/show_bug.cgi?id=14258
        Response time vs. download time should be shown in the network profile

        * page/inspector/Resource.js: Change the sorting function to sort by response received time.
        * page/inspector/ResourcesPanel.js: Hook up the existing infrastructure to two bars instead of one; one for the total time, one for the time post-response.
        * page/inspector/inspector.css: Add a new rule to make the waiting bar have a lower opacity, and change the total bar opacity to handle the overlap

2167
2168
2169
2170
2171
2172
2173
2174
2175
2176
2177
2178
2179
2180
2181
2182
2183
2184
2185
2186
2187
2188
2189
2190
2191
2192
2193
2008-04-14  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Ap.

        Bug 17403: WebKit Creates Invalid Xhtml Links with Ajax
        http://bugs.webkit.org/show_bug.cgi?id=17403

        The previous code had callbacks for the normal parsing (full document) and fragment parsing.
        The difference was induced by the method we were using which did not accept a xmlParserCtxt.
        The code has been refactored to allow us to share the callbacks between the different cases.
        A drawback is that we have to use xmlParseContent which is an internal libxml method and thus
        some internal intialization is done in WebCore.

        Test: fast/parser/ampersand-escaped-parseXMLFragment.xhtml

        * dom/XMLTokenizer.cpp:
        (WebCore::createStringParser): Moved didInit in the global scope as it is shared by the
        2 create methods.

        (WebCore::createMemoryParser): Create a memory parser similar to the previous code.
        Initialize the xmlParserContext to call xmlParseContent in parseXMLDocumentFragment.

        (WebCore::XMLTokenizer::initializeParserContext): Check m_parsingFragment to know
        which create method to call.

        * dom/XMLTokenizer.h: Added parseXMLDocumentFragment as a friend of XMLTokenizer.

rwlbuis@webkit.org's avatar
rwlbuis@webkit.org committed
2194
2195
2196
2197
2198
2199
2200
2201
2202
2203
2204
2205
2206
2008-04-14  Rob Buis  <buis@kde.org>

        Reviewed by Eric.

        http://bugs.webkit.org/show_bug.cgi?id=18230
        tspan in link not working

        Implement SVG Errata: "The 'a' element may contain any
        element that its parent may contain, except itself."

        * svg/SVGAElement.cpp:
        (WebCore::SVGAElement::childShouldCreateRenderer):

2207
2208
2209
2210
2211
2212
2213
2214
2215
2216
2217
2218
2219
2220
2221
2222
2008-04-13  David Hyatt  <hyatt@apple.com>

        Fix for bug 18466, WebKit exhibits slow performance on Opera DHTML benchmark.  Improve layout's rect
        invalidation code to only invalidate a single unioned rect once enough individual little rects have
        been detected.

        Reviewed by olliej

        * page/FrameView.cpp:
        (WebCore::FrameViewPrivate::reset):
        (WebCore::FrameView::layout):
        (WebCore::FrameView::repaintRectangle):
        (WebCore::FrameView::beginDeferredRepaints):
        (WebCore::FrameView::endDeferredRepaints):
        * page/FrameView.h:

eric@webkit.org's avatar
eric@webkit.org committed
2223
2224
2225
2226
2227
2228
2229
2230
2231
2008-04-13  Eric Seidel  <eric@webkit.org>

        Reviewed by Oliver.

        Fix spelling error in function name, no test case.

        * svg/SVGTextContentElement.cpp:
        (WebCore::SVGInlineTextBoxQueryWalker::chunkPortionCallback):

eric@webkit.org's avatar
eric@webkit.org committed
2232
2233
2234
2235
2236
2237
2238
2239
2240
2008-04-13  Eric Seidel  <eric@webkit.org>

        Reviewed by Oliver.

        Build fix for +SVG_ANIMATION -SVG_FOREIGN_OBJECT build, no tests.

        * svg/SVGAnimateMotionElement.cpp:
        (WebCore::SVGAnimateMotionElement::hasValidTarget):

2241
2242
2243
2244
2245
2246
2247
2248
2249
2008-04-13  Jan Michael Alonzo  <jmalonzo@unpluggable.com>

        Reviewed by Oliver Hunt.

        http://bugs.webkit.org/show_bug.cgi?id=18239
        [Gtk] Build breaks if SVG is enabled but SVG Fonts disabled

        * svg/SVGAltGlyphElement.idl: Add SVG_FONTS in Conditional

2250
2251
2252
2253
2254
2255
2256
2257
2258
2259
2008-04-13  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by David.

        More SVG filters build fix.

        * svg/graphics/filters/SVGFEImage.cpp:
        (WebCore::SVGFEImage::~SVGFEImage):
        (WebCore::SVGFEImage::setCachedImage):

2260
2261
2262
2263
2264
2265
2266
2267
2008-04-13  David Hyatt  <hyatt@apple.com>

        Fix build bustage on the filters SVG code path (not built by default).

        * svg/SVGFEImageElement.cpp:
        (WebCore::SVGFEImageElement::~SVGFEImageElement):
        (WebCore::SVGFEImageElement::parseMappedAttribute):

2268
2269
2270
2271
2272
2273
2274
2275
2276
2277
2278
2279
2280
2281
2282
2283
2284
2285
2008-04-13  Dan Winship  <danw@gnome.org>

        Reviewed by Alp Toker.

        http://bugs.webkit.org/show_bug.cgi?id=18391
        return body data incrementally from libsoup backend

        Fix libsoup backend to pass data to the loader incrementally
        rather than all at once at the end.

        * platform/network/soup/ResourceHandleSoup.cpp
        (ResourceHandle::start): connect to "got-headers" and "got-chunk"
        signals on the message
        (gotHeadersCallback): call client->didReceiveResponse() from here
        (gotChunkCallback): call client->didReceiveData() from here
        (finishedCallback): renamed from dataCallback. mostly just calls
        client->didFinishLoading() now.

mitz@apple.com's avatar
mitz@apple.com committed
2286
2287
2288
2289
2290
2291
2292
2293
2294
2008-04-13  Dan Bernstein  <mitz@apple.com>

        Reviewed by Jessica Kahn.

        - remove duplicate condition in canHaveChildrenForEditing()

        * editing/htmlediting.cpp:
        (WebCore::canHaveChildrenForEditing):

mitz@apple.com's avatar
mitz@apple.com committed
2295
2296
2297
2298
2299
2300
2301
2302
2303
2304
2305
2306
2307
2308
2309
2310
2311
2008-04-13  Dan Bernstein  <mitz@apple.com>

        Reviewed by Darin Adler.

        - fix http://bugs.webkit.org/show_bug.cgi?id=18307
          <rdar://problem/5842546> REGRESSION (r31620): Incorrect Hiragino Kaku Gothic, font-weight:500

        Test: fast/css/font-weight-1.html

        * platform/graphics/mac/FontCacheMac.mm:
        (WebCore::toAppKitFontWeight): Adjusted the mapping to cover the AppKit
        weight range from 2 to 12, because AppKit weight 1 never occurs. The
        new mapping matches font-weight: n00 to ISO weight Wn.
        * platform/mac/WebFontCache.mm:
        (betterChoice): Changed the midpoint used when deciding between two
        candidates that deviate from the desired weight by the same amount.

2312
2313
2314
2315
2316
2317
2318
2319
2320
2321
2322
2323
2324
2325
2326
2327
2328
2329
2330
2331
2332
2333
2334
2335
2336
2337
2338
2339
2340
2341
2008-04-12  David Hyatt  <hyatt@apple.com>

        Memory management cleanup for the new StyleCachedImage and StyleGeneratedImage classes.  Make the back end
        values hold refptrs to cached front end values.  This will avoid malloc churn as RenderStyles get
        re-resolved.

        Reviewed by olliej

        * css/CSSCursorImageValue.cpp:
        (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed):
        (WebCore::CSSCursorImageValue::cachedImage):
        * css/CSSCursorImageValue.h:
        * css/CSSImageGeneratorValue.cpp:
        (WebCore::CSSImageGeneratorValue::CSSImageGeneratorValue):
        (WebCore::CSSImageGeneratorValue::generatedImage):
        * css/CSSImageGeneratorValue.h:
        * css/CSSImageValue.cpp:
        (WebCore::CSSImageValue::CSSImageValue):
        (WebCore::CSSImageValue::~CSSImageValue):
        (WebCore::CSSImageValue::cachedImage):
        * css/CSSImageValue.h:
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        (WebCore::CSSStyleSelector::createStyleImage):
        * css/CSSStyleSelector.h:
        * rendering/RenderStyle.h:
        (WebCore::StyleCachedImage::cachedImage):
        (WebCore::StyleGeneratedImage::StyleGeneratedImage):
        (WebCore::StyleGeneratedImage::data):

2342
2343
2344
2345
2346
2008-04-12  Julien Chaffraix  <jchaffraix@webkit.org>

        Not reviewed, Qt build fix.

        * dom/XMLTokenizer.cpp:
2347
       (WebCore::XMLTokenizer::parseEndElement):
2348
2349
2350
2351
2352
        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::clip):
        * platform/qt/ClipboardQt.cpp:
        (WebCore::ClipboardQt::setDragImage):

2353
2354
2355
2356
2357
2358
2359
2360
2361
2362
2363
2364
2365
2366
2367
2368
2369
2370
2371
2372
2373
2374
2375
2376
2377
2378
2379
2380
2381
2382
2383
2384
2385
2386
2387
2388
2389
2008-04-12  David Hyatt  <hyatt@apple.com>

        Add support for list-style-image gradients.  Also improve the image comparisons between two RenderStyles        
        to not mistakenly believe that images have changed.

        Reviewed by olliej

        Added fast/gradients/list-item-gradient.html

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        (WebCore::CSSStyleSelector::createStyleImage):
        * rendering/RenderListMarker.cpp:
        (WebCore::RenderListMarker::RenderListMarker):
        (WebCore::RenderListMarker::paint):
        (WebCore::RenderListMarker::imageChanged):
        (WebCore::RenderListMarker::calcPrefWidths):
        * rendering/RenderListMarker.h:
        * rendering/RenderStyle.cpp:
        (WebCore::imagesEquivalent):
        (WebCore::BorderImage::operator==):
        (WebCore::StyleCachedImage::errorOccurred):
        (WebCore::BackgroundLayer::operator==):
        (WebCore::StyleInheritedData::StyleInheritedData):
        (WebCore::cursorDataEquivalent):
        (WebCore::StyleInheritedData::operator==):
        (WebCore::RenderStyle::diff):
        * rendering/RenderStyle.h:
        (WebCore::StyleImage::errorOccurred):
        (WebCore::RenderStyle::listStyleImage):
        (WebCore::RenderStyle::setListStyleImage):
        (WebCore::RenderStyle::initialListStyleImage):

mitz@apple.com's avatar
mitz@apple.com committed
2390
2391
2392
2393
2394
2395
2396
2008-04-12  Dan Bernstein  <mitz@apple.com>

        - Windows build fix

        * platform/win/ClipboardWin.cpp:
        (WebCore::ClipboardWin::setDragImage):

2397
2398
2399
2400
2401
2402
2403
2008-04-12  Kevin Ollivier  <kevino@theolliviers.com>

        wx build fix. Update clip to take a FloatRect.

        * platform/graphics/wx/GraphicsContextWx.cpp:
        (WebCore::GraphicsContext::clip):

2404
2405
2406
2407
2408
2409
2410
2411
2412
2413
2414
2415
2416
2417
2418
2419
2420
2421
2422
2423
2424
2425
2426
2427
2428
2429
2430
2431
2432
2433
2434
2008-04-12  David Hyatt  <hyatt@apple.com>

        Add gradient support to border-image (even though it's mostly just weird).

        Reviewed by Dan

        Added fast/gradients/border-image-gradient.html
              fast/gradients/border-image-gradient-sides-and-corners.html

        * css/CSSBorderImageValue.h:
        (WebCore::CSSBorderImageValue::imageValue):
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        * platform/graphics/GeneratedImage.cpp:
        (WebCore::GeneratedImage::draw):
        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::paintBoxDecorations):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::imageChanged):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::mustRepaintBackgroundOrBorder):
        (WebCore::RenderObject::paintBorderImage):
        (WebCore::RenderObject::paintBorder):
        (WebCore::RenderObject::updateBackgroundImages):
        (WebCore::RenderObject::arenaDelete):
        * rendering/RenderStyle.cpp:
        (WebCore::StyleCachedImage::isLoaded):
        * rendering/RenderStyle.h:
        (WebCore::StyleImage::isLoaded):
        (WebCore::BorderImage::image):

mitz@apple.com's avatar
mitz@apple.com committed
2435
2436
2437
2438
2439
2440
2441
2442
2443
2444
2445
2446
2447
2448
2449
2450
2451
2452
2453
2454
2455
2456
2457
2458
2459
2460
2008-04-11  Dan Bernstein  <mitz@apple.com>

        Reviewed by Dave Hyatt.

        - fix a regression from r31324 which caused most Arabic text to render
          as missing glyphs

        Test: svg/W3C-SVG-1.1/fonts-glyph-02-t.svg

        * svg/SVGFont.cpp:
        (WebCore::SVGTextRunWalker::walk): Changed to always process characters
        in logical order and therefore dispatch the callbacks with a logically-
        ordered glyph stream. Changed the call to isCompatibleGlyph() to check
        for compatibility only with the range of characters the candidate glyph
        is derived from rather than with the entire lookup range. Changed to
        mark the <missing-glyph> glyph identifier as valid, to facilitate the
        use of invalid glyph identifiers to mark font fallback.
        (WebCore::drawTextUsingSVGFontCallback): Changed to only append the
        glyph identifier to a vector.
        (WebCore::drawTextMissingGlyphCallback): Changed to only append the
        character to a vector and append an invalid glyph identifier to the
        glyph vector.
        (WebCore::Font::drawTextUsingSVGFont): Moved the drawing from the
        callbacks into this function, iterating over the glyph and fallback
        characters vector in visual order.

eric@webkit.org's avatar
eric@webkit.org committed
2461
2462
2463
2464
2465
2466
2467
2468
2469
2008-04-11  Dirk Schulze <vbs85@gmx.de>

        Reviewed by eseidel.

        Attempt to fix Cairo build.

        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:

hyatt@apple.com's avatar
hyatt@apple.com committed
2470
2471
2472
2473
2474
2475
2476
2477
2478
2479
2480
2481
2482
2483
2484
2485
2486
2487
2488
2489
2490
2491
2492
2493
2494
2495
2496
2497
2498
2499
2500
2501
2502
2503
2504
2505
2506
2507
2508
2509
2510
2511
2512
2513
2514
2515
2516
2517
2518
2519
2520
2521
2522
2523
2524
2525
2526
2527
2528
2529
2530
2531
2532
2533
2534
2535
2536
2537
2538
2539
2540
2541
2542
2543
2544
2545
2546
2547
2548
2549
2550
2551
2552
2553
2554
2555
2556
2557
2558
2559
2008-04-11  David Hyatt  <hyatt@apple.com>

        Rename CachedResource's ref/deref methods to addClient/removeClient.  This matches the new
        StyleImage class and is a more accurate description of what those methods really do.

        Reviewed by olliej

        * WebCore.base.exp:
        * css/CSSCursorImageValue.cpp:
        (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed):
        * css/CSSFontFaceSource.cpp:
        (WebCore::CSSFontFaceSource::CSSFontFaceSource):
        (WebCore::CSSFontFaceSource::~CSSFontFaceSource):
        * css/CSSImageValue.cpp:
        (WebCore::CSSImageValue::~CSSImageValue):
        (WebCore::CSSImageValue::image):
        * css/CSSImportRule.cpp:
        (WebCore::CSSImportRule::~CSSImportRule):
        (WebCore::CSSImportRule::insertedIntoParent):
        * dom/ProcessingInstruction.cpp:
        (WebCore::ProcessingInstruction::~ProcessingInstruction):
        (WebCore::ProcessingInstruction::checkStyleSheet):
        (WebCore::ProcessingInstruction::parseStyleSheet):
        * dom/XMLTokenizer.cpp:
        (WebCore::XMLTokenizer::~XMLTokenizer):
        (WebCore::XMLTokenizer::endElementNs):
        (WebCore::XMLTokenizer::notifyFinished):
        * html/CanvasPattern.cpp:
        (WebCore::CanvasPattern::CanvasPattern):
        (WebCore::CanvasPattern::~CanvasPattern):
        * html/HTMLImageLoader.cpp:
        (WebCore::HTMLImageLoader::~HTMLImageLoader):
        (WebCore::HTMLImageLoader::setImage):
        (WebCore::HTMLImageLoader::updateFromElement):
        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::~HTMLLinkElement):
        (WebCore::HTMLLinkElement::process):
        * html/HTMLScriptElement.cpp:
        (WebCore::HTMLScriptElement::~HTMLScriptElement):
        (WebCore::HTMLScriptElement::parseMappedAttribute):
        (WebCore::HTMLScriptElement::insertedIntoDocument):
        (WebCore::HTMLScriptElement::removedFromDocument):
        (WebCore::HTMLScriptElement::notifyFinished):
        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::reset):
        (WebCore::HTMLTokenizer::scriptHandler):
        (WebCore::HTMLTokenizer::notifyFinished):
        * loader/CachedCSSStyleSheet.cpp:
        (WebCore::CachedCSSStyleSheet::addClient):
        * loader/CachedCSSStyleSheet.h:
        * loader/CachedFont.cpp:
        (WebCore::CachedFont::addClient):
        * loader/CachedFont.h:
        * loader/CachedImage.cpp:
        (WebCore::CachedImage::addClient):
        * loader/CachedImage.h:
        * loader/CachedResource.cpp:
        (WebCore::CachedResource::addClient):
        (WebCore::CachedResource::removeClient):
        * loader/CachedResource.h:
        * loader/CachedScript.cpp:
        (WebCore::CachedScript::addClient):
        * loader/CachedScript.h:
        * loader/CachedXBLDocument.h:
        * loader/CachedXSLStyleSheet.cpp:
        (WebCore::CachedXSLStyleSheet::addClient):
        * loader/CachedXSLStyleSheet.h:
        * loader/mac/UserStyleSheetLoader.cpp:
        (UserStyleSheetLoader::UserStyleSheetLoader):
        (UserStyleSheetLoader::~UserStyleSheetLoader):
        * platform/mac/ClipboardMac.mm:
        (WebCore::ClipboardMac::setDragImage):
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::~RenderImage):
        (WebCore::RenderImage::setCachedImage):
        * rendering/RenderListMarker.cpp:
        (WebCore::RenderListMarker::~RenderListMarker):
        (WebCore::RenderListMarker::setStyle):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::updateBackgroundImages):
        (WebCore::RenderObject::arenaDelete):
        * rendering/RenderStyle.cpp:
        (WebCore::StyleCachedImage::addClient):
        (WebCore::StyleCachedImage::removeClient):
        * svg/SVGImageLoader.cpp:
        (WebCore::SVGImageLoader::updateFromElement):
        * xml/XSLImportRule.cpp:
        (WebCore::XSLImportRule::~XSLImportRule):
        (WebCore::XSLImportRule::loadSheet):

2560
2561
2562
2563
2564
2565
2566
2567
2568
2569
2570
2571
2572
2573
2574
2575
2576
2577
2578
2579
2580
2581
2582
2583
2584
2585
2586
2587
2588
2589
2590
2591
2592
2593
2594
2595
2596
2597
2598
2599
2600
2601
2602
2603
2604
2605
2606
2607
2608
2609
2610
2611
2612
2613
2614
2615
2616
2617
2618
2619
2620
2621
2622
2623
2624
2625
2626
2627
2628
2629
2630
2631
2632
2633
2634
2635
2636
2637
2638
2639
2640
2641
2642
2643
2644
2645
2646
2647
2648
2649
2650
2651
2652
2653
2654
2655
2656
2657
2658
2659
2660
2661
2662
2663
2664
2665
2666
2667
2668
2669
2670
2671
2672
2673
2674
2675
2676
2677
2678
2679
2680
2681
2682
2683
2684
2685
2686
2687
2688
2689
2690
2691
2692
2693
2694
2695
2696
2697
2698
2699
2700
2701
2702
2703
2704
2705
2008-04-11  David Hyatt  <hyatt@apple.com>

        This patch adds support for CSS gradients as background images.  RenderStyles now hold a StyleImage
        RefPtr, which is a wrapper for two types of images: CachedImages (loaded from URLs) and generated images
        (patterns created on the fly such as gradients).

        All of the features of <canvas> are supported: gradients can be linear or radial, have multiple stops, and
        can specify their points as percentages (for reusable gradients across different box sizes).

        Reviewed by olliej

        Added fast/gradients/simple-gradients.html

        * WebCore.xcodeproj/project.pbxproj:
        * css/CSSBorderImageValue.cpp:
        (WebCore::CSSBorderImageValue::CSSBorderImageValue):
        * css/CSSBorderImageValue.h:
        (WebCore::CSSBorderImageValue::imageValue):
        (WebCore::CSSBorderImageValue::generatorValue):
        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/CSSGradientValue.cpp: Added.
        (WebCore::CSSGradientValue::cssText):
        (WebCore::CSSGradientValue::createGradient):
        (WebCore::CSSGradientValue::image):
        (WebCore::compareStops):
        (WebCore::CSSGradientValue::sortStopsIfNeeded):
        (WebCore::CSSGradientValue::resolvePoint):
        (WebCore::CSSGradientValue::resolveRadius):
        * css/CSSGradientValue.h: Added.
        (WebCore::):
        (WebCore::CSSGradientColorStop::CSSGradientColorStop):
        (WebCore::CSSGradientValue::CSSGradientValue):
        (WebCore::CSSGradientValue::type):
        (WebCore::CSSGradientValue::setType):
        (WebCore::CSSGradientValue::setFirstX):
        (WebCore::CSSGradientValue::setFirstY):
        (WebCore::CSSGradientValue::setSecondX):
        (WebCore::CSSGradientValue::setSecondY):
        (WebCore::CSSGradientValue::setFirstRadius):
        (WebCore::CSSGradientValue::setSecondRadius):
        (WebCore::CSSGradientValue::addStop):
        * css/CSSImageGeneratorValue.cpp: Added.
        (WebCore::CSSImageGeneratorValue::~CSSImageGeneratorValue):
        (WebCore::CSSImageGeneratorValue::addClient):
        (WebCore::CSSImageGeneratorValue::removeClient):
        (WebCore::CSSImageGeneratorValue::getImage):
        (WebCore::CSSImageGeneratorValue::putImage):
        * css/CSSImageGeneratorValue.h: Added.
        (WebCore::CSSImageGeneratorValue::isImageGeneratorValue):
        * css/CSSImageValue.h:
        (WebCore::CSSImageValue::isImageValue):
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseBackgroundImage):
        (WebCore::BorderImageParseContext::commitImage):
        (WebCore::CSSParser::parseBorderImage):
        (WebCore::parseGradientPoint):
        (WebCore::parseGradientColorStop):
        (WebCore::CSSParser::parseGradient):
        * css/CSSParser.h:
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        (WebCore::CSSStyleSelector::createStyleImage):
        (WebCore::CSSStyleSelector::mapBackgroundImage):
        * css/CSSStyleSelector.h:
        * css/CSSValue.h:
        (WebCore::CSSValue::isImageValue):
        (WebCore::CSSValue::isImageGeneratorValue):
        * html/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::isPointInPath):
        * platform/graphics/BitmapImage.cpp:
        (WebCore::BitmapImage::BitmapImage):
        (WebCore::BitmapImage::dataChanged):
        (WebCore::BitmapImage::frameCount):
        * platform/graphics/BitmapImage.h:
        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::clipToImageBuffer):
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/ImageBuffer.h:
        (WebCore::ImageBuffer::cgImage):
        (WebCore::ImageBuffer::image):
        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::clipToImageBuffer):
        (WebCore::GraphicsContext::paintBuffer):
        (WebCore::GraphicsContext::drawImage):
        * platform/graphics/cg/ImageBufferCG.cpp:
        (WebCore::ImageBuffer::create):
        (WebCore::ImageBuffer::ImageBuffer):
        (WebCore::ImageBuffer::~ImageBuffer):
        (WebCore::ImageBuffer::image):
        (WebCore::ImageBuffer::getImageData):
        (WebCore::ImageBuffer::putImageData):
        (WebCore::ImageBuffer::toDataURL):
        * platform/graphics/cg/ImageCG.cpp:
        (WebCore::BitmapImage::BitmapImage):
        (WebCore::BitmapImage::draw):
        (WebCore::Image::drawPattern):
        * platform/graphics/qt/ImageQt.cpp:
        (WebCore::BitmapImage::BitmapImage):
        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::paintBackground):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::calculateBackgroundSize):
        (WebCore::RenderBox::imageChanged):
        (WebCore::RenderBox::paintBackgroundExtended):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::mustRepaintBackgroundOrBorder):
        (WebCore::RenderObject::updateBackgroundImages):
        (WebCore::RenderObject::arenaDelete):
        * rendering/RenderStyle.cpp:
        (WebCore::StyleCachedImage::cssValue):
        (WebCore::StyleCachedImage::canRender):
        (WebCore::StyleCachedImage::imageSize):
        (WebCore::StyleCachedImage::setImageContainerSize):
        (WebCore::StyleCachedImage::addClient):
        (WebCore::StyleCachedImage::removeClient):
        (WebCore::StyleCachedImage::image):
        (WebCore::StyleGeneratedImage::cssValue):
        (WebCore::StyleGeneratedImage::imageSize):
        (WebCore::StyleGeneratedImage::setImageContainerSize):
        (WebCore::StyleGeneratedImage::addClient):
        (WebCore::StyleGeneratedImage::removeClient):
        (WebCore::StyleGeneratedImage::image):
        * rendering/RenderStyle.h:
        (WebCore::StyleImage::StyleImage):
        (WebCore::StyleImage::~StyleImage):
        (WebCore::StyleImage::operator==):
        (WebCore::StyleImage::canRender):
        (WebCore::StyleImage::isCachedImage):
        (WebCore::StyleImage::isGeneratedImage):
        (WebCore::StyleCachedImage::StyleCachedImage):
        (WebCore::StyleCachedImage::data):
        (WebCore::StyleCachedImage::isCachedImage):
        (WebCore::StyleGeneratedImage::StyleGeneratedImage):
        (WebCore::StyleGeneratedImage::data):
        (WebCore::StyleGeneratedImage::isGeneratedImage):
        (WebCore::BackgroundLayer::backgroundImage):
        (WebCore::BackgroundLayer::setBackgroundImage):
        (WebCore::BackgroundLayer::containsImage):
        (WebCore::RenderStyle::backgroundImage):
        (WebCore::RenderStyle::initialBackgroundImage):
        * svg/graphics/cg/SVGPaintServerGradientCg.cpp:
        (WebCore::SVGPaintServerGradient::teardown):
        * svg/graphics/cg/SVGResourceMaskerCg.mm:
        (WebCore::SVGResourceMasker::applyMask):

mitz@apple.com's avatar
mitz@apple.com committed
2706
2707
2708
2709
2710
2711
2712
2713
2714
2008-04-11  Dan Bernstein  <mitz@apple.com>

        Reviewed by Oliver Hunt.

        - add SVGGlyphMap.h to project files

        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:

2715
2716
2717
2718
2719
2720
2721
2722
2723
2724
2008-04-11  Anders Carlsson  <andersca@apple.com>

        Fix release build.
        
        * WebCore.base.exp:
        
        * loader/archive/ArchiveResource.h:
        (WebCore::ArchiveResource::response):
        This should be const.

2725
2726
2727
2728
2729
2730
2008-04-11  Antti Koivisto  <antti@apple.com>

        Try to fix Qt build.

        * svg/animation/SMILTime.cpp:

2731
2732
2733
2734
2735
2736
2737
2738
2739
2740
2741
2008-04-11  Anders Carlsson  <andersca@apple.com>

        Reviewed by Brady.

        Don't create the ArchiveResource response lazily.
        
        * loader/archive/ArchiveResource.cpp:
        (WebCore::ArchiveResource::ArchiveResource):
        * loader/archive/ArchiveResource.h:
        (WebCore::ArchiveResource::response):

2742
2743
2744
2745
2746
2747
2748
2749
2008-04-11  Jan Michael Alonzo  <jmalonzo@unpluggable.com>

        Reviewed by Mark Rowe.

        Added missing '\' in the svg include path

        * GNUmakefile.am:

2750
2751
2752
2753
2754
2755
2008-04-11  Antti Koivisto  <antti@apple.com>

        Another attempted Qt build fix.

        * WebCore.pro:

2756
2757
2758
2759
2760
2761
2762
2763
2764
2765
2766
2767
2768
2769
2770
2771
2772
2773
2774
2775
2776
2777
2778
2779
2780
2781
2782
2783
2784
2785
2786
2787
2788
2789
2790
2008-04-11  Antti Koivisto  <antti@apple.com>

        Reviewed by Oliver.

        Fix build when SVG is enabled but SVG_ANIMATION is not.

        * ChangeLog:
        * bindings/js/JSSVGElementWrapperFactory.cpp:
        * bindings/objc/DOM.mm:
        (WebCore::createElementClassMap):
        * svg/SVGAElement.cpp:
        (WebCore::SVGAElement::defaultEventHandler):
        * svg/SVGAnimateColorElement.cpp:
        * svg/SVGAnimateColorElement.h:
        * svg/SVGAnimateColorElement.idl:
        * svg/SVGAnimateMotionElement.h:
        * svg/SVGAnimationElement.cpp:
        (WebCore::SVGAnimationElement::animationMode):
        * svg/SVGAnimationElement.h:
        * svg/SVGAnimationElement.idl:
        * svg/SVGSetElement.cpp:
        * svg/SVGSetElement.h:
        * svg/SVGSetElement.idl:
        * svg/animation/SMILTimeContainer.cpp:
        (WebCore::SMILTimeContainer::begin):
        (WebCore::SMILTimeContainer::pause):
        (WebCore::SMILTimeContainer::resume):
        (WebCore::SMILTimeContainer::elapsed):
        (WebCore::SMILTimeContainer::isPaused):
        (WebCore::SMILTimeContainer::timerFired):
        * svg/animation/SMILTimeContainer.h:
        * svg/animation/SVGSMILElement.cpp:
        * svg/animation/SVGSMILElement.h:
        * svg/svgtags.in:

2791
2792
2793
2794
2795
2796
2797
2798
2799
2800
2801
2802
2803
2804
2805
2806
2807
2808
2809
2810
2811
2812
2813
2814
2815
2008-04-11  Anders Carlsson  <andersca@apple.com>

        Reviewed by Brady.

        Move archive loading from FrameLoader to DocumentLoader.
        
        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::DocumentLoader):
        (WebCore::DocumentLoader::clearArchiveResources):
        (WebCore::DocumentLoader::deliverArchivedResourcesAfterDelay):
        (WebCore::DocumentLoader::archiveResourceDeliveryTimerFired):
        (WebCore::DocumentLoader::isArchiveLoadPending):
        (WebCore::DocumentLoader::cancelPendingArchiveLoad):
        (WebCore::DocumentLoader::scheduleArchiveLoad):
        (WebCore::DocumentLoader::setDefersLoading):
        * loader/DocumentLoader.h:
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::FrameLoader):
        (WebCore::FrameLoader::setDefersLoading):
        (WebCore::FrameLoader::stopAllLoaders):
        * loader/FrameLoader.h:
        * loader/ResourceLoader.cpp:
        (WebCore::ResourceLoader::load):
        (WebCore::ResourceLoader::didCancel):

2816
2817
2818
2819
2820
2821
2822
2823
2824
2825
2826
2827
2828
2829
2830
2831
2008-04-11  Timothy Hatcher  <timothy@apple.com>

        Fixes the regression where the DOM tree does not update when navigating
        to another page with the Inspector open.

        https://bugs.webkit.org/show_bug.cgi?id=18418

        Reviewed by Adam Roben.

        * page/inspector/ElementsPanel.js:
        (WebInspector.ElementsPanel.prototype.reset): If the inspected document does not have a
        firstChild yet, add an event listener for DOMContentLoaded. The event listener just sets
        a proeprty that a polling functions looks for then triggers the reset.
        (WebInspector.ElementsPanel.prototype._focusedNodeChanged): Always call updateStyles with
        forceUpdate as true. This makes sure the Styles pane clears when there isn't a focused node.

2832
2833
2834
2835
2836
2837
2838
2839
2840
2008-04-11  Dan Bernstein  <mitz@apple.com>

        Reviewed by Timothy Hatcher.

        - fix http://bugs.webkit.org/show_bug.cgi?id=18412
          Inspector truncates text when editing a CSS property

        * page/inspector/inspector.css:

2841
2842
2843
2844
2845
2846
2847
2848
2849
2850
2008-04-11  Antti Koivisto  <antti@apple.com>

        Try to fix Qt build by including some headers.

        * ChangeLog:
        * platform/graphics/UnitBezier.h:
        * svg/SVGAnimationElement.cpp:
        * svg/animation/SMILTime.h:
        * svg/animation/SVGSMILElement.cpp:

2851
2852
2853
2854
2855
2856
2857
2008-04-11  Antti Koivisto  <antti@apple.com>

        Try to fix Windows build by switching to std::sort().

        * svg/animation/SVGSMILElement.cpp:
        (WebCore::sortTimeList):

rwlbuis@webkit.org's avatar
rwlbuis@webkit.org committed
2858
2859
2860
2861
2862
2863
2864
2865
2866
2867
2868
2869
2008-04-11  Rob Buis  <buis@kde.org>

        Reviewed by Eric.

        http://bugs.webkit.org/show_bug.cgi?id=18340
        Elements with display="none" in a <clipPath> still contribute to clipping path

        Skip elements in clip-path container that have display=none specified.

        * svg/SVGClipPathElement.cpp:
        (WebCore::SVGClipPathElement::canvasResource):

2870
2871
2872
2873
2874
2875
2876
2877
2878
2879
2880
2881
2882
2883
2884
2885
2886
2887
2888
2889
2890
2891
2892
2893
2894
2895
2896
2897
2898
2899
2900
2901
2902
2903
2904
2905
2906
2907
2908
2909
2910
2911
2912
2913
2914
2915
2916
2917
2918
2919
2920
2921
2922
2923
2924
2925
2926
2927
2928
2929
2930
2931
2932
2933
2934
2935
2936
2937
2938
2939
2940
2941
2942
2943
2944
2945
2946
2947
2948
2949
2950
2951
2952
2953
2954
2955
2956
2957
2958
2959
2960
2961
2962
2963
2964
2965
2966
2967
2968
2969
2970
2971
2972
2973
2974
2975
2976
2977
2978
2979
2980
2981
2982
2983
2984
2985
2986
2987
2988
2989
2990
2991
2992
2993
2994
2995
2996
2997
2998
2999
3000
3001
3002
3003
3004
3005
3006
3007
3008
3009
3010
3011
3012
3013
3014
3015
3016
3017
3018
3019
3020
3021
3022
3023
3024
3025
3026
3027
3028
3029
3030
3031
3032
3033
3034
3035
3036
3037
3038
3039
3040
3041
3042
3043
3044
3045
3046
3047
3048
3049
3050
3051
3052
3053
3054
3055
3056
3057
3058
3059
3060
3061
3062
3063
3064
3065
3066
3067
3068
3069
3070
3071
3072
3073
3074
3075
3076
3077
3078
3079
3080
3081
3082
3083
3084
3085
3086
3087
3088
3089
3090
3091
3092
3093
3094
3095
3096
3097
3098
3099
3100
3101
3102
3103
3104
3105
3106
3107
3108
3109
3110
3111
3112
3113
3114
3115
3116
3117
3118
3119
3120
3121
3122
3123
3124
3125
3126
3127
3128
3129
3130
3131
3132
3133
3134
3135
3136
3137
3138
3139
3140
3141
3142
2008-04-10  Antti Koivisto  <antti@apple.com>

        Reviewed by Eric.

        Redo the SVG animation support.
        
        It does
        - Full SMIL interval timing model including syncbase and event base timing (the hard part).
        - CSS and XML attribute animation.
        - Linear, discrete and spline calcModes.
        - Values animation with keyTimes and keySplines.
        - Link activated animations.
        - Pretty good support for <animate> and <set> animations
        - Basic support for <animateColor>, <animateMotion> and <animateTransform>.

        This passes some 35 of the 56 tests in W3C SVG animation test suite, a bunch more
        with some subtest failures.

        What is still missing
        - Additive animation with multiple animations operating on the same property. This is a
          major architectural feature in animation code. It shouldn't be too hard to add.
        - Only <animate> implements accumulate.
        - <animateMotion> does not do paths, keypoints, rotate.
        - <animateTransform> does not work correctly in all cases
        - calcMode paced is missing.
        - repeat, beginEvent, endEvent are missing.
        - accesskey() is missing.
        - JS does not see correct values for baseVal/animVal, changing values that are being
          animted for a script produces wrong results. This problem needs to be solved outside
          the animation code.
        - Some other stuff I forgot or do not know about.

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * dom/Document.cpp:
        * history/CachedPage.cpp:
        (WebCore::CachedPage::CachedPage):
        
        Use cache notification mechanism to start/stop animations.

        * svg/SVGAElement.cpp:
        (WebCore::SVGAElement::defaultEventHandler):
        
        Start target animation on link activation.
        
        * svg/SVGAnimateColorElement.cpp:
        (WebCore::SVGAnimateColorElement::applyAnimatedValueToElement):
        (WebCore::SVGAnimateColorElement::updateAnimatedValue):
        (WebCore::SVGAnimateColorElement::calculateFromAndToValues):
        (WebCore::SVGAnimateColorElement::calculateFromAndByValues):
        * svg/SVGAnimateColorElement.h:
        * svg/SVGAnimateElement.cpp:
        (WebCore::SVGAnimateElement::SVGAnimateElement):
        (WebCore::parseNumberValueAndUnit):
        (WebCore::SVGAnimateElement::applyAnimatedValueToElement):
        (WebCore::SVGAnimateElement::updateAnimatedValue):
        (WebCore::isColorAttribute):
        (WebCore::SVGAnimateElement::calculateFromAndToValues):
        (WebCore::SVGAnimateElement::calculateFromAndByValues):
        * svg/SVGAnimateElement.h:
        (WebCore::SVGAnimateElement::):
        * svg/SVGAnimateMotionElement.cpp:
        (WebCore::SVGAnimateMotionElement::SVGAnimateMotionElement):
        (WebCore::SVGAnimateMotionElement::parseMappedAttribute):
        (WebCore::SVGAnimateMotionElement::updateAnimatedValue):
        (WebCore::parsePoint):
        (WebCore::SVGAnimateMotionElement::calculateFromAndToValues):
        (WebCore::SVGAnimateMotionElement::calculateFromAndByValues):
        (WebCore::SVGAnimateMotionElement::applyAnimatedValueToElement):
        (WebCore::SVGAnimateMotionElement::startedActiveInterval):
        * svg/SVGAnimateMotionElement.h:
        * svg/SVGAnimateTransformElement.cpp:
        (WebCore::SVGAnimateTransformElement::SVGAnimateTransformElement):
        (WebCore::SVGAnimateTransformElement::hasValidTarget):
        (WebCore::SVGAnimateTransformElement::updateAnimatedValue):
        (WebCore::transformListFor):
        (WebCore::SVGAnimateTransformElement::applyAnimatedValueToElement):
        (WebCore::SVGAnimateTransformElement::calculateFromAndToValues):
        (WebCore::SVGAnimateTransformElement::calculateFromAndByValues):
        (WebCore::SVGAnimateTransformElement::startedActiveInterval):
        (WebCore::SVGAnimateTransformElement::parseTransformValue):
        * svg/SVGAnimateTransformElement.h:
        
        Concrete anmation element classes.
        
        * svg/SVGAnimationElement.cpp:
        (WebCore::SVGAnimationElement::SVGAnimationElement):
        (WebCore::SVGAnimationElement::~SVGAnimationElement):
        (WebCore::parseKeyTimes):
        (WebCore::parseKeySplines):
        (WebCore::SVGAnimationElement::parseMappedAttribute):
        (WebCore::SVGAnimationElement::attributeChanged):
        (WebCore::SVGAnimationElement::getStartTime):
        (WebCore::SVGAnimationElement::getCurrentTime):
        (WebCore::SVGAnimationElement::getSimpleDuration):
        (WebCore::SVGAnimationElement::beginElement):
        (WebCore::SVGAnimationElement::beginElementAt):
        (WebCore::SVGAnimationElement::endElement):
        (WebCore::SVGAnimationElement::endElementAt):
        (WebCore::SVGAnimationElement::animationMode):
        (WebCore::SVGAnimationElement::calcMode):
        (WebCore::SVGAnimationElement::attributeType):
        (WebCore::SVGAnimationElement::toValue):
        (WebCore::SVGAnimationElement::byValue):
        (WebCore::SVGAnimationElement::fromValue):
        (WebCore::SVGAnimationElement::attributeName):
        (WebCore::SVGAnimationElement::isAdditive):
        (WebCore::SVGAnimationElement::isAccumulated):
        (WebCore::SVGAnimationElement::hasValidTarget):
        (WebCore::SVGAnimationElement::targetAttributeIsCSS):
        (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue):
        (WebCore::SVGAnimationElement::targetAttributeBaseValue):
        (WebCore::solveEpsilon):
        (WebCore::SVGAnimationElement::currentValuesForValuesAnimation):
        (WebCore::SVGAnimationElement::startedActiveInterval):
        (WebCore::SVGAnimationElement::applyAnimation):
        (WebCore::SVGAnimationElement::unapplyAnimation):
        (WebCore::SVGAnimationElement::endedActiveInterval):
        * svg/SVGAnimationElement.h:
        (WebCore::SVGAnimationElement::):
        
        This is pretty much a complete rewrite of the SVGAnimationElement. Timing related functionality
        was refactored to SMILTimingElement class that this class now inherits.
        
        * svg/SVGDocumentExtensions.cpp:
        (WebCore::SVGDocumentExtensions::startAnimations):