ChangeLog 511 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44
2012-10-15  Antonio Gomes  <agomes@rim.com>

        [BlackBerry] Clean up BackingStoreClient (part II)
        https://bugs.webkit.org/show_bug.cgi?id=99327

        Reviewed by Yong Li.

        Remove more unneeded BackingStoreClient <-> WebPageClient integration
        methods:
        - BackingStoreClient* backingStoreClientForFrame(...)
        - void addBackingStoreClientForFrame(...)
        - void removeBackingStoreClientForFrame(...)

        Change places calling WPPriv::backingStoreClientForFrame to directly
        access WPPriv::backingStoreClient instead, since only the main frame will
        have a BackingStoreClient instance associated with it, and it is owned by
        the WKPriv.

        Remove non-mainframe only references to BackingStoreClient completely,
        since it is dead code now.

        * Api/InRegionScroller.cpp:
        (BlackBerry::WebKit::InRegionScrollerPrivate::setLayerScrollPosition):
        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::backingStoreClient):
        (BlackBerry::WebKit::WebPage::destroy):
        * Api/WebPage_p.h:
        (WebPagePrivate):
        * WebCoreSupport/ChromeClientBlackBerry.cpp:
        (WebCore::ChromeClientBlackBerry::invalidateContentsForSlowScroll):
        (WebCore::ChromeClientBlackBerry::scroll):
        * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
        (WebCore::FrameLoaderClientBlackBerry::transitionToCommittedForNewPage):
        (WebCore::FrameLoaderClientBlackBerry::createFrame):
        (WebCore::FrameLoaderClientBlackBerry::detachedFromParent2):
        * WebKitSupport/BackingStoreClient.cpp:
        (BlackBerry::WebKit::BackingStoreClient::create):
        (BlackBerry::WebKit::BackingStoreClient::BackingStoreClient):
        (BlackBerry::WebKit::BackingStoreClient::~BackingStoreClient):
        * WebKitSupport/BackingStoreClient.h:
        (BackingStoreClient):
        * WebKitSupport/InputHandler.cpp:
        (BlackBerry::WebKit::InputHandler::setBatchEditingActive):

45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65
2012-10-15  Antonio Gomes  <agomes@rim.com>

        [BlackBerry] Clean up BackingStoreClient (part I)
        https://bugs.webkit.org/show_bug.cgi?id=99327

        Reviewed by Yong Li.

        Now that we won't use the BackingStoreClient code path to scroll inner frames at all
        (instead we use AC layers!), we can remove all "!isMainFrame" code paths.

        No behavior change, since the code path being removed was not in use.

        * WebKitSupport/BackingStoreClient.cpp:
        (BlackBerry::WebKit::BackingStoreClient::absoluteRect):
        (BlackBerry::WebKit::BackingStoreClient::transformedActualVisibleSize):
        (BlackBerry::WebKit::BackingStoreClient::viewportSize):
        (BlackBerry::WebKit::BackingStoreClient::transformedViewportSize):
        (BlackBerry::WebKit::BackingStoreClient::visibleContentsRect):
        (BlackBerry::WebKit::BackingStoreClient::transformedVisibleContentsRect):
        (BlackBerry::WebKit::BackingStoreClient::checkOriginOfCurrentScrollOperation):

66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208
2012-10-13  Jakob Petsovits  <jpetsovits@rim.com>

        [BlackBerry] Fetch blit rects from a viewport accessor
        https://bugs.webkit.org/show_bug.cgi?id=98581
        RIM PR 173292

        Reviewed by George Staikos.
        Internally reviewed by Arvid Nilsson.

        The long-standing userInterfaceBlittedVisibleContentsRect()
        method in WebPageClient has long been a major annoyance,
        as it returns the source rect for WebKit contents but in
        backingstore pixel coordinates. This makes it not only
        unwieldy but also terribly fragile, especially when
        both pinch zoom and a backingstore re-render both deal
        with the same rectangle. On different threads, even.

        BlackBerry::Platform now exposes a ViewportAccessor
        interface, which can be used to get the various rects
        in document coordinates or target pixel coordinates,
        both being a better choice than the ones dependent
        on an implentation detail.

        This commit makes use of this new functionality.
        Instead of relying on the passed rectangle to contain
        implicit information about the scale factor, we now
        track the scale of each backingstore geometry by making
        a snapshot of the current WebKit-thread scale when the
        geometry is generated. Once the geometry is swapped to
        the front, we can then calculate the remaining
        backingstore-to-viewport transformation in a threadsafe
        way. We now only calculate this if we actually blit from
        backingstore tiles and don't go through a configuration
        of pure accelerated compositing.

        As a result, we are now a lot more robust against
        synchonization issues related to backingstore
        geometry changes. As an additional gimmick, the scale
        is also stored with each tile buffer to doubly secure
        that a tile rendered in one scale is not transferred
        to a different geometry and then rendered there without
        being rerendered at the new scale, even if the rendered
        pixel coordinates are still the same.

        Having per-geometry scale information also opens up
        opportunities to further improve backingstore rendering
        later. For instance, we could pre-render a low-res
        version of the page onto one buffer and combine that one
        with a higher-res array of tiles covering a smaller area.
        Or we could steal some tiles from the front geometry to
        render them at a new scale while a pinch-zoom operation
        is in progress.

        No such thing is implemented in this patch though.

        In adapting/fixing the backingstore visualization
        debug mode and the default background painting in
        renderDirectToWindow(), we also introduce new
        ViewportAccessor subclasses that can subsequently
        be used to replace methods from WebPage and elsewhere.

        * Api/BackingStore.cpp:
        (BlackBerry::WebKit::BackingStorePrivate::slowScroll):
        (BlackBerry::WebKit::BackingStorePrivate::scroll):
        (BlackBerry::WebKit::BackingStorePrivate::setBackingStoreRect):
        (BlackBerry::WebKit::BackingStorePrivate::scrollBackingStore):
        (BlackBerry::WebKit::BackingStorePrivate::renderDirectToWindow):
        (BlackBerry::WebKit::BackingStorePrivate::render):
        (BlackBerry::WebKit::BackingStorePrivate::paintDefaultBackground):
        (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
        (BlackBerry::WebKit::BackingStorePrivate::blitHorizontalScrollbar):
        (BlackBerry::WebKit::BackingStorePrivate::blitVerticalScrollbar):
        (BlackBerry::WebKit::BackingStorePrivate::updateTilesForScrollOrNotRenderedRegion):
        (BlackBerry::WebKit::BackingStorePrivate::updateTileMatrixIfNeeded):
        (BlackBerry::WebKit::BackingStorePrivate::orientationChanged):
        (BlackBerry::WebKit::BackingStorePrivate::createSurfaces):
        (BlackBerry::WebKit::BackingStorePrivate::invalidateWindow):
        * Api/BackingStore_p.h:
        (BlackBerry):
        (Platform):
        (BlackBerry::WebKit::BackingStoreGeometry::BackingStoreGeometry):
        (BlackBerry::WebKit::BackingStoreGeometry::scale):
        (BlackBerry::WebKit::BackingStoreGeometry::setScale):
        (BackingStoreGeometry):
        (BackingStorePrivate):
        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
        (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
        (BlackBerry::WebKit::WebPagePrivate::init):
        (BlackBerry::WebKit::WebPage::webkitThreadViewportAccessor):
        (WebKit):
        * Api/WebPage.h:
        (Platform):
        * Api/WebPageClient.h:
        (Platform):
        * Api/WebPageCompositor.cpp:
        (BlackBerry::WebKit::WebPageCompositorPrivate::animationFrameChanged):
        * Api/WebPage_p.h:
        (WebKit):
        (WebPagePrivate):
        * WebKitSupport/BackingStoreTile.cpp:
        (BlackBerry::WebKit::TileBuffer::TileBuffer):
        (BlackBerry::WebKit::TileBuffer::isRendered):
        * WebKitSupport/BackingStoreTile.h:
        (TileBuffer):
        (BlackBerry::WebKit::TileBuffer::scale):
        (BlackBerry::WebKit::TileBuffer::setScale):
        * WebKitSupport/BackingStoreVisualizationViewportAccessor.cpp: Added.
        (WebKit):
        (BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::BackingStoreVisualizationViewportAccessor):
        (BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::pixelContentsSize):
        (BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::documentContentsSize):
        (BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::pixelScrollPosition):
        (BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::documentScrollPosition):
        (BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::pixelViewportSize):
        (BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::documentViewportSize):
        (BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::destinationSurfaceOffset):
        (BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::scale):
        (BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::state):
        * WebKitSupport/BackingStoreVisualizationViewportAccessor.h: Added.
        (BlackBerry):
        (Platform):
        (WebKit):
        (BackingStoreVisualizationViewportAccessor):
        (BlackBerry::WebKit::BackingStoreVisualizationViewportAccessor::~BackingStoreVisualizationViewportAccessor):
        * WebKitSupport/WebKitThreadViewportAccessor.cpp: Added.
        (WebKit):
        (BlackBerry::WebKit::WebKitThreadViewportAccessor::WebKitThreadViewportAccessor):
        (BlackBerry::WebKit::WebKitThreadViewportAccessor::pixelContentsSize):
        (BlackBerry::WebKit::WebKitThreadViewportAccessor::documentContentsSize):
        (BlackBerry::WebKit::WebKitThreadViewportAccessor::pixelScrollPosition):
        (BlackBerry::WebKit::WebKitThreadViewportAccessor::documentScrollPosition):
        (BlackBerry::WebKit::WebKitThreadViewportAccessor::pixelViewportSize):
        (BlackBerry::WebKit::WebKitThreadViewportAccessor::documentViewportSize):
        (BlackBerry::WebKit::WebKitThreadViewportAccessor::destinationSurfaceOffset):
        (BlackBerry::WebKit::WebKitThreadViewportAccessor::scale):
        * WebKitSupport/WebKitThreadViewportAccessor.h: Added.
        (BlackBerry):
        (Platform):
        (WebKit):
        (WebKitThreadViewportAccessor):
        (BlackBerry::WebKit::WebKitThreadViewportAccessor::~WebKitThreadViewportAccessor):

209 210 211 212 213 214 215 216 217 218 219 220
2012-10-11  Peter Wang  <peter.wang@torchmobile.com.cn>

        [BlackBerry] Paused in Inspector, Browser doesn't exit cleanly
        https://bugs.webkit.org/show_bug.cgi?id=97962

        Reviewed by George Staikos.

        Before destroying webpage, close the inspector, so if the JSC is paused it will be resumed.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPage::destroy):

221 222 223 224 225 226 227 228 229 230 231 232
2012-10-11  Konrad Piascik  <kpiascik@rim.com>

        Web Inspector: node search does not work with elements on touch start listener
        https://bugs.webkit.org/show_bug.cgi?id=95252

        Reviewed by Pavel Feldman.

        Removed calls to InspectorInstrumentation that no didn't work anyway.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPage::touchEvent):

233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260
2012-10-11  Chris Guan  <chris.guan@torchmobile.com.cn>

        [Blackberry] makes NavigatorContentUtils work
        https://bugs.webkit.org/show_bug.cgi?id=99022

        Reviewed by Rob Buis.

        Because r126735 renamed RegisterProtocolHandler API to NavigatorContentUtils and 
        r122810 added RegisterProtocolHandlerClient to the Modules/protocolhandler,
        we need sync up code:
        1. Add NavigatorContentUtilsClientBlackBerry class.
        2. use new API provideNavigatorContentUtilsTo.

        No new tests. Covered by existing tests.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::init):
        * WebCoreSupport/NavigatorContentUtilsClientBlackBerry.cpp: Added.
        (WebCore):
        (WebCore::NavigatorContentUtilsClientBlackBerry::NavigatorContentUtilsClientBlackBerry):
        (WebCore::NavigatorContentUtilsClientBlackBerry::registerProtocolHandler):
        (WebCore::NavigatorContentUtilsClientBlackBerry::isProtocolHandlerRegistered):
        (WebCore::NavigatorContentUtilsClientBlackBerry::unregisterProtocolHandler):
        * WebCoreSupport/NavigatorContentUtilsClientBlackBerry.h: Added.
        (WebKit):
        (NavigatorContentUtilsClientBlackBerry):
        (WebCore::NavigatorContentUtilsClientBlackBerry::~NavigatorContentUtilsClientBlackBerry):

261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284
2012-10-10  Lianghui Chen  <liachen@rim.com>

        [BlackBerry] Fix assertion in NetworkJob::notifyChallengeResult.
        https://bugs.webkit.org/show_bug.cgi?id=97397
        Internal PR: 186597.

        Internally reviewed by Yong Li, Joe Mason.
        Reviewed by George Staikos.

        Update WebPage to use new AuthenticationChallengeManager.
        Register page creation/deletion and visibility change to the new
            AuthenticationChallengeManager.
        Initialize AuthenticationChallengeManager in GlobalInitialize() function.

        * Api/BlackBerryGlobal.cpp:
        (BlackBerry::WebKit::globalInitialize):
        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
        (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
        (BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
        (BlackBerry::WebKit::WebPage::setVisible):
        * Api/WebPage_p.h:
        (WebPagePrivate):

285 286 287 288 289 290 291 292 293 294 295 296 297 298 299
2012-10-10  Andrew Lo  <anlo@rim.com>

        [BlackBerry] Do not perform backing store blit for animations during one-shot drawing synchronization
        https://bugs.webkit.org/show_bug.cgi?id=98944

        Reviewed by Rob Buis.

        Internally reviewed by: Arvid Nilsson.
        Internal PR 220014
        Prevent animations from causing a backing store blit during a
        one-shot drawing synchronization.

        * Api/WebPageCompositor.cpp:
        (BlackBerry::WebKit::WebPageCompositorPrivate::animationFrameChanged):

300 301 302 303 304 305 306 307 308 309 310 311 312 313
2012-10-10  Mike Fenton  <mifenton@rim.com>

        [BlackBerry] Fix crash for detached node when validating selection change.
        https://bugs.webkit.org/show_bug.cgi?id=98926

        Reviewed by Rob Buis.

        PR 220628.

        Guard against detached nodes when generating selection rect.

        * WebKitSupport/DOMSupport.cpp:
        (BlackBerry::WebKit::DOMSupport::visibleTextQuads):

314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331
2012-10-10  Mike Fenton  <mifenton@rim.com>

        [BlackBerry] Adjust spell checking location to update after the cursor position is set.
        https://bugs.webkit.org/show_bug.cgi?id=98904

        Reviewed by Rob Buis.

        PR 215172.

        Delay calculation of caret position until it is updated on mouse release
        handling.

        Reviewed Internally by Nima Ghanavatian.

        * WebKitSupport/InputHandler.cpp:
        (BlackBerry::WebKit::InputHandler::shouldRequestSpellCheckingOptionsForPoint):
        (BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):

332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351
2012-10-10  Mike Fenton  <mifenton@rim.com>

        [BlackBerry] Suppress keyboard requests while processing spell checking suggestions unless focus change is occurring..
        https://bugs.webkit.org/show_bug.cgi?id=98903

        Reviewed by Rob Buis.

        PR 221143.

        Suppress keyboard state changes when they are not triggered by
        focus changes.

        Reviewed Internally by Nima Ghanavatian.

        * WebKitSupport/InputHandler.cpp:
        (BlackBerry::WebKit::InputHandler::setElementUnfocused):
        (BlackBerry::WebKit::InputHandler::setElementFocused):
        (BlackBerry::WebKit::InputHandler::notifyClientOfKeyboardVisibilityChange):
        * WebKitSupport/InputHandler.h:

352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370
2012-10-09  Rob Buis  <rbuis@rim.com>

        [BlackBerry] Cleanup FatFingers.cpp
        https://bugs.webkit.org/show_bug.cgi?id=98806

        Reviewed by Antonio Gomes.

        Cleanup namespace usage and sync up FatFingers.cpp.

        * WebKitSupport/FatFingers.cpp:
        (BlackBerry::WebKit::compareDistanceBetweenPoints):
        (BlackBerry::WebKit::FatFingers::findBestPoint):
        (BlackBerry::WebKit::FatFingers::checkFingerIntersection):
        (BlackBerry::WebKit::FatFingers::findIntersectingRegions):
        (BlackBerry::WebKit::FatFingers::checkForClickableElement):
        (BlackBerry::WebKit::FatFingers::checkForText):
        (BlackBerry::WebKit::FatFingers::getNodesFromRect):
        (BlackBerry::WebKit::FatFingers::getRelevantInfoFromPoint):

371 372 373 374 375 376 377 378 379 380
2012-10-09  Antonio Gomes  <agomes@rim.com>

        Get rid of FIXED_POSITION_CREATES_STACKING_CONTEXT in favor of Settings::fixedPositionCreatesStackingContext()
        https://bugs.webkit.org/show_bug.cgi?id=98756

        Reviewed by Rob Buis.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::init):

381 382 383 384 385 386 387 388 389 390 391 392 393 394 395
2012-10-09  Charles Wei  <charles.wei@torchmobile.com.cn>

        [BlackBerry] Need API to control the DNS Prefetching
        https://bugs.webkit.org/show_bug.cgi?id=98713

        Reviewed by George Staikos.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::init):
        (BlackBerry::WebKit::WebPage::enableDNSPrefetch):
        (WebKit):
        (BlackBerry::WebKit::WebPage::disableDNSPrefetch):
        (BlackBerry::WebKit::WebPage::isDNSPrefetchEnabled):
        * Api/WebPage.h:

396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422
2012-10-07  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>

        Rename first/second to key/value in HashMap iterators
        https://bugs.webkit.org/show_bug.cgi?id=82784

        Reviewed by Eric Seidel.

        * Api/BackingStore.cpp:
        (BlackBerry::WebKit::BackingStorePrivate::setBackingStoreRect):
        (BlackBerry::WebKit::BackingStorePrivate::visibleTilesRect):
        (BlackBerry::WebKit::BackingStorePrivate::resetTiles):
        (BlackBerry::WebKit::BackingStorePrivate::updateTiles):
        (BlackBerry::WebKit::BackingStorePrivate::updateTilesForScrollOrNotRenderedRegion):
        (BlackBerry::WebKit::BackingStorePrivate::mapFromTransformedContentsToTiles):
        * WebCoreSupport/NotificationPresenterImpl.cpp:
        (WebCore::NotificationPresenterImpl::cancel):
        (WebCore::NotificationPresenterImpl::onPermission):
        (WebCore::NotificationPresenterImpl::notificationClicked):
        * WebCoreSupport/UserMediaClientImpl.cpp:
        (WebCore::UserMediaClientImpl::cancelUserMediaRequest):
        * WebKitSupport/AboutData.cpp:
        (BlackBerry::WebKit::dumpJSCTypeCountSetToTableHTML):
        * WebKitSupport/FrameLayers.cpp:
        (BlackBerry::WebKit::FrameLayers::removeLayerByFrame):
        (BlackBerry::WebKit::FrameLayers::commitOnWebKitThread):
        (BlackBerry::WebKit::FrameLayers::calculateRootLayer):

423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441
2012-10-05  Rob Buis  <rbuis@rim.com>

        [BlackBerry] Implement TestRunner.setMockDeviceOrientation
        https://bugs.webkit.org/show_bug.cgi?id=98542

        Reviewed by Antonio Gomes.

        PR 120681

        Provide framework for mock device motion.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::init):
        * WebKitSupport/DumpRenderTreeSupport.cpp:
        (toDeviceOrientationClientMock):
        (DumpRenderTreeSupport::setMockDeviceOrientation):
        * WebKitSupport/DumpRenderTreeSupport.h:
        (DumpRenderTreeSupport):

442 443 444 445 446 447 448 449 450 451 452 453
2012-10-05  Konrad Piascik  <kpiascik@rim.com>

        [BlackBerry] Remove unnecessary html file.
        https://bugs.webkit.org/show_bug.cgi?id=98531

        Reviewed by Yong Li.

        We now just use Source/WebCore/inspector/front-end/inspector.html
        instead.

        * WebCoreSupport/inspectorBB.html: Removed.

454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471
2012-10-05  Antonio Gomes  <agomes@rim.com>

        [BlackBerry] Find a proper fix for the WebPagePrivate::enqueueRenderingOfClippedContentOfScrollableNodeAfterInRegionScrolling hack
        https://bugs.webkit.org/show_bug.cgi?id=98517
        PR #137382

        Reviewed by Yong Li.

        We've generalized composited in-region scrolling, originally only applicable
        to block elements, to inner frames (see PR #197093). Past that, we no longer
        need to force repaints of offscreen areas when we finish scrolling, since translating
        the Layer takes care of properly invalidating it. Thus, remove this method.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::notifyInRegionScrollStopped):
        * Api/WebPage_p.h:
        (WebPagePrivate):

472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488
2012-10-05  Mike Fenton  <mifenton@rim.com>

        [BlackBerry] Update default input support style for single line inputs.
        https://bugs.webkit.org/show_bug.cgi?id=98510

        Reviewed by Antonio Gomes.

        PR 219588.

        Update style calculations to eliminate automatic changes
        by default on single line input fields.

        Reviewed Internally by Gen Mak.

        * WebKitSupport/InputHandler.cpp:
        (BlackBerry::WebKit::inputStyle):

489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520
2012-10-04  Simon Fraser  <simon.fraser@apple.com>

        Final part of "sync" to "flush" renaming
        https://bugs.webkit.org/show_bug.cgi?id=98430

        Reviewed by Tim Horton.

        Change method names on GraphicsLayer and GraphicsLayerClient that
        refer to "sync" to use the term "flush" instead, to be consistent
        with the rest of the code.

        * Api/WebOverlay.cpp:
        (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::notifyFlushRequired):
        * Api/WebOverlay_p.h:
        (WebOverlayPrivateWebKitThread):
        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::notifyFlushRequired):
        * Api/WebPage_p.h:
        (WebPagePrivate):
        * WebKitSupport/DefaultTapHighlight.cpp:
        (BlackBerry::WebKit::DefaultTapHighlight::notifyFlushRequired):
        * WebKitSupport/DefaultTapHighlight.h:
        (DefaultTapHighlight):
        * WebKitSupport/InspectorOverlayBlackBerry.cpp:
        (BlackBerry::WebKit::InspectorOverlay::notifyFlushRequired):
        * WebKitSupport/InspectorOverlayBlackBerry.h:
        (InspectorOverlay):
        * WebKitSupport/SelectionOverlay.cpp:
        (BlackBerry::WebKit::SelectionOverlay::notifyFlushRequired):
        * WebKitSupport/SelectionOverlay.h:
        (SelectionOverlay):

521 522 523 524 525 526 527 528 529 530 531 532 533 534 535
2012-10-04  Simon Fraser  <simon.fraser@apple.com>

        Standardize on "flush" terminology for compositing layer flushing/syncing
        https://bugs.webkit.org/show_bug.cgi?id=98321

        Reviewed by Simon Fraser.

        Rename compositing-related methods that refer to "syncing" to instead
        refer to "flushing".

        * WebCoreSupport/ChromeClientBlackBerry.cpp:
        (WebCore::ChromeClientBlackBerry::scheduleCompositingLayerFlush):
        * WebCoreSupport/ChromeClientBlackBerry.h:
        (ChromeClientBlackBerry):

536 537 538 539 540 541 542 543 544 545 546 547 548 549 550
2012-10-03  Antonio Gomes  <agomes@rim.com>

        [BlackBerry] Exiting fullscreen does not set the correct scroll position (Part II)
        https://bugs.webkit.org/show_bug.cgi?id=97917
        PR #212920

        Reviewed by Yong Li.
        Internally reviewed by Jacky Jiang.

        Inform the client of transform change so that we avoid
        getting stuck on overscroll.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::setViewportSize):

551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577
2012-10-03  Otto Derek Cheung  <otcheung@rim.com>

        [BlackBerry] Implementing the NetworkInfo API for BB port
        https://bugs.webkit.org/show_bug.cgi?id=98273

        Reviewed by Rob Buis.

        Adding new class NetworkInfoClientBlackBerry to implement
        NetworkInfoClient for the BlackBerry port.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::init):
        * WebCoreSupport/NetworkInfoClientBlackBerry.cpp: Added.
        (WebCore):
        (WebCore::NetworkInfoClientBlackBerry::NetworkInfoClientBlackBerry):
        (WebCore::NetworkInfoClientBlackBerry::startUpdating):
        (WebCore::NetworkInfoClientBlackBerry::stopUpdating):
        (WebCore::NetworkInfoClientBlackBerry::bandwidth):
        (WebCore::NetworkInfoClientBlackBerry::metered):
        (WebCore::NetworkInfoClientBlackBerry::onCurrentNetworkChange):
        (WebCore::NetworkInfoClientBlackBerry::onCurrentCellularTypeChange):
        * WebCoreSupport/NetworkInfoClientBlackBerry.h: Added.
        (WebKit):
        (WebCore):
        (NetworkInfoClientBlackBerry):
        (WebCore::NetworkInfoClientBlackBerry::~NetworkInfoClientBlackBerry):

578 579 580 581 582 583 584 585 586 587
2012-10-02  Anders Carlsson  <andersca@apple.com>

        Change most GraphicsLayer::create calls to use the version that takes a GraphicsLayerFactory
        https://bugs.webkit.org/show_bug.cgi?id=98217

        Reviewed by Andreas Kling.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::overlayLayer):

588 589 590 591 592 593 594 595 596 597 598 599 600
2012-10-02  Yong Li  <yoli@rim.com>

        [BlackBerry] Prevent window.close() from closing pages that are not opened by JS
        https://bugs.webkit.org/show_bug.cgi?id=98190

        Reviewed by Antonio Gomes.

        RIM PR# 217812.
        Only pages opened by JS can be closed by JS.

        * WebCoreSupport/ChromeClientBlackBerry.cpp:
        (WebCore::ChromeClientBlackBerry::closeWindowSoon):

601 602 603 604 605 606 607 608 609 610 611 612 613
2012-10-01  Brady Eidson  <beidson@apple.com>

        Remove the Safari 2 -> Safari 3 icon database import code.
        https://bugs.webkit.org/show_bug.cgi?id=98113

        Reviewed by Maciej Stachowiak.

        Nuke the performImport() IconDatabaseClient method.

        * WebCoreSupport/IconDatabaseClientBlackBerry.cpp:
        * WebCoreSupport/IconDatabaseClientBlackBerry.h:
        (IconDatabaseClientBlackBerry):

614 615 616 617 618 619 620 621 622 623 624 625 626 627
2012-10-01  Jakob Petsovits  <jpetsovits@rim.com>

        [BlackBerry] Remove unused hasPendingScrollOrZoomEvent() interface.
        https://bugs.webkit.org/show_bug.cgi?id=98107
        RIM PR 173292

        Reviewed by George Staikos.

        This method is not referenced anywhere anymore,
        so we should stop requiring it from WebPageClient
        implementations.

        * Api/WebPageClient.h:

628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643
2012-10-01  Mike Fenton  <mifenton@rim.com>

        [BlackBerry] Remove suppressing of VKB hiding when processing changes.
        https://bugs.webkit.org/show_bug.cgi?id=98023

        Reviewed by Rob Buis.

        PR 215881.

        Allow JS to blur the input field while processing key handling.

        Reviewed Internally by Chris Hutten-Czapski

        * WebKitSupport/InputHandler.cpp:
        (BlackBerry::WebKit::InputHandler::notifyClientOfKeyboardVisibilityChange):

644 645 646 647 648 649 650 651 652 653 654 655 656 657 658
2012-09-28  Konrad Piascik  <kpiascik@rim.com>

        [BlackBerry] Update the value of window.devicePixelRation when it is set programmatically
        https://bugs.webkit.org/show_bug.cgi?id=97512

        Reviewed by Rob Buis.

        RIM PR 213984
        Set the deviceScaleFactor of the page explicity when the
        devicePixelRatio is changed.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
        (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):

659 660 661 662 663 664 665 666 667 668 669 670 671
2012-09-28  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>

        Code inside FrameLoaderClient::canShowMIMEType() implementations can be shared among different WK ports
        https://bugs.webkit.org/show_bug.cgi?id=97547

        Reviewed by Adam Barth.

        Newly added WebCore::MIMETypeRegistry::canShowMIMEType() function is used
        inside WebCore::FrameLoaderClientBlackBerry::canShowMIMEType().

        * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
        (WebCore::FrameLoaderClientBlackBerry::canShowMIMEType):

672 673 674 675 676 677 678 679 680 681 682 683 684
2012-09-28  Rob Buis  <rbuis@rim.com>

        [BlackBerry] Hard to tap on x to clear a text field
        https://bugs.webkit.org/show_bug.cgi?id=97923

        Reviewed by Antonio Gomes.

        Allow the shadow element for 'X' to be clickable and do not prefer
        shadow content-editable div's over the 'X'.

        * WebKitSupport/FatFingers.cpp:
        (BlackBerry::WebKit::FatFingers::isElementClickable):

685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719
2012-09-28  Antonio Gomes  <agomes@rim.com>

        [BlackBerry] Extend composited  in-region scrolling to iframes/frames
        https://bugs.webkit.org/show_bug.cgi?id=97922
        PR #197093

        Reviewed by Yong Li.
        Internaly reviewed by Arvid Nilsson.

        Add support for composited scrolling in a inner frame level:

        1) When creating an InRegionScrollableArea, for a inner scrollable frame,
        cache and camouflag the appropriated scroll layer (i.e. RenderLayerCompositor::scrollLayer);

        2) Differentiate what type of scroll target we are at: BlockElement or
        InnerFrame;

        3) Change the signature of the public methods to support and newly passed
        in ScrollTarget parameter;
        As a side note, this parameter is needed in order to know what class to static_cast
        the GraphicsLayer::client to: in the case of a composited scrollable inner frame, the client
        is a RenderLayerCompositor; in case of a composited scrollable block element, the client
        is a RenderLayerBacking.

        * Api/InRegionScroller.cpp:
        (BlackBerry::WebKit::InRegionScroller::setScrollPositionWebKitThread):
        (BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionWebKitThread):
        * Api/InRegionScroller.h:
        * Api/InRegionScroller_p.h:
        (InRegionScrollerPrivate):
        * WebCoreSupport/ChromeClientBlackBerry.h:
        (WebCore::ChromeClientBlackBerry::allowedCompositingTriggers):
        * WebKitSupport/InRegionScrollableArea.cpp:
        (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):

720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743
2012-09-28  Antonio Gomes  <agomes@rim.com>

        [BlackBerry] Exiting fullscreen does not set the correct scroll position
        https://bugs.webkit.org/show_bug.cgi?id=97917
        PR #212920

        Reviewed by Yong Li.
        Internally reviewed by Jacky Jiang.

        Restore the zoom level and scroll position at the time when know
        the fullscreen exit routine has ended (i.e. in ::setViewportSize
        instead of ::exitFullScreenForElement).

        Also patch caches now the scroll position instead of only the
        "x scroll position.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
        (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
        (BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
        (BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):
        * Api/WebPage_p.h:
        (WebPagePrivate):

744 745 746 747 748 749 750 751 752 753 754 755 756 757
2012-09-28  Kent Tamura  <tkent@chromium.org>

        Clean up Localizer-related functions
        https://bugs.webkit.org/show_bug.cgi?id=97899

        Reviewed by Kentaro Hara.

        * WebCoreSupport/ColorPickerClient.cpp:
        (WebCore::ColorPickerClient::localizer): Follow Document::getLocalizer renaming.
        * WebCoreSupport/DatePickerClient.cpp:
        (WebCore::SelectPopupClient::localizer): ditto.
        * WebCoreSupport/SelectPopupClient.cpp:
        (WebCore::SelectPopupClient::localizer): ditto.

758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776
2012-09-28  Genevieve Mak  <gmak@rim.com>

        [BLACKBERRY] Add isVisible method to WebTapHighlight
        https://bugs.webkit.org/show_bug.cgi?id=97915

        Reviewed by Rob Buis.

        Reviewed Internally By Andrew Lo
        The isVisible() method lets us avoid dispatching to the webkit thread
        if the tap highlight isn't visible.
        Always clear tap highlight on Touch up when converting Touch Events
        to Mouse Events.

        * Api/WebTapHighlight.h:
        * WebKitSupport/DefaultTapHighlight.h:
        (BlackBerry::WebKit::DefaultTapHighlight::isVisible):
        * WebKitSupport/TouchEventHandler.cpp:
        (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):

777 778 779 780 781 782 783 784 785 786 787 788 789
2012-09-28  Andrew Lo  <anlo@rim.com>

        [BlackBerry] Should suspend page's scripted animations when WebPage is invisible
        https://bugs.webkit.org/show_bug.cgi?id=97856

        Reviewed by Antonio Gomes.

        Suspend page animations when setting WebPage invisible, resume when visible.
        Internal PR212788.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::setVisible):

790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817
2012-09-28  Arvid Nilsson  <anilsson@rim.com>

        [BlackBerry] Destroy thread-specific data for Platform::Graphics::Buffer on the right thread
        https://bugs.webkit.org/show_bug.cgi?id=97674

        Reviewed by Rob Buis.

        A new API was added to BlackBerry::Platform::Graphics for destroying
        thread-specific data generated on the compositing thread when we blit
        buffers. The buffers are otherwise created and destroyed on the WebKit
        thread, which doesn't give platform any opportunity to destroy the
        thread-specific data.

        This patch adds calls to the new API to avoid leaking resources.

        Reviewed internally by Jakob Petsovits and Filip Spacek.

        PR 214644

        * WebKitSupport/SurfacePool.cpp:
        (BlackBerry::WebKit::SurfacePool::initialize):
        (BlackBerry::WebKit::SurfacePool::createPlatformGraphicsContext):
        (BlackBerry::WebKit::SurfacePool::lockTileRenderingSurface):
        (BlackBerry::WebKit::SurfacePool::releaseTileRenderingSurface):
        (BlackBerry::WebKit::SurfacePool::initializeVisibleTileBuffer):
        (BlackBerry::WebKit::SurfacePool::createBuffers):
        (BlackBerry::WebKit::SurfacePool::releaseBuffers):

818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841
2012-09-27  Kent Tamura  <tkent@chromium.org>

        Use Localizer in PagePopupController
        https://bugs.webkit.org/show_bug.cgi?id=97862

        Reviewed by Hajime Morita.

        We need to implement PagePopupClient::localizer. These clients know the
        host elements. Localizer implementations get Localizer objects from the
        owner documents of the elements for the browser locale.

        * WebCoreSupport/ColorPickerClient.cpp:
        (WebCore::ColorPickerClient::localizer): Added.
        * WebCoreSupport/ColorPickerClient.h:
        (ColorPickerClient): Declare "localizer."
        * WebCoreSupport/DatePickerClient.cpp:
        (WebCore::SelectPopupClient::localizer): Added.
        * WebCoreSupport/DatePickerClient.h:
        (DatePickerClient): Declare "localizer."
        * WebCoreSupport/SelectPopupClient.cpp:
        (WebCore::SelectPopupClient::localizer): Added.
        * WebCoreSupport/SelectPopupClient.h:
        (SelectPopupClient): Declare "localizer."

842 843 844 845 846 847 848 849 850 851 852 853 854
2012-09-27  Charles Wei  <charles.wei@torchmobile.com.cn>

        Empty URL gets through to acceptNavigationRequest()
        https://bugs.webkit.org/show_bug.cgi?id=97076

        Reviewed by George Staikos.

        Invalid URLs in iframe src results in an empty URL in platform request, we should reject
        such URL as early as we identify it.

        * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
        (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNavigationAction):

855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878
2012-09-26  Jakob Petsovits  <jpetsovits@rim.com>

        [BlackBerry] Remove blitContents() in favor of blitVisibleContents().
        https://bugs.webkit.org/show_bug.cgi?id=97718

        Reviewed by Antonio Gomes.

        After the last calling sites of blitContents() have
        been removed or reworked, the actual method itself
        can now retire. All blits now go through
        blitVisibleContents(). The knowledge that we always
        blit the full visible surface can facilitate further
        optimizations; we will get to that in time.

        * Api/BackingStore.cpp:
        (BlackBerry::WebKit::BackingStorePrivate::suspendScreenAndBackingStoreUpdates):
        (BlackBerry::WebKit::BackingStorePrivate::resumeScreenAndBackingStoreUpdates):
        (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
        * Api/BackingStore.h:
        * Api/BackingStore_p.h:
        (BackingStorePrivate):
        * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
        (WebCore::FrameLoaderClientBlackBerry::transitionToCommittedForNewPage):

879 880 881 882 883 884 885 886 887 888 889 890 891 892 893
2012-09-26  Mike Fenton  <mifenton@rim.com>

        [BlackBerry] Update padding in ensureFocusTextElementVisible to be DPI independent.
        https://bugs.webkit.org/show_bug.cgi?id=97684

        Reviewed by Rob Buis.

        Update padding in ensureFocusTextElementVisible to be DPI
        independent and relative to the current zoom level.

        Reviewed Internally by Gen Mak.

        * WebKitSupport/InputHandler.cpp:
        (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):

894 895 896 897 898 899 900 901 902 903 904 905 906 907 908
2012-09-25  Genevieve Mak  <gmak@rim.com>

        Fat Fingers doesn't work on non-scrollable pages.
        PR #209609
        https://bugs.webkit.org/show_bug.cgi?id=97607

        Reviewed by Antonio Gomes.

        Only bypass Fat Fingers and use the actual touch point if its specifically
        requested and the page has a mouse move listener or if using the Touch Event
        Mode meta-tag.

        * WebKitSupport/TouchEventHandler.cpp:
        (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):

909 910 911 912 913 914 915 916 917 918 919 920
2012-09-25  Rob Buis  <rbuis@rim.com>

        [BlackBerry] Make COMPUTED_GOTO part of the HAVE section
        https://bugs.webkit.org/show_bug.cgi?id=97600

        Reviewed by Yong Li.

        Also get rid of COMPUTED_GOTO_INTERPRETER and add COMPUTED_GOTO_OPCODES.

        * WebCoreSupport/AboutDataEnableFeatures.in:
        * WebCoreSupport/AboutDataHaveFeatures.in:

921 922 923 924 925 926 927 928 929 930 931 932 933 934 935
2012-09-25  Mike Fenton  <mifenton@rim.com>

        [BlackBerry] Suspend the backingstore while adjusting the view on input field focus.
        https://bugs.webkit.org/show_bug.cgi?id=97595

        Reviewed by Antonio Gomes.

        PR 188751.

        Avoid jumpiness when both a scroll and zoom are required to
        move an input field into focus by suspending the backingstore.

        * WebKitSupport/InputHandler.cpp:
        (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):

936 937 938 939 940 941 942 943 944 945
2012-09-25  Pratik Solanki  <psolanki@apple.com>

        Remove HAVE_SBRK since we never set use_sbrk to true
        https://bugs.webkit.org/show_bug.cgi?id=97525
        <rdar://problem/12363601>

        Reviewed by Geoffrey Garen.

        * WebCoreSupport/AboutDataHaveFeatures.in: Remove SBRK from list.

946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969
2012-09-25  Beth Dakin  <bdakin@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=95397
        Need to merge didFirstVisuallyNonEmptyLayout and 
        didNewFirstVisuallyNonEmptyLayout
        -and corresponding-
        <rdar://problem/10791680>

        Reviewed by Sam Weinig.

        Remove dispatchDidFirstLayout, 
        dispatchDidFirstVisuallyNonEmptyLayout, and 
        dispatchDidNewFirstVisuallyNonEmptyLayout. Their functionality 
        is now replaced by dispatchDidLayout(LayoutMilestoneOptions)
        * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
        (WebCore::FrameLoaderClientBlackBerry::dispatchDidLayout):
        * WebCoreSupport/FrameLoaderClientBlackBerry.h:
        (FrameLoaderClientBlackBerry):

        It is now necessary to opt into getting any of the 
        "layout milestone" notifications.
        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::init):

970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985
2012-09-25  Mike Fenton  <mifenton@rim.com>

        [BlackBerry] When zooming into an input field take the current zoom level into account.
        https://bugs.webkit.org/show_bug.cgi?id=97594

        Reviewed by Antonio Gomes.

        PR 188751.

        Perform the zoom action prior to scroll to avoid breaking scrolling
        rules.  Take the current scale into account when calculating the
        zoom factor.

        * WebKitSupport/InputHandler.cpp:
        (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):

986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010
2012-09-25  Nima Ghanavatian  <nghanavatian@rim.com>

        [BlackBerry] Handling required for multiple consecutive whitespace
        https://bugs.webkit.org/show_bug.cgi?id=97575

        Reviewed by Rob Buis.

        PR211670
        Need specific handling in the case where we have multiple
        consecutive whitespaces which exceeds our character limit. This
        breaks some of the functionality employed with the visible_units
        methods used here to tranverse the text.

        Internally reviewed by Mike Fenton.

        * WebKitSupport/DOMSupport.cpp:
        (BlackBerry::WebKit::DOMSupport::trimWhitespaceFromRange):
        (DOMSupport):
        (BlackBerry::WebKit::DOMSupport::isEmptyRangeOrAllSpaces):
        * WebKitSupport/DOMSupport.h:
        (WebCore):
        * WebKitSupport/InputHandler.cpp:
        (BlackBerry::WebKit::InputHandler::spellCheckBlock):
        (BlackBerry::WebKit::InputHandler::getRangeForSpellCheckWithFineGranularity):

1011 1012 1013 1014 1015 1016 1017 1018 1019
2012-09-24  Mark Lam  <mark.lam@apple.com>

        Deleting the classic interpreter and cleaning up some build options.
        https://bugs.webkit.org/show_bug.cgi?id=96969.

        Reviewed by Geoffrey Garen.

        * WebCoreSupport/AboutDataEnableFeatures.in:

1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031
2012-09-24  Benjamin Poulain  <bpoulain@apple.com>

        Fix Geolocation error reporting in the test support
        https://bugs.webkit.org/show_bug.cgi?id=97386

        Reviewed by Sam Weinig.

        * WebKitSupport/DumpRenderTreeSupport.cpp:
        (DumpRenderTreeSupport::setMockGeolocationPositionUnavailableError):
        * WebKitSupport/DumpRenderTreeSupport.h:
        (DumpRenderTreeSupport):

1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054
2012-09-24  Otto Derek Cheung  <otcheung@rim.com>

        [BlackBerry] Reverting implementation for 407 error pages
        https://bugs.webkit.org/show_bug.cgi?id=97455

        Reviewed by Rob Buis.

        Revert "[BlackBerry] Really fix bug 95488 that user can get the 
        authentication challenge dialog while the other tab has focus."
        https://bugs.webkit.org/show_bug.cgi?id=97348

        This reverts commit 0cffe01961fb80204138505bcec29a83818efb73.

        * Api/BlackBerryGlobal.cpp:
        (BlackBerry::WebKit::globalInitialize):
        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
        (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
        (BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
        (BlackBerry::WebKit::WebPage::setVisible):
        * Api/WebPage_p.h:
        (WebPagePrivate):

1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095
2012-09-24  Arvid Nilsson  <anilsson@rim.com>

        [BlackBerry] Add cookie database API
        https://bugs.webkit.org/show_bug.cgi?id=97102

        Reviewed by Antonio Gomes.

        The cookie database is exposed through WebCookieJar, which has only two
        methods: cookies() and setCookies().

        Also add a new WebString::fromUTF8 overload that takes a const char*
        and a length, in order to avoid a strlen call when converting from
        other string classes to WebString. This is useful for callers of the
        new cookie API when converting cookies to WebString.

        Reviewed internally by Otto D. Cheung.

        PR 209282

        * Api/WebCookieJar.cpp: Added.
        (WebKit):
        (BlackBerry::WebKit::WebCookieJar::WebCookieJar):
        (BlackBerry::WebKit::WebCookieJar::cookies):
        (BlackBerry::WebKit::WebCookieJar::setCookies):
        * Api/WebCookieJar.h: Added.
        (WebKit):
        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
        (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
        (BlackBerry::WebKit::WebPage::cookieJar):
        (WebKit):
        * Api/WebPage.h:
        (WebKit):
        * Api/WebPage_p.h:
        (WebKit):
        (WebPagePrivate):
        * Api/WebString.cpp:
        (BlackBerry::WebKit::WebString::fromUtf8):
        (WebKit):
        * Api/WebString.h:

1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119
2012-09-21  Lianghui Chen  <liachen@rim.com>

        [BlackBerry] Really fix bug 95488 that user can get the authentication challenge dialog while the other tab has focus.
        https://bugs.webkit.org/show_bug.cgi?id=97348
        Internal PR: 186597.

        Internally reviewed by Yong Li, Joe Mason.
        Reviewed by Yong Li.

        Update WebPage to use new AuthenticationChallengeManager.
        Register page creation/deletion and visibility change to the new
            AuthenticationChallengeManager.
        Initialize AuthenticationChallengeManager in GlobalInitialize() function.

        * Api/BlackBerryGlobal.cpp:
        (BlackBerry::WebKit::globalInitialize):
        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
        (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
        (BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
        (BlackBerry::WebKit::WebPage::setVisible):
        * Api/WebPage_p.h:
        (WebPagePrivate):

1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131
2012-09-21  Charles Wei  <charles.wei@torchmobile.com.cn>

        Wrong seperator for viewport meta in Popup scripts
        https://bugs.webkit.org/show_bug.cgi?id=97313

        Reviewed by Yong Li.

        The valid seperator for viewport meta is ',' instead of ';'.

        * WebCoreSupport/PagePopupBlackBerry.cpp:
        (WebCore::PagePopupBlackBerry::generateHTML):

1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176
2012-09-21  Arvid Nilsson  <anilsson@rim.com>

        [BlackBerry] Remove obsolete compositing surface code
        https://bugs.webkit.org/show_bug.cgi?id=97314

        Reviewed by Antonio Gomes.

        The removed code allowed rendering of sublayers to a separate offscreen
        surface.

        Now that we composite root layer and all sublayers to the window
        surface, this code is not needed anymore. In addition, we save some
        memory by not allocating the unused offscreen surface.

        PR 208038.

        * Api/BackingStore.cpp:
        (BlackBerry::WebKit::BackingStorePrivate::suspendScreenAndBackingStoreUpdates):
        (BlackBerry::WebKit::BackingStorePrivate::blitContents):
        (BlackBerry::WebKit::BackingStorePrivate::drawAndBlendLayersForDirectRendering):
        * Api/BackingStore_p.h:
        (BackingStorePrivate):
        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::setLoadState):
        (BlackBerry::WebKit::WebPagePrivate::suspendBackingStore):
        (BlackBerry::WebKit::WebPagePrivate::resizeSurfaceIfNeeded):
        (BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
        (BlackBerry::WebKit::WebPagePrivate::setRootLayerCompositingThread):
        * Api/WebPage_p.h:
        (WebPagePrivate):
        * WebKitSupport/BackingStoreCompositingSurface.cpp: Removed.
        * WebKitSupport/BackingStoreCompositingSurface.h: Removed.
        * WebKitSupport/GLES2Context.cpp:
        (BlackBerry::WebKit::GLES2Context::buffer):
        (BlackBerry::WebKit::GLES2Context::surfaceSize):
        (BlackBerry::WebKit::GLES2Context::swapBuffers):
        * WebKitSupport/GLES2Context.h:
        (GLES2Context):
        * WebKitSupport/SurfacePool.cpp:
        (WebKit):
        (BlackBerry::WebKit::SurfacePool::SurfacePool):
        (BlackBerry::WebKit::SurfacePool::initialize):
        * WebKitSupport/SurfacePool.h:
        (SurfacePool):

1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193
2012-09-20  Peter Wang  <peter.wang@torchmobile.com.cn>

        [BlackBerry] To support "Frames View" of "TimeLine" panel  in Inspector
        https://bugs.webkit.org/show_bug.cgi?id=96077

        Reviewed by Pavel Feldman.

        A minor modification to make the inspecting results more accurate.
        Internally reviewd by Arvid, Robin.C, and Konrad.

        * Api/BackingStore.cpp:
        (BlackBerry::WebKit::BackingStorePrivate::renderJob):
        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
        * WebKitSupport/RenderQueue.cpp:
        (BlackBerry::WebKit::RenderQueue::render):

1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209
2012-09-19  Sean Wang  <Xuewen.Wang@torchmobile.com.cn>

        [BlackBerry] Basic authentication challenge credentials for stored credentials again after restarting browser
        https://bugs.webkit.org/show_bug.cgi?id=96362

        Reviewed by Rob Buis.

        Make the FrameLoaderClient use credential storage according to the macro
        BLACKBERRY_CREDENTIAL_PERSIST

        * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
        (WebCore::FrameLoaderClientBlackBerry::shouldUseCredentialStorage):
        (WebCore):
        * WebCoreSupport/FrameLoaderClientBlackBerry.h:
        (FrameLoaderClientBlackBerry):

1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227
2012-09-19  Mike Fenton  <mifenton@rim.com>

        [BlackBerry] After zooming into an input field, zoom out when focus is lost.
        https://bugs.webkit.org/show_bug.cgi?id=97128

        Reviewed by Rob Buis.

        When the page has automatically zoomed in for input
        focus, unzoom it when input focus is lost or keyboard hidden.

        Reviewed Internally by Gen Mak.

        * WebKitSupport/InputHandler.cpp:
        (BlackBerry::WebKit::InputHandler::InputHandler):
        (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
        * WebKitSupport/InputHandler.h:
        (InputHandler):

1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240
2012-09-19  Nima Ghanavatian  <nghanavatian@rim.com>

        [BlackBerry] Clean up the SpellingLog output
        https://bugs.webkit.org/show_bug.cgi?id=97129

        Reviewed by Rob Buis.

        Internally reviewed by Mike Fenton.

        * WebKitSupport/InputHandler.cpp:
        (BlackBerry::WebKit::InputHandler::spellCheckingRequestCancelled):
        (BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):

1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255
2012-09-19  Mike Fenton  <mifenton@rim.com>

        [BlackBerry] Add SpellingLog for spell checking options request.
        https://bugs.webkit.org/show_bug.cgi?id=97125

        Reviewed by Rob Buis.

        Add spell checking log to indicate the calculated
        text position for spell checking option requests.

        Reviewed Internally by Nima Ghanavatian.

        * WebKitSupport/InputHandler.cpp:
        (BlackBerry::WebKit::InputHandler::shouldRequestSpellCheckingOptionsForPoint):

1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275
2012-09-19  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>

        [BlackBerry] Add function playerId() in class PageClientBlackBerry
        https://bugs.webkit.org/show_bug.cgi?id=97099

        Reviewed by Yong Li.

        Implemented PageClientBlackBerry::playerID() in class WebPagePrivate,
        and replaced the implementation of FrameLoaderClientBlackBerry::playerId().

        Internally reviewed by Charles Wei.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::playerID):
        (WebKit):
        * Api/WebPage_p.h:
        (WebPagePrivate):
        * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
        (WebCore::FrameLoaderClientBlackBerry::playerId):

1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292
2012-09-19  Abbas Sherawala  <asherawala@rim.com>

        [BlackBerry] BackingStorePrivate::resumeScreenAndBackingStoreUpdates more atomic
        Added a missing 'if' statement.
        https://bugs.webkit.org/show_bug.cgi?id=96925

        PR #180866

        Internally Reviewed by Antonio Gomes.

        Adding an 'if' statement which should have been in PR # 180866 (SHA:b9c06af395c22e)

        Reviewed by Antonio Gomes.

        * Api/BackingStore.cpp:
        (BlackBerry::WebKit::BackingStorePrivate::resumeScreenAndBackingStoreUpdates):

1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317
2012-09-18  Nima Ghanavatian  <nghanavatian@rim.com>

        [BlackBerry] Use didCancel and didSucceed instead of didCheckCancel and didCheckSucceed
        https://bugs.webkit.org/show_bug.cgi?id=97033

        Reviewed by Rob Buis.

        Using these preferred public methods (the latter has a note to be made private) ensures that
        the right SpellChecker object is being called during the callback in spellCheckingRequestProcessed
        and spellCheckingRequestCancelled.

        Internally reviewed by Mike Fenton.

        By referencing the TextCheckingRequest object's methods, we don't need to keep track of the associated
        SpellChecker for each request. Removing much of the code that was put in place incorrectly to achieve this.

        * WebKitSupport/InputHandler.cpp:
        (BlackBerry::WebKit::InputHandler::InputHandler):
        (BlackBerry::WebKit::InputHandler::requestCheckingOfString):
        (BlackBerry::WebKit::InputHandler::spellCheckingRequestCancelled):
        (BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
        (BlackBerry::WebKit::InputHandler::getSpellChecker):
        * WebKitSupport/InputHandler.h:
        (InputHandler):

1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331
2012-09-18  Jessica Cao  <jecao@rim.com>

        [BlackBerry] Date picker isn't inputting after 'OK'
        https://bugs.webkit.org/show_bug.cgi?id=97031

        PR208052

        Reviewed by Rob Buis

        Checking for !values.contains("-1") will match valid strings like "2012-09-18". Use value != "-1" instead.

        * WebCoreSupport/DatePickerClient.cpp:
        (WebCore::DatePickerClient::setValueAndClosePopup):

1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360
2012-09-18  Yong Li  <yoli@rim.com>

        [BlackBerry] Popup page should reference the client with a weak pointer
        https://bugs.webkit.org/show_bug.cgi?id=97028

        Reviewed by Rob Buis.

        RIM PR# 209847.
        Internally reviewed by Mike Fenton.

        Store the pointer in a ref-coutned shared object, and clear the pointer 
        when the client is going to be destroyed, so it won't be accessed by
        the JS function afterwards.

        * WebCoreSupport/PagePopupBlackBerry.cpp:
        (WebCore::PagePopupBlackBerry::PagePopupBlackBerry):
        (WebCore::PagePopupBlackBerry::~PagePopupBlackBerry):
        (WebCore::PagePopupBlackBerry::init):
        (WebCore::setValueAndClosePopupCallback):
        (WebCore::popUpExtensionFinalize):
        (WebCore::PagePopupBlackBerry::installDOMFunction):
        (WebCore::PagePopupBlackBerry::closePopup):
        * WebCoreSupport/PagePopupBlackBerry.h:
        (PagePopupBlackBerry):
        (SharedClientPointer):
        (WebCore::PagePopupBlackBerry::SharedClientPointer::SharedClientPointer):
        (WebCore::PagePopupBlackBerry::SharedClientPointer::clear):
        (WebCore::PagePopupBlackBerry::SharedClientPointer::get):

1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384
2012-09-18  Arvid Nilsson  <anilsson@rim.com>

        [BlackBerry] Prevent scroll adjustment of input fields when region of interest mechanism active
        https://bugs.webkit.org/show_bug.cgi?id=96750

        Reviewed by Antonio Gomes.

        The region of interest mechanism replaces the scrolling/zooming
        functionality in InputHandler::ensureFocusTextElementVisible().

        We introduce a new fine-grained setting for the various adjustment
        modes. The WebKit embedder can disable all scroll types in favor of the
        region of interest mechanism by using the new setting.

        PR #208387

        Reviewed internally by Mike Fenton.

        * WebKitSupport/AboutData.cpp:
        (BlackBerry::WebKit::configPage):
        * WebKitSupport/InputHandler.cpp:
        (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
        * WebKitSupport/InputHandler.h:

1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412
2012-09-17  Jakob Petsovits  <jpetsovits@rim.com>

        [BlackBerry] Remove dysfunctional zoom blit in setViewportSize().
        https://bugs.webkit.org/show_bug.cgi?id=96954
        PR 178411

        Reviewed by Antonio Gomes.

        The blitContents() call removed by this patch used to
        be part of scheduleZoomAboutPoint(). Its goal was to
        display a preview of the zoomed contents, primarily
        when auto-zoomed after rotation. Nested inside a pair
        of screen suspend/resume calls, it has been a pointless
        no-op for a while.

        Antonio's recent change to remove scheduleZoomAboutPoint()
        and call zoomAboutPoint() from setViewportSize() directly
        (the only call site) obsoletes the call completely.
        The zoomAboutPoint() call itself will cause a re-render
        and blit right away, so we don't care about any preview.
        zoomAboutPoint() will also take care of the necessary
        screen/backingstore suspension.

        The result is a vastly simplified block of code.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::setViewportSize):

1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432
2012-09-17  Antonio Gomes  <agomes@rim.com>

        [BlackBerry] [FullScreen] entering/leaving fullscreen results in temporary glitches on the screen
        https://bugs.webkit.org/show_bug.cgi?id=96927
        PR #180866

        Reviewed by Yong Li.

        Suspend backing store and screen updates while entering fullscreen,
        and only resume at the end, when viewport is resized.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
        (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
        * Api/WebPage_p.h:
        (WebPagePrivate):
        * WebCoreSupport/ChromeClientBlackBerry.cpp:
        (WebCore::ChromeClientBlackBerry::enterFullScreenForElement):
        (WebCore::ChromeClientBlackBerry::exitFullScreenForElement):

1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458
2012-09-17  Rob Buis  <rbuis@rim.com>

        [BlackBerry] Fix compile problems in WebKit/blackberry
        https://bugs.webkit.org/show_bug.cgi?id=96926

        Reviewed by Antonio Gomes.

        This code is slightly out of date and so will not compile, fix it.

        * WebCoreSupport/BatteryClientBlackBerry.cpp:
        (WebCore::BatteryClientBlackBerry::BatteryClientBlackBerry):
        * WebCoreSupport/BatteryClientBlackBerry.h:
        (WebKit):
        * WebCoreSupport/CredentialTransformData.h:
        * WebCoreSupport/DeviceOrientationClientBlackBerry.cpp:
        (DeviceOrientationClientBlackBerry::onOrientation):
        * WebCoreSupport/InspectorClientBlackBerry.h:
        * WebCoreSupport/PagePopupBlackBerry.cpp:
        * WebKitSupport/DOMSupport.cpp:
        (BlackBerry::WebKit::DOMSupport::isDateTimeInputField):
        (BlackBerry::WebKit::DOMSupport::isTextBasedContentEditableElement):
        * WebKitSupport/DumpRenderTreeSupport.cpp:
        (DumpRenderTreeSupport::numberOfPendingGeolocationPermissionRequests):
        * WebKitSupport/InPageSearchManager.cpp:
        (BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):

1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480
2012-09-17  Antonio Gomes  <agomes@rim.com>

        [BlackBerry] BackingStorePrivate::resumeScreenAndBackingStoreUpdates more atomic
        https://bugs.webkit.org/show_bug.cgi?id=96925

        [FullScreen] entering/leaving fullscreen results in temporary glitches on the screen (part 2/3)
        PR #180866

        Reviewed by Rob Buis.
        Internally reviewed by Arvid Nilsson.

        Paraphrasing Arvid "resumeBackingStore will be a truly atomic operation.
        Well more atomic than it was before, with regards to a mix of accelerated and
        non-accelerated compositing content".

        I.e. by committing the root layer (if needed) when resuming the Backing
        Store, we call blitVisibleContents right way, so we are actually shortcutting when
        AC content will get on screen.

        * Api/BackingStore.cpp:
        (BlackBerry::WebKit::BackingStorePrivate::resumeScreenAndBackingStoreUpdates):

1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498
2012-09-17  Peter Wang  <peter.wang@torchmobile.com.cn>

        [BlackBerry] To support "Frames View" of "TimeLine" panel in Inspector
        https://bugs.webkit.org/show_bug.cgi?id=96077

        Reviewed by Rob Buis.

        Invoke the "instrumentBeginFrame" and "instrumentCancelFrame" at the start and end of processing
        render message to record one time of page's update.

        * Api/BackingStore.cpp:
        (BlackBerry::WebKit::BackingStorePrivate::instrumentBeginFrame):
        (WebKit):
        (BlackBerry::WebKit::BackingStorePrivate::instrumentCancelFrame):
        * Api/BackingStore_p.h:
        * WebKitSupport/RenderQueue.cpp:
        (BlackBerry::WebKit::RenderQueue::render):

1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548
2012-09-17  Jakob Petsovits  <jpetsovits@rim.com>

        [BlackBerry] Support copying image data in WebOverlay.
        https://bugs.webkit.org/show_bug.cgi?id=96684
        RIM PR 195444

        Reviewed by Rob Buis.
        Internally reviewed by Arvid Nilsson.

        The publicly exposed WebOverlay class provides a method
        setContentsToImage() to assign a pointer to pixel data,
        which is later used to provide texture data for the
        underlying compositing layer. This works well for static
        images that stay in memory and never change, but not
        so well for images with changing contents or where the
        image data is being reassigned from different image
        sources that are not constantly kept around in memory.

        Due to the delayed upload and delayed fetching of
        EGLImage data by the GPU, we shouldn't assume the caller
        to know how long the image should be retained. Instead,
        we should offer another method of setting image data
        that takes ownership of the pixel data.

        This patch adds an option to setContentsToImage() that
        copies the passed pixel data and doesn't destroy it
        until both the texture is destroyed and the image
        contents are changed. Using this method, the caller can
        withdraw the passed pixel array right after the
        setContentsToImage() call without consequences.

        * Api/WebOverlay.cpp:
        (BlackBerry::WebKit::WebOverlay::setContentsToImage):
        (BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setContentsToImage):
        (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::WebOverlayLayerCompositingThreadClient):
        (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::invalidate):
        (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setContents):
        (WebKit):
        (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::clearUploadedContents):
        (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setContentsToColor):
        (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):
        (BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::deleteTextures):
        (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setContentsToImage):
        * Api/WebOverlay.h:
        * Api/WebOverlay_p.h:
        (WebOverlayPrivate):
        (WebOverlayPrivateWebKitThread):
        (WebOverlayLayerCompositingThreadClient):
        (WebOverlayPrivateCompositingThread):

1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559
2012-09-14  Dana Jansens  <danakj@chromium.org>

        Minimize collisions when hashing pairs
        https://bugs.webkit.org/show_bug.cgi?id=96022

        Reviewed by Adrienne Walker.

        Use WTF::pairIntHash() to hash a pair of integers.

        * WebKitSupport/TileIndexHash.h:

1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573
2012-09-14  Genevieve Mak  <gmak@rim.com>

        Always send mouse events on pages that don't scroll even if there
        is no mouse move listener attatched.
        PR #208228
        https://bugs.webkit.org/show_bug.cgi?id=96800

        Reviewed by Antonio Gomes.

        Reviewed Internally By Antonio Gomes.

        * WebKitSupport/TouchEventHandler.cpp:
        (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):

1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589
2012-09-14  Mike Fenton  <mifenton@rim.com>

        [BlackBerry] Update the minimum zoom scale when focusing an input field.
        https://bugs.webkit.org/show_bug.cgi?id=96789

        Reviewed by Antonio Gomes.

        PR 188751.

        Increase the minimum font fix and base it on mm instead of pixels.

        Reviewed Internally by Gen Mak.

        * WebKitSupport/InputHandler.cpp:
        (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):

1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621
2012-09-13  Antonio Gomes  <agomes@rim.com>

        [BlackBerry]  Remove the ability to schedule a zoom about point call.
        https://bugs.webkit.org/show_bug.cgi?id=96696

        [FullScreen] entering/leaving fullscreen results in temporary glitches on the screen (Part I)
        PR #180866

        Reviewed by Rob Buis.

        Internally reviewed by Jacky Jiang and Arvid Nilsson.

        Patch replaces the async call to zoomAboutPoint (via scheduling it with a one-shot-0-timer).
        Instead, at its single call site, we inline most of the previous scheduleZoomAboutPoint code,
        and in the end call zoomAboutPoint directly.

        Change was estimulated by Arvid's comment on PRzilla: "There is no longer any reason to have
        zoom about point be async.. That was a hack I did for BB6, back when we were doing everything on the WK
        thread and needed manual time slicing betwren rendering and user interaction."

        The bigger goal though is to be able to remove screen glitches while entering/leaving
        fullscreen mode: since we could accurately use the count-based suspend/resume backing
        store mechanism to prevent it.

        * Api/WebPage.cpp:
        (WebKit):
        (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
        (BlackBerry::WebKit::WebPagePrivate::setLoadState):
        (BlackBerry::WebKit::WebPagePrivate::setViewportSize):
        * Api/WebPage_p.h:
        (WebPagePrivate):

1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637
2012-09-14  Arvid Nilsson  <anilsson@rim.com>

        [BlackBerry] Add renderTreeAsText API to WebPage
        https://bugs.webkit.org/show_bug.cgi?id=96629

        Reviewed by Antonio Gomes.

        This will be used for automated testing.

        PR #198595

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPage::renderTreeAsText):
        (WebKit):
        * Api/WebPage.h:

1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648
2012-09-13  Rob Buis  <rbuis@rim.com>

        [BlackBerry] Cleanup AboutDataEnableFeatures.in
        https://bugs.webkit.org/show_bug.cgi?id=96695

        Reviewed by Antonio Gomes.

        Remove unused features.

        * WebCoreSupport/AboutDataEnableFeatures.in:

1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677
2012-09-13  Rob Buis  <rbuis@rim.com>

        [BlackBerry] Rename InspectorOverlay in blackberry/WebKitSupport
        https://bugs.webkit.org/show_bug.cgi?id=96689

        Reviewed by Antonio Gomes.

        Rename to InspectorClientBlackBerry to avoid include problems.

        * WebCoreSupport/InspectorClientBlackBerry.h:
        * WebKitSupport/InspectorOverlayBlackBerry.cpp: Renamed from Source/WebKit/blackberry/WebKitSupport/InspectorOverlay.cpp.
        (WebKit):
        (BlackBerry::WebKit::InspectorOverlay::create):
        (BlackBerry::WebKit::InspectorOverlay::InspectorOverlay):
        (BlackBerry::WebKit::InspectorOverlay::notifySyncRequired):
        (BlackBerry::WebKit::InspectorOverlay::paintContents):
        (BlackBerry::WebKit::InspectorOverlay::showDebugBorders):
        (BlackBerry::WebKit::InspectorOverlay::showRepaintCounter):
        (BlackBerry::WebKit::InspectorOverlay::~InspectorOverlay):
        (BlackBerry::WebKit::InspectorOverlay::clear):
        (BlackBerry::WebKit::InspectorOverlay::update):
        * WebKitSupport/InspectorOverlayBlackBerry.h: Renamed from Source/WebKit/blackberry/WebKitSupport/InspectorOverlay.h.
        (WebCore):
        (WebKit):
        (InspectorOverlay):
        (InspectorOverlayClient):
        (BlackBerry::WebKit::InspectorOverlay::setClient):
        (BlackBerry::WebKit::InspectorOverlay::notifyAnimationStarted):

1678 1679 1680 1681 1682 1683 1684
2012-09-13  Antonio Gomes  <agomes@rim.com>

        Unreviewed, warning fix left over from r128456 (bug 96645)

        * Api/InRegionScroller.cpp:
        (WebKit):

1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698
2012-09-13  Genevieve Mak  <gmak@rim.com>

        Continue to send mouse move events to a non-scrollable page
        even if they are not consumed.
        PR #207024
        https://bugs.webkit.org/show_bug.cgi?id=96655

        Reviewed by Antonio Gomes.

        * WebKitSupport/TouchEventHandler.cpp:
        (BlackBerry::WebKit::isMainFrameScrollable):
        (WebKit):
        (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):

1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714
2012-09-13  Jacky Jiang  <zhajiang@rim.com>

        [BlackBerry] Missing conditions in InRegionScrollerPrivate::canScrollRenderBox
        https://bugs.webkit.org/show_bug.cgi?id=96660

        Reviewed by Antonio Gomes.

        PR: 207884
        According to RenderBox::canBeScrolledAndHasScrollableArea(), we should
        bail out early in InRegionScrollerPrivate::canScrollRenderBox() if the
        RenderBox's scroll height equals the client height and the scroll width
        equals the client width. Otherwise, we will miss the conditions.

        * Api/InRegionScroller.cpp:
        (BlackBerry::WebKit::InRegionScrollerPrivate::canScrollRenderBox):

1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728
2012-09-13  Jessica Cao  <jecao@rim.com>

        [BlackBerry] Page Popup for Month is non-functional.
        https://bugs.webkit.org/show_bug.cgi?id=96651

        Reviewed by Rob Buis.

        Hook up support for Month popup.

        * WebCoreSupport/DatePickerClient.cpp:
        (WebCore::DatePickerClient::generateHTML):
        * WebKitSupport/InputHandler.cpp:
        (BlackBerry::WebKit::InputHandler::openDatePopup):

1729 1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748
2012-09-13  Antonio Gomes  <agomes@rim.com>

        [BlackBerry] ASSERT failure in InRegionScrollableArea::InRegionScrollableArea
        https://bugs.webkit.org/show_bug.cgi?id=96645
        PR #207307

        Reviewed by George Staikos.

        We use canScrollRenderBox to promote the layer as scrollable instead
        of RenderBox::canScrollAndHasScrollableArea (see comment above the former).
        We should assert against the former as well.

        * Api/InRegionScroller.cpp:
        (BlackBerry::WebKit::InRegionScrollerPrivate::canScrollRenderBox):
        * Api/InRegionScroller_p.h:
        (WebCore):
        (InRegionScrollerPrivate):
        * WebKitSupport/InRegionScrollableArea.cpp:
        (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):

1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768
2012-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r127876.
        http://trac.webkit.org/changeset/127876
        https://bugs.webkit.org/show_bug.cgi?id=96600

        mouse click doesn't work for spin button if spin button in
        iframe (Requested by yosin on #webkit).

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::contextNode):
        (BlackBerry::WebKit::WebPagePrivate::nodeForZoomUnderPoint):
        (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
        (BlackBerry::WebKit::WebPage::nodeAtPoint):
        * WebKitSupport/FatFingers.cpp:
        (BlackBerry::WebKit::FatFingers::getNodesFromRect):
        (BlackBerry::WebKit::FatFingers::getRelevantInfoFromPoint):
        * WebKitSupport/SelectionHandler.cpp:
        (BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):

1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780
2012-09-12  Sami Kyostila  <skyostil@google.com>

        Rename OVERFLOW_SCROLLING as ACCELERATED_OVERFLOW_SCROLLING
        https://bugs.webkit.org/show_bug.cgi?id=96251

        Reviewed by Simon Fraser.

        Rename OVERFLOW_SCROLLING as ACCELERATED_OVERFLOW_SCROLLING to better describe
        the feature it controls.

        * WebCoreSupport/AboutDataEnableFeatures.in:

1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796
2012-09-11  Antonio Gomes  <agomes@rim.com>

        [BlackBerry] add a way to overscroll non-overflown content
        https://bugs.webkit.org/show_bug.cgi?id=96331
        PR #195305

        Reviewed by Yong Li.

        Check -webkit-overflow-scrolling value for '-blackberry-touch' instead
        of checking a custom HTML5 attribute.

        No behavioural change. Mostly a rework of r128142.

        * Api/InRegionScroller.cpp:
        (BlackBerry::WebKit::canScrollRenderBox):

1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812
2012-09-11  Rob Buis  <rbuis@rim.com>

        [BlackBerry] make pickers/dialogs use appendLiteral
        https://bugs.webkit.org/show_bug.cgi?id=96424

        Reviewed by Antonio Gomes.

        PR 204032

        Other pickers were updated in r128204.

        * WebCoreSupport/ColorPickerClient.cpp:
        (WebCore::ColorPickerClient::generateHTML):
        * WebCoreSupport/PagePopupBlackBerry.cpp:
        (WebCore::PagePopupBlackBerry::generateHTML):

1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828
2012-09-11  Konrad Piascik  <kpiascik@rim.com>

        [BlackBerry] Fix history navigation for error pages.
        https://bugs.webkit.org/show_bug.cgi?id=96410

        Reviewed by Rob Buis.

        Fix how history navigation handles restoring view state when navigating between error pages.

        * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
        (WebCore::FrameLoaderClientBlackBerry::FrameLoaderClientBlackBerry):
        (WebCore::FrameLoaderClientBlackBerry::saveViewStateToItem):
        (WebCore::FrameLoaderClientBlackBerry::restoreViewState):
        * WebCoreSupport/FrameLoaderClientBlackBerry.h:
        (FrameLoaderClientBlackBerry):

1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843
2012-09-11  Jinwoo Song  <jinwoo7.song@samsung.com>

        Deploy StringBuilder::appendNumber() and StringBuilder::appendLiteral() in more places
        https://bugs.webkit.org/show_bug.cgi?id=96344

        Reviewed by Benjamin Poulain.

        Use StringBuilder::appendNumber() instead of String::number(). Also deploy 
        StringBuilder::appendLiteral() instead of String::append() in the surrounding code.

        * WebCoreSupport/DatePickerClient.cpp:
        (WebCore::DatePickerClient::generateHTML):
        * WebCoreSupport/SelectPopupClient.cpp:
        (WebCore::SelectPopupClient::generateHTML):

1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864
2012-09-11  Jacky Jiang  <zhajiang@rim.com>

        [BlackBerry] InRegion scrollable area dangling pointers were accessed in UI thread
        https://bugs.webkit.org/show_bug.cgi?id=96318

        Reviewed by Antonio Gomes.

        PR: 204066
        Dangling pointers were accessed in UI thread, as the actual InRegion
        scrollable areas of WebKit side had been destroyed before that in
        WebKit thread after UI thread set scrolling to false.
        Notify the client side to clear InRegion scrollable areas before we
        destroy them in WebKit side.

        Internally reviewed by Gen Mak and George Staikos.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::notifyInRegionScrollStopped):
        (BlackBerry::WebKit::WebPagePrivate::setScrollOriginPoint):
        * Api/WebPageClient.h:

1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881
2012-09-11  Mike Fenton  <mifenton@rim.com>

        [BlackBerry] Suppress keyboard requests while processing spell checking suggestions.
        https://bugs.webkit.org/show_bug.cgi?id=96394

        Reviewed by Rob Buis.

        Suppress the VKB notification when the touch event
        is a spell checking request.

        PR 192925.

        Reviewed Internally by Gen Mak.

        * WebKitSupport/TouchEventHandler.cpp:
        (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):

1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896
2012-09-11  Mike Fenton  <mifenton@rim.com>

        [BlackBerry] Colour Dialog popup request should return proper state.
        https://bugs.webkit.org/show_bug.cgi?id=96392

        Reviewed by Rob Buis.

        Return proper state from openColorPopup dependent on
        whether the popup actually opened.

        Reviewed Internally by Chris Hutten-Czapski

        * WebKitSupport/InputHandler.cpp:
        (BlackBerry::WebKit::InputHandler::openColorPopup):

1897 1898 1899 1900 1901 1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912
2012-09-11  Nima Ghanavatian  <nghanavatian@rim.com>

        [BlackBerry] Take account for single words that exceed our client character limit
        https://bugs.webkit.org/show_bug.cgi?id=96389

        Fix to the processing of long single-line text using getRangeForSpellCheckWithFineGranularity.
        This was failing if a single word was longer than our maximum allowed limit.

        Internally reviewed by Mike Fenton.

        Reviewed by Rob Buis.

        * WebKitSupport/InputHandler.cpp:
        (WebKit):
        (BlackBerry::WebKit::InputHandler::getRangeForSpellCheckWithFineGranularity):

1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946 1947
2012-09-11  Arvid Nilsson  <anilsson@rim.com>

        [BlackBerry] SelectionHandler drops caret change notifications
        https://bugs.webkit.org/show_bug.cgi?id=96378

        Reviewed by Antonio Gomes.

        The selection handler deliberately drops caret change notifications
        while the input handler is processing changes, to avoid displaying
        intermediate state during a complex change.

        However, this meant that the client was never informed of the final
        caret position.

        Fixed by notifying client about caret change after processing ends, if
        one or more caret change notifications were dropped during processing.

        PR #205073

        Reviewed internally by Mike Fenton.

        * WebKitSupport/InputHandler.cpp:
        (BlackBerry::WebKit::InputHandler::setProcessingChange):
        (WebKit):
        * WebKitSupport/InputHandler.h:
        (InputHandler):
        * WebKitSupport/SelectionHandler.cpp:
        (BlackBerry::WebKit::SelectionHandler::SelectionHandler):
        (BlackBerry::WebKit::SelectionHandler::inputHandlerDidFinishProcessingChange):
        (WebKit):
        (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
        (BlackBerry::WebKit::SelectionHandler::notifyCaretPositionChangedIfNeeded):
        * WebKitSupport/SelectionHandler.h:
        (SelectionHandler):

1948 1949 1950 1951 1952 1953 1954 1955 1956 1957 1958 1959 1960 1961 1962 1963 1964 1965 1966 1967 1968 1969
2012-09-10  Antonio Gomes  <agomes@rim.com>

        [BlackBerry] add a way to overscroll non-overflown content
        https://bugs.webkit.org/show_bug.cgi?id=96331
        [UxD] Vertical lists should always be scrollable
        PR #195305

        Reviewed by Yong Li.
        Internally reviewed by Gen Mak.

        Check if the RenderLayer is composited / hardware acceleratable prior to
        check if its contents overflows. If that is the case, check if
        our custom data-blackberry-force-overscroll is present.

        That makes it possible for us to align to UX requirements: settings
        and CCM panels should be always scrollable.

        * Api/InRegionScroller.cpp:
        (BlackBerry::WebKit::canScrollRenderBox):
        * WebKitSupport/InRegionScrollableArea.cpp:
        (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):

1970 1971 1972 1973 1974 1975 1976 1977 1978 1979 1980 1981 1982 1983
2012-09-10  Genevieve Mak  <gmak@rim.com>

        Change -data-blackberry-webworks-context to -data-webworks-context
        because not all webworks apps are blackberry apps.
        https://bugs.webkit.org/show_bug.cgi?id=96297

        Reviewed by Antonio Gomes.

        PR #193726
        Rubber Stamped interally by Mike Fenton.

        * WebKitSupport/DOMSupport.cpp:
        (BlackBerry::WebKit::DOMSupport::webWorksContext):

1984 1985 1986 1987 1988 1989 1990 1991 1992 1993 1994 1995 1996 1997 1998 1999 2000 2001 2002 2003 2004 2005 2006 2007 2008 2009
2012-09-09  Arvid Nilsson  <anilsson@rim.com>

        [BlackBerry] Fix flicker due to introduction of the fence extension.
        https://bugs.webkit.org/show_bug.cgi?id=96207

        Reviewed by George Staikos.

        Don't immediately add fence to garbage list, so it is destroyed
        after only one swap, for a set of tiles just because one tile in
        the set gets a new fence, the old fence may still not be signalled
        and before rendering the other tiles in the set we have to wait for it.

        * WebKitSupport/BackingStoreTile.cpp:
        (BlackBerry::WebKit::Fence::~Fence):
        (WebKit):
        * WebKitSupport/BackingStoreTile.h:
        (WebKit):
        (Fence):
        * WebKitSupport/SurfacePool.cpp:
        (BlackBerry::WebKit::SurfacePool::initialize):
        (BlackBerry::WebKit::SurfacePool::notifyBuffersComposited):
        (WebKit):
        (BlackBerry::WebKit::SurfacePool::destroyPlatformSync):
        * WebKitSupport/SurfacePool.h:
        (SurfacePool):

2010 2011 2012 2013 2014 2015 2016 2017 2018 2019 2020 2021 2022 2023 2024 2025 2026 2027 2028
2012-09-08  Max Feil  <mfeil@rim.com>

        [BlackBerry] Exiting fullscreen mode can leave user stuck without Browser menus
        https://bugs.webkit.org/show_bug.cgi?id=96027

        Reviewed by Antonio Gomes.

        The changes for bug 87337 (landed as trunk svn revision 119119)
        introduced a bug. The same conditions are not checked on enter
        fullscreen vs. exit. Web sites such as http://videojs.com
        and youtube's mobile HTML5 player make the div container
        of the video element go fullscreen. This is allowed in
        WebPagePrivate::enterFullScreenForElement() but disallowed in
        WebPagePrivate::exitFullScreenForElement(). I am fixing this by
        allowing containers of video elements to exit fullscreen.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):

2029 2030 2031 2032 2033 2034 2035 2036 2037 2038 2039 2040 2041 2042 2043
2012-09-07  Ming Xie  <mxie@rim.com>


        [BlackBerry] Remove browser from the build info page
        https://bugs.webkit.org/show_bug.cgi?id=96162

        Reviewed by George Staikos.
        Internal reviewed by Jeff Rogers.

        WebKit build should not have the build info for browser which is
        built on top of webkit.

        * WebKitSupport/AboutData.cpp:
        (BlackBerry::WebKit::buildPage):

2044 2045 2046 2047 2048 2049 2050 2051 2052 2053 2054 2055 2056 2057 2058 2059 2060 2061 2062
2012-09-07  Yongxin Dai  <yodai@rim.com>

        [BlackBerry] Initialize caret rectangle with invalid location
        https://bugs.webkit.org/show_bug.cgi?id=96011

        Reviewed by Rob Buis.

        In SelectionHandler::selectionPositionChanged() method, startCaret and
        endCaret are used to notify clients about new caret positions. This patch
        initializes startCaret and endCaret with location(-1. -1), and keeps them
        empty before they are assigned to valid values. This would help for other
        classes to check validity of the caret correctly.

        Internal reviewed by Mike Fenton.

        * WebKitSupport/SelectionHandler.cpp:
        (BlackBerry::WebKit::adjustCaretRects):
        (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):

2063 2064 2065 2066 2067 2068 2069 2070 2071 2072 2073 2074 2075 2076 2077 2078 2079 2080 2081 2082 2083 2084
2012-09-07  Lianghui Chen  <liachen@rim.com>

        [BlackBerry] when one of multiple tabs uses authentication, user can get the auth dialog while the other tab has focus.
        https://bugs.webkit.org/show_bug.cgi?id=95488
        PR: 186597.

        Internally reviewed by Joe Mason.
        Reviewed by Yong Li.

        Use new AuthenticationChallengeClient interface to make authentication
        challenge asynchronous to NetworkJob, MediaPlayerPrivateBlackBerry, and
        other module that will use HTTP authentication. WebPage itself still use
        synchronous authentication though. Switching to asynchronous authentication
        in WebPage will require bigger platform layer change and not very necessary
        at the moment for this bug.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
        * Api/WebPage_p.h:
        (WebCore):
        (WebPagePrivate):

2085 2086 2087 2088 2089 2090 2091 2092 2093 2094 2095 2096
2012-09-07  Rob Buis  <rbuis@rim.com>

        [BlackBerry] Remove feature about:cache/disable and about:cache/enable
        https://bugs.webkit.org/show_bug.cgi?id=95820

        Reviewed by Yong Li.

        Fix warning that was caused by r127680.

        * WebKitSupport/AboutData.cpp:
        (BlackBerry::WebKit::cachePage):

2097 2098 2099 2100 2101 2102 2103 2104 2105 2106 2107 2108 2109 2110 2111 2112 2113 2114 2115 2116
2012-09-07  Allan Sandfeld Jensen  <allan.jensen@nokia.com>

        Simplify hitTestResultAtPoint and nodesFromRect APIs
        https://bugs.webkit.org/show_bug.cgi?id=95720

        Reviewed by Antonio Gomes.

        Update calls to new API.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::contextNode):
        (BlackBerry::WebKit::WebPagePrivate::nodeForZoomUnderPoint):
        (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
        (BlackBerry::WebKit::WebPage::nodeAtPoint):
        * WebKitSupport/FatFingers.cpp:
        (BlackBerry::WebKit::FatFingers::getNodesFromRect):
        (BlackBerry::WebKit::FatFingers::getRelevantInfoFromPoint):
        * WebKitSupport/SelectionHandler.cpp:
        (BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):

2117 2118 2119 2120 2121 2122 2123 2124 2125 2126 2127 2128 2129 2130 2131
2012-09-07  Robin Cao  <robin.cao@torchmobile.com.cn>

        [BlackBerry] Rendering issue after rotation
        https://bugs.webkit.org/show_bug.cgi?id=96094
        PR #201930

        Reviewed by George Staikos.

        The cause of the rendering issue is that the BackingStore tiles
        are not reset after layout. This is a regression of r125680, which
        overwrites a local variable that are used later in the function.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::setViewportSize):

2132 2133 2134 2135 2136 2137 2138 2139 2140 2141 2142 2143 2144 2145 2146 2147 2148 2149 2150 2151 2152 2153 2154 2155 2156 2157 2158
2012-09-06  Crystal Zhang  <haizhang@rim.com>

        [BlackBerry]  Implement a color picker
        https://bugs.webkit.org/show_bug.cgi?id=96001

        Reviewed by Rob Buis.

        Add files for color picker, replace old hook to AIR color picker.

        * WebCoreSupport/ColorPickerClient.cpp: Added.
        (WebCore):
        (WebCore::ColorPickerClient::ColorPickerClient):
        (WebCore::ColorPickerClient::~ColorPickerClient):
        (WebCore::ColorPickerClient::generateHTML):
        (WebCore::ColorPickerClient::closePopup):
        (WebCore::ColorPickerClient::contentSize):
        (WebCore::ColorPickerClient::htmlSource):
        (WebCore::ColorPickerClient::setValueAndClosePopup):
        (WebCore::ColorPickerClient::didClosePopup):
        (WebCore::ColorPickerClient::writeDocument):
        * WebCoreSupport/ColorPickerClient.h: Added.
        (WebKit):
        (WebCore):
        (ColorPickerClient):
        * WebKitSupport/InputHandler.cpp:
        (BlackBerry::WebKit::InputHandler::openColorPopup):

2159 2160 2161 2162 2163 2164 2165 2166 2167 2168 2169 2170 2171 2172 2173 2174 2175 2176 2177 2178 2179
2012-09-06  Genevieve Mak  <gmak@rim.com>

        Add data-blackberry-webworks-context attribute and set the custom context when
        getting context.
        https://bugs.webkit.org/show_bug.cgi?id=95993

        Reviewed by Antonio Gomes.

        PR #193726
        Reviewed Internally by Mike Fenton.

        * Api/WebPage.cpp:
        (BlackBerry::WebKit::WebPagePrivate::webContext):
            - Check for custom WebWorks context and add it if there.
        * WebKitSupport/DOMSupport.cpp:
        (BlackBerry::WebKit::DOMSupport::webWorksContext):
        (DOMSupport):
        * WebKitSupport/DOMSupport.h:
            - Add a method that checks a given element for the data-webworks-context
              attribute and returns its value if present.

2180 2181 2182 2183 2184 2185 2186 2187 2188 2189 2190 2191 2192 2193 2194 2195
2012-09-06  Antonio Gomes  <agomes@rim.com>

        [BlackBerry] Allow overscroll to composited scroll layers
        https://bugs.webkit.org/show_bug.cgi?id=95998
        PR #195305

        Reviewed by Rob Buis.
        Internally reviewed by Gen Mak.

        No need to reset the overscroll limit factor at creation to 0.
        It is already 0 by default, and later on the client sets the
        appropriated value.

        * WebKitSupport/InRegionScrollableArea.cpp:
        (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):

2196 2197 2198 2199 2200 2201 2202 2203 2204 2205 2206 2207 2208 2209 2210
2012-09-05  Sam Weinig  <sam@webkit.org>

        Part 2 of removing PlatformString.h, remove PlatformString.h
        https://bugs.webkit.org/show_bug.cgi?id=95931

        Reviewed by Adam Barth.

        Remove PlatformString.h

        * Api/DumpRenderTreeClient.h:
        * WebCoreSupport/ChromeClientBlackBerry.cpp:
        * WebCoreSupport/InspectorClientBlackBerry.h:
        * WebCoreSupport/JavaScriptDebuggerBlackBerry.cpp:
        * WebKitSupport/AboutData.h:

2211 2212 2213 2214 2215 2216 2217 2218 2219 2220 2221 2222
2012-09-05  Jason Liu  <jason.liu@torchmobile.com.cn>

        [BlackBerry] Remove feature about:cache/disable and about:cache/enable
        https://bugs.webkit.org/show_bug.cgi?id=95820

        Reviewed by Rob Buis.

        Remove this feature since we need to add a button in settings.

        * WebKitSupport/AboutData.cpp:
        (BlackBerry::WebKit::cachePage):

2223 2224 2225 2226 2227 2228 2229 2230 2231 2232 2233 2234 2235 2236 2237 2238
2012-09-05  Mike Fenton  <mifenton@rim.com>

        [BlackBerry] Remove deprecated dialog connections.
        https://bugs.webkit.org/show_bug.cgi?id=95868

        Reviewed by Rob Buis.

        PR 187481.
        Remove deprecated logic for unsupported
        Dialog types.

        * Api/WebPageClient.h:
        * WebKitSupport/InputHandler.cpp:
        (BlackBerry::WebKit::InputHandler::openDatePopup):
        (BlackBerry::WebKit::InputHandler::openColorPopup):

2239 2240 2241 2242 2243 2244 2245 2246 2247 2248 2249 2250 2251 2252
2012-09-05  George Staikos  <staikos@webkit.org>

        [BlackBerry] Assignment operators missing self-check
        https://bugs.webkit.org/show_bug.cgi?id=95774

        Reviewed by Rob Buis.

        Add a test for self-assignment.

        * Api/WebAnimation.cpp:
        (BlackBerry::WebKit::WebAnimation::operator=):
        * Api/WebString.cpp:
        (BlackBerry::WebKit::WebString::operator=):

2253 2254 2255 2256 2257 2258 2259 2260 2261 2262 2263 2264 2265 2266 2267
2012-09-05  Leo Yang  <leoyang@rim.com>

        [BlackBerry] Optimize BackingStorePrivate::isCurrentVisibleJob
        https://bugs.webkit.org/show_bug.cgi?id=95897

        Reviewed by Antonio Gomes.

        Bail out the loop early if one of the not-rendered rectangle is
        not current regular render job.

        No behavior change, just code optimization.

        * Api/BackingStore.cpp:
        (BlackBerry::WebKit::BackingStorePrivate::isCurrentVisibleJob):

2268 2269 2270 2271 2272 2273 2274 2275 2276 2277 2278 2279 2280
2012-09-05  Benjamin C Meyer  <bmeyer@rim.com>

        [BlackBerry] JavaScriptVariant can crash when operator= is called with itself
        https://bugs.webkit.org/show_bug.cgi?id=95859

        Reviewed by George Staikos.

        * Api/JavaScriptVariant.cpp:
        (BlackBerry::WebKit::JavaScriptVariant::operator=):
        When JavaScriptVariant contains a string and operator= is
        called with itself the memory will be free'd in 'this' and
        then a copy will be attempted from 'that' resulting in a crash.

2281 2282 2283 2284 2285 2286 2287 2288 2289 2290 2291 2292 2293 2294 2295 2296
2012-09-05  Leo Yang  <leoyang@rim.com>

        [BlackBerry] Rotation and then reload causes less sized webpage (PR 190469)
        https://bugs.webkit.org/show_bug.cgi?id=95870

        Reviewed by George Staikos.
        Reviewed internally by Jacky Jiang.

        Use the new zoom to fit scale if the page was zoomed to fit initial scale
        When a page is reloaded the layout size may be changed. So the contents
        size on which the initial scale depends may be changed. Use the new initial
        scale in this case to make sure the page will be zoomed to correct scale.

        * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
        (WebCore::FrameLoaderClientBlackBerry::restoreViewState):

2297 2298 2299 2300 2301 2302 2303 2304 2305 2306 2307 2308 2309 2310 2311
2012-09-05  Robin Cao  <robin.cao@torchmobile.com.cn>

        [BlackBerry] Do not release shared backingstore memory prematurely
        https://bugs.webkit.org/show_bug.cgi?id=95841
        PR #202517

        Reviewed by George Staikos.

        The BackingStore memory is shared by all web pages. We should check if
        the current backingStore is active before create/release this shared memory.

        * Api/BackingStore.cpp:
        (BlackBerry::WebKit::BackingStore::createBackingStoreMemory):
        (BlackBerry::WebKit::BackingStore::releaseBackingStoreMemory):

2312 2313 2314 2315 2316 2317 2318 2319 2320 2321 2322 2323 2324 2325 2326 2327 2328 2329 2330 2331 2332 2333 2334 2335 2336
2012-09-05  Andy Chen  <andchen@rim.com>

        [BlackBerry] Implement number of matches and current active match index for find-on-page
        https://bugs.webkit.org/show_bug.cgi?id=95801

        Reviewed by Antonio Gomes.

        - Calculate current match index for find-on-page
        - Notify client when number of matches and current match index update.
        PR 162090 162091.
        Internally reviewed by Mike Fenton and Joe Mason

        * Api/WebPageClient.h:
        * WebKitSupport/InPageSearchManager.cpp:
        (BlackBerry::WebKit::InPageSearchManager::DeferredScopeStringMatches::DeferredScopeStringMatches):
        (BlackBerry::WebKit::InPageSearchManager::DeferredScopeStringMatches::doTimeout):
        (InPageSearchManager::DeferredScopeStringMatches):
        (BlackBerry::WebKit::InPageSearchManager::findNextString):
        (BlackBerry::WebKit::InPageSearchManager::findAndMarkText):
        (BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):
        (BlackBerry::WebKit::InPageSearchManager::scopeStringMatchesSoon):
        (BlackBerry::WebKit::InPageSearchManager::callScopeStringMatches):
        * WebKitSupport/InPageSearchManager.h:
        (InPageSearchManager):

2337 2338 2339 2340 2341 2342 2343 2344 2345 2346 2347 2348
2012-09-04  Rob Buis  <rbuis@rim.com>

        [BlackBerry] FatFingers::cachingStrategy uses incorrect enum value
        https://bugs.webkit.org/show_bug.cgi?id=95783

        Reviewed by Antonio Gomes.

        Use the correct enum values.

        * WebKitSupport/FatFingers.cpp:
        (BlackBerry::WebKit::FatFingers::cachingStrategy):

2349 2350 2351 2352 2353 2354 2355 2356 2357 2358 2359 2360 2361 2362 2363 2364 2365 2366 2367 2368 2369
2012-09-04  Antonio Gomes  <agomes@rim.com>

        [BlackBerry] Use child/ScrollableContent layer's position instead of parent/ScrollLayer's boundsOrigin
        https://bugs.webkit.org/show_bug.cgi?id=95778
        PR #202252

        Reviewed by Rob Buis.
        Internally reviewed by Arvid Nilsson.

        Upstream has switch away from using the parent scroll layer's bounds origin
        in order to translate contents of all its child layers. Instead now, it directly
        sets the scroll position of the child scrollable contents layer.

        Source/WebKit/blackberry:
        * Api/InRegionScroller.cpp:
        (BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionCompositingThread):
        * WebKitSupport/InRegionScrollableArea.cpp:
        (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):

        No new tests, since it is a catch-up with upstreaming code.

2370 2371 2372 2373 2374 2375 2376 2377 2378 2379 2380 2381
2012-09-04  George Staikos  <staikos@webkit.org>

        [BlackBerry] Fix memory leak in InputHandler
        https://bugs.webkit.org/show_bug.cgi?id=95771

        Reviewed by Rob Buis.

        Simply delete the arrays at function exit.

        * WebKitSupport/InputHandler.cpp:
        (BlackBerry::WebKit::InputHandler::openSelectPopup):

2382 2383 2384 2385 2386 2387 2388 2389 2390 2391 2392 2393 2394 2395
2012-09-04  George Staikos  <staikos@webkit.org>

        [BlackBerry] pass isMainFrame() through to notifyDocumentOnLoad()
        https://bugs.webkit.org/show_bug.cgi?id=95766

        Reviewed by Rob Buis.

        Passing the frame status through will allow the client to make better
        decisions about how to act on the onload.

        * Api/WebPageClient.h:
        * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
        (WebCore::FrameLoaderClientBlackBerry::dispatchDidHandleOnloadEvents):

2396