ChangeLog 2.55 MB
Newer Older
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
2012-04-18  Thiago Marcos P. Santos  <thiago.santos@intel.com>

        [CMake] Use jsc target instead of ONLY_BUILD_JAVASCRIPTCORE
        https://bugs.webkit.org/show_bug.cgi?id=84229

        CMake caches ONLY_BUILD_JAVASCRIPTCORE=1 and will reuse the setting for
        subsequent builds, stopping WebCore from being built ever again.

        Instead of trying to emulate a build target using command line options,
        just build the existing jsc target directly.

        Reviewed by Rob Buis.

        * Scripts/build-jsc:

16
17
18
19
20
21
22
23
24
25
26
27
28
29
2012-04-18  Simon Pena  <spena@igalia.com>

        [GTK] r114021 triggered media flakyness
        https://bugs.webkit.org/show_bug.cgi?id=83874

        Reviewed by Philippe Normand.

        Now that there is gtk API to update the
        MediaPlaybackRequiresUserGesture property, set it to false from the
        DumpRenderTree tool when resetting defaults to consistent values.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (resetDefaultsToConsistentValues):

30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
2012-04-18  Vivek Galatage  <vivekgalatage@gmail.com>

        Web Inspector: Disabling Inspector causes build failure on Windows
        https://bugs.webkit.org/show_bug.cgi?id=83557

        Reviewed by Pavel Feldman.

        The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
        This change brings all such API calls under the guard.

        * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
        (WTR::LayoutTestController::showWebInspector):
        (WTR::LayoutTestController::closeWebInspector):
        (WTR::LayoutTestController::evaluateInWebInspector):
        (WTR::LayoutTestController::setJavaScriptProfilingEnabled):
        * WebKitTestRunner/TestInvocation.cpp:
        (WTR::TestInvocation::invoke):

48
49
50
51
52
53
54
55
56
57
2012-04-18  Mario Sanchez Prada  <msanchez@igalia.com>

        [GTK] atk/textChangedNotifications API test fails
        https://bugs.webkit.org/show_bug.cgi?id=84010

        Unreviewed, unskipping test after bug being fixed by r114311.

        * Scripts/run-gtk-tests:
        (TestRunner): Unskip now passing test.

58
59
60
61
62
63
64
65
66
67
68
69
70
2012-04-17  Jacky Jiang  <zhajiang@rim.com>

        [BlackBerry] Viewport metatag doesn't disable double-tap zoom
        https://bugs.webkit.org/show_bug.cgi?id=84199

        Reviewed by George Staikos.

        Revert a part of the change master_32/SHA:fa0f8ee9 and use
        WebPage::setUserScalable instead.

        * DumpRenderTree/blackberry/DumpRenderTree.cpp:
        (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):

71
72
73
74
75
76
77
78
79
80
81
82
83
2012-04-17  Dirk Pranke  <dpranke@chromium.org>

        build-webkit: make ninja work with chromium linux
        https://bugs.webkit.org/show_bug.cgi?id=84213

        Reviewed by Eric Seidel.

        Fix typos so that build-webkit will use ninja to
        build chromium if a build.ninja file exists and is up-to-date.

        * Scripts/webkitdirs.pm:
        (determineIsChromiumNinja):

84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
2012-04-17  Ojan Vafai  <ojan@chromium.org>

        Add caching to the flakiness dashboard json files
        https://bugs.webkit.org/show_bug.cgi?id=84198

        Reviewed by Dirk Pranke.

        * TestResultServer/handlers/testfilehandler.py:
        (GetFile._get_file_list):
        (GetFile._get_file_content):
        (GetFile._get_file_content_from_key):
        (GetFile._get_test_list_json):
        (GetFile._serve_json):
        Add a Last-Modified header and handle If-Modified-Since headers.
        (GetFile.get):

100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
2012-04-17  Anders Carlsson  <andersca@apple.com>

        Need a client callback for when the user tries to interact with an already unresponsive page
        https://bugs.webkit.org/show_bug.cgi?id=84201
        <rdar://problem/11140862>

        Reviewed by Andreas Kling.

        Add new client functions.

        * MiniBrowser/mac/BrowserWindowController.m:
        (-[BrowserWindowController awakeFromNib]):
        * WebKitTestRunner/TestController.cpp:
        (WTR::TestController::initialize):

115
116
117
118
119
120
121
122
123
124
125
126
127
128
2012-04-17  Dirk Pranke  <dpranke@chromium.org>

        nrwt: handle stopping layout test helper after a ctrl-c cleanly on the chromium port
        https://bugs.webkit.org/show_bug.cgi?id=84190

        Reviewed by Ojan Vafai.

        LayoutTestHelper would exit when the user typed ctrl-c, but we
        would attempt to write to it to shut it down, generating an
        IOError.

        * Scripts/webkitpy/layout_tests/port/chromium.py:
        (ChromiumPort.stop_helper):

129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
2012-04-17  Dirk Pranke  <dpranke@chromium.org>

        rename --experimental-fully-parallel
        https://bugs.webkit.org/show_bug.cgi?id=84188

        Reviewed by Ojan Vafai.

        I thought this was done long ago; rename
        --experimental-fully-parallel to just --fully-parallel and
        remove the --no- switch that AFAIK no one uses.

        * Scripts/webkitpy/layout_tests/controllers/manager.py:
        (Manager._run_tests):
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        (parse_args):

145
146
147
148
149
150
151
152
153
154
155
156
157
158
2012-04-17  Christophe Dumez  <christophe.dumez@intel.com>

        EFL's LayoutTestController does not implement callShouldCloseOnWebView
        https://bugs.webkit.org/show_bug.cgi?id=82301

        Reviewed by Martin Robinson.

        Implement callShouldCloseOnWebView in EFL's LayoutTestController by
        calling shouldClose() on the FrameLoader, allowing the related test
        to be removed from the skip list.

        * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
        (LayoutTestController::callShouldCloseOnWebView):

159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
2012-04-17  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>

        [EFL] Add setting API to enable/disable XSSAuditor
        https://bugs.webkit.org/show_bug.cgi?id=83281

        Add missing implementation setXSSAuditorEnabled to EFL's LayoutTestController
        in order to unskip tests in http/tests/security/xssAuditor. Also, catch the signal 
        'xss,detected' in DRT to enable a test, which is expecting a line containing
        'didDetectXSS' in the output when reflected XSS is encountered in the page.

        Reviewed by Antonio Gomes.

        * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
        (DumpRenderTreeChrome::createView):
        (DumpRenderTreeChrome::onFrameCreated):
        (DumpRenderTreeChrome::onDidDetectXSS):
        * DumpRenderTree/efl/DumpRenderTreeChrome.h:
        (DumpRenderTreeChrome):
        * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
        (LayoutTestController::setXSSAuditorEnabled):

180
181
182
183
184
185
186
187
188
189
190
191
2012-04-17  Nandor Huszka  <hnandor@inf.u-szeged.hu>

        [Qt] JSC build should handle --no-webkit2 option to avoid unwanted clean-builds
        https://bugs.webkit.org/show_bug.cgi?id=77533

        Reviewed by Simon Hausmann.

        Pick up the --no-webkit2 option from BUILD_WEBKIT_ARGS and pass on
        the corresponding parameter to the buildQMakeProjects function.

        * Scripts/build-jsc:

192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
2012-04-17  Christophe Dumez  <christophe.dumez@intel.com>

        [EFL] DRT should support LayoutTestController's dumpFrameLoadCallbacks()
        https://bugs.webkit.org/show_bug.cgi?id=83030

        Reviewed by Antonio Gomes.

        Implement support for LayoutTestController's dumpFrameLoadCallbacks()
        in EFL's DumpRenderTree. Make use of the new frame argument passed to
        the "load,started" and "load,finished" signals.

        * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
        (DumpRenderTreeChrome::createView):
        (DumpRenderTreeChrome::onLoadStarted):
        (DumpRenderTreeChrome::processWork):
        (DumpRenderTreeChrome::topLoadingFrameLoadFinished):
        (DumpRenderTreeChrome::onWebViewOnloadEvent):
        (DumpRenderTreeChrome::onInsecureContentRun):
        (DumpRenderTreeChrome::onInsecureContentDisplayed):
        (DumpRenderTreeChrome::onFrameCreated):
        (DumpRenderTreeChrome::onFrameProvisionalLoad):
        (DumpRenderTreeChrome::onFrameLoadCommitted):
        (DumpRenderTreeChrome::onFrameLoadFinished):
        (DumpRenderTreeChrome::onFrameLoadError):
        * DumpRenderTree/efl/DumpRenderTreeChrome.h:
        (DumpRenderTreeChrome):

219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
2012-04-17  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r114376.
        http://trac.webkit.org/changeset/114376
        https://bugs.webkit.org/show_bug.cgi?id=84155

        Wrong patch version committed, asked by the patch author.
        (Requested by rakuco on #webkit).

        * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
        (DumpRenderTreeChrome::createView):
        (DumpRenderTreeChrome::processWork):
        (DumpRenderTreeChrome::onLoadFinished):
        (DumpRenderTreeChrome::onWillSendRequest):
        * DumpRenderTree/efl/DumpRenderTreeChrome.h:
        (DumpRenderTreeChrome):

236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
2012-04-17  Christophe Dumez  <christophe.dumez@intel.com>

        [EFL] DRT should support LayoutTestController's dumpFrameLoadCallbacks()
        https://bugs.webkit.org/show_bug.cgi?id=83030

        Reviewed by Antonio Gomes.

        Implement support for LayoutTestController's dumpFrameLoadCallbacks()
        in EFL's DumpRenderTree.

        * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
        (DumpRenderTreeChrome::createView):
        (DumpRenderTreeChrome::processWork):
        (DumpRenderTreeChrome::topLoadingFrameLoadFinished):
        (DumpRenderTreeChrome::onWebViewOnloadEvent):
        (DumpRenderTreeChrome::onInsecureContentRun):
        (DumpRenderTreeChrome::onInsecureContentDisplayed):
        (DumpRenderTreeChrome::onFrameCreated):
        (DumpRenderTreeChrome::onFrameProvisionalLoad):
        (DumpRenderTreeChrome::onFrameLoadCommitted):
        (DumpRenderTreeChrome::onFrameLoadFinished):
        (DumpRenderTreeChrome::onFrameLoadError):
        * DumpRenderTree/efl/DumpRenderTreeChrome.h:
        (DumpRenderTreeChrome):

261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
2012-04-17  Michael Brüning  <michael.bruning@nokia.com>

        [Qt] Fix builds with force_static_libs_as_shared for non-linux builds.
        https://bugs.webkit.org/show_bug.cgi?id=83035

        Reviewed by Simon Hausmann.

        The force_static_libs_as_shared feature for the Qt port will remove
        hide_symbols from Qt's CONFIG in order to make them visible to other
        libraries again.

        Due to an evaluation order problem in qmake, the flags for the C++ compiler
        that are set by adding hide_symbols to the CONFIG variables get applied
        to qmake's C++ compiler flags directly and hence trying to remove these
        later will not work and cause build failures when using the force_static_libs_as_shared
        feature of the Qt port.

        This is fixed by removing the flags that hide the exports from the compiler flags directly.

        * qmake/mkspecs/features/force_static_libs_as_shared.prf:

282
283
284
285
286
287
288
289
290
291
292
293
294
295
2012-04-16  Ryosuke Niwa  <rniwa@webkit.org>

        Remove CreateWebKitBuildDirectory step to fix Chromium Windows Perf bot
        https://bugs.webkit.org/show_bug.cgi?id=84068

        Reviewed by Eric Seidel.

        Remove CreateWebKitBuildDirectory from master.cfg since download-built-product
        automatically creates the build directory if needed.

        * BuildSlaveSupport/build.webkit.org-config/master.cfg:
        (DownloadAndPerfTestFactory.__init__):
        (DownloadAndPerfTestWebKit2Factory.__init__):

296
297
298
299
300
301
302
303
304
305
306
2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>

        [GTK] Use configure instead of autogen.sh for gtk+
        https://bugs.webkit.org/show_bug.cgi?id=84112

        Rubber-stamped by Martin Robinson.

        * gtk/jhbuild.modules: GTK+'s autogen requires gobject-introspection;
        we don't want to depend on that for now, so run configure instead - we
        can, since we are using a tarball

307
308
309
310
311
312
313
314
315
316
2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>

        Unreviewed, rolling out r114322.
        http://trac.webkit.org/changeset/114322
        https://bugs.webkit.org/show_bug.cgi?id=84096

        Didn't make the debug bot happy, so back out

        * gtk/jhbuild.modules:

317
318
319
320
321
322
323
324
325
326
2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>

        [GTK] Try to fix debug bot by adding gobject-introspection to the build
        https://bugs.webkit.org/show_bug.cgi?id=84096

        Unreviewed speculative build fix.

        * gtk/jhbuild.modules: Added gobject-introspection, since modules need
        an up-to-date introspection m4 for running autogen.

kov@webkit.org's avatar
kov@webkit.org committed
327
328
329
330
331
332
333
334
335
336
337
2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>

        [GTK] Add pango to jhbuild
        https://bugs.webkit.org/show_bug.cgi?id=84086

        Unreviewed build fix.

        * gtk/jhbuild.modules: Add pango's latest stable release, 1.30, to our
        jhbuild environment. It's required for latest stable GTK+ and some
        systems may lack it.

338
339
340
341
342
343
344
345
346
347
348
2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>

        [GTK] fonts jhbuild module needs an empty clean target
        https://bugs.webkit.org/show_bug.cgi?id=84085

        Rubber-stamped by Martin Robinson.

        * gtk/jhbuild.modules: update to webkitgtk-test-fonts 0.0.2, which
        includes a phony clean target that should make warnings and errors go
        away.

349
350
351
352
353
354
355
356
357
358
359
360
2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>

        [GTK] Bump dependency on GTK+ 3.x to match reality
        https://bugs.webkit.org/show_bug.cgi?id=84060

        Rubber-stamped by Martin Robinson.

        * gtk/jhbuild.modules: Bump GTK+ to 3.4.0, plus glib and gdk-pixbuf
        to their GNOME 3.4 versions.
        * gtk/patches/gtk+-3.0.12-gtkprinter.patch: Removed. This patch
        is applied upstream.

361
362
363
364
365
366
367
368
2012-04-16  Vincent Scheib  <scheib@chromium.org>

        Adding Contributors Brian Salomon and Tom Hudson to committers.py.

        Unreviewed.

        * Scripts/webkitpy/common/config/committers.py:

369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
2012-04-16  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>

        [BlackBerry] Add ability for DRT to handle HTTP authentication challenges.
        https://bugs.webkit.org/show_bug.cgi?id=84031

        Reviewed by Rob Buis.

        Implemented interface function didReceiveAuthenticationChallenge in class
        DumpRenderTree.

        * DumpRenderTree/blackberry/DumpRenderTree.cpp:
        (drtCredentialDescription):
        (BlackBerry::WebKit::DumpRenderTree::didReceiveAuthenticationChallenge):
        (WebKit):
        * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
        (WebCore):
        (DumpRenderTree):

387
388
389
390
391
392
393
394
395
396
2012-04-16  Philippe Normand  <pnormand@igalia.com>

        build-webkit --gtk --no-webkit2 builds WK2
        https://bugs.webkit.org/show_bug.cgi?id=83977

        Reviewed by Martin Robinson.

        * Scripts/build-webkit: Fixup ./configure option to disable
        WebKit2 build.

397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
2012-04-16  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>

        [EFL] [DRT] Feeding key events with invalid keyName
        https://bugs.webkit.org/show_bug.cgi?id=83797

        Keep the keyName valid within scope of KeyEventInfo to avoid
        feeding key events with invalid keyName.

        Reviewed by Philippe Normand.

        * DumpRenderTree/efl/EventSender.cpp:
        (KeyEventInfo::KeyEventInfo):
        (KeyEventInfo):
        (keyPadNameFromJSValue):
        (keyNameFromJSValue):
        (createKeyEventInfo):
        (sendKeyDown):

415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
2012-04-16  Andras Piroska  <pandras@inf.u-szeged.hu>

        [Qt] Replace QtXmlPatterns usage with libxslt dependency
        <https://bugs.webkit.org/show_bug.cgi?id=76820>

        Reviewed by Simon Hausmann.

        The features.prf file was modified, in order to use libxml and libxslt by default.
        This modification only work at Qt5.

        * qmake/config.tests/libxml2/libxml2.cpp: Added.
        (main):
        * qmake/config.tests/libxml2/libxml2.pro: Added.
        * qmake/config.tests/libxslt/libxslt.cpp: Added.
        (main):
        * qmake/config.tests/libxslt/libxslt.pro: Added.
        * qmake/mkspecs/features/features.prf:
        * qmake/sync.profile:

434
435
436
437
438
439
440
441
442
443
444
445
2012-04-16  Seokju Kwon  <seokju.kwon@samsung.com>

        [EFL] EWebLaucher : Fix wrong parameter order in function call for multiple windows.
        https://bugs.webkit.org/show_bug.cgi?id=83862

        Reviewed by Kenneth Rohde Christiansen.

        EWebLauncher creates multiple windows, like multiple tabs when pressing F9 key.
        It doesn't work properly because of wrong parameter order in function call.

        * EWebLauncher/main.c:

philn@webkit.org's avatar
philn@webkit.org committed
446
447
448
449
450
451
452
2012-04-16  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, GTK gardening.

        * Scripts/run-gtk-tests:
        (TestRunner): Skip /webkit/atk/textChangedNotifications.

453
454
455
456
457
458
459
460
461
462
463
2012-04-13  Ryosuke Niwa  <rniwa@webkit.org>

        Chromium perf bots should not build
        https://bugs.webkit.org/show_bug.cgi?id=83641

        Reviewed by Eric Seidel.

        Don't build on perf bots to improve the cycle time.

        * BuildSlaveSupport/build.webkit.org-config/config.json:

464
465
466
467
468
469
470
471
472
473
474
475
476
477
2012-04-14  Zalan Bujtas  <zbujtas@gmail.com>

        [WK2] Set WebKitTestRunner's WebProcess cache model to DocumentBrowser.
        https://bugs.webkit.org/show_bug.cgi?id=81945

        Reviewed by Dan Bernstein.

        WebProcess's default cache model is DocumentViewer. When DocumentViewer model is on,
        the PageCache's capacity is set to 0. Tests that are enabling 'WebKitUsesPageCachePreferenceKey' expect
        PageCache to be functional.

        * WebKitTestRunner/TestController.cpp:
        (WTR::TestController::resetStateToConsistentValues):

478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
2012-04-11  James Robinson  <jamesr@chromium.org>

        [chromium] Remove unused compositeToTexture / compositeOffscreen setting
        https://bugs.webkit.org/show_bug.cgi?id=83733

        Reviewed by Adrienne Walker.

        Remove compositeOffscreen / compositeToTexture setting. This was an experiment that is no longer needed.

        * DumpRenderTree/chromium/DumpRenderTree.cpp:
        (main):
        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::TestShell):
        (TestShell::resetWebSettings):
        * DumpRenderTree/chromium/TestShell.h:
        (TestShell):
        * DumpRenderTree/chromium/WebPreferences.cpp:
        (WebPreferences::reset):
        (WebPreferences::applyTo):
        * DumpRenderTree/chromium/WebPreferences.h:
        (WebPreferences):

500
501
502
503
504
505
506
507
508
509
2012-04-13  Ryosuke Niwa  <rniwa@webkit.org>

        webkitpy build fix. Revert the debug change (number of runs was 2 instead of 20),
        and also rebaseline the test results since we ignore the first run now.

        * Scripts/webkitpy/performance_tests/perftest.py:
        (PageLoadingPerfTest.run):
        * Scripts/webkitpy/performance_tests/perftest_unittest.py:
        (TestPageLoadingPerfTest.test_run):

510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
2012-04-12  Ryosuke Niwa  <rniwa@webkit.org>

        Enable SVG page loading performance tests
        https://bugs.webkit.org/show_bug.cgi?id=83861

        Reviewed by Adam Barth.

        Add support for page loading tests. These are tests without any test running harnesses, and we use
        DriverOutput's test_timeout to measure the loading time.

        Extracted PerfTest.run and PerfTest.run_failed from PerfTestRunner._run_single_test.

        * Scripts/webkitpy/performance_tests/perftest.py:
        (PerfTest.run):
        (PerfTest):
        (PerfTest.run_failed):
        (PerfTest.parse_output):
        (PerfTest.output_statistics):
        (ChromiumStylePerfTest.parse_output):
        (PageLoadingPerfTest): Added.
        (PageLoadingPerfTest.__init__):
        (PageLoadingPerfTest.run): Run the driver 20 times to get the statistics for the loading time.
        * Scripts/webkitpy/performance_tests/perftest_unittest.py: Added.
        (MockPrinter):
        (MockPrinter.__init__):
        (MockPrinter.write):
        (MainTest):
        (MainTest.test_parse_output):
        (MainTest.test_parse_output_with_failing_line):
        (TestPageLoadingPerfTest):
        (TestPageLoadingPerfTest.assertWritten):
        (TestPageLoadingPerfTest.MockDriver):
        (TestPageLoadingPerfTest.MockDriver.__init__):
        (TestPageLoadingPerfTest.MockDriver.run_test):
        (TestPageLoadingPerfTest.test_run):
        (TestPageLoadingPerfTest.test_run_with_bad_output):
        * Scripts/webkitpy/performance_tests/perftestsrunner.py:
        (PerfTestsRunner):
        (PerfTestsRunner._collect_tests._is_test_file): Now recognizes svg tests.
        (PerfTestsRunner._collect_tests):
        (PerfTestsRunner._run_tests_set):
        (PerfTestsRunner._run_single_test):
        * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
        (test_collect_tests_with_page_load_svg):
        (test_collect_tests_with_page_load_svg.add_file):

556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
2012-04-10  Brady Eidson  <beidson@apple.com>

        <rdar://problem/11176921> and https://bugs.webkit.org/show_bug.cgi?id=83600
        Need WebKit2 API to notify whether history loads are in the page cache

        Add a test ShouldGoToBackForwardListItem that exercises the new BundlePageLoaderClient
        callback as well as the new WKBundleBackForwardListItemIsInPageCache() API.

        Reviewed by Darin Adler.

        * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp: Added.
        (TestWebKitAPI::didFinishLoadForFrame):
        (TestWebKitAPI::willGoToBackForwardListItem):
        (TestWebKitAPI::setPageLoaderClient):
        (TestWebKitAPI::TEST):
        * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp: Added.
        (ShouldGoToBackForwardListItemTest):
        (TestWebKitAPI::shouldGoToBackForwardListItemCallback):
        (TestWebKitAPI::ShouldGoToBackForwardListItemTest::ShouldGoToBackForwardListItemTest):
        (TestWebKitAPI::ShouldGoToBackForwardListItemTest::didCreatePage):
        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
        (WTR::InjectedBundlePage::InjectedBundlePage): Update for the new client.

581
582
583
584
585
586
587
588
589
590
591
592
593
2012-04-13  Dominik Röttsches  <dominik.rottsches@linux.intel.com>

        Group EFL bots into a category on the buildbot master
        https://bugs.webkit.org/show_bug.cgi?id=82712

        Reviewed by Adam Roben.

        Creating a new category definition on the buildbot frontend.

        * BuildSlaveSupport/build.webkit.org-config/master.cfg:
        (loadBuilderConfig): Determine category for EFL bots
        * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Add links to EFL category

594
595
596
597
598
599
600
601
602
603
604
605
2012-04-13  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r113714.
        http://trac.webkit.org/changeset/113714
        https://bugs.webkit.org/show_bug.cgi?id=83887

        It is behaving strange on the bots and needs more
        investigation. (Requested by jeez_ on #webkit).

        * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
        (WTR::PlatformWebView::PlatformWebView):

606
607
608
609
610
611
612
613
614
615
616
617
2012-04-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>

        webkit-tools-completion: Support bugzilla email completion for webkit-patch upload --cc
        https://bugs.webkit.org/show_bug.cgi?id=83690

        Reviewed by Tor Arne Vestbø.

        Typing part of an email and pressing <TAB> will bash-complete it using the list in
        Tools/Scripts/webkitpy/common/config/committers.py

        * Scripts/webkit-tools-completion.sh:

618
619
620
621
622
623
624
625
626
627
628
2012-04-13  Thiago Marcos P. Santos  <thiago.santos@intel.com>

        [EFL] Add API for color chooser
        https://bugs.webkit.org/show_bug.cgi?id=83692

        Enables INPUT_TYPE_COLOR by default on the EFL port.

        Reviewed by Kenneth Rohde Christiansen.

        * Scripts/build-webkit:

629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
2012-04-12  Ryosuke Niwa  <rniwa@webkit.org>

        Extract PerfTest class from PerfTestRunner
        https://bugs.webkit.org/show_bug.cgi?id=83847

        Reviewed by Hajime Morita.

        Extracted PerfTest and ChromiumStylePerfTest from PerfTestRunner. This class abstracts a test
        that was previously represented by a tuple.

        Also moved the logic to determine whether a given test is chromium style or not from run() to
        _collect_tests(). And moved the output parsing algorithms for parser style and chromium style
        tests from PerfTestRunner to PerfTest and ChromiumStylePerfTest respectively so that we may
        add new types of tests more easily.

        * Scripts/webkitpy/performance_tests/perftest.py: Added.
        (PerfTest):
        (PerfTest.__init__):
        (PerfTest.test_name):
        (PerfTest.dirname):
        (PerfTest.path_or_url):
        (PerfTest._should_ignore_line_in_parser_test_result):
        (PerfTest.parse_output):
        (ChromiumStylePerfTest):
        (ChromiumStylePerfTest.__init__):
        (ChromiumStylePerfTest.parse_output):
        * Scripts/webkitpy/performance_tests/perftestsrunner.py:
        (PerfTestsRunner._collect_tests):
        (PerfTestsRunner.run):
        (PerfTestsRunner._run_tests_set):
        (PerfTestsRunner._run_single_test):
        * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
        (run_test):
        (_tests_for_runner):
        (test_run_test_set_with_json_output):
        (test_run_test_set_with_json_source):
        (test_run_test_set_with_multiple_repositories):
        (_collect_tests_and_sort_test_name):
        (test_collect_tests):
        (test_collect_tests_with_skipped_list):

670
671
672
673
674
675
676
677
678
679
680
681
2012-04-12  Balazs Kelemen  <kbalazs@webkit.org>

        [Qt] Fix WebKit1 build with V8
        https://bugs.webkit.org/show_bug.cgi?id=83322

        Reviewed by Adam Barth.

        * DumpRenderTree/qt/DumpRenderTree.pro:
        * qmake/mkspecs/features/default_post.prf:
        * qmake/mkspecs/features/default_pre.prf:
        * qmake/mkspecs/features/features.prf:

682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
2012-04-12  Dirk Pranke  <dpranke@chromium.org>

        test-webkitpy fails on metered_stream_unittest for non-US West Coast Time Zones
        https://bugs.webkit.org/show_bug.cgi?id=83583

        Reviewed by Philippe Normand

        Updated the unit test to ignore the hours and minutes of the
        localtime for time(0), since we can't easily guarantee which
        timezone we're in or what timezone rules were in effect on
        1/1/1970; this should be mostly fine since we can trust that
        time.localtime() will work, although there is the possibility
        that we'll screw up the time formatting of which field is the
        hours and which is the minutes.

        * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
        (VerboseTest):
        (VerboseTest.test_basic):
        (VerboseTest.test_log_after_update):

702
703
704
705
706
707
708
709
710
711
712
2012-04-12  Dominik Rottsches  <dominik.rottsches@linux.intel.com>

        Add an EFL Debug Buildbot to the master configuration
        https://bugs.webkit.org/show_bug.cgi?id=82711

        Forgot to add EFL Linux Debug to scheduler.

        Reviewed by Philippe Normand.

        * BuildSlaveSupport/build.webkit.org-config/config.json:

713
714
715
716
717
718
719
720
721
722
723
2012-04-12  Dominik Röttsches  <dominik.rottsches@linux.intel.com>

        Add an EFL Debug Buildbot to the master configuration
        https://bugs.webkit.org/show_bug.cgi?id=82711

        Reviewed by Philippe Normand.

        Hooking up our EFL Linux 64bit debug configuration buildbot to the buildbot master.

        * BuildSlaveSupport/build.webkit.org-config/config.json: EFL Debug builder added

724
725
726
727
728
729
730
731
732
2012-04-12  George Staikos  <staikos@webkit.org>

        Enable the fullscreen API for BlackBerry.
        https://bugs.webkit.org/show_bug.cgi?id=83757

        Reviewed by Antonio Gomes.

        * Scripts/build-webkit:

733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
2012-04-12  Simon Pena  <spena@igalia.com>

        [GTK] Test runner crashes without recent versions of pulseaudio-utils
        https://bugs.webkit.org/show_bug.cgi?id=83774

        Reviewed by Philippe Normand.

        Besides checking that pactl is available, check also that its output
        is the expected one, and handle gracefully when it isn't, when
        trying to unload pulseaudio modules.

        * Scripts/webkitpy/layout_tests/port/gtk.py:
        (GtkPort._unload_pulseaudio_module):
        (GtkPort._restore_pulseaudio_module):

748
749
750
751
752
753
754
755
756
757
758
2012-03-05  Pierre Rossi  <pierre.rossi@gmail.com>

        [Qt] Use QRawFont when building with Qt 5
        https://bugs.webkit.org/show_bug.cgi?id=78001

        Flip the QRawFont switch for Qt 5.

        Reviewed by Simon Hausmann.

        * qmake/mkspecs/features/features.prf:

759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
2012-04-11  Vivek Galatage  <vivekgalatage@gmail.com>

        Web Inspector: Disabling Inspector causes build failure on Windows
        https://bugs.webkit.org/show_bug.cgi?id=83557

        Reviewed by Pavel Feldman.

        The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
        This change brings all such API calls under the guard.

        * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
        * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
        (WTR):
        * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
        (LayoutTestController):
        * WebKitTestRunner/TestInvocation.cpp:
        (WTR::TestInvocation::invoke):

777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
2012-04-11  Dirk Pranke  <dpranke@chromium.org>

        Fix regression introduced in r113927.

        Unreviewed, build fix.

        I failed to rename skipped_tests() to skipped_layout_tests()
        everywhere it needed to be renamed. The unit tests didn't catch
        this because the TestPort was one of the places that didn't get
        renamed :(.

        * Scripts/webkitpy/layout_tests/controllers/manager.py:
        (Manager.parse_expectations):
        * Scripts/webkitpy/layout_tests/port/test.py:
        (TestPort.skipped_layout_tests):
        * Scripts/webkitpy/tool/commands/queries.py:
        (PrintExpectations._model):

795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
2012-04-11  Dirk Pranke  <dpranke@chromium.org>

        new-run-webkit-tests: 'webkit-patch skipped-ports' introduced bad layering
        https://bugs.webkit.org/show_bug.cgi?id=47528

        Reviewed by Adam Barth.

        The skipped-ports command has been replaced by 'webkit-patch
        print-expectations', which offers the equivalent functionality
        via 'webkit-patch print-expectations --platform \* -t skip'
        (and other features, of course).
        
        This also allows me to fix a nasty layering violation where the
        chromium port had to know about the TestExpectations objects in
        order to implement the command properly.

        Lastly, this allows me to rename skipped_tests() to
        skipped_layout_tests() to more consistent with
        skipped_perf_tests().
        
        This patch removes skips_layout_test() from the Port interface,
        because that can't be implemented without the port knowing about
        Expectations objects (and skipped-ports was the only thing using it).

        * Scripts/webkitpy/layout_tests/port/base.py:
        (Port.skipped_layout_tests):
        (Port.skipped_perf_tests):
        * Scripts/webkitpy/layout_tests/port/base_unittest.py:
        (PortTest.test_default_configuration_notfound):
        * Scripts/webkitpy/layout_tests/port/chromium.py:
        (ChromiumPort.test_expectations_overrides):
        * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
        (ChromiumPortTest.test_path_to_image_diff):
        * Scripts/webkitpy/layout_tests/port/webkit.py:
        (WebKitPort.skipped_layout_tests):
        * Scripts/webkitpy/tool/commands/queries.py:
        (execute):
        * Scripts/webkitpy/tool/commands/queries_unittest.py:
        (QueryCommandsTest.test_tree_status):

835
836
837
838
839
840
841
842
843
844
2012-04-11  Mark Rowe  <mrowe@apple.com>

        Remove a fprintf from LayoutTestController.

        This fprintf is causing 100+MB of data to be written to stderr during a single run of the tests.
        It was added for no apparent reason by Ryosuke in r113651.

        * DumpRenderTree/LayoutTestController.cpp:
        (LayoutTestController::redirectionDestinationForURL):

845
846
847
848
849
850
851
852
853
854
2012-04-11  Nico Weber  <thakis@chromium.org>

        [mac] Suppress deprecation warning for GlobalToLocal in the carbon parts of the test plugin.
        https://bugs.webkit.org/show_bug.cgi?id=83709

        Reviewed by Anders Carlsson.

        * DumpRenderTree/TestNetscapePlugIn/main.cpp:
        (handleEventCarbon):

855
856
857
858
859
860
861
862
863
2012-04-11  Rafael Brandao  <rafael.lobo@openbossa.org>

        Adding myself to committers.py
        https://bugs.webkit.org/show_bug.cgi?id=83711

        Unreviewed update to committers.py.

        * Scripts/webkitpy/common/config/committers.py:

864
865
866
867
868
869
870
871
872
873
874
875
876
2012-04-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>

        [EFL] LayoutTestController needs implementation of pageProperty
        https://bugs.webkit.org/show_bug.cgi?id=82449

        Add missing implementation pageProperty to EFL's LayoutTestController
        in order to unskip printing/page-rule-selection.html

        Reviewed by Antonio Gomes.

        * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
        (LayoutTestController::pageProperty):

877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
2012-04-11  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r113836.
        http://trac.webkit.org/changeset/113836
        https://bugs.webkit.org/show_bug.cgi?id=83705

        Broke all the WebKit2 inspector tests (Requested by andersca
        on #webkit).

        * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
        * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
        (WTR::LayoutTestController::showWebInspector):
        (WTR::LayoutTestController::closeWebInspector):
        (WTR::LayoutTestController::evaluateInWebInspector):
        (WTR::LayoutTestController::setJavaScriptProfilingEnabled):
        * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
        (LayoutTestController):
        * WebKitTestRunner/TestInvocation.cpp:
        (WTR::TestInvocation::invoke):

897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
2012-04-11  Vivek Galatage  <vivekgalatage@gmail.com>

        Web Inspector: Disabling Inspector causes build failure on Windows
        https://bugs.webkit.org/show_bug.cgi?id=83557

        Reviewed by Pavel Feldman.

        The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
        This change brings all such API calls under the guard.

        * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
        * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
        (WTR):
        * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
        (LayoutTestController):
        * WebKitTestRunner/TestInvocation.cpp:
        (WTR::TestInvocation::invoke):

915
916
917
918
919
920
921
922
923
924
925
926
2012-04-11  No'am Rosenthal  <noam.rosenthal@nokia.com>

        [Qt][WK2] Manage graphics buffers in the web process
        https://bugs.webkit.org/show_bug.cgi?id=78675
 
        Make graphics surface available only for Qt 5, attempting to fix
        the Qt-mac build.

        Unreviewed build fix.

        * qmake/mkspecs/features/features.prf:

927
928
929
930
931
932
933
2012-04-11  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, GTK NRWT follow-up fix after r113849.

        * Scripts/webkitpy/layout_tests/port/gtk.py:
        (GtkPort._unload_pulseaudio_module): Exit early if pactl is not found.

934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
2012-04-11  Simon Pena  <spena@igalia.com>

        [GTK] media/event-attributes.html fails
        https://bugs.webkit.org/show_bug.cgi?id=71662

        Reviewed by Philippe Normand.

        PulseAudio's module "module-stream-restore" allows saving the volume
        of a stream, restoring it the next time it runs.
        This affects the tests, since DumpRenderTree's volume settings are
        saved between test runs, and tests relying on specific volume values
        would miss some volumeChange events (or get additional ones).

        This patch hooks on the existing GtkPort setup_test_run method and
        creates a new clean_up_test_run method, so PulseAudio's module is
        unloaded (if found) before running the tests, and restored (if it
        was there previously) after they finished, ensuring the tests run in
        the right environment.

        * Scripts/webkitpy/layout_tests/controllers/manager.py:
        (Manager._clean_up_run): Invoke the port implementation of
        clean_up_test_run.
        * Scripts/webkitpy/layout_tests/port/base.py:
        (Port.clean_up_test_run): Add an empty implementation of
        clean_up_test_run.
        * Scripts/webkitpy/layout_tests/port/gtk.py:
        (GtkPort._unload_pulseaudio_module): Unloads the offending
        pulseaudio module, if found.
        (GtkPort):
        (GtkPort._restore_pulseaudio_module): Restores the offending
        pulseaudio module, if it was there previously.
        (GtkPort.setup_test_run): Calls _unload_pulseaudio_module.
        (GtkPort.clean_up_test_run): Calls _restore_pulseaudio_module.

968
969
970
971
972
973
974
975
976
977
2012-04-11  Andras Becsi  <andras.becsi@nokia.com>

        Fix the build with gcc 4.7.0
        https://bugs.webkit.org/show_bug.cgi?id=83584

        Reviewed by Alexey Proskuryakov.

        * qmake/mkspecs/features/unix/default_post.prf:
        The -fuse-ld=gold option is not supported with upstream gcc.

978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
2012-04-11  Ryosuke Niwa  <rniwa@webkit.org>

        Refactor PerfTestRunner to include file extensions in test names
        https://bugs.webkit.org/show_bug.cgi?id=83677

        Reviewed by Hajime Morita.

        Move the logic that extracts the test name from _process_parser_test_result to _collect_tests.

        * Scripts/webkitpy/performance_tests/perftestsrunner.py:
        (PerfTestsRunner._collect_tests):
        (PerfTestsRunner._run_tests_set):
        (PerfTestsRunner._process_parser_test_result): Still replace "/" by ": " to keep the output format.
        We can make the said behavior change by simply removing "test_name = re.sub(r'\.\w+$', '', test_name)" here.
        (PerfTestsRunner._run_single_test):
        * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
        (run_test):
        (_tests_for_runner):
        (test_run_test_set):
        (test_run_test_set_kills_drt_per_run):
        (test_run_test_pause_before_testing):
        (test_run_test_set_for_parser_tests):
        (test_collect_tests):
        (test_collect_tests_with_skipped_list):

1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
2012-04-11  Vivek Galatage  <vivekgalatage@gmail.com>

        Web Inspector: Disabling Inspector causes build failure on Windows
        https://bugs.webkit.org/show_bug.cgi?id=83557

        Reviewed by Pavel Feldman.

        The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
        This change brings all such API calls under the guard.

        * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
        * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
        (WTR):
        * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
        (LayoutTestController):
        * WebKitTestRunner/TestInvocation.cpp:
        (WTR::TestInvocation::invoke):

1021
1022
1023
1024
1025
1026
1027
2012-04-10  Kent Tamura  <tkent@chromium.org>

        Unreviewed. Using tkent+wkapi@ for ChromiumPublicApi notifications.

        * Scripts/webkitpy/common/config/watchlist:
        * Scripts/webkitpy/common/config/committers.py: Add tkent+wkapi@ to pass the style checker.

1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
2012-04-10  Dirk Pranke  <dpranke@chromium.org>

        If NRWT gets killed halfway through a run, it incorrectly reports tests that weren't run as passes
        https://bugs.webkit.org/show_bug.cgi?id=82799

        Reviewed by Ojan Vafai.

        The tests we were skipping in _mark_interrupted_tests_as_skipped
        had incorrectly-constructed TestResults, and so they were not
        being treated as failures. The JSON generator doesn't record
        tests that are passed or skiped in incremental_results, so you
        couldn't tell these tests were being skipped at all.

        This change changes _mark_interrupted_tests_as_skipped() to
        treat the skipped tests as failures; this is arguably still
        incorrect but is minimally invasive for now. We probably need to
        revisit how we are uploading information about tests that are
        skipped and passed altogether in a separate change.

        This change also cleans up a couple of other nits that were
        unnecessary or broken in this same code path.

        * Scripts/webkitpy/layout_tests/controllers/manager.py:
        (Manager._mark_interrupted_tests_as_skipped):
        (Manager._upload_json_files): Deletes the check for
        chromium-mac-leopard (as it is no longer necessary).
        * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
        (JSONLayoutResultsGenerator.__init__): Here we were
        recalculating the failure type unnecessarily.
        * Scripts/webkitpy/layout_tests/models/test_failures.py:
        (determine_result_type):
        (FailureEarlyExit): Adds a new failure type so we can tell what
        happened.
        (FailureEarlyExit.message):
        * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
        (MainTest.test_exit_after_n_failures_upload): Add more checks to
        ensure that we are recording the SKIP correctly; this is less
        than ideal, because we can't actually test the contents of
        incremental_results.json. We should fix that at some point.

1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
2012-04-10  Dirk Pranke  <dpranke@chromium.org>

        make chromium layout tests not depend on platform/win, platform/mac-leopard, or platform/mac-snowleopard
        https://bugs.webkit.org/show_bug.cgi?id=83401

        Reviewed by Adam Barth.

        Last patch in the series - no longer look in mac-leopard,
        mac-snowleopard, or mac-lion.

        * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
        (ChromiumMacPort):
        * TestResultServer/static-dashboards/flakiness_dashboard.html:

1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
2012-04-10  Dirk Pranke  <dpranke@chromium.org>

        webkit-patch: add a print-expectations command
        https://bugs.webkit.org/show_bug.cgi?id=83347

        Reviewed by Adam Barth.

        This command will print the expected results for a given set of
        tests on a given set of ports matching a given set of keywords.

        Example output (printing all the tests not expected to pass, and their
        expected results, on a Mac):

        $ webkit-patch print-expectations -x pass fast/html
        // For mac-snowleopard
        fast/html/details-open4.html = TEXT
        fast/html/details-open2.html = TEXT
        fast/html/details-no-summary4.html = TEXT
        fast/html/details-open-javascript.html = TEXT
        $

        You can also print full test-expectatons.txt lines using --full and a
        CSV-style report (which can be useful for post-processing) using --csv.

        It will replace the 'skipped-files' command (which will be
        removed in a subsequent patch) and is a more general (and
        cleaner and properly layered) solution.

        Also add an update() command to MockOptions() to make overriding keywords easier.

        * Scripts/webkitpy/layout_tests/models/test_expectations.py:
        (TestExpectationSerializer.to_string):
        (TestExpectationSerializer):
        (TestExpectationSerializer.to_csv):
        (TestExpectationSerializer._format_result):
        (TestExpectationLine.create_passing_expectation):
        (TestExpectationsModel.get_test_set_for_keyword):
        (TestExpectationsModel.has_keyword):
        (TestExpectations.model):
        * Scripts/webkitpy/tool/commands/queries.py:
        (execute):
        (PrintExpectations):
        (PrintExpectations.__init__):
        (PrintExpectations.execute):
        (PrintExpectations._filter_tests):
        (PrintExpectations._format_lines):
        (PrintExpectations._model):
        * Scripts/webkitpy/tool/commands/queries_unittest.py:
        (TestPrintExpectations): Added.
        * Scripts/webkitpy/tool/mocktool.py:
        (MockOptions):
        (MockOptions.__init__):
        (MockOptions.update): Added.

1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
2012-04-10  Dirk Pranke  <dpranke@chromium.org>

        webkitpy: refactor handling of --platform and related options
        https://bugs.webkit.org/show_bug.cgi?id=83525

        Reviewed by Adam Barth.

        This change moves to centralize handling of --platform, --debug,
        --gtk, and other similar flags into a central place next to the
        code that actually uses those flags in PortFactory to get the
        right Port object.

        * Scripts/webkitpy/layout_tests/port/__init__.py:
        * Scripts/webkitpy/layout_tests/port/factory.py:
        (port_options):
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        (parse_args):
        * Scripts/webkitpy/tool/commands/queries.py:
        (PrintBaselines.__init__):

1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
2012-04-10  Ojan Vafai  <ojan@chromium.org>

        Add a chromeless view to the individual tests view
        https://bugs.webkit.org/show_bug.cgi?id=83541

        Reviewed by Daniel Bates.

        This is the view suitable to inlining in other contexts (e.g. garden-o-matic).

        * TestResultServer/static-dashboards/flakiness_dashboard.html:
        * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
        (testHtmlForIndividualTestOnAllBuilders):
        (testHtmlForIndividualTestOnAllBuildersWithChromeNonexistant):
        (testHtmlForIndividualTestOnAllBuildersWithChrome):
        (testHtmlForIndividualTestOnAllBuildersWithChromeWebkitMaster):
        (testHtmlForIndividualTests):
        (htmlEscape):
        (runTests):

1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
2012-04-10  Dirk Pranke  <dpranke@chromium.org>

        remove 'win' from chromium-win, chromium-linux fallback paths
        https://bugs.webkit.org/show_bug.cgi?id=83613

        Reviewed by Ojan Vafai.

        The chromium ports no longer need to look at the apple 'win'
        directory for baseline results.

        Also remove the old '-gpu-' entries from the flakiness dashboard
        map since I'm touching lines nearby.

        * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
        (ChromiumLinuxPort):
        * Scripts/webkitpy/layout_tests/port/chromium_win.py:
        (ChromiumWinPort):
        * TestResultServer/static-dashboards/flakiness_dashboard.html:

1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
2012-04-10  No'am Rosenthal  <noam.rosenthal@nokia.com>

        [Qt][WK2] Manage graphics buffers in the web process
        https://bugs.webkit.org/show_bug.cgi?id=78675

        Enable graphics surfaces on Mac for Qt.

        Reviewed by Kenneth Rohde Christiansen.

        * qmake/mkspecs/features/features.prf:

1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
2012-04-10  Patrick Gansterer  <paroga@webkit.org>

        [CMake] Enable USE_FOLDERS property
        https://bugs.webkit.org/show_bug.cgi?id=83571

        Reviewed by Daniel Bates.

        Setting the FOLDER property on targets gives more structure
        to the generated Visual Studio solutions.
        This does not affect other CMake generators.

        * DumpRenderTree/efl/CMakeLists.txt:
        * EWebLauncher/CMakeLists.txt:
        * WinCELauncher/CMakeLists.txt:

1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
2012-04-10  David Dorwin  <ddorwin@chromium.org>

        Add Encrypted Media Extensions methods to HTMLMediaElement
        https://bugs.webkit.org/show_bug.cgi?id=82971

        Reviewed by Adam Barth.

        The extensions are behind the ENABLE(ENCRYPTED_MEDIA) feature define.
        Implementation is based on v0.1 of the draft proposal at
        http://dvcs.w3.org/hg/html-media/raw-file/tip/encrypted-media/encrypted-media.html.

        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::TestShell):

1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
2012-04-10  Christophe Dumez  <christophe.dumez@intel.com>

        [EFL][DRT] Catch the "title,changed" signal
        https://bugs.webkit.org/show_bug.cgi?id=82174

        Reviewed by Gustavo Noronha Silva.

        EFL's DumpRenderTree now catches the "title,changed" signal, and
        prints out the needed information.

        * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
        (DumpRenderTreeChrome::onTitleChanged):

1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
2012-04-10  Christophe Dumez  <christophe.dumez@intel.com>

        [EFL] DRT should support LayoutTestController's willSendRequestReturnsNull()
        https://bugs.webkit.org/show_bug.cgi?id=82443

        Reviewed by Philippe Normand.

        EFL's DRT needs to support LayoutTestController's
        willSendRequestReturnsNull() and return NULL when expected. This
        allows for several tests to be removed from the skip list.

        * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
        (DumpRenderTreeChrome::onWillSendRequest):

1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
2012-04-10  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>

        [EFL] LayoutTestController needs implementation of addUserStyleSheet
        https://bugs.webkit.org/show_bug.cgi?id=82446

        Adding missing implementation addUserStyleSheet to EFL's LayoutTestController 
        so that we can unskip related tests from the skip list. 

        Reviewed by Antonio Gomes.

        * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
        (LayoutTestController::addUserStyleSheet): Implemented.

1274
1275
1276
1277
1278
1279
1280
1281
2012-04-10  Philip Rogers  <pdr@google.com>

        Adding myself to committers.py!

        Unreviewed update to committers.py.

        * Scripts/webkitpy/common/config/committers.py:

1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
2012-04-10  Dinu Jacob  <dinu.jacob@nokia.com>

        [Qt][WK2] Title in MiniBrowser is not updated for a page with no title
        https://bugs.webkit.org/show_bug.cgi?id=82483

        Reviewed by Kenneth Rohde Christiansen.

        Set window title to default if there is no page title.

        * MiniBrowser/qt/BrowserWindow.cpp:
        (BrowserWindow::BrowserWindow):
        (BrowserWindow::onTitleChanged):
        * MiniBrowser/qt/BrowserWindow.h:
        (BrowserWindow):

1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
2012-03-23  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>

        [Qt][WK2] Implement PageClient::isViewWindowActive()
        https://bugs.webkit.org/show_bug.cgi?id=81143

        Reviewed by Kenneth Rohde Christiansen.

        Fix the WrapperWindow from our PlatformWebView
        so it correctly creates the platform related
        stuff for QWindow, which is not created unless
        QWindow::setVisible() or QWindow::show() are called.

        * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
        (WTR::PlatformWebView::PlatformWebView):

1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
2012-04-10  Balazs Kelemen  <kbalazs@webkit.org>

        [Qt][WK2] TestNetscapePlugin is broken
        https://bugs.webkit.org/show_bug.cgi?id=83024

        Reviewed by Csaba Osztrogonác.

        * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
        Fix X11 availability check. embedded is always true with QPA.
        * Tools.pro:
        Build the test plugin if plugins are enabled for WebKit2.
        * qmake/mkspecs/features/features.prf:
        * qmake/mkspecs/features/functions.prf:
        Added a convenience function to determine availability
        of X11 libraries.

1328
1329
1330
1331
1332
1333
2012-04-10  Patrick Gansterer  <paroga@webkit.org>

        [WIN] Fix build without precompiled header.

        * DumpRenderTree/cg/ImageDiffCG.cpp: Define max as max as we do for min.

1334
1335
1336
1337
1338
1339
2012-04-10  Arko Saha  <arko@motorola.com>

        Unreviewed: adding myself to committers.py.

        * Scripts/webkitpy/common/config/committers.py:

1340
1341
1342
1343
1344
1345
2012-04-09  Kaustubh Atrawalkar  <kaustubh@motorola.com>

        Unreviewed: adding myself to committers.py.

        * Scripts/webkitpy/common/config/committers.py:

1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
2012-04-09  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r113656.
        http://trac.webkit.org/changeset/113656
        https://bugs.webkit.org/show_bug.cgi?id=83542

        test is broken on chromium-win (Requested by simonjam on
        #webkit).

        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::dispatchIntent):

1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
2012-04-09  Takashi Toyoshima  <toyoshim@chromium.org>

        Update pywebsocket to 0.7.4.
        https://bugs.webkit.org/show_bug.cgi?id=83461

        Reviewed by Kent Tamura.

        This version supports TLS by using ssl in addition to pyOpenSSL.
        Other functional difrerences from 0.7.2 are:
         - strict Sec-WebSocket-Key validation conforming RFC 4648
         - compression ratio logging in debug

        * Scripts/webkitpy/thirdparty/__init__.py:
        (AutoinstallImportHook._install_pywebsocket):

1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
2012-04-09  Dirk Pranke  <dpranke@chromium.org>

        add a webkit-patch print-baselines command
        https://bugs.webkit.org/show_bug.cgi?id=83348

        Reviewed by Adam Barth.

        This adds a simple 'print-baselines' command to webkit-patch
        that can be used in one of two forms: to print where the
        baselines for a given test (or set of tests) on a single port
        will be found, or to generate a report for multiple ports.

        Example of the former:

        $ webkit-patch print-baselines fast/html/keygen.html
        // For mac-snowleopard
        platform/mac/fast/html/keygen-expected.txt
        platform/mac/fast/html/keygen-expected.png
        $

        The latter is most useful for finding out which fallback dirs are
        used by which ports for which tests, for example,
        'chromium-mac-leopard' uses 100 results from 'platform/mac/leopard'.
        No example output is given because the reports are pretty wordy :).

        * Scripts/webkitpy/layout_tests/port/base.py:
        (Port.baseline_extensions): Added.
        (Port.expected_baseline_dict): Added.
        * Scripts/webkitpy/tool/commands/queries.py:
        (PrintBaselines):
        (PrintBaselines.__init__):
        (PrintBaselines.execute):
        (PrintBaselines._print_baselines):
        (PrintBaselines._platform_for_path):

1408
1409
1410
1411
1412
1413
2012-04-09  Florin Malita  <fmalita@chromium.org>

        Unreviewed: adding myself to committers.py.

        * Scripts/webkitpy/common/config/committers.py:

1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
2012-04-09  Ming Xie  <mxie@rim.com>

        [BlackBerry] Allow simulator to use GLES2 acceleration
        https://bugs.webkit.org/show_bug.cgi?id=81672

        Reviewed by Rob Buis.

        * Scripts/webkitdirs.pm:
        (blackberryCMakeArguments):

1424
1425
1426
1427
1428
1429
1430
1431
1432
2012-04-09  Dana Jansens  <danakj@chromium.org>

        Mark myself as a committer
        https://bugs.webkit.org/show_bug.cgi?id=83510

        Reviewed by Adrienne Walker.

        * Scripts/webkitpy/common/config/committers.py:

1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
2012-04-09  Dirk Pranke  <dpranke@chromium.org>

        nrwt is failing to upload test results on the chromium-mac-leopard bots
        https://bugs.webkit.org/show_bug.cgi?id=83230

        Unreviewed, build fix.

        It looks like the change in r113399 to use the per-request
        timeout variable didn't actually work, so I am removing the
        timeout code altogether and counting on the idea that upload
        just isn't likely to take that long and the timeouts and
        retransmits are largely unused and largely unnecessary. We'll
        see if this breaks anywhere else.

        * Scripts/webkitpy/common/net/file_uploader.py:
        (FileUploader.__init__):
        (FileUploader._upload_data.callback):
        (FileUploader):

1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
2012-04-09  Rob Buis  <rbuis@rim.com>

        [BlackBerry] Cleanup LayoutTestControllerBlackBerry.cpp
        https://bugs.webkit.org/show_bug.cgi?id=83469

        Reviewed by Dirk Schulze.

        Remove WTF:: prefixes and fix a warning with the length variable.

        * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
        (jsStringRefToWebCoreString):
        (LayoutTestController::execCommand):
        (LayoutTestController::isCommandEnabled):
        (LayoutTestController::setUserStyleSheetLocation):
        (LayoutTestController::counterValueForElementById):
        (LayoutTestController::overridePreference):
        (LayoutTestController::setMockGeolocationError):
        (LayoutTestController::findString):

1471
1472
1473
1474
1475
1476
2012-04-09  Patrick Gansterer  <paroga@webkit.org>

        Build fix for WinCE after r113570.

        * Scripts/build-webkit: Do not use FastMalloc for WinCE.

1477
1478
1479
1480
1481
1482
1483
1484
1485
2012-04-09  Eric Carlson  <eric.carlson@apple.com>

        Subscribe eric.carlson@apple.com to Media-related changes
        https://bugs.webkit.org/show_bug.cgi?id=83421

        Reviewed by Dan Bernstein.

        * Scripts/webkitpy/common/config/watchlist:

1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
2012-04-09  Martin Robinson  <mrobinson@igalia.com>

        check-webkit-style should ignore NULL usage in gtk_style_context_get_style
        https://bugs.webkit.org/show_bug.cgi?id=83412

        Reviewed by David Levin.

        Accept NULL as an argument for gtk_style_context_get_style, because it's
        used as a sentinel in a variable argument list. 

        * Scripts/webkitpy/style/checkers/cpp.py:
        (check_for_null): Add an exception.
        * Scripts/webkitpy/style/checkers/cpp_unittest.py:
        (WebKitStyleTest.test_null_false_zero): Add a test for the exception.

1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
2012-04-09  Dirk Pranke  <dpranke@chromium.org>

        webkitpy: use the filesystem object properly in fileuploader
        https://bugs.webkit.org/show_bug.cgi?id=83326

        Reviewed by Adam Barth.

        We should be using the filesystem object rather than the codecs
        object.

        * Scripts/webkitpy/common/net/file_uploader.py:
        (FileUploader.upload_as_multipart_form_data):

1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
2012-04-09  Eric Seidel  <eric@webkit.org>

        Enable webkit_unit_tests for commit queue and EWS while tracking failures
        https://bugs.webkit.org/show_bug.cgi?id=83329

        Unreviewed.  Add a missing import to unbreak all the Chromium EWS/CQ bots. :)

        line 62, in _create_unit_test_results
         return UnitTestResults.results_from_string(results_xml)
         NameError: global name 'UnitTestResults' is not defined

        * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
        * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
        (LayoutTestResultsReaderTest.test_create_unit_test_results):

1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
2012-04-08  Adam Barth  <abarth@webkit.org>

        The port object is missing unit_tests_results_path
        https://bugs.webkit.org/show_bug.cgi?id=83448

        Unreviewed.

        This is causing the cr-linux-ews to throw an exception.

        * Scripts/webkitpy/common/config/ports.py:
        (DeprecatedPort.unit_tests_results_path):

1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
2012-04-07  Patrick Gansterer  <paroga@webkit.org>

        [CMake] Cleanup WTF include directories
        https://bugs.webkit.org/show_bug.cgi?id=82716

        Reviewed by Eric Seidel.

        * DumpRenderTree/efl/CMakeLists.txt:
        * WinCELauncher/CMakeLists.txt:

1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
2012-04-07  Rob Buis  <rbuis@rim.com>

        [BlackBerry] Add Battery Status API support
        https://bugs.webkit.org/show_bug.cgi?id=82615

        Reviewed by George Staikos.

        Enable BATTERY_STATUS.

        * Scripts/build-webkit:

1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
2012-04-06  Ami Fischman  <fischman@chromium.org>

        Subscribe feature-media-reviews@c.o to Media-related changes.
        https://bugs.webkit.org/show_bug.cgi?id=83397

        Reviewed by David Levin.

        * Scripts/webkitpy/common/config/committers.py:
        * Scripts/webkitpy/common/config/watchlist:

1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
2012-04-06  Adrienne Walker  <enne@google.com>

        [chromium] Add virtual test suite for threaded compositing
        https://bugs.webkit.org/show_bug.cgi?id=82263

        Reviewed by James Robinson.

        Add compositing/visibility as a virtual test suites to test threaded
        compositing with. This is a reasonable smoke test of 9 tests, none of
        which have any expectations in the non-threaded case.

        To fix many of the remaining tests in this virtual test suite, there
        will need to be some serious refactoring to merge the conflict between
        the way CCScheduler wants to draw frames and the way DRT also wants to
        control things. So, in the short term, enable a few simple tests that
        are known to be passing.

        * Scripts/webkitpy/layout_tests/port/chromium.py:
        (ChromiumPort.virtual_test_suites):

1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
2012-04-06  Enrica Casucci  <enrica@apple.com>

        Provide Obj-C private API to simplify markup.
        https://bugs.webkit.org/show_bug.cgi?id=83334
        <rdar://problem/11033861>

        Reviewed by Sam Weinig.

        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
        * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm: Added.
        (-[SimplifyMarkupTest webView:didFinishLoadForFrame:]):
        * TestWebKitAPI/Tests/mac/verboseMarkup.html: Added.

1605
1606
1607
1608
1609
1610
1611
1612
1613
1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
1624
1625
1626
1627
1628
1629
1630
1631
1632
1633
1634
1635
1636
1637
2012-04-06  Dirk Pranke  <dpranke@chromium.org>

        new-run-webkit-tests: fix bugs in 'mock' drt implementation
        https://bugs.webkit.org/show_bug.cgi?id=83341

        Reviewed by Eric Seidel.

        The current implementation crashed in some circumstances for
        reference tests and files that were missing expected results.
        This patch fixes those cases and adds more unit tests; it is a
        precursor to adding unit tests each port that actually uses this
        code, in order to get better coverage of the port/*
        implementations.

        * Scripts/webkitpy/layout_tests/port/mock_drt.py:
        (parse_options):
        (MockDRT.input_from_line):
        (MockDRT.output_for_test):
        (MockDRT.run_one_test):
        (MockChromiumDRT.input_from_line):
        (MockChromiumDRT.output_for_test):
        (MockChromiumDRT.run_one_test):
        * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
        (MockDRTTest.make_input_output):
        (MockDRTTest.expected_output):
        (MockDRTTest):
        (MockDRTTest.assertTest):
        (MockDRTTest.test_missing_image):
        (MockDRTTest.test_missing_text):
        (MockDRTTest.test_reftest_match):
        (MockDRTTest.test_reftest_mismatch):
        (MockChromiumDRTTest.expected_output):

1638
1639
1640
1641
1642
1643
1644
1645
1646
1647
1648
1649
1650
1651
1652
1653
1654
1655
1656
1657
1658
1659
1660
1661
1662
1663
1664
1665
1666
1667
1668
1669
1670
1671
1672
1673
1674
1675
1676
1677
1678
1679
1680
1681
1682
1683
1684
1685
1686
1687
1688
1689
1690
1691
1692
1693
1694
1695
1696
1697
1698
1699
1700
2012-04-06  James Robinson  <jamesr@chromium.org>

        Enable webkit_unit_tests for commit queue and EWS while tracking failures
        https://bugs.webkit.org/show_bug.cgi?id=83329

        Reviewed by Adam Barth.

        This adds a step to parse XML output from webkit_unit_tests and consider regressions in the PatchAnalysisTask so
        the commit queue and EWS can reject patches that cause regressions.

        * Scripts/webkitpy/common/config/ports.py:
        (ChromiumPort.run_webkit_unit_tests_command):
        * Scripts/webkitpy/common/config/ports_mock.py:
        (MockPort.unit_tests_results_path):
        * Scripts/webkitpy/common/net/layouttestresults.py:
        (LayoutTestResults.__init__):
        (LayoutTestResults.failing_tests):
        (LayoutTestResults):
        (LayoutTestResults.add_unit_test_failures):
        * Scripts/webkitpy/common/net/unittestresults.py: Copied from Tools/Scripts/webkitpy/tool/steps/runtests_unittest.py.
        (UnitTestResults):
        (UnitTestResults.results_from_string):
        * Scripts/webkitpy/common/net/unittestresults_unittest.py: Added.
        (UnitTestResultsTest):
        (UnitTestResultsTest.test_nostring):
        (UnitTestResultsTest.test_emptystring):
        (UnitTestResultsTest.test_nofailures):
        (test_onefailure):
        (test_multiple_failures_per_test):
        * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
        (MockCommitQueue.test_results):
        (MockCommitQueue.archive_last_test_results):
        (FailingTestCommitQueue.test_results):
        (test_flaky_test_failure):
        (test_failed_archive):
        * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
        (LayoutTestResultsReader._create_unit_test_results):
        (LayoutTestResultsReader.results):
        * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
        (LayoutTestResultsReaderTest.test_missing_layout_test_results):
        * Scripts/webkitpy/tool/bot/patchanalysistask.py:
        (PatchAnalysisTaskDelegate.test_results):
        (PatchAnalysisTaskDelegate.archive_last_test_results):
        (PatchAnalysisTask._test):
        (PatchAnalysisTask._build_and_test_without_patch):
        (PatchAnalysisTask._test_patch):
        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
        (AbstractEarlyWarningSystem.test_results):
        (AbstractEarlyWarningSystem.archive_last_test_results):
        * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
        (EarlyWarningSytemTest._test_testing_ews):
        * Scripts/webkitpy/tool/commands/queues.py:
        (CommitQueue.test_results):
        (CommitQueue.archive_last_test_results):
        * Scripts/webkitpy/tool/commands/queues_unittest.py:
        (CommitQueueTest.test_commit_queue):
        (test_rollout):
        (test_manual_reject_during_processing):
        * Scripts/webkitpy/tool/steps/runtests.py:
        (RunTests.run):
        * Scripts/webkitpy/tool/steps/runtests_unittest.py:
        (RunTestsTest.test_webkit_run_unit_tests):

1701
1702
1703
1704
1705
1706
1707
1708
1709
1710
1711
2012-04-06  Aaron Colwell  <acolwell@chromium.org>

        Enable MediaSource feature for DumpRenderTree so
        MediaSource LayoutTests will pass for Chromium.
        https://bugs.webkit.org/show_bug.cgi?id=83053

        Reviewed by Dimitri Glazkov.

        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::TestShell):

1712
1713
1714
1715
1716
1717
1718
1719
2012-04-06  George Staikos  <staikos@webkit.org>

        Turn on vibration support for BlackBerry.

        Reviewed by Rob Buis.

        * Scripts/build-webkit:

1720
1721
1722
1723
1724
1725
1726
1727
2012-04-06  Dan Bernstein  <mitz@apple.com>

        <rdar://problem/10912476> HiDPI: Have canvas use a hidpi backing store, but downsample upon access

        Reviewed by Sam Weinig.

        * Scripts/build-webkit: Added high-dpi-canvas option to control ENABLE_HIGH_DPI_CANVAS.

1728
1729
1730
1731
1732
1733
1734
1735
1736
1737
1738
1739
1740
1741
1742
1743
1744
1745
1746
1747
1748
1749
1750
2012-04-05  Dirk Pranke  <dpranke@chromium.org>

        nrwt is failing to upload test results on the chromium-mac-leopard bots
        https://bugs.webkit.org/show_bug.cgi?id=83230

        Reviewed by Ojan Vafai.

        This should fix things properly; FileUploader() was setting the
        socket default timeout value, and apparently that doesn't work
        properly with urllib. Also, the class had a bad try/finally
        block that was causing the exceptions to be swallowed :(.

        * Scripts/webkitpy/common/net/file_uploader.py:
        (FileUploader.__init__):
        (FileUploader._upload_data.callback):
        (FileUploader):
        (FileUploader._upload_data):
        * Scripts/webkitpy/common/net/networktransaction.py:
        (NetworkTimeout.__str__):
        (NetworkTransaction.run):
        * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
        (JSONResultsGeneratorBase.upload_json_files):

1751
1752
1753
1754
1755
1756
1757
1758
1759
1760
1761
1762
2012-04-05  Patrick Gansterer  <paroga@webkit.org>

        [Qt] Correct <wtf/*.h> include paths.
        https://bugs.webkit.org/show_bug.cgi?id=83270

        Reviewed by Eric Seidel.

        Modify the #include declerations so that the
        wtf types are included using the full path.

        * WebKitTestRunner/qt/TestInvocationQt.cpp:

1763
1764
1765
1766
1767
1768
1769
1770
1771
1772
1773
1774
1775
1776
1777
1778
2012-04-05  Philippe Normand  <pnormand@igalia.com>

        gtk_unittest.GtkPortTest.test_get_crash_log failing on windows
        https://bugs.webkit.org/show_bug.cgi?id=83176

        Reviewed by Tony Chang.

        Refactored the test to use os.path.join() to specify the
        core_pattern value of the empty crash log mock.

        * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
        (GtkPortTest):
        (GtkPortTest.assertLinesEqual):
        (GtkPortTest.test_get_crash_log):
        (_mock_gdb_output):

1779
1780
1781
1782
1783
1784
1785
1786
1787
1788
1789
1790
1791
1792
2012-04-05  Csaba Osztrogonác  <ossy@webkit.org>

        [Qt] Fix includes after QtDeclarative -> QtQML renaming
        https://bugs.webkit.org/show_bug.cgi?id=82195

        Relanding r112651, because Qt5 is updated everywhere.

        * MiniBrowser/qt/BrowserWindow.cpp:
        (BrowserWindow::updateVisualMockTouchPoints):
        * MiniBrowser/qt/main.cpp:
        * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
        (WTR::WrapperWindow::handleStatusChanged):
        * qmake/mkspecs/features/unix/default_post.prf:

1793
1794
1795
1796
1797
1798
1799
1800
1801
1802
1803
1804
1805
1806
1807
2012-04-05  Pierre Rossi  <pierre.rossi@gmail.com>

        [Qt] WK1/WK2 layout test results are diverging
        https://bugs.webkit.org/show_bug.cgi?id=82720

        The resolving of default font families was altered in Qt5.
        This directly affects the font picked by DRT for layout
        tests. Since we want to keep the Qt4 and Qt5 results in line,
        we can trick DRT in picking the same font as before for now.

        Reviewed by Csaba Osztrogonác.

        * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
        (WebKit::initializeTestFonts):

1808
1809
1810
1811
1812
1813
1814
1815
1816
1817
1818
1819
2012-04-05  Kinuko Yasuda  <kinuko@chromium.org>

        Expose DataTransferItem.getAsEntry() to allow users access dropped files as FileEntry
        https://bugs.webkit.org/show_bug.cgi?id=82592

        Reviewed by David Levin.

        Added filesystem hook support in EventSender.beginDragWithFiles() for DumpRenderTree.

        * DumpRenderTree/chromium/EventSender.cpp:
        (EventSender::beginDragWithFiles):

1820
1821
1822
1823
1824
1825
1826
1827
1828
1829
1830
1831
1832
1833
1834
1835
1836
1837
1838
1839
2012-04-04  Tim Horton  <timothy_horton@apple.com>

        [mac] WKTR should always keep its windows offscreen
        https://bugs.webkit.org/show_bug.cgi?id=83244
        <rdar://problem/11188764>

        Reviewed by Simon Fraser.

        We don't want to allow windows onto the main display; intercept attempts to
        change WebKitTestRunnerWindow's frame origin and prevent it from happening.

        Also keep around and respond with a new "fake" origin, in case someone is
        expecting it to change (I couldn't find any tests that expected this, however).

        * WebKitTestRunner/mac/PlatformWebViewMac.mm:
        (-[WebKitTestRunnerWindow setFrameOrigin:]):
        (-[WebKitTestRunnerWindow setFrame:display:animate:]):
        (-[WebKitTestRunnerWindow setFrame:display:]):
        (-[WebKitTestRunnerWindow frame]):

1840
1841
1842
1843
1844
1845
1846
1847
1848
1849
2012-04-04  Dirk Pranke  <dpranke@chromium.org>

        Fix typo introduced in r113271.

        Unreviewed, build fix.

        * Scripts/webkitpy/common/net/file_uploader.py:
        (FileUploader._upload_data.callback):
        (FileUploader):

1850
1851
1852
1853
1854
1855
1856
1857
1858
1859
1860
1861
1862
1863
1864
1865
1866
1867
1868
2012-04-04  Scott Graham  <scottmg@google.com>

        [Chromium, DRT] Bounds check indices on gamepadController
        https://bugs.webkit.org/show_bug.cgi?id=83192

        Invalid test data would cause bad array accesses. Add simple checks to
        ignore such invalid data.

        Reviewed by Kent Tamura.

        * DumpRenderTree/chromium/GamepadController.cpp:
        (GamepadController::connect):
        (GamepadController::disconnect):
        (GamepadController::setId):
        (GamepadController::setButtonCount):
        (GamepadController::setButtonData):
        (GamepadController::setAxisCount):
        (GamepadController::setAxisData):

1869
1870
1871
1872
1873
1874
1875
1876
1877
1878
1879
1880
1881
1882
1883
1884
1885
2012-04-04  Dirk Pranke  <dpranke@chromium.org>

        nrwt is failing to upload test results on the chromium-mac-leopard bots
        https://bugs.webkit.org/show_bug.cgi?id=83230

        Reviewed by Ojan Vafai.

        More debugging info and a possible fix - stop messing with the
        default network timeout, and don't swallow URLErrors.

        * Scripts/webkitpy/common/net/file_uploader.py:
        (FileUploader._upload_data):
        * Scripts/webkitpy/common/net/networktransaction.py:
        (NetworkTransaction.run):
        * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
        (JSONResultsGeneratorBase.upload_json_files):

1886
1887
1888
1889
1890
1891
1892
1893
1894
1895
1896
1897
1898
1899
1900
1901
2012-04-04  Dirk Pranke  <dpranke@chromium.org>

        nrwt is failing to upload test results on the chromium-mac-leopard bots
        https://bugs.webkit.org/show_bug.cgi?id=83230

        Reviewed by Ojan Vafai.

        * Scripts/webkitpy/common/net/file_uploader.py:
        (FileUploader.__init__):
        (FileUploader._upload_data.callback):
        (FileUploader):
        * Scripts/webkitpy/layout_tests/controllers/manager.py:
        (Manager._upload_json_files):
        * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
        (JSONResultsGeneratorBase.upload_json_files):

1902
1903
1904
1905
1906
1907
1908
1909
1910
1911
1912
1913
1914
1915
1916
1917
1918
1919
1920
2012-04-04  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>

        WKTR needs to implement layoutTestController.setPageVisibility()
        https://bugs.webkit.org/show_bug.cgi?id=69554

        Reviewed by Simon Fraser.

        This patch implements the layoutTestController.setPageVisibility
        so WKTR supports the Page Visibility API implementation by using InjectedBundle
        to set the visibility state directly to Page.

        * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
        * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
        (WTR::LayoutTestController::setPageVisibility):
        (WTR):
        (WTR::LayoutTestController::resetPageVisibility):
        * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
        (LayoutTestController):

1921
1922
1923
1924
1925
1926
1927
1928
1929
1930
1931
1932
1933
2012-04-04  Adam Barth  <abarth@webkit.org>

        [Chromium] TestWebKitAPI links in WebCore twice
        https://bugs.webkit.org/show_bug.cgi?id=83177

        Reviewed by Dimitri Glazkov.

        This is causing link errors in the Windows component build. This patch
        moves the dependencies a bit lower down in the dependency diagram in
        the hopes of removing the duplicate symbols.

        * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:

1934
1935
1936
1937
1938
1939
1940
1941
1942
1943
1944
1945
1946
1947
1948
1949
1950
2012-04-04  Christophe Dumez  <christophe.dumez@intel.com>

        [EFL][DRT] Catch the "resource,request,willsend" signal
        https://bugs.webkit.org/show_bug.cgi?id=82192

        Reviewed by Gustavo Noronha Silva.

        EFL's DumpRenderTree now catches the "resource,request,willsend"
        signal in order to implement the "Blocked access to external URL"
        behavior and avoid potential network-related timeouts in the tests.

        * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
        (DumpRenderTreeChrome::createView):
        (DumpRenderTreeChrome::onWillSendRequest):
        * DumpRenderTree/efl/DumpRenderTreeChrome.h:
        (DumpRenderTreeChrome):

1951
1952
1953
1954
1955
1956
1957
1958
1959
1960
1961
1962
2012-04-04  Patrick Gansterer  <paroga@webkit.org>

        [EFL][DRT] Correct <wtf/*.h> include paths.
        https://bugs.webkit.org/show_bug.cgi?id=83168

        Reviewed by Eric Seidel.

        Modify the #include declarations so that the 
        wtf types are included using the full path.

        * DumpRenderTree/efl/DumpRenderTree.cpp:

1963
1964
1965
1966
1967
1968
1969
1970
1971
1972
2012-04-04  Philippe Normand  <pnormand@igalia.com>

        gtk_unittest.GtkPortTest.test_get_crash_log failing on windows
        https://bugs.webkit.org/show_bug.cgi?id=83176

        Reviewed by Tony Chang.

        * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
        (test_get_crash_log): Skip the test on non-linux platforms.

1973
1974
1975
1976
1977
1978
1979
1980
1981
1982
1983
1984
1985
2012-04-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>

        [EFL] DRT support for computedStyleIncludingVisitedInfo
        https://bugs.webkit.org/show_bug.cgi?id=82190

        Adding missing implementation computedStyleIncludingVisitedInfo to EFL's
        LayoutTestController so that we can unskip related tests from the skip list.

        Reviewed by Antonio Gomes.

        * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
        (LayoutTestController::computedStyleIncludingVisitedInfo):

1986
1987
1988
1989
1990
1991
1992
1993
1994
2012-04-04  Raphael Kubo da Costa  <rakuco@webkit.org>

        Unreviewed; update my email address once again in the committers
        and watch list.

        * Scripts/webkitpy/common/config/committers.py: Prefer my
        webkit.org email over my FreeBSD.org one.
        * Scripts/webkitpy/common/config/watchlist: Ditto.

1995
1996
1997
1998
1999
2000
2001
2002
2003
2004
2005
2012-04-04  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>

        [Qt][WK2] QtWebKit2 should support Page Visibility API
        https://bugs.webkit.org/show_bug.cgi?id=81164

        Reviewed by Kenneth Rohde Christiansen.

        Enabling Page Visiblity API for Qt WebKit2.

        * qmake/mkspecs/features/features.prf:

2006
2007
2008
2009
2010
2011
2012
2013
2014
2015
2016
2017
2018
2019
2020
2012-04-04  Andras Becsi  <andras.becsi@nokia.com>

        [Qt][WK2] Make the WebView a subclass of Flickable
        https://bugs.webkit.org/show_bug.cgi?id=83033

        Reviewed by Kenneth Rohde Christiansen.

        Remove workaround in MiniBrowser and the ScrollIndicator
        now that the WebView is a Flickable.

        * MiniBrowser/qt/MiniBrowser.pro:
        * MiniBrowser/qt/qml/BrowserWindow.qml:
        * MiniBrowser/qt/qml/ScrollIndicator.qml:
        * WebKitTestRunner/Target.pri:

2021
2022
2023
2024
2025
2026
2027
2028
2029
2012-04-04  Csaba Osztrogonác  <ossy@webkit.org>

        REGRESSION(r113144): It made run-webkit-tests always fail
        https://bugs.webkit.org/show_bug.cgi?id=83142

        Unreviewed trivial fix after r113144.

        * Scripts/run-webkit-tests:

2030
2031
2032
2033
2034
2035
2036
2037
2038
2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>

        I really hope this is the last build fix. Apparently exec doesn't quite arguments with
        double quotations on Windows. Use system instead.

        Hopefully, this won't break anything.

        * Scripts/run-webkit-tests:

2039
2040
2041
2042
2043
2044
2045
2046
2047
2012-04-03  Keishi Hattori  <keishi@webkit.org>

        Disable ENABLE_DATALIST for now
        https://bugs.webkit.org/show_bug.cgi?id=82871

        Reviewed by Kent Tamura.

        * Scripts/build-webkit: Disabled ENABLE_DATALIST.

2048
2049
2050
2051
2052
2053
2054
2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>

        Sigh... this isn't going well. I can't even reproduce this issue locally.
        Another speculative fix.

        * Scripts/run-webkit-tests:

2055
2056
2057
2058
2059
2060
2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>

        I don't know why I'm so sloppy today. Another build fix.

        * Scripts/run-webkit-tests:

2061
2062
2063
2064
2065
2066
2067
2068
2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>

        Hopefully the last build fix for Chromium Windows.

        Explicitly execute new-run-webkit-tests and old-run-webkit-tests by python and perl.

        * Scripts/run-webkit-tests:

2069
2070
2071
2072
2073
2074
2075
2076
2077
2078
2079
2080
2081
2082
2083
2084
2085
2086
2087
2088
2089
2090
2012-04-03  Dirk Pranke  <dpranke@chromium.org>

        [Chromium] Lots of timeouts causing Mac10.6 to exit early.
        https://bugs.webkit.org/show_bug.cgi?id=83076

        Unreviewed, build fix (slightly reviewed by Simon Fraser and Eric Seidel, but not approved).

        Add logic to the apple mac and chromium mac code to not use
        too many workers; it looks like the xserves (and possibly mac
        pros) count hyperthreaded cores when they really shouldn't and
        we end up using too many workers at a time; this leads to tests
        thrashing and timing out.

        This change is a temporary fix to make the bots happy while I
        look into more profiling and other fixes.

        * Scripts/webkitpy/layout_tests/port/mac.py:
        (ChromiumMacPort.default_child_processes):

        * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
        (ChromiumMacPort.default_child_processes):

2091
2092
2093
2094
2095
2096
2097
2098
2099
2100
2101
2102
2103
2104
2105
2106
2107
2108
2109
2110
2111
2112
2113
2012-04-03  Simon Fraser  <simon.fraser@apple.com>

        WebKitTestRunner's EventSender is leaky
        https://bugs.webkit.org/show_bug.cgi?id=83099

        Reviewed by Beth Dakin.
        
        Fix leaks of WKNumbers by using the adoptWK idiom, and make
        all the code consistent.

        * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
        (WTR::EventSendingController::mouseDown):
        (WTR::EventSendingController::mouseUp):
        (WTR::EventSendingController::mouseMoveTo):
        (WTR::EventSendingController::leapForward):
        (WTR::EventSendingController::keyDown):
        (WTR::EventSendingController::mouseScrollBy):
        (WTR::EventSendingController::addTouchPoint):
        (WTR::EventSendingController::updateTouchPoint):
        (WTR::EventSendingController::setTouchModifier):
        (WTR::EventSendingController::releaseTouchPoint):
        (WTR::EventSendingController::cancelTouchPoint):

2114
2115
2116
2117
2118
2119
2120
2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>

        Another build fix. Don't use old-run-webkit-tests on Chromium Windows bots.

        * Scripts/run-webkit-tests:
        (useNewRunWebKitTests):

2121
2122
2123
2124
2125
2126
2127
2128
2129
2130
2131
2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>

        kill-old-processes should kill apache2 and httpd
        https://bugs.webkit.org/show_bug.cgi?id=83065

        Reviewed by Tony Chang.

        Kill apache2 and httpd on Mac and Linux (Windows uses lighttpd) to free up port 8000.

        * BuildSlaveSupport/kill-old-processes:

2132
2133
2134
2135
2136
2137
2138
2139
2140
2141
2012-04-03  Tony Chang  <tony@chromium.org>

        run the same test steps on test only bots as on build-and-test bots
        https://bugs.webkit.org/show_bug.cgi?id=83090

        Reviewed by Ryosuke Niwa.

        * BuildSlaveSupport/build.webkit.org-config/master.cfg:
        (TestFactory.__init__):

fischman@chromium.org's avatar
fischman@chromium.org committed
2142
2143
2144
2145
2146
2147
2148
2149
2150
2012-04-03  Ami Fischman  <fischman@chromium.org>

        Add a Media watchlist.
        https://bugs.webkit.org/show_bug.cgi?id=83071

        Reviewed by David Levin.

        * Scripts/webkitpy/common/config/watchlist:

2151
2152
2153
2154
2155
2156
2157
2158
2159
2160
2161
2162
2163
2164
2165
2166
2012-04-03  Simon Fraser  <simon.fraser@apple.com>

        Fix large leak in WebKitTestRunner
        https://bugs.webkit.org/show_bug.cgi?id=83084

        Reviewed by Beth Dakin.
        
        Fix a leak of the bimap backing store created when doing pixel and
        ref tests. This leak was causing serious thrash on the test bots.
        
        We don't need to allocate memory for CGBitmapContextCreate(); if we
        pass NULL, it will allocate and manage its own backing store.

        * WebKitTestRunner/cg/TestInvocationCG.cpp:
        (WTR::createCGContextFromImage):

2167
2168
2169
2170
2171
2172
2173
2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>

        Another build fix after r113067. Close the zipfile after extracting all files so that we can remove it.

        * BuildSlaveSupport/built-product-archive:
        (unzipArchive):

2174
2175
2176
2177
2178
2179
2180
2181
2182
2183
2184
2185
2186
2012-04-03  Ojan Vafai  <ojan@chromium.org>

        Give more human friendly error message when builders fail to load or have stale data.
        https://bugs.webkit.org/show_bug.cgi?id=83058

        Reviewed by Eric Seidel.

        * TestResultServer/static-dashboards/dashboard_base.js:
        (addError):
        (addBuilderLoadErrors):
        (handleLocationChange):
        * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:

2187
2188
2189
2190
2191
2192
2193
2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>

        Again, a build fix after r113067. Don't call r113067 twice on the configuration build directory.

        * BuildSlaveSupport/built-product-archive:
        (extractBuiltProduct):

2194
2195
2196
2197
2198
2199
2200
2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>

        Yet another build fix after r113067. Don't trigger Chromium testers right away
        since they're now triggered by builders.

        * BuildSlaveSupport/build.webkit.org-config/config.json:

2201
2202
2203
2204
2205
2206
2207
2208
2209
2210
2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>

        Another build fix after r113067 for Mac port.
        It turned out that archiving the entire build directory doesn't work.

        * BuildSlaveSupport/built-product-archive:
        (createZipManually):
        (createZip):
        (archiveBuiltProduct):

2211
2212
2213
2214
2215
2216
2217
2218
2219
2220
2221
2222
2223
2224
2225
2012-04-03  Mike Lattanzio  <mlattanzio@rim.com>

        [BlackBerry] Expose CaseSensitive, Wrap, and HighlightAllMatches in WebPage::findNextString()
        https://bugs.webkit.org/show_bug.cgi?id=82643

        Update LayoutTestController to accomodate the new find API.
        It now provides caseSensitive functionality to DRT.

        Internal Review by Andy Chen.

        Reviewed by Rob Buis.

        * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
        (LayoutTestController::findString):

2226
2227
2228
2229
2230
2231
2232
2233
2234
2235
2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>

        Another build fix after r113067. CreateWebKitBuildDirectory step is no longer needed
        because download-built-product creates the build directory as needed.

        This step fails on Chromium Windows due to -p option not supported by Windows' native mkdir.

        * BuildSlaveSupport/build.webkit.org-config/master.cfg:
        (TestFactory.__init__):

2236
2237
2238
2239
2240
2241
2242
2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>

        Build fix after r113067. Don't delete the build directory.

        * BuildSlaveSupport/built-product-archive:
        (extractBuiltProduct):

2243
2244
2245
2246
2247
2248
2249
2250
2251
2252
2253
2254
2255
2256
2257
2258
2259
2260
2261
2262
2263
2264
2265
2266
2267
2268
2269
2270
2271
2272
2273
2274
2275
2276
2277
2012-04-02  Ojan Vafai  <ojan@chromium.org>

        Load all builder lists from the buildbot json
        https://bugs.webkit.org/show_bug.cgi?id=82998

        Reviewed by Adam Barth.

        Also, remove an unnecessary list of test types. Now we don't hard-code
        builder names anywhere and we only have a single hard-coded list of
        test types.

        * TestResultServer/static-dashboards/builders.js:
        (BuilderMaster.prototype.logPath):
        (BuilderMaster.prototype.builderJsonPath):
        (requestBuilderList.xhr.onload):
        (requestBuilderList.xhr.onerror):
        (isChromiumDepsFyiGpuTestRunner):
        (isChromiumTipOfTreeGpuTestRunner):
        (isChromiumDepsGTestRunner):
        (isChromiumDepsCrosGTestRunner):
        (isChromiumTipOfTreeGTestRunner):
        (onBuilderListLoad):
        (loadBuildersList):
        * TestResultServer/static-dashboards/dashboard_base.js:
        (parseCrossDashboardParameters):
        (currentBuilderGroupCategory):
        * TestResultServer/static-dashboards/flakiness_dashboard.html:
        * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
        (testHtmlForTestsWithExpectationsButNoFailures):
        (testGenerateChromiumTipOfTreeGpuBuildersFromBuilderList):
        (testGenerateChromiumDepsGTestBuildersFromBuilderList):
        (testGenerateChromiumDepsCrosGTestBuildersFromBuilderList):
        (testGenerateChromiumTipOfTreeGTestBuildersFromBuilderList):
        * TestResultServer/static-dashboards/timeline_explorer.html:

2278
2279
2280
2281
2282
2283
2284
2285
2286
2287
2288
2289
2290
2291
2292
2293
2294
2295
2296
2297
2298
2299
2300
2301
2302
2012-04-02  Ryosuke Niwa  <rniwa@webkit.org>

        Chromium testers should extract builds instead of building on their own
        https://bugs.webkit.org/show_bug.cgi?id=82996

        Reviewed by Tony Chang.

        Make Chromium builders triggger Chromium testers and make testers download and extract builds
        from the buildbot master instead of building binaries on their own.

        Add download-built-product to wrap curl used in the download-built-product step since Windows
        does not provide "curl" natively.

        * BuildSlaveSupport/build.webkit.org-config/config.json: Add new triggerables for Chromium testers and make
        Chromium builders trigger them. Also change the type of Chromium testers from NewBuildAndTest to Test.
        * BuildSlaveSupport/build.webkit.org-config/master.cfg:
        (DownloadBuiltProduct): Call download-built-product instead of curl.
        * BuildSlaveSupport/built-product-archive:
        (createZip): Don't zip the parent configuration build directory like "release" and "debug". While Mac port
        needs this behavior for compatibility reasons, Chromium Mac port doesn't want this behavior.
        (archiveBuiltProduct): Zip the configuration build directory on Mac port.
        (unzipArchive): Extracted. Use ditto on Mac, unzip on linux and cygwin, and zipfile package on Windows.
        (extractBuiltProduct): Refactor the code to use removeDirectoryIfExists and unzipArchive. Support Chromium.
        * BuildSlaveSupport/download-built-product: Added to wrap curl which isn't available on Windows.

2303
2304
2305
2306
2307
2308
2309
2310
2311
2312
2313
2314
2315
2012-04-03  Martin Robinson  <mrobinson@igalia.com>

        [GTK] Tools/Scripts/run-gtk-tests should not force you to use the WebKit jhbuild
        https://bugs.webkit.org/show_bug.cgi?id=82473

        Reviewed by Philippe Normand.

        Only use jhbuild if WebKitBuild/Dependencies exists (if update-webkitgtk-libs)
        was ever run.

        * gtk/run-with-jhbuild: Instead of using jhbuild unconditionally, first
        check if the user has ever run update-gtk-libs and, if so, then use jhbuild.

2316
2317
2318
2319
2320
2321
2322
2323
2324
2325
2326
2327
2328
2012-04-03  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>

        [EFL] DRT support for setInteractiveFormValidationEnabled
        https://bugs.webkit.org/show_bug.cgi?id=82050

        Enable interactive form validation and unskip tests from the
        skip list.

        Reviewed by Antonio Gomes.

        * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
        (DumpRenderTreeChrome::resetDefaultsToConsistentValues):

2329
2330
2331
2332
2333
2334
2335
2012-04-03  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, another test-webkitpy fix-up after r113037.

        * Scripts/webkitpy/layout_tests/port/gtk_unittest.py: Adapt mock
        crash dump depending on current environment.

2336
2337
2338
2339
2340
2341
2342
2012-04-03  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, test-webkitpy build fix after r113037.

        * Scripts/webkitpy/layout_tests/port/gtk.py:
        (GtkPort._get_crash_log):

2343
2344
2345
2346
2347
2348
2349
2350
2351
2352
2353
2354
2355
2356
2357
2358
2359
2360
2361
2362
2363
2364
2365
2366
2367
2368
2369
2370
2371
2372
2373
2374
2375
2376
2377
2378
2012-04-03  Philippe Normand  <pnormand@igalia.com>

        [GTK] crash log reports support
        https://bugs.webkit.org/show_bug.cgi?id=81659

        Reviewed by Martin Robinson.

        Removed the daemontools crashmon/xvfb scripts and implemented the crash
        log reporting in the NRWT Gtk port. To get proper crash logs one
        needs to set the core pattern like this:
        echo "/path/to/cores/core-pid_%p-_-process_%e" > /proc/sys/kernel/core_pattern
        Then enable coredumps with "ulimit -c unlimited" and set the WEBKIT_CORE_DUMPS_DIRECTORY
        environment variable.

        * BuildSlaveSupport/gtk/README:
        * BuildSlaveSupport/gtk/crashmon/crashmon: Removed.
        * BuildSlaveSupport/gtk/crashmon/log/run: Removed.
        * BuildSlaveSupport/gtk/crashmon/run: Removed.
        * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
        * BuildSlaveSupport/gtk/xvfb/log/run: Removed.
        * BuildSlaveSupport/gtk/xvfb/run: Removed.
        * Scripts/new-run-webkit-tests:
        * Scripts/webkitpy/layout_tests/port/gtk.py:
        (GtkDriver.stop):
        (GtkPort.show_results_html_file):
        (GtkPort):
        (GtkPort._get_gdb_output):
        (GtkPort._get_crash_log):
        (GtkPort._get_crash_log.match_filename):
        * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
        (GtkPortTest):
        (test_show_results_html_file):
        (assertLinesEqual):
        (_mock_gdb_output):
        (test_get_crash_log):

2379
2380
2381
2382
2383
2384
2385
2386
2387
2388
2389
2012-04-02  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>

        Enable and connect the WebInspectorServer with WebKit2 pages.
        https://bugs.webkit.org/show_bug.cgi?id=73094

        Reviewed by Simon Hausmann.

        Enable developer extras on pages in MiniBrowser for Qt.

        * MiniBrowser/qt/qml/BrowserWindow.qml:

2390
2391
2392
2393
2394
2395
2396
2397
2398
2399
2400
2401
2402
2012-04-03  Christophe Dumez  <christophe.dumez@intel.com>

        [EFL] LayoutTestController needs implementation of setDefersLoading
        https://bugs.webkit.org/show_bug.cgi?id=82890

        Reviewed by Philippe Normand.

        Implement setDefersLoading() in EFL's LayoutTestController so that the
        corresponding test case can be removed from the skip list.

        * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
        (LayoutTestController::setDefersLoading):

2403
2404
2405
2406
2407
2408
2409
2410
2411
2412
2413
2414
2415
2012-04-03  Christophe Dumez  <christophe.dumez@intel.com>

        [EFL] LayoutTestController needs implementation of goBack
        https://bugs.webkit.org/show_bug.cgi?id=81914

        Reviewed by Philippe Normand.

        Implement goBack() in EFL's LayoutTestController by calling
        ewk_frame_back().

        * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
        (LayoutTestController::goBack):

2416
2417
2418
2419
2420
2421
2422
2423
2424
2425
2426
2427
2428
2012-04-03  Alexander Shalamov  <alexander.shalamov@intel.com>

        [EFL] LayoutTestController needs implementation of pageSizeAndMarginsInPixels
        https://bugs.webkit.org/show_bug.cgi?id=82589

        Add missing implementation for pageSizeAndMarginsInPixels to EFL's LayoutTestController
        in order to unskip printing/page-format-data.html

        Reviewed by Philippe Normand.

        * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
        (LayoutTestController::pageSizeAndMarginsInPixels):

2429
2430
2431
2432
2433
2434
2435
2436
2437
2438
2439
2440
2441
2442
2443
2444
2445
2446
2447
2012-04-03  Simon Pena  <spena@igalia.com>

        [GTK] DRT missing didRunInsecureContent notification
        https://bugs.webkit.org/show_bug.cgi?id=59367

        Reviewed by Philippe Normand.

        Connect DumpRenderTree to WebFrame's "insecure-content-run", in both
        the main WebFrame or any other WebFrame created later. Added
        "didRunInsecureContent" notification in the callback in order to
        get the LayoutTests passing.

        * DumpRenderTree/gtk/DumpRenderTree.cpp: Connect
        to WebFrame's "insecure-content-run" signal and add
        didRunInsecureContent notification in the callback to get the
        LayoutTests passing.
        (didRunInsecureContent):
        (createWebView):

2448
2449
2450
2451
2452
2453
2454
2455
2456
2457
2458
2459
2460
2461
2462
2463
2012-04-03  Raphael Kubo da Costa  <rakuco@FreeBSD.org>

        rebaseline-server: Make it possible to not launch a browser with the server.
        https://bugs.webkit.org/show_bug.cgi?id=82999

        Reviewed by Adam Barth.

        Add the `--no-show-results' option, which lets one decide not to
        launch a web browser when running the rebaseline server.  This is
        especially useful if the default browser is not the wanted one, or
        if the rebaseline server page is already open.

        * Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
        (AbstractLocalServerCommand.__init__):
        (AbstractLocalServerCommand.execute):

2464
2465
2466
2467
2468
2469
2470
2471
2472
2473
2474
2475
2012-04-02  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>

        EFL's LayoutTestController disableImageLoading implementation.
        https://bugs.webkit.org/show_bug.cgi?id=82848

        Reviewed by Hajime Morita.

        * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
        (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
        * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
        (LayoutTestController::disableImageLoading):

2476
2477
2478
2479
2480
2481
2482
2483
2484
2485
2486
2487
2488
2012-04-02  Alexander Shalamov  <alexander.shalamov@intel.com>

        [EFL] LayoutTestController needs implementation of isPageBoxVisible
        https://bugs.webkit.org/show_bug.cgi?id=82591

        Add missing implementation to isPageBoxVisible to EFL's LayoutTestController
        in order to unskip printing/page-format-data.html

        Reviewed by Hajime Morita.

        * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
        (LayoutTestController::isPageBoxVisible):

2489
2490
2491
2492
2493
2494
2495
2496
2497
2498
2499
2500
2501
2502
2503
2504
2505
2506
2507
2508
2509
2012-04-02  Simon Fraser  <simon.fraser@apple.com>

        run-webkit-tests with a relative --root causes tests to fail because DYLD_LIBRARY_PATH is not set
        https://bugs.webkit.org/show_bug.cgi?id=82962

        Reviewed by Dirk Pranke.

        Ensure that _build_path() returns an absolute path.

        Eric Seidel also had to deploy MockConfig in a bunch of places
        in order to correct previous testing errors where we were
        pretending that "Mock Output from child process" (returned by MockExecutive.run_command)
        was a real path.  The real Config object calls run_command("webkit-build-directory")
        to read the WebKit build directory from the webkitdirs.pm perl code.
        MockConfig abstracts this away and always returns "/mock-build" during
        testing.  This change is much larger than one would think necessary
        because of needing to deploy this MockConfig class.

        * Scripts/webkitpy/layout_tests/port/webkit.py:
        (WebKitPort._build_path):

2510
2511
2512
2513
2514
2515
2012-04-02  Ojan Vafai  <ojan@chromium.org>

        Fix snafu in r112971. We were never calling parseParameter for builder.

        * TestResultServer/static-dashboards/dashboard_base.js:

2516
2517
2518
2519
2520
2521
2522
2523
2524
2525
2526
2527
2528
2529
2530
2531
2532
2533
2534
2535
2536
2537
2538
2539
2540
2541
2542
2543
2544
2545
2546
2547
2548
2549
2550
2551
2552
2553
2554
2555
2556
2557
2558
2559
2560
2561
2562
2563
2564
2565
2566
2567
2568
2569
2570
2571
2572
2573
2574
2575
2576
2577
2578
2579
2580
2581
2582
2583
2584
2585
2586
2587
2588
2589
2590
2591
2592
2593
2012-04-02  Ojan Vafai  <ojan@chromium.org>

        Generate the lists of all layout test builders from the buildbot json
        https://bugs.webkit.org/show_bug.cgi?id=82924

        Reviewed by Mihai Parparita.

        In order to make this work, cleaned up a lot of existing technical debt.
        -Got rid of expectations builder. This concept is outdated and just dead code.
        -Split hash parameter parsing into two functions. One for dashboard_base
        (crossDashboardParameters) and one for the specific dashboard html file
        (dashboardSpecificParameters). In the old world, parseParameters needed to
        be called twice and depended on it's own output the first time through.
        Now we only need to parse crossDashboardParameters first and crossDashboardParameters
        doesn't depend on the output of crossDashboardParameters.
        -Lots of variable/method renames due to the above.
        -g_defaultDashboardSpecificStateValues now has to list all possible hash parameters
        for that dashboard.

        * TestResultServer/static-dashboards/aggregate_results.html:
        * TestResultServer/static-dashboards/builders.js:
        (BuilderGroup):
        (BuilderGroup.prototype.setup):
        (jsonRequest.xhr.onload):
        (jsonRequest.xhr.onerror):
        (isWebkitTestRunner):
        (isChromiumWebkitTipOfTreeTestRunner):
        (isChromiumWebkitDepsTestRunner):
        (generateBuildersFromBuilderList):
        (onLayoutTestBuilderListLoad):
        (onErrorLoadingBuilderList):
        (loadBuildersList):
        * TestResultServer/static-dashboards/dashboard_base.js:
        (handleValidHashParameterWrapper):
        (queryHashAsMap):
        (parseParameter):
        (parseCrossDashboardParameters):
        (parseDashboardSpecificParameters):
        (parseParameters):
        (diffStates):
        (defaultValue):
        (isLayoutTestResults):
        (isGPUTestResults):
        (currentBuilderGroupCategory):
        (currentBuilderGroup):
        (initBuilders):
        Now that we've split parameter parseing, these methods no longer need
        to take an optional state. They can always just use the global cross-dashboard state.

        (pathToBuilderResultsFile):
        (appendJSONScriptElementFor):
        (appendJSONScriptElements):
        (handleResourceLoadError):
        (haveJsonFilesLoaded):
        (combinedDashboardState):
        (setQueryParameter):
        (permaLinkURLHash):
        (toggleQueryParameter):
        (queryParameterValue):
        (selectHTML):
        (htmlForTestTypeSwitcher):
        (g_handleBuildersListLoaded):
        * TestResultServer/static-dashboards/flakiness_dashboard.html:
        * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
        (testPlatformAndBuildType):
        (testSubstringList):
        (testHtmlForTestTypeSwitcherGroup):
        (testLookupVirtualTestSuite):
        (testBaseTest):
        (generateBuildersFromBuilderListHelper):
        (testGenerateChromiumWebkitTipOfTreeBuildersFromBuilderList):
        (testGenerateChromiumWebkitDepsBuildersFromBuilderList):
        (assertObjectsDeepEqual):
        (testQueryHashAsMap):
        (testDiffStates):
        * TestResultServer/static-dashboards/timeline_explorer.html:
        * TestResultServer/static-dashboards/treemap.html:

2594
2595
2596
2597
2598
2599
2600
2601
2602
2603
2604
2605
2012-04-02  Tony Chang  <tony@chromium.org>

        check-webkit-style errors when removing .png files
        https://bugs.webkit.org/show_bug.cgi?id=82933

        Reviewed by David Levin.

        * Scripts/webkitpy/style/patchreader.py:
        (PatchReader.check): Make sure the file exists and pass in a FileSystem() object (for mocking).
        * Scripts/webkitpy/style/patchreader_unittest.py:
        (test_check_patch_with_png_deletion):

2606
2607
2608
2609
2610
2611
2612
2613
2614
2615
2616
2617
2012-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r112948.
        http://trac.webkit.org/changeset/112948
        https://bugs.webkit.org/show_bug.cgi?id=82961

        Someone else already checked in a similar change (Requested by
        sundiamonde on #webkit).

        * Scripts/webkitpy/layout_tests/port/webkit.py:
        (WebKitDriver._start):

2618
2619
2620
2621
2622
2623
2624
2625
2626
2627
2628
2629
2630
2631
2012-04-02  Adam Barth  <abarth@webkit.org>

        garden-o-matic isn't able to rebaseline audio failures
        https://bugs.webkit.org/show_bug.cgi?id=82957

        Reviewed by Chris Rogers.

        This patch just adds "wav" to the list of test suffixes and updates the
        unit tests to show that we're rebaselining audio tests results now too.

        * Scripts/webkitpy/tool/commands/rebaseline.py:
        * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
        (test_rebaseline_updates_expectations_file):

2632
2633
2634
2635
2636
2637
2638
2639
2640
2641
2642
2643
2644
2645
2646
2647
2012-04-02  Adam Barth  <abarth@webkit.org>

        garden-o-matic should let you listen to audio failures
        https://bugs.webkit.org/show_bug.cgi?id=82953

        Reviewed by Chris Rogers.

        Now that we've actually got an audio failure on the bots, we can clean
        up the last stray bugs.  This patch doesn't have any tests because I'm
        lame.

        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
        (.):

2648
2649
2650
2651
2652
2653
2654
2655
2656
2657
2658
2659
2012-04-02  Stephanie Lewis  <slewis@apple.com>

        run-webkit-tests --root fails if /usr/local/lib/libWebCoreTestSupport.dylib is not installed.
        https://bugs.webkit.org/show_bug.cgi?id=82552

        Reviewed by Dirk Pranke.

        Use DYLD_LIBRARY_PATH so we pick up the libWebCoreTestSupport.dylib located in the root.

        * Scripts/webkitpy/layout_tests/port/webkit.py:
        (WebKitDriver._start):

2660
2661
2662
2663
2664
2665
2666
2667
2668
2669
2670
2671
2672
2673
2674
2675
2012-04-02  Dirk Pranke  <dpranke@chromium.org>

        NRWT is not printing out the builder it's uploading JSON files for
        https://bugs.webkit.org/show_bug.cgi?id=82834

        Reviewed by Ojan Vafai.

        Handle log messages of the form log.info("%s", arg) properly ...
        I didn't even know you could do that :).

        * Scripts/webkitpy/layout_tests/views/metered_stream.py:
        (_LogHandler.emit):
        * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
        (RegularTest.test_log_args):
        (VerboseTest.test_log_args):

2676
2677
2678
2679
2680
2681
2682
2683
2684
2685
2686
2687
2688
2689
2012-04-02  Tim Horton  <timothy_horton@apple.com>

        [mac] LayoutTestHelper crashes if there is no main display
        https://bugs.webkit.org/show_bug.cgi?id=82944
        <rdar://problem/11162954>

        Reviewed by Simon Fraser.

        If there's no main display attached, ColorSyncDeviceCopyDeviceInfo returns
        a null dictionary, so we shouldn't go ahead and try to read from it.

        * DumpRenderTree/mac/LayoutTestHelper.m:
        (installLayoutTestColorProfile):

2690
2691
2692
2693
2694
2695
2696
2697
2698
2699
2012-04-02  Balazs Kelemen  <kbalazs@webkit.org>

        [Qt][WK2] Set up plugin process on Unix
        https://bugs.webkit.org/show_bug.cgi?id=72121

        Reviewed by Simon Hausmann.

        * qmake/mkspecs/features/features.prf: Reenable plugins
        and turn on plugin process.

2700
2701
2702
2703
2704
2705
2706
2707
2708
2709
2710
2711
2712
2012-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r112868, r112879, and r112881.
        http://trac.webkit.org/changeset/112868
        http://trac.webkit.org/changeset/112879
        http://trac.webkit.org/changeset/112881
        https://bugs.webkit.org/show_bug.cgi?id=82901

        "Build fail on bots." (Requested by kbalazs on #webkit).

        * MiniBrowser/gtk/GNUmakefile.am:
        * qmake/mkspecs/features/features.prf:

2713
2714
2715
2716
2717
2718
2719
2720
2721
2012-04-02  Philippe Normand  <pnormand@igalia.com>

        [GTK] Enable shadow-dom in build-webkit.

        Rubber-stamped by Gustavo Noronha Silva.

        * Scripts/build-webkit: Enable shadow-dom build, this is need to
        have a working build currently.

2722
2723
2724
2725
2726
2727
2012-04-02  Andreas Kling  <kling@webkit.org>

        Adding Zalan Bujtas to committers list.

        * Scripts/webkitpy/common/config/committers.py:

2728
2729
2730
2731
2732
2733
2734
2735
2736
2737
2012-04-02  Balazs Kelemen  <kbalazs@webkit.org>

        [Qt][WK2] Set up plugin process on Unix
        https://bugs.webkit.org/show_bug.cgi?id=72121

        Reviewed by Simon Hausmann.

        * qmake/mkspecs/features/features.prf: Reenable plugins
        and turn on plugin process.

2738
2739
2740
2741
2742
2743
2744
2745
2746
2747
2748
2749
2750
2751
2752
2012-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r112651.
        http://trac.webkit.org/changeset/112651
        https://bugs.webkit.org/show_bug.cgi?id=82887

        It doesn't work with older Qt5 (Requested by Ossy on #webkit).

        * MiniBrowser/qt/BrowserWindow.cpp:
        (BrowserWindow::updateVisualMockTouchPoints):
        * MiniBrowser/qt/main.cpp:
        * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
        (WTR::WrapperWindow::handleStatusChanged):
        * qmake/mkspecs/features/unix/default_post.prf:

2753
2754
2755
2756
2757
2758
2759
2760
2761
2762
2763
2012-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>

        [GTK] Fix names of failed unit tests in Tools/Scripts/run-gtk-tests
        https://bugs.webkit.org/show_bug.cgi?id=82877

        Reviewed by Philippe Normand.

        * Scripts/run-gtk-tests:
        (TestRunner.run_tests): Use replace instead of lstrip to remove
        the programs_path from the full path of unit tests.

2764
2765
2766
2767
2768
2769
2770
2012-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>

        Unreviewed. Skip flaky unit tests.

        * Scripts/run-gtk-tests:
        (TestRunner):